10 months agocondition_list_free(): Fix a memory leak.
Uwe Hermann [Sat, 16 Nov 2019 21:49:30 +0000 (22:49 +0100)]
condition_list_free(): Fix a memory leak.

10 months agouart: Add [rx|tx]_packet_len options.
Uwe Hermann [Tue, 12 Nov 2019 21:20:45 +0000 (22:20 +0100)]
uart: Add [rx|tx]_packet_len options.

Similar to the recently added [rx|tx]_packet_delimiter options, these
emit summary annotations ("packets") when a certain number of data values
have been decoded.

This is a convenience feature which can be useful when a user wants to
view data which doesn't have a specified delimiter value (as last data
value in the "packet"), but rather fixed-length "packets".

This is just an (intentionally very simple) helper/convenience improvement
and is NOT meant to replace "proper" stacked decoders for UART-based protocols.

10 months agouart: Add [rx|tx]_packet_delimiter options.
Uwe Hermann [Tue, 12 Nov 2019 21:03:21 +0000 (22:03 +0100)]
uart: Add [rx|tx]_packet_delimiter options.

This is a convenience feature that emits summary annotations ("packets")
that comprise all data values that were decoded until a specified delimiter
value is seen (as last data value of the "packet").

Example use-cases include ASCII data where it can be convenient to
"packetize" whenever a 10/0x0A value (newline) is seen, or some
protocols which have a fixed "marker" value (e.g. 0x55) as last
value in the "packet".

The annotations are affected by the selected 'format' option, i.e. the
user can get summaries in ASCII or hex or other formats.

This is just an (intentionally very simple) helper/convenience improvement
and is NOT meant to replace "proper" stacked decoders for UART-based protocols.

10 months Add support for Python 3.8.
Uwe Hermann [Tue, 12 Nov 2019 20:58:23 +0000 (21:58 +0100)] Add support for Python 3.8.

This fixes bug #1438.

10 months agoeeprom93xx: Use fixed-width hex output.
Uwe Hermann [Sat, 9 Nov 2019 14:48:36 +0000 (15:48 +0100)]
eeprom93xx: Use fixed-width hex output.

This improves readability a bit in most cases.

10 months agoeeprom93xx: Add OUTPUT_BINARY support.
Uwe Hermann [Sat, 9 Nov 2019 14:25:47 +0000 (15:25 +0100)]
eeprom93xx: Add OUTPUT_BINARY support.

10 months agoseven_segment: Simplify two code snippets.
Uwe Hermann [Wed, 6 Nov 2019 22:41:48 +0000 (23:41 +0100)]
seven_segment: Simplify two code snippets.

10 months agoseven_segment: Initial commit.
Benedikt Otto [Sun, 6 Oct 2019 09:18:51 +0000 (11:18 +0200)]
seven_segment: Initial commit.

10 months agospiflash: Add "EEPROM" to descriptions.
Uwe Hermann [Tue, 5 Nov 2019 21:34:44 +0000 (22:34 +0100)]
spiflash: Add "EEPROM" to descriptions.

There are various different names that these types of memories are being
referred to in the wild: SPI flash, flash chip, flash, flash EEPROM,
SPI EEPROM, serial flash, serial memory, flash memory, and various others.

In order to make UI decoder selection more useful to the user, we add
the "EEPROM" string to some of the decoder metadata fields, so the
decoder will (for example) show up in PulseView's list of decoders when
the user types "eeprom" to narrow down the listed decoders.

10 months agocan: Mention CAN-FD support in the description.
Uwe Hermann [Tue, 5 Nov 2019 21:23:23 +0000 (22:23 +0100)]
can: Mention CAN-FD support in the description.

11 months agocan: Factor out dlc2len().
Uwe Hermann [Mon, 8 Jul 2019 09:10:46 +0000 (11:10 +0200)]
can: Factor out dlc2len().

11 months agocan: Random whitespace and cosmetic fixes.
Uwe Hermann [Mon, 8 Jul 2019 08:35:42 +0000 (10:35 +0200)]
can: Random whitespace and cosmetic fixes.

11 months agocan: introduce fast bitrate
Stephan Thiele [Wed, 17 Apr 2019 18:04:22 +0000 (20:04 +0200)]
can: introduce fast bitrate

11 months agocan: proper annotation on CAN-FD extended frames
stephan.thiele [Thu, 28 Feb 2019 20:33:56 +0000 (21:33 +0100)]
can: proper annotation on CAN-FD extended frames

11 months agocan: add basic CAN-FD handling of non BRS extended frames
stephan.thiele [Wed, 27 Feb 2019 23:55:25 +0000 (00:55 +0100)]
can: add basic CAN-FD handling of non BRS extended frames

11 months agocan: make PD temporary compatible to existing tests
Stephan Thiele [Fri, 22 Feb 2019 21:05:04 +0000 (22:05 +0100)]
can: make PD temporary compatible to existing tests

11 months agocan: correct decoding of CRC-21
Stephan Thiele [Fri, 22 Feb 2019 18:57:56 +0000 (19:57 +0100)]
can: correct decoding of CRC-21

12 months agocan: decode CAN-FD DLC
Stephan Thiele [Fri, 22 Feb 2019 18:50:03 +0000 (19:50 +0100)]
can: decode CAN-FD DLC

12 months agocan: display CRC type + correct decoding of CRC-17
Stephan Thiele [Fri, 22 Feb 2019 18:29:53 +0000 (19:29 +0100)]
can: display CRC type + correct decoding of CRC-17

12 months agocan: implement decoding of CAN-FD header when FDF bit is set
Stephan Thiele [Wed, 20 Feb 2019 22:36:18 +0000 (23:36 +0100)]
can: implement decoding of CAN-FD header when FDF bit is set

12 months agocan: implement basic CAN-FD decoding (SRR and FDF bits)
Stephan Thiele [Thu, 10 Jan 2019 22:59:27 +0000 (23:59 +0100)]
can: implement basic CAN-FD decoding (SRR and FDF bits)

12 months agoeeprom93xx: Add ascii format support
Sylvain Pelissier [Fri, 19 Jul 2019 12:32:01 +0000 (14:32 +0200)]
eeprom93xx: Add ascii format support

12 months agomrf24j40: Add TX retries/fails and CCAFAIL support.
Uwe Hermann [Tue, 6 Aug 2019 19:42:07 +0000 (21:42 +0200)]
mrf24j40: Add TX retries/fails and CCAFAIL support.

13 months agomrf24j40: Add RX/TX frame annotations.
Uwe Hermann [Wed, 31 Jul 2019 19:40:07 +0000 (21:40 +0200)]
mrf24j40: Add RX/TX frame annotations.

14 months agopca9571: Shorten names a bit.
Uwe Hermann [Sat, 6 Jul 2019 13:33:43 +0000 (15:33 +0200)]
pca9571: Shorten names a bit.

14 months agoAdd an NXP PCA9571 decoder.
Mickael Bosch [Tue, 2 Jul 2019 14:31:12 +0000 (16:31 +0200)]
Add an NXP PCA9571 decoder.

14 months agomodbus: Make the 'framegap' option an integer.
Uwe Hermann [Sun, 30 Jun 2019 22:27:17 +0000 (00:27 +0200)]
modbus: Make the 'framegap' option an integer.

14 months agomodbus: Make C->S and S->C configurable, add framegap option.
Andrew Gregory [Wed, 5 Dec 2018 15:31:34 +0000 (23:31 +0800)]
modbus: Make C->S and S->C configurable, add framegap option.

Change client->server and server->client to be separately configurable,
allowing decoding at both the server (where client->server is RX and
server->client is TX) and client (where client->server is TX and
server->client is RX) ends of the link. It also allows monitoring of the
bus on a single channel (where client->server and server->client are both
RX (or TX)).

When I tried to decode a bus capture, I found that when the transmitter was
turned off it generated a false start bit, which in turn resulted in a false
trailing byte from the UART decoder. This narrowed the inter-frame gap to
the point where the Modbus decoder failed to recognise a new frame. The
result was only the first frame of the capture decoded - all the rest of the
frames failed to decode. I had to reduce the frame gap to allow subsequent
frames to decode, and so made it a configurable option that defaults to the
existing gap.

Lastly, I fixed a call to puti() that incorrectly included the annotation

14 months agosdcard_spi: Add "Card is busy" annotations for CMD24.
Pierre Poulain [Tue, 16 Apr 2019 17:56:54 +0000 (19:56 +0200)]
sdcard_spi: Add "Card is busy" annotations for CMD24.

This fixes bug #1376.

14 months agosdcard_spi: Fix incorrect handling of CMD17.
Pierre Poulain [Tue, 16 Apr 2019 18:48:11 +0000 (20:48 +0200)]
sdcard_spi: Fix incorrect handling of CMD17.

This fixes bug #1377.

15 months agousb_request: Allow configuration of BULK IN transfer display
Stefan Brüns [Mon, 17 Jun 2019 18:01:58 +0000 (20:01 +0200)]
usb_request: Allow configuration of BULK IN transfer display

From a protocol level, a BULK IN transfer starts when the host starts
polling the respective endpoint. For analysis, it is sometimes useful
to show when the devices starts to answer the requests.

As both are useful for different use cases (the old, default one emphasizes
the host behavior, the new one shows the endpoint/device behavior), make
the display configurable.

15 months agousb_request: Use separate annotation rows for IN, OUT and CONTROL
Stefan Brüns [Mon, 17 Jun 2019 17:56:51 +0000 (19:56 +0200)]
usb_request: Use separate annotation rows for IN, OUT and CONTROL

E.g. CONTROL and BULK IN transfers may overlap each other, and as a result
only one of the two can be seen in pulseview.

Partly solves bug #1046. In case a device has multiple IN/OUT endpoints,
transfers would still overlap, but many simple devices have just one each.

15 months agousb_request: Fix some decoding errors
Stefan Brüns [Mon, 17 Jun 2019 17:51:29 +0000 (19:51 +0200)]
usb_request: Fix some decoding errors

Append OUT data only if it has been ACKed. OUT transfers (BULK OUT or
CONTROL transfer DATA stage) are typically NACKed to create backpressure.

Always keep IN and OUT transfers separate. On the physical layer, the
endpoint number only uses 4 bits, and IN and OUT use separate tokens.
In case the transfer is an IN transfer, set the high bit as used in the
endpoint descriptors (i.e. 0x81 is IN enpoint 1, 0x01 is OUT endpoint 1).

16 months agoenc28j60: Rename self.ann to self.out_ann.
Uwe Hermann [Tue, 14 May 2019 23:28:53 +0000 (01:28 +0200)]
enc28j60: Rename self.ann to self.out_ann.

(for consistency with all other decoders)

16 months agoenc28j60: Shorten various self.put*() calls.
Uwe Hermann [Tue, 14 May 2019 23:26:02 +0000 (01:26 +0200)]
enc28j60: Shorten various self.put*() calls.

16 months agoenc28j60: Factor out self.putr().
Uwe Hermann [Tue, 14 May 2019 23:21:24 +0000 (01:21 +0200)]
enc28j60: Factor out self.putr().

16 months agoenc28j60: Factor out self.putc().
Uwe Hermann [Tue, 14 May 2019 23:16:52 +0000 (01:16 +0200)]
enc28j60: Factor out self.putc().

16 months agoenc28j60: Use the common ss/es abbreviations.
Uwe Hermann [Tue, 14 May 2019 23:08:16 +0000 (01:08 +0200)]
enc28j60: Use the common ss/es abbreviations.

This makes it more consistent with the rest of the decoders.

16 months agoenc28j60: Clear 'outputs' (no OUTPUT_PYTHON support).
Uwe Hermann [Tue, 14 May 2019 22:59:44 +0000 (00:59 +0200)]
enc28j60: Clear 'outputs' (no OUTPUT_PYTHON support).

16 months agoenc28j60: Factor out command list to
Uwe Hermann [Tue, 14 May 2019 22:57:42 +0000 (00:57 +0200)]
enc28j60: Factor out command list to

16 months agoenc28j60: Shorten ANN_* list a bit.
Uwe Hermann [Tue, 14 May 2019 22:56:46 +0000 (00:56 +0200)]
enc28j60: Shorten ANN_* list a bit.

16 months agoenc28j60: Add 'tags' field.
Uwe Hermann [Tue, 14 May 2019 22:49:04 +0000 (00:49 +0200)]
enc28j60: Add 'tags' field.

16 months agoenc28j60: Implements decoder for ENC28J60 SPI Ethernet chip
Jiahao Li [Wed, 20 Feb 2019 22:38:11 +0000 (17:38 -0500)]
enc28j60: Implements decoder for ENC28J60 SPI Ethernet chip

16 months agoatsha204a: Mention other potentially supported devices.
Uwe Hermann [Tue, 30 Apr 2019 20:26:59 +0000 (22:26 +0200)]
atsha204a: Mention other potentially supported devices.

16 months agoatsha204a: Mention ATECC508A support in docs.
Uwe Hermann [Tue, 30 Apr 2019 20:15:54 +0000 (22:15 +0200)]
atsha204a: Mention ATECC508A support in docs.

16 months agoatsha204a: Minor indentation fixes.
Uwe Hermann [Tue, 30 Apr 2019 20:03:27 +0000 (22:03 +0200)]
atsha204a: Minor indentation fixes.

16 months agoatsha204a: Only call output_tx_bytes() when the bytes buffer is not empty
Michalis Pappas [Sat, 26 Jan 2019 21:28:04 +0000 (22:28 +0100)]
atsha204a: Only call output_tx_bytes() when the bytes buffer is not empty

16 months agoatsha204a: Display OtherData parameter correctly when Verify command is executed...
Michalis Pappas [Wed, 11 Jul 2018 17:45:15 +0000 (20:45 +0300)]
atsha204a: Display OtherData parameter correctly when Verify command is executed in Validate mode.

16 months agoatsha204a: Add support for ATECC508A
Michalis Pappas [Fri, 15 Jun 2018 09:29:21 +0000 (12:29 +0300)]
atsha204a: Add support for ATECC508A

16 months agoNEWS: Fix two typos.
Uwe Hermann [Wed, 24 Apr 2019 20:02:59 +0000 (22:02 +0200)]
NEWS: Fix two typos.

16 months agospi: Fix annotation row ordering.
Uwe Hermann [Wed, 24 Apr 2019 20:00:02 +0000 (22:00 +0200)]
spi: Fix annotation row ordering.

Use the same (more logical) order of having the "bits" annotation row
being the first one, which is also what pretty much all other PDs do.

16 months agospi: Don't emit bogus "transfer" items.
Uwe Hermann [Wed, 24 Apr 2019 19:57:35 +0000 (21:57 +0200)]
spi: Don't emit bogus "transfer" items.

16 months agospi: Add support for "transfer" annotations.
Uwe Hermann [Wed, 24 Apr 2019 19:10:40 +0000 (21:10 +0200)]
spi: Add support for "transfer" annotations.

There is already an OUTPUT_PYTHON type named 'TRANSFER' that is being
transmitted to stacked decoders. Make the same information available
as annotations (additionally), which can be helpful in some situations.

17 months agocc1101: Use namedtuple to increase readability a bit.
Uwe Hermann [Fri, 19 Apr 2019 13:42:15 +0000 (15:42 +0200)]
cc1101: Use namedtuple to increase readability a bit.

17 months agocc1101: Remove 0x prefixes and unneeded quotation marks.
Uwe Hermann [Thu, 18 Apr 2019 22:25:31 +0000 (00:25 +0200)]
cc1101: Remove 0x prefixes and unneeded quotation marks.

The format "0xAA BB CC ..." looks a bit strange, use "AA BB CC" instead,
it's relatively obvious that the data is hex-encoded.

The quotation marks around some names/values are unneeded and reduce
readability a bit, so drop them.

17 months agocc1101: Shorten decode_register() to decode_reg().
Uwe Hermann [Thu, 18 Apr 2019 22:24:28 +0000 (00:24 +0200)]
cc1101: Shorten decode_register() to decode_reg().

17 months agocc1101: Simplify decode_command().
Uwe Hermann [Thu, 18 Apr 2019 22:20:43 +0000 (00:20 +0200)]
cc1101: Simplify decode_command().

By using the annotation strings as command names directly, some parts
of decode_command() can be simplified a bit.

17 months agocc1101: Simplify format_command().
Uwe Hermann [Thu, 18 Apr 2019 22:02:54 +0000 (00:02 +0200)]
cc1101: Simplify format_command().

17 months agocc1101: Factor out and simplify ANN_* names.
Uwe Hermann [Thu, 18 Apr 2019 21:55:39 +0000 (23:55 +0200)]
cc1101: Factor out and simplify ANN_* names.

17 months agoAdd a TI CC1101 decoder.
Marco [Wed, 27 Mar 2019 22:47:36 +0000 (23:47 +0100)]
Add a TI CC1101 decoder.

17 months agosdcard_spi: Fix duplicated 'End bit' annotation emission.
Uwe Hermann [Mon, 15 Apr 2019 18:19:19 +0000 (20:19 +0200)]
sdcard_spi: Fix duplicated 'End bit' annotation emission.

17 months agosdcard_spi: Fix incorrect annotation row indices.
Uwe Hermann [Mon, 15 Apr 2019 18:13:32 +0000 (20:13 +0200)]
sdcard_spi: Fix incorrect annotation row indices.

This fixes the remaining parts of bug #1365.

17 months agosdcard_spi: handle_data_response(): Shorten a few lines.
Uwe Hermann [Mon, 15 Apr 2019 17:46:04 +0000 (19:46 +0200)]
sdcard_spi: handle_data_response(): Shorten a few lines.

17 months agosdcard_spi: handle_data_response(): Add comment, cosmetics.
Uwe Hermann [Mon, 15 Apr 2019 17:40:55 +0000 (19:40 +0200)]
sdcard_spi: handle_data_response(): Add comment, cosmetics.

17 months agosdcard_spi: Fix some abbreviations and names to match the spec.
Uwe Hermann [Mon, 15 Apr 2019 16:50:12 +0000 (18:50 +0200)]
sdcard_spi: Fix some abbreviations and names to match the spec.

The official abbreviation for CMD24 in the spec is "WRITE_BLOCK", as
opposed to "WRITE_MULTIPLE_BLOCK" for CMD25 (chapter 4.7.4,
"Detailed Command Description", table 4-24).

The byte preceeding e.g. the CMD24 block data is called "Start Block" token
(chapter, "Start Block Tokens and Stop Tran Token"). We don't
include the "token" itself for consistency, since the decoder doesn't do
that for any other tokens either.

17 months agosdcard_spi: touch up CMD24 handling
Gerhard Sittig [Wed, 3 Apr 2019 17:10:46 +0000 (19:10 +0200)]
sdcard_spi: touch up CMD24 handling

Address some nits in the SDCard (SPI mode) protocol decoder. Rename
identifiers to eliminate comments. Determine the default block size at
the start of the write command instead of the iteration over payload
data bytes. Remove a print() statement which would break regression
tests. Allow re-use of the data handler for other commands, too. Use
lower case hex digits for consistency across the source file, and
slightly unobfuscate a bit pattern check while we are here. Improve
robustness of response handlers and how internal state gets advanced.
Replace constant lookups by direct method calls.

17 months agosdcard_spi: add support for CMD24 including payload data
Pierre Poulain [Fri, 15 Mar 2019 17:37:24 +0000 (18:37 +0100)]
sdcard_spi: add support for CMD24 including payload data

The previous implementation advanced from the start of CMD24 to IDLE.
This commit introduces support for the data phase and data response of
CMD24. Which results in improved usability of the decoder output, and
reduced probability of false positives (don't detect "commands" in the
payload data).

This commit addresses the missing CMD24 handling part of bug #1365.

17 months agosrd_inst_stack(): Warn upon potentially incorrect stacking.
Uwe Hermann [Tue, 2 Apr 2019 19:35:32 +0000 (21:35 +0200)]
srd_inst_stack(): Warn upon potentially incorrect stacking.

Currently there must be at least one match of inputs/outputs for
decoders that are stacked. If not, we emit an informational warning
(but this is not a hard error for the time being).

17 months agodecoders: Fix incorrect 'outputs' fields.
Uwe Hermann [Tue, 2 Apr 2019 19:33:58 +0000 (21:33 +0200)]
decoders: Fix incorrect 'outputs' fields.

Only add items to 'outputs' if the respective PD actually has
OUTPUT_PYTHON support implemented as of right now.

Various decoders might get OUTPUT_PYTHON support later, but the
'outputs' field should reflect the current status.

17 months agods2408: Add missing tags.
Uwe Hermann [Thu, 28 Mar 2019 21:49:39 +0000 (22:49 +0100)]
ds2408: Add missing tags.

17 months agoadd a Maxim DS2408 decoder
Mariusz Bialonczyk [Thu, 14 Mar 2019 11:25:54 +0000 (12:25 +0100)]
add a Maxim DS2408 decoder

This is a 1-Wire 8-channel addressable switch.

17 months agoonewire_network: add a 'Disable Test Mode' command for DS2408
Mariusz Bialonczyk [Sat, 16 Mar 2019 10:57:22 +0000 (11:57 +0100)]
onewire_network: add a 'Disable Test Mode' command for DS2408

For details see the DS2408 datasheet, section "Power-up timing".

This commit is adding this missing command so now a full decoding
is possible:
Annotations from 1-Wire network layer:
8990980-8991220 1-Wire network layer: : Reset/presence: true
8994163-8994437 1-Wire network layer: : ROM command: 0x96 'DS2408: Disable Test Mode'
8995026-9008178 1-Wire network layer: : ROM: 0xa30000001246a929
9008785-9009060 1-Wire network layer: : Data: 0x3c
9012290-9012530 1-Wire network layer: : Reset/presence: true

And from the specific stacked DS2408 slave:
8990980-8991220 DS2408: : Reset/presence: true
8995026-9008178 DS2408: : ROM: 0xa30000001246a929 (family code 0x29)
9008785-9009060 DS2408: : Disable Test Mode (0x3c)
9012290-9012530 DS2408: : Reset/presence: true

17 months agoonewire_network: add a missing 'Resume ROM' command
Mariusz Bialonczyk [Wed, 13 Mar 2019 17:47:38 +0000 (18:47 +0100)]
onewire_network: add a missing 'Resume ROM' command

For details see the DS2408 datasheet, section "Resume Command [A5h]".

18 months agodecoders: Various cosmetic/consistency/typo fixes.
Uwe Hermann [Sat, 16 Mar 2019 17:46:01 +0000 (18:46 +0100)]
decoders: Various cosmetic/consistency/typo fixes.

18 months agoHACKING: Document current tags and their intention/usage.
Uwe Hermann [Thu, 14 Mar 2019 23:57:31 +0000 (00:57 +0100)]
HACKING: Document current tags and their intention/usage.

18 months agodecoders: Add/update tags for each PD.
Uwe Hermann [Thu, 14 Mar 2019 23:57:04 +0000 (00:57 +0100)]
decoders: Add/update tags for each PD.

18 months agoAdd PD tags handling and some tags
Soeren Apel [Fri, 28 Dec 2018 10:41:41 +0000 (11:41 +0100)]
Add PD tags handling and some tags

19 months agojtag_ejtag: Shorten a variable name.
Uwe Hermann [Tue, 29 Jan 2019 23:03:23 +0000 (00:03 +0100)]
jtag_ejtag: Shorten a variable name.

19 months agoRename values that shadow built-in keywords
Ryan Jarvis [Sat, 19 Jan 2019 08:05:07 +0000 (00:05 -0800)]
Rename values that shadow built-in keywords

19 months agoRemove trailing semicolons
Ryan Jarvis [Sat, 19 Jan 2019 07:51:23 +0000 (23:51 -0800)]
Remove trailing semicolons

19 months agoFix obvious typos with string formatters
Ryan Jarvis [Sat, 19 Jan 2019 07:49:47 +0000 (23:49 -0800)]
Fix obvious typos with string formatters

19 months agoTypo preventing "Personal preference settings" & "Display user info on screen" from...
Ryan Jarvis [Sat, 19 Jan 2019 07:46:36 +0000 (23:46 -0800)]
Typo preventing "Personal preference settings" & "Display user info on screen" from functioning


19 months agoComparison to None should use "is/is not" instead of "==/!="
Ryan Jarvis [Sat, 19 Jan 2019 07:43:26 +0000 (23:43 -0800)]
Comparison to None should use "is/is not" instead of "==/!="

19 months agoDS1307: Bugs fixes.
Libor Gabaj [Wed, 23 Jan 2019 20:58:26 +0000 (21:58 +0100)]
DS1307: Bugs fixes.

- Square wave frequencies above 1 Hz are in Hz not in kHz.
- AM/PM flag is in the bit 5 of hours register not in bit 6.
- AM flag is valid at 0 value of AM/PM flag not at 1 value.

21 months agouart: remove obsolete TODO (Python annotation for frame errors)
Gerhard Sittig [Sat, 24 Nov 2018 10:57:38 +0000 (11:57 +0100)]
uart: remove obsolete TODO (Python annotation for frame errors)

The "Frame error?" TODO comment on Python annotations has become
obsolete. Individual bit errors within the frame immediately get
communicated as they are detected (START, parity, STOP). The overall
frame's validity has become available with the FRAME annotation.

21 months agouart: add FRAME Python annotation, communicate frame validity
Gerhard Sittig [Fri, 23 Nov 2018 18:10:34 +0000 (19:10 +0100)]
uart: add FRAME Python annotation, communicate frame validity

Internally keep track of the UART frame's validity. Emit a FRAME Python
annotation for aborted as well as for completed frames. This obsoletes a
TODO comment in the STOP bit code path.

This annotation also spans the complete frame's length, including start
and parity and stop bits, which the DATA annotation doesn't cover.
Stacked decoders can individually decide whether to strictly reference
the mere data bits section or the complete UART frame which happened to
communicate the data value.

21 months agouart: document the Python annotation for BREAK
Gerhard Sittig [Fri, 23 Nov 2018 18:09:09 +0000 (19:09 +0100)]
uart: document the Python annotation for BREAK

21 months agoi2s: Fix 2 issues.
Weixiao Zhang [Wed, 21 Nov 2018 03:41:45 +0000 (21:41 -0600)]
i2s: Fix 2 issues.

1. WS = 0, Left Channel; WS = 1, Right Channel
2. Data start and end at falling edge of SCK

22 months agox2444m: Add some shorter annotation strings as well.
Uwe Hermann [Sat, 10 Nov 2018 17:48:37 +0000 (18:48 +0100)]
x2444m: Add some shorter annotation strings as well.

22 months agox2444m: Move variable initializations to reset().
Uwe Hermann [Sat, 10 Nov 2018 17:31:38 +0000 (18:31 +0100)]
x2444m: Move variable initializations to reset().

22 months agox2444m: Make each command an extra annotation class.
Uwe Hermann [Sat, 10 Nov 2018 17:31:04 +0000 (18:31 +0100)]
x2444m: Make each command an extra annotation class.

22 months agoDecoder for Xicor X2444M, nonvolatile static RAM.
Stefan Petersen [Wed, 31 Oct 2018 13:27:44 +0000 (14:27 +0100)]
Decoder for Xicor X2444M, nonvolatile static RAM.

22 months agodecoder: consider reset() a mandatory decoder method
Gerhard Sittig [Sun, 21 Oct 2018 15:14:59 +0000 (17:14 +0200)]
decoder: consider reset() a mandatory decoder method

In theory support for PD reset is optional, applications are not
required to make use of it. But it's essential to receive correct
decoding results when used with the popular Pulseview mainline

So let's consider the absence of the reset() method fatal. All mainline
decoders have it. Out-of-tree decoders are easy to adjust, and very
probably should support reset() as well. Thus this change is considered
beneficial, and not harmful.

22 months agomiller: add reset() method
Gerhard Sittig [Sun, 21 Oct 2018 19:25:34 +0000 (21:25 +0200)]
miller: add reset() method

22 months agolin: Simplify state handling a bit.
Uwe Hermann [Sun, 21 Oct 2018 17:43:10 +0000 (19:43 +0200)]
lin: Simplify state handling a bit.

22 months agolin: handle_break(): Use self.putx().
Uwe Hermann [Sun, 21 Oct 2018 17:30:32 +0000 (19:30 +0200)]
lin: handle_break(): Use self.putx().

22 months agolin: Simplify LinFsm._transition_allowed().
Uwe Hermann [Sun, 21 Oct 2018 17:28:31 +0000 (19:28 +0200)]
lin: Simplify LinFsm._transition_allowed().

22 months agoadd LIN protocol decoder
stephan.thiele [Wed, 17 Oct 2018 09:40:23 +0000 (11:40 +0200)]
add LIN protocol decoder

22 months agospiflash: Remember write protection latch from status registers
Vesa-Pekka Palmu [Wed, 17 Oct 2018 22:57:28 +0000 (01:57 +0300)]
spiflash: Remember write protection latch from status registers

22 months agospiflash: Bugfix: WRSR was using miso for register decode
Vesa-Pekka Palmu [Wed, 17 Oct 2018 22:56:26 +0000 (01:56 +0300)]
spiflash: Bugfix: WRSR was using miso for register decode