Ruler: Don't draw the tick marks antialiased

[pulseview.git] / pv / view / ruler.cpp

diff --git a/pv/view/ruler.cpp b/pv/view/ruler.cpp
index 6f8e89a5b69833ad3449167f0599dc87b87794a4..cd72a179cc72a84e46f4e9e65edb82750da42b0b 100644 (file)
--- a/pv/view/ruler.cpp
+++ b/pv/view/ruler.cpp
@@ -77,6 +77,38 @@ QSize Ruler::extended_size_hint() const
                ViewItem::HighlightRadius);
 }
 
+QString Ruler::format_time_with_distance(
+       const pv::util::Timestamp& distance,
+       const pv::util::Timestamp& t,
+       pv::util::SIPrefix prefix,
+       pv::util::TimeUnit unit,
+       unsigned precision,
+       bool sign)
+{
+       const unsigned limit = 60;
+
+       if (t.is_zero())
+               return "0";
+
+       // If we have to use samples then we have no alternative formats
+       if (unit == pv::util::TimeUnit::Samples)
+               return pv::util::format_time_si_adjusted(t, prefix, precision, "sa", sign);
+
+       // View zoomed way out -> low precision (0), big distance (>=60s)
+       // -> DD:HH:MM
+       if ((precision == 0) && (distance >= limit))
+               return pv::util::format_time_minutes(t, 0, sign);
+
+       // View in "normal" range -> medium precision, medium step size
+       // -> HH:MM:SS.mmm... or xxxx (si unit) if less than limit seconds
+       // View zoomed way in -> high precision (>3), low step size (<1s)
+       // -> HH:MM:SS.mmm... or xxxx (si unit) if less than limit seconds
+       if (abs(t) < limit)
+               return pv::util::format_time_si_adjusted(t, prefix, precision, "s", sign);
+       else
+               return pv::util::format_time_minutes(t, precision, sign);
+}
+
 vector< shared_ptr<ViewItem> > Ruler::items()
 {
        const vector< shared_ptr<TimeItem> > time_items(view_.time_items());
@@ -98,7 +130,8 @@ void Ruler::paintEvent(QPaintEvent*)
        if (!tick_position_cache_) {
                auto ffunc = [this](const pv::util::Timestamp& t)
                {
-                       return util::format_time(
+                       return format_time_with_distance(
+                               this->view_.tick_period(),
                                t,
                                this->view_.tick_prefix(),
                                this->view_.time_unit(),
@@ -121,7 +154,6 @@ void Ruler::paintEvent(QPaintEvent*)
        const int minor_tick_y1 = (major_tick_y1 + ruler_height) / 2;
 
        QPainter p(this);
-       p.setRenderHint(QPainter::Antialiasing);
 
        // Draw the tick marks
        p.setPen(palette().color(foregroundRole()));
@@ -141,6 +173,8 @@ void Ruler::paintEvent(QPaintEvent*)
        // Draw the hover mark
        draw_hover_mark(p, text_height);
 
+       p.setRenderHint(QPainter::Antialiasing);
+
        // The cursor labels are not drawn with the arrows exactly on the
        // bottom line of the widget, because then the selection shadow
        // would be clipped away.
@@ -156,7 +190,7 @@ void Ruler::paintEvent(QPaintEvent*)
 }
 
 Ruler::TickPositions Ruler::calculate_tick_positions(
-       const double major_period,
+       const pv::util::Timestamp& major_period,
        const pv::util::Timestamp& offset,
        const double scale,
        const int width,
@@ -164,7 +198,8 @@ Ruler::TickPositions Ruler::calculate_tick_positions(
 {
        TickPositions tp;
 
-       const double minor_period = major_period / MinorTickSubdivision;
+       const double minor_period =
+               (major_period / MinorTickSubdivision).convert_to<double>();
        const pv::util::Timestamp first_major_division = floor(offset / major_period);
        const pv::util::Timestamp first_minor_division = ceil(offset / minor_period);
        const pv::util::Timestamp t0 = first_major_division * major_period;
@@ -175,10 +210,12 @@ Ruler::TickPositions Ruler::calculate_tick_positions(
        double x;
 
        do {
-               const pv::util::Timestamp t = t0 + division * minor_period;
+               pv::util::Timestamp t = t0 + division * minor_period;
                x = ((t - offset) / scale).convert_to<double>();
 
                if (division % MinorTickSubdivision == 0) {
+                       // Recalculate 't' without using 'minor_period' which is of type double.
+                       t = t0 + division / MinorTickSubdivision * major_period;
                        tp.major.emplace_back(x, format_function(t));
                } else {
                        tp.minor.emplace_back(x);