]> sigrok.org Git - pulseview.git/blobdiff - pv/view/header.cpp
Header: Fixed dragging glitches
[pulseview.git] / pv / view / header.cpp
index 125d3c2430ba868d95c0f535e162d9279dda9e90..9ba4cf8f8814088749cf20b1909dee6cfec50e7e 100644 (file)
 #include "signal.h"
 #include "../sigsession.h"
 
-#include <assert.h>
+#include <cassert>
+#include <algorithm>
 
-#include <boost/foreach.hpp>
-
-#include <QColorDialog>
-#include <QInputDialog>
+#include <QApplication>
 #include <QMenu>
 #include <QMouseEvent>
 #include <QPainter>
 #include <QRect>
 
-using namespace boost;
-using namespace std;
+#include <pv/widgets/popup.h>
+
+using std::max;
+using std::make_pair;
+using std::pair;
+using std::shared_ptr;
+using std::stable_sort;
+using std::vector;
 
 namespace pv {
 namespace view {
 
+const int Header::Padding = 12;
+const int Header::BaselineOffset = 5;
+
 Header::Header(View &parent) :
-       QWidget(&parent),
-       _view(parent),
-       _action_set_name(new QAction(tr("Set &Name..."), this)),
-       _action_set_colour(new QAction(tr("Set &Colour..."), this))
+       MarginWidget(parent),
+       _dragging(false)
 {
+       setFocusPolicy(Qt::ClickFocus);
        setMouseTracking(true);
 
-       connect(_action_set_name, SIGNAL(triggered()),
-               this, SLOT(on_action_set_name_triggered()));
-       connect(_action_set_colour, SIGNAL(triggered()),
-               this, SLOT(on_action_set_colour_triggered()));
+       connect(&_view, SIGNAL(signals_moved()),
+               this, SLOT(on_signals_moved()));
+}
+
+QSize Header::sizeHint() const
+{
+       QRectF max_rect(-Padding, 0, Padding, 0);
+       for (auto &i : _view)
+               if (i->enabled())
+                       max_rect = max_rect.united(i->label_rect(0));
+       return QSize(max_rect.width() + Padding + BaselineOffset, 0);
+}
+
+shared_ptr<RowItem> Header::get_mouse_over_row_item(const QPoint &pt)
+{
+       const int w = width() - BaselineOffset;
+       for (auto &i : _view)
+               if (i->enabled() && i->label_rect(w).contains(pt))
+                       return i;
+       return shared_ptr<RowItem>();
+}
+
+void Header::clear_selection()
+{
+       for (auto &i : _view)
+               i->select(false);
+       update();
+}
+
+void Header::signals_updated()
+{
+       for (shared_ptr<RowItem> r : _view) {
+               assert(r);
+               connect(r.get(), SIGNAL(appearance_changed()),
+                       this, SLOT(on_trace_changed()));
+       }
 }
 
-void Header::paintEvent(QPaintEvent *event)
+void Header::show_popup(const shared_ptr<RowItem> &item)
 {
-       const int w = width();
-       const vector< shared_ptr<Signal> > &sigs =
-               _view.session().get_signals();
+       using pv::widgets::Popup;
+
+       Popup *const p = item->create_popup(&_view);
+       if (!p)
+               return;
+
+       const QPoint pt(width() - BaselineOffset, item->get_y());
+       p->set_position(mapToGlobal(pt), Popup::Right);
+       p->show();
+}
+
+void Header::paintEvent(QPaintEvent*)
+{
+       // The trace labels are not drawn with the arrows exactly on the
+       // left edge of the widget, because then the selection shadow
+       // would be clipped away.
+       const int w = width() - BaselineOffset;
+
+       vector< shared_ptr<RowItem> > row_items(
+               _view.begin(), _view.end());
+
+       stable_sort(row_items.begin(), row_items.end(),
+               [](const shared_ptr<RowItem> &a, const shared_ptr<RowItem> &b) {
+                       return a->v_offset() < b->v_offset(); });
 
        QPainter painter(this);
        painter.setRenderHint(QPainter::Antialiasing);
 
-       const int v_offset = _view.v_offset();
-       BOOST_FOREACH(const shared_ptr<Signal> s, sigs)
+       const bool dragging = !_drag_row_items.empty();
+       for (const shared_ptr<RowItem> r : row_items)
        {
-               assert(s);
+               assert(r);
 
-               const QRect signal_heading_rect(
-                       0, s->get_v_offset() - v_offset,
-                       w, View::SignalHeight);
-
-               s->paint_label(painter, signal_heading_rect,
-                       s->pt_in_label_rect(signal_heading_rect, _mouse_point));
+               const bool highlight = !dragging &&
+                       r->label_rect(w).contains(_mouse_point);
+               r->paint_label(painter, w, highlight);
        }
 
        painter.end();
 }
 
-void Header::mouseMoveEvent(QMouseEvent *event)
+void Header::mouseLeftPressEvent(QMouseEvent *event)
 {
-       assert(event);
-       _mouse_point = event->pos();
+       const bool ctrl_pressed =
+               QApplication::keyboardModifiers() & Qt::ControlModifier;
+
+       // Clear selection if control is not pressed and this item is unselected
+       const shared_ptr<RowItem> mouse_over =
+               get_mouse_over_row_item(event->pos());
+       if (!ctrl_pressed && (!mouse_over || !mouse_over->selected()))
+               for (shared_ptr<RowItem> r : _view)
+                       r->select(false);
+
+       // Set the signal selection state if the item has been clicked
+       if (mouse_over) {
+               if (ctrl_pressed)
+                       mouse_over->select(!mouse_over->selected());
+               else
+                       mouse_over->select(true);
+       }
+
+       // Save the offsets of any signals which will be dragged
+       _mouse_down_point = event->pos();
+       for (const shared_ptr<RowItem> r : _view)
+               if (r->selected())
+                       _drag_row_items.push_back(
+                               make_pair(r, r->v_offset()));
+
+       selection_changed();
        update();
 }
 
-void Header::leaveEvent(QEvent *event)
+void Header::mousePressEvent(QMouseEvent *event)
 {
-       _mouse_point = QPoint(-1, -1);
-       update();
+       assert(event);
+       if (event->button() & Qt::LeftButton)
+               mouseLeftPressEvent(event);
 }
 
-void Header::contextMenuEvent(QContextMenuEvent *event)
+void Header::mouseLeftReleaseEvent(QMouseEvent *event)
 {
-       const int w = width();
-       const vector< shared_ptr<Signal> > &sigs =
-               _view.session().get_signals();
+       assert(event);
+
+       const bool ctrl_pressed =
+               QApplication::keyboardModifiers() & Qt::ControlModifier;
+
+       // Unselect everything if control is not pressed
+       const shared_ptr<RowItem> mouse_over =
+               get_mouse_over_row_item(event->pos());
 
-       const int v_offset = _view.v_offset();
-       BOOST_FOREACH(const shared_ptr<Signal> s, sigs)
+       if (_dragging)
+               _view.normalize_layout();
+       else
        {
-               assert(s);
+               if (!ctrl_pressed) {
+                       for (shared_ptr<RowItem> r : _view)
+                               if (mouse_over != r)
+                                       r->select(false);
+
+                       if (mouse_over)
+                               show_popup(mouse_over);
+               }
+       }
+
+       _dragging = false;
+       _drag_row_items.clear();
+}
+
+void Header::mouseReleaseEvent(QMouseEvent *event)
+{
+       assert(event);
+       if (event->button() & Qt::LeftButton)
+               mouseLeftReleaseEvent(event);
+}
+
+void Header::mouseMoveEvent(QMouseEvent *event)
+{
+       assert(event);
+       _mouse_point = event->pos();
+
+       if (!(event->buttons() & Qt::LeftButton))
+               return;
 
-               const QRect signal_heading_rect(
-                       0, s->get_v_offset() - v_offset,
-                       w, View::SignalHeight);
+       if ((event->pos() - _mouse_down_point).manhattanLength() <
+               QApplication::startDragDistance())
+               return;
 
-               if(s->pt_in_label_rect(signal_heading_rect, _mouse_point)) {
-                       QMenu menu(this);
-                       menu.addAction(_action_set_name);
-                       menu.addAction(_action_set_colour);
+       // Check the list of dragging items is not empty
+       if (_drag_row_items.empty())
+               return;
 
-                       _context_signal = s;
-                       menu.exec(event->globalPos());
-                       _context_signal.reset();
+       // Check all the drag items share a common owner
+       const shared_ptr<RowItem> first_row_item(
+               _drag_row_items.front().first);
+       for (const auto &r : _drag_row_items) {
+               const shared_ptr<RowItem> row_item(r.first);
+               assert(row_item);
 
-                       break;
+               if (row_item->owner() != first_row_item->owner())
+                       return;
+       }
+
+       // Do the drag
+       _dragging = true;
+
+       const int delta = event->pos().y() - _mouse_down_point.y();
+
+       for (auto i = _drag_row_items.begin();
+               i != _drag_row_items.end(); i++) {
+               const std::shared_ptr<RowItem> row_item((*i).first);
+               if (row_item) {
+                       const int y = (*i).second + delta;
+                       row_item->set_v_offset(y);
+
+                       // Ensure the trace is selected
+                       row_item->select();
                }
        }
+
+       signals_moved();
+
+       update();
 }
 
-void Header::on_action_set_name_triggered()
+void Header::leaveEvent(QEvent*)
 {
-       shared_ptr<view::Signal> context_signal = _context_signal;
-       if(!context_signal)
+       _mouse_point = QPoint(-1, -1);
+       update();
+}
+
+void Header::contextMenuEvent(QContextMenuEvent *event)
+{
+       const shared_ptr<RowItem> r = get_mouse_over_row_item(_mouse_point);
+       if (!r)
                return;
 
-       const QString new_label = QInputDialog::getText(this, tr("Set Name"),
-               tr("Name"), QLineEdit::Normal, context_signal->get_name());
+       QMenu *const menu = r->create_context_menu(this);
+       if (!menu)
+               return;
 
-       if(!new_label.isEmpty())
-               context_signal->set_name(new_label);
+       menu->exec(event->globalPos());
 }
 
-void Header::on_action_set_colour_triggered()
+void Header::keyPressEvent(QKeyEvent *e)
 {
-       shared_ptr<view::Signal> context_signal = _context_signal;
-       if(!context_signal)
-               return;
+       assert(e);
 
-       const QColor new_colour = QColorDialog::getColor(
-               context_signal->get_colour(), this, tr("Set Colour"));
+       switch (e->key())
+       {
+       case Qt::Key_Delete:
+       {
+               for (const shared_ptr<RowItem> r : _view)
+                       if (r->selected())
+                               r->delete_pressed();
+               break;
+       }
+       }
+}
+
+void Header::on_signals_moved()
+{
+       update();
+}
 
-       if(new_colour.isValid())
-               context_signal->set_colour(new_colour);
+void Header::on_trace_changed()
+{
+       update();
+       geometry_updated();
 }
 
 } // namespace view