]> sigrok.org Git - pulseview.git/blobdiff - pv/view/decodetrace.cpp
Fix bug #477 by keeping track of visible rows, not just titles
[pulseview.git] / pv / view / decodetrace.cpp
index c8a20dc3c9c6cf7eb3888080351e624ba38349c7..e290e55fe2ae68fa72c0f9cfefae29e371c5d72c 100644 (file)
@@ -33,6 +33,7 @@ extern "C" {
 #include <QLabel>
 #include <QMenu>
 #include <QPushButton>
+#include <QToolTip>
 
 #include "decodetrace.h"
 
@@ -49,9 +50,11 @@ extern "C" {
 
 using std::dynamic_pointer_cast;
 using std::list;
+using std::make_pair;
 using std::max;
 using std::map;
 using std::min;
+using std::pair;
 using std::shared_ptr;
 using std::vector;
 
@@ -116,6 +119,8 @@ DecodeTrace::DecodeTrace(pv::SigSession &session,
                decoder_stack->stack().front()->decoder()->name)),
        _session(session),
        _decoder_stack(decoder_stack),
+       _text_height(0),
+       _row_height(0),
        _delete_mapper(this),
        _show_hide_mapper(this)
 {
@@ -157,37 +162,16 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
 {
        using namespace pv::data::decode;
 
-       const double scale = _view->scale();
-       assert(scale > 0);
-
-       double samplerate = _decoder_stack->samplerate();
-
-       _cur_row_headings.clear();
-
-       // Show sample rate as 1Hz when it is unknown
-       if (samplerate == 0.0)
-               samplerate = 1.0;
-
-       const double pixels_offset = (_view->offset() -
-               _decoder_stack->get_start_time()) / scale;
-       const double samples_per_pixel = samplerate * scale;
-
-       const uint64_t start_sample = (uint64_t)max((left + pixels_offset) *
-               samples_per_pixel, 0.0);
-       const uint64_t end_sample = (uint64_t)max((right + pixels_offset) *
-               samples_per_pixel, 0.0);
-
        QFontMetrics m(QApplication::font());
-       const int text_height =  m.boundingRect(QRect(), 0, "Tg").height();
-       const int annotation_height = (text_height * 5) / 4;
-       const int row_height = (text_height * 6) / 4;
+       _text_height = m.boundingRect(QRect(), 0, "Tg").height();
+       _row_height = (_text_height * 6) / 4;
+       const int annotation_height = (_text_height * 5) / 4;
 
        assert(_decoder_stack);
        const QString err = _decoder_stack->error_message();
        if (!err.isEmpty())
        {
-               draw_unresolved_period(p, annotation_height, left, right,
-                       samples_per_pixel, pixels_offset);
+               draw_unresolved_period(p, annotation_height, left, right);
                draw_error(p, err, left, right);
                return;
        }
@@ -195,10 +179,12 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
        // Iterate through the rows
        assert(_view);
        int y = get_y();
+       pair<uint64_t, uint64_t> sample_range = get_sample_range(left, right);
 
        assert(_decoder_stack);
-
        const vector<Row> rows(_decoder_stack->get_visible_rows());
+
+       _visible_rows.clear();
        for (size_t i = 0; i < rows.size(); i++)
        {
                const Row &row = rows[i];
@@ -211,22 +197,20 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
 
                vector<Annotation> annotations;
                _decoder_stack->get_annotation_subset(annotations, row,
-                       start_sample, end_sample);
+                       sample_range.first, sample_range.second);
                if (!annotations.empty()) {
                        for (const Annotation &a : annotations)
                                draw_annotation(a, p, get_text_colour(),
-                                       annotation_height, left, right,
-                                       samples_per_pixel, pixels_offset, y,
+                                       annotation_height, left, right, y,
                                        base_colour);
-                       y += row_height;
+                       y += _row_height;
 
-                       _cur_row_headings.push_back(row.title());
+                       _visible_rows.push_back(rows[i]);
                }
        }
 
        // Draw the hatching
-       draw_unresolved_period(p, annotation_height, left, right,
-               samples_per_pixel, pixels_offset);
+       draw_unresolved_period(p, annotation_height, left, right);
 }
 
 void DecodeTrace::paint_fore(QPainter &p, int left, int right)
@@ -235,13 +219,11 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
 
        (void)right;
 
-       QFontMetrics m(QApplication::font());
-       const int text_height =  m.boundingRect(QRect(), 0, "Tg").height();
-       const int row_height = (text_height * 6) / 4;
+       assert(_row_height);
 
-       for (size_t i = 0; i < _cur_row_headings.size(); i++)
+       for (size_t i = 0; i < _visible_rows.size(); i++)
        {
-               const int y = i * row_height + get_y();
+               const int y = i * _row_height + get_y();
 
                p.setPen(QPen(Qt::NoPen));
                p.setBrush(QApplication::palette().brush(QPalette::WindowText));
@@ -256,9 +238,9 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
                        p.drawPolygon(points, countof(points));
                }
 
-               const QRect r(left + ArrowSize * 2, y - row_height / 2,
-                       right - left, row_height);
-               const QString h(_cur_row_headings[i]);
+               const QRect r(left + ArrowSize * 2, y - _row_height / 2,
+                       right - left, _row_height);
+               const QString h(_visible_rows[i].title());
                const int f = Qt::AlignLeft | Qt::AlignVCenter |
                        Qt::TextDontClip;
 
@@ -342,10 +324,12 @@ QMenu* DecodeTrace::create_context_menu(QWidget *parent)
 }
 
 void DecodeTrace::draw_annotation(const pv::data::decode::Annotation &a,
-       QPainter &p, QColor text_color, int h, int left, int right,
-       double samples_per_pixel, double pixels_offset, int y,
+       QPainter &p, QColor text_color, int h, int left, int right, int y,
        size_t base_colour) const
 {
+       const double samples_per_pixel = get_samples_per_pixel();
+       const double pixels_offset = get_pixels_offset();
+
        const double start = a.start_sample() / samples_per_pixel -
                pixels_offset;
        const double end = a.end_sample() / samples_per_pixel -
@@ -464,7 +448,7 @@ void DecodeTrace::draw_error(QPainter &p, const QString &message,
 }
 
 void DecodeTrace::draw_unresolved_period(QPainter &p, int h, int left,
-       int right, double samples_per_pixel, double pixels_offset) 
+       int right) const
 {
        using namespace pv::data;
        using pv::data::decode::Decoder;
@@ -500,6 +484,10 @@ void DecodeTrace::draw_unresolved_period(QPainter &p, int h, int left,
                return;
 
        const int y = get_y();
+
+       const double samples_per_pixel = get_samples_per_pixel();
+       const double pixels_offset = get_pixels_offset();
+
        const double start = max(samples_decoded /
                samples_per_pixel - pixels_offset, left - 1.0);
        const double end = min(sample_count / samples_per_pixel -
@@ -515,6 +503,138 @@ void DecodeTrace::draw_unresolved_period(QPainter &p, int h, int left,
        p.drawRect(no_decode_rect);
 }
 
+double DecodeTrace::get_pixels_offset() const
+{
+       assert(_view);
+       assert(_decoder_stack);
+
+       const double scale = _view->scale();
+       assert(scale > 0);
+
+       return (_view->offset() - _decoder_stack->get_start_time()) / scale;
+}
+
+double DecodeTrace::get_samples_per_pixel() const
+{
+       assert(_view);
+       assert(_decoder_stack);
+
+       const double scale = _view->scale();
+       assert(scale > 0);
+
+       double samplerate = _decoder_stack->samplerate();
+
+       // Show sample rate as 1Hz when it is unknown
+       if (samplerate == 0.0)
+               samplerate = 1.0;
+
+       return samplerate * scale;
+}
+
+pair<uint64_t, uint64_t> DecodeTrace::get_sample_range(int x_start, int x_end) const
+{
+       assert(_view);
+       assert(_decoder_stack);
+
+       const double samples_per_pixel = get_samples_per_pixel();
+       const double pixels_offset = get_pixels_offset();
+
+       uint64_t start, end;
+
+       start = (uint64_t)max((x_start + pixels_offset) * samples_per_pixel, 0.0);
+       end = (uint64_t)max((x_end + pixels_offset) * samples_per_pixel, 0.0);
+
+       return make_pair(start, end);
+}
+
+bool DecodeTrace::hover_point_is_over_trace()
+{
+       assert(_view);
+       assert(_row_height);
+
+       // Note: if _row_height is valid then _cur_row_headings is valid, too,
+       // as both are set in paint_mid().
+
+       // Note: hp.x will be 0 if the cursor is above the header area,
+       // so we set trace.left to 1 to exclude this.
+
+       QRect trace(1, get_y() - (_row_height/2),
+               _view->width(), _row_height * _visible_rows.size());
+
+       // Note: We don't need to check for _row_height being 0 here but
+       // we do it anyway to be more robust.
+
+       return _row_height && enabled() && trace.contains(_view->hover_point());
+}
+
+int DecodeTrace::get_row_at_hover_point()
+{
+       assert(_view);
+       assert(_row_height);
+       assert(_decoder_stack);
+
+       QPoint hp = _view->hover_point();
+       int hover_row = (hp.y() - get_y() + (_row_height/2)) / _row_height;
+
+       return min(hover_row, (int)_visible_rows.size() - 1);
+}
+
+const QString DecodeTrace::get_annotation_at_hover_point()
+{
+       using namespace pv::data::decode;
+
+       assert(_view);
+       QPoint hp = _view->hover_point();
+
+       pair<uint64_t, uint64_t> sample_range = get_sample_range(hp.x(), hp.x() + 1);
+
+       const int hover_row = get_row_at_hover_point();
+
+       vector<pv::data::decode::Annotation> annotations;
+
+       assert(_decoder_stack);
+       _decoder_stack->get_annotation_subset(annotations, _visible_rows[hover_row],
+               sample_range.first, sample_range.second);
+
+       return (annotations.empty()) ?
+               QString() : annotations[0].annotations().front();
+}
+
+void DecodeTrace::show_hover_annotation()
+{
+       QString ann = get_annotation_at_hover_point();
+
+       assert(_view);
+       assert(_row_height);
+       assert(_text_height);
+
+       if (!ann.isEmpty()) {
+               const int hover_row = get_row_at_hover_point();
+
+               // Make sure the tool tip doesn't overlap with the mouse cursor.
+               // If it did, the tool tip would constantly hide and re-appear.
+               QPoint hp = _view->hover_point();
+               hp.setY(get_y() - (_row_height/2) +
+                       (hover_row * _row_height) - _text_height);
+
+               QToolTip::showText(_view->mapToGlobal(hp), ann);
+       } else
+               hide_hover_annotation();
+}
+
+void DecodeTrace::hide_hover_annotation()
+{
+       QToolTip::hideText();
+}
+
+void DecodeTrace::hover_point_changed()
+{
+       if (hover_point_is_over_trace())
+               show_hover_annotation();
+       else
+               hide_hover_annotation();
+}
+
 void DecodeTrace::create_decoder_form(int index,
        shared_ptr<data::decode::Decoder> &dec, QWidget *parent,
        QFormLayout *form)