]> sigrok.org Git - pulseview.git/blobdiff - pv/view/decodetrace.cpp
RowItem: Split appart visual and layout v offsets
[pulseview.git] / pv / view / decodetrace.cpp
index c8a20dc3c9c6cf7eb3888080351e624ba38349c7..5ca665e0dff947f17ebbcbd0a5a77aa8802d1b98 100644 (file)
@@ -22,8 +22,12 @@ extern "C" {
 #include <libsigrokdecode/libsigrokdecode.h>
 }
 
+#include <mutex>
+
 #include <extdef.h>
 
+#include <tuple>
+
 #include <boost/functional/hash.hpp>
 
 #include <QAction>
@@ -33,6 +37,7 @@ extern "C" {
 #include <QLabel>
 #include <QMenu>
 #include <QPushButton>
+#include <QToolTip>
 
 #include "decodetrace.h"
 
@@ -44,15 +49,23 @@ extern "C" {
 #include <pv/data/decode/annotation.h>
 #include <pv/view/logicsignal.h>
 #include <pv/view/view.h>
+#include <pv/view/viewport.h>
 #include <pv/widgets/decodergroupbox.h>
 #include <pv/widgets/decodermenu.h>
 
+using boost::shared_lock;
+using boost::shared_mutex;
 using std::dynamic_pointer_cast;
 using std::list;
+using std::lock_guard;
+using std::make_pair;
 using std::max;
+using std::make_pair;
 using std::map;
 using std::min;
+using std::pair;
 using std::shared_ptr;
+using std::tie;
 using std::vector;
 
 namespace pv {
@@ -116,6 +129,8 @@ DecodeTrace::DecodeTrace(pv::SigSession &session,
                decoder_stack->stack().front()->decoder()->name)),
        _session(session),
        _decoder_stack(decoder_stack),
+       _text_height(0),
+       _row_height(0),
        _delete_mapper(this),
        _show_hide_mapper(this)
 {
@@ -141,64 +156,48 @@ const std::shared_ptr<pv::data::DecoderStack>& DecodeTrace::decoder() const
        return _decoder_stack;
 }
 
-void DecodeTrace::set_view(pv::view::View *view)
+pair<int, int> DecodeTrace::v_extents() const
 {
-       assert(view);
-       Trace::set_view(view);
+       /// @todo Replace this with an implementation that knows the true
+       /// height of the trace
+       QFontMetrics m(QApplication::font());
+       const int text_height =  m.boundingRect(QRect(), 0, "Tg").height();
+       const int row_height = (text_height * 6) / 4;
+       return make_pair(-row_height / 2, row_height * 7 / 2);
 }
 
 void DecodeTrace::paint_back(QPainter &p, int left, int right)
 {
        Trace::paint_back(p, left, right);
-       paint_axis(p, get_y(), left, right);
+       paint_axis(p, get_visual_y(), left, right);
 }
 
 void DecodeTrace::paint_mid(QPainter &p, int left, int right)
 {
        using namespace pv::data::decode;
 
-       const double scale = _view->scale();
-       assert(scale > 0);
-
-       double samplerate = _decoder_stack->samplerate();
-
-       _cur_row_headings.clear();
-
-       // Show sample rate as 1Hz when it is unknown
-       if (samplerate == 0.0)
-               samplerate = 1.0;
-
-       const double pixels_offset = (_view->offset() -
-               _decoder_stack->get_start_time()) / scale;
-       const double samples_per_pixel = samplerate * scale;
-
-       const uint64_t start_sample = (uint64_t)max((left + pixels_offset) *
-               samples_per_pixel, 0.0);
-       const uint64_t end_sample = (uint64_t)max((right + pixels_offset) *
-               samples_per_pixel, 0.0);
-
        QFontMetrics m(QApplication::font());
-       const int text_height =  m.boundingRect(QRect(), 0, "Tg").height();
-       const int annotation_height = (text_height * 5) / 4;
-       const int row_height = (text_height * 6) / 4;
+       _text_height = m.boundingRect(QRect(), 0, "Tg").height();
+       _row_height = (_text_height * 6) / 4;
+       const int annotation_height = (_text_height * 5) / 4;
 
        assert(_decoder_stack);
        const QString err = _decoder_stack->error_message();
        if (!err.isEmpty())
        {
-               draw_unresolved_period(p, annotation_height, left, right,
-                       samples_per_pixel, pixels_offset);
+               draw_unresolved_period(p, annotation_height, left, right);
                draw_error(p, err, left, right);
                return;
        }
 
        // Iterate through the rows
-       assert(_view);
-       int y = get_y();
+       int y = get_visual_y();
+       pair<uint64_t, uint64_t> sample_range = get_sample_range(left, right);
 
        assert(_decoder_stack);
-
        const vector<Row> rows(_decoder_stack->get_visible_rows());
+
+       _visible_rows.clear();
        for (size_t i = 0; i < rows.size(); i++)
        {
                const Row &row = rows[i];
@@ -211,22 +210,20 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
 
                vector<Annotation> annotations;
                _decoder_stack->get_annotation_subset(annotations, row,
-                       start_sample, end_sample);
+                       sample_range.first, sample_range.second);
                if (!annotations.empty()) {
                        for (const Annotation &a : annotations)
                                draw_annotation(a, p, get_text_colour(),
-                                       annotation_height, left, right,
-                                       samples_per_pixel, pixels_offset, y,
+                                       annotation_height, left, right, y,
                                        base_colour);
-                       y += row_height;
+                       y += _row_height;
 
-                       _cur_row_headings.push_back(row.title());
+                       _visible_rows.push_back(rows[i]);
                }
        }
 
        // Draw the hatching
-       draw_unresolved_period(p, annotation_height, left, right,
-               samples_per_pixel, pixels_offset);
+       draw_unresolved_period(p, annotation_height, left, right);
 }
 
 void DecodeTrace::paint_fore(QPainter &p, int left, int right)
@@ -235,13 +232,11 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
 
        (void)right;
 
-       QFontMetrics m(QApplication::font());
-       const int text_height =  m.boundingRect(QRect(), 0, "Tg").height();
-       const int row_height = (text_height * 6) / 4;
+       assert(_row_height);
 
-       for (size_t i = 0; i < _cur_row_headings.size(); i++)
+       for (size_t i = 0; i < _visible_rows.size(); i++)
        {
-               const int y = i * row_height + get_y();
+               const int y = i * _row_height + get_visual_y();
 
                p.setPen(QPen(Qt::NoPen));
                p.setBrush(QApplication::palette().brush(QPalette::WindowText));
@@ -256,9 +251,9 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
                        p.drawPolygon(points, countof(points));
                }
 
-               const QRect r(left + ArrowSize * 2, y - row_height / 2,
-                       right - left, row_height);
-               const QString h(_cur_row_headings[i]);
+               const QRect r(left + ArrowSize * 2, y - _row_height / 2,
+                       right - left, _row_height);
+               const QString h(_visible_rows[i].title());
                const int f = Qt::AlignLeft | Qt::AlignVCenter |
                        Qt::TextDontClip;
 
@@ -342,10 +337,13 @@ QMenu* DecodeTrace::create_context_menu(QWidget *parent)
 }
 
 void DecodeTrace::draw_annotation(const pv::data::decode::Annotation &a,
-       QPainter &p, QColor text_color, int h, int left, int right,
-       double samples_per_pixel, double pixels_offset, int y,
+       QPainter &p, QColor text_color, int h, int left, int right, int y,
        size_t base_colour) const
 {
+       double samples_per_pixel, pixels_offset;
+       tie(pixels_offset, samples_per_pixel) =
+               get_pixels_offset_samples_per_pixel();
+
        const double start = a.start_sample() / samples_per_pixel -
                pixels_offset;
        const double end = a.end_sample() / samples_per_pixel -
@@ -445,7 +443,7 @@ void DecodeTrace::draw_range(const pv::data::decode::Annotation &a, QPainter &p,
 void DecodeTrace::draw_error(QPainter &p, const QString &message,
        int left, int right)
 {
-       const int y = get_y();
+       const int y = get_visual_y();
 
        p.setPen(ErrorBgColour.darker());
        p.setBrush(ErrorBgColour);
@@ -464,11 +462,13 @@ void DecodeTrace::draw_error(QPainter &p, const QString &message,
 }
 
 void DecodeTrace::draw_unresolved_period(QPainter &p, int h, int left,
-       int right, double samples_per_pixel, double pixels_offset) 
+       int right) const
 {
        using namespace pv::data;
        using pv::data::decode::Decoder;
 
+       double samples_per_pixel, pixels_offset;
+
        assert(_decoder_stack); 
 
        shared_ptr<Logic> data;
@@ -499,7 +499,11 @@ void DecodeTrace::draw_unresolved_period(QPainter &p, int h, int left,
        if (sample_count == samples_decoded)
                return;
 
-       const int y = get_y();
+       const int y = get_visual_y();
+
+       tie(pixels_offset, samples_per_pixel) =
+               get_pixels_offset_samples_per_pixel();
+
        const double start = max(samples_decoded /
                samples_per_pixel - pixels_offset, left - 1.0);
        const double end = min(sample_count / samples_per_pixel -
@@ -515,6 +519,125 @@ void DecodeTrace::draw_unresolved_period(QPainter &p, int h, int left,
        p.drawRect(no_decode_rect);
 }
 
+pair<double, double> DecodeTrace::get_pixels_offset_samples_per_pixel() const
+{
+       assert(_owner);
+       assert(_decoder_stack);
+
+       const View *view = _owner->view();
+       assert(view);
+
+       const double scale = view->scale();
+       assert(scale > 0);
+
+       const double pixels_offset =
+               (view->offset() - _decoder_stack->get_start_time()) / scale;
+
+       double samplerate = _decoder_stack->samplerate();
+
+       // Show sample rate as 1Hz when it is unknown
+       if (samplerate == 0.0)
+               samplerate = 1.0;
+
+       return make_pair(pixels_offset, samplerate * scale);
+}
+
+pair<uint64_t, uint64_t> DecodeTrace::get_sample_range(
+       int x_start, int x_end) const
+{
+       double samples_per_pixel, pixels_offset;
+       tie(pixels_offset, samples_per_pixel) =
+               get_pixels_offset_samples_per_pixel();
+
+       const uint64_t start = (uint64_t)max(
+               (x_start + pixels_offset) * samples_per_pixel, 0.0);
+       const uint64_t end = (uint64_t)max(
+               (x_end + pixels_offset) * samples_per_pixel, 0.0);
+
+       return make_pair(start, end);
+}
+
+int DecodeTrace::get_row_at_point(const QPoint &point)
+{
+       if (!_row_height)
+               return -1;
+
+       const int row = (point.y() - get_visual_y() + _row_height / 2) /
+               _row_height;
+       if (row < 0 || row >= (int)_visible_rows.size())
+               return -1;
+
+       return row;
+}
+
+const QString DecodeTrace::get_annotation_at_point(const QPoint &point)
+{
+       using namespace pv::data::decode;
+
+       if (!enabled())
+               return QString();
+
+       const pair<uint64_t, uint64_t> sample_range =
+               get_sample_range(point.x(), point.x() + 1);
+       const int row = get_row_at_point(point);
+       if (row < 0)
+               return QString();
+
+       vector<pv::data::decode::Annotation> annotations;
+
+       assert(_decoder_stack);
+       _decoder_stack->get_annotation_subset(annotations, _visible_rows[row],
+               sample_range.first, sample_range.second);
+
+       return (annotations.empty()) ?
+               QString() : annotations[0].annotations().front();
+}
+
+void DecodeTrace::hide_hover_annotation()
+{
+       QToolTip::hideText();
+}
+
+void DecodeTrace::hover_point_changed()
+{
+       assert(_owner);
+
+       const View *const view = _owner->view();
+       assert(view);
+
+       QPoint hp = view->hover_point();
+       QString ann = get_annotation_at_point(hp);
+
+       assert(view);
+       assert(_row_height);
+
+       if (ann.isEmpty()) {
+               hide_hover_annotation();
+               return;
+       }
+
+       const int hover_row = get_row_at_point(hp);
+
+       QFontMetrics m(QToolTip::font());
+       const QRect text_size = m.boundingRect(QRect(), 0, ann);
+
+       // This is OS-specific and unfortunately we can't query it, so
+       // use an approximation to at least try to minimize the error.
+       const int padding = 8;
+
+       // Make sure the tool tip doesn't overlap with the mouse cursor.
+       // If it did, the tool tip would constantly hide and re-appear.
+       // We also push it up by one row so that it appears above the
+       // decode trace, not below.
+       hp.setX(hp.x() - (text_size.width() / 2) - padding);
+
+       hp.setY(get_visual_y() - (_row_height / 2) +
+               (hover_row * _row_height) -
+               _row_height - text_size.height());
+
+       QToolTip::showText(view->viewport()->mapToGlobal(hp), ann);
+}
+
 void DecodeTrace::create_decoder_form(int index,
        shared_ptr<data::decode::Decoder> &dec, QWidget *parent,
        QFormLayout *form)
@@ -587,7 +710,8 @@ QComboBox* DecodeTrace::create_channel_selector(
 {
        assert(dec);
 
-       const vector< shared_ptr<Signal> > sigs = _session.get_signals();
+       shared_lock<shared_mutex> lock(_session.signals_mutex());
+       const vector< shared_ptr<Signal> > &sigs(_session.signals());
 
        assert(_decoder_stack);
        const auto channel_iter = dec->channels().find(pdch);
@@ -605,7 +729,7 @@ QComboBox* DecodeTrace::create_channel_selector(
 
                if (dynamic_pointer_cast<LogicSignal>(s) && s->enabled())
                {
-                       selector->addItem(s->get_name(),
+                       selector->addItem(s->name(),
                                qVariantFromValue((void*)s.get()));
                        if ((*channel_iter).second == s)
                                selector->setCurrentIndex(i + 1);
@@ -620,7 +744,9 @@ void DecodeTrace::commit_decoder_channels(shared_ptr<data::decode::Decoder> &dec
        assert(dec);
 
        map<const srd_channel*, shared_ptr<LogicSignal> > channel_map;
-       const vector< shared_ptr<Signal> > sigs = _session.get_signals();
+
+       shared_lock<shared_mutex> lock(_session.signals_mutex());
+       const vector< shared_ptr<Signal> > &sigs(_session.signals());
 
        for (const ChannelSelector &s : _channel_selectors)
        {
@@ -653,8 +779,8 @@ void DecodeTrace::commit_channels()
 
 void DecodeTrace::on_new_decode_data()
 {
-       if (_view)
-               _view->update_viewport();
+       if (_owner)
+               _owner->update_viewport();
 }
 
 void DecodeTrace::delete_pressed()
@@ -713,7 +839,7 @@ void DecodeTrace::on_show_hide_decoder(int index)
        assert(index < (int)_decoder_forms.size());
        _decoder_forms[index]->set_decoder_visible(show);
 
-       _view->update_viewport();
+       _owner->update_viewport();
 }
 
 } // namespace view