]> sigrok.org Git - pulseview.git/blobdiff - pv/mainwindow.cpp
Move run/stop button from the menu bar to the tab widget
[pulseview.git] / pv / mainwindow.cpp
index 53ff35a9d427dcc108343e318281b3ecf5dc6d67..22e4e80e10f6a2ad3b803abcedfd4a88f5500bec 100644 (file)
@@ -32,6 +32,7 @@
 #include <QCloseEvent>
 #include <QDockWidget>
 #include <QHBoxLayout>
+#include <QMessageBox>
 #include <QSettings>
 #include <QWidget>
 
@@ -71,9 +72,13 @@ MainWindow::MainWindow(DeviceManager &device_manager,
        QMainWindow(parent),
        device_manager_(device_manager),
        session_selector_(this),
+       session_state_mapper_(this),
        action_view_sticky_scrolling_(new QAction(this)),
        action_view_coloured_bg_(new QAction(this)),
-       action_about_(new QAction(this))
+       action_about_(new QAction(this)),
+       icon_red_(":/icons/status-red.svg"),
+       icon_green_(":/icons/status-green.svg"),
+       icon_grey_(":/icons/status-grey.svg")
 {
        qRegisterMetaType<util::Timestamp>("util::Timestamp");
 
@@ -230,13 +235,18 @@ shared_ptr<Session> MainWindow::add_session()
                this, SLOT(on_add_view(const QString&, views::ViewType, Session*)));
        connect(session.get(), SIGNAL(name_changed()),
                this, SLOT(on_session_name_changed()));
+       session_state_mapper_.setMapping(session.get(), session.get());
+       connect(session.get(), SIGNAL(capture_state_changed(int)),
+               &session_state_mapper_, SLOT(map()));
 
        sessions_.push_back(session);
 
        QMainWindow *window = new QMainWindow();
        window->setWindowFlags(Qt::Widget);  // Remove Qt::Window flag
        session_windows_[session] = window;
-       session_selector_.addTab(window, name);
+
+       int index = session_selector_.addTab(window, name);
+       session_selector_.setCurrentIndex(index);
 
        window->setDockNestingEnabled(true);
 
@@ -248,6 +258,8 @@ shared_ptr<Session> MainWindow::add_session()
 
 void MainWindow::remove_session(shared_ptr<Session> session)
 {
+       int h = new_session_button_->height();
+
        for (shared_ptr<views::ViewBase> view : session->views()) {
                // Find the dock the view is contained in and remove it
                for (auto entry : view_docks_)
@@ -274,10 +286,21 @@ void MainWindow::remove_session(shared_ptr<Session> session)
        sessions_.remove_if([&](shared_ptr<Session> s) {
                return s == session; });
 
-       // Update the window title if there is no view left to
-       // generate focus change events
-       if (sessions_.empty())
+       if (sessions_.empty()) {
+               // When there are no more tabs, the height of the QTabWidget
+               // drops to zero. We must prevent this to keep the static
+               // widgets visible
+               for (QWidget *w : static_tab_widget_->findChildren<QWidget*>())
+                       w->setMinimumHeight(h);
+
+               int margin = static_tab_widget_->layout()->contentsMargins().bottom();
+               static_tab_widget_->setMinimumHeight(h + 2 * margin);
+               session_selector_.setMinimumHeight(h + 2 * margin);
+
+               // Update the window title if there is no view left to
+               // generate focus change events
                setWindowTitle(WindowTitle);
+       }
 }
 
 void MainWindow::setup_ui()
@@ -314,22 +337,33 @@ void MainWindow::setup_ui()
                QIcon(":/icons/document-new.png")));
        new_session_button_->setAutoRaise(true);
 
+       run_stop_button_ = new QToolButton();
+       run_stop_button_->setAutoRaise(true);
+       run_stop_button_->setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
+       run_stop_button_->setShortcut(QKeySequence(Qt::Key_Space));
+
        QHBoxLayout* layout = new QHBoxLayout();
        layout->setContentsMargins(2, 2, 2, 2);
        layout->addWidget(new_session_button_);
+       layout->addWidget(run_stop_button_);
 
-       QWidget* static_tab_widget_ = new QWidget();
+       static_tab_widget_ = new QWidget();
        static_tab_widget_->setLayout(layout);
 
        session_selector_.setCornerWidget(static_tab_widget_, Qt::TopLeftCorner);
-
        session_selector_.setTabsClosable(true);
 
        connect(new_session_button_, SIGNAL(clicked(bool)),
                this, SLOT(on_new_session_clicked()));
+       connect(run_stop_button_, SIGNAL(clicked(bool)),
+               this, SLOT(on_run_stop_clicked()));
+       connect(&session_state_mapper_, SIGNAL(mapped(QObject*)),
+               this, SLOT(on_capture_state_changed(QObject*)));
 
        connect(&session_selector_, SIGNAL(tabCloseRequested(int)),
                this, SLOT(on_tab_close_requested(int)));
+       connect(&session_selector_, SIGNAL(currentChanged(int)),
+               this, SLOT(on_tab_changed(int)));
 
 
        connect(static_cast<QApplication *>(QCoreApplication::instance()),
@@ -393,6 +427,16 @@ void MainWindow::restore_ui_settings()
        }
 }
 
+std::shared_ptr<Session> MainWindow::get_tab_session(int index) const
+{
+       // Find the session that belongs to the tab's main window
+       for (auto entry : session_windows_)
+               if (entry.second == session_selector_.widget(index))
+                       return entry.first;
+
+       return nullptr;
+}
+
 void MainWindow::closeEvent(QCloseEvent *event)
 {
        save_ui_settings();
@@ -415,6 +459,23 @@ bool MainWindow::restoreState(const QByteArray &state, int version)
        return false;
 }
 
+void MainWindow::session_error(const QString text, const QString info_text)
+{
+       QMetaObject::invokeMethod(this, "show_session_error",
+               Qt::QueuedConnection, Q_ARG(QString, text),
+               Q_ARG(QString, info_text));
+}
+
+void MainWindow::show_session_error(const QString text, const QString info_text)
+{
+       QMessageBox msg(this);
+       msg.setText(text);
+       msg.setInformativeText(info_text);
+       msg.setStandardButtons(QMessageBox::Ok);
+       msg.setIcon(QMessageBox::Warning);
+       msg.exec();
+}
+
 void MainWindow::on_add_view(const QString &title, views::ViewType type,
        Session *session)
 {
@@ -426,28 +487,63 @@ void MainWindow::on_add_view(const QString &title, views::ViewType type,
 
 void MainWindow::on_focus_changed()
 {
-       shared_ptr<views::ViewBase> view;
-       bool title_set = false;
-
-       view = get_active_view();
-
-       for (shared_ptr<Session> session : sessions_) {
-               if (!session->has_view(view))
-                       continue;
-
-               setWindowTitle(session->name() + " - " + WindowTitle);
-               title_set = true;
+       static shared_ptr<Session> prev_session;
+
+       shared_ptr<views::ViewBase> view = get_active_view();
+
+       if (view) {
+               for (shared_ptr<Session> session : sessions_) {
+                       if (session->has_view(view)) {
+                               if (session != prev_session) {
+                                       // Activate correct tab if necessary
+                                       shared_ptr<Session> tab_session = get_tab_session(
+                                               session_selector_.currentIndex());
+                                       if (tab_session != session)
+                                               session_selector_.setCurrentWidget(
+                                                       session_windows_.at(session));
+
+                                       on_focused_session_changed(session);
+                               }
+
+                               prev_session = session;
+                               break;
+                       }
+               }
        }
 
-       if (!title_set)
+       if (sessions_.empty())
                setWindowTitle(WindowTitle);
 }
 
+void MainWindow::on_focused_session_changed(shared_ptr<Session> session)
+{
+       setWindowTitle(session->name() + " - " + WindowTitle);
+
+       // Update the state of the run/stop button, too
+       on_capture_state_changed(session.get());
+}
+
 void MainWindow::on_new_session_clicked()
 {
        add_session();
 }
 
+void MainWindow::on_run_stop_clicked()
+{
+       Session &session = get_active_view()->session();
+
+       switch (session.get_capture_state()) {
+       case Session::Stopped:
+               session.start_capture([&](QString message) {
+                       session_error("Capture failed", message); });
+               break;
+       case Session::AwaitingTrigger:
+       case Session::Running:
+               session.stop_capture();
+               break;
+       }
+}
+
 void MainWindow::on_session_name_changed()
 {
        // Update the corresponding dock widget's name(s)
@@ -464,7 +560,31 @@ void MainWindow::on_session_name_changed()
        }
 
        // Refresh window title if the affected session has focus
-       on_focus_changed();
+       shared_ptr<views::ViewBase> view = get_active_view();
+
+       if (view && session->has_view(view))
+               setWindowTitle(session->name() + " - " + WindowTitle);
+}
+
+void MainWindow::on_capture_state_changed(QObject *obj)
+{
+       Session *caller = qobject_cast<Session*>(obj);
+
+       // Ignore if caller is not the currently focused session
+       // unless there is only one session
+       if (sessions_.size() > 1) {
+               Session &focused_session = get_active_view()->session();
+
+               if (caller != &focused_session)
+                       return;
+       }
+
+       int state = caller->get_capture_state();
+
+       const QIcon *icons[] = {&icon_grey_, &icon_red_, &icon_green_};
+       run_stop_button_->setIcon(*icons[state]);
+       run_stop_button_->setText((state == pv::Session::Stopped) ?
+               tr("Run") : tr("Stop"));
 }
 
 void MainWindow::on_new_view(Session *session)
@@ -509,16 +629,22 @@ void MainWindow::on_view_close_clicked()
        }
 }
 
+void MainWindow::on_tab_changed(int index)
+{
+       shared_ptr<Session> session = get_tab_session(index);
+
+       if (session)
+               on_focused_session_changed(session);
+}
+
 void MainWindow::on_tab_close_requested(int index)
 {
        // TODO Ask user if this is intended in case data is unsaved
 
-       // Find the session that belongs to this main window and remove it
-       for (auto entry : session_windows_)
-               if (entry.second == session_selector_.widget(index)) {
-                       remove_session(entry.first);
-                       break;
-               }
+       shared_ptr<Session> session = get_tab_session(index);
+
+       if (session)
+               remove_session(session);
 }
 
 void MainWindow::on_actionViewStickyScrolling_triggered()