logic_mux_data_ = make_shared<Logic>(ch_count);
}
- // Receive notifications when new sample data is available
- connect_input_notifiers();
-
if (get_input_segment_count() == 0)
set_error_message(tr("No input data"));
{
bool new_assignment = false;
+ // Disconnect all input signal notifications so we don't have duplicate connections
+ disconnect_input_notifiers();
+
// Try to auto-select channels that don't have signals assigned yet
for (decode::DecodeChannel& ch : channels_) {
// If a decoder is given, auto-assign only its channels
}
}
- if (match) {
+ // Prevent using a signal more than once as D1 would match e.g. D1 and D10
+ bool signal_not_already_used = true;
+ for (decode::DecodeChannel& ch : channels_)
+ if (ch.assigned_signal && (ch.assigned_signal == match))
+ signal_not_already_used = false;
+
+ if (match && signal_not_already_used) {
ch.assigned_signal = match;
new_assignment = true;
}
}
if (new_assignment) {
+ // Receive notifications when new sample data is available
+ connect_input_notifiers();
+
logic_mux_data_invalid_ = true;
stack_config_changed_ = true;
commit_decoder_channels();
void DecodeSignal::assign_signal(const uint16_t channel_id, shared_ptr<const SignalBase> signal)
{
+ // Disconnect all input signal notifications so we don't have duplicate connections
+ disconnect_input_notifiers();
+
for (decode::DecodeChannel& ch : channels_)
if (ch.id == channel_id) {
ch.assigned_signal = signal;
logic_mux_data_invalid_ = true;
}
+ // Receive notifications when new sample data is available
+ connect_input_notifiers();
+
stack_config_changed_ = true;
commit_decoder_channels();
channels_updated();
return rows;
}
-
uint64_t DecodeSignal::get_annotation_count(const Row* row, uint32_t segment_id) const
{
if (segment_id >= segments_.size())
settings.endGroup();
}
+ connect_input_notifiers();
+
// Update the internal structures
stack_config_changed_ = true;
update_channel_list();
output_segment->set_complete();
if (segment_id < get_input_segment_count() - 1) {
+
// Process next segment
segment_id++;
logic_mux_data_->push_segment(output_segment);
output_segment->set_samplerate(get_input_samplerate(segment_id));
+ } else {
+ // Wait for more input data if we're processing the currently last segment
+ unique_lock<mutex> logic_mux_lock(logic_mux_mutex_);
+ logic_mux_cond_.wait(logic_mux_lock);
}
} else {
- // Wait for more input
+ // Input segments aren't all complete yet but samples_to_process is 0, wait for more input data
unique_lock<mutex> logic_mux_lock(logic_mux_mutex_);
logic_mux_cond_.wait(logic_mux_lock);
}
const int64_t chunk_sample_count = DecodeChunkLength / unit_size;
for (int64_t i = abs_start_samplenum;
- error_message_.isEmpty() && !decode_interrupt_ &&
- (i < (abs_start_samplenum + sample_count));
+ !decode_interrupt_ && (i < (abs_start_samplenum + sample_count));
i += chunk_sample_count) {
const int64_t chunk_end = min(i + chunk_sample_count,
// If the input segment is complete, we've exhausted this segment
if (input_segment->is_complete()) {
- if (current_segment_id_ < logic_mux_data_->logic_segments().size() - 1) {
+ if (current_segment_id_ < (logic_mux_data_->logic_segments().size() - 1)) {
// Process next segment
current_segment_id_++;
// All segments have been processed
if (!decode_interrupt_)
decode_finished();
+
+ // Wait for more input data
+ unique_lock<mutex> input_wait_lock(input_mutex_);
+ decode_input_cond_.wait(input_wait_lock);
}
} else {
- // Wait for more input data
+ // Input segment isn't complete yet but samples_to_process is 0, wait for more input data
unique_lock<mutex> input_wait_lock(input_mutex_);
decode_input_cond_.wait(input_wait_lock);
}
+
}
} while (!decode_interrupt_);
}
void DecodeSignal::connect_input_notifiers()
{
- // Disconnect the notification slot from the previous set of signals
- disconnect(this, SLOT(on_data_cleared()));
- disconnect(this, SLOT(on_data_received()));
-
// Connect the currently used signals to our slot
for (decode::DecodeChannel& ch : channels_) {
if (!ch.assigned_signal)
continue;
+ const data::SignalBase *signal = ch.assigned_signal.get();
+ connect(signal, SIGNAL(samples_cleared()),
+ this, SLOT(on_data_cleared()), Qt::UniqueConnection);
+ connect(signal, SIGNAL(samples_added(uint64_t, uint64_t, uint64_t)),
+ this, SLOT(on_data_received()), Qt::UniqueConnection);
+
+ if (signal->logic_data())
+ connect(signal->logic_data().get(), SIGNAL(segment_completed()),
+ this, SLOT(on_input_segment_completed()), Qt::UniqueConnection);
+ }
+}
+
+void DecodeSignal::disconnect_input_notifiers()
+{
+ // Disconnect the notification slot from the previous set of signals
+ for (decode::DecodeChannel& ch : channels_) {
+ if (!ch.assigned_signal)
+ continue;
const data::SignalBase *signal = ch.assigned_signal.get();
- connect(signal, &data::SignalBase::samples_cleared,
- this, &DecodeSignal::on_data_cleared);
- connect(signal, &data::SignalBase::samples_added,
- this, &DecodeSignal::on_data_received);
+ disconnect(signal, nullptr, this, SLOT(on_data_cleared()));
+ disconnect(signal, nullptr, this, SLOT(on_data_received()));
+
+ if (signal->logic_data())
+ disconnect(signal->logic_data().get(), nullptr, this, SLOT(on_input_segment_completed()));
}
}
void DecodeSignal::on_data_received()
{
// If we detected a lack of input data when trying to start decoding,
- // we have set an error message. Only try again if we now have data
+ // we have set an error message. Bail out if we still don't have data
// to work with
if ((!error_message_.isEmpty()) && (get_input_segment_count() == 0))
return;
+ if (!error_message_.isEmpty()) {
+ error_message_.clear();
+ // TODO Emulate noquote()
+ qDebug().nospace() << name() << ": Input data available, error cleared";
+ }
+
if (!logic_mux_thread_.joinable())
begin_decode();
else
logic_mux_cond_.notify_one();
}
+void DecodeSignal::on_input_segment_completed()
+{
+ if (!logic_mux_thread_.joinable())
+ logic_mux_cond_.notify_one();
+}
+
void DecodeSignal::on_annotation_visibility_changed()
{
annotation_visibility_changed();
projects / pulseview.git / blobdiff