[pulseview.git] / pv / view / view.cpp

/*
 * This file is part of the PulseView project.
 *
 * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 */

#include <assert.h>
#include <limits.h>
#include <math.h>

#include <boost/foreach.hpp>

#include <QEvent>
#include <QMouseEvent>
#include <QScrollBar>

#include "header.h"
#include "ruler.h"
#include "signal.h"
#include "view.h"
#include "viewport.h"

#include "pv/sigsession.h"
#include "pv/data/logic.h"
#include "pv/data/logicsnapshot.h"

using namespace boost;
using namespace std;

namespace pv {
namespace view {

const double View::MaxScale = 1e9;
const double View::MinScale = 1e-15;

const int View::LabelMarginWidth = 70;
const int View::RulerHeight = 30;

const int View::MaxScrollValue = INT_MAX / 2;

const int View::SignalHeight = 30;
const int View::SignalMargin = 10;
const int View::SignalSnapGridSize = 10;

const QColor View::CursorAreaColour(220, 231, 243);

const QSizeF View::LabelPadding(4, 0);

View::View(SigSession &session, QWidget *parent) :
	QAbstractScrollArea(parent),
	_session(session),
	_viewport(new Viewport(*this)),
	_ruler(new Ruler(*this)),
	_header(new Header(*this)),
	_data_length(0),
	_scale(1e-6),
	_offset(0),
	_v_offset(0),
	_updating_scroll(false),
	_show_cursors(false),
	_cursors(*this),
	_hover_point(-1, -1)
{
	connect(horizontalScrollBar(), SIGNAL(valueChanged(int)),
		this, SLOT(h_scroll_value_changed(int)));
	connect(verticalScrollBar(), SIGNAL(valueChanged(int)),
		this, SLOT(v_scroll_value_changed(int)));

	connect(&_session, SIGNAL(signals_changed()),
		this, SLOT(signals_changed()));
	connect(&_session, SIGNAL(data_updated()),
		this, SLOT(data_updated()));

	connect(&_cursors.first(), SIGNAL(time_changed()),
		this, SLOT(marker_time_changed()));
	connect(&_cursors.second(), SIGNAL(time_changed()),
		this, SLOT(marker_time_changed()));

	connect(_header, SIGNAL(signals_moved()),
		this, SLOT(on_signals_moved()));

	connect(_header, SIGNAL(selection_changed()),
		_ruler, SLOT(clear_selection()));
	connect(_ruler, SIGNAL(selection_changed()),
		_header, SLOT(clear_selection()));

	connect(_header, SIGNAL(selection_changed()),
		this, SIGNAL(selection_changed()));
	connect(_ruler, SIGNAL(selection_changed()),
		this, SIGNAL(selection_changed()));

	setViewportMargins(LabelMarginWidth, RulerHeight, 0, 0);
	setViewport(_viewport);

	_viewport->installEventFilter(this);
	_ruler->installEventFilter(this);
	_header->installEventFilter(this);
}

SigSession& View::session()
{
	return _session;
}

double View::scale() const
{
	return _scale;
}

double View::offset() const
{
	return _offset;
}

int View::v_offset() const
{
	return _v_offset;
}

void View::zoom(double steps)
{
	zoom(steps, (width() - LabelMarginWidth) / 2);
}

void View::zoom(double steps, int offset)
{
	const double cursor_offset = _offset + _scale * offset;
	_scale *= pow(3.0/2.0, -steps);
	_scale = max(min(_scale, MaxScale), MinScale);
	_offset = cursor_offset - _scale * offset;

	_ruler->update();
	_viewport->update();
	update_scroll();
}


void View::set_scale_offset(double scale, double offset)
{
	_scale = scale;
	_offset = offset;

	update_scroll();
	_ruler->update();
	_viewport->update();
}

bool View::cursors_shown() const
{
	return _show_cursors;
}

void View::show_cursors(bool show)
{
	_show_cursors = show;
	_ruler->update();
	_viewport->update();
}

void View::centre_cursors()
{
	const double time_width = _scale * _viewport->width();
	_cursors.first().set_time(_offset + time_width * 0.4);
	_cursors.second().set_time(_offset + time_width * 0.6);
	_ruler->update();
	_viewport->update();
}

CursorPair& View::cursors()
{
	return _cursors;
}

const QPoint& View::hover_point() const
{
	return _hover_point;
}

void View::normalize_layout()
{
	const vector< shared_ptr<Signal> > sigs(_session.get_signals());

	int v_min = INT_MAX;
	BOOST_FOREACH(const shared_ptr<Signal> s, sigs)
		v_min = min(s->get_v_offset(), v_min);

	const int delta = -min(v_min, 0);
	BOOST_FOREACH(shared_ptr<Signal> s, sigs)
		s->set_v_offset(s->get_v_offset() + delta);

	verticalScrollBar()->setSliderPosition(_v_offset + delta);
	v_scroll_value_changed(verticalScrollBar()->sliderPosition());
}

void View::get_scroll_layout(double &length, double &offset) const
{
	const shared_ptr<data::SignalData> sig_data = _session.get_data();
	if (!sig_data)
		return;

	length = _data_length / (sig_data->get_samplerate() * _scale);
	offset = _offset / _scale;
}

void View::update_scroll()
{
	assert(_viewport);

	const QSize areaSize = _viewport->size();

	// Set the horizontal scroll bar
	double length = 0, offset = 0;
	get_scroll_layout(length, offset);
	length = max(length - areaSize.width(), 0.0);

	horizontalScrollBar()->setPageStep(areaSize.width() / 2);

	_updating_scroll = true;

	if (length < MaxScrollValue) {
		horizontalScrollBar()->setRange(0, length);
		horizontalScrollBar()->setSliderPosition(offset);
	} else {
		horizontalScrollBar()->setRange(0, MaxScrollValue);
		horizontalScrollBar()->setSliderPosition(
			_offset * MaxScrollValue / (_scale * length));
	}

	_updating_scroll = false;

	// Set the vertical scrollbar
	verticalScrollBar()->setPageStep(areaSize.height());
	verticalScrollBar()->setRange(0,
		_viewport->get_total_height() + SignalMargin -
		areaSize.height());
}

void View::reset_signal_layout()
{
	int offset = SignalMargin + SignalHeight;
	const vector< shared_ptr<Signal> > sigs(_session.get_signals());
	BOOST_FOREACH(shared_ptr<Signal> s, sigs) {
		s->set_v_offset(offset);
		offset += SignalHeight + 2 * SignalMargin;
	}

	normalize_layout();
}

bool View::eventFilter(QObject *object, QEvent *event)
{
	const QEvent::Type type = event->type();
	if (type == QEvent::MouseMove) {

		const QMouseEvent *const mouse_event = (QMouseEvent*)event;
		if (object == _viewport)
			_hover_point = mouse_event->pos();
		else if (object == _ruler)
			_hover_point = QPoint(mouse_event->x(), 0);
		else if (object == _header)
			_hover_point = QPoint(0, mouse_event->y());
		else
			_hover_point = QPoint(-1, -1);

		hover_point_changed();

	} else if (type == QEvent::Leave) {
		_hover_point = QPoint(-1, -1);
		hover_point_changed();
	}

	return QObject::eventFilter(object, event);
}

bool View::viewportEvent(QEvent *e)
{
	switch(e->type()) {
	case QEvent::Paint:
	case QEvent::MouseButtonPress:
	case QEvent::MouseButtonRelease:
	case QEvent::MouseButtonDblClick:
	case QEvent::MouseMove:
	case QEvent::Wheel:
		return false;

	default:
		return QAbstractScrollArea::viewportEvent(e);
	}
}

void View::resizeEvent(QResizeEvent*)
{
	_ruler->setGeometry(_viewport->x(), 0,
		_viewport->width(), _viewport->y());
	_header->setGeometry(0, _viewport->y(),
		_viewport->x(), _viewport->height());
	update_scroll();
}

void View::h_scroll_value_changed(int value)
{
	if (_updating_scroll)
		return;

	const int range = horizontalScrollBar()->maximum();
	if (range < MaxScrollValue)
		_offset = _scale * value;
	else {
		double length = 0, offset;
		get_scroll_layout(length, offset);
		_offset = _scale * length * value / MaxScrollValue;
	}

	_ruler->update();
	_viewport->update();
}

void View::v_scroll_value_changed(int value)
{
	_v_offset = value;
	_header->update();
	_viewport->update();
}

void View::signals_changed()
{
	reset_signal_layout();
}

void View::data_updated()
{
	// Get the new data length
	_data_length = 0;
	shared_ptr<data::Logic> sig_data = _session.get_data();
	if (sig_data) {
		deque< shared_ptr<data::LogicSnapshot> > &snapshots =
			sig_data->get_snapshots();
		BOOST_FOREACH(shared_ptr<data::LogicSnapshot> s, snapshots)
			if (s)
				_data_length = max(_data_length,
					s->get_sample_count());
	}

	// Update the scroll bars
	update_scroll();

	// Repaint the view
	_viewport->update();
}

void View::marker_time_changed()
{
	_ruler->update();
	_viewport->update();
}

void View::on_signals_moved()
{
	update_scroll();
	signals_moved();
}

} // namespace view
} // namespace pv
Commit	Line	Data
adb4b10c	1	/*
b3f22de0	2	* This file is part of the PulseView project.
adb4b10c JH	3	*
	4	* Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
	5	*
	6	* This program is free software; you can redistribute it and/or modify
	7	* it under the terms of the GNU General Public License as published by
	8	* the Free Software Foundation; either version 2 of the License, or
	9	* (at your option) any later version.
	10	*
	11	* This program is distributed in the hope that it will be useful,
	12	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	13	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	14	* GNU General Public License for more details.
	15	*
	16	* You should have received a copy of the GNU General Public License
	17	* along with this program; if not, write to the Free Software
	18	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	19	*/
	20
	21	#include <assert.h>
f25770e2	22	#include <limits.h>
adb4b10c JH	23	#include <math.h>
	24
	25	#include <boost/foreach.hpp>
	26
	27	#include <QEvent>
cbd80f64	28	#include <QMouseEvent>
adb4b10c JH	29	#include <QScrollBar>
adb4b10c JH	30
1d8dca91	31	#include "header.h"
ccdd3ef5	32	#include "ruler.h"
2e575351	33	#include "signal.h"
cdf7bea7 JH	34	#include "view.h"
cdf7bea7 JH	35	#include "viewport.h"
adb4b10c	36
1b1ec774 JH	37	#include "pv/sigsession.h"
	38	#include "pv/data/logic.h"
	39	#include "pv/data/logicsnapshot.h"
adb4b10c JH	40
	41	using namespace boost;
	42	using namespace std;
	43
cdf7bea7 JH	44	namespace pv {
cdf7bea7 JH	45	namespace view {
adb4b10c	46
cdf7bea7 JH	47	const double View::MaxScale = 1e9;
cdf7bea7 JH	48	const double View::MinScale = 1e-15;
adb4b10c	49
cdf7bea7 JH	50	const int View::LabelMarginWidth = 70;
	51	const int View::RulerHeight = 30;
	52
f25770e2 JH	53	const int View::MaxScrollValue = INT_MAX / 2;
f25770e2 JH	54
8d44d030 JH	55	const int View::SignalHeight = 30;
8d44d030 JH	56	const int View::SignalMargin = 10;
49153683	57	const int View::SignalSnapGridSize = 10;
1d8dca91	58
f76af637 JH	59	const QColor View::CursorAreaColour(220, 231, 243);
f76af637 JH	60
2e04f9bd JH	61	const QSizeF View::LabelPadding(4, 0);
2e04f9bd JH	62
cdf7bea7	63	View::View(SigSession &session, QWidget *parent) :
adb4b10c JH	64	QAbstractScrollArea(parent),
adb4b10c JH	65	_session(session),
cdf7bea7	66	_viewport(new Viewport(*this)),
ccdd3ef5	67	_ruler(new Ruler(*this)),
1d8dca91	68	_header(new Header(*this)),
adb4b10c JH	69	_data_length(0),
	70	_scale(1e-6),
	71	_offset(0),
cbd80f64	72	_v_offset(0),
528bd8a1	73	_updating_scroll(false),
f76af637	74	_show_cursors(false),
b42d25c4	75	_cursors(*this),
cbd80f64	76	_hover_point(-1, -1)
adb4b10c	77	{
b16907d3 JH	78	connect(horizontalScrollBar(), SIGNAL(valueChanged(int)),
b16907d3 JH	79	this, SLOT(h_scroll_value_changed(int)));
adb4b10c JH	80	connect(verticalScrollBar(), SIGNAL(valueChanged(int)),
adb4b10c JH	81	this, SLOT(v_scroll_value_changed(int)));
69dd2b03 JH	82
	83	connect(&_session, SIGNAL(signals_changed()),
	84	this, SLOT(signals_changed()));
adb4b10c JH	85	connect(&_session, SIGNAL(data_updated()),
adb4b10c JH	86	this, SLOT(data_updated()));
1d8dca91	87
b42d25c4	88	connect(&_cursors.first(), SIGNAL(time_changed()),
ca4ec3ea	89	this, SLOT(marker_time_changed()));
b42d25c4	90	connect(&_cursors.second(), SIGNAL(time_changed()),
ca4ec3ea JH	91	this, SLOT(marker_time_changed()));
ca4ec3ea JH	92
54401bbb	93	connect(_header, SIGNAL(signals_moved()),
07204819	94	this, SLOT(on_signals_moved()));
54401bbb	95
17348f85 JH	96	connect(_header, SIGNAL(selection_changed()),
	97	_ruler, SLOT(clear_selection()));
	98	connect(_ruler, SIGNAL(selection_changed()),
	99	_header, SLOT(clear_selection()));
	100
8b454527 JH	101	connect(_header, SIGNAL(selection_changed()),
	102	this, SIGNAL(selection_changed()));
	103	connect(_ruler, SIGNAL(selection_changed()),
	104	this, SIGNAL(selection_changed()));
	105
ccdd3ef5	106	setViewportMargins(LabelMarginWidth, RulerHeight, 0, 0);
adb4b10c	107	setViewport(_viewport);
cbd80f64 JH	108
	109	_viewport->installEventFilter(this);
	110	_ruler->installEventFilter(this);
	111	_header->installEventFilter(this);
adb4b10c JH	112	}
adb4b10c JH	113
1d19ef83 JH	114	SigSession& View::session()
	115	{
	116	return _session;
	117	}
	118
cdf7bea7	119	double View::scale() const
adb4b10c JH	120	{
	121	return _scale;
	122	}
	123
cdf7bea7	124	double View::offset() const
adb4b10c JH	125	{
	126	return _offset;
	127	}
	128
cdf7bea7	129	int View::v_offset() const
adb4b10c JH	130	{
	131	return _v_offset;
	132	}
	133
cdf7bea7	134	void View::zoom(double steps)
adb4b10c JH	135	{
	136	zoom(steps, (width() - LabelMarginWidth) / 2);
	137	}
	138
17c0f398 JH	139	void View::zoom(double steps, int offset)
	140	{
	141	const double cursor_offset = _offset + _scale * offset;
	142	_scale *= pow(3.0/2.0, -steps);
	143	_scale = max(min(_scale, MaxScale), MinScale);
	144	_offset = cursor_offset - _scale * offset;
	145
	146	_ruler->update();
	147	_viewport->update();
	148	update_scroll();
	149	}
	150
	151
cdf7bea7	152	void View::set_scale_offset(double scale, double offset)
adb4b10c JH	153	{
	154	_scale = scale;
	155	_offset = offset;
ccdd3ef5	156
adb4b10c	157	update_scroll();
ccdd3ef5	158	_ruler->update();
adb4b10c JH	159	_viewport->update();
	160	}
	161
f76af637 JH	162	bool View::cursors_shown() const
	163	{
	164	return _show_cursors;
	165	}
	166
	167	void View::show_cursors(bool show)
	168	{
	169	_show_cursors = show;
	170	_ruler->update();
	171	_viewport->update();
	172	}
	173
b4d91e56 JH	174	void View::centre_cursors()
	175	{
	176	const double time_width = _scale * _viewport->width();
	177	_cursors.first().set_time(_offset + time_width * 0.4);
	178	_cursors.second().set_time(_offset + time_width * 0.6);
	179	_ruler->update();
	180	_viewport->update();
	181	}
	182
b42d25c4	183	CursorPair& View::cursors()
f76af637 JH	184	{
	185	return _cursors;
	186	}
	187
cbd80f64 JH	188	const QPoint& View::hover_point() const
	189	{
	190	return _hover_point;
	191	}
	192
4b192962 JH	193	void View::normalize_layout()
4b192962 JH	194	{
3868e5fa	195	const vector< shared_ptr<Signal> > sigs(_session.get_signals());
4b192962 JH	196
	197	int v_min = INT_MAX;
	198	BOOST_FOREACH(const shared_ptr<Signal> s, sigs)
	199	v_min = min(s->get_v_offset(), v_min);
	200
	201	const int delta = -min(v_min, 0);
	202	BOOST_FOREACH(shared_ptr<Signal> s, sigs)
	203	s->set_v_offset(s->get_v_offset() + delta);
	204
	205	verticalScrollBar()->setSliderPosition(_v_offset + delta);
	206	v_scroll_value_changed(verticalScrollBar()->sliderPosition());
	207	}
	208
f25770e2 JH	209	void View::get_scroll_layout(double &length, double &offset) const
f25770e2 JH	210	{
1b1ec774	211	const shared_ptr<data::SignalData> sig_data = _session.get_data();
333d5bbc	212	if (!sig_data)
f25770e2 JH	213	return;
	214
	215	length = _data_length / (sig_data->get_samplerate() * _scale);
	216	offset = _offset / _scale;
	217	}
	218
cdf7bea7	219	void View::update_scroll()
adb4b10c JH	220	{
	221	assert(_viewport);
	222
	223	const QSize areaSize = _viewport->size();
	224
	225	// Set the horizontal scroll bar
	226	double length = 0, offset = 0;
f25770e2 JH	227	get_scroll_layout(length, offset);
f25770e2 JH	228	length = max(length - areaSize.width(), 0.0);
adb4b10c	229
b4ef7f2a	230	horizontalScrollBar()->setPageStep(areaSize.width() / 2);
f25770e2	231
528bd8a1 JH	232	_updating_scroll = true;
528bd8a1 JH	233
333d5bbc	234	if (length < MaxScrollValue) {
f25770e2 JH	235	horizontalScrollBar()->setRange(0, length);
	236	horizontalScrollBar()->setSliderPosition(offset);
	237	} else {
	238	horizontalScrollBar()->setRange(0, MaxScrollValue);
	239	horizontalScrollBar()->setSliderPosition(
	240	_offset * MaxScrollValue / (_scale * length));
	241	}
adb4b10c	242
528bd8a1 JH	243	_updating_scroll = false;
528bd8a1 JH	244
adb4b10c JH	245	// Set the vertical scrollbar
	246	verticalScrollBar()->setPageStep(areaSize.height());
	247	verticalScrollBar()->setRange(0,
4b192962 JH	248	_viewport->get_total_height() + SignalMargin -
4b192962 JH	249	areaSize.height());
adb4b10c JH	250	}
adb4b10c JH	251
2e575351 JH	252	void View::reset_signal_layout()
2e575351 JH	253	{
2658961b	254	int offset = SignalMargin + SignalHeight;
3868e5fa	255	const vector< shared_ptr<Signal> > sigs(_session.get_signals());
2e575351 JH	256	BOOST_FOREACH(shared_ptr<Signal> s, sigs) {
2e575351 JH	257	s->set_v_offset(offset);
8d44d030	258	offset += SignalHeight + 2 * SignalMargin;
2e575351	259	}
4b192962 JH	260
4b192962 JH	261	normalize_layout();
2e575351 JH	262	}
2e575351 JH	263
cbd80f64 JH	264	bool View::eventFilter(QObject object, QEvent event)
	265	{
	266	const QEvent::Type type = event->type();
333d5bbc	267	if (type == QEvent::MouseMove) {
cbd80f64 JH	268
cbd80f64 JH	269	const QMouseEvent const mouse_event = (QMouseEvent)event;
333d5bbc	270	if (object == _viewport)
cbd80f64	271	_hover_point = mouse_event->pos();
333d5bbc	272	else if (object == _ruler)
cbd80f64	273	_hover_point = QPoint(mouse_event->x(), 0);
333d5bbc	274	else if (object == _header)
cbd80f64 JH	275	_hover_point = QPoint(0, mouse_event->y());
	276	else
	277	_hover_point = QPoint(-1, -1);
	278
	279	hover_point_changed();
	280
333d5bbc	281	} else if (type == QEvent::Leave) {
cbd80f64 JH	282	_hover_point = QPoint(-1, -1);
	283	hover_point_changed();
	284	}
	285
	286	return QObject::eventFilter(object, event);
	287	}
	288
cdf7bea7	289	bool View::viewportEvent(QEvent *e)
adb4b10c JH	290	{
	291	switch(e->type()) {
	292	case QEvent::Paint:
	293	case QEvent::MouseButtonPress:
	294	case QEvent::MouseButtonRelease:
	295	case QEvent::MouseButtonDblClick:
	296	case QEvent::MouseMove:
	297	case QEvent::Wheel:
	298	return false;
	299
	300	default:
	301	return QAbstractScrollArea::viewportEvent(e);
	302	}
	303	}
	304
e314eca4	305	void View::resizeEvent(QResizeEvent*)
adb4b10c	306	{
ccdd3ef5 JH	307	_ruler->setGeometry(_viewport->x(), 0,
	308	_viewport->width(), _viewport->y());
	309	_header->setGeometry(0, _viewport->y(),
1d8dca91	310	_viewport->x(), _viewport->height());
adb4b10c JH	311	update_scroll();
	312	}
	313
b16907d3	314	void View::h_scroll_value_changed(int value)
adb4b10c	315	{
528bd8a1 JH	316	if (_updating_scroll)
	317	return;
	318
f25770e2	319	const int range = horizontalScrollBar()->maximum();
333d5bbc	320	if (range < MaxScrollValue)
f25770e2 JH	321	_offset = _scale * value;
	322	else {
	323	double length = 0, offset;
	324	get_scroll_layout(length, offset);
	325	_offset = _scale * length * value / MaxScrollValue;
	326	}
	327
ccdd3ef5	328	_ruler->update();
adb4b10c JH	329	_viewport->update();
	330	}
	331
cdf7bea7	332	void View::v_scroll_value_changed(int value)
adb4b10c JH	333	{
adb4b10c JH	334	_v_offset = value;
1d8dca91	335	_header->update();
adb4b10c JH	336	_viewport->update();
	337	}
	338
69dd2b03 JH	339	void View::signals_changed()
	340	{
	341	reset_signal_layout();
	342	}
	343
cdf7bea7	344	void View::data_updated()
adb4b10c JH	345	{
	346	// Get the new data length
	347	_data_length = 0;
1b1ec774	348	shared_ptr<data::Logic> sig_data = _session.get_data();
333d5bbc	349	if (sig_data) {
1b1ec774	350	deque< shared_ptr<data::LogicSnapshot> > &snapshots =
adb4b10c	351	sig_data->get_snapshots();
1b1ec774	352	BOOST_FOREACH(shared_ptr<data::LogicSnapshot> s, snapshots)
333d5bbc	353	if (s)
adb4b10c JH	354	_data_length = max(_data_length,
	355	s->get_sample_count());
	356	}
	357
	358	// Update the scroll bars
	359	update_scroll();
	360
	361	// Repaint the view
	362	_viewport->update();
	363	}
cdf7bea7	364
ca4ec3ea JH	365	void View::marker_time_changed()
	366	{
	367	_ruler->update();
	368	_viewport->update();
	369	}
	370
07204819	371	void View::on_signals_moved()
54401bbb	372	{
07204819 JH	373	update_scroll();
07204819 JH	374	signals_moved();
54401bbb JH	375	}
54401bbb JH	376
cdf7bea7 JH	377	} // namespace view
cdf7bea7 JH	378	} // namespace pv