[pulseview.git] / pv / mainwindow.cpp

/*
 * This file is part of the PulseView project.
 *
 * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 */

#ifdef ENABLE_SIGROKDECODE
#include <sigrokdecode.h>
#endif

#include <boost/bind.hpp>

#include <QAction>
#include <QApplication>
#include <QButtonGroup>
#include <QFileDialog>
#include <QMessageBox>
#include <QMenu>
#include <QMenuBar>
#include <QStatusBar>
#include <QVBoxLayout>
#include <QWidget>

#include "mainwindow.h"
#include "dialogs/about.h"
#include "dialogs/connect.h"
#include "toolbars/samplingbar.h"
#include "view/view.h"

/* __STDC_FORMAT_MACROS is required for PRIu64 and friends (in C++). */
#define __STDC_FORMAT_MACROS
#include <inttypes.h>
#include <stdint.h>
#include <stdarg.h>
#include <glib.h>
#include <libsigrok/libsigrok.h>


namespace pv {

MainWindow::MainWindow(const char *open_file_name,
	QWidget *parent) :
	QMainWindow(parent)
{
	setup_ui();
	if (open_file_name) {
		const QString s(QString::fromUtf8(open_file_name));
		QMetaObject::invokeMethod(this, "load_file",
			Qt::QueuedConnection,
			Q_ARG(QString, s));
	}
}

void MainWindow::setup_ui()
{
	setObjectName(QString::fromUtf8("MainWindow"));

	resize(1024, 768);

	// Set the window icon
	QIcon icon;
	icon.addFile(QString::fromUtf8(":/icons/sigrok-logo-notext.png"),
		QSize(), QIcon::Normal, QIcon::Off);
	setWindowIcon(icon);

	// Setup the central widget
	_central_widget = new QWidget(this);
	_vertical_layout = new QVBoxLayout(_central_widget);
	_vertical_layout->setSpacing(6);
	_vertical_layout->setContentsMargins(0, 0, 0, 0);
	setCentralWidget(_central_widget);

	_view = new pv::view::View(_session, this);
	_vertical_layout->addWidget(_view);

	// Setup the menu bar
	_menu_bar = new QMenuBar(this);
	_menu_bar->setGeometry(QRect(0, 0, 400, 25));

	// File Menu
	_menu_file = new QMenu(_menu_bar);
	_menu_file->setTitle(QApplication::translate(
		"MainWindow", "&File", 0, QApplication::UnicodeUTF8));

	_action_open = new QAction(this);
	_action_open->setText(QApplication::translate(
		"MainWindow", "&Open...", 0, QApplication::UnicodeUTF8));
	_action_open->setIcon(QIcon::fromTheme("document-open",
		QIcon(":/icons/document-open.png")));
	_action_open->setObjectName(QString::fromUtf8("actionOpen"));
	_menu_file->addAction(_action_open);

	_menu_file->addSeparator();

	_action_connect = new QAction(this);
	_action_connect->setText(QApplication::translate(
		"MainWindow", "&Connect to Device...", 0,
		QApplication::UnicodeUTF8));
	_action_connect->setObjectName(QString::fromUtf8("actionConnect"));
	_menu_file->addAction(_action_connect);

	_menu_file->addSeparator();

	_action_quit = new QAction(this);
	_action_quit->setText(QApplication::translate(
		"MainWindow", "&Quit", 0, QApplication::UnicodeUTF8));
	_action_quit->setIcon(QIcon::fromTheme("application-exit",
		QIcon(":/icons/application-exit.png")));
	_action_quit->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_Q));
	_action_quit->setObjectName(QString::fromUtf8("actionQuit"));
	_menu_file->addAction(_action_quit);

	// View Menu
	_menu_view = new QMenu(_menu_bar);
	_menu_view->setTitle(QApplication::translate(
		"MainWindow", "&View", 0, QApplication::UnicodeUTF8));

	_action_view_zoom_in = new QAction(this);
	_action_view_zoom_in->setText(QApplication::translate(
		"MainWindow", "Zoom &In", 0, QApplication::UnicodeUTF8));
	_action_view_zoom_in->setIcon(QIcon::fromTheme("zoom-in",
		QIcon(":/icons/zoom-in.png")));
	_action_view_zoom_in->setObjectName(
		QString::fromUtf8("actionViewZoomIn"));
	_menu_view->addAction(_action_view_zoom_in);

	_action_view_zoom_out = new QAction(this);
	_action_view_zoom_out->setText(QApplication::translate(
		"MainWindow", "Zoom &Out", 0, QApplication::UnicodeUTF8));
	_action_view_zoom_out->setIcon(QIcon::fromTheme("zoom-out",
		QIcon(":/icons/zoom-out.png")));
	_action_view_zoom_out->setObjectName(
		QString::fromUtf8("actionViewZoomOut"));
	_menu_view->addAction(_action_view_zoom_out);

	_menu_view->addSeparator();

	_action_view_show_cursors = new QAction(this);
	_action_view_show_cursors->setCheckable(true);
	_action_view_show_cursors->setChecked(_view->cursors_shown());
	_action_view_show_cursors->setObjectName(
		QString::fromUtf8("actionViewShowCursors"));
	_action_view_show_cursors->setText(QApplication::translate(
		"MainWindow", "Show &Cursors", 0, QApplication::UnicodeUTF8));
	_menu_view->addAction(_action_view_show_cursors);

	// Help Menu
	_menu_help = new QMenu(_menu_bar);
	_menu_help->setTitle(QApplication::translate(
		"MainWindow", "&Help", 0, QApplication::UnicodeUTF8));

	_action_about = new QAction(this);
	_action_about->setObjectName(QString::fromUtf8("actionAbout"));
	_action_about->setText(QApplication::translate(
		"MainWindow", "&About...", 0, QApplication::UnicodeUTF8));
	_menu_help->addAction(_action_about);

	_menu_bar->addAction(_menu_file->menuAction());
	_menu_bar->addAction(_menu_view->menuAction());
	_menu_bar->addAction(_menu_help->menuAction());

	setMenuBar(_menu_bar);
	QMetaObject::connectSlotsByName(this);

	// Setup the toolbars
	_toolbar = new QToolBar(this);
	_toolbar->addAction(_action_open);
	_toolbar->addSeparator();
	_toolbar->addAction(_action_view_zoom_in);
	_toolbar->addAction(_action_view_zoom_out);
	addToolBar(_toolbar);

	_sampling_bar = new toolbars::SamplingBar(this);
	scan_devices();
	connect(_sampling_bar, SIGNAL(run_stop()), this,
		SLOT(run_stop()));
	addToolBar(_sampling_bar);

	setWindowTitle(QApplication::translate("MainWindow", "PulseView", 0,
		QApplication::UnicodeUTF8));

	// Setup _session events
	connect(&_session, SIGNAL(capture_state_changed(int)), this,
		SLOT(capture_state_changed(int)));

}

void MainWindow::scan_devices()
{
	_devices.clear();

	/* Scan all drivers for all devices. */
	struct sr_dev_driver **const drivers = sr_driver_list();
	for (struct sr_dev_driver **driver = drivers; *driver; driver++) {
		GSList *const devices = sr_driver_scan(*driver, NULL);
		for (GSList *l = devices; l; l = l->next)
			_devices.push_back((sr_dev_inst*)l->data);
		g_slist_free(devices);
	}

	assert(_sampling_bar);
	_sampling_bar->set_device_list(_devices);
}

void MainWindow::session_error(
	const QString text, const QString info_text)
{
	QMetaObject::invokeMethod(this, "show_session_error",
		Qt::QueuedConnection, Q_ARG(QString, text),
		Q_ARG(QString, info_text));
}

void MainWindow::load_file(QString file_name)
{
	const QString errorMessage(
		QString("Failed to load file %1").arg(file_name));
	const QString infoMessage;
	_session.load_file(file_name.toStdString(),
		boost::bind(&MainWindow::session_error, this,
			errorMessage, infoMessage));
}

void MainWindow::show_session_error(
	const QString text, const QString info_text)
{
	QMessageBox msg(this);
	msg.setText(text);
	msg.setInformativeText(info_text);
	msg.setStandardButtons(QMessageBox::Ok);
	msg.setIcon(QMessageBox::Warning);
	msg.exec();
}

void MainWindow::on_actionOpen_triggered()
{
	const QString file_name = QFileDialog::getOpenFileName(
		this, tr("Open File"), "",
		tr("Sigrok Sessions (*.sr)"));
	load_file(file_name);
}

void MainWindow::on_actionConnect_triggered()
{
	dialogs::Connect dlg(this);
	if (!dlg.exec())
		return;

	struct sr_dev_inst *const sdi = dlg.get_selected_device();
	if (sdi) {
		assert(_sampling_bar);

		_devices.push_back(sdi);
		_sampling_bar->set_device_list(_devices);
		_sampling_bar->set_selected_device(sdi);
	}
}

void MainWindow::on_actionQuit_triggered()
{
	close();
}

void MainWindow::on_actionViewZoomIn_triggered()
{
	_view->zoom(1);
}

void MainWindow::on_actionViewZoomOut_triggered()
{
	_view->zoom(-1);
}

void MainWindow::on_actionViewShowCursors_triggered()
{
	assert(_view);
	_view->show_cursors(_action_view_show_cursors->isChecked());
}

void MainWindow::on_actionAbout_triggered()
{
	dialogs::About dlg(this);
	dlg.exec();
}

void MainWindow::run_stop()
{
	switch(_session.get_capture_state()) {
	case SigSession::Stopped:
		_session.start_capture(
			_sampling_bar->get_selected_device(),
			_sampling_bar->get_record_length(),
			boost::bind(&MainWindow::session_error, this,
				QString("Capture failed"), _1));
		break;

	case SigSession::Running:
		_session.stop_capture();
		break;
	}
}

void MainWindow::capture_state_changed(int state)
{
	_sampling_bar->set_sampling(state != SigSession::Stopped);
}

} // namespace pv
Commit	Line	Data
d7bed479	1	/*
b3f22de0	2	* This file is part of the PulseView project.
d7bed479 JH	3	*
	4	* Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
	5	*
	6	* This program is free software; you can redistribute it and/or modify
	7	* it under the terms of the GNU General Public License as published by
	8	* the Free Software Foundation; either version 2 of the License, or
	9	* (at your option) any later version.
	10	*
	11	* This program is distributed in the hope that it will be useful,
	12	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	13	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	14	* GNU General Public License for more details.
	15	*
	16	* You should have received a copy of the GNU General Public License
	17	* along with this program; if not, write to the Free Software
	18	* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
	19	*/
	20
d52d8455	21	#ifdef ENABLE_SIGROKDECODE
30236a54	22	#include <sigrokdecode.h>
d52d8455	23	#endif
30236a54	24
f2edb557 JH	25	#include <boost/bind.hpp>
f2edb557 JH	26
7d5425ef JH	27	#include <QAction>
	28	#include <QApplication>
	29	#include <QButtonGroup>
2953961c	30	#include <QFileDialog>
f2edb557	31	#include <QMessageBox>
7d5425ef JH	32	#include <QMenu>
	33	#include <QMenuBar>
	34	#include <QStatusBar>
	35	#include <QVBoxLayout>
	36	#include <QWidget>
2953961c	37
d7bed479	38	#include "mainwindow.h"
acda14b8	39	#include "dialogs/about.h"
9663c82b	40	#include "dialogs/connect.h"
f4c92e1c	41	#include "toolbars/samplingbar.h"
4104d7f3	42	#include "view/view.h"
d7bed479	43
30236a54 JH	44	/* __STDC_FORMAT_MACROS is required for PRIu64 and friends (in C++). */
	45	#define __STDC_FORMAT_MACROS
	46	#include <inttypes.h>
	47	#include <stdint.h>
	48	#include <stdarg.h>
	49	#include <glib.h>
	50	#include <libsigrok/libsigrok.h>
e82fd481	51
30236a54	52
51e77110 JH	53	namespace pv {
51e77110 JH	54
1d478458 JH	55	MainWindow::MainWindow(const char *open_file_name,
1d478458 JH	56	QWidget *parent) :
7d5425ef	57	QMainWindow(parent)
d7bed479	58	{
7d5425ef	59	setup_ui();
1d478458 JH	60	if (open_file_name) {
	61	const QString s(QString::fromUtf8(open_file_name));
	62	QMetaObject::invokeMethod(this, "load_file",
	63	Qt::QueuedConnection,
	64	Q_ARG(QString, s));
	65	}
7d5425ef JH	66	}
	67
	68	void MainWindow::setup_ui()
	69	{
	70	setObjectName(QString::fromUtf8("MainWindow"));
	71
	72	resize(1024, 768);
	73
	74	// Set the window icon
	75	QIcon icon;
	76	icon.addFile(QString::fromUtf8(":/icons/sigrok-logo-notext.png"),
	77	QSize(), QIcon::Normal, QIcon::Off);
	78	setWindowIcon(icon);
	79
e072efc8 JH	80	// Setup the central widget
	81	_central_widget = new QWidget(this);
	82	_vertical_layout = new QVBoxLayout(_central_widget);
	83	_vertical_layout->setSpacing(6);
	84	_vertical_layout->setContentsMargins(0, 0, 0, 0);
	85	setCentralWidget(_central_widget);
	86
	87	_view = new pv::view::View(_session, this);
	88	_vertical_layout->addWidget(_view);
	89
ab1d13ee JH	90	// Setup the menu bar
	91	_menu_bar = new QMenuBar(this);
	92	_menu_bar->setGeometry(QRect(0, 0, 400, 25));
a429590b	93
ab1d13ee JH	94	// File Menu
	95	_menu_file = new QMenu(_menu_bar);
	96	_menu_file->setTitle(QApplication::translate(
	97	"MainWindow", "&File", 0, QApplication::UnicodeUTF8));
e072efc8	98
7d5425ef	99	_action_open = new QAction(this);
ab1d13ee JH	100	_action_open->setText(QApplication::translate(
ab1d13ee JH	101	"MainWindow", "&Open...", 0, QApplication::UnicodeUTF8));
362eea96 JH	102	_action_open->setIcon(QIcon::fromTheme("document-open",
362eea96 JH	103	QIcon(":/icons/document-open.png")));
7d5425ef	104	_action_open->setObjectName(QString::fromUtf8("actionOpen"));
7d5425ef	105	_menu_file->addAction(_action_open);
009e1503	106
2a032dcb JH	107	_menu_file->addSeparator();
2a032dcb JH	108
9663c82b JH	109	_action_connect = new QAction(this);
	110	_action_connect->setText(QApplication::translate(
	111	"MainWindow", "&Connect to Device...", 0,
	112	QApplication::UnicodeUTF8));
	113	_action_connect->setObjectName(QString::fromUtf8("actionConnect"));
	114	_menu_file->addAction(_action_connect);
	115
	116	_menu_file->addSeparator();
	117
2a032dcb JH	118	_action_quit = new QAction(this);
	119	_action_quit->setText(QApplication::translate(
	120	"MainWindow", "&Quit", 0, QApplication::UnicodeUTF8));
	121	_action_quit->setIcon(QIcon::fromTheme("application-exit",
	122	QIcon(":/icons/application-exit.png")));
d1bb7d7a	123	_action_quit->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_Q));
2a032dcb JH	124	_action_quit->setObjectName(QString::fromUtf8("actionQuit"));
	125	_menu_file->addAction(_action_quit);
	126
ab1d13ee	127	// View Menu
a429590b	128	_menu_view = new QMenu(_menu_bar);
ab1d13ee JH	129	_menu_view->setTitle(QApplication::translate(
	130	"MainWindow", "&View", 0, QApplication::UnicodeUTF8));
	131
	132	_action_view_zoom_in = new QAction(this);
	133	_action_view_zoom_in->setText(QApplication::translate(
	134	"MainWindow", "Zoom &In", 0, QApplication::UnicodeUTF8));
	135	_action_view_zoom_in->setIcon(QIcon::fromTheme("zoom-in",
	136	QIcon(":/icons/zoom-in.png")));
	137	_action_view_zoom_in->setObjectName(
	138	QString::fromUtf8("actionViewZoomIn"));
a429590b	139	_menu_view->addAction(_action_view_zoom_in);
ab1d13ee JH	140
	141	_action_view_zoom_out = new QAction(this);
	142	_action_view_zoom_out->setText(QApplication::translate(
	143	"MainWindow", "Zoom &Out", 0, QApplication::UnicodeUTF8));
	144	_action_view_zoom_out->setIcon(QIcon::fromTheme("zoom-out",
	145	QIcon(":/icons/zoom-out.png")));
	146	_action_view_zoom_out->setObjectName(
	147	QString::fromUtf8("actionViewZoomOut"));
a429590b	148	_menu_view->addAction(_action_view_zoom_out);
ab1d13ee	149
e072efc8	150	_menu_view->addSeparator();
ab1d13ee JH	151
	152	_action_view_show_cursors = new QAction(this);
	153	_action_view_show_cursors->setCheckable(true);
	154	_action_view_show_cursors->setChecked(_view->cursors_shown());
	155	_action_view_show_cursors->setObjectName(
	156	QString::fromUtf8("actionViewShowCursors"));
	157	_action_view_show_cursors->setText(QApplication::translate(
	158	"MainWindow", "Show &Cursors", 0, QApplication::UnicodeUTF8));
e072efc8	159	_menu_view->addAction(_action_view_show_cursors);
a429590b	160
ab1d13ee	161	// Help Menu
7d5425ef	162	_menu_help = new QMenu(_menu_bar);
ab1d13ee JH	163	_menu_help->setTitle(QApplication::translate(
	164	"MainWindow", "&Help", 0, QApplication::UnicodeUTF8));
	165
	166	_action_about = new QAction(this);
	167	_action_about->setObjectName(QString::fromUtf8("actionAbout"));
	168	_action_about->setText(QApplication::translate(
	169	"MainWindow", "&About...", 0, QApplication::UnicodeUTF8));
7d5425ef JH	170	_menu_help->addAction(_action_about);
	171
	172	_menu_bar->addAction(_menu_file->menuAction());
a429590b	173	_menu_bar->addAction(_menu_view->menuAction());
7d5425ef JH	174	_menu_bar->addAction(_menu_help->menuAction());
	175
	176	setMenuBar(_menu_bar);
	177	QMetaObject::connectSlotsByName(this);
	178
	179	// Setup the toolbars
0a4db787 JH	180	_toolbar = new QToolBar(this);
0a4db787 JH	181	_toolbar->addAction(_action_open);
a429590b JH	182	_toolbar->addSeparator();
	183	_toolbar->addAction(_action_view_zoom_in);
	184	_toolbar->addAction(_action_view_zoom_out);
0a4db787 JH	185	addToolBar(_toolbar);
0a4db787 JH	186
f4c92e1c	187	_sampling_bar = new toolbars::SamplingBar(this);
18203d86	188	scan_devices();
274d4f13 JH	189	connect(_sampling_bar, SIGNAL(run_stop()), this,
274d4f13 JH	190	SLOT(run_stop()));
d4984fe7 JH	191	addToolBar(_sampling_bar);
d4984fe7 JH	192
a8d3fb2d JH	193	setWindowTitle(QApplication::translate("MainWindow", "PulseView", 0,
	194	QApplication::UnicodeUTF8));
	195
6ac96c2e JH	196	// Setup _session events
	197	connect(&_session, SIGNAL(capture_state_changed(int)), this,
	198	SLOT(capture_state_changed(int)));
	199
d7bed479	200	}
30236a54	201
18203d86 JH	202	void MainWindow::scan_devices()
	203	{
	204	_devices.clear();
	205
	206	/* Scan all drivers for all devices. */
	207	struct sr_dev_driver **const drivers = sr_driver_list();
	208	for (struct sr_dev_driver *driver = drivers; driver; driver++) {
	209	GSList const devices = sr_driver_scan(driver, NULL);
	210	for (GSList *l = devices; l; l = l->next)
	211	_devices.push_back((sr_dev_inst*)l->data);
	212	g_slist_free(devices);
	213	}
	214
	215	assert(_sampling_bar);
	216	_sampling_bar->set_device_list(_devices);
	217	}
	218
f2edb557 JH	219	void MainWindow::session_error(
	220	const QString text, const QString info_text)
	221	{
	222	QMetaObject::invokeMethod(this, "show_session_error",
	223	Qt::QueuedConnection, Q_ARG(QString, text),
	224	Q_ARG(QString, info_text));
	225	}
	226
1d478458 JH	227	void MainWindow::load_file(QString file_name)
1d478458 JH	228	{
f2edb557 JH	229	const QString errorMessage(
	230	QString("Failed to load file %1").arg(file_name));
	231	const QString infoMessage;
	232	_session.load_file(file_name.toStdString(),
	233	boost::bind(&MainWindow::session_error, this,
	234	errorMessage, infoMessage));
	235	}
	236
	237	void MainWindow::show_session_error(
	238	const QString text, const QString info_text)
	239	{
	240	QMessageBox msg(this);
	241	msg.setText(text);
	242	msg.setInformativeText(info_text);
	243	msg.setStandardButtons(QMessageBox::Ok);
	244	msg.setIcon(QMessageBox::Warning);
	245	msg.exec();
1d478458 JH	246	}
1d478458 JH	247
2953961c JH	248	void MainWindow::on_actionOpen_triggered()
2953961c JH	249	{
1d478458	250	const QString file_name = QFileDialog::getOpenFileName(
2953961c JH	251	this, tr("Open File"), "",
2953961c JH	252	tr("Sigrok Sessions (*.sr)"));
1d478458	253	load_file(file_name);
2953961c JH	254	}
2953961c JH	255
9663c82b JH	256	void MainWindow::on_actionConnect_triggered()
	257	{
	258	dialogs::Connect dlg(this);
793f8096	259	if (!dlg.exec())
5eb0fa13 JH	260	return;
	261
	262	struct sr_dev_inst *const sdi = dlg.get_selected_device();
	263	if (sdi) {
	264	assert(_sampling_bar);
	265
	266	_devices.push_back(sdi);
	267	_sampling_bar->set_device_list(_devices);
	268	_sampling_bar->set_selected_device(sdi);
	269	}
9663c82b JH	270	}
9663c82b JH	271
2a032dcb JH	272	void MainWindow::on_actionQuit_triggered()
	273	{
	274	close();
	275	}
	276
a429590b JH	277	void MainWindow::on_actionViewZoomIn_triggered()
	278	{
	279	_view->zoom(1);
	280	}
	281
	282	void MainWindow::on_actionViewZoomOut_triggered()
	283	{
	284	_view->zoom(-1);
	285	}
	286
e072efc8 JH	287	void MainWindow::on_actionViewShowCursors_triggered()
	288	{
	289	assert(_view);
	290	_view->show_cursors(_action_view_show_cursors->isChecked());
	291	}
	292
30236a54 JH	293	void MainWindow::on_actionAbout_triggered()
30236a54 JH	294	{
acda14b8	295	dialogs::About dlg(this);
40eb2ff4	296	dlg.exec();
30236a54	297	}
274d4f13 JH	298
	299	void MainWindow::run_stop()
	300	{
5b7cf66c JH	301	switch(_session.get_capture_state()) {
	302	case SigSession::Stopped:
	303	_session.start_capture(
	304	_sampling_bar->get_selected_device(),
f2edb557 JH	305	_sampling_bar->get_record_length(),
	306	boost::bind(&MainWindow::session_error, this,
	307	QString("Capture failed"), _1));
5b7cf66c JH	308	break;
	309
	310	case SigSession::Running:
	311	_session.stop_capture();
	312	break;
	313	}
274d4f13	314	}
51e77110	315
6ac96c2e JH	316	void MainWindow::capture_state_changed(int state)
	317	{
	318	_sampling_bar->set_sampling(state != SigSession::Stopped);
	319	}
	320
51e77110	321	} // namespace pv