[libsigrok.git] / src / hardware / hp-3457a / api.c

/*
 * This file is part of the libsigrok project.
 *
 * Copyright (C) 2016 Alexandru Gagniuc <mr.nuke.me@gmail.com>
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

#include <config.h>
#include <scpi.h>
#include <string.h>
#include "protocol.h"

static const uint32_t scanopts[] = {
	SR_CONF_CONN,
};

static const uint32_t drvopts[] = {
	SR_CONF_MULTIMETER,
};

static const uint32_t devopts[] = {
	SR_CONF_CONTINUOUS,
	SR_CONF_LIMIT_SAMPLES | SR_CONF_SET,
	SR_CONF_MEASURED_QUANTITY | SR_CONF_SET,
	SR_CONF_ADC_POWERLINE_CYCLES | SR_CONF_SET | SR_CONF_GET,
};

static struct sr_dev_driver hp_3457a_driver_info;

static int create_front_channel(struct sr_dev_inst *sdi, int chan_idx)
{
	struct sr_channel *channel;
	struct sr_channel_group *front;
	struct channel_context *chanc;

	chanc = g_malloc(sizeof(*chanc));
	chanc->location = CONN_FRONT;

	channel = sr_channel_new(sdi, chan_idx++, SR_CHANNEL_ANALOG,
				 TRUE, "Front");
	channel->priv = chanc;

	front = sr_channel_group_new(sdi, "Front", NULL);
	front->channels = g_slist_append(front->channels, channel);

	return chan_idx;
}

static int create_rear_channels(struct sr_dev_inst *sdi, int chan_idx,
				 const struct rear_card_info *card)
{
	unsigned int i;
	struct sr_channel *channel;
	struct sr_channel_group *group;
	struct channel_context *chanc;
	char name[16];

	/* When card is NULL, we couldn't identify the type of card. */
	if (!card)
		return chan_idx;

	group = sr_channel_group_new(sdi, card->cg_name, NULL);

	for (i = 0; i < card->num_channels; i++) {

		chanc = g_malloc(sizeof(*chanc));
		chanc->location = CONN_REAR;

		if (card->type == REAR_TERMINALS) {
			chanc->index = -1;
			g_snprintf(name, sizeof(name), "%s", card->cg_name);
		} else {
			chanc->index = i;
			g_snprintf(name, sizeof(name), "%s%u", card->cg_name, i);
		}

		channel = sr_channel_new(sdi, chan_idx++, SR_CHANNEL_ANALOG,
					FALSE, name);
		channel->priv = chanc;
		group->channels = g_slist_append(group->channels, channel);
	}

	return chan_idx;
}

static gchar *get_revision(struct sr_scpi_dev_inst *scpi)
{
	int ret, major, minor;
	GArray *rev_numbers;

	/* Report a version of '0.0' if we can't parse the response. */
	major = minor = 0;

	ret = sr_scpi_get_floatv(scpi, "REV?", &rev_numbers);
	if ((ret == SR_OK) && (rev_numbers->len >= 2)) {
		major = (int)g_array_index(rev_numbers, float, 0);
		minor = (int)g_array_index(rev_numbers, float, 1);
	}

	g_array_free(rev_numbers, TRUE);

	return g_strdup_printf("%d.%d", major, minor);
}

static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi)
{
	int ret, idx;
	char *response;
	struct sr_dev_inst *sdi;
	struct dev_context *devc;

	/*
	 * The device cannot get identified by means of SCPI queries.
	 * Neither shall non-SCPI requests get emitted before reliable
	 * identification of the device. Assume that we only get here
	 * when user specs led us to believe it's safe to communicate
	 * to the expected kind of device.
	 */

	/*
	 * This command ensures we receive an EOI after every response, so that
	 * we don't wait the entire timeout after the response is received.
	 */
	if (sr_scpi_send(scpi, "END ALWAYS") != SR_OK)
		return NULL;

	ret = sr_scpi_get_string(scpi, "ID?", &response);
	if ((ret != SR_OK) || !response)
		return NULL;

	if (strcmp(response, "HP3457A") != 0) {
		g_free(response);
		return NULL;
	}

	g_free(response);

	devc = g_malloc0(sizeof(*devc));
	sdi = g_malloc0(sizeof(*sdi));
	sdi->vendor = g_strdup("Hewlett-Packard");
	sdi->model = g_strdup("3457A");
	sdi->version = get_revision(scpi);
	sdi->conn = scpi;
	sdi->driver = &hp_3457a_driver_info;
	sdi->inst_type = SR_INST_SCPI;
	sdi->priv = devc;

	/* There is no way to probe the measurement mode. It must be set. */
	devc->measurement_mq = 0;
	devc->measurement_unit = 0;

	/* Probe rear card option and create channels accordingly (TODO). */
	devc->rear_card = hp_3457a_probe_rear_card(scpi);
	idx = 0;
	idx = create_front_channel(sdi, idx);
	create_rear_channels(sdi, idx, devc->rear_card);

	return sdi;
}

static GSList *scan(struct sr_dev_driver *di, GSList *options)
{
	const char *conn;

	/* Only scan for a device when conn= was specified. */
	conn = NULL;
	(void)sr_serial_extract_options(options, &conn, NULL);
	if (!conn)
		return NULL;

	return sr_scpi_scan(di->context, options, probe_device);
}

/*
 * We need to set the HP 3457A to a known state, and there are quite a number
 * of knobs to tweak. Here's a brief explanation of what's going on. For more
 * details, print out and consult the user manual.
 *   PRESET
 *     Set the instrument to a pre-determined state. This is easier and faster
 *     than sending a few dozen commands. Some of the PRESET defaults include
 *     ASCII output format, and synchronous triggering. See user manual for
 *     more details.
 *
 * After the PRESET command, the instrument is in a known state, and only those
 * parameters for which the default is unsuitable are modified:
 *   INBUF ON
 *     Enable the HP-IB input buffer. This allows the instrument to release the
 *     HP-IB bus before processing the command, and increases throughput on
 *     GPIB buses with more than one device.
 *   TRIG HOLD
 *     Do not trigger new measurements until instructed to do so.
 */
static int dev_open(struct sr_dev_inst *sdi)
{
	struct sr_scpi_dev_inst *scpi = sdi->conn;
	struct dev_context *devc;

	if (sr_scpi_open(scpi) != SR_OK)
		return SR_ERR;

	devc = sdi->priv;

	sr_scpi_send(scpi, "PRESET");
	sr_scpi_send(scpi, "INBUF ON");
	sr_scpi_send(scpi, "TRIG HOLD");
	sr_scpi_get_float(scpi, "NPLC?", &devc->nplc);

	return SR_OK;
}

static int dev_close(struct sr_dev_inst *sdi)
{
	struct sr_scpi_dev_inst *scpi = sdi->conn;

	/* Disable scan-advance (preserve relay life). */
	sr_scpi_send(scpi, "SADV HOLD");
	/* Switch back to auto-triggering. */
	sr_scpi_send(scpi, "TRIG AUTO");

	sr_scpi_close(scpi);

	return SR_OK;
}

static int config_get(uint32_t key, GVariant **data,
	const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
{
	struct dev_context *devc;

	(void)cg;

	devc = sdi->priv;

	switch (key) {
	case SR_CONF_ADC_POWERLINE_CYCLES:
		*data = g_variant_new_double(devc->nplc);
		break;
	default:
		return SR_ERR_NA;
	}

	return SR_OK;
}

static int config_set(uint32_t key, GVariant *data,
	const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
{
	enum sr_mq mq;
	enum sr_mqflag mq_flags;
	struct dev_context *devc;
	GVariant *tuple_child;

	(void)cg;

	devc = sdi->priv;

	switch (key) {
	case SR_CONF_LIMIT_SAMPLES:
		devc->limit_samples = g_variant_get_uint64(data);
		break;
	case SR_CONF_MEASURED_QUANTITY:
		tuple_child = g_variant_get_child_value(data, 0);
		mq = g_variant_get_uint32(tuple_child);
		tuple_child = g_variant_get_child_value(data, 1);
		mq_flags = g_variant_get_uint64(tuple_child);
		g_variant_unref(tuple_child);
		return hp_3457a_set_mq(sdi, mq, mq_flags);
	case SR_CONF_ADC_POWERLINE_CYCLES:
		return hp_3457a_set_nplc(sdi, g_variant_get_double(data));
	default:
		return SR_ERR_NA;
	}

	return SR_OK;
}

static int config_list(uint32_t key, GVariant **data,
	const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
{
	/*
	 * TODO: Implement channel group configuration when adding support for
	 * plug-in cards.
	 */

	return STD_CONFIG_LIST(key, data, sdi, cg, scanopts, drvopts, devopts);
}

static void create_channel_index_list(GSList *channels, GArray **arr)
{
	struct sr_channel *channel;
	struct channel_context *chanc;
	GSList *list_elem;

	*arr = g_array_new(FALSE, FALSE, sizeof(unsigned int));

	for (list_elem = channels; list_elem; list_elem = list_elem->next) {
		channel = list_elem->data;
		chanc = channel->priv;
		g_array_append_val(*arr, chanc->index);
	}
}

/*
 * TRIG SGL
 *   Trigger the first measurement, then hold. We can't let the instrument
 *   auto-trigger because we read several registers to make a complete
 *   reading. If the instrument were auto-triggering, we could get the
 *   reading for sample N, but a new measurement is made and when we read the
 *   HIRES register, it contains data for sample N+1. This would produce
 *   wrong readings.
 * SADV AUTO
 *   Activate the scan-advance feature. This automatically connects the next
 *   channel in the scan list to the A/D converter. This way, we do not need to
 *   occupy the HP-IB bus to send channel select commands.
 */
static int dev_acquisition_start(const struct sr_dev_inst *sdi)
{
	int ret;
	gboolean front_selected, rear_selected;
	struct sr_scpi_dev_inst *scpi;
	struct sr_channel *channel;
	struct dev_context *devc;
	struct channel_context *chanc;
	GArray *ch_list;
	GSList *channels;

	scpi = sdi->conn;
	devc = sdi->priv;

	ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 100,
				 hp_3457a_receive_data, (void *)sdi);
	if (ret != SR_OK)
		return ret;

	std_session_send_df_header(sdi);

	front_selected = rear_selected = FALSE;
	devc->active_channels = NULL;

	for (channels = sdi->channels; channels; channels = channels->next) {
		channel = channels->data;

		if (!channel->enabled)
			continue;

		chanc = channel->priv;

		if (chanc->location == CONN_FRONT)
			front_selected = TRUE;
		if (chanc->location == CONN_REAR)
			rear_selected = TRUE;

		devc->active_channels = g_slist_append(devc->active_channels, channel);
	}

	if (front_selected && rear_selected) {
		sr_err("Can not use front and rear channels at the same time!");
		g_slist_free(devc->active_channels);
		return SR_ERR_ARG;
	}

	devc->num_active_channels = g_slist_length(devc->active_channels);
	if (!devc->num_active_channels) {
		sr_err("Need at least one active channel!");
		g_slist_free(devc->active_channels);
		return SR_ERR_ARG;
	}
	devc->current_channel = devc->active_channels->data;

	hp_3457a_select_input(sdi, front_selected ? CONN_FRONT : CONN_REAR);

	/* For plug-in cards, use the scan-advance features to scan channels. */
	if (rear_selected && (devc->rear_card->card_id != REAR_TERMINALS)) {
		create_channel_index_list(devc->active_channels, &ch_list);
		hp_3457a_send_scan_list(sdi, (void *)ch_list->data, ch_list->len);
		sr_scpi_send(scpi, "SADV AUTO");
		g_array_free(ch_list, TRUE);
	}

	/* Start first measurement. */
	sr_scpi_send(scpi, "TRIG SGL");
	devc->acq_state = ACQ_TRIGGERED_MEASUREMENT;
	devc->num_samples = 0;

	return SR_OK;
}

static int dev_acquisition_stop(struct sr_dev_inst *sdi)
{
	struct dev_context *devc;

	devc = sdi->priv;

	g_slist_free(devc->active_channels);

	return SR_OK;
}

static struct sr_dev_driver hp_3457a_driver_info = {
	.name = "hp-3457a",
	.longname = "HP 3457A",
	.api_version = 1,
	.init = std_init,
	.cleanup = std_cleanup,
	.scan = scan,
	.dev_list = std_dev_list,
	.dev_clear = std_dev_clear,
	.config_get = config_get,
	.config_set = config_set,
	.config_list = config_list,
	.dev_open = dev_open,
	.dev_close = dev_close,
	.dev_acquisition_start = dev_acquisition_start,
	.dev_acquisition_stop = dev_acquisition_stop,
	.context = NULL,
};
SR_REGISTER_DEV_DRIVER(hp_3457a_driver_info);
Commit	Line	Data
00b2a092 AG	1	/*
	2	* This file is part of the libsigrok project.
	3	*
	4	* Copyright (C) 2016 Alexandru Gagniuc <mr.nuke.me@gmail.com>
	5	*
	6	* This program is free software: you can redistribute it and/or modify
	7	* it under the terms of the GNU General Public License as published by
	8	* the Free Software Foundation, either version 3 of the License, or
	9	* (at your option) any later version.
	10	*
	11	* This program is distributed in the hope that it will be useful,
	12	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	13	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	14	* GNU General Public License for more details.
	15	*
	16	* You should have received a copy of the GNU General Public License
	17	* along with this program. If not, see <http://www.gnu.org/licenses/>.
	18	*/
	19
	20	#include <config.h>
db23af7f AG	21	#include <scpi.h>
db23af7f AG	22	#include <string.h>
00b2a092 AG	23	#include "protocol.h"
00b2a092 AG	24
db23af7f AG	25	static const uint32_t scanopts[] = {
	26	SR_CONF_CONN,
	27	};
	28
	29	static const uint32_t drvopts[] = {
	30	SR_CONF_MULTIMETER,
	31	};
	32
	33	static const uint32_t devopts[] = {
e91bb0a6	34	SR_CONF_CONTINUOUS,
db23af7f AG	35	SR_CONF_LIMIT_SAMPLES \| SR_CONF_SET,
	36	SR_CONF_MEASURED_QUANTITY \| SR_CONF_SET,
	37	SR_CONF_ADC_POWERLINE_CYCLES \| SR_CONF_SET \| SR_CONF_GET,
	38	};
	39
dd5c48a6	40	static struct sr_dev_driver hp_3457a_driver_info;
00b2a092	41
db23af7f	42	static int create_front_channel(struct sr_dev_inst *sdi, int chan_idx)
00b2a092	43	{
db23af7f AG	44	struct sr_channel *channel;
db23af7f AG	45	struct sr_channel_group *front;
9a093be9 AG	46	struct channel_context *chanc;
	47
	48	chanc = g_malloc(sizeof(*chanc));
	49	chanc->location = CONN_FRONT;
db23af7f AG	50
	51	channel = sr_channel_new(sdi, chan_idx++, SR_CHANNEL_ANALOG,
	52	TRUE, "Front");
9a093be9	53	channel->priv = chanc;
db23af7f	54
d810901a	55	front = sr_channel_group_new(sdi, "Front", NULL);
db23af7f	56	front->channels = g_slist_append(front->channels, channel);
9a093be9	57
db23af7f	58	return chan_idx;
00b2a092 AG	59	}
00b2a092 AG	60
db23af7f AG	61	static int create_rear_channels(struct sr_dev_inst *sdi, int chan_idx,
	62	const struct rear_card_info *card)
	63	{
9a093be9 AG	64	unsigned int i;
	65	struct sr_channel *channel;
	66	struct sr_channel_group *group;
	67	struct channel_context *chanc;
	68	char name[16];
db23af7f AG	69
	70	/* When card is NULL, we couldn't identify the type of card. */
	71	if (!card)
	72	return chan_idx;
	73
d810901a	74	group = sr_channel_group_new(sdi, card->cg_name, NULL);
9a093be9 AG	75
	76	for (i = 0; i < card->num_channels; i++) {
	77
	78	chanc = g_malloc(sizeof(*chanc));
	79	chanc->location = CONN_REAR;
	80
	81	if (card->type == REAR_TERMINALS) {
	82	chanc->index = -1;
	83	g_snprintf(name, sizeof(name), "%s", card->cg_name);
	84	} else {
	85	chanc->index = i;
	86	g_snprintf(name, sizeof(name), "%s%u", card->cg_name, i);
	87	}
	88
	89	channel = sr_channel_new(sdi, chan_idx++, SR_CHANNEL_ANALOG,
	90	FALSE, name);
	91	channel->priv = chanc;
	92	group->channels = g_slist_append(group->channels, channel);
	93	}
	94
db23af7f AG	95	return chan_idx;
	96	}
	97
	98	static gchar get_revision(struct sr_scpi_dev_inst scpi)
00b2a092	99	{
db23af7f AG	100	int ret, major, minor;
	101	GArray *rev_numbers;
	102
	103	/* Report a version of '0.0' if we can't parse the response. */
	104	major = minor = 0;
	105
	106	ret = sr_scpi_get_floatv(scpi, "REV?", &rev_numbers);
	107	if ((ret == SR_OK) && (rev_numbers->len >= 2)) {
	108	major = (int)g_array_index(rev_numbers, float, 0);
	109	minor = (int)g_array_index(rev_numbers, float, 1);
	110	}
00b2a092	111
db23af7f	112	g_array_free(rev_numbers, TRUE);
00b2a092	113
db23af7f AG	114	return g_strdup_printf("%d.%d", major, minor);
db23af7f AG	115	}
00b2a092	116
db23af7f AG	117	static struct sr_dev_inst probe_device(struct sr_scpi_dev_inst scpi)
	118	{
	119	int ret, idx;
	120	char *response;
	121	struct sr_dev_inst *sdi;
	122	struct dev_context *devc;
	123
69498046 GS	124	/*
	125	* The device cannot get identified by means of SCPI queries.
	126	* Neither shall non-SCPI requests get emitted before reliable
	127	* identification of the device. Assume that we only get here
	128	* when user specs led us to believe it's safe to communicate
	129	* to the expected kind of device.
	130	*/
	131
db23af7f AG	132	/*
	133	* This command ensures we receive an EOI after every response, so that
	134	* we don't wait the entire timeout after the response is received.
	135	*/
	136	if (sr_scpi_send(scpi, "END ALWAYS") != SR_OK)
	137	return NULL;
	138
	139	ret = sr_scpi_get_string(scpi, "ID?", &response);
	140	if ((ret != SR_OK) \|\| !response)
	141	return NULL;
	142
9417f26f	143	if (strcmp(response, "HP3457A") != 0) {
1c502555	144	g_free(response);
db23af7f	145	return NULL;
1c502555	146	}
db23af7f AG	147
	148	g_free(response);
	149
9417f26f GS	150	devc = g_malloc0(sizeof(*devc));
9417f26f GS	151	sdi = g_malloc0(sizeof(*sdi));
db23af7f AG	152	sdi->vendor = g_strdup("Hewlett-Packard");
	153	sdi->model = g_strdup("3457A");
	154	sdi->version = get_revision(scpi);
	155	sdi->conn = scpi;
	156	sdi->driver = &hp_3457a_driver_info;
	157	sdi->inst_type = SR_INST_SCPI;
	158	sdi->priv = devc;
	159
	160	/* There is no way to probe the measurement mode. It must be set. */
	161	devc->measurement_mq = 0;
	162	devc->measurement_unit = 0;
	163
	164	/* Probe rear card option and create channels accordingly (TODO). */
	165	devc->rear_card = hp_3457a_probe_rear_card(scpi);
	166	idx = 0;
	167	idx = create_front_channel(sdi, idx);
	168	create_rear_channels(sdi, idx, devc->rear_card);
	169
	170	return sdi;
	171	}
00b2a092	172
db23af7f AG	173	static GSList scan(struct sr_dev_driver di, GSList *options)
db23af7f AG	174	{
69498046 GS	175	const char *conn;
	176
	177	/* Only scan for a device when conn= was specified. */
	178	conn = NULL;
	179	(void)sr_serial_extract_options(options, &conn, NULL);
	180	if (!conn)
	181	return NULL;
	182
db23af7f	183	return sr_scpi_scan(di->context, options, probe_device);
00b2a092 AG	184	}
00b2a092 AG	185
db23af7f AG	186	/*
	187	* We need to set the HP 3457A to a known state, and there are quite a number
	188	* of knobs to tweak. Here's a brief explanation of what's going on. For more
	189	* details, print out and consult the user manual.
	190	* PRESET
	191	* Set the instrument to a pre-determined state. This is easier and faster
	192	* than sending a few dozen commands. Some of the PRESET defaults include
	193	* ASCII output format, and synchronous triggering. See user manual for
	194	* more details.
	195	*
	196	* After the PRESET command, the instrument is in a known state, and only those
	197	* parameters for which the default is unsuitable are modified:
	198	* INBUF ON
	199	* Enable the HP-IB input buffer. This allows the instrument to release the
	200	* HP-IB bus before processing the command, and increases throughput on
	201	* GPIB buses with more than one device.
	202	* TRIG HOLD
	203	* Do not trigger new measurements until instructed to do so.
	204	*/
00b2a092 AG	205	static int dev_open(struct sr_dev_inst *sdi)
00b2a092 AG	206	{
db23af7f AG	207	struct sr_scpi_dev_inst *scpi = sdi->conn;
	208	struct dev_context *devc;
	209
	210	if (sr_scpi_open(scpi) != SR_OK)
	211	return SR_ERR;
00b2a092	212
61c90858	213	devc = sdi->priv;
db23af7f AG	214
	215	sr_scpi_send(scpi, "PRESET");
	216	sr_scpi_send(scpi, "INBUF ON");
	217	sr_scpi_send(scpi, "TRIG HOLD");
	218	sr_scpi_get_float(scpi, "NPLC?", &devc->nplc);
00b2a092	219
00b2a092 AG	220	return SR_OK;
	221	}
	222
	223	static int dev_close(struct sr_dev_inst *sdi)
	224	{
db23af7f AG	225	struct sr_scpi_dev_inst *scpi = sdi->conn;
db23af7f AG	226
9a093be9 AG	227	/* Disable scan-advance (preserve relay life). */
9a093be9 AG	228	sr_scpi_send(scpi, "SADV HOLD");
db23af7f AG	229	/* Switch back to auto-triggering. */
	230	sr_scpi_send(scpi, "TRIG AUTO");
	231
	232	sr_scpi_close(scpi);
00b2a092	233
00b2a092 AG	234	return SR_OK;
	235	}
	236
00b2a092 AG	237	static int config_get(uint32_t key, GVariant **data,
	238	const struct sr_dev_inst sdi, const struct sr_channel_group cg)
	239	{
db23af7f	240	struct dev_context *devc;
00b2a092	241
00b2a092 AG	242	(void)cg;
00b2a092 AG	243
db23af7f AG	244	devc = sdi->priv;
db23af7f AG	245
00b2a092	246	switch (key) {
db23af7f AG	247	case SR_CONF_ADC_POWERLINE_CYCLES:
	248	*data = g_variant_new_double(devc->nplc);
	249	break;
00b2a092 AG	250	default:
	251	return SR_ERR_NA;
	252	}
	253
a9010323	254	return SR_OK;
00b2a092 AG	255	}
	256
	257	static int config_set(uint32_t key, GVariant *data,
dd7a72ea	258	const struct sr_dev_inst sdi, const struct sr_channel_group cg)
00b2a092	259	{
db23af7f	260	enum sr_mq mq;
2c04f943	261	enum sr_mqflag mq_flags;
db23af7f AG	262	struct dev_context *devc;
db23af7f AG	263	GVariant *tuple_child;
00b2a092	264
00b2a092 AG	265	(void)cg;
00b2a092 AG	266
db23af7f AG	267	devc = sdi->priv;
db23af7f AG	268
00b2a092	269	switch (key) {
db23af7f AG	270	case SR_CONF_LIMIT_SAMPLES:
	271	devc->limit_samples = g_variant_get_uint64(data);
	272	break;
	273	case SR_CONF_MEASURED_QUANTITY:
	274	tuple_child = g_variant_get_child_value(data, 0);
	275	mq = g_variant_get_uint32(tuple_child);
2c04f943 AG	276	tuple_child = g_variant_get_child_value(data, 1);
2c04f943 AG	277	mq_flags = g_variant_get_uint64(tuple_child);
db23af7f	278	g_variant_unref(tuple_child);
758906aa	279	return hp_3457a_set_mq(sdi, mq, mq_flags);
db23af7f	280	case SR_CONF_ADC_POWERLINE_CYCLES:
758906aa	281	return hp_3457a_set_nplc(sdi, g_variant_get_double(data));
00b2a092	282	default:
758906aa	283	return SR_ERR_NA;
00b2a092 AG	284	}
00b2a092 AG	285
758906aa	286	return SR_OK;
00b2a092 AG	287	}
	288
	289	static int config_list(uint32_t key, GVariant **data,
	290	const struct sr_dev_inst sdi, const struct sr_channel_group cg)
	291	{
db23af7f AG	292	/*
	293	* TODO: Implement channel group configuration when adding support for
	294	* plug-in cards.
	295	*/
00b2a092	296
e66d1892	297	return STD_CONFIG_LIST(key, data, sdi, cg, scanopts, drvopts, devopts);
00b2a092 AG	298	}
00b2a092 AG	299
9a093be9 AG	300	static void create_channel_index_list(GSList channels, GArray *arr)
	301	{
	302	struct sr_channel *channel;
	303	struct channel_context *chanc;
	304	GSList *list_elem;
	305
	306	*arr = g_array_new(FALSE, FALSE, sizeof(unsigned int));
	307
	308	for (list_elem = channels; list_elem; list_elem = list_elem->next) {
	309	channel = list_elem->data;
	310	chanc = channel->priv;
	311	g_array_append_val(*arr, chanc->index);
	312	}
	313	}
	314
db23af7f AG	315	/*
	316	* TRIG SGL
	317	* Trigger the first measurement, then hold. We can't let the instrument
	318	* auto-trigger because we read several registers to make a complete
	319	* reading. If the instrument were auto-triggering, we could get the
	320	* reading for sample N, but a new measurement is made and when we read the
	321	* HIRES register, it contains data for sample N+1. This would produce
	322	* wrong readings.
9a093be9 AG	323	* SADV AUTO
	324	* Activate the scan-advance feature. This automatically connects the next
	325	* channel in the scan list to the A/D converter. This way, we do not need to
	326	* occupy the HP-IB bus to send channel select commands.
db23af7f	327	*/
695dc859	328	static int dev_acquisition_start(const struct sr_dev_inst *sdi)
00b2a092	329	{
db23af7f	330	int ret;
9a093be9	331	gboolean front_selected, rear_selected;
db23af7f	332	struct sr_scpi_dev_inst *scpi;
9a093be9	333	struct sr_channel *channel;
db23af7f	334	struct dev_context *devc;
9a093be9 AG	335	struct channel_context *chanc;
	336	GArray *ch_list;
	337	GSList *channels;
db23af7f	338
db23af7f AG	339	scpi = sdi->conn;
	340	devc = sdi->priv;
	341
	342	ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 100,
	343	hp_3457a_receive_data, (void *)sdi);
	344	if (ret != SR_OK)
	345	return ret;
	346
bee2b016	347	std_session_send_df_header(sdi);
db23af7f	348
9a093be9 AG	349	front_selected = rear_selected = FALSE;
	350	devc->active_channels = NULL;
	351
	352	for (channels = sdi->channels; channels; channels = channels->next) {
	353	channel = channels->data;
	354
	355	if (!channel->enabled)
	356	continue;
	357
	358	chanc = channel->priv;
	359
	360	if (chanc->location == CONN_FRONT)
	361	front_selected = TRUE;
	362	if (chanc->location == CONN_REAR)
	363	rear_selected = TRUE;
	364
	365	devc->active_channels = g_slist_append(devc->active_channels, channel);
	366	}
	367
	368	if (front_selected && rear_selected) {
	369	sr_err("Can not use front and rear channels at the same time!");
	370	g_slist_free(devc->active_channels);
	371	return SR_ERR_ARG;
	372	}
	373
9a093be9	374	devc->num_active_channels = g_slist_length(devc->active_channels);
1674225a GS	375	if (!devc->num_active_channels) {
	376	sr_err("Need at least one active channel!");
	377	g_slist_free(devc->active_channels);
	378	return SR_ERR_ARG;
	379	}
	380	devc->current_channel = devc->active_channels->data;
9a093be9 AG	381
	382	hp_3457a_select_input(sdi, front_selected ? CONN_FRONT : CONN_REAR);
	383
	384	/* For plug-in cards, use the scan-advance features to scan channels. */
	385	if (rear_selected && (devc->rear_card->card_id != REAR_TERMINALS)) {
	386	create_channel_index_list(devc->active_channels, &ch_list);
	387	hp_3457a_send_scan_list(sdi, (void *)ch_list->data, ch_list->len);
	388	sr_scpi_send(scpi, "SADV AUTO");
	389	g_array_free(ch_list, TRUE);
	390	}
	391
db23af7f AG	392	/* Start first measurement. */
	393	sr_scpi_send(scpi, "TRIG SGL");
	394	devc->acq_state = ACQ_TRIGGERED_MEASUREMENT;
	395	devc->num_samples = 0;
00b2a092 AG	396
	397	return SR_OK;
	398	}
	399
695dc859	400	static int dev_acquisition_stop(struct sr_dev_inst *sdi)
00b2a092	401	{
9a093be9	402	struct dev_context *devc;
00b2a092	403
9a093be9 AG	404	devc = sdi->priv;
9a093be9 AG	405
9a093be9 AG	406	g_slist_free(devc->active_channels);
9a093be9 AG	407
00b2a092 AG	408	return SR_OK;
	409	}
	410
dd5c48a6	411	static struct sr_dev_driver hp_3457a_driver_info = {
00b2a092 AG	412	.name = "hp-3457a",
	413	.longname = "HP 3457A",
	414	.api_version = 1,
c2fdcc25	415	.init = std_init,
700d6b64	416	.cleanup = std_cleanup,
00b2a092	417	.scan = scan,
c01bf34c	418	.dev_list = std_dev_list,
f778bf02	419	.dev_clear = std_dev_clear,
00b2a092 AG	420	.config_get = config_get,
	421	.config_set = config_set,
	422	.config_list = config_list,
	423	.dev_open = dev_open,
	424	.dev_close = dev_close,
	425	.dev_acquisition_start = dev_acquisition_start,
	426	.dev_acquisition_stop = dev_acquisition_stop,
	427	.context = NULL,
	428	};
dd5c48a6	429	SR_REGISTER_DEV_DRIVER(hp_3457a_driver_info);