]> sigrok.org Git - libsigrok.git/blame - src/hardware/hp-3457a/api.c
hp-3457a: free memory that was allocated by SCPI get routines
[libsigrok.git] / src / hardware / hp-3457a / api.c
CommitLineData
00b2a092
AG
1/*
2 * This file is part of the libsigrok project.
3 *
4 * Copyright (C) 2016 Alexandru Gagniuc <mr.nuke.me@gmail.com>
5 *
6 * This program is free software: you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License as published by
8 * the Free Software Foundation, either version 3 of the License, or
9 * (at your option) any later version.
10 *
11 * This program is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 * GNU General Public License for more details.
15 *
16 * You should have received a copy of the GNU General Public License
17 * along with this program. If not, see <http://www.gnu.org/licenses/>.
18 */
19
20#include <config.h>
db23af7f
AG
21#include <scpi.h>
22#include <string.h>
00b2a092
AG
23#include "protocol.h"
24
db23af7f
AG
25static const uint32_t scanopts[] = {
26 SR_CONF_CONN,
27};
28
29static const uint32_t drvopts[] = {
30 SR_CONF_MULTIMETER,
31};
32
33static const uint32_t devopts[] = {
e91bb0a6 34 SR_CONF_CONTINUOUS,
db23af7f
AG
35 SR_CONF_LIMIT_SAMPLES | SR_CONF_SET,
36 SR_CONF_MEASURED_QUANTITY | SR_CONF_SET,
37 SR_CONF_ADC_POWERLINE_CYCLES | SR_CONF_SET | SR_CONF_GET,
38};
39
dd5c48a6 40static struct sr_dev_driver hp_3457a_driver_info;
00b2a092 41
db23af7f 42static int create_front_channel(struct sr_dev_inst *sdi, int chan_idx)
00b2a092 43{
db23af7f
AG
44 struct sr_channel *channel;
45 struct sr_channel_group *front;
9a093be9
AG
46 struct channel_context *chanc;
47
48 chanc = g_malloc(sizeof(*chanc));
49 chanc->location = CONN_FRONT;
db23af7f
AG
50
51 channel = sr_channel_new(sdi, chan_idx++, SR_CHANNEL_ANALOG,
52 TRUE, "Front");
9a093be9 53 channel->priv = chanc;
db23af7f
AG
54
55 front = g_malloc0(sizeof(*front));
56 front->name = g_strdup("Front");
57 front->channels = g_slist_append(front->channels, channel);
9a093be9 58
db23af7f
AG
59 sdi->channel_groups = g_slist_append(sdi->channel_groups, front);
60
61 return chan_idx;
00b2a092
AG
62}
63
db23af7f
AG
64static int create_rear_channels(struct sr_dev_inst *sdi, int chan_idx,
65 const struct rear_card_info *card)
66{
9a093be9
AG
67 unsigned int i;
68 struct sr_channel *channel;
69 struct sr_channel_group *group;
70 struct channel_context *chanc;
71 char name[16];
db23af7f
AG
72
73 /* When card is NULL, we couldn't identify the type of card. */
74 if (!card)
75 return chan_idx;
76
9a093be9
AG
77 group = g_malloc0(sizeof(*group));
78 group->priv = NULL;
79 group->name = g_strdup(card->cg_name);
80 sdi->channel_groups = g_slist_append(sdi->channel_groups, group);
81
82 for (i = 0; i < card->num_channels; i++) {
83
84 chanc = g_malloc(sizeof(*chanc));
85 chanc->location = CONN_REAR;
86
87 if (card->type == REAR_TERMINALS) {
88 chanc->index = -1;
89 g_snprintf(name, sizeof(name), "%s", card->cg_name);
90 } else {
91 chanc->index = i;
92 g_snprintf(name, sizeof(name), "%s%u", card->cg_name, i);
93 }
94
95 channel = sr_channel_new(sdi, chan_idx++, SR_CHANNEL_ANALOG,
96 FALSE, name);
97 channel->priv = chanc;
98 group->channels = g_slist_append(group->channels, channel);
99 }
100
db23af7f
AG
101 return chan_idx;
102}
103
104static gchar *get_revision(struct sr_scpi_dev_inst *scpi)
00b2a092 105{
db23af7f
AG
106 int ret, major, minor;
107 GArray *rev_numbers;
108
109 /* Report a version of '0.0' if we can't parse the response. */
110 major = minor = 0;
111
112 ret = sr_scpi_get_floatv(scpi, "REV?", &rev_numbers);
113 if ((ret == SR_OK) && (rev_numbers->len >= 2)) {
114 major = (int)g_array_index(rev_numbers, float, 0);
115 minor = (int)g_array_index(rev_numbers, float, 1);
116 }
00b2a092 117
db23af7f 118 g_array_free(rev_numbers, TRUE);
00b2a092 119
db23af7f
AG
120 return g_strdup_printf("%d.%d", major, minor);
121}
00b2a092 122
db23af7f
AG
123static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi)
124{
125 int ret, idx;
126 char *response;
127 struct sr_dev_inst *sdi;
128 struct dev_context *devc;
129
130 /*
131 * This command ensures we receive an EOI after every response, so that
132 * we don't wait the entire timeout after the response is received.
133 */
134 if (sr_scpi_send(scpi, "END ALWAYS") != SR_OK)
135 return NULL;
136
137 ret = sr_scpi_get_string(scpi, "ID?", &response);
138 if ((ret != SR_OK) || !response)
139 return NULL;
140
1c502555
GS
141 if (strcmp(response, "HP3457A")) {
142 g_free(response);
db23af7f 143 return NULL;
1c502555 144 }
db23af7f
AG
145
146 g_free(response);
147
148 devc = g_malloc0(sizeof(struct dev_context));
149 sdi = g_malloc0(sizeof(struct sr_dev_inst));
150 sdi->vendor = g_strdup("Hewlett-Packard");
151 sdi->model = g_strdup("3457A");
152 sdi->version = get_revision(scpi);
153 sdi->conn = scpi;
154 sdi->driver = &hp_3457a_driver_info;
155 sdi->inst_type = SR_INST_SCPI;
156 sdi->priv = devc;
157
158 /* There is no way to probe the measurement mode. It must be set. */
159 devc->measurement_mq = 0;
160 devc->measurement_unit = 0;
161
162 /* Probe rear card option and create channels accordingly (TODO). */
163 devc->rear_card = hp_3457a_probe_rear_card(scpi);
164 idx = 0;
165 idx = create_front_channel(sdi, idx);
166 create_rear_channels(sdi, idx, devc->rear_card);
167
168 return sdi;
169}
00b2a092 170
db23af7f
AG
171static GSList *scan(struct sr_dev_driver *di, GSList *options)
172{
173 return sr_scpi_scan(di->context, options, probe_device);
00b2a092
AG
174}
175
db23af7f
AG
176/*
177 * We need to set the HP 3457A to a known state, and there are quite a number
178 * of knobs to tweak. Here's a brief explanation of what's going on. For more
179 * details, print out and consult the user manual.
180 * PRESET
181 * Set the instrument to a pre-determined state. This is easier and faster
182 * than sending a few dozen commands. Some of the PRESET defaults include
183 * ASCII output format, and synchronous triggering. See user manual for
184 * more details.
185 *
186 * After the PRESET command, the instrument is in a known state, and only those
187 * parameters for which the default is unsuitable are modified:
188 * INBUF ON
189 * Enable the HP-IB input buffer. This allows the instrument to release the
190 * HP-IB bus before processing the command, and increases throughput on
191 * GPIB buses with more than one device.
192 * TRIG HOLD
193 * Do not trigger new measurements until instructed to do so.
194 */
00b2a092
AG
195static int dev_open(struct sr_dev_inst *sdi)
196{
db23af7f
AG
197 struct sr_scpi_dev_inst *scpi = sdi->conn;
198 struct dev_context *devc;
199
200 if (sr_scpi_open(scpi) != SR_OK)
201 return SR_ERR;
00b2a092 202
61c90858 203 devc = sdi->priv;
db23af7f
AG
204
205 sr_scpi_send(scpi, "PRESET");
206 sr_scpi_send(scpi, "INBUF ON");
207 sr_scpi_send(scpi, "TRIG HOLD");
208 sr_scpi_get_float(scpi, "NPLC?", &devc->nplc);
00b2a092 209
00b2a092
AG
210 return SR_OK;
211}
212
213static int dev_close(struct sr_dev_inst *sdi)
214{
db23af7f
AG
215 struct sr_scpi_dev_inst *scpi = sdi->conn;
216
9a093be9
AG
217 /* Disable scan-advance (preserve relay life). */
218 sr_scpi_send(scpi, "SADV HOLD");
db23af7f
AG
219 /* Switch back to auto-triggering. */
220 sr_scpi_send(scpi, "TRIG AUTO");
221
222 sr_scpi_close(scpi);
00b2a092 223
00b2a092
AG
224 return SR_OK;
225}
226
00b2a092
AG
227static int config_get(uint32_t key, GVariant **data,
228 const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
229{
db23af7f 230 struct dev_context *devc;
00b2a092 231
00b2a092
AG
232 (void)cg;
233
db23af7f
AG
234 devc = sdi->priv;
235
00b2a092 236 switch (key) {
db23af7f
AG
237 case SR_CONF_ADC_POWERLINE_CYCLES:
238 *data = g_variant_new_double(devc->nplc);
239 break;
00b2a092
AG
240 default:
241 return SR_ERR_NA;
242 }
243
a9010323 244 return SR_OK;
00b2a092
AG
245}
246
247static int config_set(uint32_t key, GVariant *data,
dd7a72ea 248 const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
00b2a092 249{
db23af7f 250 enum sr_mq mq;
2c04f943 251 enum sr_mqflag mq_flags;
db23af7f
AG
252 struct dev_context *devc;
253 GVariant *tuple_child;
00b2a092 254
00b2a092
AG
255 (void)cg;
256
db23af7f
AG
257 devc = sdi->priv;
258
00b2a092 259 switch (key) {
db23af7f
AG
260 case SR_CONF_LIMIT_SAMPLES:
261 devc->limit_samples = g_variant_get_uint64(data);
262 break;
263 case SR_CONF_MEASURED_QUANTITY:
264 tuple_child = g_variant_get_child_value(data, 0);
265 mq = g_variant_get_uint32(tuple_child);
2c04f943
AG
266 tuple_child = g_variant_get_child_value(data, 1);
267 mq_flags = g_variant_get_uint64(tuple_child);
db23af7f 268 g_variant_unref(tuple_child);
758906aa 269 return hp_3457a_set_mq(sdi, mq, mq_flags);
db23af7f 270 case SR_CONF_ADC_POWERLINE_CYCLES:
758906aa 271 return hp_3457a_set_nplc(sdi, g_variant_get_double(data));
00b2a092 272 default:
758906aa 273 return SR_ERR_NA;
00b2a092
AG
274 }
275
758906aa 276 return SR_OK;
00b2a092
AG
277}
278
279static int config_list(uint32_t key, GVariant **data,
280 const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
281{
db23af7f
AG
282 /*
283 * TODO: Implement channel group configuration when adding support for
284 * plug-in cards.
285 */
00b2a092 286
e66d1892 287 return STD_CONFIG_LIST(key, data, sdi, cg, scanopts, drvopts, devopts);
00b2a092
AG
288}
289
9a093be9
AG
290static void create_channel_index_list(GSList *channels, GArray **arr)
291{
292 struct sr_channel *channel;
293 struct channel_context *chanc;
294 GSList *list_elem;
295
296 *arr = g_array_new(FALSE, FALSE, sizeof(unsigned int));
297
298 for (list_elem = channels; list_elem; list_elem = list_elem->next) {
299 channel = list_elem->data;
300 chanc = channel->priv;
301 g_array_append_val(*arr, chanc->index);
302 }
303}
304
db23af7f
AG
305/*
306 * TRIG SGL
307 * Trigger the first measurement, then hold. We can't let the instrument
308 * auto-trigger because we read several registers to make a complete
309 * reading. If the instrument were auto-triggering, we could get the
310 * reading for sample N, but a new measurement is made and when we read the
311 * HIRES register, it contains data for sample N+1. This would produce
312 * wrong readings.
9a093be9
AG
313 * SADV AUTO
314 * Activate the scan-advance feature. This automatically connects the next
315 * channel in the scan list to the A/D converter. This way, we do not need to
316 * occupy the HP-IB bus to send channel select commands.
db23af7f 317 */
695dc859 318static int dev_acquisition_start(const struct sr_dev_inst *sdi)
00b2a092 319{
db23af7f 320 int ret;
9a093be9 321 gboolean front_selected, rear_selected;
db23af7f 322 struct sr_scpi_dev_inst *scpi;
9a093be9 323 struct sr_channel *channel;
db23af7f 324 struct dev_context *devc;
9a093be9
AG
325 struct channel_context *chanc;
326 GArray *ch_list;
327 GSList *channels;
db23af7f 328
db23af7f
AG
329 scpi = sdi->conn;
330 devc = sdi->priv;
331
332 ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 100,
333 hp_3457a_receive_data, (void *)sdi);
334 if (ret != SR_OK)
335 return ret;
336
bee2b016 337 std_session_send_df_header(sdi);
db23af7f 338
9a093be9
AG
339 front_selected = rear_selected = FALSE;
340 devc->active_channels = NULL;
341
342 for (channels = sdi->channels; channels; channels = channels->next) {
343 channel = channels->data;
344
345 if (!channel->enabled)
346 continue;
347
348 chanc = channel->priv;
349
350 if (chanc->location == CONN_FRONT)
351 front_selected = TRUE;
352 if (chanc->location == CONN_REAR)
353 rear_selected = TRUE;
354
355 devc->active_channels = g_slist_append(devc->active_channels, channel);
356 }
357
358 if (front_selected && rear_selected) {
359 sr_err("Can not use front and rear channels at the same time!");
360 g_slist_free(devc->active_channels);
361 return SR_ERR_ARG;
362 }
363
9a093be9 364 devc->num_active_channels = g_slist_length(devc->active_channels);
1674225a
GS
365 if (!devc->num_active_channels) {
366 sr_err("Need at least one active channel!");
367 g_slist_free(devc->active_channels);
368 return SR_ERR_ARG;
369 }
370 devc->current_channel = devc->active_channels->data;
9a093be9
AG
371
372 hp_3457a_select_input(sdi, front_selected ? CONN_FRONT : CONN_REAR);
373
374 /* For plug-in cards, use the scan-advance features to scan channels. */
375 if (rear_selected && (devc->rear_card->card_id != REAR_TERMINALS)) {
376 create_channel_index_list(devc->active_channels, &ch_list);
377 hp_3457a_send_scan_list(sdi, (void *)ch_list->data, ch_list->len);
378 sr_scpi_send(scpi, "SADV AUTO");
379 g_array_free(ch_list, TRUE);
380 }
381
db23af7f
AG
382 /* Start first measurement. */
383 sr_scpi_send(scpi, "TRIG SGL");
384 devc->acq_state = ACQ_TRIGGERED_MEASUREMENT;
385 devc->num_samples = 0;
00b2a092
AG
386
387 return SR_OK;
388}
389
695dc859 390static int dev_acquisition_stop(struct sr_dev_inst *sdi)
00b2a092 391{
9a093be9 392 struct dev_context *devc;
00b2a092 393
9a093be9
AG
394 devc = sdi->priv;
395
9a093be9
AG
396 g_slist_free(devc->active_channels);
397
00b2a092
AG
398 return SR_OK;
399}
400
dd5c48a6 401static struct sr_dev_driver hp_3457a_driver_info = {
00b2a092
AG
402 .name = "hp-3457a",
403 .longname = "HP 3457A",
404 .api_version = 1,
c2fdcc25 405 .init = std_init,
700d6b64 406 .cleanup = std_cleanup,
00b2a092 407 .scan = scan,
c01bf34c 408 .dev_list = std_dev_list,
f778bf02 409 .dev_clear = std_dev_clear,
00b2a092
AG
410 .config_get = config_get,
411 .config_set = config_set,
412 .config_list = config_list,
413 .dev_open = dev_open,
414 .dev_close = dev_close,
415 .dev_acquisition_start = dev_acquisition_start,
416 .dev_acquisition_stop = dev_acquisition_stop,
417 .context = NULL,
418};
dd5c48a6 419SR_REGISTER_DEV_DRIVER(hp_3457a_driver_info);