if (!row_height_)
return -1;
- const int row = (point.y() - get_visual_y() + row_height_ / 2) /
- row_height_;
- if (row < 0 || row >= (int)visible_rows_.size())
+ const int y = (point.y() - get_visual_y() + row_height_ / 2);
+
+ /* Integer divison of (x-1)/x would yield 0, so we check for this. */
+ if (y < 0)
+ return -1;
+
+ const int row = y / row_height_;
+
+ if (row >= (int)visible_rows_.size())
return -1;
return row;
QString() : annotations[0].annotations().front();
}
-void DecodeTrace::hide_hover_annotation()
-{
- QToolTip::hideText();
-}
-
void DecodeTrace::hover_point_changed()
{
assert(owner_);
assert(view);
if (!row_height_ || ann.isEmpty()) {
- hide_hover_annotation();
+ QToolTip::hideText();
return;
}
hp.setY(get_visual_y() - (row_height_ / 2) +
(hover_row * row_height_) -
- row_height_ - text_size.height());
+ row_height_ - text_size.height() - padding);
QToolTip::showText(view->viewport()->mapToGlobal(hp), ann);
}