]> sigrok.org Git - libsigrokdecode.git/blame - controller.c
testsuite: Add some basic tests for loading PDs.
[libsigrokdecode.git] / controller.c
CommitLineData
b2c19614 1/*
50bd5d25 2 * This file is part of the libsigrokdecode project.
b2c19614
BV
3 *
4 * Copyright (C) 2010 Uwe Hermann <uwe@hermann-uwe.de>
bc5f5a43 5 * Copyright (C) 2012 Bert Vermeulen <bert@biot.com>
b2c19614
BV
6 *
7 * This program is free software: you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation, either version 3 of the License, or
10 * (at your option) any later version.
11 *
12 * This program is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 * GNU General Public License for more details.
16 *
17 * You should have received a copy of the GNU General Public License
18 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 */
20
c1f86f02
UH
21#include "libsigrokdecode.h" /* First, so we avoid a _POSIX_C_SOURCE warning. */
22#include "libsigrokdecode-internal.h"
7ce7775c 23#include "config.h"
b2c19614 24#include <glib.h>
1aef2f93 25#include <inttypes.h>
0bdadba2 26#include <stdlib.h>
32cfb920 27#include <stdint.h>
b2c19614 28
d7dae84b
UH
29/**
30 * @mainpage libsigrokdecode API
31 *
32 * @section sec_intro Introduction
33 *
34 * The <a href="http://sigrok.org">sigrok</a> project aims at creating a
35 * portable, cross-platform, Free/Libre/Open-Source signal analysis software
36 * suite that supports various device types (such as logic analyzers,
37 * oscilloscopes, multimeters, and more).
38 *
39 * <a href="http://sigrok.org/wiki/Libsigrokdecode">libsigrokdecode</a> is a
40 * shared library written in C which provides the basic API for (streaming)
41 * protocol decoding functionality.
42 *
43 * The <a href="http://sigrok.org/wiki/Protocol_decoders">protocol decoders</a>
44 * are written in Python (>= 3.0).
45 *
46 * @section sec_api API reference
47 *
48 * See the "Modules" page for an introduction to various libsigrokdecode
49 * related topics and the detailed API documentation of the respective
50 * functions.
51 *
52 * You can also browse the API documentation by file, or review all
53 * data structures.
54 *
55 * @section sec_mailinglists Mailing lists
56 *
57 * There are two mailing lists for sigrok/libsigrokdecode: <a href="https://lists.sourceforge.net/lists/listinfo/sigrok-devel">sigrok-devel</a> and <a href="https://lists.sourceforge.net/lists/listinfo/sigrok-commits">sigrok-commits</a>.
58 *
59 * @section sec_irc IRC
60 *
61 * You can find the sigrok developers in the
62 * <a href="irc://chat.freenode.net/sigrok">\#sigrok</a>
63 * IRC channel on Freenode.
64 *
65 * @section sec_website Website
66 *
67 * <a href="http://sigrok.org/wiki/Libsigrokdecode">sigrok.org/wiki/Libsigrokdecode</a>
68 */
69
70/**
71 * @file
72 *
73 * Initializing and shutting down libsigrokdecode.
74 */
75
76/**
77 * @defgroup grp_init Initialization
78 *
79 * Initializing and shutting down libsigrokdecode.
80 *
81 * Before using any of the libsigrokdecode functionality, srd_init() must
82 * be called to initialize the library.
83 *
84 * When libsigrokdecode functionality is no longer needed, srd_exit() should
85 * be called.
86 *
87 * @{
88 */
89
32cfb920 90/** @cond PRIVATE */
d906d3f9 91
32cfb920
BV
92SRD_PRIV GSList *sessions = NULL;
93static int max_session_id = -1;
983cb0f5 94
32cfb920 95static int session_is_valid(struct srd_session *sess);
57790bc8 96
c9bfccc6 97/* decoder.c */
55c3c5f4 98extern SRD_PRIV GSList *pd_list;
b2c19614 99
c9bfccc6 100/* module_sigrokdecode.c */
53a07a6d 101extern PyMODINIT_FUNC PyInit_sigrokdecode(void);
b2c19614 102
c9bfccc6 103/* type_logic.c */
55c3c5f4 104extern SRD_PRIV PyTypeObject srd_logic_type;
b2c19614 105
57790bc8
UH
106/** @endcond */
107
b2c19614
BV
108/**
109 * Initialize libsigrokdecode.
110 *
111 * This initializes the Python interpreter, and creates and initializes
361fdcaa 112 * a "sigrokdecode" Python module.
b2c19614 113 *
4cc0d9fe
UH
114 * Then, it searches for sigrok protocol decoders in the "decoders"
115 * subdirectory of the the libsigrokdecode installation directory.
b2c19614 116 * All decoders that are found are loaded into memory and added to an
4cc0d9fe 117 * internal list of decoders, which can be queried via srd_decoder_list().
b2c19614
BV
118 *
119 * The caller is responsible for calling the clean-up function srd_exit(),
120 * which will properly shut down libsigrokdecode and free its allocated memory.
121 *
7ce7775c 122 * Multiple calls to srd_init(), without calling srd_exit() in between,
b2c19614
BV
123 * are not allowed.
124 *
65e1c7d0 125 * @param path Path to an extra directory containing protocol decoders
4cc0d9fe 126 * which will be added to the Python sys.path. May be NULL.
65e1c7d0 127 *
b2c19614 128 * @return SRD_OK upon success, a (negative) error code otherwise.
4cc0d9fe
UH
129 * Upon Python errors, SRD_ERR_PYTHON is returned. If the decoders
130 * directory cannot be accessed, SRD_ERR_DECODERS_DIR is returned.
131 * If not enough memory could be allocated, SRD_ERR_MALLOC is returned.
8c664ca2
UH
132 *
133 * @since 0.1.0
b2c19614 134 */
abeeed8b 135SRD_API int srd_init(const char *path)
b2c19614
BV
136{
137 int ret;
65e1c7d0 138 char *env_path;
b2c19614 139
32cfb920
BV
140 if (max_session_id != -1) {
141 srd_err("libsigrokdecode is already initialized.");
142 return SRD_ERR;
143 }
144
7a1712c4 145 srd_dbg("Initializing libsigrokdecode.");
d906d3f9
BV
146
147 /* Add our own module to the list of built-in modules. */
bc5f5a43 148 PyImport_AppendInittab("sigrokdecode", PyInit_sigrokdecode);
5f802ec6 149
511e2123 150 /* Initialize the Python interpreter. */
b2c19614
BV
151 Py_Initialize();
152
65e1c7d0 153 /* Installed decoders. */
aafeeaea 154 if ((ret = srd_decoder_searchpath_add(DECODERS_DIR)) != SRD_OK) {
b2c19614
BV
155 Py_Finalize();
156 return ret;
157 }
158
65e1c7d0
BV
159 /* Path specified by the user. */
160 if (path) {
aafeeaea 161 if ((ret = srd_decoder_searchpath_add(path)) != SRD_OK) {
65e1c7d0
BV
162 Py_Finalize();
163 return ret;
164 }
165 }
166
167 /* Environment variable overrides everything, for debugging. */
168 if ((env_path = getenv("SIGROKDECODE_DIR"))) {
aafeeaea 169 if ((ret = srd_decoder_searchpath_add(env_path)) != SRD_OK) {
65e1c7d0
BV
170 Py_Finalize();
171 return ret;
172 }
173 }
174
32cfb920
BV
175 max_session_id = 0;
176
b2c19614
BV
177 return SRD_OK;
178}
179
b2c19614
BV
180/**
181 * Shutdown libsigrokdecode.
182 *
183 * This frees all the memory allocated for protocol decoders and shuts down
184 * the Python interpreter.
185 *
186 * This function should only be called if there was a (successful!) invocation
187 * of srd_init() before. Calling this function multiple times in a row, without
7ce7775c 188 * any successful srd_init() calls in between, is not allowed.
b2c19614
BV
189 *
190 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
191 *
192 * @since 0.1.0
b2c19614 193 */
55c3c5f4 194SRD_API int srd_exit(void)
b2c19614 195{
32cfb920
BV
196 GSList *l;
197
7a1712c4 198 srd_dbg("Exiting libsigrokdecode.");
d906d3f9 199
32cfb920
BV
200 for (l = sessions; l; l = l->next)
201 srd_session_destroy((struct srd_session *)l->data);
202
8ad6e500 203 srd_decoder_unload_all();
e5080882 204 g_slist_free(pd_list);
96c52595 205 pd_list = NULL;
b2c19614
BV
206
207 /* Py_Finalize() returns void, any finalization errors are ignored. */
208 Py_Finalize();
209
32cfb920
BV
210 max_session_id = -1;
211
b2c19614
BV
212 return SRD_OK;
213}
214
b2c19614 215/**
9d9fcb37
UH
216 * Add an additional search directory for the protocol decoders.
217 *
218 * The specified directory is prepended (not appended!) to Python's sys.path,
219 * in order to search for sigrok protocol decoders in the specified
220 * directories first, and in the generic Python module directories (and in
221 * the current working directory) last. This avoids conflicts if there are
222 * Python modules which have the same name as a sigrok protocol decoder in
223 * sys.path or in the current working directory.
b2c19614 224 *
361fdcaa
UH
225 * @param path Path to the directory containing protocol decoders which shall
226 * be added to the Python sys.path, or NULL.
9d9fcb37 227 *
65e1c7d0 228 * @return SRD_OK upon success, a (negative) error code otherwise.
57790bc8
UH
229 *
230 * @private
8c664ca2
UH
231 *
232 * @since 0.1.0
b2c19614 233 */
aafeeaea 234SRD_PRIV int srd_decoder_searchpath_add(const char *path)
b2c19614 235{
65e1c7d0
BV
236 PyObject *py_cur_path, *py_item;
237 GString *new_path;
238 int wc_len, i;
239 wchar_t *wc_new_path;
240 char *item;
241
8ad6e500 242 srd_dbg("Adding '%s' to module path.", path);
65e1c7d0
BV
243
244 new_path = g_string_sized_new(256);
e592ac89 245 g_string_assign(new_path, path);
65e1c7d0
BV
246 py_cur_path = PySys_GetObject("path");
247 for (i = 0; i < PyList_Size(py_cur_path); i++) {
e592ac89 248 g_string_append(new_path, G_SEARCHPATH_SEPARATOR_S);
65e1c7d0
BV
249 py_item = PyList_GetItem(py_cur_path, i);
250 if (!PyUnicode_Check(py_item))
251 /* Shouldn't happen. */
252 continue;
253 if (py_str_as_str(py_item, &item) != SRD_OK)
254 continue;
255 g_string_append(new_path, item);
e592ac89 256 g_free(item);
65e1c7d0 257 }
639c5689 258
65e1c7d0
BV
259 /* Convert to wide chars. */
260 wc_len = sizeof(wchar_t) * (new_path->len + 1);
261 if (!(wc_new_path = g_try_malloc(wc_len))) {
262 srd_dbg("malloc failed");
263 return SRD_ERR_MALLOC;
264 }
265 mbstowcs(wc_new_path, new_path->str, wc_len);
266 PySys_SetPath(wc_new_path);
267 g_string_free(new_path, TRUE);
268 g_free(wc_new_path);
269
65e1c7d0 270 return SRD_OK;
b2c19614
BV
271}
272
4895418c
UH
273/** @} */
274
275/**
276 * @defgroup grp_instances Decoder instances
277 *
278 * Decoder instance handling.
279 *
280 * @{
281 */
282
7ce7775c 283/**
b33b8aa5 284 * Set one or more options in a decoder instance.
0bdadba2 285 *
361fdcaa
UH
286 * Handled options are removed from the hash.
287 *
0bdadba2
BV
288 * @param di Decoder instance.
289 * @param options A GHashTable of options to set.
7ce7775c 290 *
0bdadba2 291 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
292 *
293 * @since 0.1.0
0bdadba2 294 */
b33b8aa5 295SRD_API int srd_inst_option_set(struct srd_decoder_inst *di,
0ff2d191 296 GHashTable *options)
0bdadba2
BV
297{
298 PyObject *py_dec_options, *py_dec_optkeys, *py_di_options, *py_optval;
299 PyObject *py_optlist, *py_classval;
300 Py_UNICODE *py_ustr;
2f395bff 301 GVariant *value;
0bdadba2 302 unsigned long long int val_ull;
2f395bff 303 gint64 val_int;
0bdadba2 304 int num_optkeys, ret, size, i;
2f395bff
BV
305 const char *val_str;
306 char *dbg, *key;
0bdadba2 307
c9bfccc6 308 if (!PyObject_HasAttrString(di->decoder->py_dec, "options")) {
0bdadba2 309 /* Decoder has no options. */
e431d9cc
BV
310 if (g_hash_table_size(options) == 0) {
311 /* No options provided. */
312 return SRD_OK;
313 } else {
314 srd_err("Protocol decoder has no options.");
315 return SRD_ERR_ARG;
316 }
0bdadba2 317 return SRD_OK;
e431d9cc 318 }
0bdadba2
BV
319
320 ret = SRD_ERR_PYTHON;
321 key = NULL;
322 py_dec_options = py_dec_optkeys = py_di_options = py_optval = NULL;
323 py_optlist = py_classval = NULL;
324 py_dec_options = PyObject_GetAttrString(di->decoder->py_dec, "options");
0bdadba2
BV
325
326 /* All of these are synthesized objects, so they're good. */
327 py_dec_optkeys = PyDict_Keys(py_dec_options);
328 num_optkeys = PyList_Size(py_dec_optkeys);
a8b72b05 329 if (!(py_di_options = PyObject_GetAttrString(di->py_inst, "options")))
0bdadba2
BV
330 goto err_out;
331 for (i = 0; i < num_optkeys; i++) {
332 /* Get the default class value for this option. */
333 py_str_as_str(PyList_GetItem(py_dec_optkeys, i), &key);
334 if (!(py_optlist = PyDict_GetItemString(py_dec_options, key)))
335 goto err_out;
336 if (!(py_classval = PyList_GetItem(py_optlist, 1)))
337 goto err_out;
130ef08a 338 if (!PyUnicode_Check(py_classval) && !PyLong_Check(py_classval)) {
c9bfccc6
UH
339 srd_err("Options of type %s are not yet supported.",
340 Py_TYPE(py_classval)->tp_name);
130ef08a
BV
341 goto err_out;
342 }
0bdadba2
BV
343
344 if ((value = g_hash_table_lookup(options, key))) {
2f395bff
BV
345 dbg = g_variant_print(value, TRUE);
346 srd_dbg("got option '%s' = %s", key, dbg);
347 g_free(dbg);
0bdadba2
BV
348 /* An override for this option was provided. */
349 if (PyUnicode_Check(py_classval)) {
2f395bff
BV
350 if (!g_variant_is_of_type(value, G_VARIANT_TYPE_STRING)) {
351 srd_err("Option '%s' requires a string value.", key);
352 goto err_out;
353 }
354 val_str = g_variant_get_string(value, NULL);
355 if (!(py_optval = PyUnicode_FromString(val_str))) {
0bdadba2
BV
356 /* Some UTF-8 encoding error. */
357 PyErr_Clear();
2f395bff 358 srd_err("Option '%s' requires a UTF-8 string value.", key);
0bdadba2
BV
359 goto err_out;
360 }
361 } else if (PyLong_Check(py_classval)) {
2f395bff
BV
362 if (!g_variant_is_of_type(value, G_VARIANT_TYPE_INT64)) {
363 srd_err("Option '%s' requires an integer value.", key);
364 goto err_out;
365 }
366 val_int = g_variant_get_int64(value);
367 if (!(py_optval = PyLong_FromLong(val_int))) {
0bdadba2
BV
368 /* ValueError Exception */
369 PyErr_Clear();
2f395bff 370 srd_err("Option '%s' has invalid integer value.", key);
0bdadba2
BV
371 goto err_out;
372 }
373 }
374 g_hash_table_remove(options, key);
375 } else {
376 /* Use the class default for this option. */
377 if (PyUnicode_Check(py_classval)) {
378 /* Make a brand new copy of the string. */
379 py_ustr = PyUnicode_AS_UNICODE(py_classval);
380 size = PyUnicode_GET_SIZE(py_classval);
381 py_optval = PyUnicode_FromUnicode(py_ustr, size);
382 } else if (PyLong_Check(py_classval)) {
383 /* Make a brand new copy of the integer. */
384 val_ull = PyLong_AsUnsignedLongLong(py_classval);
385 if (val_ull == (unsigned long long)-1) {
386 /* OverFlowError exception */
387 PyErr_Clear();
c9bfccc6
UH
388 srd_err("Invalid integer value for %s: "
389 "expected integer.", key);
0bdadba2
BV
390 goto err_out;
391 }
392 if (!(py_optval = PyLong_FromUnsignedLongLong(val_ull)))
393 goto err_out;
394 }
395 }
396
361fdcaa
UH
397 /*
398 * If we got here, py_optval holds a known good new reference
0bdadba2
BV
399 * to the instance option to set.
400 */
401 if (PyDict_SetItemString(py_di_options, key, py_optval) == -1)
402 goto err_out;
e592ac89 403 g_free(key);
b88e336b 404 key = NULL;
0bdadba2
BV
405 }
406
407 ret = SRD_OK;
408
409err_out:
410 Py_XDECREF(py_optlist);
411 Py_XDECREF(py_di_options);
412 Py_XDECREF(py_dec_optkeys);
413 Py_XDECREF(py_dec_options);
6f858319 414 g_free(key);
7fc7bde6 415 if (PyErr_Occurred()) {
aafeeaea 416 srd_exception_catch("Stray exception in srd_inst_option_set().");
7fc7bde6
BV
417 ret = SRD_ERR_PYTHON;
418 }
0bdadba2
BV
419
420 return ret;
421}
422
b33b8aa5 423/* Helper GComparefunc for g_slist_find_custom() in srd_inst_probe_set_all() */
abeeed8b 424static gint compare_probe_id(const struct srd_probe *a, const char *probe_id)
f38ec285 425{
f38ec285
BV
426 return strcmp(a->id, probe_id);
427}
428
0bdadba2 429/**
b33b8aa5
UH
430 * Set all probes in a decoder instance.
431 *
432 * This function sets _all_ probes for the specified decoder instance, i.e.,
433 * it overwrites any probes that were already defined (if any).
0bdadba2
BV
434 *
435 * @param di Decoder instance.
38ff5046
UH
436 * @param new_probes A GHashTable of probes to set. Key is probe name, value is
437 * the probe number. Samples passed to this instance will be
438 * arranged in this order.
12243c22 439 *
0bdadba2 440 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
441 *
442 * @since 0.1.0
0bdadba2 443 */
b33b8aa5 444SRD_API int srd_inst_probe_set_all(struct srd_decoder_inst *di,
0ff2d191 445 GHashTable *new_probes)
0bdadba2 446{
2f395bff 447 GVariant *probe_val;
f38ec285
BV
448 GList *l;
449 GSList *sl;
450 struct srd_probe *p;
451 int *new_probemap, new_probenum;
2f395bff 452 char *probe_id;
38ff5046 453 int i, num_required_probes;
0bdadba2 454
ce46beed 455 srd_dbg("set probes called for instance %s with list of %d probes",
a8b72b05 456 di->inst_id, g_hash_table_size(new_probes));
ce46beed 457
f38ec285 458 if (g_hash_table_size(new_probes) == 0)
0bdadba2
BV
459 /* No probes provided. */
460 return SRD_OK;
461
c9bfccc6 462 if (di->dec_num_probes == 0) {
0bdadba2 463 /* Decoder has no probes. */
f38ec285 464 srd_err("Protocol decoder %s has no probes to define.",
c9bfccc6 465 di->decoder->name);
f38ec285
BV
466 return SRD_ERR_ARG;
467 }
0bdadba2 468
f38ec285 469 new_probemap = NULL;
0bdadba2 470
f38ec285 471 if (!(new_probemap = g_try_malloc(sizeof(int) * di->dec_num_probes))) {
a61ece20 472 srd_err("Failed to g_malloc() new probe map.");
f38ec285 473 return SRD_ERR_MALLOC;
0bdadba2
BV
474 }
475
38ff5046
UH
476 /*
477 * For now, map all indexes to probe -1 (can be overridden later).
478 * This -1 is interpreted as an unspecified probe later.
479 */
480 for (i = 0; i < di->dec_num_probes; i++)
481 new_probemap[i] = -1;
482
f38ec285
BV
483 for (l = g_hash_table_get_keys(new_probes); l; l = l->next) {
484 probe_id = l->data;
2f395bff
BV
485 probe_val= g_hash_table_lookup(new_probes, probe_id);
486 if (!g_variant_is_of_type(probe_val, G_VARIANT_TYPE_INT32)) {
be873260 487 /* Probe name was specified without a value. */
c9bfccc6 488 srd_err("No probe number was specified for %s.",
2f395bff 489 probe_id);
be873260
BV
490 g_free(new_probemap);
491 return SRD_ERR_ARG;
492 }
2f395bff 493 new_probenum = g_variant_get_int32(probe_val);
f38ec285
BV
494 if (!(sl = g_slist_find_custom(di->decoder->probes, probe_id,
495 (GCompareFunc)compare_probe_id))) {
496 /* Fall back on optional probes. */
dcdf4883 497 if (!(sl = g_slist_find_custom(di->decoder->opt_probes,
c9bfccc6
UH
498 probe_id, (GCompareFunc) compare_probe_id))) {
499 srd_err("Protocol decoder %s has no probe "
2f395bff 500 "'%s'.", di->decoder->name, probe_id);
f38ec285
BV
501 g_free(new_probemap);
502 return SRD_ERR_ARG;
503 }
504 }
505 p = sl->data;
506 new_probemap[p->order] = new_probenum;
38ff5046
UH
507 srd_dbg("Setting probe mapping: %s (index %d) = probe %d.",
508 p->id, p->order, new_probenum);
509 }
510
511 srd_dbg("Final probe map:");
512 num_required_probes = g_slist_length(di->decoder->probes);
513 for (i = 0; i < di->dec_num_probes; i++) {
514 srd_dbg(" - index %d = probe %d (%s)", i, new_probemap[i],
515 (i < num_required_probes) ? "required" : "optional");
f38ec285 516 }
38ff5046 517
f38ec285
BV
518 g_free(di->dec_probemap);
519 di->dec_probemap = new_probemap;
0bdadba2 520
f38ec285 521 return SRD_OK;
0bdadba2
BV
522}
523
524/**
525 * Create a new protocol decoder instance.
7ce7775c 526 *
32cfb920 527 * @param sess The session holding the protocol decoder instance.
38ff5046 528 * @param decoder_id Decoder 'id' field.
0bdadba2 529 * @param options GHashtable of options which override the defaults set in
38ff5046 530 * the decoder class. May be NULL.
12243c22 531 *
a8b72b05 532 * @return Pointer to a newly allocated struct srd_decoder_inst, or
c9bfccc6 533 * NULL in case of failure.
8c664ca2
UH
534 *
535 * @since 0.1.0
7ce7775c 536 */
32cfb920
BV
537SRD_API struct srd_decoder_inst *srd_inst_new(struct srd_session *sess,
538 const char *decoder_id, GHashTable *options)
b2c19614 539{
c9bfccc6 540 int i;
b2c19614 541 struct srd_decoder *dec;
a8b72b05
BV
542 struct srd_decoder_inst *di;
543 char *inst_id;
b2c19614 544
7a1712c4 545 srd_dbg("Creating new %s instance.", decoder_id);
7ce7775c 546
32cfb920
BV
547 if (session_is_valid(sess) != SRD_OK) {
548 srd_err("Invalid session.");
549 return NULL;
550 }
551
9d122fd5 552 if (!(dec = srd_decoder_get_by_id(decoder_id))) {
0bdadba2 553 srd_err("Protocol decoder %s not found.", decoder_id);
b2c19614 554 return NULL;
0bdadba2 555 }
b2c19614 556
a8b72b05 557 if (!(di = g_try_malloc0(sizeof(struct srd_decoder_inst)))) {
a61ece20 558 srd_err("Failed to g_malloc() instance.");
7ce7775c
BV
559 return NULL;
560 }
0bdadba2 561
b2c19614 562 di->decoder = dec;
32cfb920 563 di->sess = sess;
38ff5046
UH
564 if (options) {
565 inst_id = g_hash_table_lookup(options, "id");
566 di->inst_id = g_strdup(inst_id ? inst_id : decoder_id);
567 g_hash_table_remove(options, "id");
568 } else
569 di->inst_id = g_strdup(decoder_id);
b2c19614 570
361fdcaa
UH
571 /*
572 * Prepare a default probe map, where samples come in the
f38ec285
BV
573 * order in which the decoder class defined them.
574 */
575 di->dec_num_probes = g_slist_length(di->decoder->probes) +
c9bfccc6 576 g_slist_length(di->decoder->opt_probes);
19a90bab 577 if (di->dec_num_probes) {
c9bfccc6
UH
578 if (!(di->dec_probemap =
579 g_try_malloc(sizeof(int) * di->dec_num_probes))) {
a61ece20 580 srd_err("Failed to g_malloc() probe map.");
19a90bab
BV
581 g_free(di);
582 return NULL;
583 }
584 for (i = 0; i < di->dec_num_probes; i++)
585 di->dec_probemap[i] = i;
f38ec285 586 }
f38ec285 587
0bdadba2 588 /* Create a new instance of this decoder class. */
a8b72b05 589 if (!(di->py_inst = PyObject_CallObject(dec->py_dec, NULL))) {
b2c19614 590 if (PyErr_Occurred())
aafeeaea
UH
591 srd_exception_catch("failed to create %s instance: ",
592 decoder_id);
f38ec285 593 g_free(di->dec_probemap);
0bdadba2 594 g_free(di);
7ce7775c 595 return NULL;
b2c19614 596 }
7ce7775c 597
38ff5046 598 if (options && srd_inst_option_set(di, options) != SRD_OK) {
f38ec285 599 g_free(di->dec_probemap);
0bdadba2
BV
600 g_free(di);
601 return NULL;
602 }
b2c19614 603
f38ec285 604 /* Instance takes input from a frontend by default. */
32cfb920 605 sess->di_list = g_slist_append(sess->di_list, di);
f38ec285 606
b2c19614
BV
607 return di;
608}
609
582c8473
BV
610/**
611 * Stack a decoder instance on top of another.
612 *
32cfb920 613 * @param sess The session holding the protocol decoder instances.
582c8473
BV
614 * @param di_from The instance to move.
615 * @param di_to The instance on top of which di_from will be stacked.
616 *
617 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
618 *
619 * @since 0.1.0
582c8473 620 */
32cfb920
BV
621SRD_API int srd_inst_stack(struct srd_session *sess,
622 struct srd_decoder_inst *di_from, struct srd_decoder_inst *di_to)
7ce7775c 623{
32cfb920
BV
624
625 if (session_is_valid(sess) != SRD_OK) {
626 srd_err("Invalid session.");
627 return SRD_ERR_ARG;
628 }
629
7ce7775c 630 if (!di_from || !di_to) {
d906d3f9 631 srd_err("Invalid from/to instance pair.");
7ce7775c
BV
632 return SRD_ERR_ARG;
633 }
634
32cfb920 635 if (g_slist_find(sess->di_list, di_to)) {
2072ae0c 636 /* Remove from the unstacked list. */
32cfb920 637 sess->di_list = g_slist_remove(sess->di_list, di_to);
7ce7775c
BV
638 }
639
7ce7775c
BV
640 /* Stack on top of source di. */
641 di_from->next_di = g_slist_append(di_from->next_di, di_to);
642
643 return SRD_OK;
644}
645
2072ae0c 646/**
361fdcaa
UH
647 * Find a decoder instance by its instance ID.
648 *
649 * Only the bottom level of instances are searched -- instances already stacked
650 * on top of another one will not be found.
2072ae0c 651 *
32cfb920 652 * @param sess The session holding the protocol decoder instance.
ed2306a6 653 * @param inst_id The instance ID to be found.
2072ae0c 654 *
a8b72b05 655 * @return Pointer to struct srd_decoder_inst, or NULL if not found.
8c664ca2
UH
656 *
657 * @since 0.1.0
2072ae0c 658 */
32cfb920
BV
659SRD_API struct srd_decoder_inst *srd_inst_find_by_id(struct srd_session *sess,
660 const char *inst_id)
7ce7775c
BV
661{
662 GSList *l;
a8b72b05 663 struct srd_decoder_inst *tmp, *di;
b2c19614 664
32cfb920
BV
665 if (session_is_valid(sess) != SRD_OK) {
666 srd_err("Invalid session.");
667 return NULL;
668 }
669
7ce7775c 670 di = NULL;
32cfb920 671 for (l = sess->di_list; l; l = l->next) {
7ce7775c 672 tmp = l->data;
a8b72b05 673 if (!strcmp(tmp->inst_id, inst_id)) {
7ce7775c
BV
674 di = tmp;
675 break;
676 }
677 }
678
679 return di;
680}
681
32cfb920
BV
682static struct srd_decoder_inst *srd_sess_inst_find_by_obj(
683 struct srd_session *sess, const GSList *stack,
684 const PyObject *obj)
685{
686 const GSList *l;
687 struct srd_decoder_inst *tmp, *di;
688
689 if (session_is_valid(sess) != SRD_OK) {
690 srd_err("Invalid session.");
691 return NULL;
692 }
693
694 di = NULL;
695 for (l = stack ? stack : sess->di_list; di == NULL && l != NULL; l = l->next) {
696 tmp = l->data;
697 if (tmp->py_inst == obj)
698 di = tmp;
699 else if (tmp->next_di)
700 di = srd_sess_inst_find_by_obj(sess, tmp->next_di, obj);
701 }
702
703 return di;
704}
705
2072ae0c 706/**
361fdcaa
UH
707 * Find a decoder instance by its Python object.
708 *
709 * I.e. find that instance's instantiation of the sigrokdecode.Decoder class.
32cfb920
BV
710 * This will recurse to find the instance anywhere in the stack tree of all
711 * sessions.
2072ae0c 712 *
361fdcaa
UH
713 * @param stack Pointer to a GSList of struct srd_decoder_inst, indicating the
714 * stack to search. To start searching at the bottom level of
715 * decoder instances, pass NULL.
511e2123 716 * @param obj The Python class instantiation.
2072ae0c 717 *
a8b72b05 718 * @return Pointer to struct srd_decoder_inst, or NULL if not found.
57790bc8
UH
719 *
720 * @private
8c664ca2
UH
721 *
722 * @since 0.1.0
2072ae0c 723 */
abeeed8b 724SRD_PRIV struct srd_decoder_inst *srd_inst_find_by_obj(const GSList *stack,
0ff2d191 725 const PyObject *obj)
2072ae0c 726{
32cfb920
BV
727 struct srd_decoder_inst *di;
728 struct srd_session *sess;
729 GSList *l;
2072ae0c
BV
730
731 di = NULL;
32cfb920
BV
732 for (l = sessions; di == NULL && l != NULL; l = l->next) {
733 sess = l->data;
734 di = srd_sess_inst_find_by_obj(sess, stack, obj);
2072ae0c
BV
735 }
736
737 return di;
738}
739
57790bc8 740/** @private */
ee4ed227 741SRD_PRIV int srd_inst_start(struct srd_decoder_inst *di, PyObject *args)
b2c19614 742{
7ce7775c 743 PyObject *py_name, *py_res;
2072ae0c 744 GSList *l;
a8b72b05 745 struct srd_decoder_inst *next_di;
b2c19614 746
7a1712c4 747 srd_dbg("Calling start() method on protocol decoder instance %s.",
a8b72b05 748 di->inst_id);
b2c19614 749
7ce7775c 750 if (!(py_name = PyUnicode_FromString("start"))) {
511e2123 751 srd_err("Unable to build Python object for 'start'.");
aafeeaea
UH
752 srd_exception_catch("Protocol decoder instance %s: ",
753 di->inst_id);
7ce7775c
BV
754 return SRD_ERR_PYTHON;
755 }
756
a8b72b05 757 if (!(py_res = PyObject_CallMethodObjArgs(di->py_inst,
c9bfccc6 758 py_name, args, NULL))) {
aafeeaea
UH
759 srd_exception_catch("Protocol decoder instance %s: ",
760 di->inst_id);
7ce7775c 761 return SRD_ERR_PYTHON;
b2c19614
BV
762 }
763
f38ec285
BV
764 Py_DecRef(py_res);
765 Py_DecRef(py_name);
7ce7775c 766
361fdcaa
UH
767 /*
768 * Start all the PDs stacked on top of this one. Pass along the
2072ae0c
BV
769 * metadata all the way from the bottom PD, even though it's only
770 * applicable to logic data for now.
771 */
772 for (l = di->next_di; l; l = l->next) {
773 next_di = l->data;
a8b72b05 774 srd_inst_start(next_di, args);
2072ae0c
BV
775 }
776
b2c19614
BV
777 return SRD_OK;
778}
779
b2c19614
BV
780/**
781 * Run the specified decoder function.
782 *
d906d3f9 783 * @param start_samplenum The starting sample number for the buffer's sample
7a1712c4
UH
784 * set, relative to the start of capture.
785 * @param di The decoder instance to call. Must not be NULL.
786 * @param inbuf The buffer to decode. Must not be NULL.
787 * @param inbuflen Length of the buffer. Must be > 0.
b2c19614
BV
788 *
789 * @return SRD_OK upon success, a (negative) error code otherwise.
57790bc8
UH
790 *
791 * @private
8c664ca2
UH
792 *
793 * @since 0.1.0
b2c19614 794 */
12243c22 795SRD_PRIV int srd_inst_decode(uint64_t start_samplenum,
0ff2d191
BV
796 const struct srd_decoder_inst *di, const uint8_t *inbuf,
797 uint64_t inbuflen)
b2c19614 798{
d906d3f9 799 PyObject *py_res;
bc5f5a43 800 srd_logic *logic;
86528298 801 uint64_t end_samplenum;
b2c19614 802
7a1712c4 803 srd_dbg("Calling decode() on instance %s with %d bytes starting "
a8b72b05 804 "at sample %d.", di->inst_id, inbuflen, start_samplenum);
b2c19614 805
d906d3f9 806 /* Return an error upon unusable input. */
7a1712c4
UH
807 if (!di) {
808 srd_dbg("empty decoder instance");
d906d3f9
BV
809 return SRD_ERR_ARG;
810 }
7a1712c4
UH
811 if (!inbuf) {
812 srd_dbg("NULL buffer pointer");
d906d3f9
BV
813 return SRD_ERR_ARG;
814 }
815 if (inbuflen == 0) {
7a1712c4 816 srd_dbg("empty buffer");
d906d3f9
BV
817 return SRD_ERR_ARG;
818 }
b2c19614 819
361fdcaa
UH
820 /*
821 * Create new srd_logic object. Each iteration around the PD's loop
d906d3f9
BV
822 * will fill one sample into this object.
823 */
bc5f5a43
BV
824 logic = PyObject_New(srd_logic, &srd_logic_type);
825 Py_INCREF(logic);
abeeed8b 826 logic->di = (struct srd_decoder_inst *)di;
86528298 827 logic->start_samplenum = start_samplenum;
bc5f5a43 828 logic->itercnt = 0;
abeeed8b 829 logic->inbuf = (uint8_t *)inbuf;
bc5f5a43
BV
830 logic->inbuflen = inbuflen;
831 logic->sample = PyList_New(2);
832 Py_INCREF(logic->sample);
833
a8b72b05 834 Py_IncRef(di->py_inst);
f38ec285 835 end_samplenum = start_samplenum + inbuflen / di->data_unitsize;
a8b72b05 836 if (!(py_res = PyObject_CallMethod(di->py_inst, "decode",
c9bfccc6
UH
837 "KKO", logic->start_samplenum,
838 end_samplenum, logic))) {
aafeeaea
UH
839 srd_exception_catch("Protocol decoder instance %s: ",
840 di->inst_id);
0ff2d191 841 return SRD_ERR_PYTHON;
b2c19614 842 }
d906d3f9 843 Py_DecRef(py_res);
bc5f5a43 844
b2c19614
BV
845 return SRD_OK;
846}
847
57790bc8 848/** @private */
12243c22 849SRD_PRIV void srd_inst_free(struct srd_decoder_inst *di)
fa12a21e
BV
850{
851 GSList *l;
852 struct srd_pd_output *pdo;
853
a8b72b05 854 srd_dbg("Freeing instance %s", di->inst_id);
fa12a21e 855
a8b72b05
BV
856 Py_DecRef(di->py_inst);
857 g_free(di->inst_id);
fa12a21e
BV
858 g_free(di->dec_probemap);
859 g_slist_free(di->next_di);
860 for (l = di->pd_output; l; l = l->next) {
861 pdo = l->data;
862 g_free(pdo->proto_id);
863 g_free(pdo);
864 }
865 g_slist_free(di->pd_output);
e592ac89 866 g_free(di);
fa12a21e
BV
867}
868
57790bc8 869/** @private */
32cfb920 870SRD_PRIV void srd_inst_free_all(struct srd_session *sess, GSList *stack)
fa12a21e
BV
871{
872 GSList *l;
a8b72b05 873 struct srd_decoder_inst *di;
fa12a21e 874
32cfb920
BV
875 if (session_is_valid(sess) != SRD_OK) {
876 srd_err("Invalid session.");
877 return;
878 }
879
fa12a21e 880 di = NULL;
32cfb920 881 for (l = stack ? stack : sess->di_list; di == NULL && l != NULL; l = l->next) {
fa12a21e
BV
882 di = l->data;
883 if (di->next_di)
32cfb920 884 srd_inst_free_all(sess, di->next_di);
a8b72b05 885 srd_inst_free(di);
fa12a21e
BV
886 }
887 if (!stack) {
32cfb920
BV
888 g_slist_free(sess->di_list);
889 sess->di_list = NULL;
fa12a21e 890 }
fa12a21e 891}
b2c19614 892
4895418c
UH
893/** @} */
894
895/**
896 * @defgroup grp_session Session handling
897 *
898 * Starting and handling decoding sessions.
899 *
900 * @{
901 */
902
32cfb920
BV
903static int session_is_valid(struct srd_session *sess)
904{
905
906 if (!sess || sess->session_id < 1)
907 return SRD_ERR;
908
909 return SRD_OK;
910}
911
912/**
913 * Create a decoding session.
914 *
915 * A session holds all decoder instances, their stack relationships and
916 * output callbacks.
917 *
918 * @param sess. A pointer which will hold a pointer to a newly
919 * initialized session on return.
920 *
921 * @return SRD_OK upon success, a (negative) error code otherwise.
922 *
923 * @since 0.3.0
924 */
925SRD_API int srd_session_new(struct srd_session **sess)
926{
927
928 if (!sess) {
929 srd_err("Invalid session pointer.");
930 return SRD_ERR;
931 }
932
933 if (!(*sess = g_try_malloc(sizeof(struct srd_session))))
934 return SRD_ERR_MALLOC;
935 (*sess)->session_id = ++max_session_id;
936 (*sess)->num_probes = (*sess)->unitsize = (*sess)->samplerate = 0;
937 (*sess)->di_list = (*sess)->callbacks = NULL;
938
939 /* Keep a list of all sessions, so we can clean up as needed. */
940 sessions = g_slist_append(sessions, *sess);
941
942 srd_dbg("Created session %d.", (*sess)->session_id);
943
944 return SRD_OK;
945}
946
582c8473
BV
947/**
948 * Start a decoding session.
949 *
32cfb920
BV
950 * Decoders, instances and stack must have been prepared beforehand,
951 * and all SRD_CONF parameters set.
582c8473 952 *
32cfb920 953 * @param sess The session to start.
582c8473
BV
954 *
955 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
956 *
957 * @since 0.1.0
582c8473 958 */
32cfb920 959SRD_API int srd_session_start(struct srd_session *sess)
7ce7775c
BV
960{
961 PyObject *args;
2072ae0c 962 GSList *d;
a8b72b05 963 struct srd_decoder_inst *di;
7ce7775c
BV
964 int ret;
965
32cfb920
BV
966 if (session_is_valid(sess) != SRD_OK) {
967 srd_err("Invalid session pointer.");
968 return SRD_ERR;
969 }
970 if (sess->num_probes == 0) {
971 srd_err("Session has invalid number of probes.");
972 return SRD_ERR;
973 }
974 if (sess->unitsize == 0) {
975 srd_err("Session has invalid unitsize.");
976 return SRD_ERR;
977 }
978 if (sess->samplerate == 0) {
979 srd_err("Session has invalid samplerate.");
980 return SRD_ERR;
981 }
982
38ff5046
UH
983 ret = SRD_OK;
984
32cfb920
BV
985 srd_dbg("Calling start() on all instances in session %d with "
986 "%d probes, unitsize %d samplerate %d.", sess->session_id,
987 sess->num_probes, sess->unitsize, sess->samplerate);
d906d3f9 988
361fdcaa
UH
989 /*
990 * Currently only one item of metadata is passed along to decoders,
d906d3f9
BV
991 * samplerate. This can be extended as needed.
992 */
32cfb920 993 if (!(args = Py_BuildValue("{s:l}", "samplerate", (long)sess->samplerate))) {
511e2123 994 srd_err("Unable to build Python object for metadata.");
7ce7775c
BV
995 return SRD_ERR_PYTHON;
996 }
997
998 /* Run the start() method on all decoders receiving frontend data. */
32cfb920 999 for (d = sess->di_list; d; d = d->next) {
7ce7775c 1000 di = d->data;
32cfb920
BV
1001 di->data_num_probes = sess->num_probes;
1002 di->data_unitsize = sess->unitsize;
1003 di->data_samplerate = sess->samplerate;
38ff5046 1004 if ((ret = srd_inst_start(di, args)) != SRD_OK)
2072ae0c 1005 break;
7ce7775c
BV
1006 }
1007
d906d3f9 1008 Py_DecRef(args);
7ce7775c 1009
2072ae0c 1010 return ret;
7ce7775c
BV
1011}
1012
32cfb920
BV
1013/**
1014 * Set a configuration key in a session.
1015 *
1016 * @param sess The session to configure.
1017 * @param key The configuration key (SRD_CONF_*).
1018 * @param data The new value for the key, as a GVariant with GVariantType
1019 * appropriate to that key. A floating reference can be passed
1020 * in; its refcount will be sunk and unreferenced after use.
1021 *
1022 * @return SRD_OK upon success, a (negative) error code otherwise.
1023 *
1024 * @since 0.3.0
1025 */
1026SRD_API int srd_session_config_set(struct srd_session *sess, int key,
1027 GVariant *data)
1028{
1029
1030 if (session_is_valid(sess) != SRD_OK) {
1031 srd_err("Invalid session.");
1032 return SRD_ERR_ARG;
1033 }
1034
1035 if (!g_variant_is_of_type(data, G_VARIANT_TYPE_UINT64)) {
1036 srd_err("Value for key %d should be of type uint64.");
1037 return SRD_ERR_ARG;
1038 }
1039
1040 switch (key) {
1041 case SRD_CONF_NUM_PROBES:
1042 sess->num_probes = g_variant_get_uint64(data);
1043 break;
1044 case SRD_CONF_UNITSIZE:
1045 sess->unitsize = g_variant_get_uint64(data);
1046 break;
1047 case SRD_CONF_SAMPLERATE:
1048 sess->samplerate = g_variant_get_uint64(data);
1049 break;
1050 }
1051
1052 g_variant_unref(data);
1053
1054 return SRD_OK;
1055}
1056
582c8473 1057/**
29dad0ac 1058 * Send a chunk of logic sample data to a running decoder session.
582c8473 1059 *
32cfb920 1060 * @param sess The session to use.
582c8473
BV
1061 * @param start_samplenum The sample number of the first sample in this chunk.
1062 * @param inbuf Pointer to sample data.
38ff5046 1063 * @param inbuflen Length in bytes of the buffer.
582c8473
BV
1064 *
1065 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
1066 *
1067 * @since 0.1.0
582c8473 1068 */
32cfb920
BV
1069SRD_API int srd_session_send(struct srd_session *sess, uint64_t start_samplenum,
1070 const uint8_t *inbuf, uint64_t inbuflen)
b2c19614
BV
1071{
1072 GSList *d;
1073 int ret;
1074
32cfb920
BV
1075 if (session_is_valid(sess) != SRD_OK) {
1076 srd_err("Invalid session.");
1077 return SRD_ERR_ARG;
1078 }
1079
7a1712c4 1080 srd_dbg("Calling decode() on all instances with starting sample "
c9bfccc6
UH
1081 "number %" PRIu64 ", %" PRIu64 " bytes at 0x%p",
1082 start_samplenum, inbuflen, inbuf);
d906d3f9 1083
32cfb920 1084 for (d = sess->di_list; d; d = d->next) {
a8b72b05 1085 if ((ret = srd_inst_decode(start_samplenum, d->data, inbuf,
361fdcaa 1086 inbuflen)) != SRD_OK)
b2c19614
BV
1087 return ret;
1088 }
1089
1090 return SRD_OK;
1091}
1092
32cfb920
BV
1093/**
1094 * Destroy a decoding session.
1095 *
1096 * All decoder instances and output callbacks are properly released.
1097 *
1098 * @param sess. The session to be destroyed.
1099 *
1100 * @return SRD_OK upon success, a (negative) error code otherwise.
1101 *
1102 * @since 0.1.0
1103 */
1104SRD_API int srd_session_destroy(struct srd_session *sess)
1105{
1106 int session_id;
1107
1108 session_id = sess->session_id;
1109 if (sess->di_list)
1110 srd_inst_free_all(sess, NULL);
1111 if (sess->callbacks)
1112 g_slist_free_full(sess->callbacks, g_free);
1113 sessions = g_slist_remove(sessions, sess);
1114 g_free(sess);
1115
1116 srd_dbg("Destroyed session %d.", session_id);
1117
1118 return SRD_OK;
1119}
1120
582c8473 1121/**
b33b8aa5 1122 * Register/add a decoder output callback function.
582c8473
BV
1123 *
1124 * The function will be called when a protocol decoder sends output back
1125 * to the PD controller (except for Python objects, which only go up the
1126 * stack).
1127 *
32cfb920 1128 * @param sess The output session in which to register the callback.
582c8473 1129 * @param output_type The output type this callback will receive. Only one
4c1d0670 1130 * callback per output type can be registered.
361fdcaa
UH
1131 * @param cb The function to call. Must not be NULL.
1132 * @param cb_data Private data for the callback function. Can be NULL.
8c664ca2
UH
1133 *
1134 * @since 0.1.0
582c8473 1135 */
32cfb920
BV
1136SRD_API int srd_pd_output_callback_add(struct srd_session *sess,
1137 int output_type, srd_pd_output_callback_t cb, void *cb_data)
4fadb128
BV
1138{
1139 struct srd_pd_callback *pd_cb;
1140
32cfb920
BV
1141 if (session_is_valid(sess) != SRD_OK) {
1142 srd_err("Invalid session.");
1143 return SRD_ERR_ARG;
1144 }
1145
7a1712c4 1146 srd_dbg("Registering new callback for output type %d.", output_type);
4fadb128 1147
a61ece20
UH
1148 if (!(pd_cb = g_try_malloc(sizeof(struct srd_pd_callback)))) {
1149 srd_err("Failed to g_malloc() struct srd_pd_callback.");
4fadb128 1150 return SRD_ERR_MALLOC;
a61ece20 1151 }
4fadb128
BV
1152
1153 pd_cb->output_type = output_type;
4c1d0670 1154 pd_cb->cb = cb;
41a5d962 1155 pd_cb->cb_data = cb_data;
32cfb920 1156 sess->callbacks = g_slist_append(sess->callbacks, pd_cb);
4fadb128
BV
1157
1158 return SRD_OK;
1159}
1160
57790bc8 1161/** @private */
32cfb920
BV
1162SRD_PRIV struct srd_pd_callback *srd_pd_output_callback_find(
1163 struct srd_session *sess, int output_type)
4fadb128
BV
1164{
1165 GSList *l;
2994587f 1166 struct srd_pd_callback *tmp, *pd_cb;
4fadb128 1167
32cfb920
BV
1168 if (session_is_valid(sess) != SRD_OK) {
1169 srd_err("Invalid session.");
1170 return NULL;
1171 }
1172
2994587f 1173 pd_cb = NULL;
32cfb920 1174 for (l = sess->callbacks; l; l = l->next) {
2994587f
BV
1175 tmp = l->data;
1176 if (tmp->output_type == output_type) {
1177 pd_cb = tmp;
4fadb128
BV
1178 break;
1179 }
1180 }
1181
2994587f 1182 return pd_cb;
4fadb128
BV
1183}
1184
511e2123 1185/* This is the backend function to Python sigrokdecode.add() call. */
57790bc8 1186/** @private */
aafeeaea
UH
1187SRD_PRIV int srd_inst_pd_output_add(struct srd_decoder_inst *di,
1188 int output_type, const char *proto_id)
e5080882 1189{
e5080882 1190 struct srd_pd_output *pdo;
e5080882 1191
7a1712c4 1192 srd_dbg("Instance %s creating new output type %d for %s.",
a8b72b05 1193 di->inst_id, output_type, proto_id);
d906d3f9 1194
a61ece20
UH
1195 if (!(pdo = g_try_malloc(sizeof(struct srd_pd_output)))) {
1196 srd_err("Failed to g_malloc() struct srd_pd_output.");
e5080882 1197 return -1;
a61ece20 1198 }
e5080882 1199
b231546d 1200 /* pdo_id is just a simple index, nothing is deleted from this list anyway. */
15969949 1201 pdo->pdo_id = g_slist_length(di->pd_output);
e5080882 1202 pdo->output_type = output_type;
b3b2cae8 1203 pdo->di = di;
94d43b37 1204 pdo->proto_id = g_strdup(proto_id);
e5080882
BV
1205 di->pd_output = g_slist_append(di->pd_output, pdo);
1206
15969949 1207 return pdo->pdo_id;
e5080882 1208}
d7dae84b
UH
1209
1210/** @} */