]> sigrok.org Git - libsigrok.git/commitdiff
korad-kaxxxxp: fix potential NULL dereference
authorGerhard Sittig <redacted>
Fri, 9 Feb 2018 18:08:11 +0000 (19:08 +0100)
committerUwe Hermann <redacted>
Fri, 9 Feb 2018 20:37:39 +0000 (21:37 +0100)
Check pointers' validity before dereferencing them.

This was reported by clang's scan-build.

src/hardware/korad-kaxxxxp/api.c

index 96aa03e67ebb738495d101ddecbfb86e977e4cee..d33373e2b88e94c26147de3cb635fd580fb04821 100644 (file)
@@ -281,9 +281,13 @@ static int config_list(uint32_t key, GVariant **data,
        case SR_CONF_DEVICE_OPTIONS:
                return STD_CONFIG_LIST(key, data, sdi, cg, scanopts, drvopts, devopts);
        case SR_CONF_VOLTAGE_TARGET:
+               if (!devc || !devc->model)
+                       return SR_ERR_ARG;
                *data = std_gvar_min_max_step_array(devc->model->voltage);
                break;
        case SR_CONF_CURRENT_LIMIT:
+               if (!devc || !devc->model)
+                       return SR_ERR_ARG;
                *data = std_gvar_min_max_step_array(devc->model->current);
                break;
        default: