]> sigrok.org Git - libsigrok.git/commitdiff
ols: drop wrong usage of macro
authorWolfram Sang <redacted>
Wed, 2 Jan 2019 12:15:17 +0000 (13:15 +0100)
committerUwe Hermann <redacted>
Sun, 13 Jan 2019 19:07:27 +0000 (20:07 +0100)
commit f51acd69 ("ols: combine demux samples") wrongly replaced the bit
pattern of 0x20 with the number of channels which just happens to be 32
as well. So, the code works but is confusing to read. Reword the
for-loop to make it more comprehensible.

Signed-off-by: Wolfram Sang <redacted>
src/hardware/openbench-logic-sniffer/protocol.c

index 3bfb890fddf6623f8af8af9495d667b25d71b028..0041b21a3b744144252e611d8ee8a9bb6c15089d 100644 (file)
@@ -365,7 +365,7 @@ SR_PRIV int ols_receive_data(int fd, int revents, void *cb_data)
        }
 
        num_ols_changrp = 0;
-       for (i = NUM_CHANNELS; i > 0x02; i /= 2) {
+       for (i = 0x20; i > 0x02; i >>= 1) {
                if ((devc->flag_reg & i) == 0) {
                        num_ols_changrp++;
                }