hp-3457a: style nits in the probe routine
authorGerhard Sittig <gerhard.sittig@gmx.net>
Sun, 16 May 2021 13:30:42 +0000 (15:30 +0200)
committerGerhard Sittig <gerhard.sittig@gmx.net>
Sat, 22 May 2021 06:06:58 +0000 (08:06 +0200)
Unobfuscate a string comparison. Eliminate redundant data type specs
in malloc calls.

src/hardware/hp-3457a/api.c

index 6e42bb9ac91f23b1ad8c0c4cce47284763e96997..f828cfd817f3743c7c764561c8ac8c5737285cff 100644 (file)
@@ -138,15 +138,15 @@ static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi)
        if ((ret != SR_OK) || !response)
                return NULL;
 
-       if (strcmp(response, "HP3457A")) {
+       if (strcmp(response, "HP3457A") != 0) {
                g_free(response);
                return NULL;
        }
 
        g_free(response);
 
-       devc = g_malloc0(sizeof(struct dev_context));
-       sdi = g_malloc0(sizeof(struct sr_dev_inst));
+       devc = g_malloc0(sizeof(*devc));
+       sdi = g_malloc0(sizeof(*sdi));
        sdi->vendor = g_strdup("Hewlett-Packard");
        sdi->model = g_strdup("3457A");
        sdi->version = get_revision(scpi);