src/hardware/scpi-pps/api.c

   1 /*
   2  * This file is part of the libsigrok project.
   3  *
   4  * Copyright (C) 2014 Bert Vermeulen <bert@biot.com>
   5  *
   6  * This program is free software: you can redistribute it and/or modify
   7  * it under the terms of the GNU General Public License as published by
   8  * the Free Software Foundation, either version 3 of the License, or
   9  * (at your option) any later version.
  10  *
  11  * This program is distributed in the hope that it will be useful,
  12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  14  * GNU General Public License for more details.
  15  *
  16  * You should have received a copy of the GNU General Public License
  17  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  18  */
  19
  20 #include <config.h>
  21 #include <string.h>
  22 #include <strings.h>
  23 #include "scpi.h"
  24 #include "protocol.h"
  25
  26 SR_PRIV struct sr_dev_driver scpi_pps_driver_info;
  27
  28 static const uint32_t scanopts[] = {
  29         SR_CONF_CONN,
  30         SR_CONF_SERIALCOMM,
  31 };
  32
  33 static const uint32_t drvopts[] = {
  34         SR_CONF_POWER_SUPPLY,
  35 };
  36
  37 static const struct pps_channel_instance pci[] = {
  38         { SR_MQ_VOLTAGE, SCPI_CMD_GET_MEAS_VOLTAGE, "V" },
  39         { SR_MQ_CURRENT, SCPI_CMD_GET_MEAS_CURRENT, "I" },
  40         { SR_MQ_POWER, SCPI_CMD_GET_MEAS_POWER, "P" },
  41         { SR_MQ_FREQUENCY, SCPI_CMD_GET_MEAS_FREQUENCY, "F" },
  42 };
  43
  44 static int init(struct sr_dev_driver *di, struct sr_context *sr_ctx)
  45 {
  46         return std_init(sr_ctx, di, LOG_PREFIX);
  47 }
  48
  49 static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi)
  50 {
  51         struct dev_context *devc;
  52         struct sr_dev_inst *sdi;
  53         struct sr_scpi_hw_info *hw_info;
  54         struct sr_channel_group *cg;
  55         struct sr_channel *ch;
  56         const struct scpi_pps *device;
  57         struct pps_channel *pch;
  58         struct channel_spec *channels;
  59         struct channel_group_spec *channel_groups, *cgs;
  60         struct pps_channel_group *pcg;
  61         GRegex *model_re;
  62         GMatchInfo *model_mi;
  63         GSList *l;
  64         uint64_t mask;
  65         unsigned int num_channels, num_channel_groups, ch_num, ch_idx, i, j;
  66         int ret;
  67         const char *vendor;
  68         char ch_name[16];
  69
  70         if (sr_scpi_get_hw_id(scpi, &hw_info) != SR_OK) {
  71                 sr_info("Couldn't get IDN response.");
  72                 return NULL;
  73         }
  74
  75         device = NULL;
  76         for (i = 0; i < num_pps_profiles; i++) {
  77                 vendor = sr_vendor_alias(hw_info->manufacturer);
  78                 if (g_ascii_strcasecmp(vendor, pps_profiles[i].vendor))
  79                         continue;
  80                 model_re = g_regex_new(pps_profiles[i].model, 0, 0, NULL);
  81                 if (g_regex_match(model_re, hw_info->model, 0, &model_mi))
  82                         device = &pps_profiles[i];
  83                 g_match_info_unref(model_mi);
  84                 g_regex_unref(model_re);
  85                 if (device)
  86                         break;
  87         }
  88         if (!device) {
  89                 sr_scpi_hw_info_free(hw_info);
  90                 return NULL;
  91         }
  92
  93         sdi = g_malloc0(sizeof(struct sr_dev_inst));
  94         sdi->vendor = g_strdup(vendor);
  95         sdi->model = g_strdup(hw_info->model);
  96         sdi->version = g_strdup(hw_info->firmware_version);
  97         sdi->conn = scpi;
  98         sdi->driver = &scpi_pps_driver_info;
  99         sdi->inst_type = SR_INST_SCPI;
 100         sdi->serial_num = g_strdup(hw_info->serial_number);
 101
 102         devc = g_malloc0(sizeof(struct dev_context));
 103         devc->device = device;
 104         sdi->priv = devc;
 105
 106         if (device->num_channels) {
 107                 /* Static channels and groups. */
 108                 channels = (struct channel_spec *)device->channels;
 109                 num_channels = device->num_channels;
 110                 channel_groups = (struct channel_group_spec *)device->channel_groups;
 111                 num_channel_groups = device->num_channel_groups;
 112         } else {
 113                 /* Channels and groups need to be probed. */
 114                 ret = device->probe_channels(sdi, hw_info, &channels, &num_channels,
 115                                 &channel_groups, &num_channel_groups);
 116                 if (ret != SR_OK) {
 117                         sr_err("Failed to probe for channels.");
 118                         return NULL;
 119                 }
 120                 /*
 121                  * Since these were dynamically allocated, we'll need to free them
 122                  * later.
 123                  */
 124                 devc->channels = channels;
 125                 devc->channel_groups = channel_groups;
 126         }
 127
 128         ch_idx = 0;
 129         for (ch_num = 0; ch_num < num_channels; ch_num++) {
 130                 /* Create one channel per measurable output unit. */
 131                 for (i = 0; i < ARRAY_SIZE(pci); i++) {
 132                         if (!scpi_cmd_get(devc->device->commands, pci[i].command))
 133                                 continue;
 134                         g_snprintf(ch_name, 16, "%s%s", pci[i].prefix,
 135                                         channels[ch_num].name);
 136                         ch = sr_channel_new(sdi, ch_idx++, SR_CHANNEL_ANALOG, TRUE,
 137                                         ch_name);
 138                         pch = g_malloc0(sizeof(struct pps_channel));
 139                         pch->hw_output_idx = ch_num;
 140                         pch->hwname = channels[ch_num].name;
 141                         pch->mq = pci[i].mq;
 142                         ch->priv = pch;
 143                 }
 144         }
 145
 146         for (i = 0; i < num_channel_groups; i++) {
 147                 cgs = &channel_groups[i];
 148                 cg = g_malloc0(sizeof(struct sr_channel_group));
 149                 cg->name = g_strdup(cgs->name);
 150                 for (j = 0, mask = 1; j < 64; j++, mask <<= 1) {
 151                         if (cgs->channel_index_mask & mask) {
 152                                 for (l = sdi->channels; l; l = l->next) {
 153                                         ch = l->data;
 154                                         pch = ch->priv;
 155                                         if (pch->hw_output_idx == j)
 156                                                 cg->channels = g_slist_append(cg->channels, ch);
 157                                 }
 158                         }
 159                 }
 160                 pcg = g_malloc0(sizeof(struct pps_channel_group));
 161                 pcg->features = cgs->features;
 162                 cg->priv = pcg;
 163                 sdi->channel_groups = g_slist_append(sdi->channel_groups, cg);
 164         }
 165
 166         sr_scpi_hw_info_free(hw_info);
 167         hw_info = NULL;
 168
 169         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_LOCAL);
 170
 171         return sdi;
 172 }
 173
 174 static GSList *scan(struct sr_dev_driver *di, GSList *options)
 175 {
 176         return sr_scpi_scan(di->context, options, probe_device);
 177 }
 178
 179 static GSList *dev_list(const struct sr_dev_driver *di)
 180 {
 181         return ((struct drv_context *)(di->context))->instances;
 182 }
 183
 184 static int dev_open(struct sr_dev_inst *sdi)
 185 {
 186         struct dev_context *devc;
 187         struct sr_scpi_dev_inst *scpi;
 188         GVariant *beeper;
 189
 190         if (sdi->status != SR_ST_INACTIVE)
 191                 return SR_ERR;
 192
 193         scpi = sdi->conn;
 194         if (sr_scpi_open(scpi) < 0)
 195                 return SR_ERR;
 196
 197         sdi->status = SR_ST_ACTIVE;
 198
 199         devc = sdi->priv;
 200         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_REMOTE);
 201         devc->beeper_was_set = FALSE;
 202         if (scpi_cmd_resp(sdi, devc->device->commands, &beeper,
 203                         G_VARIANT_TYPE_BOOLEAN, SCPI_CMD_BEEPER) == SR_OK) {
 204                 if (g_variant_get_boolean(beeper)) {
 205                         devc->beeper_was_set = TRUE;
 206                         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_BEEPER_DISABLE);
 207                 }
 208                 g_variant_unref(beeper);
 209         }
 210
 211         return SR_OK;
 212 }
 213
 214 static int dev_close(struct sr_dev_inst *sdi)
 215 {
 216         struct sr_scpi_dev_inst *scpi;
 217         struct dev_context *devc;
 218
 219         if (sdi->status != SR_ST_ACTIVE)
 220                 return SR_ERR_DEV_CLOSED;
 221
 222         devc = sdi->priv;
 223         scpi = sdi->conn;
 224         if (scpi) {
 225                 if (devc->beeper_was_set)
 226                         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_BEEPER_ENABLE);
 227                 scpi_cmd(sdi, devc->device->commands, SCPI_CMD_LOCAL);
 228                 sr_scpi_close(scpi);
 229                 sdi->status = SR_ST_INACTIVE;
 230         }
 231
 232         return SR_OK;
 233 }
 234
 235 static void clear_helper(void *priv)
 236 {
 237         struct dev_context *devc;
 238
 239         devc = priv;
 240         g_free(devc->channels);
 241         g_free(devc->channel_groups);
 242         g_free(devc);
 243 }
 244
 245 static int dev_clear(const struct sr_dev_driver *di)
 246 {
 247         return std_dev_clear(di, clear_helper);
 248 }
 249
 250 static int config_get(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
 251                 const struct sr_channel_group *cg)
 252 {
 253         struct dev_context *devc;
 254         const GVariantType *gvtype;
 255         unsigned int i;
 256         int cmd, ret;
 257         const char *s;
 258
 259         if (!sdi)
 260                 return SR_ERR_ARG;
 261
 262         devc = sdi->priv;
 263
 264         if (cg) {
 265                 /*
 266                  * These options only apply to channel groups with a single
 267                  * channel -- they're per-channel settings for the device.
 268                  */
 269
 270                 /*
 271                  * Config keys are handled below depending on whether a channel
 272                  * group was provided by the frontend. However some of these
 273                  * take a CG on one PPS but not on others. Check the device's
 274                  * profile for that here, and NULL out the channel group as needed.
 275                  */
 276                 for (i = 0; i < devc->device->num_devopts; i++) {
 277                         if (devc->device->devopts[i] == key) {
 278                                 cg = NULL;
 279                                 break;
 280                         }
 281                 }
 282         }
 283
 284         gvtype = NULL;
 285         cmd = -1;
 286         switch (key) {
 287         case SR_CONF_ENABLED:
 288                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 289                 cmd = SCPI_CMD_GET_OUTPUT_ENABLED;
 290                 break;
 291         case SR_CONF_VOLTAGE:
 292                 gvtype = G_VARIANT_TYPE_DOUBLE;
 293                 cmd = SCPI_CMD_GET_MEAS_VOLTAGE;
 294                 break;
 295         case SR_CONF_VOLTAGE_TARGET:
 296                 gvtype = G_VARIANT_TYPE_DOUBLE;
 297                 cmd = SCPI_CMD_GET_VOLTAGE_TARGET;
 298                 break;
 299         case SR_CONF_OUTPUT_FREQUENCY:
 300                 gvtype = G_VARIANT_TYPE_DOUBLE;
 301                 cmd = SCPI_CMD_GET_MEAS_FREQUENCY;
 302                 break;
 303         case SR_CONF_OUTPUT_FREQUENCY_TARGET:
 304                 gvtype = G_VARIANT_TYPE_DOUBLE;
 305                 cmd = SCPI_CMD_GET_FREQUENCY_TARGET;
 306                 break;
 307         case SR_CONF_CURRENT:
 308                 gvtype = G_VARIANT_TYPE_DOUBLE;
 309                 cmd = SCPI_CMD_GET_MEAS_CURRENT;
 310                 break;
 311         case SR_CONF_CURRENT_LIMIT:
 312                 gvtype = G_VARIANT_TYPE_DOUBLE;
 313                 cmd = SCPI_CMD_GET_CURRENT_LIMIT;
 314                 break;
 315         case SR_CONF_OVER_VOLTAGE_PROTECTION_ENABLED:
 316                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 317                 cmd = SCPI_CMD_GET_OVER_VOLTAGE_PROTECTION_ENABLED;
 318                 break;
 319         case SR_CONF_OVER_VOLTAGE_PROTECTION_ACTIVE:
 320                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 321                 cmd = SCPI_CMD_GET_OVER_VOLTAGE_PROTECTION_ACTIVE;
 322                 break;
 323         case SR_CONF_OVER_VOLTAGE_PROTECTION_THRESHOLD:
 324                 gvtype = G_VARIANT_TYPE_DOUBLE;
 325                 cmd = SCPI_CMD_GET_OVER_VOLTAGE_PROTECTION_THRESHOLD;
 326                 break;
 327         case SR_CONF_OVER_CURRENT_PROTECTION_ENABLED:
 328                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 329                 cmd = SCPI_CMD_GET_OVER_CURRENT_PROTECTION_ENABLED;
 330                 break;
 331         case SR_CONF_OVER_CURRENT_PROTECTION_ACTIVE:
 332                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 333                 cmd = SCPI_CMD_GET_OVER_CURRENT_PROTECTION_ACTIVE;
 334                 break;
 335         case SR_CONF_OVER_CURRENT_PROTECTION_THRESHOLD:
 336                 gvtype = G_VARIANT_TYPE_DOUBLE;
 337                 cmd = SCPI_CMD_GET_OVER_CURRENT_PROTECTION_THRESHOLD;
 338                 break;
 339         case SR_CONF_OVER_TEMPERATURE_PROTECTION:
 340                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 341                 cmd = SCPI_CMD_GET_OVER_TEMPERATURE_PROTECTION;
 342                 break;
 343         case SR_CONF_REGULATION:
 344                 gvtype = G_VARIANT_TYPE_STRING;
 345                 cmd = SCPI_CMD_GET_OUTPUT_REGULATION;
 346         }
 347         if (!gvtype)
 348                 return SR_ERR_NA;
 349
 350         if (cg)
 351                 select_channel(sdi, cg->channels->data);
 352         ret = scpi_cmd_resp(sdi, devc->device->commands, data, gvtype, cmd);
 353
 354         if (cmd == SCPI_CMD_GET_OUTPUT_REGULATION) {
 355                 /*
 356                  * The Rigol DP800 series return CV/CC/UR, Philips PM2800
 357                  * return VOLT/CURR. We always return a GVariant string in
 358                  * the Rigol notation.
 359                  */
 360                 s = g_variant_get_string(*data, NULL);
 361                 if (!strcmp(s, "VOLT")) {
 362                         g_variant_unref(*data);
 363                         *data = g_variant_new_string("CV");
 364                 } else if (!strcmp(s, "CURR")) {
 365                         g_variant_unref(*data);
 366                         *data = g_variant_new_string("CC");
 367                 }
 368
 369                 s = g_variant_get_string(*data, NULL);
 370                 if (strcmp(s, "CV") && strcmp(s, "CC") && strcmp(s, "UR")) {
 371                         sr_dbg("Unknown response to SCPI_CMD_GET_OUTPUT_REGULATION: %s", s);
 372                         ret = SR_ERR_DATA;
 373                 }
 374         }
 375
 376         return ret;
 377 }
 378
 379 static int config_set(uint32_t key, GVariant *data, const struct sr_dev_inst *sdi,
 380                 const struct sr_channel_group *cg)
 381 {
 382         struct dev_context *devc;
 383         double d;
 384         int ret;
 385
 386         if (!sdi)
 387                 return SR_ERR_ARG;
 388
 389         if (sdi->status != SR_ST_ACTIVE)
 390                 return SR_ERR_DEV_CLOSED;
 391
 392         if (cg)
 393                 /* Channel group specified. */
 394                 select_channel(sdi, cg->channels->data);
 395
 396         devc = sdi->priv;
 397
 398         switch (key) {
 399         case SR_CONF_ENABLED:
 400                 if (g_variant_get_boolean(data))
 401                         ret = scpi_cmd(sdi, devc->device->commands,
 402                                         SCPI_CMD_SET_OUTPUT_ENABLE);
 403                 else
 404                         ret = scpi_cmd(sdi, devc->device->commands,
 405                                         SCPI_CMD_SET_OUTPUT_DISABLE);
 406                 break;
 407         case SR_CONF_VOLTAGE_TARGET:
 408                 d = g_variant_get_double(data);
 409                 ret = scpi_cmd(sdi, devc->device->commands,
 410                                 SCPI_CMD_SET_VOLTAGE_TARGET, d);
 411                 break;
 412         case SR_CONF_OUTPUT_FREQUENCY_TARGET:
 413                 d = g_variant_get_double(data);
 414                 ret = scpi_cmd(sdi, devc->device->commands,
 415                                 SCPI_CMD_SET_FREQUENCY_TARGET, d);
 416                 break;
 417         case SR_CONF_CURRENT_LIMIT:
 418                 d = g_variant_get_double(data);
 419                 ret = scpi_cmd(sdi, devc->device->commands,
 420                                 SCPI_CMD_SET_CURRENT_LIMIT, d);
 421                 break;
 422         case SR_CONF_OVER_VOLTAGE_PROTECTION_ENABLED:
 423                 if (g_variant_get_boolean(data))
 424                         ret = scpi_cmd(sdi, devc->device->commands,
 425                                         SCPI_CMD_SET_OVER_VOLTAGE_PROTECTION_ENABLE);
 426                 else
 427                         ret = scpi_cmd(sdi, devc->device->commands,
 428                                         SCPI_CMD_SET_OVER_VOLTAGE_PROTECTION_DISABLE);
 429                 break;
 430         case SR_CONF_OVER_VOLTAGE_PROTECTION_THRESHOLD:
 431                 d = g_variant_get_double(data);
 432                 ret = scpi_cmd(sdi, devc->device->commands,
 433                                 SCPI_CMD_SET_OVER_VOLTAGE_PROTECTION_THRESHOLD, d);
 434                 break;
 435         case SR_CONF_OVER_CURRENT_PROTECTION_ENABLED:
 436                 if (g_variant_get_boolean(data))
 437                         ret = scpi_cmd(sdi, devc->device->commands,
 438                                         SCPI_CMD_SET_OVER_CURRENT_PROTECTION_ENABLE);
 439                 else
 440                         ret = scpi_cmd(sdi, devc->device->commands,
 441                                         SCPI_CMD_SET_OVER_CURRENT_PROTECTION_DISABLE);
 442                 break;
 443         case SR_CONF_OVER_CURRENT_PROTECTION_THRESHOLD:
 444                 d = g_variant_get_double(data);
 445                 ret = scpi_cmd(sdi, devc->device->commands,
 446                                 SCPI_CMD_SET_OVER_CURRENT_PROTECTION_THRESHOLD, d);
 447                 break;
 448         case SR_CONF_OVER_TEMPERATURE_PROTECTION:
 449                 if (g_variant_get_boolean(data))
 450                         ret = scpi_cmd(sdi, devc->device->commands,
 451                                         SCPI_CMD_SET_OVER_TEMPERATURE_PROTECTION_ENABLE);
 452                 else
 453                         ret = scpi_cmd(sdi, devc->device->commands,
 454                                         SCPI_CMD_SET_OVER_TEMPERATURE_PROTECTION_DISABLE);
 455                 break;
 456         default:
 457                 ret = SR_ERR_NA;
 458         }
 459
 460         return ret;
 461 }
 462
 463 static int config_list(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
 464                 const struct sr_channel_group *cg)
 465 {
 466         struct dev_context *devc;
 467         struct sr_channel *ch;
 468         const struct channel_spec *ch_spec;
 469         GVariant *gvar;
 470         GVariantBuilder gvb;
 471         int ret, i;
 472         const char *s[16];
 473
 474         /* Always available, even without sdi. */
 475         if (key == SR_CONF_SCAN_OPTIONS) {
 476                 *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 477                                 scanopts, ARRAY_SIZE(scanopts), sizeof(uint32_t));
 478                 return SR_OK;
 479         } else if (key == SR_CONF_DEVICE_OPTIONS && !sdi) {
 480                 *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 481                                 drvopts, ARRAY_SIZE(drvopts), sizeof(uint32_t));
 482                 return SR_OK;
 483         }
 484
 485         if (!sdi)
 486                 return SR_ERR_ARG;
 487         devc = sdi->priv;
 488
 489         ret = SR_OK;
 490         if (!cg) {
 491                 /* No channel group: global options. */
 492                 switch (key) {
 493                 case SR_CONF_DEVICE_OPTIONS:
 494                         *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 495                                         devc->device->devopts, devc->device->num_devopts,
 496                                         sizeof(uint32_t));
 497                         break;
 498                 case SR_CONF_CHANNEL_CONFIG:
 499                         /* Not used. */
 500                         i = 0;
 501                         if (devc->device->features & PPS_INDEPENDENT)
 502                                 s[i++] = "Independent";
 503                         if (devc->device->features & PPS_SERIES)
 504                                 s[i++] = "Series";
 505                         if (devc->device->features & PPS_PARALLEL)
 506                                 s[i++] = "Parallel";
 507                         if (i == 0) {
 508                                 /*
 509                                  * Shouldn't happen: independent-only devices
 510                                  * shouldn't advertise this option at all.
 511                                  */
 512                                 return SR_ERR_NA;
 513                         }
 514                         *data = g_variant_new_strv(s, i);
 515                         break;
 516                 default:
 517                         return SR_ERR_NA;
 518                 }
 519         } else {
 520                 /* Channel group specified. */
 521                 /*
 522                  * Per-channel-group options depending on a channel are actually
 523                  * done with the first channel. Channel groups in PPS can have
 524                  * more than one channel, but they will typically be of equal
 525                  * specification for use in series or parallel mode.
 526                  */
 527                 ch = cg->channels->data;
 528
 529                 switch (key) {
 530                 case SR_CONF_DEVICE_OPTIONS:
 531                         *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 532                                         devc->device->devopts_cg, devc->device->num_devopts_cg,
 533                                         sizeof(uint32_t));
 534                         break;
 535                 case SR_CONF_VOLTAGE_TARGET:
 536                         ch_spec = &(devc->device->channels[ch->index]);
 537                         g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 538                         /* Min, max, write resolution. */
 539                         for (i = 0; i < 3; i++) {
 540                                 gvar = g_variant_new_double(ch_spec->voltage[i]);
 541                                 g_variant_builder_add_value(&gvb, gvar);
 542                         }
 543                         *data = g_variant_builder_end(&gvb);
 544                         break;
 545                 case SR_CONF_OUTPUT_FREQUENCY_TARGET:
 546                         ch_spec = &(devc->device->channels[ch->index]);
 547                         g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 548                         /* Min, max, write resolution. */
 549                         for (i = 0; i < 3; i++) {
 550                                 gvar = g_variant_new_double(ch_spec->frequency[i]);
 551                                 g_variant_builder_add_value(&gvb, gvar);
 552                         }
 553                         *data = g_variant_builder_end(&gvb);
 554                         break;
 555                 case SR_CONF_CURRENT_LIMIT:
 556                         g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 557                         /* Min, max, step. */
 558                         for (i = 0; i < 3; i++) {
 559                                 ch_spec = &(devc->device->channels[ch->index]);
 560                                 gvar = g_variant_new_double(ch_spec->current[i]);
 561                                 g_variant_builder_add_value(&gvb, gvar);
 562                         }
 563                         *data = g_variant_builder_end(&gvb);
 564                         break;
 565                 default:
 566                         return SR_ERR_NA;
 567                 }
 568         }
 569
 570         return ret;
 571 }
 572
 573 static int dev_acquisition_start(const struct sr_dev_inst *sdi)
 574 {
 575         struct dev_context *devc;
 576         struct sr_scpi_dev_inst *scpi;
 577         struct sr_channel *ch;
 578         struct pps_channel *pch;
 579         int cmd, ret;
 580
 581         if (sdi->status != SR_ST_ACTIVE)
 582                 return SR_ERR_DEV_CLOSED;
 583
 584         devc = sdi->priv;
 585         scpi = sdi->conn;
 586
 587         if ((ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 10,
 588                         scpi_pps_receive_data, (void *)sdi)) != SR_OK)
 589                 return ret;
 590         std_session_send_df_header(sdi, LOG_PREFIX);
 591
 592         /* Prime the pipe with the first channel's fetch. */
 593         ch = sr_next_enabled_channel(sdi, NULL);
 594         pch = ch->priv;
 595         if ((ret = select_channel(sdi, ch)) < 0)
 596                 return ret;
 597         if (pch->mq == SR_MQ_VOLTAGE)
 598                 cmd = SCPI_CMD_GET_MEAS_VOLTAGE;
 599         else if (pch->mq == SR_MQ_FREQUENCY)
 600                 cmd = SCPI_CMD_GET_MEAS_FREQUENCY;
 601         else if (pch->mq == SR_MQ_CURRENT)
 602                 cmd = SCPI_CMD_GET_MEAS_CURRENT;
 603         else if (pch->mq == SR_MQ_POWER)
 604                 cmd = SCPI_CMD_GET_MEAS_POWER;
 605         else
 606                 return SR_ERR;
 607         scpi_cmd(sdi, devc->device->commands, cmd, pch->hwname);
 608
 609         return SR_OK;
 610 }
 611
 612 static int dev_acquisition_stop(struct sr_dev_inst *sdi)
 613 {
 614         struct sr_scpi_dev_inst *scpi;
 615         float f;
 616
 617         if (sdi->status != SR_ST_ACTIVE)
 618                 return SR_ERR_DEV_CLOSED;
 619
 620         scpi = sdi->conn;
 621
 622         /*
 623          * A requested value is certainly on the way. Retrieve it now,
 624          * to avoid leaving the device in a state where it's not expecting
 625          * commands.
 626          */
 627         sr_scpi_get_float(scpi, NULL, &f);
 628         sr_scpi_source_remove(sdi->session, scpi);
 629
 630         std_session_send_df_end(sdi, LOG_PREFIX);
 631
 632         return SR_OK;
 633 }
 634
 635 SR_PRIV struct sr_dev_driver scpi_pps_driver_info = {
 636         .name = "scpi-pps",
 637         .longname = "SCPI PPS",
 638         .api_version = 1,
 639         .init = init,
 640         .cleanup = std_cleanup,
 641         .scan = scan,
 642         .dev_list = dev_list,
 643         .dev_clear = dev_clear,
 644         .config_get = config_get,
 645         .config_set = config_set,
 646         .config_list = config_list,
 647         .dev_open = dev_open,
 648         .dev_close = dev_close,
 649         .dev_acquisition_start = dev_acquisition_start,
 650         .dev_acquisition_stop = dev_acquisition_stop,
 651         .context = NULL,
 652 };