src/hardware/scpi-pps/api.c

   1 /*
   2  * This file is part of the libsigrok project.
   3  *
   4  * Copyright (C) 2014 Bert Vermeulen <bert@biot.com>
   5  *
   6  * This program is free software: you can redistribute it and/or modify
   7  * it under the terms of the GNU General Public License as published by
   8  * the Free Software Foundation, either version 3 of the License, or
   9  * (at your option) any later version.
  10  *
  11  * This program is distributed in the hope that it will be useful,
  12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  14  * GNU General Public License for more details.
  15  *
  16  * You should have received a copy of the GNU General Public License
  17  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  18  */
  19
  20 #include <config.h>
  21 #include <string.h>
  22 #include <strings.h>
  23 #include "scpi.h"
  24 #include "protocol.h"
  25
  26 static struct sr_dev_driver scpi_pps_driver_info;
  27 static struct sr_dev_driver hp_ib_pps_driver_info;
  28
  29 static const uint32_t scanopts[] = {
  30         SR_CONF_CONN,
  31         SR_CONF_SERIALCOMM,
  32 };
  33
  34 static const uint32_t drvopts[] = {
  35         SR_CONF_POWER_SUPPLY,
  36 };
  37
  38 static const struct pps_channel_instance pci[] = {
  39         { SR_MQ_VOLTAGE, SCPI_CMD_GET_MEAS_VOLTAGE, "V" },
  40         { SR_MQ_CURRENT, SCPI_CMD_GET_MEAS_CURRENT, "I" },
  41         { SR_MQ_POWER, SCPI_CMD_GET_MEAS_POWER, "P" },
  42         { SR_MQ_FREQUENCY, SCPI_CMD_GET_MEAS_FREQUENCY, "F" },
  43 };
  44
  45 static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi,
  46                 int (*get_hw_id)(struct sr_scpi_dev_inst *scpi,
  47                 struct sr_scpi_hw_info **scpi_response))
  48 {
  49         struct dev_context *devc;
  50         struct sr_dev_inst *sdi;
  51         struct sr_scpi_hw_info *hw_info;
  52         struct sr_channel_group *cg;
  53         struct sr_channel *ch;
  54         const struct scpi_pps *device;
  55         struct pps_channel *pch;
  56         struct channel_spec *channels;
  57         struct channel_group_spec *channel_groups, *cgs;
  58         struct pps_channel_group *pcg;
  59         GRegex *model_re;
  60         GMatchInfo *model_mi;
  61         GSList *l;
  62         uint64_t mask;
  63         unsigned int num_channels, num_channel_groups, ch_num, ch_idx, i, j;
  64         int ret;
  65         const char *vendor;
  66         char ch_name[16];
  67
  68         if (get_hw_id(scpi, &hw_info) != SR_OK) {
  69                 sr_info("Couldn't get IDN response.");
  70                 return NULL;
  71         }
  72
  73         device = NULL;
  74         for (i = 0; i < num_pps_profiles; i++) {
  75                 vendor = sr_vendor_alias(hw_info->manufacturer);
  76                 if (g_ascii_strcasecmp(vendor, pps_profiles[i].vendor))
  77                         continue;
  78                 model_re = g_regex_new(pps_profiles[i].model, 0, 0, NULL);
  79                 if (g_regex_match(model_re, hw_info->model, 0, &model_mi))
  80                         device = &pps_profiles[i];
  81                 g_match_info_unref(model_mi);
  82                 g_regex_unref(model_re);
  83                 if (device)
  84                         break;
  85         }
  86         if (!device) {
  87                 sr_scpi_hw_info_free(hw_info);
  88                 return NULL;
  89         }
  90
  91         sdi = g_malloc0(sizeof(struct sr_dev_inst));
  92         sdi->vendor = g_strdup(vendor);
  93         sdi->model = g_strdup(hw_info->model);
  94         sdi->version = g_strdup(hw_info->firmware_version);
  95         sdi->conn = scpi;
  96         sdi->driver = &scpi_pps_driver_info;
  97         sdi->inst_type = SR_INST_SCPI;
  98         sdi->serial_num = g_strdup(hw_info->serial_number);
  99
 100         devc = g_malloc0(sizeof(struct dev_context));
 101         devc->device = device;
 102         sdi->priv = devc;
 103
 104         if (device->num_channels) {
 105                 /* Static channels and groups. */
 106                 channels = (struct channel_spec *)device->channels;
 107                 num_channels = device->num_channels;
 108                 channel_groups = (struct channel_group_spec *)device->channel_groups;
 109                 num_channel_groups = device->num_channel_groups;
 110         } else {
 111                 /* Channels and groups need to be probed. */
 112                 ret = device->probe_channels(sdi, hw_info, &channels, &num_channels,
 113                                 &channel_groups, &num_channel_groups);
 114                 if (ret != SR_OK) {
 115                         sr_err("Failed to probe for channels.");
 116                         return NULL;
 117                 }
 118                 /*
 119                  * Since these were dynamically allocated, we'll need to free them
 120                  * later.
 121                  */
 122                 devc->channels = channels;
 123                 devc->channel_groups = channel_groups;
 124         }
 125
 126         ch_idx = 0;
 127         for (ch_num = 0; ch_num < num_channels; ch_num++) {
 128                 /* Create one channel per measurable output unit. */
 129                 for (i = 0; i < ARRAY_SIZE(pci); i++) {
 130                         if (!scpi_cmd_get(devc->device->commands, pci[i].command))
 131                                 continue;
 132                         g_snprintf(ch_name, 16, "%s%s", pci[i].prefix,
 133                                         channels[ch_num].name);
 134                         ch = sr_channel_new(sdi, ch_idx++, SR_CHANNEL_ANALOG, TRUE,
 135                                         ch_name);
 136                         pch = g_malloc0(sizeof(struct pps_channel));
 137                         pch->hw_output_idx = ch_num;
 138                         pch->hwname = channels[ch_num].name;
 139                         pch->mq = pci[i].mq;
 140                         ch->priv = pch;
 141                 }
 142         }
 143
 144         for (i = 0; i < num_channel_groups; i++) {
 145                 cgs = &channel_groups[i];
 146                 cg = g_malloc0(sizeof(struct sr_channel_group));
 147                 cg->name = g_strdup(cgs->name);
 148                 for (j = 0, mask = 1; j < 64; j++, mask <<= 1) {
 149                         if (cgs->channel_index_mask & mask) {
 150                                 for (l = sdi->channels; l; l = l->next) {
 151                                         ch = l->data;
 152                                         pch = ch->priv;
 153                                         if (pch->hw_output_idx == j)
 154                                                 cg->channels = g_slist_append(cg->channels, ch);
 155                                 }
 156                         }
 157                 }
 158                 pcg = g_malloc0(sizeof(struct pps_channel_group));
 159                 pcg->features = cgs->features;
 160                 cg->priv = pcg;
 161                 sdi->channel_groups = g_slist_append(sdi->channel_groups, cg);
 162         }
 163
 164         sr_scpi_hw_info_free(hw_info);
 165         hw_info = NULL;
 166
 167         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_LOCAL);
 168
 169         return sdi;
 170 }
 171
 172 static gchar *hpib_get_revision(struct sr_scpi_dev_inst *scpi)
 173 {
 174         int ret;
 175         gboolean matches;
 176         char *response;
 177         GRegex *version_regex;
 178
 179         ret = sr_scpi_get_string(scpi, "ROM?", &response);
 180         if (ret != SR_OK && !response)
 181                 return NULL;
 182
 183         /* Example version string: "B01 B01" */
 184         version_regex = g_regex_new("[A-Z][0-9]{2} [A-Z][0-9]{2}", 0, 0, NULL);
 185         matches = g_regex_match(version_regex, response, 0, NULL);
 186         g_regex_unref(version_regex);
 187
 188         if (!matches) {
 189                 /* Not a valid version string. Ignore it. */
 190                 g_free(response);
 191                 response = NULL;
 192         } else {
 193                 /* Replace space with dot. */
 194                 response[3] = '.';
 195         }
 196
 197         return response;
 198 }
 199
 200 /*
 201  * This function assumes the response is in the form "HP<model_number>"
 202  *
 203  * HP made many GPIB (then called HP-IB) instruments before the SCPI command
 204  * set was introduced into the standard. We haven't seen any non-HP instruments
 205  * which respond to the "ID?" query, so assume all are HP for now.
 206  */
 207 static int hpib_get_hw_id(struct sr_scpi_dev_inst *scpi,
 208                           struct sr_scpi_hw_info **scpi_response)
 209 {
 210         int ret;
 211         char *response;
 212         struct sr_scpi_hw_info *hw_info;
 213
 214         ret = sr_scpi_get_string(scpi, "ID?", &response);
 215         if ((ret != SR_OK) || !response)
 216                 return SR_ERR;
 217
 218         hw_info = g_malloc0(sizeof(struct sr_scpi_hw_info));
 219
 220         *scpi_response = hw_info;
 221         hw_info->model = response;
 222         hw_info->firmware_version = hpib_get_revision(scpi);
 223         hw_info->manufacturer = g_strdup("HP");
 224
 225         return SR_OK;
 226 }
 227
 228 static struct sr_dev_inst *probe_scpi_pps_device(struct sr_scpi_dev_inst *scpi)
 229 {
 230         return probe_device(scpi, sr_scpi_get_hw_id);
 231 }
 232
 233 static struct sr_dev_inst *probe_hpib_pps_device(struct sr_scpi_dev_inst *scpi)
 234 {
 235         return probe_device(scpi, hpib_get_hw_id);
 236 }
 237
 238 static GSList *scan_scpi_pps(struct sr_dev_driver *di, GSList *options)
 239 {
 240         return sr_scpi_scan(di->context, options, probe_scpi_pps_device);
 241 }
 242
 243 static GSList *scan_hpib_pps(struct sr_dev_driver *di, GSList *options)
 244 {
 245         return sr_scpi_scan(di->context, options, probe_hpib_pps_device);
 246 }
 247
 248 static int dev_open(struct sr_dev_inst *sdi)
 249 {
 250         struct dev_context *devc;
 251         struct sr_scpi_dev_inst *scpi;
 252         GVariant *beeper;
 253
 254         scpi = sdi->conn;
 255         if (sr_scpi_open(scpi) < 0)
 256                 return SR_ERR;
 257
 258         devc = sdi->priv;
 259         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_REMOTE);
 260         devc->beeper_was_set = FALSE;
 261         if (scpi_cmd_resp(sdi, devc->device->commands, &beeper,
 262                         G_VARIANT_TYPE_BOOLEAN, SCPI_CMD_BEEPER) == SR_OK) {
 263                 if (g_variant_get_boolean(beeper)) {
 264                         devc->beeper_was_set = TRUE;
 265                         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_BEEPER_DISABLE);
 266                 }
 267                 g_variant_unref(beeper);
 268         }
 269
 270         return SR_OK;
 271 }
 272
 273 static int dev_close(struct sr_dev_inst *sdi)
 274 {
 275         struct sr_scpi_dev_inst *scpi;
 276         struct dev_context *devc;
 277
 278         devc = sdi->priv;
 279         scpi = sdi->conn;
 280
 281         if (!scpi)
 282                 return SR_ERR_BUG;
 283
 284         if (devc->beeper_was_set)
 285                 scpi_cmd(sdi, devc->device->commands, SCPI_CMD_BEEPER_ENABLE);
 286         scpi_cmd(sdi, devc->device->commands, SCPI_CMD_LOCAL);
 287
 288         return sr_scpi_close(scpi);
 289 }
 290
 291 static void clear_helper(void *priv)
 292 {
 293         struct dev_context *devc;
 294
 295         devc = priv;
 296         g_free(devc->channels);
 297         g_free(devc->channel_groups);
 298         g_free(devc);
 299 }
 300
 301 static int dev_clear(const struct sr_dev_driver *di)
 302 {
 303         return std_dev_clear(di, clear_helper);
 304 }
 305
 306 static int config_get(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
 307                 const struct sr_channel_group *cg)
 308 {
 309         struct dev_context *devc;
 310         const GVariantType *gvtype;
 311         unsigned int i;
 312         int cmd, ret;
 313         const char *s;
 314
 315         if (!sdi)
 316                 return SR_ERR_ARG;
 317
 318         devc = sdi->priv;
 319
 320         if (cg) {
 321                 /*
 322                  * These options only apply to channel groups with a single
 323                  * channel -- they're per-channel settings for the device.
 324                  */
 325
 326                 /*
 327                  * Config keys are handled below depending on whether a channel
 328                  * group was provided by the frontend. However some of these
 329                  * take a CG on one PPS but not on others. Check the device's
 330                  * profile for that here, and NULL out the channel group as needed.
 331                  */
 332                 for (i = 0; i < devc->device->num_devopts; i++) {
 333                         if (devc->device->devopts[i] == key) {
 334                                 cg = NULL;
 335                                 break;
 336                         }
 337                 }
 338         }
 339
 340         gvtype = NULL;
 341         cmd = -1;
 342         switch (key) {
 343         case SR_CONF_ENABLED:
 344                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 345                 cmd = SCPI_CMD_GET_OUTPUT_ENABLED;
 346                 break;
 347         case SR_CONF_VOLTAGE:
 348                 gvtype = G_VARIANT_TYPE_DOUBLE;
 349                 cmd = SCPI_CMD_GET_MEAS_VOLTAGE;
 350                 break;
 351         case SR_CONF_VOLTAGE_TARGET:
 352                 gvtype = G_VARIANT_TYPE_DOUBLE;
 353                 cmd = SCPI_CMD_GET_VOLTAGE_TARGET;
 354                 break;
 355         case SR_CONF_OUTPUT_FREQUENCY:
 356                 gvtype = G_VARIANT_TYPE_DOUBLE;
 357                 cmd = SCPI_CMD_GET_MEAS_FREQUENCY;
 358                 break;
 359         case SR_CONF_OUTPUT_FREQUENCY_TARGET:
 360                 gvtype = G_VARIANT_TYPE_DOUBLE;
 361                 cmd = SCPI_CMD_GET_FREQUENCY_TARGET;
 362                 break;
 363         case SR_CONF_CURRENT:
 364                 gvtype = G_VARIANT_TYPE_DOUBLE;
 365                 cmd = SCPI_CMD_GET_MEAS_CURRENT;
 366                 break;
 367         case SR_CONF_CURRENT_LIMIT:
 368                 gvtype = G_VARIANT_TYPE_DOUBLE;
 369                 cmd = SCPI_CMD_GET_CURRENT_LIMIT;
 370                 break;
 371         case SR_CONF_OVER_VOLTAGE_PROTECTION_ENABLED:
 372                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 373                 cmd = SCPI_CMD_GET_OVER_VOLTAGE_PROTECTION_ENABLED;
 374                 break;
 375         case SR_CONF_OVER_VOLTAGE_PROTECTION_ACTIVE:
 376                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 377                 cmd = SCPI_CMD_GET_OVER_VOLTAGE_PROTECTION_ACTIVE;
 378                 break;
 379         case SR_CONF_OVER_VOLTAGE_PROTECTION_THRESHOLD:
 380                 gvtype = G_VARIANT_TYPE_DOUBLE;
 381                 cmd = SCPI_CMD_GET_OVER_VOLTAGE_PROTECTION_THRESHOLD;
 382                 break;
 383         case SR_CONF_OVER_CURRENT_PROTECTION_ENABLED:
 384                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 385                 cmd = SCPI_CMD_GET_OVER_CURRENT_PROTECTION_ENABLED;
 386                 break;
 387         case SR_CONF_OVER_CURRENT_PROTECTION_ACTIVE:
 388                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 389                 cmd = SCPI_CMD_GET_OVER_CURRENT_PROTECTION_ACTIVE;
 390                 break;
 391         case SR_CONF_OVER_CURRENT_PROTECTION_THRESHOLD:
 392                 gvtype = G_VARIANT_TYPE_DOUBLE;
 393                 cmd = SCPI_CMD_GET_OVER_CURRENT_PROTECTION_THRESHOLD;
 394                 break;
 395         case SR_CONF_OVER_TEMPERATURE_PROTECTION:
 396                 gvtype = G_VARIANT_TYPE_BOOLEAN;
 397                 cmd = SCPI_CMD_GET_OVER_TEMPERATURE_PROTECTION;
 398                 break;
 399         case SR_CONF_REGULATION:
 400                 gvtype = G_VARIANT_TYPE_STRING;
 401                 cmd = SCPI_CMD_GET_OUTPUT_REGULATION;
 402         }
 403         if (!gvtype)
 404                 return SR_ERR_NA;
 405
 406         if (cg)
 407                 select_channel(sdi, cg->channels->data);
 408         ret = scpi_cmd_resp(sdi, devc->device->commands, data, gvtype, cmd);
 409
 410         if (cmd == SCPI_CMD_GET_OUTPUT_REGULATION) {
 411                 /*
 412                  * The Rigol DP800 series return CV/CC/UR, Philips PM2800
 413                  * return VOLT/CURR. We always return a GVariant string in
 414                  * the Rigol notation.
 415                  */
 416                 s = g_variant_get_string(*data, NULL);
 417                 if (!strcmp(s, "VOLT")) {
 418                         g_variant_unref(*data);
 419                         *data = g_variant_new_string("CV");
 420                 } else if (!strcmp(s, "CURR")) {
 421                         g_variant_unref(*data);
 422                         *data = g_variant_new_string("CC");
 423                 }
 424
 425                 s = g_variant_get_string(*data, NULL);
 426                 if (strcmp(s, "CV") && strcmp(s, "CC") && strcmp(s, "UR")) {
 427                         sr_dbg("Unknown response to SCPI_CMD_GET_OUTPUT_REGULATION: %s", s);
 428                         ret = SR_ERR_DATA;
 429                 }
 430         }
 431
 432         return ret;
 433 }
 434
 435 static int config_set(uint32_t key, GVariant *data, const struct sr_dev_inst *sdi,
 436                 const struct sr_channel_group *cg)
 437 {
 438         struct dev_context *devc;
 439         double d;
 440         int ret;
 441
 442         if (!sdi)
 443                 return SR_ERR_ARG;
 444
 445         if (cg)
 446                 /* Channel group specified. */
 447                 select_channel(sdi, cg->channels->data);
 448
 449         devc = sdi->priv;
 450
 451         switch (key) {
 452         case SR_CONF_ENABLED:
 453                 if (g_variant_get_boolean(data))
 454                         ret = scpi_cmd(sdi, devc->device->commands,
 455                                         SCPI_CMD_SET_OUTPUT_ENABLE);
 456                 else
 457                         ret = scpi_cmd(sdi, devc->device->commands,
 458                                         SCPI_CMD_SET_OUTPUT_DISABLE);
 459                 break;
 460         case SR_CONF_VOLTAGE_TARGET:
 461                 d = g_variant_get_double(data);
 462                 ret = scpi_cmd(sdi, devc->device->commands,
 463                                 SCPI_CMD_SET_VOLTAGE_TARGET, d);
 464                 break;
 465         case SR_CONF_OUTPUT_FREQUENCY_TARGET:
 466                 d = g_variant_get_double(data);
 467                 ret = scpi_cmd(sdi, devc->device->commands,
 468                                 SCPI_CMD_SET_FREQUENCY_TARGET, d);
 469                 break;
 470         case SR_CONF_CURRENT_LIMIT:
 471                 d = g_variant_get_double(data);
 472                 ret = scpi_cmd(sdi, devc->device->commands,
 473                                 SCPI_CMD_SET_CURRENT_LIMIT, d);
 474                 break;
 475         case SR_CONF_OVER_VOLTAGE_PROTECTION_ENABLED:
 476                 if (g_variant_get_boolean(data))
 477                         ret = scpi_cmd(sdi, devc->device->commands,
 478                                         SCPI_CMD_SET_OVER_VOLTAGE_PROTECTION_ENABLE);
 479                 else
 480                         ret = scpi_cmd(sdi, devc->device->commands,
 481                                         SCPI_CMD_SET_OVER_VOLTAGE_PROTECTION_DISABLE);
 482                 break;
 483         case SR_CONF_OVER_VOLTAGE_PROTECTION_THRESHOLD:
 484                 d = g_variant_get_double(data);
 485                 ret = scpi_cmd(sdi, devc->device->commands,
 486                                 SCPI_CMD_SET_OVER_VOLTAGE_PROTECTION_THRESHOLD, d);
 487                 break;
 488         case SR_CONF_OVER_CURRENT_PROTECTION_ENABLED:
 489                 if (g_variant_get_boolean(data))
 490                         ret = scpi_cmd(sdi, devc->device->commands,
 491                                         SCPI_CMD_SET_OVER_CURRENT_PROTECTION_ENABLE);
 492                 else
 493                         ret = scpi_cmd(sdi, devc->device->commands,
 494                                         SCPI_CMD_SET_OVER_CURRENT_PROTECTION_DISABLE);
 495                 break;
 496         case SR_CONF_OVER_CURRENT_PROTECTION_THRESHOLD:
 497                 d = g_variant_get_double(data);
 498                 ret = scpi_cmd(sdi, devc->device->commands,
 499                                 SCPI_CMD_SET_OVER_CURRENT_PROTECTION_THRESHOLD, d);
 500                 break;
 501         case SR_CONF_OVER_TEMPERATURE_PROTECTION:
 502                 if (g_variant_get_boolean(data))
 503                         ret = scpi_cmd(sdi, devc->device->commands,
 504                                         SCPI_CMD_SET_OVER_TEMPERATURE_PROTECTION_ENABLE);
 505                 else
 506                         ret = scpi_cmd(sdi, devc->device->commands,
 507                                         SCPI_CMD_SET_OVER_TEMPERATURE_PROTECTION_DISABLE);
 508                 break;
 509         default:
 510                 ret = SR_ERR_NA;
 511         }
 512
 513         return ret;
 514 }
 515
 516 static int config_list(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
 517                 const struct sr_channel_group *cg)
 518 {
 519         struct dev_context *devc;
 520         struct sr_channel *ch;
 521         const struct channel_spec *ch_spec;
 522         GVariant *gvar;
 523         GVariantBuilder gvb;
 524         int ret, i;
 525         const char *s[16];
 526
 527         /* Always available, even without sdi. */
 528         if (key == SR_CONF_SCAN_OPTIONS) {
 529                 *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 530                                 scanopts, ARRAY_SIZE(scanopts), sizeof(uint32_t));
 531                 return SR_OK;
 532         } else if (key == SR_CONF_DEVICE_OPTIONS && !sdi) {
 533                 *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 534                                 drvopts, ARRAY_SIZE(drvopts), sizeof(uint32_t));
 535                 return SR_OK;
 536         }
 537
 538         if (!sdi)
 539                 return SR_ERR_ARG;
 540         devc = sdi->priv;
 541
 542         ret = SR_OK;
 543         if (!cg) {
 544                 /* No channel group: global options. */
 545                 switch (key) {
 546                 case SR_CONF_DEVICE_OPTIONS:
 547                         *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 548                                         devc->device->devopts, devc->device->num_devopts,
 549                                         sizeof(uint32_t));
 550                         break;
 551                 case SR_CONF_CHANNEL_CONFIG:
 552                         /* Not used. */
 553                         i = 0;
 554                         if (devc->device->features & PPS_INDEPENDENT)
 555                                 s[i++] = "Independent";
 556                         if (devc->device->features & PPS_SERIES)
 557                                 s[i++] = "Series";
 558                         if (devc->device->features & PPS_PARALLEL)
 559                                 s[i++] = "Parallel";
 560                         if (i == 0) {
 561                                 /*
 562                                  * Shouldn't happen: independent-only devices
 563                                  * shouldn't advertise this option at all.
 564                                  */
 565                                 return SR_ERR_NA;
 566                         }
 567                         *data = g_variant_new_strv(s, i);
 568                         break;
 569                 default:
 570                         return SR_ERR_NA;
 571                 }
 572         } else {
 573                 /* Channel group specified. */
 574                 /*
 575                  * Per-channel-group options depending on a channel are actually
 576                  * done with the first channel. Channel groups in PPS can have
 577                  * more than one channel, but they will typically be of equal
 578                  * specification for use in series or parallel mode.
 579                  */
 580                 ch = cg->channels->data;
 581
 582                 switch (key) {
 583                 case SR_CONF_DEVICE_OPTIONS:
 584                         *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
 585                                         devc->device->devopts_cg, devc->device->num_devopts_cg,
 586                                         sizeof(uint32_t));
 587                         break;
 588                 case SR_CONF_VOLTAGE_TARGET:
 589                         ch_spec = &(devc->device->channels[ch->index]);
 590                         g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 591                         /* Min, max, write resolution. */
 592                         for (i = 0; i < 3; i++) {
 593                                 gvar = g_variant_new_double(ch_spec->voltage[i]);
 594                                 g_variant_builder_add_value(&gvb, gvar);
 595                         }
 596                         *data = g_variant_builder_end(&gvb);
 597                         break;
 598                 case SR_CONF_OUTPUT_FREQUENCY_TARGET:
 599                         ch_spec = &(devc->device->channels[ch->index]);
 600                         g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 601                         /* Min, max, write resolution. */
 602                         for (i = 0; i < 3; i++) {
 603                                 gvar = g_variant_new_double(ch_spec->frequency[i]);
 604                                 g_variant_builder_add_value(&gvb, gvar);
 605                         }
 606                         *data = g_variant_builder_end(&gvb);
 607                         break;
 608                 case SR_CONF_CURRENT_LIMIT:
 609                         g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
 610                         /* Min, max, step. */
 611                         for (i = 0; i < 3; i++) {
 612                                 ch_spec = &(devc->device->channels[ch->index]);
 613                                 gvar = g_variant_new_double(ch_spec->current[i]);
 614                                 g_variant_builder_add_value(&gvb, gvar);
 615                         }
 616                         *data = g_variant_builder_end(&gvb);
 617                         break;
 618                 default:
 619                         return SR_ERR_NA;
 620                 }
 621         }
 622
 623         return ret;
 624 }
 625
 626 static int dev_acquisition_start(const struct sr_dev_inst *sdi)
 627 {
 628         struct dev_context *devc;
 629         struct sr_scpi_dev_inst *scpi;
 630         struct sr_channel *ch;
 631         struct pps_channel *pch;
 632         int cmd, ret;
 633
 634         devc = sdi->priv;
 635         scpi = sdi->conn;
 636
 637         if ((ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 10,
 638                         scpi_pps_receive_data, (void *)sdi)) != SR_OK)
 639                 return ret;
 640         std_session_send_df_header(sdi);
 641
 642         /* Prime the pipe with the first channel's fetch. */
 643         ch = sr_next_enabled_channel(sdi, NULL);
 644         pch = ch->priv;
 645         if ((ret = select_channel(sdi, ch)) < 0)
 646                 return ret;
 647         if (pch->mq == SR_MQ_VOLTAGE)
 648                 cmd = SCPI_CMD_GET_MEAS_VOLTAGE;
 649         else if (pch->mq == SR_MQ_FREQUENCY)
 650                 cmd = SCPI_CMD_GET_MEAS_FREQUENCY;
 651         else if (pch->mq == SR_MQ_CURRENT)
 652                 cmd = SCPI_CMD_GET_MEAS_CURRENT;
 653         else if (pch->mq == SR_MQ_POWER)
 654                 cmd = SCPI_CMD_GET_MEAS_POWER;
 655         else
 656                 return SR_ERR;
 657         scpi_cmd(sdi, devc->device->commands, cmd, pch->hwname);
 658
 659         return SR_OK;
 660 }
 661
 662 static int dev_acquisition_stop(struct sr_dev_inst *sdi)
 663 {
 664         struct sr_scpi_dev_inst *scpi;
 665         float f;
 666
 667         scpi = sdi->conn;
 668
 669         /*
 670          * A requested value is certainly on the way. Retrieve it now,
 671          * to avoid leaving the device in a state where it's not expecting
 672          * commands.
 673          */
 674         sr_scpi_get_float(scpi, NULL, &f);
 675         sr_scpi_source_remove(sdi->session, scpi);
 676
 677         std_session_send_df_end(sdi);
 678
 679         return SR_OK;
 680 }
 681
 682 static struct sr_dev_driver scpi_pps_driver_info = {
 683         .name = "scpi-pps",
 684         .longname = "SCPI PPS",
 685         .api_version = 1,
 686         .init = std_init,
 687         .cleanup = std_cleanup,
 688         .scan = scan_scpi_pps,
 689         .dev_list = std_dev_list,
 690         .dev_clear = dev_clear,
 691         .config_get = config_get,
 692         .config_set = config_set,
 693         .config_list = config_list,
 694         .dev_open = dev_open,
 695         .dev_close = dev_close,
 696         .dev_acquisition_start = dev_acquisition_start,
 697         .dev_acquisition_stop = dev_acquisition_stop,
 698         .context = NULL,
 699 };
 700
 701 static struct sr_dev_driver hp_ib_pps_driver_info = {
 702         .name = "hpib-pps",
 703         .longname = "HP-IB PPS",
 704         .api_version = 1,
 705         .init = std_init,
 706         .cleanup = std_cleanup,
 707         .scan = scan_hpib_pps,
 708         .dev_list = std_dev_list,
 709         .dev_clear = dev_clear,
 710         .config_get = config_get,
 711         .config_set = config_set,
 712         .config_list = config_list,
 713         .dev_open = dev_open,
 714         .dev_close = dev_close,
 715         .dev_acquisition_start = dev_acquisition_start,
 716         .dev_acquisition_stop = dev_acquisition_stop,
 717         .context = NULL,
 718 };
 719 SR_REGISTER_DEV_DRIVER(scpi_pps_driver_info);
 720 SR_REGISTER_DEV_DRIVER(hp_ib_pps_driver_info);