]> sigrok.org Git - libsigrok.git/blob - src/hardware/scpi-dmm/api.c
scpi-dmm: add support for OWON XDM1041
[libsigrok.git] / src / hardware / scpi-dmm / api.c
1 /*
2  * This file is part of the libsigrok project.
3  *
4  * Copyright (C) 2018 Gerhard Sittig <gerhard.sittig@gmx.net>
5  *
6  * This program is free software: you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation, either version 3 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
18  */
19
20 #include <string.h>
21 #include "protocol.h"
22
23 static struct sr_dev_driver scpi_dmm_driver_info;
24
25 static const uint32_t scanopts[] = {
26         SR_CONF_CONN,
27         SR_CONF_SERIALCOMM,
28 };
29
30 static const uint32_t drvopts[] = {
31         SR_CONF_MULTIMETER,
32 };
33
34 static const uint32_t devopts_generic[] = {
35         SR_CONF_CONTINUOUS,
36         SR_CONF_CONN | SR_CONF_GET,
37         SR_CONF_LIMIT_SAMPLES | SR_CONF_GET | SR_CONF_SET,
38         SR_CONF_LIMIT_MSEC | SR_CONF_GET | SR_CONF_SET,
39         SR_CONF_MEASURED_QUANTITY | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
40 };
41
42 static const uint32_t devopts_generic_range[] = {
43         SR_CONF_CONTINUOUS,
44         SR_CONF_CONN | SR_CONF_GET,
45         SR_CONF_LIMIT_SAMPLES | SR_CONF_GET | SR_CONF_SET,
46         SR_CONF_LIMIT_MSEC | SR_CONF_GET | SR_CONF_SET,
47         SR_CONF_MEASURED_QUANTITY | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
48         SR_CONF_RANGE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
49 };
50
51 static const struct scpi_command cmdset_agilent[] = {
52         { DMM_CMD_SETUP_REMOTE, "\n", },
53         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
54         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
55         { DMM_CMD_QUERY_FUNC, "CONF?", },
56         { DMM_CMD_START_ACQ, "INIT", },
57         { DMM_CMD_STOP_ACQ, "ABORT", },
58         { DMM_CMD_QUERY_VALUE, "FETCH?", },
59         { DMM_CMD_QUERY_PREC, "CONF?", },
60         { DMM_CMD_QUERY_RANGE_AUTO, "%s:RANGE:AUTO?", },
61         { DMM_CMD_QUERY_RANGE, "%s:RANGE?", },
62         { DMM_CMD_SETUP_RANGE, "CONF:%s %s", },
63         ALL_ZERO,
64 };
65
66 /*
67  * cmdset_hp is used for the 34401A, which was added to this code after the
68  * 34405A and 34465A. It differs in starting the measurement with INIT: using
69  * MEAS without a trailing '?' (as used for the 34405A) is not valid for the
70  * 34401A and gives an error.
71  * I'm surprised the same instruction sequence doesn't work and INIT may
72  * work for both, but I don't have the others to re-test.
73  *
74  * cmdset_hp also works well for the 34410A, using cmdset_agilent throws an
75  * error on 'MEAS' without a '?'.
76  *
77  * On the 34401A,
78  *  MEAS <optional parameters> ? configures, arms, triggers and waits
79  *       for a reading
80  *  CONF <parameters> configures
81  *  INIT prepares for triggering (trigger mode is not set, assumed
82  *       internal - external might time out)
83  *  *OPC waits for completion, and
84  *  READ? retrieves the result
85  */
86 static const struct scpi_command cmdset_hp[] = {
87         { DMM_CMD_SETUP_REMOTE, "\n", },
88         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
89         { DMM_CMD_QUERY_FUNC, "CONF?", },
90         { DMM_CMD_START_ACQ, "INIT", },
91         { DMM_CMD_STOP_ACQ, "ABORT", },
92         { DMM_CMD_QUERY_VALUE, "READ?", },
93         { DMM_CMD_QUERY_PREC, "CONF?", },
94         ALL_ZERO,
95 };
96
97 static const struct scpi_command cmdset_gwinstek[] = {
98         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
99         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
100         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
101         { DMM_CMD_QUERY_FUNC, "CONF:STAT:FUNC?", },
102         { DMM_CMD_START_ACQ, "*CLS;SYST:REM", },
103         { DMM_CMD_QUERY_VALUE, "VAL1?", },
104         { DMM_CMD_QUERY_PREC, "SENS:DET:RATE?", },
105         ALL_ZERO,
106 };
107
108 static const struct scpi_command cmdset_gwinstek_906x[] = {
109         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
110         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
111         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
112         { DMM_CMD_QUERY_FUNC, "CONF?", },
113         { DMM_CMD_START_ACQ, "INIT", },
114         { DMM_CMD_STOP_ACQ, "ABORT", },
115         { DMM_CMD_QUERY_VALUE, "VAL1?", },
116         { DMM_CMD_QUERY_PREC, "SENS:DET:RATE?", },
117         ALL_ZERO,
118 };
119
120 static const struct scpi_command cmdset_owon[] = {
121         { DMM_CMD_SETUP_REMOTE, "SYST:REM", },
122         { DMM_CMD_SETUP_LOCAL, "SYST:LOC", },
123         { DMM_CMD_SETUP_FUNC, "CONF:%s", },
124         { DMM_CMD_QUERY_FUNC, "FUNC?", },
125         { DMM_CMD_QUERY_VALUE, "MEAS1?", },
126         ALL_ZERO,
127 };
128
129 static const struct mqopt_item mqopts_agilent_34405a[] = {
130         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, FLAGS_NONE, },
131         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC ", NO_DFLT_PREC, FLAG_CONF_DELAY | FLAG_MEAS_DELAY, },
132         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, FLAGS_NONE, },
133         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC ", NO_DFLT_PREC, FLAG_CONF_DELAY | FLAG_MEAS_DELAY, },
134         { SR_MQ_RESISTANCE, 0, "RES", "RES ", NO_DFLT_PREC, FLAG_MEAS_DELAY, },
135         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES ", NO_DFLT_PREC, FLAG_MEAS_DELAY, },
136         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAG_NO_RANGE, },
137         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP ", NO_DFLT_PREC, FLAGS_NONE, },
138         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAG_NO_RANGE, },
139         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP ", NO_DFLT_PREC, FLAG_NO_RANGE | FLAG_MEAS_DELAY, },
140         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ ", NO_DFLT_PREC, FLAG_NO_RANGE | FLAG_MEAS_DELAY, },
141 };
142
143 static const struct mqopt_item mqopts_agilent_34401a[] = {
144         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, FLAGS_NONE, },
145         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC ", NO_DFLT_PREC, FLAGS_NONE, },
146         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, FLAGS_NONE, },
147         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC ", NO_DFLT_PREC, FLAGS_NONE, },
148         { SR_MQ_RESISTANCE, 0, "RES", "RES ", NO_DFLT_PREC, FLAGS_NONE, },
149         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES ", NO_DFLT_PREC, FLAGS_NONE, },
150         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
151         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
152         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ ", NO_DFLT_PREC, FLAGS_NONE, },
153         { SR_MQ_TIME, 0, "PER", "PER ", NO_DFLT_PREC, FLAGS_NONE, },
154 };
155
156 static const struct mqopt_item mqopts_gwinstek_gdm8200a[] = {
157         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "01", NO_DFLT_PREC, FLAGS_NONE, },
158         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "02", NO_DFLT_PREC, FLAGS_NONE, },
159         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "03", NO_DFLT_PREC, FLAGS_NONE, },
160         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "04", NO_DFLT_PREC, FLAGS_NONE, },
161         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "05", NO_DFLT_PREC, FLAGS_NONE, }, /* mA */
162         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "06", NO_DFLT_PREC, FLAGS_NONE, }, /* mA */
163         { SR_MQ_RESISTANCE, 0, "RES", "07", NO_DFLT_PREC, FLAGS_NONE, },
164         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "16", NO_DFLT_PREC, FLAGS_NONE, },
165         { SR_MQ_CONTINUITY, 0, "CONT", "13", -1, FLAGS_NONE, },
166         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "17", -4, FLAGS_NONE, },
167         { SR_MQ_TEMPERATURE, 0, "TEMP", "09", NO_DFLT_PREC, FLAGS_NONE, }, /* Celsius */
168         { SR_MQ_TEMPERATURE, 0, "TEMP", "15", NO_DFLT_PREC, FLAGS_NONE, }, /* Fahrenheit */
169         { SR_MQ_FREQUENCY, 0, "FREQ", "08", NO_DFLT_PREC, FLAGS_NONE, },
170         { SR_MQ_TIME, 0, "PER", "14", NO_DFLT_PREC, FLAGS_NONE, },
171 };
172
173 static const struct mqopt_item mqopts_gwinstek_gdm906x[] = {
174         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, FLAGS_NONE, },
175         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC", NO_DFLT_PREC, FLAGS_NONE, },
176         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, FLAGS_NONE, },
177         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC", NO_DFLT_PREC, FLAGS_NONE, },
178         { SR_MQ_RESISTANCE, 0, "RES", "RES", NO_DFLT_PREC, FLAGS_NONE, },
179         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES", NO_DFLT_PREC, FLAGS_NONE, },
180         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
181         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
182         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP", NO_DFLT_PREC, FLAGS_NONE, },
183         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ", NO_DFLT_PREC, FLAGS_NONE, },
184         { SR_MQ_TIME, 0, "PER", "PER", NO_DFLT_PREC, FLAGS_NONE, },
185         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP", NO_DFLT_PREC, FLAGS_NONE, },
186 };
187
188 static const struct mqopt_item mqopts_owon_xdm2041[] = {
189         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT AC", NO_DFLT_PREC, FLAGS_NONE, },
190         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT", NO_DFLT_PREC, FLAGS_NONE, },
191         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR AC", NO_DFLT_PREC, FLAGS_NONE, },
192         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR", NO_DFLT_PREC, FLAGS_NONE, },
193         { SR_MQ_RESISTANCE, 0, "RES", "RES", NO_DFLT_PREC, FLAGS_NONE, },
194         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES", NO_DFLT_PREC, FLAGS_NONE, },
195         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
196         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
197         { SR_MQ_TEMPERATURE, 0, "TEMP", "TEMP", NO_DFLT_PREC, FLAGS_NONE, },
198         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ", NO_DFLT_PREC, FLAGS_NONE, },
199         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP", NO_DFLT_PREC, FLAGS_NONE, },
200 };
201
202 static const struct mqopt_item mqopts_siglent_sdm3055[] = {
203         { SR_MQ_VOLTAGE, SR_MQFLAG_DC, "VOLT:DC", "VOLT ", NO_DFLT_PREC, FLAGS_NONE, },
204         { SR_MQ_VOLTAGE, SR_MQFLAG_AC, "VOLT:AC", "VOLT:AC ", NO_DFLT_PREC, FLAGS_NONE, },
205         { SR_MQ_CURRENT, SR_MQFLAG_DC, "CURR:DC", "CURR ", NO_DFLT_PREC, FLAGS_NONE, },
206         { SR_MQ_CURRENT, SR_MQFLAG_AC, "CURR:AC", "CURR:AC ", NO_DFLT_PREC, FLAGS_NONE, },
207         { SR_MQ_RESISTANCE, 0, "RES", "RES ", NO_DFLT_PREC, FLAGS_NONE, },
208         { SR_MQ_RESISTANCE, SR_MQFLAG_FOUR_WIRE, "FRES", "FRES ", NO_DFLT_PREC, FLAGS_NONE, },
209         { SR_MQ_CONTINUITY, 0, "CONT", "CONT", -1, FLAGS_NONE, },
210         { SR_MQ_VOLTAGE, SR_MQFLAG_DC | SR_MQFLAG_DIODE, "DIOD", "DIOD", -4, FLAGS_NONE, },
211         { SR_MQ_FREQUENCY, 0, "FREQ", "FREQ ", NO_DFLT_PREC, FLAGS_NONE, },
212         { SR_MQ_TIME, 0, "PER", "PER ", NO_DFLT_PREC, FLAGS_NONE, },
213         { SR_MQ_CAPACITANCE, 0, "CAP", "CAP", NO_DFLT_PREC, FLAGS_NONE, },
214 };
215
216 SR_PRIV const struct scpi_dmm_model models[] = {
217         {
218                 "Agilent", "34405A",
219                 1, 5, cmdset_agilent, ARRAY_AND_SIZE(mqopts_agilent_34405a),
220                 scpi_dmm_get_meas_agilent,
221                 ARRAY_AND_SIZE(devopts_generic_range),
222                 0, 200 * 1000, 2500 * 1000, 0, FALSE,
223                 scpi_dmm_get_range_text, scpi_dmm_set_range_from_text, NULL,
224         },
225         {
226                 "Agilent", "34410A",
227                 1, 6, cmdset_hp, ARRAY_AND_SIZE(mqopts_agilent_34405a),
228                 scpi_dmm_get_meas_agilent,
229                 ARRAY_AND_SIZE(devopts_generic),
230                 0, 0, 0, 0, FALSE,
231                 NULL, NULL, NULL,
232         },
233         {
234                 "Agilent", "34460A",
235                 1, 6, cmdset_agilent, ARRAY_AND_SIZE(mqopts_agilent_34405a),
236                 scpi_dmm_get_meas_agilent,
237                 ARRAY_AND_SIZE(devopts_generic_range),
238                 0, 0, 10 * 1000, 0, FALSE,
239                 scpi_dmm_get_range_text, scpi_dmm_set_range_from_text, NULL,
240         },
241         {
242                 "GW", "GDM8251A",
243                 1, 6, cmdset_gwinstek, ARRAY_AND_SIZE(mqopts_gwinstek_gdm8200a),
244                 scpi_dmm_get_meas_gwinstek,
245                 ARRAY_AND_SIZE(devopts_generic),
246                 2500 * 1000, 0, 0, 0, FALSE,
247                 NULL, NULL, NULL,
248         },
249         {
250                 "GW", "GDM8255A",
251                 1, 6, cmdset_gwinstek, ARRAY_AND_SIZE(mqopts_gwinstek_gdm8200a),
252                 scpi_dmm_get_meas_gwinstek,
253                 ARRAY_AND_SIZE(devopts_generic),
254                 2500 * 1000, 0, 0, 0, FALSE,
255                 NULL, NULL, NULL,
256         },
257         {
258                 "GWInstek", "GDM9060",
259                 1, 6, cmdset_gwinstek_906x, ARRAY_AND_SIZE(mqopts_gwinstek_gdm906x),
260                 scpi_dmm_get_meas_agilent,
261                 ARRAY_AND_SIZE(devopts_generic),
262                 0, 0, 0, 0, FALSE,
263                 NULL, NULL, NULL,
264         },
265         {
266                 "GWInstek", "GDM9061",
267                 1, 6, cmdset_gwinstek_906x, ARRAY_AND_SIZE(mqopts_gwinstek_gdm906x),
268                 scpi_dmm_get_meas_agilent,
269                 ARRAY_AND_SIZE(devopts_generic),
270                 0, 0, 0, 0, FALSE,
271                 NULL, NULL, NULL,
272         },
273         {
274                 "HP", "34401A",
275                 1, 6, cmdset_hp, ARRAY_AND_SIZE(mqopts_agilent_34401a),
276                 scpi_dmm_get_meas_agilent,
277                 ARRAY_AND_SIZE(devopts_generic),
278                 /* 34401A: typ. 1020ms for AC readings (default is 1000ms). */
279                 1500 * 1000, 0, 0, 0, FALSE,
280                 NULL, NULL, NULL,
281         },
282         {
283                 "Keysight", "34465A",
284                 1, 6, cmdset_agilent, ARRAY_AND_SIZE(mqopts_agilent_34405a),
285                 scpi_dmm_get_meas_agilent,
286                 ARRAY_AND_SIZE(devopts_generic_range),
287                 0, 0, 10 * 1000, 0, FALSE,
288                 scpi_dmm_get_range_text, scpi_dmm_set_range_from_text, NULL,
289         },
290         {
291                 "OWON", "XDM1041",
292                 1, 5, cmdset_owon, ARRAY_AND_SIZE(mqopts_owon_xdm2041),
293                 scpi_dmm_get_meas_gwinstek,
294                 ARRAY_AND_SIZE(devopts_generic),
295                 0, 0, 0, 1e9, TRUE,
296                 NULL, NULL, NULL,
297         },
298         {
299                 "OWON", "XDM2041",
300                 1, 5, cmdset_owon, ARRAY_AND_SIZE(mqopts_owon_xdm2041),
301                 scpi_dmm_get_meas_gwinstek,
302                 ARRAY_AND_SIZE(devopts_generic),
303                 0, 0, 0, 1e9, TRUE,
304                 NULL, NULL, NULL,
305         },
306         {
307                 "Siglent", "SDM3055",
308                 1, 5, cmdset_hp, ARRAY_AND_SIZE(mqopts_siglent_sdm3055),
309                 scpi_dmm_get_meas_agilent,
310                 ARRAY_AND_SIZE(devopts_generic),
311                 0, 0, 0, 0, FALSE,
312                 NULL, NULL, NULL,
313         },
314 };
315
316 static const struct scpi_dmm_model *is_compatible(const char *vendor, const char *model)
317 {
318         size_t i;
319         const struct scpi_dmm_model *entry;
320
321         for (i = 0; i < ARRAY_SIZE(models); i++) {
322                 entry = &models[i];
323                 if (!entry->vendor || !entry->model)
324                         continue;
325                 if (strcmp(vendor, entry->vendor) != 0)
326                         continue;
327                 if (strcmp(model, entry->model) != 0)
328                         continue;
329                 return entry;
330         }
331
332         return NULL;
333 }
334
335 /*
336  * Some devices (such as Owon XDM2041) do not support the standard
337  * OPeration Complete? command. This function tests the command with
338  * a short timeout, and returns TRUE if any reply (busy or not) is received.
339  */
340 static gboolean probe_opc_support(struct sr_scpi_dev_inst *scpi)
341 {
342         gboolean result;
343         GString *response;
344
345         response = g_string_sized_new(128);
346         result = TRUE;
347         if (sr_scpi_get_data(scpi, SCPI_CMD_OPC, &response) != SR_OK)
348                 result = FALSE;
349         g_string_free(response, TRUE);
350
351         return result;
352 }
353
354 static struct sr_dev_inst *probe_device(struct sr_scpi_dev_inst *scpi)
355 {
356         struct sr_scpi_hw_info *hw_info;
357         int ret;
358         const char *vendor;
359         const struct scpi_dmm_model *model;
360         struct sr_dev_inst *sdi;
361         struct dev_context *devc;
362         size_t i;
363         gchar *channel_name;
364         const char *command;
365
366         ret = sr_scpi_get_hw_id(scpi, &hw_info);
367         if (ret != SR_OK) {
368                 sr_info("Could not get IDN response.");
369                 return NULL;
370         }
371         vendor = sr_vendor_alias(hw_info->manufacturer);
372         model = is_compatible(vendor, hw_info->model);
373         if (!model) {
374                 sr_scpi_hw_info_free(hw_info);
375                 return NULL;
376         }
377
378         if (model->check_opc && !probe_opc_support(scpi))
379                 scpi->no_opc_command = TRUE;
380
381         sdi = g_malloc0(sizeof(*sdi));
382         sdi->vendor = g_strdup(hw_info->manufacturer);
383         sdi->model = g_strdup(hw_info->model);
384         sdi->version = g_strdup(hw_info->firmware_version);
385         sdi->serial_num = g_strdup(hw_info->serial_number);
386         sdi->conn = scpi;
387         sdi->driver = &scpi_dmm_driver_info;
388         sdi->inst_type = SR_INST_SCPI;
389         ret = sr_scpi_connection_id(scpi, &sdi->connection_id);
390         if (ret != SR_OK) {
391                 g_free(sdi->connection_id);
392                 sdi->connection_id = NULL;
393         }
394         sr_scpi_hw_info_free(hw_info);
395         if (model->read_timeout_us)  /* non-default read timeout */
396                 scpi->read_timeout_us = model->read_timeout_us;
397         devc = g_malloc0(sizeof(*devc));
398         sdi->priv = devc;
399         devc->num_channels = model->num_channels;
400         devc->cmdset = model->cmdset;
401         devc->model = model;
402
403         for (i = 0; i < devc->num_channels; i++) {
404                 channel_name = g_strdup_printf("P%zu", i + 1);
405                 sr_channel_new(sdi, 0, SR_CHANNEL_ANALOG, TRUE, channel_name);
406         }
407
408         /*
409          * If device has DMM_CMD_SETUP_LOCAL command, send it now. To avoid
410          * leaving device in remote mode (if only a "scan" is run).
411          */
412         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_SETUP_LOCAL);
413         if (command && *command) {
414                 scpi_dmm_cmd_delay(scpi);
415                 sr_scpi_send(scpi, command);
416         }
417
418         return sdi;
419 }
420
421 static GSList *scan(struct sr_dev_driver *di, GSList *options)
422 {
423         return sr_scpi_scan(di->context, options, probe_device);
424 }
425
426 static int dev_open(struct sr_dev_inst *sdi)
427 {
428         struct sr_scpi_dev_inst *scpi;
429         int ret;
430
431         scpi = sdi->conn;
432         ret = sr_scpi_open(scpi);
433         if (ret < 0) {
434                 sr_err("Failed to open SCPI device: %s.", sr_strerror(ret));
435                 return SR_ERR;
436         }
437
438         return SR_OK;
439 }
440
441 static int dev_close(struct sr_dev_inst *sdi)
442 {
443         struct dev_context *devc;
444         struct sr_scpi_dev_inst *scpi;
445         const char *command;
446
447         devc = sdi->priv;
448         scpi = sdi->conn;
449         if (!scpi)
450                 return SR_ERR_BUG;
451
452         sr_dbg("DIAG: sdi->status %d.", sdi->status - SR_ST_NOT_FOUND);
453         if (sdi->status <= SR_ST_INACTIVE)
454                 return SR_OK;
455
456         /*
457          * If device has DMM_CMD_SETUP_LOCAL command, send it now
458          * to avoid leaving device in remote mode.
459          */
460         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_SETUP_LOCAL);
461         if (command && *command) {
462                 scpi_dmm_cmd_delay(scpi);
463                 sr_scpi_send(scpi, command);
464         }
465
466         return sr_scpi_close(scpi);
467 }
468
469 static int config_get(uint32_t key, GVariant **data,
470         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
471 {
472         struct dev_context *devc;
473         enum sr_mq mq;
474         enum sr_mqflag mqflag;
475         GVariant *arr[2];
476         int ret;
477         const char *range;
478
479         (void)cg;
480
481         devc = sdi->priv;
482
483         switch (key) {
484         case SR_CONF_CONN:
485                 if (!sdi || !sdi->connection_id)
486                         return SR_ERR_NA;
487                 *data = g_variant_new_string(sdi->connection_id);
488                 return SR_OK;
489         case SR_CONF_LIMIT_SAMPLES:
490         case SR_CONF_LIMIT_MSEC:
491                 return sr_sw_limits_config_get(&devc->limits, key, data);
492         case SR_CONF_MEASURED_QUANTITY:
493                 ret = scpi_dmm_get_mq(sdi, &mq, &mqflag, NULL, NULL);
494                 if (ret != SR_OK)
495                         return ret;
496                 arr[0] = g_variant_new_uint32(mq);
497                 arr[1] = g_variant_new_uint64(mqflag);
498                 *data = g_variant_new_tuple(arr, ARRAY_SIZE(arr));
499                 return SR_OK;
500         case SR_CONF_RANGE:
501                 if (!devc || !devc->model->get_range_text)
502                         return SR_ERR_NA;
503                 range = devc->model->get_range_text(sdi);
504                 if (!range || !*range)
505                         return SR_ERR_NA;
506                 *data = g_variant_new_string(range);
507                 return SR_OK;
508         default:
509                 return SR_ERR_NA;
510         }
511 }
512
513 static int config_set(uint32_t key, GVariant *data,
514         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
515 {
516         struct dev_context *devc;
517         enum sr_mq mq;
518         enum sr_mqflag mqflag;
519         GVariant *tuple_child;
520         const char *range;
521
522         (void)cg;
523
524         devc = sdi->priv;
525
526         switch (key) {
527         case SR_CONF_LIMIT_SAMPLES:
528         case SR_CONF_LIMIT_MSEC:
529                 return sr_sw_limits_config_set(&devc->limits, key, data);
530         case SR_CONF_MEASURED_QUANTITY:
531                 tuple_child = g_variant_get_child_value(data, 0);
532                 mq = g_variant_get_uint32(tuple_child);
533                 g_variant_unref(tuple_child);
534                 tuple_child = g_variant_get_child_value(data, 1);
535                 mqflag = g_variant_get_uint64(tuple_child);
536                 g_variant_unref(tuple_child);
537                 return scpi_dmm_set_mq(sdi, mq, mqflag);
538         case SR_CONF_RANGE:
539                 if (!devc || !devc->model->set_range_from_text)
540                         return SR_ERR_NA;
541                 range = g_variant_get_string(data, NULL);
542                 return devc->model->set_range_from_text(sdi, range);
543         default:
544                 return SR_ERR_NA;
545         }
546 }
547
548 static int config_list(uint32_t key, GVariant **data,
549         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
550 {
551         struct dev_context *devc;
552         GVariant *gvar, *arr[2];
553         GVariantBuilder gvb;
554         size_t i;
555
556         (void)cg;
557
558         devc = sdi ? sdi->priv : NULL;
559
560         switch (key) {
561         case SR_CONF_SCAN_OPTIONS:
562         case SR_CONF_DEVICE_OPTIONS:
563                 if (!devc)
564                         return STD_CONFIG_LIST(key, data, sdi, cg,
565                                 scanopts, drvopts, devopts_generic);
566                 return std_opts_config_list(key, data, sdi, cg,
567                         ARRAY_AND_SIZE(scanopts), ARRAY_AND_SIZE(drvopts),
568                         devc->model->devopts, devc->model->devopts_size);
569         case SR_CONF_MEASURED_QUANTITY:
570                 /* TODO Use std_gvar_measured_quantities() when available. */
571                 if (!devc)
572                         return SR_ERR_ARG;
573                 g_variant_builder_init(&gvb, G_VARIANT_TYPE_ARRAY);
574                 for (i = 0; i < devc->model->mqopt_size; i++) {
575                         arr[0] = g_variant_new_uint32(devc->model->mqopts[i].mq);
576                         arr[1] = g_variant_new_uint64(devc->model->mqopts[i].mqflag);
577                         gvar = g_variant_new_tuple(arr, ARRAY_SIZE(arr));
578                         g_variant_builder_add_value(&gvb, gvar);
579                 }
580                 *data = g_variant_builder_end(&gvb);
581                 return SR_OK;
582         case SR_CONF_RANGE:
583                 if (!devc || !devc->model->get_range_text_list)
584                         return SR_ERR_NA;
585                 *data = devc->model->get_range_text_list(sdi);
586                 return SR_OK;
587         default:
588                 (void)devc;
589                 return SR_ERR_NA;
590         }
591 }
592
593 static int dev_acquisition_start(const struct sr_dev_inst *sdi)
594 {
595         struct sr_scpi_dev_inst *scpi;
596         struct dev_context *devc;
597         int ret;
598         const struct mqopt_item *item;
599         const char *command;
600         char *response;
601         gboolean do_mq_meas_delay;
602
603         scpi = sdi->conn;
604         devc = sdi->priv;
605
606         ret = scpi_dmm_get_mq(sdi, &devc->start_acq_mq.curr_mq,
607                 &devc->start_acq_mq.curr_mqflag, NULL, &item);
608         if (ret != SR_OK)
609                 return ret;
610
611         /*
612          * Query for current precision if DMM supports the command
613          */
614         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_QUERY_PREC);
615         if (command && *command) {
616                 scpi_dmm_cmd_delay(scpi);
617                 ret = sr_scpi_get_string(scpi, command, &response);
618                 if (ret == SR_OK) {
619                         g_strstrip(response);
620                         g_free(devc->precision);
621                         devc->precision = g_strdup(response);
622                         g_free(response);
623                         sr_dbg("%s: Precision: '%s'", __func__, devc->precision);
624                 } else {
625                         sr_info("Precision query ('%s') failed: %d",
626                                 command, ret);
627                 }
628         }
629
630         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_START_ACQ);
631         if (command && *command) {
632                 scpi_dmm_cmd_delay(scpi);
633                 ret = sr_scpi_send(scpi, command);
634                 if (ret != SR_OK)
635                         return ret;
636         }
637
638         do_mq_meas_delay = item->drv_flags & FLAG_MEAS_DELAY;
639         if (do_mq_meas_delay && devc->model->meas_delay_us)
640                 g_usleep(devc->model->meas_delay_us);
641
642         sr_sw_limits_acquisition_start(&devc->limits);
643         ret = std_session_send_df_header(sdi);
644         if (ret != SR_OK)
645                 return ret;
646
647         ret = sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 10,
648                 scpi_dmm_receive_data, (void *)sdi);
649         if (ret != SR_OK)
650                 return ret;
651
652         return SR_OK;
653 }
654
655 static int dev_acquisition_stop(struct sr_dev_inst *sdi)
656 {
657         struct sr_scpi_dev_inst *scpi;
658         struct dev_context *devc;
659         const char *command;
660
661         scpi = sdi->conn;
662         devc = sdi->priv;
663
664         command = sr_scpi_cmd_get(devc->cmdset, DMM_CMD_STOP_ACQ);
665         if (command && *command) {
666                 scpi_dmm_cmd_delay(scpi);
667                 (void)sr_scpi_send(scpi, command);
668         }
669         sr_scpi_source_remove(sdi->session, scpi);
670
671         std_session_send_df_end(sdi);
672
673         g_free(devc->precision);
674         devc->precision = NULL;
675
676         return SR_OK;
677 }
678
679 static struct sr_dev_driver scpi_dmm_driver_info = {
680         .name = "scpi-dmm",
681         .longname = "SCPI DMM",
682         .api_version = 1,
683         .init = std_init,
684         .cleanup = std_cleanup,
685         .scan = scan,
686         .dev_list = std_dev_list,
687         .dev_clear = std_dev_clear,
688         .config_get = config_get,
689         .config_set = config_set,
690         .config_list = config_list,
691         .dev_open = dev_open,
692         .dev_close = dev_close,
693         .dev_acquisition_start = dev_acquisition_start,
694         .dev_acquisition_stop = dev_acquisition_stop,
695         .context = NULL,
696 };
697 SR_REGISTER_DEV_DRIVER(scpi_dmm_driver_info);