]> sigrok.org Git - libsigrok.git/blob - src/hardware/lascar-el-usb/protocol.c
Don't check sr_channel_new() return value (always succeeds).
[libsigrok.git] / src / hardware / lascar-el-usb / protocol.c
1 /*
2  * This file is part of the libsigrok project.
3  *
4  * Copyright (C) 2012 Bert Vermeulen <bert@biot.com>
5  *
6  * This program is free software: you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation, either version 3 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
18  */
19
20 #include <stdlib.h>
21 #include <sys/time.h>
22 #include <string.h>
23 #include <math.h>
24 #include <glib.h>
25 #include "libsigrok.h"
26 #include "libsigrok-internal.h"
27 #include "protocol.h"
28
29 extern struct sr_dev_driver lascar_el_usb_driver_info;
30 static struct sr_dev_driver *di = &lascar_el_usb_driver_info;
31
32 static const struct elusb_profile profiles[] = {
33         { 1, "EL-USB-1", LOG_UNSUPPORTED },
34         { 2, "EL-USB-1", LOG_UNSUPPORTED },
35         { 3, "EL-USB-2", LOG_TEMP_RH },
36         { 4, "EL-USB-3", LOG_UNSUPPORTED },
37         { 5, "EL-USB-4", LOG_UNSUPPORTED },
38         { 6, "EL-USB-3", LOG_UNSUPPORTED },
39         { 7, "EL-USB-4", LOG_UNSUPPORTED },
40         { 8, "EL-USB-LITE", LOG_UNSUPPORTED },
41         { 9, "EL-USB-CO", LOG_CO },
42         { 10, "EL-USB-TC", LOG_UNSUPPORTED },
43         { 11, "EL-USB-CO300", LOG_CO },
44         { 12, "EL-USB-2-LCD", LOG_TEMP_RH },
45         { 13, "EL-USB-2+", LOG_TEMP_RH },
46         { 14, "EL-USB-1-PRO", LOG_UNSUPPORTED },
47         { 15, "EL-USB-TC-LCD", LOG_UNSUPPORTED },
48         { 16, "EL-USB-2-LCD+", LOG_TEMP_RH },
49         { 17, "EL-USB-5", LOG_UNSUPPORTED },
50         { 18, "EL-USB-1-RCG", LOG_UNSUPPORTED },
51         { 19, "EL-USB-1-LCD", LOG_UNSUPPORTED },
52         { 20, "EL-OEM-3", LOG_UNSUPPORTED },
53         { 21, "EL-USB-1-LCD", LOG_UNSUPPORTED },
54         { 0, NULL, 0 }
55 };
56
57
58 static libusb_device_handle *lascar_open(struct libusb_device *dev)
59 {
60         libusb_device_handle *dev_hdl;
61         int ret;
62
63         if ((ret = libusb_open(dev, &dev_hdl)) != 0) {
64                 sr_dbg("failed to open device for scan: %s",
65                                 libusb_error_name(ret));
66                 return NULL;
67         }
68
69         /* Some of these fail, but it needs doing -- some sort of mode
70          * setup for the SILabs F32x. */
71         libusb_control_transfer(dev_hdl, LIBUSB_REQUEST_TYPE_VENDOR,
72                         0x00, 0xffff, 0x00, NULL, 0, 50);
73         libusb_control_transfer(dev_hdl, LIBUSB_REQUEST_TYPE_VENDOR,
74                         0x02, 0x0002, 0x00, NULL, 0, 50);
75         libusb_control_transfer(dev_hdl, LIBUSB_REQUEST_TYPE_VENDOR,
76                         0x02, 0x0001, 0x00, NULL, 0, 50);
77
78         return dev_hdl;
79 }
80
81 static void mark_xfer(struct libusb_transfer *xfer)
82 {
83
84         xfer->user_data = GINT_TO_POINTER(1);
85
86 }
87
88 SR_PRIV int lascar_get_config(libusb_device_handle *dev_hdl,
89                 unsigned char *configblock, int *configlen)
90 {
91         struct drv_context *drvc;
92         struct libusb_transfer *xfer_in, *xfer_out;
93         struct timeval tv;
94         int64_t start;
95         int buflen;
96         unsigned char cmd[3], buf[MAX_CONFIGBLOCK_SIZE];
97
98         sr_spew("Reading config block.");
99
100         drvc = di->priv;
101         *configlen = 0;
102
103         if (!(xfer_in = libusb_alloc_transfer(0)) ||
104                         !(xfer_out = libusb_alloc_transfer(0)))
105                 return SR_ERR;
106
107         /* Flush anything the F321 still has queued. */
108         while (libusb_bulk_transfer(dev_hdl, LASCAR_EP_IN, buf, 256, &buflen,
109                         5) == 0 && buflen > 0)
110                 ;
111
112         /* Keep a read request waiting in the wings, ready to pounce
113          * the moment the device sends something. */
114         libusb_fill_bulk_transfer(xfer_in, dev_hdl, LASCAR_EP_IN,
115                         buf, 256, mark_xfer, 0, 10000);
116         if (libusb_submit_transfer(xfer_in) != 0)
117                 goto cleanup;
118
119         /* Request device configuration structure. */
120         cmd[0] = 0x00;
121         cmd[1] = 0xff;
122         cmd[2] = 0xff;
123         libusb_fill_bulk_transfer(xfer_out, dev_hdl, LASCAR_EP_OUT,
124                         cmd, 3, mark_xfer, 0, 100);
125         if (libusb_submit_transfer(xfer_out) != 0)
126                 goto cleanup;
127
128         tv.tv_sec = 0;
129         tv.tv_usec = 0;
130         start = g_get_monotonic_time();
131         while (!xfer_in->user_data || !xfer_out->user_data) {
132                 if (g_get_monotonic_time() - start > SCAN_TIMEOUT) {
133                         start = 0;
134                         break;
135                 }
136                 g_usleep(5000);
137                 libusb_handle_events_timeout(drvc->sr_ctx->libusb_ctx, &tv);
138         }
139         if (!start) {
140                 sr_dbg("no response");
141                 goto cleanup;
142         }
143         if (xfer_in->actual_length != 3) {
144                 sr_dbg("expected 3-byte header, got %d bytes", xfer_in->actual_length);
145                 goto cleanup;
146         }
147
148         /* Got configuration structure header. */
149         sr_spew("Response to config request: 0x%.2x 0x%.2x 0x%.2x ",
150                         buf[0], buf[1], buf[2]);
151         buflen = buf[1] | (buf[2] << 8);
152         if (buf[0] != 0x02 || buflen > MAX_CONFIGBLOCK_SIZE) {
153                 sr_dbg("Invalid response to config request: "
154                                 "0x%.2x 0x%.2x 0x%.2x ", buf[0], buf[1], buf[2]);
155                 libusb_close(dev_hdl);
156                 goto cleanup;
157         }
158
159         /* Get configuration structure. */
160         xfer_in->length = buflen;
161         xfer_in->user_data = 0;
162         if (libusb_submit_transfer(xfer_in) != 0)
163                 goto cleanup;
164         while (!xfer_in->user_data) {
165                 if (g_get_monotonic_time() - start > SCAN_TIMEOUT) {
166                         start = 0;
167                         break;
168                 }
169                 g_usleep(5000);
170                 libusb_handle_events_timeout(drvc->sr_ctx->libusb_ctx, &tv);
171         }
172         if (!start) {
173                 sr_dbg("Timeout waiting for configuration structure.");
174                 goto cleanup;
175         }
176         if (xfer_in->actual_length != buflen) {
177                 sr_dbg("expected %d-byte structure, got %d bytes", buflen,
178                                 xfer_in->actual_length);
179                 goto cleanup;
180         }
181
182         memcpy(configblock, buf, buflen);
183         *configlen = buflen;
184
185 cleanup:
186         if (!xfer_in->user_data || !xfer_in->user_data) {
187                 if (!xfer_in->user_data)
188                         libusb_cancel_transfer(xfer_in);
189                 if (!xfer_out->user_data)
190                         libusb_cancel_transfer(xfer_out);
191                 start = g_get_monotonic_time();
192                 while (!xfer_in->user_data || !xfer_out->user_data) {
193                         if (g_get_monotonic_time() - start > 10000)
194                                 break;
195                         g_usleep(1000);
196                         libusb_handle_events_timeout(drvc->sr_ctx->libusb_ctx, &tv);
197                 }
198         }
199         libusb_free_transfer(xfer_in);
200         libusb_free_transfer(xfer_out);
201
202         return *configlen ? SR_OK : SR_ERR;
203 }
204
205 static int lascar_save_config(libusb_device_handle *dev_hdl,
206                 unsigned char *config, int configlen)
207 {
208         struct drv_context *drvc;
209         struct libusb_transfer *xfer_in, *xfer_out;
210         struct timeval tv;
211         int64_t start;
212         int buflen, ret;
213         unsigned char cmd[3], buf[256];
214
215         sr_spew("Writing config block.");
216
217         drvc = di->priv;
218
219         if (!(xfer_in = libusb_alloc_transfer(0)) ||
220                         !(xfer_out = libusb_alloc_transfer(0)))
221                 return SR_ERR;
222
223         /* Flush anything the F321 still has queued. */
224         while (libusb_bulk_transfer(dev_hdl, LASCAR_EP_IN, buf, 256, &buflen,
225                         5) == 0 && buflen > 0)
226                 ;
227         ret = SR_OK;
228
229         /* Keep a read request waiting in the wings, ready to pounce
230          * the moment the device sends something. */
231         libusb_fill_bulk_transfer(xfer_in, dev_hdl, LASCAR_EP_IN,
232                         buf, 256, mark_xfer, 0, 10000);
233         if (libusb_submit_transfer(xfer_in) != 0) {
234                 ret = SR_ERR;
235                 goto cleanup;
236         }
237
238         /* Request device configuration structure. */
239         cmd[0] = 0x01;
240         cmd[1] = configlen & 0xff;
241         cmd[2] = (configlen >> 8) & 0xff;
242         libusb_fill_bulk_transfer(xfer_out, dev_hdl, LASCAR_EP_OUT,
243                         cmd, 3, mark_xfer, 0, 100);
244         if (libusb_submit_transfer(xfer_out) != 0) {
245                 ret = SR_ERR;
246                 goto cleanup;
247         }
248         tv.tv_sec = 0;
249         tv.tv_usec = 0;
250         while (!xfer_out->user_data) {
251                 g_usleep(5000);
252                 libusb_handle_events_timeout(drvc->sr_ctx->libusb_ctx, &tv);
253         }
254
255         libusb_fill_bulk_transfer(xfer_out, dev_hdl, LASCAR_EP_OUT,
256                         config, configlen, mark_xfer, 0, 100);
257         if (libusb_submit_transfer(xfer_out) != 0) {
258                 ret = SR_ERR;
259                 goto cleanup;
260         }
261         while (!xfer_in->user_data || !xfer_out->user_data) {
262                 g_usleep(5000);
263                 libusb_handle_events_timeout(drvc->sr_ctx->libusb_ctx, &tv);
264         }
265
266         if (xfer_in->actual_length != 1 || buf[0] != 0xff) {
267                 sr_dbg("unexpected response after transfer");
268                 ret = SR_ERR;
269         }
270
271 cleanup:
272         if (!xfer_in->user_data || !xfer_in->user_data) {
273                 if (!xfer_in->user_data)
274                         libusb_cancel_transfer(xfer_in);
275                 if (!xfer_out->user_data)
276                         libusb_cancel_transfer(xfer_out);
277                 start = g_get_monotonic_time();
278                 while (!xfer_in->user_data || !xfer_out->user_data) {
279                         if (g_get_monotonic_time() - start > 10000)
280                                 break;
281                         g_usleep(1000);
282                         libusb_handle_events_timeout(drvc->sr_ctx->libusb_ctx, &tv);
283                 }
284         }
285         libusb_free_transfer(xfer_in);
286         libusb_free_transfer(xfer_out);
287
288         return ret;
289 }
290
291 static struct sr_dev_inst *lascar_identify(unsigned char *config)
292 {
293         struct dev_context *devc;
294         const struct elusb_profile *profile;
295         struct sr_dev_inst *sdi;
296         struct sr_channel *ch;
297         int modelid, i;
298         char firmware[5];
299
300         modelid = config[0];
301         sdi = NULL;
302         if (modelid) {
303                 profile = NULL;
304                 for (i = 0; profiles[i].modelid; i++) {
305                         if (profiles[i].modelid == modelid) {
306                                 profile = &profiles[i];
307                                 break;
308                         }
309                 }
310                 if (!profile) {
311                         sr_dbg("unknown EL-USB modelid %d", modelid);
312                         return NULL;
313                 }
314
315                 i = config[52] | (config[53] << 8);
316                 memcpy(firmware, config + 0x30, 4);
317                 firmware[4] = '\0';
318                 sr_dbg("found %s with firmware version %s serial %d",
319                                 profile->modelname, firmware, i);
320
321                 if (profile->logformat == LOG_UNSUPPORTED) {
322                         sr_dbg("unsupported EL-USB logformat for %s", profile->modelname);
323                         return NULL;
324                 }
325
326                 sdi = g_malloc0(sizeof(struct sr_dev_inst));
327                 sdi->status = SR_ST_INACTIVE;
328                 sdi->vendor = g_strdup(LASCAR_VENDOR);
329                 sdi->model = g_strdup(profile->modelname);
330                 sdi->version = g_strdup(firmware);
331                 sdi->driver = di;
332
333                 if (profile->logformat == LOG_TEMP_RH) {
334                         /* Model this as two channels: temperature and humidity. */
335                         ch = sr_channel_new(0, SR_CHANNEL_ANALOG, TRUE, "Temp");
336                         sdi->channels = g_slist_append(NULL, ch);
337                         ch = sr_channel_new(0, SR_CHANNEL_ANALOG, TRUE, "Hum");
338                         sdi->channels = g_slist_append(sdi->channels, ch);
339                 } else if (profile->logformat == LOG_CO) {
340                         ch = sr_channel_new(0, SR_CHANNEL_ANALOG, TRUE, "CO");
341                         sdi->channels = g_slist_append(NULL, ch);
342                 } else {
343                         ch = sr_channel_new(0, SR_CHANNEL_ANALOG, TRUE, "P1");
344                         sdi->channels = g_slist_append(NULL, ch);
345                 }
346
347                 devc = g_malloc0(sizeof(struct dev_context));
348                 sdi->priv = devc;
349                 devc->profile = profile;
350         }
351
352         return sdi;
353 }
354
355 SR_PRIV struct sr_dev_inst *lascar_scan(int bus, int address)
356 {
357         struct drv_context *drvc;
358         struct sr_dev_inst *sdi;
359         struct libusb_device **devlist;
360         struct libusb_device_descriptor des;
361         libusb_device_handle *dev_hdl;
362         int dummy, ret, i;
363         unsigned char config[MAX_CONFIGBLOCK_SIZE];
364
365         drvc = di->priv;
366         sdi = NULL;
367
368         libusb_get_device_list(drvc->sr_ctx->libusb_ctx, &devlist);
369         for (i = 0; devlist[i]; i++) {
370                 if ((ret = libusb_get_device_descriptor(devlist[i], &des))) {
371                         sr_err("Failed to get device descriptor: %d.", ret);
372                         continue;
373                 }
374
375                 if (libusb_get_bus_number(devlist[i]) != bus ||
376                                 libusb_get_device_address(devlist[i]) != address)
377                         continue;
378
379                 if (!(dev_hdl = lascar_open(devlist[i])))
380                         continue;
381
382                 if (lascar_get_config(dev_hdl, config, &dummy) != SR_OK)
383                         continue;
384
385                 libusb_close(dev_hdl);
386                 sdi = lascar_identify(config);
387         }
388
389         return sdi;
390 }
391
392 static void lascar_el_usb_dispatch(struct sr_dev_inst *sdi, unsigned char *buf,
393                 int buflen)
394 {
395         struct dev_context *devc;
396         struct sr_datafeed_packet packet;
397         struct sr_datafeed_analog analog;
398         struct sr_channel *ch;
399         float *temp, *rh;
400         uint16_t s;
401         int samples, samples_left, i, j;
402
403         devc = sdi->priv;
404
405         samples = buflen / devc->sample_size;
406         samples_left = devc->logged_samples - devc->rcvd_samples;
407         if (samples_left < samples)
408                 samples = samples_left;
409         switch (devc->profile->logformat) {
410         case LOG_TEMP_RH:
411                 packet.type = SR_DF_ANALOG;
412                 packet.payload = &analog;
413                 analog.mqflags = 0;
414                 if (!(temp = g_try_malloc(sizeof(float) * samples)))
415                         break;
416                 if (!(rh = g_try_malloc(sizeof(float) * samples)))
417                         break;
418                 for (i = 0, j = 0; i < samples; i++) {
419                         /* Both Celcius and Fahrenheit stored at base -40. */
420                         if (devc->temp_unit == 0)
421                                 /* Celcius is stored in half-degree increments. */
422                                 temp[j] = buf[i * 2] / 2 - 40;
423                         else
424                                 temp[j] = buf[i * 2] - 40;
425
426                         rh[j] = buf[i * 2 + 1] / 2;
427
428                         if (temp[j] == 0.0 && rh[j] == 0.0)
429                                 /* Skip invalid measurement. */
430                                 continue;
431                         j++;
432                 }
433                 analog.num_samples = j;
434
435                 ch = sdi->channels->data;
436                 if (ch->enabled) {
437                         analog.channels = g_slist_append(NULL, ch);
438                         analog.mq = SR_MQ_TEMPERATURE;
439                         if (devc->temp_unit == 1)
440                                 analog.unit = SR_UNIT_FAHRENHEIT;
441                         else
442                                 analog.unit = SR_UNIT_CELSIUS;
443                         analog.data = temp;
444                         sr_session_send(devc->cb_data, &packet);
445                 }
446
447                 ch = sdi->channels->next->data;
448                 if (ch->enabled) {
449                         analog.channels = g_slist_append(NULL, ch);
450                         analog.mq = SR_MQ_RELATIVE_HUMIDITY;
451                         analog.unit = SR_UNIT_PERCENTAGE;
452                         analog.data = rh;
453                         sr_session_send(devc->cb_data, &packet);
454                 }
455
456                 g_free(temp);
457                 g_free(rh);
458                 break;
459         case LOG_CO:
460                 packet.type = SR_DF_ANALOG;
461                 packet.payload = &analog;
462                 analog.channels = sdi->channels;
463                 analog.num_samples = samples;
464                 analog.mq = SR_MQ_CARBON_MONOXIDE;
465                 analog.unit = SR_UNIT_CONCENTRATION;
466                 analog.mqflags = 0;
467                 if (!(analog.data = g_try_malloc(sizeof(float) * samples)))
468                         break;
469                 for (i = 0; i < samples; i++) {
470                         s = (buf[i * 2] << 8) | buf[i * 2 + 1];
471                         analog.data[i] = (s * devc->co_high + devc->co_low) / 1000000;
472                         if (analog.data[i] < 0.0)
473                                 analog.data[i] = 0.0;
474                 }
475                 sr_session_send(devc->cb_data, &packet);
476                 g_free(analog.data);
477                 break;
478         default:
479                 /* How did we even get this far? */
480                 break;
481         }
482         devc->rcvd_samples += samples;
483
484 }
485
486 SR_PRIV int lascar_el_usb_handle_events(int fd, int revents, void *cb_data)
487 {
488         struct drv_context *drvc = di->priv;
489         struct sr_datafeed_packet packet;
490         struct sr_dev_inst *sdi;
491         struct timeval tv;
492
493         (void)fd;
494         (void)revents;
495
496         sdi = cb_data;
497
498         if (sdi->status == SR_ST_STOPPING) {
499                 usb_source_remove(sdi->session, drvc->sr_ctx);
500
501                 packet.type = SR_DF_END;
502                 sr_session_send(cb_data, &packet);
503         }
504
505         memset(&tv, 0, sizeof(struct timeval));
506         libusb_handle_events_timeout_completed(drvc->sr_ctx->libusb_ctx, &tv,
507                                                NULL);
508
509         return TRUE;
510 }
511
512 SR_PRIV void lascar_el_usb_receive_transfer(struct libusb_transfer *transfer)
513 {
514         struct dev_context *devc;
515         struct sr_dev_inst *sdi;
516         int ret;
517         gboolean packet_has_error;
518
519         sdi = transfer->user_data;
520         devc = sdi->priv;
521
522         packet_has_error = FALSE;
523         switch (transfer->status) {
524         case LIBUSB_TRANSFER_NO_DEVICE:
525                 /* USB device was unplugged. */
526                 dev_acquisition_stop(sdi, sdi);
527                 return;
528         case LIBUSB_TRANSFER_COMPLETED:
529         case LIBUSB_TRANSFER_TIMED_OUT: /* We may have received some data though */
530                 break;
531         default:
532                 packet_has_error = TRUE;
533                 break;
534         }
535
536         if (!packet_has_error) {
537                 if (devc->rcvd_samples < devc->logged_samples)
538                         lascar_el_usb_dispatch(sdi, transfer->buffer,
539                                         transfer->actual_length);
540                 devc->rcvd_bytes += transfer->actual_length;
541                 sr_spew("received %d/%d bytes (%d/%d samples)",
542                                 devc->rcvd_bytes, devc->log_size,
543                                 devc->rcvd_samples, devc->logged_samples);
544                 if (devc->rcvd_bytes >= devc->log_size)
545                         dev_acquisition_stop(sdi, sdi);
546         }
547
548         if (sdi->status == SR_ST_ACTIVE) {
549                 /* Send the same request again. */
550                 if ((ret = libusb_submit_transfer(transfer) != 0)) {
551                         sr_err("Unable to resubmit transfer: %s.",
552                                libusb_error_name(ret));
553                         g_free(transfer->buffer);
554                         libusb_free_transfer(transfer);
555                         dev_acquisition_stop(sdi, sdi);
556                 }
557         } else {
558                 /* This was the last transfer we're going to receive, so
559                  * clean up now. */
560                 g_free(transfer->buffer);
561                 libusb_free_transfer(transfer);
562         }
563
564 }
565
566 static int get_flags(unsigned char *configblock)
567 {
568         int flags;
569
570         flags = (configblock[32] | (configblock[33] << 8)) & 0x1fff;
571         sr_spew("Read flags (0x%.4x).", flags);
572
573         return flags;
574 }
575
576 static int set_flags(unsigned char *configblock, int flags)
577 {
578
579         sr_spew("Setting flags to 0x%.4x.", flags);
580         configblock[32] = flags & 0xff;
581         configblock[33] = (flags >> 8) & 0x1f;
582
583         return flags;
584 }
585
586 SR_PRIV int lascar_is_logging(const struct sr_dev_inst *sdi)
587 {
588         struct dev_context *devc;
589         struct sr_usb_dev_inst *usb;
590         int dummy, flags, ret;
591
592         devc = sdi->priv;
593         usb = sdi->conn;
594
595         if (lascar_get_config(usb->devhdl, devc->config, &dummy) != SR_OK)
596                 return -1;
597
598         flags = get_flags(devc->config);
599         if (flags & 0x0100)
600                 ret = 1;
601         else
602                 ret = 0;
603
604         return ret;
605 }
606
607 SR_PRIV int lascar_start_logging(const struct sr_dev_inst *sdi)
608 {
609         struct dev_context *devc;
610         struct sr_usb_dev_inst *usb;
611         int len, flags, ret;
612
613         devc = sdi->priv;
614         usb = sdi->conn;
615
616         if (lascar_get_config(usb->devhdl, devc->config, &len) != SR_OK)
617                 return SR_ERR;
618
619         /* Turn on logging. */
620         flags = get_flags(devc->config);
621         flags |= 0x0100;
622         set_flags(devc->config, flags);
623
624         /* Start logging in 0 seconds. */
625         memset(devc->config + 24, 0, 4);
626
627         ret = lascar_save_config(usb->devhdl, devc->config, len);
628         sr_info("Started internal logging.");
629
630         return ret;
631 }
632
633 SR_PRIV int lascar_stop_logging(const struct sr_dev_inst *sdi)
634 {
635         struct dev_context *devc;
636         struct sr_usb_dev_inst *usb;
637         int len, flags, ret;
638
639         devc = sdi->priv;
640         usb = sdi->conn;
641
642         if (lascar_get_config(usb->devhdl, devc->config, &len) != SR_OK)
643                 return SR_ERR;
644
645         flags = get_flags(devc->config);
646         flags &= ~0x0100;
647         set_flags(devc->config, flags);
648
649         ret = lascar_save_config(usb->devhdl, devc->config, len);
650         sr_info("Stopped internal logging.");
651
652         return ret;
653 }