src/hardware/hameg-hmo/api.c

   1 /*
   2  * This file is part of the libsigrok project.
   3  *
   4  * Copyright (C) 2013 poljar (Damir Jelić) <poljarinho@gmail.com>
   5  *
   6  * This program is free software: you can redistribute it and/or modify
   7  * it under the terms of the GNU General Public License as published by
   8  * the Free Software Foundation, either version 3 of the License, or
   9  * (at your option) any later version.
  10  *
  11  * This program is distributed in the hope that it will be useful,
  12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  14  * GNU General Public License for more details.
  15  *
  16  * You should have received a copy of the GNU General Public License
  17  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  18  */
  19
  20 #include <config.h>
  21 #include <stdlib.h>
  22 #include "scpi.h"
  23 #include "protocol.h"
  24
  25 #define SERIALCOMM "115200/8n1/flow=1"
  26
  27 static struct sr_dev_driver hameg_hmo_driver_info;
  28
  29 static const char *manufacturers[] = {
  30         "HAMEG",
  31         "Rohde&Schwarz",
  32 };
  33
  34 static const uint32_t scanopts[] = {
  35         SR_CONF_CONN,
  36         SR_CONF_SERIALCOMM,
  37 };
  38
  39 static const uint32_t drvopts[] = {
  40         SR_CONF_OSCILLOSCOPE,
  41 };
  42
  43 enum {
  44         CG_INVALID = -1,
  45         CG_NONE,
  46         CG_ANALOG,
  47         CG_DIGITAL,
  48 };
  49
  50 static int check_manufacturer(const char *manufacturer)
  51 {
  52         unsigned int i;
  53
  54         for (i = 0; i < ARRAY_SIZE(manufacturers); i++)
  55                 if (!strcmp(manufacturer, manufacturers[i]))
  56                         return SR_OK;
  57
  58         return SR_ERR;
  59 }
  60
  61 static struct sr_dev_inst *hmo_probe_serial_device(struct sr_scpi_dev_inst *scpi)
  62 {
  63         struct sr_dev_inst *sdi;
  64         struct dev_context *devc;
  65         struct sr_scpi_hw_info *hw_info;
  66
  67         sdi = NULL;
  68         devc = NULL;
  69         hw_info = NULL;
  70
  71         if (sr_scpi_get_hw_id(scpi, &hw_info) != SR_OK) {
  72                 sr_info("Couldn't get IDN response.");
  73                 goto fail;
  74         }
  75
  76         if (check_manufacturer(hw_info->manufacturer) != SR_OK)
  77                 goto fail;
  78
  79         sdi = g_malloc0(sizeof(struct sr_dev_inst));
  80         sdi->vendor = g_strdup(hw_info->manufacturer);
  81         sdi->model = g_strdup(hw_info->model);
  82         sdi->version = g_strdup(hw_info->firmware_version);
  83         sdi->serial_num = g_strdup(hw_info->serial_number);
  84         sdi->driver = &hameg_hmo_driver_info;
  85         sdi->inst_type = SR_INST_SCPI;
  86         sdi->conn = scpi;
  87
  88         sr_scpi_hw_info_free(hw_info);
  89         hw_info = NULL;
  90
  91         devc = g_malloc0(sizeof(struct dev_context));
  92
  93         sdi->priv = devc;
  94
  95         if (hmo_init_device(sdi) != SR_OK)
  96                 goto fail;
  97
  98         return sdi;
  99
 100 fail:
 101         sr_scpi_hw_info_free(hw_info);
 102         sr_dev_inst_free(sdi);
 103         g_free(devc);
 104
 105         return NULL;
 106 }
 107
 108 static GSList *scan(struct sr_dev_driver *di, GSList *options)
 109 {
 110         return sr_scpi_scan(di->context, options, hmo_probe_serial_device);
 111 }
 112
 113 static void clear_helper(struct dev_context *devc)
 114 {
 115         hmo_scope_state_free(devc->model_state);
 116         g_free(devc->analog_groups);
 117         g_free(devc->digital_groups);
 118 }
 119
 120 static int dev_clear(const struct sr_dev_driver *di)
 121 {
 122         return std_dev_clear_with_callback(di, (std_dev_clear_callback)clear_helper);
 123 }
 124
 125 static int dev_open(struct sr_dev_inst *sdi)
 126 {
 127         if (sr_scpi_open(sdi->conn) != SR_OK)
 128                 return SR_ERR;
 129
 130         if (hmo_scope_state_get(sdi) != SR_OK)
 131                 return SR_ERR;
 132
 133         return SR_OK;
 134 }
 135
 136 static int dev_close(struct sr_dev_inst *sdi)
 137 {
 138         return sr_scpi_close(sdi->conn);
 139 }
 140
 141 static int check_channel_group(struct dev_context *devc,
 142                              const struct sr_channel_group *cg)
 143 {
 144         unsigned int i;
 145         const struct scope_config *model;
 146
 147         model = devc->model_config;
 148
 149         if (!cg)
 150                 return CG_NONE;
 151
 152         for (i = 0; i < model->analog_channels; i++)
 153                 if (cg == devc->analog_groups[i])
 154                         return CG_ANALOG;
 155
 156         for (i = 0; i < model->digital_pods; i++)
 157                 if (cg == devc->digital_groups[i])
 158                         return CG_DIGITAL;
 159
 160         sr_err("Invalid channel group specified.");
 161
 162         return CG_INVALID;
 163 }
 164
 165 static int config_get(uint32_t key, GVariant **data,
 166         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 167 {
 168         int ret, cg_type;
 169         unsigned int i;
 170         struct dev_context *devc;
 171         const struct scope_config *model;
 172         struct scope_state *state;
 173
 174         if (!sdi)
 175                 return SR_ERR_ARG;
 176
 177         devc = sdi->priv;
 178
 179         if ((cg_type = check_channel_group(devc, cg)) == CG_INVALID)
 180                 return SR_ERR;
 181
 182         ret = SR_ERR_NA;
 183         model = devc->model_config;
 184         state = devc->model_state;
 185
 186         switch (key) {
 187         case SR_CONF_NUM_HDIV:
 188                 *data = g_variant_new_int32(model->num_xdivs);
 189                 ret = SR_OK;
 190                 break;
 191         case SR_CONF_TIMEBASE:
 192                 *data = g_variant_new("(tt)", (*model->timebases)[state->timebase][0],
 193                                       (*model->timebases)[state->timebase][1]);
 194                 ret = SR_OK;
 195                 break;
 196         case SR_CONF_NUM_VDIV:
 197                 if (cg_type == CG_NONE) {
 198                         return SR_ERR_CHANNEL_GROUP;
 199                 } else if (cg_type == CG_ANALOG) {
 200                         for (i = 0; i < model->analog_channels; i++) {
 201                                 if (cg != devc->analog_groups[i])
 202                                         continue;
 203                                 *data = g_variant_new_int32(model->num_ydivs);
 204                                 ret = SR_OK;
 205                                 break;
 206                         }
 207
 208                 } else {
 209                         ret = SR_ERR_NA;
 210                 }
 211                 break;
 212         case SR_CONF_VDIV:
 213                 if (cg_type == CG_NONE) {
 214                         return SR_ERR_CHANNEL_GROUP;
 215                 } else if (cg_type == CG_ANALOG) {
 216                         for (i = 0; i < model->analog_channels; i++) {
 217                                 if (cg != devc->analog_groups[i])
 218                                         continue;
 219                                 *data = g_variant_new("(tt)",
 220                                                       (*model->vdivs)[state->analog_channels[i].vdiv][0],
 221                                                       (*model->vdivs)[state->analog_channels[i].vdiv][1]);
 222                                 ret = SR_OK;
 223                                 break;
 224                         }
 225
 226                 } else {
 227                         ret = SR_ERR_NA;
 228                 }
 229                 break;
 230         case SR_CONF_TRIGGER_SOURCE:
 231                 *data = g_variant_new_string((*model->trigger_sources)[state->trigger_source]);
 232                 ret = SR_OK;
 233                 break;
 234         case SR_CONF_TRIGGER_SLOPE:
 235                 *data = g_variant_new_string((*model->trigger_slopes)[state->trigger_slope]);
 236                 ret = SR_OK;
 237                 break;
 238         case SR_CONF_HORIZ_TRIGGERPOS:
 239                 *data = g_variant_new_double(state->horiz_triggerpos);
 240                 ret = SR_OK;
 241                 break;
 242         case SR_CONF_COUPLING:
 243                 if (cg_type == CG_NONE) {
 244                         return SR_ERR_CHANNEL_GROUP;
 245                 } else if (cg_type == CG_ANALOG) {
 246                         for (i = 0; i < model->analog_channels; i++) {
 247                                 if (cg != devc->analog_groups[i])
 248                                         continue;
 249                                 *data = g_variant_new_string((*model->coupling_options)[state->analog_channels[i].coupling]);
 250                                 ret = SR_OK;
 251                                 break;
 252                         }
 253
 254                 } else {
 255                         ret = SR_ERR_NA;
 256                 }
 257                 break;
 258         case SR_CONF_SAMPLERATE:
 259                 *data = g_variant_new_uint64(state->sample_rate);
 260                 ret = SR_OK;
 261                 break;
 262         default:
 263                 ret = SR_ERR_NA;
 264         }
 265
 266         return ret;
 267 }
 268
 269 static int config_set(uint32_t key, GVariant *data,
 270         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 271 {
 272         int ret, cg_type;
 273         unsigned int i, j;
 274         char command[MAX_COMMAND_SIZE], float_str[30];
 275         struct dev_context *devc;
 276         const struct scope_config *model;
 277         struct scope_state *state;
 278         const char *tmp;
 279         uint64_t p, q;
 280         double tmp_d;
 281         gboolean update_sample_rate;
 282
 283         if (!sdi)
 284                 return SR_ERR_ARG;
 285
 286         devc = sdi->priv;
 287
 288         if ((cg_type = check_channel_group(devc, cg)) == CG_INVALID)
 289                 return SR_ERR;
 290
 291         model = devc->model_config;
 292         state = devc->model_state;
 293         update_sample_rate = FALSE;
 294
 295         ret = SR_ERR_NA;
 296
 297         switch (key) {
 298         case SR_CONF_LIMIT_FRAMES:
 299                 devc->frame_limit = g_variant_get_uint64(data);
 300                 ret = SR_OK;
 301                 break;
 302         case SR_CONF_TRIGGER_SOURCE:
 303                 tmp = g_variant_get_string(data, NULL);
 304                 for (i = 0; (*model->trigger_sources)[i]; i++) {
 305                         if (g_strcmp0(tmp, (*model->trigger_sources)[i]) != 0)
 306                                 continue;
 307                         state->trigger_source = i;
 308                         g_snprintf(command, sizeof(command),
 309                                    (*model->scpi_dialect)[SCPI_CMD_SET_TRIGGER_SOURCE],
 310                                    (*model->trigger_sources)[i]);
 311
 312                         ret = sr_scpi_send(sdi->conn, command);
 313                         break;
 314                 }
 315                 break;
 316         case SR_CONF_VDIV:
 317                 if (cg_type == CG_NONE)
 318                         return SR_ERR_CHANNEL_GROUP;
 319
 320                 g_variant_get(data, "(tt)", &p, &q);
 321
 322                 for (i = 0; i < model->num_vdivs; i++) {
 323                         if (p != (*model->vdivs)[i][0] ||
 324                             q != (*model->vdivs)[i][1])
 325                                 continue;
 326                         for (j = 1; j <= model->analog_channels; j++) {
 327                                 if (cg != devc->analog_groups[j - 1])
 328                                         continue;
 329                                 state->analog_channels[j - 1].vdiv = i;
 330                                 g_ascii_formatd(float_str, sizeof(float_str), "%E", (float) p / q);
 331                                 g_snprintf(command, sizeof(command),
 332                                            (*model->scpi_dialect)[SCPI_CMD_SET_VERTICAL_DIV],
 333                                            j, float_str);
 334
 335                                 if (sr_scpi_send(sdi->conn, command) != SR_OK ||
 336                                     sr_scpi_get_opc(sdi->conn) != SR_OK)
 337                                         return SR_ERR;
 338
 339                                 break;
 340                         }
 341
 342                         ret = SR_OK;
 343                         break;
 344                 }
 345                 break;
 346         case SR_CONF_TIMEBASE:
 347                 g_variant_get(data, "(tt)", &p, &q);
 348
 349                 for (i = 0; i < model->num_timebases; i++) {
 350                         if (p != (*model->timebases)[i][0] ||
 351                             q != (*model->timebases)[i][1])
 352                                 continue;
 353                         state->timebase = i;
 354                         g_ascii_formatd(float_str, sizeof(float_str), "%E", (float) p / q);
 355                         g_snprintf(command, sizeof(command),
 356                                    (*model->scpi_dialect)[SCPI_CMD_SET_TIMEBASE],
 357                                    float_str);
 358
 359                         ret = sr_scpi_send(sdi->conn, command);
 360                         update_sample_rate = TRUE;
 361                         break;
 362                 }
 363                 break;
 364         case SR_CONF_HORIZ_TRIGGERPOS:
 365                 tmp_d = g_variant_get_double(data);
 366
 367                 if (tmp_d < 0.0 || tmp_d > 1.0)
 368                         return SR_ERR;
 369
 370                 state->horiz_triggerpos = tmp_d;
 371                 tmp_d = -(tmp_d - 0.5) *
 372                         ((double) (*model->timebases)[state->timebase][0] /
 373                         (*model->timebases)[state->timebase][1])
 374                          * model->num_xdivs;
 375
 376                 g_ascii_formatd(float_str, sizeof(float_str), "%E", tmp_d);
 377                 g_snprintf(command, sizeof(command),
 378                            (*model->scpi_dialect)[SCPI_CMD_SET_HORIZ_TRIGGERPOS],
 379                            float_str);
 380
 381                 ret = sr_scpi_send(sdi->conn, command);
 382                 break;
 383         case SR_CONF_TRIGGER_SLOPE:
 384                 tmp = g_variant_get_string(data, NULL);
 385                 for (i = 0; (*model->trigger_slopes)[i]; i++) {
 386                         if (g_strcmp0(tmp, (*model->trigger_slopes)[i]) != 0)
 387                                 continue;
 388                         state->trigger_slope = i;
 389                         g_snprintf(command, sizeof(command),
 390                                    (*model->scpi_dialect)[SCPI_CMD_SET_TRIGGER_SLOPE],
 391                                    (*model->trigger_slopes)[i]);
 392
 393                         ret = sr_scpi_send(sdi->conn, command);
 394                         break;
 395                 }
 396                 break;
 397         case SR_CONF_COUPLING:
 398                 if (cg_type == CG_NONE)
 399                         return SR_ERR_CHANNEL_GROUP;
 400
 401                 tmp = g_variant_get_string(data, NULL);
 402
 403                 for (i = 0; (*model->coupling_options)[i]; i++) {
 404                         if (strcmp(tmp, (*model->coupling_options)[i]) != 0)
 405                                 continue;
 406                         for (j = 1; j <= model->analog_channels; j++) {
 407                                 if (cg != devc->analog_groups[j - 1])
 408                                         continue;
 409                                 state->analog_channels[j-1].coupling = i;
 410
 411                                 g_snprintf(command, sizeof(command),
 412                                            (*model->scpi_dialect)[SCPI_CMD_SET_COUPLING],
 413                                            j, tmp);
 414
 415                                 if (sr_scpi_send(sdi->conn, command) != SR_OK ||
 416                                     sr_scpi_get_opc(sdi->conn) != SR_OK)
 417                                         return SR_ERR;
 418                                 break;
 419                         }
 420
 421                         ret = SR_OK;
 422                         break;
 423                 }
 424                 break;
 425         default:
 426                 ret = SR_ERR_NA;
 427                 break;
 428         }
 429
 430         if (ret == SR_OK)
 431                 ret = sr_scpi_get_opc(sdi->conn);
 432
 433         if (ret == SR_OK && update_sample_rate)
 434                 ret = hmo_update_sample_rate(sdi);
 435
 436         return ret;
 437 }
 438
 439 static int config_list(uint32_t key, GVariant **data,
 440         const struct sr_dev_inst *sdi, const struct sr_channel_group *cg)
 441 {
 442         int cg_type = CG_NONE;
 443         struct dev_context *devc = NULL;
 444         const struct scope_config *model = NULL;
 445
 446         if (sdi) {
 447                 devc = sdi->priv;
 448                 if ((cg_type = check_channel_group(devc, cg)) == CG_INVALID)
 449                         return SR_ERR;
 450
 451                 model = devc->model_config;
 452         }
 453
 454         switch (key) {
 455         case SR_CONF_SCAN_OPTIONS:
 456                 *data = std_gvar_array_u32(ARRAY_AND_SIZE(scanopts));
 457                 break;
 458         case SR_CONF_DEVICE_OPTIONS:
 459                 if (cg_type == CG_NONE) {
 460                         if (model)
 461                                 *data = std_gvar_array_u32((const uint32_t *)model->devopts, model->num_devopts);
 462                         else
 463                                 *data = std_gvar_array_u32(ARRAY_AND_SIZE(drvopts));
 464                 } else if (cg_type == CG_ANALOG) {
 465                         *data = std_gvar_array_u32((const uint32_t *)model->devopts_cg_analog, model->num_devopts_cg_analog);
 466                 } else {
 467                         *data = std_gvar_array_u32(NULL, 0);
 468                 }
 469                 break;
 470         case SR_CONF_COUPLING:
 471                 if (cg_type == CG_NONE)
 472                         return SR_ERR_CHANNEL_GROUP;
 473                 *data = g_variant_new_strv(*model->coupling_options,
 474                            g_strv_length((char **)*model->coupling_options));
 475                 break;
 476         case SR_CONF_TRIGGER_SOURCE:
 477                 if (!model)
 478                         return SR_ERR_ARG;
 479                 *data = g_variant_new_strv(*model->trigger_sources,
 480                            g_strv_length((char **)*model->trigger_sources));
 481                 break;
 482         case SR_CONF_TRIGGER_SLOPE:
 483                 if (!model)
 484                         return SR_ERR_ARG;
 485                 *data = g_variant_new_strv(*model->trigger_slopes,
 486                            g_strv_length((char **)*model->trigger_slopes));
 487                 break;
 488         case SR_CONF_TIMEBASE:
 489                 if (!model)
 490                         return SR_ERR_ARG;
 491                 *data = std_gvar_tuple_array(*model->timebases, model->num_timebases);
 492                 break;
 493         case SR_CONF_VDIV:
 494                 if (cg_type == CG_NONE)
 495                         return SR_ERR_CHANNEL_GROUP;
 496                 *data = std_gvar_tuple_array(*model->vdivs, model->num_vdivs);
 497                 break;
 498         default:
 499                 return SR_ERR_NA;
 500         }
 501
 502         return SR_OK;
 503 }
 504
 505 SR_PRIV int hmo_request_data(const struct sr_dev_inst *sdi)
 506 {
 507         char command[MAX_COMMAND_SIZE];
 508         struct sr_channel *ch;
 509         struct dev_context *devc;
 510         const struct scope_config *model;
 511
 512         devc = sdi->priv;
 513         model = devc->model_config;
 514
 515         ch = devc->current_channel->data;
 516
 517         switch (ch->type) {
 518         case SR_CHANNEL_ANALOG:
 519                 g_snprintf(command, sizeof(command),
 520                            (*model->scpi_dialect)[SCPI_CMD_GET_ANALOG_DATA],
 521 #ifdef WORDS_BIGENDIAN
 522                            "MSBF",
 523 #else
 524                            "LSBF",
 525 #endif
 526                            ch->index + 1);
 527                 break;
 528         case SR_CHANNEL_LOGIC:
 529                 g_snprintf(command, sizeof(command),
 530                            (*model->scpi_dialect)[SCPI_CMD_GET_DIG_DATA],
 531                            ch->index < 8 ? 1 : 2);
 532                 break;
 533         default:
 534                 sr_err("Invalid channel type.");
 535                 break;
 536         }
 537
 538         return sr_scpi_send(sdi->conn, command);
 539 }
 540
 541 static int hmo_check_channels(GSList *channels)
 542 {
 543         GSList *l;
 544         struct sr_channel *ch;
 545         gboolean enabled_chan[MAX_ANALOG_CHANNEL_COUNT];
 546         gboolean enabled_pod[MAX_DIGITAL_GROUP_COUNT];
 547         size_t idx;
 548
 549         /* Preset "not enabled" for all channels / pods. */
 550         for (idx = 0; idx < ARRAY_SIZE(enabled_chan); idx++)
 551                 enabled_chan[idx] = FALSE;
 552         for (idx = 0; idx < ARRAY_SIZE(enabled_pod); idx++)
 553                 enabled_pod[idx] = FALSE;
 554
 555         /*
 556          * Determine which channels / pods are required for the caller's
 557          * specified configuration.
 558          */
 559         for (l = channels; l; l = l->next) {
 560                 ch = l->data;
 561                 switch (ch->type) {
 562                 case SR_CHANNEL_ANALOG:
 563                         idx = ch->index;
 564                         if (idx < ARRAY_SIZE(enabled_chan))
 565                                 enabled_chan[idx] = TRUE;
 566                         break;
 567                 case SR_CHANNEL_LOGIC:
 568                         idx = ch->index / 8;
 569                         if (idx < ARRAY_SIZE(enabled_pod))
 570                                 enabled_pod[idx] = TRUE;
 571                         break;
 572                 default:
 573                         return SR_ERR;
 574                 }
 575         }
 576
 577         /*
 578          * Check for resource conflicts. Some channels can be either
 579          * analog or digital, but never both at the same time.
 580          *
 581          * Note that the constraints might depend on the specific model.
 582          * These tests might need some adjustment when support for more
 583          * models gets added to the driver.
 584          */
 585         if (enabled_pod[0] && enabled_chan[2])
 586                 return SR_ERR;
 587         if (enabled_pod[1] && enabled_chan[3])
 588                 return SR_ERR;
 589         return SR_OK;
 590 }
 591
 592 static int hmo_setup_channels(const struct sr_dev_inst *sdi)
 593 {
 594         GSList *l;
 595         unsigned int i;
 596         gboolean *pod_enabled, setup_changed;
 597         char command[MAX_COMMAND_SIZE];
 598         struct scope_state *state;
 599         const struct scope_config *model;
 600         struct sr_channel *ch;
 601         struct dev_context *devc;
 602         struct sr_scpi_dev_inst *scpi;
 603
 604         devc = sdi->priv;
 605         scpi = sdi->conn;
 606         state = devc->model_state;
 607         model = devc->model_config;
 608         setup_changed = FALSE;
 609
 610         pod_enabled = g_try_malloc0(sizeof(gboolean) * model->digital_pods);
 611
 612         for (l = sdi->channels; l; l = l->next) {
 613                 ch = l->data;
 614                 switch (ch->type) {
 615                 case SR_CHANNEL_ANALOG:
 616                         if (ch->enabled == state->analog_channels[ch->index].state)
 617                                 break;
 618                         g_snprintf(command, sizeof(command),
 619                                    (*model->scpi_dialect)[SCPI_CMD_SET_ANALOG_CHAN_STATE],
 620                                    ch->index + 1, ch->enabled);
 621
 622                         if (sr_scpi_send(scpi, command) != SR_OK)
 623                                 return SR_ERR;
 624                         state->analog_channels[ch->index].state = ch->enabled;
 625                         setup_changed = TRUE;
 626                         break;
 627                 case SR_CHANNEL_LOGIC:
 628                         /*
 629                          * A digital POD needs to be enabled for every group of
 630                          * 8 channels.
 631                          */
 632                         if (ch->enabled)
 633                                 pod_enabled[ch->index < 8 ? 0 : 1] = TRUE;
 634
 635                         if (ch->enabled == state->digital_channels[ch->index])
 636                                 break;
 637                         g_snprintf(command, sizeof(command),
 638                                    (*model->scpi_dialect)[SCPI_CMD_SET_DIG_CHAN_STATE],
 639                                    ch->index, ch->enabled);
 640
 641                         if (sr_scpi_send(scpi, command) != SR_OK)
 642                                 return SR_ERR;
 643
 644                         state->digital_channels[ch->index] = ch->enabled;
 645                         setup_changed = TRUE;
 646                         break;
 647                 default:
 648                         return SR_ERR;
 649                 }
 650         }
 651
 652         for (i = 1; i <= model->digital_pods; i++) {
 653                 if (state->digital_pods[i - 1] == pod_enabled[i - 1])
 654                         continue;
 655                 g_snprintf(command, sizeof(command),
 656                            (*model->scpi_dialect)[SCPI_CMD_SET_DIG_POD_STATE],
 657                            i, pod_enabled[i - 1]);
 658                 if (sr_scpi_send(scpi, command) != SR_OK)
 659                         return SR_ERR;
 660                 state->digital_pods[i - 1] = pod_enabled[i - 1];
 661                 setup_changed = TRUE;
 662         }
 663
 664         g_free(pod_enabled);
 665
 666         if (setup_changed && hmo_update_sample_rate(sdi) != SR_OK)
 667                 return SR_ERR;
 668
 669         return SR_OK;
 670 }
 671
 672 static int dev_acquisition_start(const struct sr_dev_inst *sdi)
 673 {
 674         GSList *l;
 675         gboolean digital_added[MAX_DIGITAL_GROUP_COUNT];
 676         size_t group, pod_count;
 677         struct sr_channel *ch;
 678         struct dev_context *devc;
 679         struct sr_scpi_dev_inst *scpi;
 680         int ret;
 681
 682         scpi = sdi->conn;
 683         devc = sdi->priv;
 684
 685         /* Preset empty results. */
 686         for (group = 0; group < ARRAY_SIZE(digital_added); group++)
 687                 digital_added[group] = FALSE;
 688         g_slist_free(devc->enabled_channels);
 689         devc->enabled_channels = NULL;
 690
 691         /*
 692          * Contruct the list of enabled channels. Determine the highest
 693          * number of digital pods involved in the acquisition.
 694          */
 695         pod_count = 0;
 696         for (l = sdi->channels; l; l = l->next) {
 697                 ch = l->data;
 698                 if (!ch->enabled)
 699                         continue;
 700                 /* Only add a single digital channel per group (pod). */
 701                 group = ch->index / 8;
 702                 if (ch->type != SR_CHANNEL_LOGIC || !digital_added[group]) {
 703                         devc->enabled_channels = g_slist_append(
 704                                         devc->enabled_channels, ch);
 705                         if (ch->type == SR_CHANNEL_LOGIC) {
 706                                 digital_added[group] = TRUE;
 707                                 if (pod_count < group + 1)
 708                                         pod_count = group + 1;
 709                         }
 710                 }
 711         }
 712         if (!devc->enabled_channels)
 713                 return SR_ERR;
 714         devc->pod_count = pod_count;
 715         devc->logic_data = NULL;
 716
 717         /*
 718          * Check constraints. Some channels can be either analog or
 719          * digital, but not both at the same time.
 720          */
 721         if (hmo_check_channels(devc->enabled_channels) != SR_OK) {
 722                 sr_err("Invalid channel configuration specified!");
 723                 ret = SR_ERR_NA;
 724                 goto free_enabled;
 725         }
 726
 727         /*
 728          * Configure the analog and digital channels and the
 729          * corresponding digital pods.
 730          */
 731         if (hmo_setup_channels(sdi) != SR_OK) {
 732                 sr_err("Failed to setup channel configuration!");
 733                 ret = SR_ERR;
 734                 goto free_enabled;
 735         }
 736
 737         /*
 738          * Start acquisition on the first enabled channel. The
 739          * receive routine will continue driving the acquisition.
 740          */
 741         sr_scpi_source_add(sdi->session, scpi, G_IO_IN, 50,
 742                         hmo_receive_data, (void *)sdi);
 743
 744         std_session_send_df_header(sdi);
 745
 746         devc->current_channel = devc->enabled_channels;
 747
 748         return hmo_request_data(sdi);
 749
 750 free_enabled:
 751         g_slist_free(devc->enabled_channels);
 752         devc->enabled_channels = NULL;
 753         return ret;
 754 }
 755
 756 static int dev_acquisition_stop(struct sr_dev_inst *sdi)
 757 {
 758         struct dev_context *devc;
 759         struct sr_scpi_dev_inst *scpi;
 760
 761         std_session_send_df_end(sdi);
 762
 763         devc = sdi->priv;
 764
 765         devc->num_frames = 0;
 766         g_slist_free(devc->enabled_channels);
 767         devc->enabled_channels = NULL;
 768         scpi = sdi->conn;
 769         sr_scpi_source_remove(sdi->session, scpi);
 770
 771         return SR_OK;
 772 }
 773
 774 static struct sr_dev_driver hameg_hmo_driver_info = {
 775         .name = "hameg-hmo",
 776         .longname = "Hameg HMO",
 777         .api_version = 1,
 778         .init = std_init,
 779         .cleanup = std_cleanup,
 780         .scan = scan,
 781         .dev_list = std_dev_list,
 782         .dev_clear = dev_clear,
 783         .config_get = config_get,
 784         .config_set = config_set,
 785         .config_list = config_list,
 786         .dev_open = dev_open,
 787         .dev_close = dev_close,
 788         .dev_acquisition_start = dev_acquisition_start,
 789         .dev_acquisition_stop = dev_acquisition_stop,
 790         .context = NULL,
 791 };
 792 SR_REGISTER_DEV_DRIVER(hameg_hmo_driver_info);