]> sigrok.org Git - sigrok-cli.git/blobdiff - sigrok-cli.c
fix SR_DF_END flow
[sigrok-cli.git] / sigrok-cli.c
index a67970d10788b1246fdb3b7d6e8dd2e5b8feea1c..24fef94d05c396c346ae94e4220496f8c1b4f738 100644 (file)
@@ -332,7 +332,7 @@ static void show_dev_detail(void)
 
        print_dev_line(sdi);
 
-       if (sr_info_get(sdi->driver, SR_DI_TRIGGER_TYPES, (const void **)&charopts,
+       if (sr_config_list(sdi->driver, SR_CONF_TRIGGER_TYPE, (const void **)&charopts,
                        sdi) == SR_OK && charopts) {
                printf("Supported triggers: ");
                while (*charopts) {
@@ -342,7 +342,7 @@ static void show_dev_detail(void)
                printf("\n");
        }
 
-       if ((sr_info_get(sdi->driver, SR_DI_HWOPTS, (const void **)&hwopts,
+       if ((sr_config_list(sdi->driver, SR_CONF_SCAN_OPTIONS, (const void **)&hwopts,
                        NULL) == SR_OK) && hwopts) {
                printf("Supported driver options:\n");
                for (i = 0; hwopts[i]; i++) {
@@ -353,7 +353,7 @@ static void show_dev_detail(void)
        }
 
        title = "Supported device options:\n";
-       if ((sr_info_get(sdi->driver, SR_DI_HWCAPS, (const void **)&hwcaps,
+       if ((sr_config_list(sdi->driver, SR_CONF_DEVICE_OPTIONS, (const void **)&hwcaps,
                        NULL) != SR_OK) || !hwcaps)
                /* Driver supports no device instance options. */
                return;
@@ -370,7 +370,7 @@ static void show_dev_detail(void)
                if (srci->key == SR_CONF_PATTERN_MODE) {
                        /* Pattern generator modes */
                        printf("    %s", srci->id);
-                       if (sr_info_get(sdi->driver, SR_DI_PATTERNS,
+                       if (sr_config_list(sdi->driver, SR_CONF_PATTERN_MODE,
                                        (const void **)&stropts, sdi) == SR_OK) {
                                printf(" - supported patterns:\n");
                                for (i = 0; stropts[i]; i++)
@@ -412,7 +412,7 @@ static void show_dev_detail(void)
                } else if (srci->key == SR_CONF_BUFFERSIZE) {
                        /* Supported buffer sizes */
                        printf("    %s", srci->id);
-                       if (sr_info_get(sdi->driver, SR_DI_BUFFERSIZES,
+                       if (sr_config_list(sdi->driver, SR_CONF_BUFFERSIZE,
                                        (const void **)&integers, sdi) != SR_OK) {
                                printf("\n");
                                continue;
@@ -424,7 +424,7 @@ static void show_dev_detail(void)
                } else if (srci->key == SR_CONF_TIMEBASE) {
                        /* Supported time bases */
                        printf("    %s", srci->id);
-                       if (sr_info_get(sdi->driver, SR_DI_TIMEBASES,
+                       if (sr_config_list(sdi->driver, SR_CONF_TIMEBASE,
                                        (const void **)&rationals, sdi) != SR_OK) {
                                printf("\n");
                                continue;
@@ -437,7 +437,7 @@ static void show_dev_detail(void)
                } else if (srci->key == SR_CONF_TRIGGER_SOURCE) {
                        /* Supported trigger sources */
                        printf("    %s", srci->id);
-                       if (sr_info_get(sdi->driver, SR_DI_TRIGGER_SOURCES,
+                       if (sr_config_list(sdi->driver, SR_CONF_TRIGGER_SOURCE,
                                        (const void **)&stropts, sdi) != SR_OK) {
                                printf("\n");
                                continue;
@@ -449,7 +449,7 @@ static void show_dev_detail(void)
                } else if (srci->key == SR_CONF_FILTER) {
                        /* Supported filters */
                        printf("    %s", srci->id);
-                       if (sr_info_get(sdi->driver, SR_DI_FILTERS,
+                       if (sr_config_list(sdi->driver, SR_CONF_FILTER,
                                        (const void **)&stropts, sdi) != SR_OK) {
                                printf("\n");
                                continue;
@@ -461,7 +461,7 @@ static void show_dev_detail(void)
                } else if (srci->key == SR_CONF_VDIV) {
                        /* Supported volts/div values */
                        printf("    %s", srci->id);
-                       if (sr_info_get(sdi->driver, SR_DI_VDIVS,
+                       if (sr_config_list(sdi->driver, SR_CONF_VDIV,
                                        (const void **)&rationals, sdi) != SR_OK) {
                                printf("\n");
                                continue;
@@ -473,7 +473,7 @@ static void show_dev_detail(void)
                } else if (srci->key == SR_CONF_COUPLING) {
                        /* Supported coupling settings */
                        printf("    %s", srci->id);
-                       if (sr_info_get(sdi->driver, SR_DI_COUPLING,
+                       if (sr_config_list(sdi->driver, SR_CONF_COUPLING,
                                        (const void **)&stropts, sdi) != SR_OK) {
                                printf("\n");
                                continue;
@@ -629,7 +629,7 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
                unitsize = (logic_probelist->len + 7) / 8;
 
                if (opt_pds && logic_probelist->len) {
-                       if (sr_info_get(sdi->driver, SR_DI_CUR_SAMPLERATE,
+                       if (sr_config_get(sdi->driver, SR_CONF_SAMPLERATE,
                                        (const void **)&samplerate, sdi) != SR_OK) {
                                g_critical("Unable to initialize protocol "
                                                "decoders: no samplerate found.");
@@ -640,45 +640,6 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
                }
                break;
 
-       case SR_DF_END:
-               g_debug("cli: Received SR_DF_END");
-               if (!o) {
-                       g_debug("cli: double end!");
-                       break;
-               }
-               if (o->format->event) {
-                       o->format->event(o, SR_DF_END, &output_buf, &output_len);
-                       if (output_buf) {
-                               if (outfile)
-                                       fwrite(output_buf, 1, output_len, outfile);
-                               g_free(output_buf);
-                               output_len = 0;
-                       }
-               }
-               if (limit_samples && received_samples < limit_samples)
-                       g_warning("Device only sent %" PRIu64 " samples.",
-                              received_samples);
-               if (opt_continuous)
-                       g_warning("Device stopped after %" PRIu64 " samples.",
-                              received_samples);
-
-               if (outfile && outfile != stdout)
-                       fclose(outfile);
-
-               if (opt_output_file && default_output_format) {
-                       if (sr_session_save(opt_output_file, sdi, savebuf->data,
-                                       unitsize, savebuf->len / unitsize) != SR_OK)
-                               g_critical("Failed to save session.");
-                       g_byte_array_free(savebuf, FALSE);
-               }
-
-               g_array_free(logic_probelist, TRUE);
-               if (o->format->cleanup)
-                       o->format->cleanup(o);
-               g_free(o);
-               o = NULL;
-               break;
-
        case SR_DF_META:
                g_debug("cli: received SR_DF_META");
                meta = packet->payload;
@@ -746,7 +707,7 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
                                if (o->format->data && packet->type == o->format->df_type)
                                        o->format->data(o, filter_out, filter_out_len,
                                                        &output_buf, &output_len);
-                               if (output_buf) {
+                               if (output_len) {
                                        fwrite(output_buf, 1, output_len, outfile);
                                        fflush(outfile);
                                        g_free(output_buf);
@@ -819,6 +780,47 @@ static void datafeed_in(const struct sr_dev_inst *sdi,
                }
        }
 
+       /* SR_DF_END needs to be handled after the output module's recv()
+        * is called, so it can properly clean up that module etc. */
+       if (packet->type == SR_DF_END) {
+               g_debug("cli: Received SR_DF_END");
+
+               if (o->format->event) {
+                       o->format->event(o, SR_DF_END, &output_buf, &output_len);
+                       if (output_buf) {
+                               if (outfile)
+                                       fwrite(output_buf, 1, output_len, outfile);
+                               g_free(output_buf);
+                               output_len = 0;
+                       }
+               }
+
+               if (limit_samples && received_samples < limit_samples)
+                       g_warning("Device only sent %" PRIu64 " samples.",
+                              received_samples);
+
+               if (opt_continuous)
+                       g_warning("Device stopped after %" PRIu64 " samples.",
+                              received_samples);
+
+               g_array_free(logic_probelist, TRUE);
+
+               if (o->format->cleanup)
+                       o->format->cleanup(o);
+               g_free(o);
+               o = NULL;
+
+               if (outfile && outfile != stdout)
+                       fclose(outfile);
+
+               if (opt_output_file && default_output_format) {
+                       if (sr_session_save(opt_output_file, sdi, savebuf->data,
+                                       unitsize, savebuf->len / unitsize) != SR_OK)
+                               g_critical("Failed to save session.");
+                       g_byte_array_free(savebuf, FALSE);
+               }
+       }
+
 }
 
 /* Register the given PDs for this session.
@@ -1189,7 +1191,7 @@ static void load_input_file_format(void)
        in->format = input_format;
        in->param = fmtargs;
        if (in->format->init) {
-               if (in->format->init(in) != SR_OK) {
+               if (in->format->init(in, opt_input_file) != SR_OK) {
                        g_critical("Input format init failed.");
                        exit(1);
                }
@@ -1290,7 +1292,7 @@ static int set_dev_options(struct sr_dev_inst *sdi, GHashTable *args)
                        ret = SR_ERR;
                }
                if (val)
-                       ret = sr_dev_config_set(sdi, srci->key, val);
+                       ret = sr_config_set(sdi, srci->key, val);
                if (ret != SR_OK) {
                        g_critical("Failed to set device option '%s'.", (char *)key);
                        return ret;
@@ -1312,8 +1314,8 @@ static int set_limit_time(const struct sr_dev_inst *sdi)
                return SR_ERR;
        }
 
-       if (sr_driver_hwcap_exists(sdi->driver, SR_CONF_LIMIT_MSEC)) {
-               if (sr_dev_config_set(sdi, SR_CONF_LIMIT_MSEC, &time_msec) != SR_OK) {
+       if (sr_dev_has_option(sdi, SR_CONF_LIMIT_MSEC)) {
+               if (sr_config_set(sdi, SR_CONF_LIMIT_MSEC, &time_msec) != SR_OK) {
                        g_critical("Failed to configure time limit.");
                        sr_session_destroy();
                        return SR_ERR;
@@ -1324,8 +1326,8 @@ static int set_limit_time(const struct sr_dev_inst *sdi)
                 * convert to samples based on the samplerate.
                 */
                limit_samples = 0;
-               if (sr_dev_has_hwcap(sdi, SR_CONF_SAMPLERATE)) {
-                       sr_info_get(sdi->driver, SR_DI_CUR_SAMPLERATE,
+               if (sr_dev_has_option(sdi, SR_CONF_SAMPLERATE)) {
+                       sr_config_get(sdi->driver, SR_CONF_SAMPLERATE,
                                        (const void **)&samplerate, sdi);
                        limit_samples = (*samplerate) * time_msec / (uint64_t)1000;
                }
@@ -1335,7 +1337,7 @@ static int set_limit_time(const struct sr_dev_inst *sdi)
                        return SR_ERR;
                }
 
-               if (sr_dev_config_set(sdi, SR_CONF_LIMIT_SAMPLES,
+               if (sr_config_set(sdi, SR_CONF_LIMIT_SAMPLES,
                                        &limit_samples) != SR_OK) {
                        g_critical("Failed to configure time-based sample limit.");
                        sr_session_destroy();
@@ -1404,7 +1406,7 @@ static void run_session(void)
        }
 
        if (opt_continuous) {
-               if (!sr_driver_hwcap_exists(sdi->driver, SR_CONF_CONTINUOUS)) {
+               if (!sr_dev_has_option(sdi, SR_CONF_CONTINUOUS)) {
                        g_critical("This device does not support continuous sampling.");
                        sr_session_destroy();
                        return;
@@ -1420,7 +1422,7 @@ static void run_session(void)
 
        if (opt_samples) {
                if ((sr_parse_sizestring(opt_samples, &limit_samples) != SR_OK)
-                               || (sr_dev_config_set(sdi, SR_CONF_LIMIT_SAMPLES,
+                               || (sr_config_set(sdi, SR_CONF_LIMIT_SAMPLES,
                                                &limit_samples) != SR_OK)) {
                        g_critical("Failed to configure sample limit.");
                        sr_session_destroy();
@@ -1430,7 +1432,7 @@ static void run_session(void)
 
        if (opt_frames) {
                if ((sr_parse_sizestring(opt_frames, &limit_frames) != SR_OK)
-                               || (sr_dev_config_set(sdi, SR_CONF_LIMIT_FRAMES,
+                               || (sr_config_set(sdi, SR_CONF_LIMIT_FRAMES,
                                                &limit_frames) != SR_OK)) {
                        g_critical("Failed to configure frame limit.");
                        sr_session_destroy();