Remove unreasonable test

[libsigrokdecode.git] / tests / check_decoder.c

diff --git a/tests/check_decoder.c b/tests/check_decoder.c
index 0b46348b70dc60419ebb50bea10d3a6469cf5876..e84658517ca42347d99a0c758b5720ad4f44ea6c 100644 (file)
--- a/tests/check_decoder.c
+++ b/tests/check_decoder.c
@@ -57,7 +57,7 @@ START_TEST(test_load_all_no_init)
        int ret;
 
        ret = srd_decoder_load_all();
-       fail_unless(ret == SRD_OK, "srd_decoder_load_all() failed: %d.", ret);
+       fail_unless(ret != SRD_OK, "srd_decoder_load_all() didn't fail properly.");
 }
 END_TEST
 
@@ -307,25 +307,7 @@ END_TEST
 START_TEST(test_doc_get_null)
 {
        srd_init(NULL);
-       fail_unless(srd_decoder_doc_get(NULL) != NULL);
-       srd_exit();
-}
-END_TEST
-
-/*
- * Check whether srd_decoder_doc_get() fails with an "empty" argument.
- * If it returns a value != NULL (or segfaults) this test will fail.
- * See also: http://sigrok.org/bugzilla/show_bug.cgi?id=180
- */
-START_TEST(test_doc_get_empty)
-{
-       struct srd_decoder dec;
-
-       srd_init(NULL);
-
-       memset(&dec, 0, sizeof(struct srd_decoder));
-       fail_unless(srd_decoder_doc_get(&dec) == NULL);
-
+       fail_unless(srd_decoder_doc_get(NULL) == NULL);
        srd_exit();
 }
 END_TEST
@@ -366,7 +348,6 @@ Suite *suite_decoder(void)
        tc = tcase_create("doc_get");
        tcase_add_test(tc, test_doc_get);
        tcase_add_test(tc, test_doc_get_null);
-       tcase_add_test(tc, test_doc_get_empty);
        suite_add_tcase(s, tc);
 
        return s;