]> sigrok.org Git - libsigrokdecode.git/blame - controller.c
Don't release borrowed reference
[libsigrokdecode.git] / controller.c
CommitLineData
b2c19614 1/*
50bd5d25 2 * This file is part of the libsigrokdecode project.
b2c19614
BV
3 *
4 * Copyright (C) 2010 Uwe Hermann <uwe@hermann-uwe.de>
bc5f5a43 5 * Copyright (C) 2012 Bert Vermeulen <bert@biot.com>
b2c19614
BV
6 *
7 * This program is free software: you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation, either version 3 of the License, or
10 * (at your option) any later version.
11 *
12 * This program is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 * GNU General Public License for more details.
16 *
17 * You should have received a copy of the GNU General Public License
18 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 */
20
c1f86f02
UH
21#include "libsigrokdecode.h" /* First, so we avoid a _POSIX_C_SOURCE warning. */
22#include "libsigrokdecode-internal.h"
7ce7775c 23#include "config.h"
b2c19614 24#include <glib.h>
1aef2f93 25#include <inttypes.h>
0bdadba2 26#include <stdlib.h>
32cfb920 27#include <stdint.h>
b2c19614 28
d7dae84b
UH
29/**
30 * @mainpage libsigrokdecode API
31 *
32 * @section sec_intro Introduction
33 *
34 * The <a href="http://sigrok.org">sigrok</a> project aims at creating a
35 * portable, cross-platform, Free/Libre/Open-Source signal analysis software
36 * suite that supports various device types (such as logic analyzers,
37 * oscilloscopes, multimeters, and more).
38 *
39 * <a href="http://sigrok.org/wiki/Libsigrokdecode">libsigrokdecode</a> is a
40 * shared library written in C which provides the basic API for (streaming)
41 * protocol decoding functionality.
42 *
43 * The <a href="http://sigrok.org/wiki/Protocol_decoders">protocol decoders</a>
44 * are written in Python (>= 3.0).
45 *
46 * @section sec_api API reference
47 *
48 * See the "Modules" page for an introduction to various libsigrokdecode
49 * related topics and the detailed API documentation of the respective
50 * functions.
51 *
52 * You can also browse the API documentation by file, or review all
53 * data structures.
54 *
55 * @section sec_mailinglists Mailing lists
56 *
57 * There are two mailing lists for sigrok/libsigrokdecode: <a href="https://lists.sourceforge.net/lists/listinfo/sigrok-devel">sigrok-devel</a> and <a href="https://lists.sourceforge.net/lists/listinfo/sigrok-commits">sigrok-commits</a>.
58 *
59 * @section sec_irc IRC
60 *
61 * You can find the sigrok developers in the
62 * <a href="irc://chat.freenode.net/sigrok">\#sigrok</a>
63 * IRC channel on Freenode.
64 *
65 * @section sec_website Website
66 *
67 * <a href="http://sigrok.org/wiki/Libsigrokdecode">sigrok.org/wiki/Libsigrokdecode</a>
68 */
69
70/**
71 * @file
72 *
73 * Initializing and shutting down libsigrokdecode.
74 */
75
76/**
77 * @defgroup grp_init Initialization
78 *
79 * Initializing and shutting down libsigrokdecode.
80 *
81 * Before using any of the libsigrokdecode functionality, srd_init() must
82 * be called to initialize the library.
83 *
84 * When libsigrokdecode functionality is no longer needed, srd_exit() should
85 * be called.
86 *
87 * @{
88 */
89
32cfb920 90/** @cond PRIVATE */
d906d3f9 91
32cfb920
BV
92SRD_PRIV GSList *sessions = NULL;
93static int max_session_id = -1;
983cb0f5 94
32cfb920 95static int session_is_valid(struct srd_session *sess);
57790bc8 96
c9bfccc6 97/* decoder.c */
55c3c5f4 98extern SRD_PRIV GSList *pd_list;
b2c19614 99
c9bfccc6 100/* module_sigrokdecode.c */
53a07a6d 101extern PyMODINIT_FUNC PyInit_sigrokdecode(void);
b2c19614 102
c9bfccc6 103/* type_logic.c */
55c3c5f4 104extern SRD_PRIV PyTypeObject srd_logic_type;
b2c19614 105
57790bc8
UH
106/** @endcond */
107
b2c19614
BV
108/**
109 * Initialize libsigrokdecode.
110 *
111 * This initializes the Python interpreter, and creates and initializes
361fdcaa 112 * a "sigrokdecode" Python module.
b2c19614 113 *
4cc0d9fe
UH
114 * Then, it searches for sigrok protocol decoders in the "decoders"
115 * subdirectory of the the libsigrokdecode installation directory.
b2c19614 116 * All decoders that are found are loaded into memory and added to an
4cc0d9fe 117 * internal list of decoders, which can be queried via srd_decoder_list().
b2c19614
BV
118 *
119 * The caller is responsible for calling the clean-up function srd_exit(),
120 * which will properly shut down libsigrokdecode and free its allocated memory.
121 *
7ce7775c 122 * Multiple calls to srd_init(), without calling srd_exit() in between,
b2c19614
BV
123 * are not allowed.
124 *
65e1c7d0 125 * @param path Path to an extra directory containing protocol decoders
4cc0d9fe 126 * which will be added to the Python sys.path. May be NULL.
65e1c7d0 127 *
b2c19614 128 * @return SRD_OK upon success, a (negative) error code otherwise.
4cc0d9fe
UH
129 * Upon Python errors, SRD_ERR_PYTHON is returned. If the decoders
130 * directory cannot be accessed, SRD_ERR_DECODERS_DIR is returned.
131 * If not enough memory could be allocated, SRD_ERR_MALLOC is returned.
8c664ca2
UH
132 *
133 * @since 0.1.0
b2c19614 134 */
abeeed8b 135SRD_API int srd_init(const char *path)
b2c19614
BV
136{
137 int ret;
65e1c7d0 138 char *env_path;
b2c19614 139
32cfb920
BV
140 if (max_session_id != -1) {
141 srd_err("libsigrokdecode is already initialized.");
142 return SRD_ERR;
143 }
144
7a1712c4 145 srd_dbg("Initializing libsigrokdecode.");
d906d3f9
BV
146
147 /* Add our own module to the list of built-in modules. */
bc5f5a43 148 PyImport_AppendInittab("sigrokdecode", PyInit_sigrokdecode);
5f802ec6 149
511e2123 150 /* Initialize the Python interpreter. */
b2c19614
BV
151 Py_Initialize();
152
65e1c7d0 153 /* Installed decoders. */
aafeeaea 154 if ((ret = srd_decoder_searchpath_add(DECODERS_DIR)) != SRD_OK) {
b2c19614
BV
155 Py_Finalize();
156 return ret;
157 }
158
65e1c7d0
BV
159 /* Path specified by the user. */
160 if (path) {
aafeeaea 161 if ((ret = srd_decoder_searchpath_add(path)) != SRD_OK) {
65e1c7d0
BV
162 Py_Finalize();
163 return ret;
164 }
165 }
166
167 /* Environment variable overrides everything, for debugging. */
168 if ((env_path = getenv("SIGROKDECODE_DIR"))) {
aafeeaea 169 if ((ret = srd_decoder_searchpath_add(env_path)) != SRD_OK) {
65e1c7d0
BV
170 Py_Finalize();
171 return ret;
172 }
173 }
174
32cfb920
BV
175 max_session_id = 0;
176
b2c19614
BV
177 return SRD_OK;
178}
179
b2c19614
BV
180/**
181 * Shutdown libsigrokdecode.
182 *
183 * This frees all the memory allocated for protocol decoders and shuts down
184 * the Python interpreter.
185 *
186 * This function should only be called if there was a (successful!) invocation
187 * of srd_init() before. Calling this function multiple times in a row, without
7ce7775c 188 * any successful srd_init() calls in between, is not allowed.
b2c19614
BV
189 *
190 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
191 *
192 * @since 0.1.0
b2c19614 193 */
55c3c5f4 194SRD_API int srd_exit(void)
b2c19614 195{
32cfb920
BV
196 GSList *l;
197
7a1712c4 198 srd_dbg("Exiting libsigrokdecode.");
d906d3f9 199
32cfb920
BV
200 for (l = sessions; l; l = l->next)
201 srd_session_destroy((struct srd_session *)l->data);
202
8ad6e500 203 srd_decoder_unload_all();
e5080882 204 g_slist_free(pd_list);
96c52595 205 pd_list = NULL;
b2c19614
BV
206
207 /* Py_Finalize() returns void, any finalization errors are ignored. */
208 Py_Finalize();
209
32cfb920
BV
210 max_session_id = -1;
211
b2c19614
BV
212 return SRD_OK;
213}
214
b2c19614 215/**
9d9fcb37
UH
216 * Add an additional search directory for the protocol decoders.
217 *
218 * The specified directory is prepended (not appended!) to Python's sys.path,
219 * in order to search for sigrok protocol decoders in the specified
220 * directories first, and in the generic Python module directories (and in
221 * the current working directory) last. This avoids conflicts if there are
222 * Python modules which have the same name as a sigrok protocol decoder in
223 * sys.path or in the current working directory.
b2c19614 224 *
361fdcaa
UH
225 * @param path Path to the directory containing protocol decoders which shall
226 * be added to the Python sys.path, or NULL.
9d9fcb37 227 *
65e1c7d0 228 * @return SRD_OK upon success, a (negative) error code otherwise.
57790bc8
UH
229 *
230 * @private
8c664ca2
UH
231 *
232 * @since 0.1.0
b2c19614 233 */
aafeeaea 234SRD_PRIV int srd_decoder_searchpath_add(const char *path)
b2c19614 235{
65e1c7d0
BV
236 PyObject *py_cur_path, *py_item;
237 GString *new_path;
238 int wc_len, i;
239 wchar_t *wc_new_path;
240 char *item;
241
8ad6e500 242 srd_dbg("Adding '%s' to module path.", path);
65e1c7d0
BV
243
244 new_path = g_string_sized_new(256);
e592ac89 245 g_string_assign(new_path, path);
65e1c7d0
BV
246 py_cur_path = PySys_GetObject("path");
247 for (i = 0; i < PyList_Size(py_cur_path); i++) {
e592ac89 248 g_string_append(new_path, G_SEARCHPATH_SEPARATOR_S);
65e1c7d0
BV
249 py_item = PyList_GetItem(py_cur_path, i);
250 if (!PyUnicode_Check(py_item))
251 /* Shouldn't happen. */
252 continue;
253 if (py_str_as_str(py_item, &item) != SRD_OK)
254 continue;
255 g_string_append(new_path, item);
e592ac89 256 g_free(item);
65e1c7d0 257 }
639c5689 258
65e1c7d0
BV
259 /* Convert to wide chars. */
260 wc_len = sizeof(wchar_t) * (new_path->len + 1);
261 if (!(wc_new_path = g_try_malloc(wc_len))) {
262 srd_dbg("malloc failed");
263 return SRD_ERR_MALLOC;
264 }
265 mbstowcs(wc_new_path, new_path->str, wc_len);
266 PySys_SetPath(wc_new_path);
267 g_string_free(new_path, TRUE);
268 g_free(wc_new_path);
269
65e1c7d0 270 return SRD_OK;
b2c19614
BV
271}
272
4895418c
UH
273/** @} */
274
275/**
276 * @defgroup grp_instances Decoder instances
277 *
278 * Decoder instance handling.
279 *
280 * @{
281 */
282
7ce7775c 283/**
b33b8aa5 284 * Set one or more options in a decoder instance.
0bdadba2 285 *
361fdcaa
UH
286 * Handled options are removed from the hash.
287 *
0bdadba2
BV
288 * @param di Decoder instance.
289 * @param options A GHashTable of options to set.
7ce7775c 290 *
0bdadba2 291 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
292 *
293 * @since 0.1.0
0bdadba2 294 */
b33b8aa5 295SRD_API int srd_inst_option_set(struct srd_decoder_inst *di,
0ff2d191 296 GHashTable *options)
0bdadba2
BV
297{
298 PyObject *py_dec_options, *py_dec_optkeys, *py_di_options, *py_optval;
299 PyObject *py_optlist, *py_classval;
300 Py_UNICODE *py_ustr;
2f395bff 301 GVariant *value;
0bdadba2 302 unsigned long long int val_ull;
2f395bff 303 gint64 val_int;
0bdadba2 304 int num_optkeys, ret, size, i;
2f395bff
BV
305 const char *val_str;
306 char *dbg, *key;
0bdadba2 307
c9bfccc6 308 if (!PyObject_HasAttrString(di->decoder->py_dec, "options")) {
0bdadba2 309 /* Decoder has no options. */
e431d9cc
BV
310 if (g_hash_table_size(options) == 0) {
311 /* No options provided. */
312 return SRD_OK;
313 } else {
314 srd_err("Protocol decoder has no options.");
315 return SRD_ERR_ARG;
316 }
0bdadba2 317 return SRD_OK;
e431d9cc 318 }
0bdadba2
BV
319
320 ret = SRD_ERR_PYTHON;
321 key = NULL;
322 py_dec_options = py_dec_optkeys = py_di_options = py_optval = NULL;
323 py_optlist = py_classval = NULL;
324 py_dec_options = PyObject_GetAttrString(di->decoder->py_dec, "options");
0bdadba2
BV
325
326 /* All of these are synthesized objects, so they're good. */
327 py_dec_optkeys = PyDict_Keys(py_dec_options);
328 num_optkeys = PyList_Size(py_dec_optkeys);
a8b72b05 329 if (!(py_di_options = PyObject_GetAttrString(di->py_inst, "options")))
0bdadba2
BV
330 goto err_out;
331 for (i = 0; i < num_optkeys; i++) {
332 /* Get the default class value for this option. */
333 py_str_as_str(PyList_GetItem(py_dec_optkeys, i), &key);
334 if (!(py_optlist = PyDict_GetItemString(py_dec_options, key)))
335 goto err_out;
336 if (!(py_classval = PyList_GetItem(py_optlist, 1)))
337 goto err_out;
130ef08a 338 if (!PyUnicode_Check(py_classval) && !PyLong_Check(py_classval)) {
c9bfccc6
UH
339 srd_err("Options of type %s are not yet supported.",
340 Py_TYPE(py_classval)->tp_name);
130ef08a
BV
341 goto err_out;
342 }
0bdadba2
BV
343
344 if ((value = g_hash_table_lookup(options, key))) {
2f395bff
BV
345 dbg = g_variant_print(value, TRUE);
346 srd_dbg("got option '%s' = %s", key, dbg);
347 g_free(dbg);
0bdadba2
BV
348 /* An override for this option was provided. */
349 if (PyUnicode_Check(py_classval)) {
2f395bff
BV
350 if (!g_variant_is_of_type(value, G_VARIANT_TYPE_STRING)) {
351 srd_err("Option '%s' requires a string value.", key);
352 goto err_out;
353 }
354 val_str = g_variant_get_string(value, NULL);
355 if (!(py_optval = PyUnicode_FromString(val_str))) {
0bdadba2
BV
356 /* Some UTF-8 encoding error. */
357 PyErr_Clear();
2f395bff 358 srd_err("Option '%s' requires a UTF-8 string value.", key);
0bdadba2
BV
359 goto err_out;
360 }
361 } else if (PyLong_Check(py_classval)) {
2f395bff
BV
362 if (!g_variant_is_of_type(value, G_VARIANT_TYPE_INT64)) {
363 srd_err("Option '%s' requires an integer value.", key);
364 goto err_out;
365 }
366 val_int = g_variant_get_int64(value);
367 if (!(py_optval = PyLong_FromLong(val_int))) {
0bdadba2
BV
368 /* ValueError Exception */
369 PyErr_Clear();
2f395bff 370 srd_err("Option '%s' has invalid integer value.", key);
0bdadba2
BV
371 goto err_out;
372 }
373 }
374 g_hash_table_remove(options, key);
375 } else {
376 /* Use the class default for this option. */
377 if (PyUnicode_Check(py_classval)) {
378 /* Make a brand new copy of the string. */
379 py_ustr = PyUnicode_AS_UNICODE(py_classval);
380 size = PyUnicode_GET_SIZE(py_classval);
381 py_optval = PyUnicode_FromUnicode(py_ustr, size);
382 } else if (PyLong_Check(py_classval)) {
383 /* Make a brand new copy of the integer. */
384 val_ull = PyLong_AsUnsignedLongLong(py_classval);
385 if (val_ull == (unsigned long long)-1) {
386 /* OverFlowError exception */
387 PyErr_Clear();
c9bfccc6
UH
388 srd_err("Invalid integer value for %s: "
389 "expected integer.", key);
0bdadba2
BV
390 goto err_out;
391 }
392 if (!(py_optval = PyLong_FromUnsignedLongLong(val_ull)))
393 goto err_out;
394 }
395 }
396
361fdcaa
UH
397 /*
398 * If we got here, py_optval holds a known good new reference
0bdadba2
BV
399 * to the instance option to set.
400 */
401 if (PyDict_SetItemString(py_di_options, key, py_optval) == -1)
402 goto err_out;
e592ac89 403 g_free(key);
b88e336b 404 key = NULL;
0bdadba2
BV
405 }
406
407 ret = SRD_OK;
408
409err_out:
0bdadba2
BV
410 Py_XDECREF(py_di_options);
411 Py_XDECREF(py_dec_optkeys);
412 Py_XDECREF(py_dec_options);
6f858319 413 g_free(key);
7fc7bde6 414 if (PyErr_Occurred()) {
aafeeaea 415 srd_exception_catch("Stray exception in srd_inst_option_set().");
7fc7bde6
BV
416 ret = SRD_ERR_PYTHON;
417 }
0bdadba2
BV
418
419 return ret;
420}
421
b33b8aa5 422/* Helper GComparefunc for g_slist_find_custom() in srd_inst_probe_set_all() */
abeeed8b 423static gint compare_probe_id(const struct srd_probe *a, const char *probe_id)
f38ec285 424{
f38ec285
BV
425 return strcmp(a->id, probe_id);
426}
427
0bdadba2 428/**
b33b8aa5
UH
429 * Set all probes in a decoder instance.
430 *
431 * This function sets _all_ probes for the specified decoder instance, i.e.,
432 * it overwrites any probes that were already defined (if any).
0bdadba2
BV
433 *
434 * @param di Decoder instance.
38ff5046
UH
435 * @param new_probes A GHashTable of probes to set. Key is probe name, value is
436 * the probe number. Samples passed to this instance will be
437 * arranged in this order.
12243c22 438 *
0bdadba2 439 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
440 *
441 * @since 0.1.0
0bdadba2 442 */
b33b8aa5 443SRD_API int srd_inst_probe_set_all(struct srd_decoder_inst *di,
0ff2d191 444 GHashTable *new_probes)
0bdadba2 445{
2f395bff 446 GVariant *probe_val;
f38ec285
BV
447 GList *l;
448 GSList *sl;
449 struct srd_probe *p;
450 int *new_probemap, new_probenum;
2f395bff 451 char *probe_id;
38ff5046 452 int i, num_required_probes;
0bdadba2 453
ce46beed 454 srd_dbg("set probes called for instance %s with list of %d probes",
a8b72b05 455 di->inst_id, g_hash_table_size(new_probes));
ce46beed 456
f38ec285 457 if (g_hash_table_size(new_probes) == 0)
0bdadba2
BV
458 /* No probes provided. */
459 return SRD_OK;
460
c9bfccc6 461 if (di->dec_num_probes == 0) {
0bdadba2 462 /* Decoder has no probes. */
f38ec285 463 srd_err("Protocol decoder %s has no probes to define.",
c9bfccc6 464 di->decoder->name);
f38ec285
BV
465 return SRD_ERR_ARG;
466 }
0bdadba2 467
f38ec285 468 new_probemap = NULL;
0bdadba2 469
f38ec285 470 if (!(new_probemap = g_try_malloc(sizeof(int) * di->dec_num_probes))) {
a61ece20 471 srd_err("Failed to g_malloc() new probe map.");
f38ec285 472 return SRD_ERR_MALLOC;
0bdadba2
BV
473 }
474
38ff5046
UH
475 /*
476 * For now, map all indexes to probe -1 (can be overridden later).
477 * This -1 is interpreted as an unspecified probe later.
478 */
479 for (i = 0; i < di->dec_num_probes; i++)
480 new_probemap[i] = -1;
481
f38ec285
BV
482 for (l = g_hash_table_get_keys(new_probes); l; l = l->next) {
483 probe_id = l->data;
2f395bff
BV
484 probe_val= g_hash_table_lookup(new_probes, probe_id);
485 if (!g_variant_is_of_type(probe_val, G_VARIANT_TYPE_INT32)) {
be873260 486 /* Probe name was specified without a value. */
c9bfccc6 487 srd_err("No probe number was specified for %s.",
2f395bff 488 probe_id);
be873260
BV
489 g_free(new_probemap);
490 return SRD_ERR_ARG;
491 }
2f395bff 492 new_probenum = g_variant_get_int32(probe_val);
f38ec285
BV
493 if (!(sl = g_slist_find_custom(di->decoder->probes, probe_id,
494 (GCompareFunc)compare_probe_id))) {
495 /* Fall back on optional probes. */
dcdf4883 496 if (!(sl = g_slist_find_custom(di->decoder->opt_probes,
c9bfccc6
UH
497 probe_id, (GCompareFunc) compare_probe_id))) {
498 srd_err("Protocol decoder %s has no probe "
2f395bff 499 "'%s'.", di->decoder->name, probe_id);
f38ec285
BV
500 g_free(new_probemap);
501 return SRD_ERR_ARG;
502 }
503 }
504 p = sl->data;
505 new_probemap[p->order] = new_probenum;
38ff5046
UH
506 srd_dbg("Setting probe mapping: %s (index %d) = probe %d.",
507 p->id, p->order, new_probenum);
508 }
509
510 srd_dbg("Final probe map:");
511 num_required_probes = g_slist_length(di->decoder->probes);
512 for (i = 0; i < di->dec_num_probes; i++) {
513 srd_dbg(" - index %d = probe %d (%s)", i, new_probemap[i],
514 (i < num_required_probes) ? "required" : "optional");
f38ec285 515 }
38ff5046 516
f38ec285
BV
517 g_free(di->dec_probemap);
518 di->dec_probemap = new_probemap;
0bdadba2 519
f38ec285 520 return SRD_OK;
0bdadba2
BV
521}
522
523/**
524 * Create a new protocol decoder instance.
7ce7775c 525 *
32cfb920 526 * @param sess The session holding the protocol decoder instance.
38ff5046 527 * @param decoder_id Decoder 'id' field.
0bdadba2 528 * @param options GHashtable of options which override the defaults set in
38ff5046 529 * the decoder class. May be NULL.
12243c22 530 *
a8b72b05 531 * @return Pointer to a newly allocated struct srd_decoder_inst, or
c9bfccc6 532 * NULL in case of failure.
8c664ca2
UH
533 *
534 * @since 0.1.0
7ce7775c 535 */
32cfb920
BV
536SRD_API struct srd_decoder_inst *srd_inst_new(struct srd_session *sess,
537 const char *decoder_id, GHashTable *options)
b2c19614 538{
c9bfccc6 539 int i;
b2c19614 540 struct srd_decoder *dec;
a8b72b05
BV
541 struct srd_decoder_inst *di;
542 char *inst_id;
b2c19614 543
7a1712c4 544 srd_dbg("Creating new %s instance.", decoder_id);
7ce7775c 545
32cfb920
BV
546 if (session_is_valid(sess) != SRD_OK) {
547 srd_err("Invalid session.");
548 return NULL;
549 }
550
9d122fd5 551 if (!(dec = srd_decoder_get_by_id(decoder_id))) {
0bdadba2 552 srd_err("Protocol decoder %s not found.", decoder_id);
b2c19614 553 return NULL;
0bdadba2 554 }
b2c19614 555
a8b72b05 556 if (!(di = g_try_malloc0(sizeof(struct srd_decoder_inst)))) {
a61ece20 557 srd_err("Failed to g_malloc() instance.");
7ce7775c
BV
558 return NULL;
559 }
0bdadba2 560
b2c19614 561 di->decoder = dec;
32cfb920 562 di->sess = sess;
38ff5046
UH
563 if (options) {
564 inst_id = g_hash_table_lookup(options, "id");
565 di->inst_id = g_strdup(inst_id ? inst_id : decoder_id);
566 g_hash_table_remove(options, "id");
567 } else
568 di->inst_id = g_strdup(decoder_id);
b2c19614 569
361fdcaa
UH
570 /*
571 * Prepare a default probe map, where samples come in the
f38ec285
BV
572 * order in which the decoder class defined them.
573 */
574 di->dec_num_probes = g_slist_length(di->decoder->probes) +
c9bfccc6 575 g_slist_length(di->decoder->opt_probes);
19a90bab 576 if (di->dec_num_probes) {
c9bfccc6
UH
577 if (!(di->dec_probemap =
578 g_try_malloc(sizeof(int) * di->dec_num_probes))) {
a61ece20 579 srd_err("Failed to g_malloc() probe map.");
19a90bab
BV
580 g_free(di);
581 return NULL;
582 }
583 for (i = 0; i < di->dec_num_probes; i++)
584 di->dec_probemap[i] = i;
f38ec285 585 }
f38ec285 586
0bdadba2 587 /* Create a new instance of this decoder class. */
a8b72b05 588 if (!(di->py_inst = PyObject_CallObject(dec->py_dec, NULL))) {
b2c19614 589 if (PyErr_Occurred())
aafeeaea
UH
590 srd_exception_catch("failed to create %s instance: ",
591 decoder_id);
f38ec285 592 g_free(di->dec_probemap);
0bdadba2 593 g_free(di);
7ce7775c 594 return NULL;
b2c19614 595 }
7ce7775c 596
38ff5046 597 if (options && srd_inst_option_set(di, options) != SRD_OK) {
f38ec285 598 g_free(di->dec_probemap);
0bdadba2
BV
599 g_free(di);
600 return NULL;
601 }
b2c19614 602
f38ec285 603 /* Instance takes input from a frontend by default. */
32cfb920 604 sess->di_list = g_slist_append(sess->di_list, di);
f38ec285 605
b2c19614
BV
606 return di;
607}
608
582c8473
BV
609/**
610 * Stack a decoder instance on top of another.
611 *
32cfb920 612 * @param sess The session holding the protocol decoder instances.
582c8473
BV
613 * @param di_from The instance to move.
614 * @param di_to The instance on top of which di_from will be stacked.
615 *
616 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
617 *
618 * @since 0.1.0
582c8473 619 */
32cfb920
BV
620SRD_API int srd_inst_stack(struct srd_session *sess,
621 struct srd_decoder_inst *di_from, struct srd_decoder_inst *di_to)
7ce7775c 622{
32cfb920
BV
623
624 if (session_is_valid(sess) != SRD_OK) {
625 srd_err("Invalid session.");
626 return SRD_ERR_ARG;
627 }
628
7ce7775c 629 if (!di_from || !di_to) {
d906d3f9 630 srd_err("Invalid from/to instance pair.");
7ce7775c
BV
631 return SRD_ERR_ARG;
632 }
633
32cfb920 634 if (g_slist_find(sess->di_list, di_to)) {
2072ae0c 635 /* Remove from the unstacked list. */
32cfb920 636 sess->di_list = g_slist_remove(sess->di_list, di_to);
7ce7775c
BV
637 }
638
7ce7775c
BV
639 /* Stack on top of source di. */
640 di_from->next_di = g_slist_append(di_from->next_di, di_to);
641
642 return SRD_OK;
643}
644
2072ae0c 645/**
361fdcaa
UH
646 * Find a decoder instance by its instance ID.
647 *
648 * Only the bottom level of instances are searched -- instances already stacked
649 * on top of another one will not be found.
2072ae0c 650 *
32cfb920 651 * @param sess The session holding the protocol decoder instance.
ed2306a6 652 * @param inst_id The instance ID to be found.
2072ae0c 653 *
a8b72b05 654 * @return Pointer to struct srd_decoder_inst, or NULL if not found.
8c664ca2
UH
655 *
656 * @since 0.1.0
2072ae0c 657 */
32cfb920
BV
658SRD_API struct srd_decoder_inst *srd_inst_find_by_id(struct srd_session *sess,
659 const char *inst_id)
7ce7775c
BV
660{
661 GSList *l;
a8b72b05 662 struct srd_decoder_inst *tmp, *di;
b2c19614 663
32cfb920
BV
664 if (session_is_valid(sess) != SRD_OK) {
665 srd_err("Invalid session.");
666 return NULL;
667 }
668
7ce7775c 669 di = NULL;
32cfb920 670 for (l = sess->di_list; l; l = l->next) {
7ce7775c 671 tmp = l->data;
a8b72b05 672 if (!strcmp(tmp->inst_id, inst_id)) {
7ce7775c
BV
673 di = tmp;
674 break;
675 }
676 }
677
678 return di;
679}
680
32cfb920
BV
681static struct srd_decoder_inst *srd_sess_inst_find_by_obj(
682 struct srd_session *sess, const GSList *stack,
683 const PyObject *obj)
684{
685 const GSList *l;
686 struct srd_decoder_inst *tmp, *di;
687
688 if (session_is_valid(sess) != SRD_OK) {
689 srd_err("Invalid session.");
690 return NULL;
691 }
692
693 di = NULL;
694 for (l = stack ? stack : sess->di_list; di == NULL && l != NULL; l = l->next) {
695 tmp = l->data;
696 if (tmp->py_inst == obj)
697 di = tmp;
698 else if (tmp->next_di)
699 di = srd_sess_inst_find_by_obj(sess, tmp->next_di, obj);
700 }
701
702 return di;
703}
704
2072ae0c 705/**
361fdcaa
UH
706 * Find a decoder instance by its Python object.
707 *
708 * I.e. find that instance's instantiation of the sigrokdecode.Decoder class.
32cfb920
BV
709 * This will recurse to find the instance anywhere in the stack tree of all
710 * sessions.
2072ae0c 711 *
361fdcaa
UH
712 * @param stack Pointer to a GSList of struct srd_decoder_inst, indicating the
713 * stack to search. To start searching at the bottom level of
714 * decoder instances, pass NULL.
511e2123 715 * @param obj The Python class instantiation.
2072ae0c 716 *
a8b72b05 717 * @return Pointer to struct srd_decoder_inst, or NULL if not found.
57790bc8
UH
718 *
719 * @private
8c664ca2
UH
720 *
721 * @since 0.1.0
2072ae0c 722 */
abeeed8b 723SRD_PRIV struct srd_decoder_inst *srd_inst_find_by_obj(const GSList *stack,
0ff2d191 724 const PyObject *obj)
2072ae0c 725{
32cfb920
BV
726 struct srd_decoder_inst *di;
727 struct srd_session *sess;
728 GSList *l;
2072ae0c
BV
729
730 di = NULL;
32cfb920
BV
731 for (l = sessions; di == NULL && l != NULL; l = l->next) {
732 sess = l->data;
733 di = srd_sess_inst_find_by_obj(sess, stack, obj);
2072ae0c
BV
734 }
735
736 return di;
737}
738
57790bc8 739/** @private */
ee4ed227 740SRD_PRIV int srd_inst_start(struct srd_decoder_inst *di, PyObject *args)
b2c19614 741{
7ce7775c 742 PyObject *py_name, *py_res;
2072ae0c 743 GSList *l;
a8b72b05 744 struct srd_decoder_inst *next_di;
b2c19614 745
7a1712c4 746 srd_dbg("Calling start() method on protocol decoder instance %s.",
a8b72b05 747 di->inst_id);
b2c19614 748
7ce7775c 749 if (!(py_name = PyUnicode_FromString("start"))) {
511e2123 750 srd_err("Unable to build Python object for 'start'.");
aafeeaea
UH
751 srd_exception_catch("Protocol decoder instance %s: ",
752 di->inst_id);
7ce7775c
BV
753 return SRD_ERR_PYTHON;
754 }
755
a8b72b05 756 if (!(py_res = PyObject_CallMethodObjArgs(di->py_inst,
c9bfccc6 757 py_name, args, NULL))) {
aafeeaea
UH
758 srd_exception_catch("Protocol decoder instance %s: ",
759 di->inst_id);
7ce7775c 760 return SRD_ERR_PYTHON;
b2c19614
BV
761 }
762
f38ec285
BV
763 Py_DecRef(py_res);
764 Py_DecRef(py_name);
7ce7775c 765
361fdcaa
UH
766 /*
767 * Start all the PDs stacked on top of this one. Pass along the
2072ae0c
BV
768 * metadata all the way from the bottom PD, even though it's only
769 * applicable to logic data for now.
770 */
771 for (l = di->next_di; l; l = l->next) {
772 next_di = l->data;
a8b72b05 773 srd_inst_start(next_di, args);
2072ae0c
BV
774 }
775
b2c19614
BV
776 return SRD_OK;
777}
778
b2c19614
BV
779/**
780 * Run the specified decoder function.
781 *
d906d3f9 782 * @param start_samplenum The starting sample number for the buffer's sample
7a1712c4
UH
783 * set, relative to the start of capture.
784 * @param di The decoder instance to call. Must not be NULL.
785 * @param inbuf The buffer to decode. Must not be NULL.
786 * @param inbuflen Length of the buffer. Must be > 0.
b2c19614
BV
787 *
788 * @return SRD_OK upon success, a (negative) error code otherwise.
57790bc8
UH
789 *
790 * @private
8c664ca2
UH
791 *
792 * @since 0.1.0
b2c19614 793 */
12243c22 794SRD_PRIV int srd_inst_decode(uint64_t start_samplenum,
0ff2d191
BV
795 const struct srd_decoder_inst *di, const uint8_t *inbuf,
796 uint64_t inbuflen)
b2c19614 797{
d906d3f9 798 PyObject *py_res;
bc5f5a43 799 srd_logic *logic;
86528298 800 uint64_t end_samplenum;
b2c19614 801
7a1712c4 802 srd_dbg("Calling decode() on instance %s with %d bytes starting "
a8b72b05 803 "at sample %d.", di->inst_id, inbuflen, start_samplenum);
b2c19614 804
d906d3f9 805 /* Return an error upon unusable input. */
7a1712c4
UH
806 if (!di) {
807 srd_dbg("empty decoder instance");
d906d3f9
BV
808 return SRD_ERR_ARG;
809 }
7a1712c4
UH
810 if (!inbuf) {
811 srd_dbg("NULL buffer pointer");
d906d3f9
BV
812 return SRD_ERR_ARG;
813 }
814 if (inbuflen == 0) {
7a1712c4 815 srd_dbg("empty buffer");
d906d3f9
BV
816 return SRD_ERR_ARG;
817 }
b2c19614 818
361fdcaa
UH
819 /*
820 * Create new srd_logic object. Each iteration around the PD's loop
d906d3f9
BV
821 * will fill one sample into this object.
822 */
bc5f5a43
BV
823 logic = PyObject_New(srd_logic, &srd_logic_type);
824 Py_INCREF(logic);
abeeed8b 825 logic->di = (struct srd_decoder_inst *)di;
86528298 826 logic->start_samplenum = start_samplenum;
bc5f5a43 827 logic->itercnt = 0;
abeeed8b 828 logic->inbuf = (uint8_t *)inbuf;
bc5f5a43
BV
829 logic->inbuflen = inbuflen;
830 logic->sample = PyList_New(2);
831 Py_INCREF(logic->sample);
832
a8b72b05 833 Py_IncRef(di->py_inst);
f38ec285 834 end_samplenum = start_samplenum + inbuflen / di->data_unitsize;
a8b72b05 835 if (!(py_res = PyObject_CallMethod(di->py_inst, "decode",
c9bfccc6
UH
836 "KKO", logic->start_samplenum,
837 end_samplenum, logic))) {
aafeeaea
UH
838 srd_exception_catch("Protocol decoder instance %s: ",
839 di->inst_id);
0ff2d191 840 return SRD_ERR_PYTHON;
b2c19614 841 }
d906d3f9 842 Py_DecRef(py_res);
bc5f5a43 843
b2c19614
BV
844 return SRD_OK;
845}
846
57790bc8 847/** @private */
12243c22 848SRD_PRIV void srd_inst_free(struct srd_decoder_inst *di)
fa12a21e
BV
849{
850 GSList *l;
851 struct srd_pd_output *pdo;
852
a8b72b05 853 srd_dbg("Freeing instance %s", di->inst_id);
fa12a21e 854
a8b72b05
BV
855 Py_DecRef(di->py_inst);
856 g_free(di->inst_id);
fa12a21e
BV
857 g_free(di->dec_probemap);
858 g_slist_free(di->next_di);
859 for (l = di->pd_output; l; l = l->next) {
860 pdo = l->data;
861 g_free(pdo->proto_id);
862 g_free(pdo);
863 }
864 g_slist_free(di->pd_output);
e592ac89 865 g_free(di);
fa12a21e
BV
866}
867
57790bc8 868/** @private */
32cfb920 869SRD_PRIV void srd_inst_free_all(struct srd_session *sess, GSList *stack)
fa12a21e
BV
870{
871 GSList *l;
a8b72b05 872 struct srd_decoder_inst *di;
fa12a21e 873
32cfb920
BV
874 if (session_is_valid(sess) != SRD_OK) {
875 srd_err("Invalid session.");
876 return;
877 }
878
fa12a21e 879 di = NULL;
32cfb920 880 for (l = stack ? stack : sess->di_list; di == NULL && l != NULL; l = l->next) {
fa12a21e
BV
881 di = l->data;
882 if (di->next_di)
32cfb920 883 srd_inst_free_all(sess, di->next_di);
a8b72b05 884 srd_inst_free(di);
fa12a21e
BV
885 }
886 if (!stack) {
32cfb920
BV
887 g_slist_free(sess->di_list);
888 sess->di_list = NULL;
fa12a21e 889 }
fa12a21e 890}
b2c19614 891
4895418c
UH
892/** @} */
893
894/**
895 * @defgroup grp_session Session handling
896 *
897 * Starting and handling decoding sessions.
898 *
899 * @{
900 */
901
32cfb920
BV
902static int session_is_valid(struct srd_session *sess)
903{
904
905 if (!sess || sess->session_id < 1)
906 return SRD_ERR;
907
908 return SRD_OK;
909}
910
911/**
912 * Create a decoding session.
913 *
914 * A session holds all decoder instances, their stack relationships and
915 * output callbacks.
916 *
917 * @param sess. A pointer which will hold a pointer to a newly
918 * initialized session on return.
919 *
920 * @return SRD_OK upon success, a (negative) error code otherwise.
921 *
922 * @since 0.3.0
923 */
924SRD_API int srd_session_new(struct srd_session **sess)
925{
926
927 if (!sess) {
928 srd_err("Invalid session pointer.");
929 return SRD_ERR;
930 }
931
932 if (!(*sess = g_try_malloc(sizeof(struct srd_session))))
933 return SRD_ERR_MALLOC;
934 (*sess)->session_id = ++max_session_id;
935 (*sess)->num_probes = (*sess)->unitsize = (*sess)->samplerate = 0;
936 (*sess)->di_list = (*sess)->callbacks = NULL;
937
938 /* Keep a list of all sessions, so we can clean up as needed. */
939 sessions = g_slist_append(sessions, *sess);
940
941 srd_dbg("Created session %d.", (*sess)->session_id);
942
943 return SRD_OK;
944}
945
582c8473
BV
946/**
947 * Start a decoding session.
948 *
32cfb920
BV
949 * Decoders, instances and stack must have been prepared beforehand,
950 * and all SRD_CONF parameters set.
582c8473 951 *
32cfb920 952 * @param sess The session to start.
582c8473
BV
953 *
954 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
955 *
956 * @since 0.1.0
582c8473 957 */
32cfb920 958SRD_API int srd_session_start(struct srd_session *sess)
7ce7775c
BV
959{
960 PyObject *args;
2072ae0c 961 GSList *d;
a8b72b05 962 struct srd_decoder_inst *di;
7ce7775c
BV
963 int ret;
964
32cfb920
BV
965 if (session_is_valid(sess) != SRD_OK) {
966 srd_err("Invalid session pointer.");
967 return SRD_ERR;
968 }
969 if (sess->num_probes == 0) {
970 srd_err("Session has invalid number of probes.");
971 return SRD_ERR;
972 }
973 if (sess->unitsize == 0) {
974 srd_err("Session has invalid unitsize.");
975 return SRD_ERR;
976 }
977 if (sess->samplerate == 0) {
978 srd_err("Session has invalid samplerate.");
979 return SRD_ERR;
980 }
981
38ff5046
UH
982 ret = SRD_OK;
983
32cfb920
BV
984 srd_dbg("Calling start() on all instances in session %d with "
985 "%d probes, unitsize %d samplerate %d.", sess->session_id,
986 sess->num_probes, sess->unitsize, sess->samplerate);
d906d3f9 987
361fdcaa
UH
988 /*
989 * Currently only one item of metadata is passed along to decoders,
d906d3f9
BV
990 * samplerate. This can be extended as needed.
991 */
32cfb920 992 if (!(args = Py_BuildValue("{s:l}", "samplerate", (long)sess->samplerate))) {
511e2123 993 srd_err("Unable to build Python object for metadata.");
7ce7775c
BV
994 return SRD_ERR_PYTHON;
995 }
996
997 /* Run the start() method on all decoders receiving frontend data. */
32cfb920 998 for (d = sess->di_list; d; d = d->next) {
7ce7775c 999 di = d->data;
32cfb920
BV
1000 di->data_num_probes = sess->num_probes;
1001 di->data_unitsize = sess->unitsize;
1002 di->data_samplerate = sess->samplerate;
38ff5046 1003 if ((ret = srd_inst_start(di, args)) != SRD_OK)
2072ae0c 1004 break;
7ce7775c
BV
1005 }
1006
d906d3f9 1007 Py_DecRef(args);
7ce7775c 1008
2072ae0c 1009 return ret;
7ce7775c
BV
1010}
1011
32cfb920
BV
1012/**
1013 * Set a configuration key in a session.
1014 *
1015 * @param sess The session to configure.
1016 * @param key The configuration key (SRD_CONF_*).
1017 * @param data The new value for the key, as a GVariant with GVariantType
1018 * appropriate to that key. A floating reference can be passed
1019 * in; its refcount will be sunk and unreferenced after use.
1020 *
1021 * @return SRD_OK upon success, a (negative) error code otherwise.
1022 *
1023 * @since 0.3.0
1024 */
1025SRD_API int srd_session_config_set(struct srd_session *sess, int key,
1026 GVariant *data)
1027{
1028
1029 if (session_is_valid(sess) != SRD_OK) {
1030 srd_err("Invalid session.");
1031 return SRD_ERR_ARG;
1032 }
1033
1034 if (!g_variant_is_of_type(data, G_VARIANT_TYPE_UINT64)) {
1035 srd_err("Value for key %d should be of type uint64.");
1036 return SRD_ERR_ARG;
1037 }
1038
1039 switch (key) {
1040 case SRD_CONF_NUM_PROBES:
1041 sess->num_probes = g_variant_get_uint64(data);
1042 break;
1043 case SRD_CONF_UNITSIZE:
1044 sess->unitsize = g_variant_get_uint64(data);
1045 break;
1046 case SRD_CONF_SAMPLERATE:
1047 sess->samplerate = g_variant_get_uint64(data);
1048 break;
1049 }
1050
1051 g_variant_unref(data);
1052
1053 return SRD_OK;
1054}
1055
582c8473 1056/**
29dad0ac 1057 * Send a chunk of logic sample data to a running decoder session.
582c8473 1058 *
32cfb920 1059 * @param sess The session to use.
582c8473
BV
1060 * @param start_samplenum The sample number of the first sample in this chunk.
1061 * @param inbuf Pointer to sample data.
38ff5046 1062 * @param inbuflen Length in bytes of the buffer.
582c8473
BV
1063 *
1064 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
1065 *
1066 * @since 0.1.0
582c8473 1067 */
32cfb920
BV
1068SRD_API int srd_session_send(struct srd_session *sess, uint64_t start_samplenum,
1069 const uint8_t *inbuf, uint64_t inbuflen)
b2c19614
BV
1070{
1071 GSList *d;
1072 int ret;
1073
32cfb920
BV
1074 if (session_is_valid(sess) != SRD_OK) {
1075 srd_err("Invalid session.");
1076 return SRD_ERR_ARG;
1077 }
1078
7a1712c4 1079 srd_dbg("Calling decode() on all instances with starting sample "
c9bfccc6
UH
1080 "number %" PRIu64 ", %" PRIu64 " bytes at 0x%p",
1081 start_samplenum, inbuflen, inbuf);
d906d3f9 1082
32cfb920 1083 for (d = sess->di_list; d; d = d->next) {
a8b72b05 1084 if ((ret = srd_inst_decode(start_samplenum, d->data, inbuf,
361fdcaa 1085 inbuflen)) != SRD_OK)
b2c19614
BV
1086 return ret;
1087 }
1088
1089 return SRD_OK;
1090}
1091
32cfb920
BV
1092/**
1093 * Destroy a decoding session.
1094 *
1095 * All decoder instances and output callbacks are properly released.
1096 *
1097 * @param sess. The session to be destroyed.
1098 *
1099 * @return SRD_OK upon success, a (negative) error code otherwise.
1100 *
1101 * @since 0.1.0
1102 */
1103SRD_API int srd_session_destroy(struct srd_session *sess)
1104{
1105 int session_id;
1106
1107 session_id = sess->session_id;
1108 if (sess->di_list)
1109 srd_inst_free_all(sess, NULL);
1110 if (sess->callbacks)
1111 g_slist_free_full(sess->callbacks, g_free);
1112 sessions = g_slist_remove(sessions, sess);
1113 g_free(sess);
1114
1115 srd_dbg("Destroyed session %d.", session_id);
1116
1117 return SRD_OK;
1118}
1119
582c8473 1120/**
b33b8aa5 1121 * Register/add a decoder output callback function.
582c8473
BV
1122 *
1123 * The function will be called when a protocol decoder sends output back
1124 * to the PD controller (except for Python objects, which only go up the
1125 * stack).
1126 *
32cfb920 1127 * @param sess The output session in which to register the callback.
582c8473 1128 * @param output_type The output type this callback will receive. Only one
4c1d0670 1129 * callback per output type can be registered.
361fdcaa
UH
1130 * @param cb The function to call. Must not be NULL.
1131 * @param cb_data Private data for the callback function. Can be NULL.
8c664ca2
UH
1132 *
1133 * @since 0.1.0
582c8473 1134 */
32cfb920
BV
1135SRD_API int srd_pd_output_callback_add(struct srd_session *sess,
1136 int output_type, srd_pd_output_callback_t cb, void *cb_data)
4fadb128
BV
1137{
1138 struct srd_pd_callback *pd_cb;
1139
32cfb920
BV
1140 if (session_is_valid(sess) != SRD_OK) {
1141 srd_err("Invalid session.");
1142 return SRD_ERR_ARG;
1143 }
1144
7a1712c4 1145 srd_dbg("Registering new callback for output type %d.", output_type);
4fadb128 1146
a61ece20
UH
1147 if (!(pd_cb = g_try_malloc(sizeof(struct srd_pd_callback)))) {
1148 srd_err("Failed to g_malloc() struct srd_pd_callback.");
4fadb128 1149 return SRD_ERR_MALLOC;
a61ece20 1150 }
4fadb128
BV
1151
1152 pd_cb->output_type = output_type;
4c1d0670 1153 pd_cb->cb = cb;
41a5d962 1154 pd_cb->cb_data = cb_data;
32cfb920 1155 sess->callbacks = g_slist_append(sess->callbacks, pd_cb);
4fadb128
BV
1156
1157 return SRD_OK;
1158}
1159
57790bc8 1160/** @private */
32cfb920
BV
1161SRD_PRIV struct srd_pd_callback *srd_pd_output_callback_find(
1162 struct srd_session *sess, int output_type)
4fadb128
BV
1163{
1164 GSList *l;
2994587f 1165 struct srd_pd_callback *tmp, *pd_cb;
4fadb128 1166
32cfb920
BV
1167 if (session_is_valid(sess) != SRD_OK) {
1168 srd_err("Invalid session.");
1169 return NULL;
1170 }
1171
2994587f 1172 pd_cb = NULL;
32cfb920 1173 for (l = sess->callbacks; l; l = l->next) {
2994587f
BV
1174 tmp = l->data;
1175 if (tmp->output_type == output_type) {
1176 pd_cb = tmp;
4fadb128
BV
1177 break;
1178 }
1179 }
1180
2994587f 1181 return pd_cb;
4fadb128
BV
1182}
1183
511e2123 1184/* This is the backend function to Python sigrokdecode.add() call. */
57790bc8 1185/** @private */
aafeeaea
UH
1186SRD_PRIV int srd_inst_pd_output_add(struct srd_decoder_inst *di,
1187 int output_type, const char *proto_id)
e5080882 1188{
e5080882 1189 struct srd_pd_output *pdo;
e5080882 1190
7a1712c4 1191 srd_dbg("Instance %s creating new output type %d for %s.",
a8b72b05 1192 di->inst_id, output_type, proto_id);
d906d3f9 1193
a61ece20
UH
1194 if (!(pdo = g_try_malloc(sizeof(struct srd_pd_output)))) {
1195 srd_err("Failed to g_malloc() struct srd_pd_output.");
e5080882 1196 return -1;
a61ece20 1197 }
e5080882 1198
b231546d 1199 /* pdo_id is just a simple index, nothing is deleted from this list anyway. */
15969949 1200 pdo->pdo_id = g_slist_length(di->pd_output);
e5080882 1201 pdo->output_type = output_type;
b3b2cae8 1202 pdo->di = di;
94d43b37 1203 pdo->proto_id = g_strdup(proto_id);
e5080882
BV
1204 di->pd_output = g_slist_append(di->pd_output, pdo);
1205
15969949 1206 return pdo->pdo_id;
e5080882 1207}
d7dae84b
UH
1208
1209/** @} */