sr_dev_close(): Set status to SR_ST_INACTIVE.

[libsigrok.git] / src / std.c

diff --git a/src/std.c b/src/std.c
index ccb73718c9b26b0fdf129b43439f437c5405e414..13f9b03195f549eafa40e02072605242dc6f7294 100644 (file)
--- a/src/std.c
+++ b/src/std.c
@@ -152,23 +152,20 @@ SR_PRIV int std_session_send_df_end(const struct sr_dev_inst *sdi)
  * callback in drivers that use a serial port. The port is opened
  * with the SERIAL_RDWR flag.
  *
- * If the open succeeded, the status field of the given sdi is set
- * to SR_ST_ACTIVE.
- *
  * @retval SR_OK Success.
+ * @retval SR_ERR_ARG Invalid arguments.
  * @retval SR_ERR Serial port open failed.
  */
 SR_PRIV int std_serial_dev_open(struct sr_dev_inst *sdi)
 {
        struct sr_serial_dev_inst *serial;
 
-       serial = sdi->conn;
-       if (serial_open(serial, SERIAL_RDWR) != SR_OK)
-               return SR_ERR;
+       if (!sdi || !sdi->conn)
+               return SR_ERR_ARG;
 
-       sdi->status = SR_ST_ACTIVE;
+       serial = sdi->conn;
 
-       return SR_OK;
+       return serial_open(serial, SERIAL_RDWR);
 }
 
 /**
@@ -177,27 +174,20 @@ SR_PRIV int std_serial_dev_open(struct sr_dev_inst *sdi)
  * This function can be used to implement the dev_close() driver API
  * callback in drivers that use a serial port.
  *
- * After closing the port, the status field of the given sdi is set
- * to SR_ST_INACTIVE.
- *
  * @retval SR_OK Success.
  * @retval SR_ERR_ARG Invalid arguments.
+ * @retval SR_ERR Serial port close failed.
  */
 SR_PRIV int std_serial_dev_close(struct sr_dev_inst *sdi)
 {
        struct sr_serial_dev_inst *serial;
 
-       sdi->status = SR_ST_INACTIVE;
-
-       serial = sdi->conn;
-       if (!serial) {
-               sr_err("%s: Can't close invalid serial port.", sdi->driver->name);
+       if (!sdi || !sdi->conn)
                return SR_ERR_ARG;
-       }
 
-       serial_close(serial);
+       serial = sdi->conn;
 
-       return SR_OK;
+       return serial_close(serial);
 }
 
 /**