]> sigrok.org Git - libsigrok.git/blobdiff - src/hardware/demo/demo.c
Change sr_dev_inst_new() to take no parameters.
[libsigrok.git] / src / hardware / demo / demo.c
index b2f3a50915227ee4b96cd4b9dd7d45b2a0a1262f..b5cb276c9747f4011ed42ef8917abe1cf3866aa5 100644 (file)
@@ -42,7 +42,7 @@
 /* Size of the analog pattern space per channel. */
 #define ANALOG_BUFSIZE       4096
 
-#define ANALOG_AMPLITUDE 25
+#define DEFAULT_ANALOG_AMPLITUDE 25
 #define ANALOG_SAMPLES_PER_PERIOD 20
 
 /* Logic patterns we can generate. */
@@ -99,6 +99,7 @@ static const char *analog_pattern_str[] = {
 
 struct analog_gen {
        int pattern;
+       float amplitude;
        float pattern_data[ANALOG_BUFSIZE];
        unsigned int num_samples;
        struct sr_datafeed_analog packet;
@@ -109,6 +110,7 @@ struct dev_context {
        int pipe_fds[2];
        GIOChannel *channel;
        uint64_t cur_samplerate;
+       gboolean continuous;
        uint64_t limit_samples;
        uint64_t limit_msec;
        uint64_t logic_counter;
@@ -123,24 +125,34 @@ struct dev_context {
        unsigned char logic_data[LOGIC_BUFSIZE];
        /* Analog */
        int32_t num_analog_channels;
-       GSList *analog_channel_groups;
+       GHashTable *ch_ag;
 };
 
-static const int32_t scanopts[] = {
+static const uint32_t scanopts[] = {
        SR_CONF_NUM_LOGIC_CHANNELS,
        SR_CONF_NUM_ANALOG_CHANNELS,
 };
 
-static const int devopts[] = {
-       SR_CONF_LOGIC_ANALYZER,
+static const uint32_t devopts[] = {
        SR_CONF_DEMO_DEV,
-       SR_CONF_SAMPLERATE,
-       SR_CONF_LIMIT_SAMPLES,
-       SR_CONF_LIMIT_MSEC,
+       SR_CONF_LOGIC_ANALYZER,
+       SR_CONF_OSCILLOSCOPE,
+       SR_CONF_CONTINUOUS,
+       SR_CONF_LIMIT_SAMPLES | SR_CONF_GET | SR_CONF_SET,
+       SR_CONF_LIMIT_MSEC | SR_CONF_GET | SR_CONF_SET,
+};
+
+static const uint32_t devopts_global[] = {
+       SR_CONF_SAMPLERATE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
 };
 
-static const int devopts_cg[] = {
-       SR_CONF_PATTERN_MODE,
+static const uint32_t devopts_cg_logic[] = {
+       SR_CONF_PATTERN_MODE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
+};
+
+static const uint32_t devopts_cg_analog[] = {
+       SR_CONF_PATTERN_MODE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
+       SR_CONF_AMPLITUDE | SR_CONF_GET | SR_CONF_SET,
 };
 
 static const uint64_t samplerates[] = {
@@ -171,23 +183,20 @@ static int init(struct sr_context *sr_ctx)
        return std_init(sr_ctx, di, LOG_PREFIX);
 }
 
-static void generate_analog_pattern(const struct sr_channel_group *cg, uint64_t sample_rate)
+static void generate_analog_pattern(struct analog_gen *ag, uint64_t sample_rate)
 {
-       struct analog_gen *ag;
        double t, frequency;
        float value;
        unsigned int num_samples, i;
        int last_end;
 
-       ag = cg->priv;
-       num_samples = ANALOG_BUFSIZE / sizeof(float);
+       sr_dbg("Generating %s pattern.", analog_pattern_str[ag->pattern]);
 
-       sr_dbg("Generating %s pattern for channel group %s",
-              analog_pattern_str[ag->pattern], cg->name);
+       num_samples = ANALOG_BUFSIZE / sizeof(float);
 
        switch (ag->pattern) {
        case PATTERN_SQUARE:
-               value = ANALOG_AMPLITUDE;
+               value = ag->amplitude;
                last_end = 0;
                for (i = 0; i < num_samples; i++) {
                        if (i % 5 == 0)
@@ -211,7 +220,7 @@ static void generate_analog_pattern(const struct sr_channel_group *cg, uint64_t
 
                for (i = 0; i < num_samples; i++) {
                        t = (double) i / (double) sample_rate;
-                       ag->pattern_data[i] = ANALOG_AMPLITUDE *
+                       ag->pattern_data[i] = ag->amplitude *
                                                sin(2 * M_PI * frequency * t);
                }
 
@@ -226,7 +235,7 @@ static void generate_analog_pattern(const struct sr_channel_group *cg, uint64_t
 
                for (i = 0; i < num_samples; i++) {
                        t = (double) i / (double) sample_rate;
-                       ag->pattern_data[i] = (2 * ANALOG_AMPLITUDE / M_PI) *
+                       ag->pattern_data[i] = (2 * ag->amplitude / M_PI) *
                                                asin(sin(2 * M_PI * frequency * t));
                }
 
@@ -241,7 +250,7 @@ static void generate_analog_pattern(const struct sr_channel_group *cg, uint64_t
 
                for (i = 0; i < num_samples; i++) {
                        t = (double) i / (double) sample_rate;
-                       ag->pattern_data[i] = 2 * ANALOG_AMPLITUDE *
+                       ag->pattern_data[i] = 2 * ag->amplitude *
                                                ((t * frequency) - floor(0.5f + t * frequency));
                }
 
@@ -256,7 +265,7 @@ static GSList *scan(GSList *options)
        struct dev_context *devc;
        struct sr_dev_inst *sdi;
        struct sr_channel *ch;
-       struct sr_channel_group *cg;
+       struct sr_channel_group *cg, *acg;
        struct sr_config *src;
        struct analog_gen *ag;
        GSList *devices, *l;
@@ -280,33 +289,26 @@ static GSList *scan(GSList *options)
        }
 
        devices = NULL;
-       sdi = sr_dev_inst_new(0, SR_ST_ACTIVE, "Demo device", NULL, NULL);
-       if (!sdi) {
-               sr_err("Device instance creation failed.");
-               return NULL;
-       }
+
+       sdi = sr_dev_inst_new();
+       sdi->status = SR_ST_ACTIVE;
+       sdi->model = "Demo device";
        sdi->driver = di;
 
-       if (!(devc = g_try_malloc(sizeof(struct dev_context)))) {
-               sr_err("Device context malloc failed.");
-               return NULL;
-       }
+       devc = g_malloc(sizeof(struct dev_context));
        devc->cur_samplerate = SR_KHZ(200);
        devc->limit_samples = 0;
        devc->limit_msec = 0;
        devc->step = 0;
+       devc->continuous = FALSE;
        devc->num_logic_channels = num_logic_channels;
        devc->logic_unitsize = (devc->num_logic_channels + 7) / 8;
        devc->logic_pattern = PATTERN_SIGROK;
        devc->num_analog_channels = num_analog_channels;
-       devc->analog_channel_groups = NULL;
 
        /* Logic channels, all in one channel group. */
-       if (!(cg = g_try_malloc(sizeof(struct sr_channel_group))))
-               return NULL;
+       cg = g_malloc0(sizeof(struct sr_channel_group));
        cg->name = g_strdup("Logic");
-       cg->channels = NULL;
-       cg->priv = NULL;
        for (i = 0; i < num_logic_channels; i++) {
                sprintf(channel_name, "D%d", i);
                if (!(ch = sr_channel_new(i, SR_CHANNEL_LOGIC, TRUE, channel_name)))
@@ -317,34 +319,36 @@ static GSList *scan(GSList *options)
        sdi->channel_groups = g_slist_append(NULL, cg);
 
        /* Analog channels, channel groups and pattern generators. */
-
        pattern = 0;
+       /* An "Analog" channel group with all analog channels in it. */
+       acg = g_malloc0(sizeof(struct sr_channel_group));
+       acg->name = g_strdup("Analog");
+       sdi->channel_groups = g_slist_append(sdi->channel_groups, acg);
+
+       devc->ch_ag = g_hash_table_new(g_direct_hash, g_direct_equal);
        for (i = 0; i < num_analog_channels; i++) {
-               sprintf(channel_name, "A%d", i);
-               if (!(ch = sr_channel_new(i + num_logic_channels,
-                               SR_CHANNEL_ANALOG, TRUE, channel_name)))
-                       return NULL;
+               snprintf(channel_name, 16, "A%d", i);
+               ch = sr_channel_new(i + num_logic_channels, SR_CHANNEL_ANALOG,
+                               TRUE, channel_name);
                sdi->channels = g_slist_append(sdi->channels, ch);
+               acg->channels = g_slist_append(acg->channels, ch);
 
-               /* Every analog channel gets its own channel group. */
-               if (!(cg = g_try_malloc(sizeof(struct sr_channel_group))))
-                       return NULL;
+               /* Every analog channel gets its own channel group as well. */
+               cg = g_malloc0(sizeof(struct sr_channel_group));
                cg->name = g_strdup(channel_name);
                cg->channels = g_slist_append(NULL, ch);
+               sdi->channel_groups = g_slist_append(sdi->channel_groups, cg);
 
-               /* Every channel group gets a generator struct. */
-               if (!(ag = g_try_malloc(sizeof(struct analog_gen))))
-                       return NULL;
+               /* Every channel gets a generator struct. */
+               ag = g_malloc(sizeof(struct analog_gen));
+               ag->amplitude = DEFAULT_ANALOG_AMPLITUDE;
                ag->packet.channels = cg->channels;
                ag->packet.mq = 0;
                ag->packet.mqflags = 0;
                ag->packet.unit = SR_UNIT_VOLT;
                ag->packet.data = ag->pattern_data;
                ag->pattern = pattern;
-               cg->priv = ag;
-
-               sdi->channel_groups = g_slist_append(sdi->channel_groups, cg);
-               devc->analog_channel_groups = g_slist_append(devc->analog_channel_groups, cg);
+               g_hash_table_insert(devc->ch_ag, ch, ag);
 
                if (++pattern == ARRAY_SIZE(analog_pattern_str))
                        pattern = 0;
@@ -376,12 +380,28 @@ static int dev_close(struct sr_dev_inst *sdi)
        return SR_OK;
 }
 
+static void clear_helper(void *priv)
+{
+       struct dev_context *devc;
+       GHashTableIter iter;
+       void *value;
+
+       devc = priv;
+
+       /* Analog generators. */
+       g_hash_table_iter_init(&iter, devc->ch_ag);
+       while (g_hash_table_iter_next(&iter, NULL, &value))
+               g_free(value);
+       g_hash_table_unref(devc->ch_ag);
+       g_free(devc);
+}
+
 static int cleanup(void)
 {
-       return std_dev_clear(di, NULL);
+       return std_dev_clear(di, clear_helper);
 }
 
-static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi,
+static int config_get(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
                const struct sr_channel_group *cg)
 {
        struct dev_context *devc;
@@ -393,7 +413,7 @@ static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi,
                return SR_ERR_ARG;
 
        devc = sdi->priv;
-       switch (id) {
+       switch (key) {
        case SR_CONF_SAMPLERATE:
                *data = g_variant_new_uint64(devc->cur_samplerate);
                break;
@@ -406,22 +426,27 @@ static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi,
        case SR_CONF_PATTERN_MODE:
                if (!cg)
                        return SR_ERR_CHANNEL_GROUP;
+               /* Any channel in the group will do. */
                ch = cg->channels->data;
                if (ch->type == SR_CHANNEL_LOGIC) {
                        pattern = devc->logic_pattern;
                        *data = g_variant_new_string(logic_pattern_str[pattern]);
                } else if (ch->type == SR_CHANNEL_ANALOG) {
-                       ag = cg->priv;
+                       ag = g_hash_table_lookup(devc->ch_ag, ch);
                        pattern = ag->pattern;
                        *data = g_variant_new_string(analog_pattern_str[pattern]);
                } else
                        return SR_ERR_BUG;
                break;
-       case SR_CONF_NUM_LOGIC_CHANNELS:
-               *data = g_variant_new_int32(devc->num_logic_channels);
-               break;
-       case SR_CONF_NUM_ANALOG_CHANNELS:
-               *data = g_variant_new_int32(devc->num_analog_channels);
+       case SR_CONF_AMPLITUDE:
+               if (!cg)
+                       return SR_ERR_CHANNEL_GROUP;
+               /* Any channel in the group will do. */
+               ch = cg->channels->data;
+               if (ch->type != SR_CHANNEL_ANALOG)
+                       return SR_ERR_ARG;
+               ag = g_hash_table_lookup(devc->ch_ag, ch);
+               *data = g_variant_new_double(ag->amplitude);
                break;
        default:
                return SR_ERR_NA;
@@ -430,13 +455,14 @@ static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi,
        return SR_OK;
 }
 
-static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
+static int config_set(uint32_t key, GVariant *data, const struct sr_dev_inst *sdi,
                const struct sr_channel_group *cg)
 {
        struct dev_context *devc;
        struct analog_gen *ag;
        struct sr_channel *ch;
-       int pattern, ret;
+       GSList *l;
+       int logic_pattern, analog_pattern, ret;
        unsigned int i;
        const char *stropt;
 
@@ -446,7 +472,7 @@ static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
                return SR_ERR_DEV_CLOSED;
 
        ret = SR_OK;
-       switch (id) {
+       switch (key) {
        case SR_CONF_SAMPLERATE:
                devc->cur_samplerate = g_variant_get_uint64(data);
                sr_dbg("Setting samplerate to %" PRIu64, devc->cur_samplerate);
@@ -465,41 +491,55 @@ static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
                if (!cg)
                        return SR_ERR_CHANNEL_GROUP;
                stropt = g_variant_get_string(data, NULL);
-               ch = cg->channels->data;
-               pattern = -1;
-               if (ch->type == SR_CHANNEL_LOGIC) {
-                       for (i = 0; i < ARRAY_SIZE(logic_pattern_str); i++) {
-                               if (!strcmp(stropt, logic_pattern_str[i])) {
-                                       pattern = i;
-                                       break;
-                               }
+               logic_pattern = analog_pattern = -1;
+               for (i = 0; i < ARRAY_SIZE(logic_pattern_str); i++) {
+                       if (!strcmp(stropt, logic_pattern_str[i])) {
+                               logic_pattern = i;
+                               break;
                        }
-                       if (pattern == -1)
-                               return SR_ERR_ARG;
-                       devc->logic_pattern = pattern;
-
-                       /* Might as well do this now, these are static. */
-                       if (pattern == PATTERN_ALL_LOW)
-                               memset(devc->logic_data, 0x00, LOGIC_BUFSIZE);
-                       else if (pattern == PATTERN_ALL_HIGH)
-                               memset(devc->logic_data, 0xff, LOGIC_BUFSIZE);
-                       sr_dbg("Setting logic pattern to %s",
-                                       logic_pattern_str[pattern]);
-               } else if (ch->type == SR_CHANNEL_ANALOG) {
-                       for (i = 0; i < ARRAY_SIZE(analog_pattern_str); i++) {
-                               if (!strcmp(stropt, analog_pattern_str[i])) {
-                                       pattern = i;
-                                       break;
-                               }
+               }
+               for (i = 0; i < ARRAY_SIZE(analog_pattern_str); i++) {
+                       if (!strcmp(stropt, analog_pattern_str[i])) {
+                               analog_pattern = i;
+                               break;
                        }
-                       if (pattern == -1)
+               }
+               if (logic_pattern == -1 && analog_pattern == -1)
+                       return SR_ERR_ARG;
+               for (l = cg->channels; l; l = l->next) {
+                       ch = l->data;
+                       if (ch->type == SR_CHANNEL_LOGIC) {
+                               if (logic_pattern == -1)
+                                       return SR_ERR_ARG;
+                               sr_dbg("Setting logic pattern to %s",
+                                               logic_pattern_str[logic_pattern]);
+                               devc->logic_pattern = logic_pattern;
+                               /* Might as well do this now, these are static. */
+                               if (logic_pattern == PATTERN_ALL_LOW)
+                                       memset(devc->logic_data, 0x00, LOGIC_BUFSIZE);
+                               else if (logic_pattern == PATTERN_ALL_HIGH)
+                                       memset(devc->logic_data, 0xff, LOGIC_BUFSIZE);
+                       } else if (ch->type == SR_CHANNEL_ANALOG) {
+                               if (analog_pattern == -1)
+                                       return SR_ERR_ARG;
+                               sr_dbg("Setting analog pattern for channel %s to %s",
+                                               ch->name, analog_pattern_str[analog_pattern]);
+                               ag = g_hash_table_lookup(devc->ch_ag, ch);
+                               ag->pattern = analog_pattern;
+                       } else
+                               return SR_ERR_BUG;
+               }
+               break;
+       case SR_CONF_AMPLITUDE:
+               if (!cg)
+                       return SR_ERR_CHANNEL_GROUP;
+               for (l = cg->channels; l; l = l->next) {
+                       ch = l->data;
+                       if (ch->type != SR_CHANNEL_ANALOG)
                                return SR_ERR_ARG;
-                       sr_dbg("Setting analog pattern for channel group %s to %s",
-                                       cg->name, analog_pattern_str[pattern]);
-                       ag = cg->priv;
-                       ag->pattern = pattern;
-               } else
-                       return SR_ERR_BUG;
+                       ag = g_hash_table_lookup(devc->ch_ag, ch);
+                       ag->amplitude = g_variant_get_double(data);
+               }
                break;
        default:
                ret = SR_ERR_NA;
@@ -508,7 +548,7 @@ static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
        return ret;
 }
 
-static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
+static int config_list(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
                const struct sr_channel_group *cg)
 {
        struct sr_channel *ch;
@@ -518,8 +558,14 @@ static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
        (void)sdi;
 
        if (key == SR_CONF_SCAN_OPTIONS) {
-               *data = g_variant_new_fixed_array(G_VARIANT_TYPE_INT32,
-                               scanopts, ARRAY_SIZE(scanopts), sizeof(int32_t));
+               *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
+                               scanopts, ARRAY_SIZE(scanopts), sizeof(uint32_t));
+               return SR_OK;
+       }
+
+       if (key == SR_CONF_DEVICE_OPTIONS && !sdi) {
+               *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
+                               devopts, ARRAY_SIZE(devopts), sizeof(uint32_t));
                return SR_OK;
        }
 
@@ -529,8 +575,8 @@ static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
        if (!cg) {
                switch (key) {
                case SR_CONF_DEVICE_OPTIONS:
-                       *data = g_variant_new_fixed_array(G_VARIANT_TYPE_INT32,
-                                       devopts, ARRAY_SIZE(devopts), sizeof(int32_t));
+                       *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
+                                       devopts_global, ARRAY_SIZE(devopts_global), sizeof(uint32_t));
                        break;
                case SR_CONF_SAMPLERATE:
                        g_variant_builder_init(&gvb, G_VARIANT_TYPE("a{sv}"));
@@ -543,11 +589,20 @@ static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
                        return SR_ERR_NA;
                }
        } else {
+               /* Any channel in the group will do. */
                ch = cg->channels->data;
                switch (key) {
                case SR_CONF_DEVICE_OPTIONS:
-                       *data = g_variant_new_fixed_array(G_VARIANT_TYPE_INT32,
-                                       devopts_cg, ARRAY_SIZE(devopts_cg), sizeof(int32_t));
+                       if (ch->type == SR_CHANNEL_LOGIC)
+                               *data = g_variant_new_fixed_array(G_VARIANT_TYPE_INT32,
+                                               devopts_cg_logic, ARRAY_SIZE(devopts_cg_logic),
+                                               sizeof(uint32_t));
+                       else if (ch->type == SR_CHANNEL_ANALOG)
+                               *data = g_variant_new_fixed_array(G_VARIANT_TYPE_INT32,
+                                               devopts_cg_analog, ARRAY_SIZE(devopts_cg_analog),
+                                               sizeof(uint32_t));
+                       else
+                               return SR_ERR_BUG;
                        break;
                case SR_CONF_PATTERN_MODE:
                        if (ch->type == SR_CHANNEL_LOGIC)
@@ -615,10 +670,10 @@ static int prepare_data(int fd, int revents, void *cb_data)
        struct dev_context *devc;
        struct sr_datafeed_packet packet;
        struct sr_datafeed_logic logic;
-       struct sr_channel_group *cg;
        struct analog_gen *ag;
-       GSList *l;
-       uint64_t logic_todo, analog_todo, expected_samplenum, analog_samples, sending_now;
+       GHashTableIter iter;
+       void *value;
+       uint64_t logic_todo, analog_todo, expected_samplenum, analog_sent, sending_now;
        int64_t time, elapsed;
 
        (void)fd;
@@ -626,21 +681,27 @@ static int prepare_data(int fd, int revents, void *cb_data)
 
        sdi = cb_data;
        devc = sdi->priv;
+       logic_todo = analog_todo = 0;
 
-       /* How many "virtual" samples should we have collected by now? */
+       /* How many samples should we have sent by now? */
        time = g_get_monotonic_time();
        elapsed = time - devc->starttime;
        expected_samplenum = elapsed * devc->cur_samplerate / 1000000;
 
+       /* But never more than the limit, if there is one. */
+       if (!devc->continuous)
+               expected_samplenum = MIN(expected_samplenum, devc->limit_samples);
+
        /* Of those, how many do we still have to send? */
-       logic_todo = MIN(expected_samplenum, devc->limit_samples) - devc->logic_counter;
-       analog_todo = MIN(expected_samplenum, devc->limit_samples) - devc->analog_counter;
+       if (devc->num_logic_channels)
+               logic_todo = expected_samplenum - devc->logic_counter;
+       if (devc->num_analog_channels)
+               analog_todo = expected_samplenum - devc->analog_counter;
 
        while (logic_todo || analog_todo) {
                /* Logic */
-               if (devc->num_logic_channels > 0 && logic_todo > 0) {
-                       sending_now = MIN(logic_todo,
-                                       LOGIC_BUFSIZE / devc->logic_unitsize);
+               if (logic_todo > 0) {
+                       sending_now = MIN(logic_todo, LOGIC_BUFSIZE / devc->logic_unitsize);
                        logic_generator(sdi, sending_now * devc->logic_unitsize);
                        packet.type = SR_DF_LOGIC;
                        packet.payload = &logic;
@@ -653,11 +714,12 @@ static int prepare_data(int fd, int revents, void *cb_data)
                }
 
                /* Analog, one channel at a time */
-               if (devc->num_analog_channels > 0 && analog_todo > 0) {
-                       sending_now = 0;
-                       for (l = devc->analog_channel_groups; l; l = l->next) {
-                               cg = l->data;
-                               ag = cg->priv;
+               if (analog_todo > 0) {
+                       analog_sent = 0;
+
+                       g_hash_table_iter_init(&iter, devc->ch_ag);
+                       while (g_hash_table_iter_next(&iter, NULL, &value)) {
+                               ag = value;
                                packet.type = SR_DF_ANALOG;
                                packet.payload = &ag->packet;
 
@@ -666,19 +728,21 @@ static int prepare_data(int fd, int revents, void *cb_data)
                                 * beginning of our buffer. A ring buffer would
                                 * help here as well */
 
-                               analog_samples = MIN(analog_todo, ag->num_samples);
-                               /* Whichever channel group gets there first. */
-                               sending_now = MAX(sending_now, analog_samples);
-                               ag->packet.num_samples = analog_samples;
+                               sending_now = MIN(analog_todo, ag->num_samples);
+                               ag->packet.num_samples = sending_now;
                                sr_session_send(sdi, &packet);
+
+                               /* Whichever channel group gets there first. */
+                               analog_sent = MAX(analog_sent, sending_now);
                        }
-                       analog_todo -= sending_now;
-                       devc->analog_counter += sending_now;
+                       analog_todo -= analog_sent;
+                       devc->analog_counter += analog_sent;
                }
        }
 
-       if (devc->logic_counter >= devc->limit_samples &&
-                       devc->analog_counter >= devc->limit_samples) {
+       if (!devc->continuous
+                       && (!devc->num_logic_channels || devc->logic_counter >= devc->limit_samples)
+                       && (!devc->num_analog_channels || devc->analog_counter >= devc->limit_samples)) {
                sr_dbg("Requested number of samples reached.");
                dev_acquisition_stop(sdi, cb_data);
                return TRUE;
@@ -689,8 +753,9 @@ static int prepare_data(int fd, int revents, void *cb_data)
 
 static int dev_acquisition_start(const struct sr_dev_inst *sdi, void *cb_data)
 {
-       GSList *l;
        struct dev_context *devc;
+       GHashTableIter iter;
+       void *value;
 
        (void)cb_data;
 
@@ -698,8 +763,7 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi, void *cb_data)
                return SR_ERR_DEV_CLOSED;
 
        devc = sdi->priv;
-       if (devc->limit_samples == 0)
-               return SR_ERR;
+       devc->continuous = !devc->limit_samples;
        devc->logic_counter = devc->analog_counter = 0;
 
        /*
@@ -714,22 +778,21 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi, void *cb_data)
                return SR_ERR;
        }
 
-       for (l = devc->analog_channel_groups; l; l = l->next) {
-               generate_analog_pattern(l->data, devc->cur_samplerate);
-       }
+       g_hash_table_iter_init(&iter, devc->ch_ag);
+       while (g_hash_table_iter_next(&iter, NULL, &value))
+               generate_analog_pattern(value, devc->cur_samplerate);
 
        devc->channel = g_io_channel_unix_new(devc->pipe_fds[0]);
-
        g_io_channel_set_flags(devc->channel, G_IO_FLAG_NONBLOCK, NULL);
 
        /* Set channel encoding to binary (default is UTF-8). */
        g_io_channel_set_encoding(devc->channel, NULL, NULL);
 
-       /* Make channels to unbuffered. */
+       /* Make channels unbuffered. */
        g_io_channel_set_buffered(devc->channel, FALSE);
 
-       sr_session_source_add_channel(sdi->session, devc->channel, G_IO_IN | G_IO_ERR,
-                       40, prepare_data, (void *)sdi);
+       sr_session_source_add_channel(sdi->session, devc->channel,
+                       G_IO_IN | G_IO_ERR, 40, prepare_data, (void *)sdi);
 
        /* Send header packet to the session bus. */
        std_session_send_df_header(sdi, LOG_PREFIX);