]> sigrok.org Git - libsigrok.git/blobdiff - hardware/saleae-logic/saleae-logic.c
sr: Fix/document probe names.
[libsigrok.git] / hardware / saleae-logic / saleae-logic.c
index 09a37cb29caa63dae0e0a98ae850c17c920f60ae..b986243b80a8693fe8bfbdb29c584e8e11596e1c 100644 (file)
@@ -1,7 +1,7 @@
 /*
  * This file is part of the sigrok project.
  *
- * Copyright (C) 2012 Bert Vermeulen <bert@biot.com>
+ * Copyright (C) 2010-2012 Bert Vermeulen <bert@biot.com>
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -36,7 +36,7 @@ static struct fx2_profile supported_fx2[] = {
        { 0, 0, 0, 0, 0, 0, 0, 0 }
 };
 
-static int capabilities[] = {
+static int hwcaps[] = {
        SR_HWCAP_LOGIC_ANALYZER,
        SR_HWCAP_SAMPLERATE,
 
@@ -46,6 +46,12 @@ static int capabilities[] = {
        0,
 };
 
+/*
+ * Probes are numbered 1-8.
+ *
+ * TODO: FX2 eval boards with the standard Cypress VID/PID can have 16 pins
+ * or probes in theory, which is not supported by the Saleae Logic firmware.
+ */
 static const char *probe_names[] = {
        "0",
        "1",
@@ -87,12 +93,14 @@ static struct sr_samplerates samplerates = {
        supported_samplerates,
 };
 
-/* List of struct sr_device_instance, maintained by opendev()/closedev(). */
-static GSList *device_instances = NULL;
+/* List of struct sr_dev_inst, maintained by dev_open()/dev_close(). */
+static GSList *dev_insts = NULL;
 static libusb_context *usb_context = NULL;
 
-static int hw_set_configuration(int device_index, int capability, void *value);
-static void hw_stop_acquisition(int device_index, gpointer session_device_id);
+static int new_saleae_logic_firmware = 0;
+
+static int hw_dev_config_set(int dev_index, int hwcap, void *value);
+static int hw_dev_acquisition_stop(int dev_index, gpointer session_dev_id);
 
 /**
  * Check the USB configuration to determine if this is a Saleae Logic.
@@ -130,20 +138,29 @@ static int check_conf_profile(libusb_device *dev)
                        break;
 
                intf_dsc = &(conf_dsc->interface[0].altsetting[0]);
-               if (intf_dsc->bNumEndpoints != 2)
-                       /* Need 2 endpoints. */
+               if (intf_dsc->bNumEndpoints == 4) {
+                       /* The new Saleae Logic firmware has 4 endpoints. */
+                       new_saleae_logic_firmware = 1;
+               } else if (intf_dsc->bNumEndpoints == 2) {
+                       /* The old Saleae Logic firmware has 2 endpoints. */
+                       new_saleae_logic_firmware = 0;
+               } else {
+                       /* Other number of endpoints -> not a Saleae Logic. */
                        break;
+               }
 
                if ((intf_dsc->endpoint[0].bEndpointAddress & 0x8f) !=
                    (1 | LIBUSB_ENDPOINT_OUT))
-                       /* First endpoint should be 1 (outbound). */
+                       /* The first endpoint should be 1 (outbound). */
                        break;
 
                if ((intf_dsc->endpoint[1].bEndpointAddress & 0x8f) !=
                    (2 | LIBUSB_ENDPOINT_IN))
-                       /* First endpoint should be 2 (inbound). */
+                       /* The second endpoint should be 2 (inbound). */
                        break;
 
+               /* TODO: The new firmware has 4 endpoints... */
+
                /* If we made it here, it must be a Saleae Logic. */
                ret = 1;
        }
@@ -154,17 +171,17 @@ static int check_conf_profile(libusb_device *dev)
        return ret;
 }
 
-static int sl_open_device(int device_index)
+static int sl_open_dev(int dev_index)
 {
        libusb_device **devlist;
        struct libusb_device_descriptor des;
-       struct sr_device_instance *sdi;
-       struct fx2_device *fx2;
+       struct sr_dev_inst *sdi;
+       struct context *ctx;
        int err, skip, i;
 
-       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
                return SR_ERR;
-       fx2 = sdi->priv;
+       ctx = sdi->priv;
 
        if (sdi->status == SR_ST_ACTIVE)
                /* already in use */
@@ -174,44 +191,45 @@ static int sl_open_device(int device_index)
        libusb_get_device_list(usb_context, &devlist);
        for (i = 0; devlist[i]; i++) {
                if ((err = libusb_get_device_descriptor(devlist[i], &des))) {
-                       sr_warn("failed to get device descriptor: %d", err);
+                       sr_err("logic: failed to get device descriptor: %d", err);
                        continue;
                }
 
-               if (des.idVendor != fx2->profile->fw_vid || des.idProduct != fx2->profile->fw_pid)
+               if (des.idVendor != ctx->profile->fw_vid
+                   || des.idProduct != ctx->profile->fw_pid)
                        continue;
 
                if (sdi->status == SR_ST_INITIALIZING) {
-                       if (skip != device_index) {
+                       if (skip != dev_index) {
                                /* Skip devices of this type that aren't the one we want. */
                                skip += 1;
                                continue;
                        }
                } else if (sdi->status == SR_ST_INACTIVE) {
                        /*
-                        * This device is fully enumerated, so we need to find this
-                        * device by vendor, product, bus and address.
+                        * This device is fully enumerated, so we need to find
+                        * this device by vendor, product, bus and address.
                         */
-                       if (libusb_get_bus_number(devlist[i]) != fx2->usb->bus
-                               || libusb_get_device_address(devlist[i]) != fx2->usb->address)
+                       if (libusb_get_bus_number(devlist[i]) != ctx->usb->bus
+                               || libusb_get_device_address(devlist[i]) != ctx->usb->address)
                                /* this is not the one */
                                continue;
                }
 
-               if (!(err = libusb_open(devlist[i], &fx2->usb->devhdl))) {
-                       if (fx2->usb->address == 0xff)
+               if (!(err = libusb_open(devlist[i], &ctx->usb->devhdl))) {
+                       if (ctx->usb->address == 0xff)
                                /*
                                 * first time we touch this device after firmware upload,
                                 * so we don't know the address yet.
                                 */
-                               fx2->usb->address = libusb_get_device_address(devlist[i]);
+                               ctx->usb->address = libusb_get_device_address(devlist[i]);
 
                        sdi->status = SR_ST_ACTIVE;
-                       sr_info("saleae: opened device %d on %d.%d interface %d",
-                                 sdi->index, fx2->usb->bus,
-                                 fx2->usb->address, USB_INTERFACE);
+                       sr_info("logic: opened device %d on %d.%d interface %d",
+                               sdi->index, ctx->usb->bus,
+                               ctx->usb->address, USB_INTERFACE);
                } else {
-                       sr_warn("failed to open device: %d", err);
+                       sr_err("logic: failed to open device: %d", err);
                }
 
                /* if we made it here, we handled the device one way or another */
@@ -225,34 +243,34 @@ static int sl_open_device(int device_index)
        return SR_OK;
 }
 
-static void close_device(struct sr_device_instance *sdi)
+static void close_dev(struct sr_dev_inst *sdi)
 {
-       struct fx2_device *fx2;
+       struct context *ctx;
 
-       fx2 = sdi->priv;
+       ctx = sdi->priv;
 
-       if (fx2->usb->devhdl == NULL)
+       if (ctx->usb->devhdl == NULL)
                return;
 
-       sr_info("saleae: closing device %d on %d.%d interface %d", sdi->index,
-               fx2->usb->bus, fx2->usb->address, USB_INTERFACE);
-       libusb_release_interface(fx2->usb->devhdl, USB_INTERFACE);
-       libusb_close(fx2->usb->devhdl);
-       fx2->usb->devhdl = NULL;
+       sr_info("logic: closing device %d on %d.%d interface %d", sdi->index,
+               ctx->usb->bus, ctx->usb->address, USB_INTERFACE);
+       libusb_release_interface(ctx->usb->devhdl, USB_INTERFACE);
+       libusb_close(ctx->usb->devhdl);
+       ctx->usb->devhdl = NULL;
        sdi->status = SR_ST_INACTIVE;
 }
 
-static int configure_probes(struct fx2_device *fx2, GSList *probes)
+static int configure_probes(struct context *ctx, GSList *probes)
 {
        struct sr_probe *probe;
        GSList *l;
        int probe_bit, stage, i;
        char *tc;
 
-       fx2->probe_mask = 0;
+       ctx->probe_mask = 0;
        for (i = 0; i < NUM_TRIGGER_STAGES; i++) {
-               fx2->trigger_mask[i] = 0;
-               fx2->trigger_value[i] = 0;
+               ctx->trigger_mask[i] = 0;
+               ctx->trigger_value[i] = 0;
        }
 
        stage = -1;
@@ -261,15 +279,15 @@ static int configure_probes(struct fx2_device *fx2, GSList *probes)
                if (probe->enabled == FALSE)
                        continue;
                probe_bit = 1 << (probe->index - 1);
-               fx2->probe_mask |= probe_bit;
+               ctx->probe_mask |= probe_bit;
                if (!(probe->trigger))
                        continue;
 
                stage = 0;
                for (tc = probe->trigger; *tc; tc++) {
-                       fx2->trigger_mask[stage] |= probe_bit;
+                       ctx->trigger_mask[stage] |= probe_bit;
                        if (*tc == '1')
-                               fx2->trigger_value[stage] |= probe_bit;
+                               ctx->trigger_value[stage] |= probe_bit;
                        stage++;
                        if (stage > NUM_TRIGGER_STAGES)
                                return SR_ERR;
@@ -281,25 +299,25 @@ static int configure_probes(struct fx2_device *fx2, GSList *probes)
                 * We didn't configure any triggers, make sure acquisition
                 * doesn't wait for any.
                 */
-               fx2->trigger_stage = TRIGGER_FIRED;
+               ctx->trigger_stage = TRIGGER_FIRED;
        else
-               fx2->trigger_stage = 0;
+               ctx->trigger_stage = 0;
 
        return SR_OK;
 }
 
-static struct fx2_device *fx2_device_new(void)
+static struct context *fx2_dev_new(void)
 {
-       struct fx2_device *fx2;
+       struct context *ctx;
 
-       if (!(fx2 = g_try_malloc0(sizeof(struct fx2_device)))) {
-               sr_err("saleae: %s: fx2 malloc failed", __func__);
+       if (!(ctx = g_try_malloc0(sizeof(struct context)))) {
+               sr_err("logic: %s: ctx malloc failed", __func__);
                return NULL;
        }
-       fx2->trigger_stage = TRIGGER_FIRED;
-       fx2->usb = NULL;
+       ctx->trigger_stage = TRIGGER_FIRED;
+       ctx->usb = NULL;
 
-       return fx2;
+       return ctx;
 }
 
 
@@ -307,20 +325,20 @@ static struct fx2_device *fx2_device_new(void)
  * API callbacks
  */
 
-static int hw_init(const char *deviceinfo)
+static int hw_init(const char *devinfo)
 {
-       struct sr_device_instance *sdi;
+       struct sr_dev_inst *sdi;
        struct libusb_device_descriptor des;
        struct fx2_profile *fx2_prof;
-       struct fx2_device *fx2;
+       struct context *ctx;
        libusb_device **devlist;
        int err, devcnt, i, j;
 
        /* Avoid compiler warnings. */
-       (void)deviceinfo;
+       (void)devinfo;
 
        if (libusb_init(&usb_context) != 0) {
-               sr_warn("Failed to initialize USB.");
+               sr_err("logic: Failed to initialize USB.");
                return 0;
        }
 
@@ -331,7 +349,8 @@ static int hw_init(const char *deviceinfo)
                fx2_prof = NULL;
                err = libusb_get_device_descriptor(devlist[i], &des);
                if (err != 0) {
-                       sr_warn("failed to get device descriptor: %d", err);
+                       sr_err("logic: failed to get device descriptor: %d",
+                              err);
                        continue;
                }
 
@@ -346,28 +365,31 @@ static int hw_init(const char *deviceinfo)
                        /* not a supported VID/PID */
                        continue;
 
-               sdi = sr_device_instance_new(devcnt, SR_ST_INITIALIZING,
+               sdi = sr_dev_inst_new(devcnt, SR_ST_INITIALIZING,
                        fx2_prof->vendor, fx2_prof->model, fx2_prof->model_version);
                if (!sdi)
                        return 0;
-               fx2 = fx2_device_new();
-               fx2->profile = fx2_prof;
-               sdi->priv = fx2;
-               device_instances = g_slist_append(device_instances, sdi);
+               ctx = fx2_dev_new();
+               ctx->profile = fx2_prof;
+               sdi->priv = ctx;
+               dev_insts = g_slist_append(dev_insts, sdi);
 
                if (check_conf_profile(devlist[i])) {
                        /* Already has the firmware, so fix the new address. */
+                       sr_dbg("logic: Found a Saleae Logic with %s firmware.",
+                              new_saleae_logic_firmware ? "new" : "old");
                        sdi->status = SR_ST_INACTIVE;
-                       fx2->usb = sr_usb_device_instance_new
+                       ctx->usb = sr_usb_dev_inst_new
                            (libusb_get_bus_number(devlist[i]),
                             libusb_get_device_address(devlist[i]), NULL);
                } else {
                        if (ezusb_upload_firmware(devlist[i], USB_CONFIGURATION, FIRMWARE) == SR_OK)
                                /* Remember when the firmware on this device was updated */
-                               g_get_current_time(&fx2->fw_updated);
+                               g_get_current_time(&ctx->fw_updated);
                        else
-                               sr_warn("firmware upload failed for device %d", devcnt);
-                       fx2->usb = sr_usb_device_instance_new
+                               sr_err("logic: firmware upload failed for "
+                                      "device %d", devcnt);
+                       ctx->usb = sr_usb_dev_inst_new
                                (libusb_get_bus_number(devlist[i]), 0xff, NULL);
                }
                devcnt++;
@@ -377,54 +399,54 @@ static int hw_init(const char *deviceinfo)
        return devcnt;
 }
 
-static int hw_opendev(int device_index)
+static int hw_dev_open(int dev_index)
 {
        GTimeVal cur_time;
-       struct sr_device_instance *sdi;
-       struct fx2_device *fx2;
+       struct sr_dev_inst *sdi;
+       struct context *ctx;
        int timediff, err;
 
-       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
                return SR_ERR;
-       fx2 = sdi->priv;
+       ctx = sdi->priv;
 
        /*
         * if the firmware was recently uploaded, wait up to MAX_RENUM_DELAY ms
         * for the FX2 to renumerate
         */
        err = 0;
-       if (GTV_TO_MSEC(fx2->fw_updated) > 0) {
-               sr_info("saleae: waiting for device to reset");
+       if (GTV_TO_MSEC(ctx->fw_updated) > 0) {
+               sr_info("logic: waiting for device to reset");
                /* takes at least 300ms for the FX2 to be gone from the USB bus */
-               g_usleep(300*1000);
+               g_usleep(300 * 1000);
                timediff = 0;
                while (timediff < MAX_RENUM_DELAY) {
-                       if ((err = sl_open_device(device_index)) == SR_OK)
+                       if ((err = sl_open_dev(dev_index)) == SR_OK)
                                break;
-                       g_usleep(100*1000);
+                       g_usleep(100 * 1000);
                        g_get_current_time(&cur_time);
-                       timediff = GTV_TO_MSEC(cur_time) - GTV_TO_MSEC(fx2->fw_updated);
+                       timediff = GTV_TO_MSEC(cur_time) - GTV_TO_MSEC(ctx->fw_updated);
                }
-               sr_info("saleae: device came back after %d ms", timediff);
+               sr_info("logic: device came back after %d ms", timediff);
        } else {
-               err = sl_open_device(device_index);
+               err = sl_open_dev(dev_index);
        }
 
        if (err != SR_OK) {
-               sr_warn("unable to open device");
+               sr_err("logic: unable to open device");
                return SR_ERR;
        }
-       fx2 = sdi->priv;
+       ctx = sdi->priv;
 
-       err = libusb_claim_interface(fx2->usb->devhdl, USB_INTERFACE);
+       err = libusb_claim_interface(ctx->usb->devhdl, USB_INTERFACE);
        if (err != 0) {
-               sr_warn("Unable to claim interface: %d", err);
+               sr_err("logic: Unable to claim interface: %d", err);
                return SR_ERR;
        }
 
-       if (fx2->cur_samplerate == 0) {
+       if (ctx->cur_samplerate == 0) {
                /* Samplerate hasn't been set; default to the slowest one. */
-               if (hw_set_configuration(device_index, SR_HWCAP_SAMPLERATE,
+               if (hw_dev_config_set(dev_index, SR_HWCAP_SAMPLERATE,
                    &supported_samplerates[0]) == SR_ERR)
                        return SR_ERR;
        }
@@ -432,60 +454,74 @@ static int hw_opendev(int device_index)
        return SR_OK;
 }
 
-static int hw_closedev(int device_index)
+static int hw_dev_close(int dev_index)
 {
-       struct sr_device_instance *sdi;
+       struct sr_dev_inst *sdi;
 
-       if (!(sdi = sr_get_device_instance(device_instances, device_index))) {
+       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index))) {
                sr_err("logic: %s: sdi was NULL", __func__);
                return SR_ERR; /* TODO: SR_ERR_ARG? */
        }
 
        /* TODO */
-       close_device(sdi);
+       close_dev(sdi);
 
        return SR_OK;
 }
 
-static void hw_cleanup(void)
+static int hw_cleanup(void)
 {
        GSList *l;
-       struct sr_device_instance *sdi;
-       struct fx2_device *fx2;
+       struct sr_dev_inst *sdi;
+       struct context *ctx;
+       int ret = SR_OK;
 
        /* Properly close and free all devices. */
-       for (l = device_instances; l; l = l->next) {
-               sdi = l->data;
-               fx2 = sdi->priv;
-               close_device(sdi);
-               sr_usb_device_instance_free(fx2->usb);
-               sr_device_instance_free(sdi);
+       for (l = dev_insts; l; l = l->next) {
+               if (!(sdi = l->data)) {
+                       /* Log error, but continue cleaning up the rest. */
+                       sr_err("logic: %s: sdi was NULL, continuing", __func__);
+                       ret = SR_ERR_BUG;
+                       continue;
+               }
+               if (!(ctx = sdi->priv)) {
+                       /* Log error, but continue cleaning up the rest. */
+                       sr_err("logic: %s: sdi->priv was NULL, continuing",
+                              __func__);
+                       ret = SR_ERR_BUG;
+                       continue;
+               }
+               close_dev(sdi);
+               sr_usb_dev_inst_free(ctx->usb);
+               sr_dev_inst_free(sdi);
        }
 
-       g_slist_free(device_instances);
-       device_instances = NULL;
+       g_slist_free(dev_insts);
+       dev_insts = NULL;
 
        if (usb_context)
                libusb_exit(usb_context);
        usb_context = NULL;
+
+       return ret;
 }
 
-static void *hw_get_device_info(int device_index, int device_info_id)
+static void *hw_dev_info_get(int dev_index, int dev_info_id)
 {
-       struct sr_device_instance *sdi;
-       struct fx2_device *fx2;
+       struct sr_dev_inst *sdi;
+       struct context *ctx;
        void *info = NULL;
 
-       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
                return NULL;
-       fx2 = sdi->priv;
+       ctx = sdi->priv;
 
-       switch (device_info_id) {
-       case SR_DI_INSTANCE:
+       switch (dev_info_id) {
+       case SR_DI_INST:
                info = sdi;
                break;
        case SR_DI_NUM_PROBES:
-               info = GINT_TO_POINTER(fx2->profile->num_probes);
+               info = GINT_TO_POINTER(ctx->profile->num_probes);
                break;
        case SR_DI_PROBE_NAMES:
                info = probe_names;
@@ -497,38 +533,78 @@ static void *hw_get_device_info(int device_index, int device_info_id)
                info = TRIGGER_TYPES;
                break;
        case SR_DI_CUR_SAMPLERATE:
-               info = &fx2->cur_samplerate;
+               info = &ctx->cur_samplerate;
                break;
        }
 
        return info;
 }
 
-static int hw_get_status(int device_index)
+static int hw_dev_status_get(int dev_index)
 {
-       struct sr_device_instance *sdi;
+       struct sr_dev_inst *sdi;
 
-       sdi = sr_get_device_instance(device_instances, device_index);
+       sdi = sr_dev_inst_get(dev_insts, dev_index);
        if (sdi)
                return sdi->status;
        else
                return SR_ST_NOT_FOUND;
 }
 
-static int *hw_get_capabilities(void)
+static int *hw_hwcap_get_all(void)
+{
+       return hwcaps;
+}
+
+static uint8_t new_firmware_divider_value(uint64_t samplerate)
 {
-       return capabilities;
+       switch (samplerate) {
+       case SR_MHZ(24):
+               return 0xe0;
+               break;
+       case SR_MHZ(16):
+               return 0xd5;
+               break;
+       case SR_MHZ(12):
+               return 0xe2;
+               break;
+       case SR_MHZ(8):
+               return 0xd4;
+               break;
+       case SR_MHZ(4):
+               return 0xda;
+               break;
+       case SR_MHZ(2):
+               return 0xe6;
+               break;
+       case SR_MHZ(1):
+               return 0x8e;
+               break;
+       case SR_KHZ(500):
+               return 0xfe;
+               break;
+       case SR_KHZ(250):
+               return 0x9e;
+               break;
+       case SR_KHZ(200):
+               return 0x4e;
+               break;
+       }
+
+       /* Shouldn't happen. */
+       sr_err("logic: %s: Invalid samplerate %" PRIu64 "",
+              __func__, samplerate);
+       return 0;
 }
 
-static int set_configuration_samplerate(struct sr_device_instance *sdi,
-                                       uint64_t samplerate)
+static int set_samplerate(struct sr_dev_inst *sdi, uint64_t samplerate)
 {
-       struct fx2_device *fx2;
+       struct context *ctx;
        uint8_t divider;
        int ret, result, i;
        unsigned char buf[2];
 
-       fx2 = sdi->priv;
+       ctx = sdi->priv;
        for (i = 0; supported_samplerates[i]; i++) {
                if (supported_samplerates[i] == samplerate)
                        break;
@@ -536,42 +612,43 @@ static int set_configuration_samplerate(struct sr_device_instance *sdi,
        if (supported_samplerates[i] == 0)
                return SR_ERR_SAMPLERATE;
 
-       divider = (uint8_t) (48 / (samplerate / 1000000.0)) - 1;
+       if (new_saleae_logic_firmware)
+               divider = new_firmware_divider_value(samplerate);
+       else
+               divider = (uint8_t) (48 / (samplerate / 1000000.0)) - 1;
 
-       sr_info("saleae: setting samplerate to %" PRIu64 " Hz (divider %d)",
+       sr_info("logic: setting samplerate to %" PRIu64 " Hz (divider %d)",
                samplerate, divider);
-       buf[0] = 0x01;
+
+       buf[0] = (new_saleae_logic_firmware) ? 0xd5 : 0x01;
        buf[1] = divider;
-       ret = libusb_bulk_transfer(fx2->usb->devhdl, 1 | LIBUSB_ENDPOINT_OUT,
+       ret = libusb_bulk_transfer(ctx->usb->devhdl, 1 | LIBUSB_ENDPOINT_OUT,
                                   buf, 2, &result, 500);
        if (ret != 0) {
-               sr_warn("failed to set samplerate: %d", ret);
+               sr_err("logic: failed to set samplerate: %d", ret);
                return SR_ERR;
        }
-       fx2->cur_samplerate = samplerate;
+       ctx->cur_samplerate = samplerate;
 
        return SR_OK;
 }
 
-static int hw_set_configuration(int device_index, int capability, void *value)
+static int hw_dev_config_set(int dev_index, int hwcap, void *value)
 {
-       struct sr_device_instance *sdi;
-       struct fx2_device *fx2;
+       struct sr_dev_inst *sdi;
+       struct context *ctx;
        int ret;
-       uint64_t *tmp_u64;
 
-       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
                return SR_ERR;
-       fx2 = sdi->priv;
-
-       if (capability == SR_HWCAP_SAMPLERATE) {
-               tmp_u64 = value;
-               ret = set_configuration_samplerate(sdi, *tmp_u64);
-       } else if (capability == SR_HWCAP_PROBECONFIG) {
-               ret = configure_probes(fx2, (GSList *) value);
-       } else if (capability == SR_HWCAP_LIMIT_SAMPLES) {
-               tmp_u64 = value;
-               fx2->limit_samples = *tmp_u64;
+       ctx = sdi->priv;
+
+       if (hwcap == SR_HWCAP_SAMPLERATE) {
+               ret = set_samplerate(sdi, *(uint64_t *)value);
+       } else if (hwcap == SR_HWCAP_PROBECONFIG) {
+               ret = configure_probes(ctx, (GSList *) value);
+       } else if (hwcap == SR_HWCAP_LIMIT_SAMPLES) {
+               ctx->limit_samples = *(uint64_t *)value;
                ret = SR_OK;
        } else {
                ret = SR_ERR;
@@ -597,16 +674,16 @@ static int receive_data(int fd, int revents, void *user_data)
 
 static void receive_transfer(struct libusb_transfer *transfer)
 {
-       /* TODO: these statics have to move to fx2_device struct */
+       /* TODO: These statics have to move to the ctx struct. */
        static int num_samples = 0;
        static int empty_transfer_count = 0;
        struct sr_datafeed_packet packet;
        struct sr_datafeed_logic logic;
-       struct fx2_device *fx2;
+       struct context *ctx;
        int cur_buflen, trigger_offset, i;
        unsigned char *cur_buf, *new_buf;
 
-       /* hw_stop_acquisition() is telling us to stop. */
+       /* hw_dev_acquisition_stop() is telling us to stop. */
        if (transfer == NULL)
                num_samples = -1;
 
@@ -620,26 +697,26 @@ static void receive_transfer(struct libusb_transfer *transfer)
                return;
        }
 
-       sr_info("saleae: receive_transfer(): status %d received %d bytes",
+       sr_info("logic: receive_transfer(): status %d received %d bytes",
                transfer->status, transfer->actual_length);
 
        /* Save incoming transfer before reusing the transfer struct. */
        cur_buf = transfer->buffer;
        cur_buflen = transfer->actual_length;
-       fx2 = transfer->user_data;
+       ctx = transfer->user_data;
 
        /* Fire off a new request. */
        if (!(new_buf = g_try_malloc(4096))) {
-               sr_err("saleae: %s: new_buf malloc failed", __func__);
-               // return SR_ERR_MALLOC;
-               return; /* FIXME */
+               sr_err("logic: %s: new_buf malloc failed", __func__);
+               return; /* TODO: SR_ERR_MALLOC */
        }
 
        transfer->buffer = new_buf;
        transfer->length = 4096;
        if (libusb_submit_transfer(transfer) != 0) {
                /* TODO: Stop session? */
-               sr_warn("eek");
+               /* TODO: Better error message. */
+               sr_err("logic: %s: libusb_submit_transfer error", __func__);
        }
 
        if (cur_buflen == 0) {
@@ -649,7 +726,7 @@ static void receive_transfer(struct libusb_transfer *transfer)
                         * The FX2 gave up. End the acquisition, the frontend
                         * will work out that the samplecount is short.
                         */
-                       hw_stop_acquisition(-1, fx2->session_data);
+                       hw_dev_acquisition_stop(-1, ctx->session_data);
                }
                return;
        } else {
@@ -657,15 +734,15 @@ static void receive_transfer(struct libusb_transfer *transfer)
        }
 
        trigger_offset = 0;
-       if (fx2->trigger_stage >= 0) {
+       if (ctx->trigger_stage >= 0) {
                for (i = 0; i < cur_buflen; i++) {
 
-                       if ((cur_buf[i] & fx2->trigger_mask[fx2->trigger_stage]) == fx2->trigger_value[fx2->trigger_stage]) {
+                       if ((cur_buf[i] & ctx->trigger_mask[ctx->trigger_stage]) == ctx->trigger_value[ctx->trigger_stage]) {
                                /* Match on this trigger stage. */
-                               fx2->trigger_buffer[fx2->trigger_stage] = cur_buf[i];
-                               fx2->trigger_stage++;
+                               ctx->trigger_buffer[ctx->trigger_stage] = cur_buf[i];
+                               ctx->trigger_stage++;
 
-                               if (fx2->trigger_stage == NUM_TRIGGER_STAGES || fx2->trigger_mask[fx2->trigger_stage] == 0) {
+                               if (ctx->trigger_stage == NUM_TRIGGER_STAGES || ctx->trigger_mask[ctx->trigger_stage] == 0) {
                                        /* Match on all trigger stages, we're done. */
                                        trigger_offset = i + 1;
 
@@ -675,7 +752,7 @@ static void receive_transfer(struct libusb_transfer *transfer)
                                         */
                                        packet.type = SR_DF_TRIGGER;
                                        packet.payload = NULL;
-                                       sr_session_bus(fx2->session_data, &packet);
+                                       sr_session_bus(ctx->session_data, &packet);
 
                                        /*
                                         * Send the samples that triggered it, since we're
@@ -683,12 +760,12 @@ static void receive_transfer(struct libusb_transfer *transfer)
                                         */
                                        packet.type = SR_DF_LOGIC;
                                        packet.payload = &logic;
-                                       logic.length = fx2->trigger_stage;
+                                       logic.length = ctx->trigger_stage;
                                        logic.unitsize = 1;
-                                       logic.data = fx2->trigger_buffer;
-                                       sr_session_bus(fx2->session_data, &packet);
+                                       logic.data = ctx->trigger_buffer;
+                                       sr_session_bus(ctx->session_data, &packet);
 
-                                       fx2->trigger_stage = TRIGGER_FIRED;
+                                       ctx->trigger_stage = TRIGGER_FIRED;
                                        break;
                                }
                                return;
@@ -701,29 +778,29 @@ static void receive_transfer(struct libusb_transfer *transfer)
                         * the next sample from the one that matched originally, which the
                         * counter increment at the end of the loop takes care of.
                         */
-                       if (fx2->trigger_stage > 0) {
-                               i -= fx2->trigger_stage;
+                       if (ctx->trigger_stage > 0) {
+                               i -= ctx->trigger_stage;
                                if (i < -1)
                                        i = -1; /* Oops, went back past this buffer. */
                                /* Reset trigger stage. */
-                               fx2->trigger_stage = 0;
+                               ctx->trigger_stage = 0;
                        }
                }
        }
 
-       if (fx2->trigger_stage == TRIGGER_FIRED) {
+       if (ctx->trigger_stage == TRIGGER_FIRED) {
                /* Send the incoming transfer to the session bus. */
                packet.type = SR_DF_LOGIC;
                packet.payload = &logic;
                logic.length = cur_buflen - trigger_offset;
                logic.unitsize = 1;
                logic.data = cur_buf + trigger_offset;
-               sr_session_bus(fx2->session_data, &packet);
+               sr_session_bus(ctx->session_data, &packet);
                g_free(cur_buf);
 
                num_samples += cur_buflen;
-               if (fx2->limit_samples && (unsigned int) num_samples > fx2->limit_samples) {
-                       hw_stop_acquisition(-1, fx2->session_data);
+               if (ctx->limit_samples && (unsigned int) num_samples > ctx->limit_samples) {
+                       hw_dev_acquisition_stop(-1, ctx->session_data);
                }
        } else {
                /*
@@ -733,29 +810,29 @@ static void receive_transfer(struct libusb_transfer *transfer)
        }
 }
 
-static int hw_start_acquisition(int device_index, gpointer session_data)
+static int hw_dev_acquisition_start(int dev_index, gpointer session_data)
 {
-       struct sr_device_instance *sdi;
+       struct sr_dev_inst *sdi;
        struct sr_datafeed_packet *packet;
        struct sr_datafeed_header *header;
-       struct fx2_device *fx2;
+       struct context *ctx;
        struct libusb_transfer *transfer;
        const struct libusb_pollfd **lupfd;
        int size, i;
        unsigned char *buf;
 
-       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
                return SR_ERR;
-       fx2 = sdi->priv;
-       fx2->session_data = session_data;
+       ctx = sdi->priv;
+       ctx->session_data = session_data;
 
        if (!(packet = g_try_malloc(sizeof(struct sr_datafeed_packet)))) {
-               sr_err("saleae: %s: packet malloc failed", __func__);
+               sr_err("logic: %s: packet malloc failed", __func__);
                return SR_ERR_MALLOC;
        }
 
        if (!(header = g_try_malloc(sizeof(struct sr_datafeed_header)))) {
-               sr_err("saleae: %s: header malloc failed", __func__);
+               sr_err("logic: %s: header malloc failed", __func__);
                return SR_ERR_MALLOC;
        }
 
@@ -763,13 +840,13 @@ static int hw_start_acquisition(int device_index, gpointer session_data)
        size = 2048;
        for (i = 0; i < NUM_SIMUL_TRANSFERS; i++) {
                if (!(buf = g_try_malloc(size))) {
-                       sr_err("saleae: %s: buf malloc failed", __func__);
+                       sr_err("logic: %s: buf malloc failed", __func__);
                        return SR_ERR_MALLOC;
                }
                transfer = libusb_alloc_transfer(0);
-               libusb_fill_bulk_transfer(transfer, fx2->usb->devhdl,
+               libusb_fill_bulk_transfer(transfer, ctx->usb->devhdl,
                                2 | LIBUSB_ENDPOINT_IN, buf, size,
-                               receive_transfer, fx2, 40);
+                               receive_transfer, ctx, 40);
                if (libusb_submit_transfer(transfer) != 0) {
                        /* TODO: Free them all. */
                        libusb_free_transfer(transfer);
@@ -783,14 +860,14 @@ static int hw_start_acquisition(int device_index, gpointer session_data)
        for (i = 0; lupfd[i]; i++)
                sr_source_add(lupfd[i]->fd, lupfd[i]->events, 40, receive_data,
                              NULL);
-       free(lupfd);
+       free(lupfd); /* NOT g_free()! */
 
        packet->type = SR_DF_HEADER;
        packet->payload = header;
        header->feed_version = 1;
        gettimeofday(&header->starttime, NULL);
-       header->samplerate = fx2->cur_samplerate;
-       header->num_logic_probes = fx2->profile->num_probes;
+       header->samplerate = ctx->cur_samplerate;
+       header->num_logic_probes = ctx->profile->num_probes;
        sr_session_bus(session_data, packet);
        g_free(header);
        g_free(packet);
@@ -798,13 +875,13 @@ static int hw_start_acquisition(int device_index, gpointer session_data)
        return SR_OK;
 }
 
-/* This stops acquisition on ALL devices, ignoring device_index. */
-static void hw_stop_acquisition(int device_index, gpointer session_data)
+/* This stops acquisition on ALL devices, ignoring dev_index. */
+static int hw_dev_acquisition_stop(int dev_index, gpointer session_data)
 {
        struct sr_datafeed_packet packet;
 
        /* Avoid compiler warnings. */
-       (void)device_index;
+       (void)dev_index;
 
        packet.type = SR_DF_END;
        sr_session_bus(session_data, &packet);
@@ -812,20 +889,22 @@ static void hw_stop_acquisition(int device_index, gpointer session_data)
        receive_transfer(NULL);
 
        /* TODO: Need to cancel and free any queued up transfers. */
+
+       return SR_OK;
 }
 
-SR_PRIV struct sr_device_plugin saleae_logic_plugin_info = {
+SR_PRIV struct sr_dev_plugin saleae_logic_plugin_info = {
        .name = "saleae-logic",
        .longname = "Saleae Logic",
        .api_version = 1,
        .init = hw_init,
        .cleanup = hw_cleanup,
-       .opendev = hw_opendev,
-       .closedev = hw_closedev,
-       .get_device_info = hw_get_device_info,
-       .get_status = hw_get_status,
-       .get_capabilities = hw_get_capabilities,
-       .set_configuration = hw_set_configuration,
-       .start_acquisition = hw_start_acquisition,
-       .stop_acquisition = hw_stop_acquisition,
+       .dev_open = hw_dev_open,
+       .dev_close = hw_dev_close,
+       .dev_info_get = hw_dev_info_get,
+       .dev_status_get = hw_dev_status_get,
+       .hwcap_get_all = hw_hwcap_get_all,
+       .dev_config_set = hw_dev_config_set,
+       .dev_acquisition_start = hw_dev_acquisition_start,
+       .dev_acquisition_stop = hw_dev_acquisition_stop,
 };