*/
/* Needed for isascii(), as used in the GNU libstdc++ headers */
+/* Needed in strutil.c for POSIX.1-2008 locale functions */
#ifndef _XOPEN_SOURCE
-#define _XOPEN_SOURCE 600
+#define _XOPEN_SOURCE 700
#endif
#include <config.h>
/** Helper function to convert between map<string, VariantBase> and GHashTable */
static GHashTable *map_to_hash_variant(const map<string, Glib::VariantBase> &input)
{
- auto output = g_hash_table_new_full(g_str_hash, g_str_equal, g_free,
+ auto *const output = g_hash_table_new_full(g_str_hash, g_str_equal, g_free,
reinterpret_cast<GDestroyNotify>(&g_variant_unref));
- for (auto entry : input)
+ for (const auto &entry : input)
g_hash_table_insert(output,
g_strdup(entry.first.c_str()),
entry.second.gobj_copy());
}
SR_PRIV int ResourceReader::open_callback(struct sr_resource *res,
- const char *name, void *cb_data)
+ const char *name, void *cb_data) noexcept
{
try {
auto *const reader = static_cast<ResourceReader*>(cb_data);
return SR_OK;
}
-SR_PRIV int ResourceReader::close_callback(struct sr_resource *res, void *cb_data)
+SR_PRIV int ResourceReader::close_callback(struct sr_resource *res,
+ void *cb_data) noexcept
{
try {
auto *const reader = static_cast<ResourceReader*>(cb_data);
return SR_OK;
}
-SR_PRIV ssize_t ResourceReader::read_callback(const struct sr_resource *res,
- void *buf, size_t count, void *cb_data)
+SR_PRIV gssize ResourceReader::read_callback(const struct sr_resource *res,
+ void *buf, size_t count, void *cb_data) noexcept
{
try {
auto *const reader = static_cast<ResourceReader*>(cb_data);
shared_ptr<Context> Context::create()
{
- return shared_ptr<Context>(new Context(), Context::Deleter());
+ return shared_ptr<Context>{new Context{}, default_delete<Context>{}};
}
Context::Context() :
- UserOwned(_structure),
+ _structure(nullptr),
_session(nullptr)
{
check(sr_init(&_structure));
- struct sr_dev_driver **driver_list = sr_driver_list(_structure);
- if (driver_list)
- for (int i = 0; driver_list[i]; i++)
- _drivers[driver_list[i]->name] =
- new Driver(driver_list[i]);
- const struct sr_input_module **input_list = sr_input_list();
- if (input_list)
- for (int i = 0; input_list[i]; i++)
- _input_formats[sr_input_id_get(input_list[i])] =
- new InputFormat(input_list[i]);
- const struct sr_output_module **output_list = sr_output_list();
- if (output_list)
- for (int i = 0; output_list[i]; i++)
- _output_formats[sr_output_id_get(output_list[i])] =
- new OutputFormat(output_list[i]);
+ if (struct sr_dev_driver **driver_list = sr_driver_list(_structure))
+ for (int i = 0; driver_list[i]; i++) {
+ unique_ptr<Driver> driver {new Driver{driver_list[i]}};
+ _drivers.emplace(driver->name(), move(driver));
+ }
+
+ if (const struct sr_input_module **input_list = sr_input_list())
+ for (int i = 0; input_list[i]; i++) {
+ unique_ptr<InputFormat> input {new InputFormat{input_list[i]}};
+ _input_formats.emplace(input->name(), move(input));
+ }
+
+ if (const struct sr_output_module **output_list = sr_output_list())
+ for (int i = 0; output_list[i]; i++) {
+ unique_ptr<OutputFormat> output {new OutputFormat{output_list[i]}};
+ _output_formats.emplace(output->name(), move(output));
+ }
}
string Context::package_version()
map<string, shared_ptr<Driver>> Context::drivers()
{
map<string, shared_ptr<Driver>> result;
- for (auto entry: _drivers)
- {
- auto name = entry.first;
- auto driver = entry.second;
- result[name] = driver->get_shared_pointer(this);
+ for (const auto &entry: _drivers) {
+ const auto &name = entry.first;
+ const auto &driver = entry.second;
+ result.emplace(name, driver->share_owned_by(shared_from_this()));
}
return result;
}
map<string, shared_ptr<InputFormat>> Context::input_formats()
{
map<string, shared_ptr<InputFormat>> result;
- for (auto entry: _input_formats)
- {
- auto name = entry.first;
- auto input_format = entry.second;
- result[name] = input_format->get_shared_pointer(this);
+ for (const auto &entry: _input_formats) {
+ const auto &name = entry.first;
+ const auto &input_format = entry.second;
+ result.emplace(name, input_format->share_owned_by(shared_from_this()));
}
return result;
}
+shared_ptr<InputFormat> Context::input_format_match(string filename)
+{
+ const struct sr_input *input;
+ const struct sr_input_module *imod;
+ int rc;
+
+ /*
+ * Have the input module looked up for the specified file.
+ * Failed lookup (or "successful lookup" with an empty result)
+ * are non-fatal. Free the sr_input that was created by the
+ * lookup routine, but grab the input module kind and return an
+ * InputFormat instance to the application. This works because
+ * the application passes a filename, no input data got buffered
+ * in the sr_input that we release.
+ */
+ input = NULL;
+ rc = sr_input_scan_file(filename.c_str(), &input);
+ if (rc != SR_OK)
+ return nullptr;
+ if (!input)
+ return nullptr;
+ imod = sr_input_module_get(input);
+ sr_input_free(input);
+ return shared_ptr<InputFormat>{new InputFormat{imod}, default_delete<InputFormat>{}};
+}
+
map<string, shared_ptr<OutputFormat>> Context::output_formats()
{
map<string, shared_ptr<OutputFormat>> result;
- for (auto entry: _output_formats)
- {
- auto name = entry.first;
- auto output_format = entry.second;
- result[name] = output_format->get_shared_pointer(this);
+ for (const auto &entry: _output_formats) {
+ const auto &name = entry.first;
+ const auto &output_format = entry.second;
+ result.emplace(name, output_format->share_owned_by(shared_from_this()));
}
return result;
}
Context::~Context()
{
- for (auto entry : _drivers)
- delete entry.second;
- for (auto entry : _input_formats)
- delete entry.second;
- for (auto entry : _output_formats)
- delete entry.second;
check(sr_exit(_structure));
}
-const LogLevel *Context::log_level()
+const LogLevel *Context::log_level() const
{
return LogLevel::get(sr_log_loglevel_get());
}
check(sr_log_loglevel_set(level->id()));
}
-static int call_log_callback(void *cb_data, int loglevel, const char *format, va_list args)
+static int call_log_callback(void *cb_data, int loglevel,
+ const char *format, va_list args) noexcept
{
const unique_ptr<char, decltype(&g_free)>
message {g_strdup_vprintf(format, args), &g_free};
auto *const callback = static_cast<LogCallbackFunction *>(cb_data);
- try
- {
+ try {
(*callback)(LogLevel::get(loglevel), message.get());
- }
- catch (Error e)
- {
+ } catch (Error &e) {
return e.result;
}
shared_ptr<Session> Context::create_session()
{
- return shared_ptr<Session>(
- new Session(shared_from_this()), Session::Deleter());
+ return shared_ptr<Session>{new Session{shared_from_this()},
+ default_delete<Session>{}};
}
shared_ptr<UserDevice> Context::create_user_device(
string vendor, string model, string version)
{
- return shared_ptr<UserDevice>(
- new UserDevice(vendor, model, version), UserDevice::Deleter());
+ return shared_ptr<UserDevice>{
+ new UserDevice{move(vendor), move(model), move(version)},
+ default_delete<UserDevice>{}};
}
shared_ptr<Packet> Context::create_header_packet(Glib::TimeVal start_time)
auto packet = g_new(struct sr_datafeed_packet, 1);
packet->type = SR_DF_HEADER;
packet->payload = header;
- return shared_ptr<Packet>(new Packet(nullptr, packet), Packet::Deleter());
+ return shared_ptr<Packet>{new Packet{nullptr, packet},
+ default_delete<Packet>{}};
}
shared_ptr<Packet> Context::create_meta_packet(
- const map<const ConfigKey *, Glib::VariantBase> &config)
+ map<const ConfigKey *, Glib::VariantBase> config)
{
auto meta = g_new0(struct sr_datafeed_meta, 1);
- for (auto input : config)
- {
- auto key = input.first;
- auto value = input.second;
- auto output = g_new(struct sr_config, 1);
+ for (const auto &input : config) {
+ const auto &key = input.first;
+ const auto &value = input.second;
+ auto *const output = g_new(struct sr_config, 1);
output->key = key->id();
- output->data = value.gobj();
- g_variant_ref(output->data);
+ output->data = value.gobj_copy();
meta->config = g_slist_append(meta->config, output);
}
auto packet = g_new(struct sr_datafeed_packet, 1);
packet->type = SR_DF_META;
packet->payload = meta;
- return shared_ptr<Packet>(new Packet(nullptr, packet), Packet::Deleter());
+ return shared_ptr<Packet>{new Packet{nullptr, packet},
+ default_delete<Packet>{}};
}
shared_ptr<Packet> Context::create_logic_packet(
auto packet = g_new(struct sr_datafeed_packet, 1);
packet->type = SR_DF_LOGIC;
packet->payload = logic;
- return shared_ptr<Packet>(new Packet(nullptr, packet), Packet::Deleter());
+ return shared_ptr<Packet>{new Packet{nullptr, packet}, default_delete<Packet>{}};
}
shared_ptr<Packet> Context::create_analog_packet(
- const vector<shared_ptr<Channel> > &channels,
- float *data_pointer, unsigned int num_samples, const Quantity *mq,
- const Unit *unit, const vector<const QuantityFlag *> &mqflags)
+ vector<shared_ptr<Channel> > channels,
+ const float *data_pointer, unsigned int num_samples, const Quantity *mq,
+ const Unit *unit, vector<const QuantityFlag *> mqflags)
{
auto analog = g_new0(struct sr_datafeed_analog, 1);
auto meaning = g_new0(struct sr_analog_meaning, 1);
+ auto encoding = g_new0(struct sr_analog_encoding, 1);
+ auto spec = g_new0(struct sr_analog_spec, 1);
analog->meaning = meaning;
- for (auto channel : channels)
+ for (const auto &channel : channels)
meaning->channels = g_slist_append(meaning->channels, channel->_structure);
- analog->num_samples = num_samples;
meaning->mq = static_cast<sr_mq>(mq->id());
meaning->unit = static_cast<sr_unit>(unit->id());
- meaning->mqflags = static_cast<sr_mqflag>(QuantityFlag::mask_from_flags(mqflags));
- analog->data = data_pointer;
+ meaning->mqflags = static_cast<sr_mqflag>(QuantityFlag::mask_from_flags(move(mqflags)));
+
+ analog->encoding = encoding;
+
+ encoding->unitsize = sizeof(float);
+ encoding->is_signed = TRUE;
+ encoding->is_float = TRUE;
+#ifdef WORDS_BIGENDIAN
+ encoding->is_bigendian = TRUE;
+#else
+ encoding->is_bigendian = FALSE;
+#endif
+ encoding->digits = 0;
+ encoding->is_digits_decimal = FALSE;
+ encoding->scale.p = 1;
+ encoding->scale.q = 1;
+ encoding->offset.p = 0;
+ encoding->offset.q = 1;
+
+ analog->spec = spec;
+
+ spec->spec_digits = 0;
+
+ analog->num_samples = num_samples;
+ analog->data = (float*)data_pointer;
auto packet = g_new(struct sr_datafeed_packet, 1);
packet->type = SR_DF_ANALOG;
packet->payload = analog;
- return shared_ptr<Packet>(new Packet(nullptr, packet), Packet::Deleter());
+ return shared_ptr<Packet>{new Packet{nullptr, packet}, default_delete<Packet>{}};
+}
+
+shared_ptr<Packet> Context::create_end_packet()
+{
+ auto packet = g_new(struct sr_datafeed_packet, 1);
+ packet->type = SR_DF_END;
+ return shared_ptr<Packet>{new Packet{nullptr, packet},
+ default_delete<Packet>{}};
}
shared_ptr<Session> Context::load_session(string filename)
{
- return shared_ptr<Session>(
- new Session(shared_from_this(), move(filename)), Session::Deleter());
+ return shared_ptr<Session>{
+ new Session{shared_from_this(), move(filename)},
+ default_delete<Session>{}};
}
shared_ptr<Trigger> Context::create_trigger(string name)
{
- return shared_ptr<Trigger>(
- new Trigger(shared_from_this(), move(name)), Trigger::Deleter());
+ return shared_ptr<Trigger>{
+ new Trigger{shared_from_this(), move(name)},
+ default_delete<Trigger>{}};
}
shared_ptr<Input> Context::open_file(string filename)
const struct sr_input *input;
check(sr_input_scan_file(filename.c_str(), &input));
- return shared_ptr<Input>(
- new Input(shared_from_this(), input), Input::Deleter());
+ return shared_ptr<Input>{
+ new Input{shared_from_this(), input},
+ default_delete<Input>{}};
}
shared_ptr<Input> Context::open_stream(string header)
auto ret = sr_input_scan_buffer(gstr, &input);
g_string_free(gstr, true);
check(ret);
- return shared_ptr<Input>(
- new Input(shared_from_this(), input), Input::Deleter());
+ return shared_ptr<Input>{
+ new Input{shared_from_this(), input},
+ default_delete<Input>{}};
}
-map<string, string> Context::serials(shared_ptr<Driver> driver)
+map<string, string> Context::serials(shared_ptr<Driver> driver) const
{
GSList *serial_list = sr_serial_list(driver ? driver->_structure : nullptr);
map<string, string> serials;
}
Driver::Driver(struct sr_dev_driver *structure) :
- ParentOwned(structure),
Configurable(structure, nullptr, nullptr),
+ _structure(structure),
_initialized(false)
{
}
{
}
-string Driver::name()
+string Driver::name() const
{
return valid_string(_structure->name);
}
-string Driver::long_name()
+string Driver::long_name() const
{
return valid_string(_structure->longname);
}
+set<const ConfigKey *> Driver::scan_options() const
+{
+ GArray *opts = sr_driver_scan_options_list(_structure);
+ set<const ConfigKey *> result;
+ if (opts) {
+ for (guint i = 0; i < opts->len; i++)
+ result.insert(ConfigKey::get(g_array_index(opts, uint32_t, i)));
+ g_array_free(opts, TRUE);
+ }
+ return result;
+}
+
vector<shared_ptr<HardwareDevice>> Driver::scan(
- const map<const ConfigKey *, Glib::VariantBase> &options)
+ map<const ConfigKey *, Glib::VariantBase> options)
{
/* Initialise the driver if not yet done. */
- if (!_initialized)
- {
+ if (!_initialized) {
check(sr_driver_init(_parent->_structure, _structure));
_initialized = true;
}
/* Translate scan options to GSList of struct sr_config pointers. */
GSList *option_list = nullptr;
- for (auto entry : options)
- {
- auto key = entry.first;
- auto value = entry.second;
- auto config = g_new(struct sr_config, 1);
+ for (const auto &entry : options) {
+ const auto &key = entry.first;
+ const auto &value = entry.second;
+ auto *const config = g_new(struct sr_config, 1);
config->key = key->id();
- config->data = value.gobj();
+ config->data = const_cast<GVariant*>(value.gobj());
option_list = g_slist_append(option_list, config);
}
/* Create device objects. */
vector<shared_ptr<HardwareDevice>> result;
- for (GSList *device = device_list; device; device = device->next)
- {
+ for (GSList *device = device_list; device; device = device->next) {
auto *const sdi = static_cast<struct sr_dev_inst *>(device->data);
- result.push_back(shared_ptr<HardwareDevice>(
- new HardwareDevice(shared_from_this(), sdi),
- HardwareDevice::Deleter()));
+ shared_ptr<HardwareDevice> hwdev {
+ new HardwareDevice{shared_from_this(), sdi},
+ default_delete<HardwareDevice>{}};
+ result.push_back(move(hwdev));
}
/* Free GSList returned from scan. */
{
}
-Glib::VariantBase Configurable::config_get(const ConfigKey *key)
+set<const ConfigKey *> Configurable::config_keys() const
+{
+ GArray *opts;
+ set<const ConfigKey *> result;
+
+ opts = sr_dev_options(config_driver, config_sdi, config_channel_group);
+
+ if (opts) {
+ for (guint i = 0; i < opts->len; i++)
+ result.insert(ConfigKey::get(g_array_index(opts, uint32_t, i)));
+ g_array_free(opts, TRUE);
+ }
+
+ return result;
+}
+
+Glib::VariantBase Configurable::config_get(const ConfigKey *key) const
{
GVariant *data;
check(sr_config_get(
key->id(), const_cast<GVariant*>(value.gobj())));
}
-Glib::VariantContainerBase Configurable::config_list(const ConfigKey *key)
-{
- GVariant *data;
- check(sr_config_list(
- config_driver, config_sdi, config_channel_group,
- key->id(), &data));
- return Glib::VariantContainerBase(data);
-}
-
-map<const ConfigKey *, set<Capability>> Configurable::config_keys(const ConfigKey *key)
+set<const Capability *> Configurable::config_capabilities(const ConfigKey *key) const
{
- GVariant *gvar_opts;
- gsize num_opts;
- const uint32_t *opts;
- map<const ConfigKey *, set<Capability>> result;
-
- check(sr_config_list(
- config_driver, config_sdi, config_channel_group,
- key->id(), &gvar_opts));
-
- opts = static_cast<const uint32_t *>(g_variant_get_fixed_array(
- gvar_opts, &num_opts, sizeof(uint32_t)));
+ int caps = sr_dev_config_capabilities_list(config_sdi,
+ config_channel_group, key->id());
- for (gsize i = 0; i < num_opts; i++)
- {
- auto key = ConfigKey::get(opts[i] & SR_CONF_MASK);
- set<Capability> capabilities;
- if (opts[i] & SR_CONF_GET)
- capabilities.insert(GET);
- if (opts[i] & SR_CONF_SET)
- capabilities.insert(SET);
- if (opts[i] & SR_CONF_LIST)
- capabilities.insert(LIST);
- result[key] = capabilities;
- }
+ set<const Capability *> result;
- g_variant_unref(gvar_opts);
+ for (auto cap: Capability::values())
+ if (caps & cap->id())
+ result.insert(cap);
return result;
}
bool Configurable::config_check(const ConfigKey *key,
- const ConfigKey *index_key)
+ const Capability *capability) const
{
- GVariant *gvar_opts;
- gsize num_opts;
- const uint32_t *opts;
-
- if (sr_config_list(config_driver, config_sdi, config_channel_group,
- index_key->id(), &gvar_opts) != SR_OK)
- return false;
-
- opts = static_cast<const uint32_t *>(g_variant_get_fixed_array(
- gvar_opts, &num_opts, sizeof(uint32_t)));
-
- for (gsize i = 0; i < num_opts; i++)
- {
- if ((opts[i] & SR_CONF_MASK) == unsigned(key->id()))
- {
- g_variant_unref(gvar_opts);
- return true;
- }
- }
+ int caps = sr_dev_config_capabilities_list(config_sdi,
+ config_channel_group, key->id());
- g_variant_unref(gvar_opts);
+ return (caps & capability->id());
+}
- return false;
+Glib::VariantContainerBase Configurable::config_list(const ConfigKey *key) const
+{
+ GVariant *data;
+ check(sr_config_list(
+ config_driver, config_sdi, config_channel_group,
+ key->id(), &data));
+ return Glib::VariantContainerBase(data);
}
Device::Device(struct sr_dev_inst *structure) :
Configurable(sr_dev_inst_driver_get(structure), structure, nullptr),
_structure(structure)
{
- for (GSList *entry = sr_dev_inst_channels_get(structure); entry; entry = entry->next)
- {
- auto *const channel = static_cast<struct sr_channel *>(entry->data);
- _channels[channel] = new Channel(channel);
+ for (GSList *entry = sr_dev_inst_channels_get(structure); entry; entry = entry->next) {
+ auto *const ch = static_cast<struct sr_channel *>(entry->data);
+ unique_ptr<Channel> channel {new Channel{ch}};
+ _channels.emplace(ch, move(channel));
}
- for (GSList *entry = sr_dev_inst_channel_groups_get(structure); entry; entry = entry->next)
- {
- auto *const group = static_cast<struct sr_channel_group *>(entry->data);
- _channel_groups[group->name] = new ChannelGroup(this, group);
+ for (GSList *entry = sr_dev_inst_channel_groups_get(structure); entry; entry = entry->next) {
+ auto *const cg = static_cast<struct sr_channel_group *>(entry->data);
+ unique_ptr<ChannelGroup> group {new ChannelGroup{this, cg}};
+ _channel_groups.emplace(group->name(), move(group));
}
}
Device::~Device()
{
- for (auto entry : _channels)
- delete entry.second;
- for (auto entry : _channel_groups)
- delete entry.second;
}
-string Device::vendor()
+string Device::vendor() const
{
return valid_string(sr_dev_inst_vendor_get(_structure));
}
-string Device::model()
+string Device::model() const
{
return valid_string(sr_dev_inst_model_get(_structure));
}
-string Device::version()
+string Device::version() const
{
return valid_string(sr_dev_inst_version_get(_structure));
}
-string Device::serial_number()
+string Device::serial_number() const
{
return valid_string(sr_dev_inst_sernum_get(_structure));
}
-string Device::connection_id()
+string Device::connection_id() const
{
return valid_string(sr_dev_inst_connid_get(_structure));
}
vector<shared_ptr<Channel>> result;
for (auto channel = sr_dev_inst_channels_get(_structure); channel; channel = channel->next) {
auto *const ch = static_cast<struct sr_channel *>(channel->data);
- result.push_back(_channels[ch]->get_shared_pointer(get_shared_from_this()));
+ result.push_back(_channels[ch]->share_owned_by(get_shared_from_this()));
}
return result;
}
shared_ptr<Channel> Device::get_channel(struct sr_channel *ptr)
{
- return _channels[ptr]->get_shared_pointer(get_shared_from_this());
+ return _channels[ptr]->share_owned_by(get_shared_from_this());
}
map<string, shared_ptr<ChannelGroup>>
Device::channel_groups()
{
map<string, shared_ptr<ChannelGroup>> result;
- for (auto entry: _channel_groups)
- {
- auto name = entry.first;
- auto channel_group = entry.second;
- result[name] = channel_group->get_shared_pointer(get_shared_from_this());
+ for (const auto &entry: _channel_groups) {
+ const auto &name = entry.first;
+ const auto &channel_group = entry.second;
+ result.emplace(name, channel_group->share_owned_by(get_shared_from_this()));
}
return result;
}
HardwareDevice::HardwareDevice(shared_ptr<Driver> driver,
struct sr_dev_inst *structure) :
- UserOwned(structure),
Device(structure),
_driver(move(driver))
{
}
UserDevice::UserDevice(string vendor, string model, string version) :
- UserOwned(sr_dev_inst_user_new(
- vendor.c_str(), model.c_str(), version.c_str())),
- Device(UserOwned::_structure)
+ Device(sr_dev_inst_user_new(
+ vendor.c_str(), model.c_str(), version.c_str()))
{
}
index, type->id(), name.c_str()));
GSList *const last = g_slist_last(sr_dev_inst_channels_get(Device::_structure));
auto *const ch = static_cast<struct sr_channel *>(last->data);
- _channels[ch] = new Channel(ch);
+ unique_ptr<Channel> channel {new Channel{ch}};
+ _channels.emplace(ch, move(channel));
return get_channel(ch);
}
Channel::Channel(struct sr_channel *structure) :
- ParentOwned(structure),
+ _structure(structure),
_type(ChannelType::get(_structure->type))
{
}
{
}
-string Channel::name()
+string Channel::name() const
{
return valid_string(_structure->name);
}
check(sr_dev_channel_name_set(_structure, name.c_str()));
}
-const ChannelType *Channel::type()
+const ChannelType *Channel::type() const
{
return ChannelType::get(_structure->type);
}
-bool Channel::enabled()
+bool Channel::enabled() const
{
return _structure->enabled;
}
check(sr_dev_channel_enable(_structure, value));
}
-unsigned int Channel::index()
+unsigned int Channel::index() const
{
return _structure->index;
}
-ChannelGroup::ChannelGroup(Device *device,
+ChannelGroup::ChannelGroup(const Device *device,
struct sr_channel_group *structure) :
- ParentOwned(structure),
Configurable(sr_dev_inst_driver_get(device->_structure), device->_structure, structure)
{
- for (GSList *entry = structure->channels; entry; entry = entry->next) {
+ for (GSList *entry = config_channel_group->channels; entry; entry = entry->next) {
auto *const ch = static_cast<struct sr_channel *>(entry->data);
- _channels.push_back(device->_channels[ch]);
+ /* Note: This relies on Device::_channels to keep the Channel
+ * objects around over the lifetime of the ChannelGroup. */
+ _channels.push_back(device->_channels.find(ch)->second.get());
}
}
{
}
-string ChannelGroup::name()
+string ChannelGroup::name() const
{
- return valid_string(_structure->name);
+ return valid_string(config_channel_group->name);
}
vector<shared_ptr<Channel>> ChannelGroup::channels()
{
vector<shared_ptr<Channel>> result;
- for (auto channel : _channels)
- result.push_back(channel->get_shared_pointer(_parent));
+ for (const auto &channel : _channels)
+ result.push_back(channel->share_owned_by(_parent));
return result;
}
-Trigger::Trigger(shared_ptr<Context> context, string name) :
- UserOwned(sr_trigger_new(name.c_str())),
+Trigger::Trigger(shared_ptr<Context> context, string name) :
+ _structure(sr_trigger_new(name.c_str())),
_context(move(context))
{
- for (auto stage = _structure->stages; stage; stage = stage->next)
- _stages.push_back(
- new TriggerStage(static_cast<struct sr_trigger_stage *>(stage->data)));
+ for (auto *stage = _structure->stages; stage; stage = stage->next) {
+ unique_ptr<TriggerStage> ts {new TriggerStage{
+ static_cast<struct sr_trigger_stage *>(stage->data)}};
+ _stages.push_back(move(ts));
+ }
}
Trigger::~Trigger()
{
- for (auto stage: _stages)
- delete stage;
-
sr_trigger_free(_structure);
}
-string Trigger::name()
+string Trigger::name() const
{
return _structure->name;
}
vector<shared_ptr<TriggerStage>> Trigger::stages()
{
vector<shared_ptr<TriggerStage>> result;
- for (auto stage : _stages)
- result.push_back(stage->get_shared_pointer(this));
+ for (const auto &stage : _stages)
+ result.push_back(stage->share_owned_by(shared_from_this()));
return result;
}
shared_ptr<TriggerStage> Trigger::add_stage()
{
- auto stage = new TriggerStage(sr_trigger_stage_add(_structure));
- _stages.push_back(stage);
- return stage->get_shared_pointer(this);
+ unique_ptr<TriggerStage> stage {new TriggerStage{sr_trigger_stage_add(_structure)}};
+ _stages.push_back(move(stage));
+ return _stages.back()->share_owned_by(shared_from_this());
}
-TriggerStage::TriggerStage(struct sr_trigger_stage *structure) :
- ParentOwned(structure)
+TriggerStage::TriggerStage(struct sr_trigger_stage *structure) :
+ _structure(structure)
{
}
TriggerStage::~TriggerStage()
{
- for (auto match : _matches)
- delete match;
}
-
-int TriggerStage::number()
+
+int TriggerStage::number() const
{
return _structure->stage;
}
vector<shared_ptr<TriggerMatch>> TriggerStage::matches()
{
vector<shared_ptr<TriggerMatch>> result;
- for (auto match : _matches)
- result.push_back(match->get_shared_pointer(this));
+ for (const auto &match : _matches)
+ result.push_back(match->share_owned_by(shared_from_this()));
return result;
}
check(sr_trigger_match_add(_structure,
channel->_structure, type->id(), value));
GSList *const last = g_slist_last(_structure->matches);
- _matches.push_back(new TriggerMatch(
- static_cast<struct sr_trigger_match *>(last->data),
- move(channel)));
+ unique_ptr<TriggerMatch> match {new TriggerMatch{
+ static_cast<struct sr_trigger_match *>(last->data),
+ move(channel)}};
+ _matches.push_back(move(match));
}
void TriggerStage::add_match(shared_ptr<Channel> channel,
TriggerMatch::TriggerMatch(struct sr_trigger_match *structure,
shared_ptr<Channel> channel) :
- ParentOwned(structure),
+ _structure(structure),
_channel(move(channel))
{
}
return _channel;
}
-const TriggerMatchType *TriggerMatch::type()
+const TriggerMatchType *TriggerMatch::type() const
{
return TriggerMatchType::get(_structure->match);
}
-float TriggerMatch::value()
+float TriggerMatch::value() const
{
return _structure->value;
}
const struct sr_datafeed_packet *pkt)
{
auto device = _session->get_device(sdi);
- auto packet = shared_ptr<Packet>(new Packet(device, pkt), Packet::Deleter());
+ shared_ptr<Packet> packet {new Packet{device, pkt}, default_delete<Packet>{}};
_callback(move(device), move(packet));
}
SessionDevice::SessionDevice(struct sr_dev_inst *structure) :
- ParentOwned(structure),
Device(structure)
{
}
}
Session::Session(shared_ptr<Context> context) :
- UserOwned(_structure),
+ _structure(nullptr),
_context(move(context))
{
check(sr_session_new(_context->_structure, &_structure));
}
Session::Session(shared_ptr<Context> context, string filename) :
- UserOwned(_structure),
+ _structure(nullptr),
_context(move(context)),
_filename(move(filename))
{
check(sr_session_dev_list(_structure, &dev_list));
for (GSList *dev = dev_list; dev; dev = dev->next) {
auto *const sdi = static_cast<struct sr_dev_inst *>(dev->data);
- _owned_devices[sdi] = new SessionDevice(sdi);
+ unique_ptr<SessionDevice> device {new SessionDevice{sdi}};
+ _owned_devices.emplace(sdi, move(device));
}
_context->_session = this;
+ g_slist_free(dev_list);
}
Session::~Session()
{
check(sr_session_destroy(_structure));
-
- for (auto callback : _datafeed_callbacks)
- delete callback;
-
- for (auto entry : _owned_devices)
- delete entry.second;
}
shared_ptr<Device> Session::get_device(const struct sr_dev_inst *sdi)
{
if (_owned_devices.count(sdi))
return static_pointer_cast<Device>(
- _owned_devices[sdi]->get_shared_pointer(this));
+ _owned_devices[sdi]->share_owned_by(shared_from_this()));
else if (_other_devices.count(sdi))
return _other_devices[sdi];
else
auto *const sdi = static_cast<struct sr_dev_inst *>(dev->data);
result.push_back(get_device(sdi));
}
+ g_slist_free(dev_list);
return result;
}
return (ret != 0);
}
-static void session_stopped_callback(void *data)
+static void session_stopped_callback(void *data) noexcept
{
auto *const callback = static_cast<SessionStoppedCallback*>(data);
(*callback)();
}
static void datafeed_callback(const struct sr_dev_inst *sdi,
- const struct sr_datafeed_packet *pkt, void *cb_data)
+ const struct sr_datafeed_packet *pkt, void *cb_data) noexcept
{
auto callback = static_cast<DatafeedCallbackData *>(cb_data);
callback->run(sdi, pkt);
void Session::add_datafeed_callback(DatafeedCallbackFunction callback)
{
- auto cb_data = new DatafeedCallbackData(this, move(callback));
+ unique_ptr<DatafeedCallbackData> cb_data
+ {new DatafeedCallbackData{this, move(callback)}};
check(sr_session_datafeed_callback_add(_structure,
- datafeed_callback, cb_data));
- _datafeed_callbacks.push_back(cb_data);
+ &datafeed_callback, cb_data.get()));
+ _datafeed_callbacks.push_back(move(cb_data));
}
void Session::remove_datafeed_callbacks()
{
check(sr_session_datafeed_callback_remove_all(_structure));
- for (auto callback : _datafeed_callbacks)
- delete callback;
_datafeed_callbacks.clear();
}
_trigger = move(trigger);
}
-string Session::filename()
+string Session::filename() const
{
return _filename;
}
Packet::Packet(shared_ptr<Device> device,
const struct sr_datafeed_packet *structure) :
- UserOwned(structure),
+ _structure(structure),
_device(move(device))
{
switch (structure->type)
{
case SR_DF_HEADER:
- _payload = new Header(
+ _payload.reset(new Header{
static_cast<const struct sr_datafeed_header *>(
- structure->payload));
+ structure->payload)});
break;
case SR_DF_META:
- _payload = new Meta(
+ _payload.reset(new Meta{
static_cast<const struct sr_datafeed_meta *>(
- structure->payload));
+ structure->payload)});
break;
case SR_DF_LOGIC:
- _payload = new Logic(
+ _payload.reset(new Logic{
static_cast<const struct sr_datafeed_logic *>(
- structure->payload));
+ structure->payload)});
break;
case SR_DF_ANALOG:
- _payload = new Analog(
+ _payload.reset(new Analog{
static_cast<const struct sr_datafeed_analog *>(
- structure->payload));
- break;
- default:
- _payload = nullptr;
+ structure->payload)});
break;
}
}
Packet::~Packet()
{
- if (_payload)
- delete _payload;
}
-const PacketType *Packet::type()
+const PacketType *Packet::type() const
{
return PacketType::get(_structure->type);
}
shared_ptr<PacketPayload> Packet::payload()
{
if (_payload)
- return _payload->get_shared_pointer(this);
+ return _payload->share_owned_by(shared_from_this());
else
throw Error(SR_ERR_NA);
}
}
Header::Header(const struct sr_datafeed_header *structure) :
- ParentOwned(structure),
- PacketPayload()
+ PacketPayload(),
+ _structure(structure)
{
}
{
}
-shared_ptr<PacketPayload> Header::get_shared_pointer(Packet *_parent)
+shared_ptr<PacketPayload> Header::share_owned_by(shared_ptr<Packet> _parent)
{
return static_pointer_cast<PacketPayload>(
- ParentOwned::get_shared_pointer(_parent));
+ ParentOwned::share_owned_by(_parent));
}
-int Header::feed_version()
+int Header::feed_version() const
{
return _structure->feed_version;
}
-Glib::TimeVal Header::start_time()
+Glib::TimeVal Header::start_time() const
{
return Glib::TimeVal(
_structure->starttime.tv_sec,
}
Meta::Meta(const struct sr_datafeed_meta *structure) :
- ParentOwned(structure),
- PacketPayload()
+ PacketPayload(),
+ _structure(structure)
{
}
{
}
-shared_ptr<PacketPayload> Meta::get_shared_pointer(Packet *_parent)
+shared_ptr<PacketPayload> Meta::share_owned_by(shared_ptr<Packet> _parent)
{
return static_pointer_cast<PacketPayload>(
- ParentOwned::get_shared_pointer(_parent));
+ ParentOwned::share_owned_by(_parent));
}
-map<const ConfigKey *, Glib::VariantBase> Meta::config()
+map<const ConfigKey *, Glib::VariantBase> Meta::config() const
{
map<const ConfigKey *, Glib::VariantBase> result;
for (auto l = _structure->config; l; l = l->next) {
auto *const config = static_cast<struct sr_config *>(l->data);
- result[ConfigKey::get(config->key)] = Glib::VariantBase(config->data);
+ result[ConfigKey::get(config->key)] = Glib::VariantBase(config->data, true);
}
return result;
}
Logic::Logic(const struct sr_datafeed_logic *structure) :
- ParentOwned(structure),
- PacketPayload()
+ PacketPayload(),
+ _structure(structure)
{
}
{
}
-shared_ptr<PacketPayload> Logic::get_shared_pointer(Packet *_parent)
+shared_ptr<PacketPayload> Logic::share_owned_by(shared_ptr<Packet> _parent)
{
return static_pointer_cast<PacketPayload>(
- ParentOwned::get_shared_pointer(_parent));
+ ParentOwned::share_owned_by(_parent));
}
void *Logic::data_pointer()
return _structure->data;
}
-size_t Logic::data_length()
+size_t Logic::data_length() const
{
return _structure->length;
}
-unsigned int Logic::unit_size()
+unsigned int Logic::unit_size() const
{
return _structure->unitsize;
}
Analog::Analog(const struct sr_datafeed_analog *structure) :
- ParentOwned(structure),
- PacketPayload()
+ PacketPayload(),
+ _structure(structure)
{
}
{
}
-shared_ptr<PacketPayload> Analog::get_shared_pointer(Packet *_parent)
+shared_ptr<PacketPayload> Analog::share_owned_by(shared_ptr<Packet> _parent)
{
return static_pointer_cast<PacketPayload>(
- ParentOwned::get_shared_pointer(_parent));
+ ParentOwned::share_owned_by(_parent));
}
void *Analog::data_pointer()
return _structure->data;
}
-unsigned int Analog::num_samples()
+void Analog::get_data_as_float(float *dest)
+{
+ check(sr_analog_to_float(_structure, dest));
+}
+
+unsigned int Analog::num_samples() const
{
return _structure->num_samples;
}
return result;
}
-const Quantity *Analog::mq()
+unsigned int Analog::unitsize() const
+{
+ return _structure->encoding->unitsize;
+}
+
+bool Analog::is_signed() const
+{
+ return _structure->encoding->is_signed;
+}
+
+bool Analog::is_float() const
+{
+ return _structure->encoding->is_float;
+}
+
+bool Analog::is_bigendian() const
+{
+ return _structure->encoding->is_bigendian;
+}
+
+int Analog::digits() const
+{
+ return _structure->encoding->digits;
+}
+
+bool Analog::is_digits_decimal() const
+{
+ return _structure->encoding->is_digits_decimal;
+}
+
+shared_ptr<Rational> Analog::scale()
+{
+ unique_ptr<Rational> scale;
+ scale.reset(new Rational(&(_structure->encoding->scale)));
+
+ if (scale)
+ return scale->share_owned_by(shared_from_this());
+ else
+ throw Error(SR_ERR_NA);
+}
+
+shared_ptr<Rational> Analog::offset()
+{
+ unique_ptr<Rational> offset;
+ offset.reset(new Rational(&(_structure->encoding->offset)));
+
+ if (offset)
+ return offset->share_owned_by(shared_from_this());
+ else
+ throw Error(SR_ERR_NA);
+}
+
+const Quantity *Analog::mq() const
{
return Quantity::get(_structure->meaning->mq);
}
-const Unit *Analog::unit()
+const Unit *Analog::unit() const
{
return Unit::get(_structure->meaning->unit);
}
-vector<const QuantityFlag *> Analog::mq_flags()
+vector<const QuantityFlag *> Analog::mq_flags() const
{
return QuantityFlag::flags_from_mask(_structure->meaning->mqflags);
}
+shared_ptr<Logic> Analog::get_logic_via_threshold(float threshold,
+ uint8_t *data_ptr) const
+{
+ auto datafeed = g_new(struct sr_datafeed_logic, 1);
+ datafeed->length = num_samples();
+ datafeed->unitsize = 1;
+
+ if (data_ptr)
+ datafeed->data = data_ptr;
+ else
+ datafeed->data = g_malloc(datafeed->length);
+
+ shared_ptr<Logic> logic =
+ shared_ptr<Logic>{new Logic{datafeed}, default_delete<Logic>{}};
+
+ check(sr_a2l_threshold(_structure, threshold,
+ (uint8_t*)datafeed->data, datafeed->length));
+
+ return logic;
+}
+
+shared_ptr<Logic> Analog::get_logic_via_schmitt_trigger(float lo_thr,
+ float hi_thr, uint8_t *state, uint8_t *data_ptr) const
+{
+ auto datafeed = g_new(struct sr_datafeed_logic, 1);
+ datafeed->length = num_samples();
+ datafeed->unitsize = 1;
+
+ if (data_ptr)
+ datafeed->data = data_ptr;
+ else
+ datafeed->data = g_malloc(datafeed->length);
+
+ shared_ptr<Logic> logic =
+ shared_ptr<Logic>{new Logic{datafeed}, default_delete<Logic>{}};
+
+ check(sr_a2l_schmitt_trigger(_structure, lo_thr, hi_thr, state,
+ (uint8_t*)datafeed->data, datafeed->length));
+
+ return logic;
+}
+
+Rational::Rational(const struct sr_rational *structure) :
+ _structure(structure)
+{
+}
+
+Rational::~Rational()
+{
+}
+
+shared_ptr<Rational> Rational::share_owned_by(shared_ptr<Analog> _parent)
+{
+ return static_pointer_cast<Rational>(
+ ParentOwned::share_owned_by(_parent));
+}
+
+int64_t Rational::numerator() const
+{
+ return _structure->p;
+}
+
+uint64_t Rational::denominator() const
+{
+ return _structure->q;
+}
+
+float Rational::value() const
+{
+ return (float)(_structure->p) / (float)(_structure->q);
+}
+
InputFormat::InputFormat(const struct sr_input_module *structure) :
- ParentOwned(structure)
+ _structure(structure)
{
}
{
}
-string InputFormat::name()
+string InputFormat::name() const
{
return valid_string(sr_input_id_get(_structure));
}
-string InputFormat::description()
+string InputFormat::description() const
{
return valid_string(sr_input_description_get(_structure));
}
-vector<string> InputFormat::extensions()
+vector<string> InputFormat::extensions() const
{
vector<string> exts;
for (const char *const *e = sr_input_extensions_get(_structure);
map<string, shared_ptr<Option>> InputFormat::options()
{
- const struct sr_option **options = sr_input_options_get(_structure);
map<string, shared_ptr<Option>> result;
- if (options)
- {
- auto option_array = shared_ptr<const struct sr_option *>(
- options, sr_input_options_free);
- for (int i = 0; options[i]; i++)
- result[options[i]->id] = shared_ptr<Option>(
- new Option(options[i], option_array), Option::Deleter());
+
+ if (const struct sr_option **options = sr_input_options_get(_structure)) {
+ shared_ptr<const struct sr_option *> option_array
+ {options, &sr_input_options_free};
+ for (int i = 0; options[i]; i++) {
+ shared_ptr<Option> opt {
+ new Option{options[i], option_array},
+ default_delete<Option>{}};
+ result.emplace(opt->id(), move(opt));
+ }
}
return result;
}
shared_ptr<Input> InputFormat::create_input(
- const map<string, Glib::VariantBase> &options)
+ map<string, Glib::VariantBase> options)
{
auto input = sr_input_new(_structure, map_to_hash_variant(options));
if (!input)
throw Error(SR_ERR_ARG);
- return shared_ptr<Input>(
- new Input(_parent->shared_from_this(), input), Input::Deleter());
+ return shared_ptr<Input>{new Input{_parent, input}, default_delete<Input>{}};
}
Input::Input(shared_ptr<Context> context, const struct sr_input *structure) :
- UserOwned(structure),
- _context(move(context)),
- _device(nullptr)
+ _structure(structure),
+ _context(move(context))
{
}
shared_ptr<InputDevice> Input::device()
{
- if (!_device)
- {
+ if (!_device) {
auto sdi = sr_input_dev_inst_get(_structure);
if (!sdi)
throw Error(SR_ERR_NA);
- _device = new InputDevice(shared_from_this(), sdi);
+ _device.reset(new InputDevice{shared_from_this(), sdi});
}
- return _device->get_shared_pointer(shared_from_this());
+ return _device->share_owned_by(shared_from_this());
}
void Input::send(void *data, size_t length)
{
auto gstr = g_string_new_len(static_cast<char *>(data), length);
auto ret = sr_input_send(_structure, gstr);
- g_string_free(gstr, false);
+ g_string_free(gstr, true);
check(ret);
}
check(sr_input_end(_structure));
}
+void Input::reset()
+{
+ check(sr_input_reset(_structure));
+}
+
Input::~Input()
{
- if (_device)
- delete _device;
sr_input_free(_structure);
}
InputDevice::InputDevice(shared_ptr<Input> input,
struct sr_dev_inst *structure) :
- ParentOwned(structure),
Device(structure),
_input(move(input))
{
Option::Option(const struct sr_option *structure,
shared_ptr<const struct sr_option *> structure_array) :
- UserOwned(structure),
+ _structure(structure),
_structure_array(move(structure_array))
{
}
{
}
-string Option::id()
+string Option::id() const
{
return valid_string(_structure->id);
}
-string Option::name()
+string Option::name() const
{
return valid_string(_structure->name);
}
-string Option::description()
+string Option::description() const
{
return valid_string(_structure->desc);
}
-Glib::VariantBase Option::default_value()
+Glib::VariantBase Option::default_value() const
{
return Glib::VariantBase(_structure->def, true);
}
-vector<Glib::VariantBase> Option::values()
+vector<Glib::VariantBase> Option::values() const
{
vector<Glib::VariantBase> result;
for (auto l = _structure->values; l; l = l->next) {
return result;
}
+Glib::VariantBase Option::parse_string(string value)
+{
+ enum sr_datatype dt;
+ Glib::VariantBase dflt = default_value();
+ GVariant *tmpl = dflt.gobj();
+
+ if (g_variant_is_of_type(tmpl, G_VARIANT_TYPE_UINT64)) {
+ dt = SR_T_UINT64;
+ } else if (g_variant_is_of_type(tmpl, G_VARIANT_TYPE_STRING)) {
+ dt = SR_T_STRING;
+ } else if (g_variant_is_of_type(tmpl, G_VARIANT_TYPE_BOOLEAN)) {
+ dt = SR_T_BOOL;
+ } else if (g_variant_is_of_type(tmpl, G_VARIANT_TYPE_DOUBLE)) {
+ dt = SR_T_FLOAT;
+ } else if (g_variant_is_of_type(tmpl, G_VARIANT_TYPE_INT32)) {
+ dt = SR_T_INT32;
+ } else {
+ throw Error(SR_ERR_BUG);
+ }
+ return ConfigKey::parse_string(value, dt);
+}
+
OutputFormat::OutputFormat(const struct sr_output_module *structure) :
- ParentOwned(structure)
+ _structure(structure)
{
}
{
}
-string OutputFormat::name()
+string OutputFormat::name() const
{
return valid_string(sr_output_id_get(_structure));
}
-string OutputFormat::description()
+string OutputFormat::description() const
{
return valid_string(sr_output_description_get(_structure));
}
-vector<string> OutputFormat::extensions()
+vector<string> OutputFormat::extensions() const
{
vector<string> exts;
for (const char *const *e = sr_output_extensions_get(_structure);
map<string, shared_ptr<Option>> OutputFormat::options()
{
- const struct sr_option **options = sr_output_options_get(_structure);
map<string, shared_ptr<Option>> result;
- if (options)
- {
- auto option_array = shared_ptr<const struct sr_option *>(
- options, sr_output_options_free);
- for (int i = 0; options[i]; i++)
- result[options[i]->id] = shared_ptr<Option>(
- new Option(options[i], option_array), Option::Deleter());
+
+ if (const struct sr_option **options = sr_output_options_get(_structure)) {
+ shared_ptr<const struct sr_option *> option_array
+ {options, &sr_output_options_free};
+ for (int i = 0; options[i]; i++) {
+ shared_ptr<Option> opt {
+ new Option{options[i], option_array},
+ default_delete<Option>{}};
+ result.emplace(opt->id(), move(opt));
+ }
}
return result;
}
shared_ptr<Output> OutputFormat::create_output(
- shared_ptr<Device> device, const map<string, Glib::VariantBase> &options)
+ shared_ptr<Device> device, map<string, Glib::VariantBase> options)
{
- return shared_ptr<Output>(
- new Output(shared_from_this(), move(device), options),
- Output::Deleter());
+ return shared_ptr<Output>{
+ new Output{shared_from_this(), move(device), move(options)},
+ default_delete<Output>{}};
}
shared_ptr<Output> OutputFormat::create_output(string filename,
- shared_ptr<Device> device, const map<string, Glib::VariantBase> &options)
+ shared_ptr<Device> device, map<string, Glib::VariantBase> options)
{
- return shared_ptr<Output>(
- new Output(move(filename), shared_from_this(), move(device), options),
- Output::Deleter());
+ return shared_ptr<Output>{
+ new Output{move(filename), shared_from_this(), move(device), move(options)},
+ default_delete<Output>{}};
}
-bool OutputFormat::test_flag(const OutputFlag *flag)
+bool OutputFormat::test_flag(const OutputFlag *flag) const
{
return sr_output_test_flag(_structure, flag->id());
}
Output::Output(shared_ptr<OutputFormat> format,
- shared_ptr<Device> device, const map<string, Glib::VariantBase> &options) :
- UserOwned(sr_output_new(format->_structure,
+ shared_ptr<Device> device, map<string, Glib::VariantBase> options) :
+ _structure(sr_output_new(format->_structure,
map_to_hash_variant(options), device->_structure, nullptr)),
_format(move(format)),
_device(move(device)),
- _options(options)
+ _options(move(options))
{
}
Output::Output(string filename, shared_ptr<OutputFormat> format,
- shared_ptr<Device> device, const map<string, Glib::VariantBase> &options) :
- UserOwned(sr_output_new(format->_structure,
+ shared_ptr<Device> device, map<string, Glib::VariantBase> options) :
+ _structure(sr_output_new(format->_structure,
map_to_hash_variant(options), device->_structure, filename.c_str())),
_format(move(format)),
_device(move(device)),
- _options(options)
+ _options(move(options))
{
}
check(sr_output_free(_structure));
}
+shared_ptr<OutputFormat> Output::format()
+{
+ return _format;
+}
+
string Output::receive(shared_ptr<Packet> packet)
{
GString *out;
check(sr_output_send(_structure, packet->_structure, &out));
- if (out)
- {
+ if (out) {
auto result = string(out->str, out->str + out->len);
g_string_free(out, true);
return result;
- }
- else
- {
+ } else {
return string();
}
}
projects / libsigrok.git / blobdiff