[libsigrok.git] / src / hardware / uni-t-ut32x / api.c

/*
 * This file is part of the libsigrok project.
 *
 * Copyright (C) 2013 Bert Vermeulen <bert@biot.com>
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

#include <config.h>
#include <string.h>
#include "protocol.h"

static const uint32_t devopts[] = {
	SR_CONF_THERMOMETER,
	SR_CONF_CONTINUOUS,
	SR_CONF_LIMIT_SAMPLES | SR_CONF_GET | SR_CONF_SET,
	SR_CONF_DATA_SOURCE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
};

static const char *channel_names[] = {
	"T1", "T2", "T1-T2",
};

static const char *data_sources[] = {
	"Live",
	"Memory",
};

static GSList *scan(struct sr_dev_driver *di, GSList *options)
{
	struct drv_context *drvc;
	struct dev_context *devc;
	struct sr_dev_inst *sdi;
	struct sr_config *src;
	GSList *usb_devices, *devices, *l;
	unsigned int i;
	const char *conn;

	drvc = di->context;
	drvc->instances = NULL;

	conn = NULL;
	for (l = options; l; l = l->next) {
		src = l->data;
		switch (src->key) {
		case SR_CONF_CONN:
			conn = g_variant_get_string(src->data, NULL);
			break;
		}
	}
	if (!conn)
		return NULL;

	devices = NULL;
	if ((usb_devices = sr_usb_find(drvc->sr_ctx->libusb_ctx, conn))) {
		/* We have a list of sr_usb_dev_inst matching the connection
		 * string. Wrap them in sr_dev_inst and we're done. */
		for (l = usb_devices; l; l = l->next) {
			sdi = g_malloc0(sizeof(struct sr_dev_inst));
			sdi->status = SR_ST_INACTIVE;
			sdi->vendor = g_strdup(VENDOR);
			sdi->model = g_strdup(MODEL);
			sdi->driver = di;
			sdi->inst_type = SR_INST_USB;
			sdi->conn = l->data;
			for (i = 0; i < ARRAY_SIZE(channel_names); i++)
				sr_channel_new(sdi, i, SR_CHANNEL_ANALOG, TRUE,
						channel_names[i]);
			devc = g_malloc0(sizeof(struct dev_context));
			sdi->priv = devc;
			devc->limit_samples = 0;
			devc->data_source = DEFAULT_DATA_SOURCE;
			drvc->instances = g_slist_append(drvc->instances, sdi);
			devices = g_slist_append(devices, sdi);
		}
		g_slist_free(usb_devices);
	} else
		g_slist_free_full(usb_devices, g_free);

	return devices;
}

static int dev_open(struct sr_dev_inst *sdi)
{
	struct sr_dev_driver *di = sdi->driver;
	struct drv_context *drvc = di->context;
	struct sr_usb_dev_inst *usb;
	int ret;

	usb = sdi->conn;

	if (sr_usb_open(drvc->sr_ctx->libusb_ctx, usb) != SR_OK)
		return SR_ERR;

/*
 * The libusb 1.0.9 Darwin backend is broken: it can report a kernel
 * driver being active, but detaching it always returns an error.
 */
#if !defined(__APPLE__)
	if (libusb_kernel_driver_active(usb->devhdl, USB_INTERFACE) == 1) {
		if ((ret = libusb_detach_kernel_driver(usb->devhdl, USB_INTERFACE)) < 0) {
			sr_err("failed to detach kernel driver: %s",
					libusb_error_name(ret));
			return SR_ERR;
		}
	}
#endif

	if ((ret = libusb_set_configuration(usb->devhdl, USB_CONFIGURATION))) {
		sr_err("Failed to set configuration: %s.", libusb_error_name(ret));
		return SR_ERR;
	}

	if ((ret = libusb_claim_interface(usb->devhdl, USB_INTERFACE))) {
		sr_err("Failed to claim interface: %s.", libusb_error_name(ret));
		return SR_ERR;
	}
	sdi->status = SR_ST_ACTIVE;

	return ret;
}

static int dev_close(struct sr_dev_inst *sdi)
{
	struct sr_usb_dev_inst *usb;

	usb = sdi->conn;
	if (!usb->devhdl)
		/*  Nothing to do. */
		return SR_OK;

	libusb_release_interface(usb->devhdl, USB_INTERFACE);
	libusb_close(usb->devhdl);
	usb->devhdl = NULL;
	sdi->status = SR_ST_INACTIVE;

	return SR_OK;
}

static int config_get(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
		const struct sr_channel_group *cg)
{
	struct dev_context *devc;

	(void)cg;

	devc = sdi->priv;
	switch (key) {
	case SR_CONF_LIMIT_SAMPLES:
		*data = g_variant_new_uint64(devc->limit_samples);
		break;
	case SR_CONF_DATA_SOURCE:
		if (devc->data_source == DATA_SOURCE_LIVE)
			*data = g_variant_new_string("Live");
		else
			*data = g_variant_new_string("Memory");
		break;
	default:
		return SR_ERR_NA;
	}

	return SR_OK;
}

static int config_set(uint32_t key, GVariant *data, const struct sr_dev_inst *sdi,
		const struct sr_channel_group *cg)
{
	struct dev_context *devc;
	const char *tmp_str;

	(void)cg;

	if (sdi->status != SR_ST_ACTIVE)
		return SR_ERR_DEV_CLOSED;

	devc = sdi->priv;

	switch (key) {
	case SR_CONF_LIMIT_SAMPLES:
		devc->limit_samples = g_variant_get_uint64(data);
		break;
	case SR_CONF_DATA_SOURCE:
		tmp_str = g_variant_get_string(data, NULL);
		if (!strcmp(tmp_str, "Live"))
			devc->data_source = DATA_SOURCE_LIVE;
		else if (!strcmp(tmp_str, "Memory"))
			devc->data_source = DATA_SOURCE_MEMORY;
		else
			return SR_ERR;
		break;
	default:
		return SR_ERR_NA;
	}

	return SR_OK;
}

static int config_list(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
		const struct sr_channel_group *cg)
{
	(void)sdi;
	(void)cg;

	switch (key) {
	case SR_CONF_DEVICE_OPTIONS:
		*data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
				devopts, ARRAY_SIZE(devopts), sizeof(uint32_t));
		break;
	case SR_CONF_DATA_SOURCE:
		*data = g_variant_new_strv(data_sources, ARRAY_SIZE(data_sources));
		break;
	default:
		return SR_ERR_NA;
	}

	return SR_OK;
}

static int dev_acquisition_start(const struct sr_dev_inst *sdi)
{
	struct sr_dev_driver *di = sdi->driver;
	struct drv_context *drvc;
	struct dev_context *devc;
	struct sr_usb_dev_inst *usb;
	int len, ret;
	unsigned char cmd[2];

	if (sdi->status != SR_ST_ACTIVE)
		return SR_ERR_DEV_CLOSED;

	drvc = di->context;
	devc = sdi->priv;
	usb = sdi->conn;

	devc->num_samples = 0;
	devc->packet_len = 0;

	/* Configure serial port parameters on USB-UART interface
	 * chip inside the device (just baudrate 2400 actually). */
	cmd[0] = 0x09;
	cmd[1] = 0x60;
	ret = libusb_control_transfer(usb->devhdl, 0x21, 0x09, 0x0300, 0x00,
			cmd, 2, 5);
	if (ret != 2) {
		sr_dbg("Failed to configure CH9325: %s", libusb_error_name(ret));
		return SR_ERR;
	}

	std_session_send_df_header(sdi, LOG_PREFIX);

	if (!(devc->xfer = libusb_alloc_transfer(0)))
		return SR_ERR;

	/* Length of payload to follow. */
	cmd[0] = 0x01;
	if (devc->data_source == DATA_SOURCE_LIVE)
		cmd[1] = CMD_GET_LIVE;
	else
		cmd[1] = CMD_GET_STORED;

	ret = libusb_bulk_transfer(usb->devhdl, EP_OUT, cmd, 2, &len, 5);
	if (ret != 0 || len != 2) {
		sr_dbg("Failed to start acquisition: %s", libusb_error_name(ret));
		libusb_free_transfer(devc->xfer);
		return SR_ERR;
	}

	libusb_fill_bulk_transfer(devc->xfer, usb->devhdl, EP_IN, devc->buf,
			8, uni_t_ut32x_receive_transfer, (void *)sdi, 15);
	if (libusb_submit_transfer(devc->xfer) != 0) {
		libusb_free_transfer(devc->xfer);
		return SR_ERR;
	}

	usb_source_add(sdi->session, drvc->sr_ctx, 10,
			uni_t_ut32x_handle_events, (void *)sdi);

	return SR_OK;
}

static int dev_acquisition_stop(struct sr_dev_inst *sdi)
{
	if (sdi->status != SR_ST_ACTIVE)
		return SR_ERR_DEV_CLOSED;

	/* Signal USB transfer handler to clean up and stop. */
	sdi->status = SR_ST_STOPPING;

	return SR_OK;
}

static struct sr_dev_driver uni_t_ut32x_driver_info = {
	.name = "uni-t-ut32x",
	.longname = "UNI-T UT32x",
	.api_version = 1,
	.init = std_init,
	.cleanup = std_cleanup,
	.scan = scan,
	.dev_list = std_dev_list,
	.dev_clear = NULL,
	.config_get = config_get,
	.config_set = config_set,
	.config_list = config_list,
	.dev_open = dev_open,
	.dev_close = dev_close,
	.dev_acquisition_start = dev_acquisition_start,
	.dev_acquisition_stop = dev_acquisition_stop,
	.context = NULL,
};
SR_REGISTER_DEV_DRIVER(uni_t_ut32x_driver_info);
Commit	Line	Data
3877dde4 BV	1	/*
	2	* This file is part of the libsigrok project.
	3	*
	4	* Copyright (C) 2013 Bert Vermeulen <bert@biot.com>
	5	*
	6	* This program is free software: you can redistribute it and/or modify
	7	* it under the terms of the GNU General Public License as published by
	8	* the Free Software Foundation, either version 3 of the License, or
	9	* (at your option) any later version.
	10	*
	11	* This program is distributed in the hope that it will be useful,
	12	* but WITHOUT ANY WARRANTY; without even the implied warranty of
	13	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
	14	* GNU General Public License for more details.
	15	*
	16	* You should have received a copy of the GNU General Public License
	17	* along with this program. If not, see <http://www.gnu.org/licenses/>.
	18	*/
	19
6ec6c43b	20	#include <config.h>
6513f97f	21	#include <string.h>
515ab088	22	#include "protocol.h"
6513f97f	23
f254bc4b	24	static const uint32_t devopts[] = {
6513f97f	25	SR_CONF_THERMOMETER,
6513f97f	26	SR_CONF_CONTINUOUS,
5827f61b BV	27	SR_CONF_LIMIT_SAMPLES \| SR_CONF_GET \| SR_CONF_SET,
5827f61b BV	28	SR_CONF_DATA_SOURCE \| SR_CONF_GET \| SR_CONF_SET \| SR_CONF_LIST,
6513f97f BV	29	};
6513f97f BV	30
0f34cb47 UH	31	static const char *channel_names[] = {
0f34cb47 UH	32	"T1", "T2", "T1-T2",
6513f97f BV	33	};
	34
	35	static const char *data_sources[] = {
	36	"Live",
	37	"Memory",
	38	};
	39
4f840ce9	40	static GSList scan(struct sr_dev_driver di, GSList *options)
3877dde4 BV	41	{
3877dde4 BV	42	struct drv_context *drvc;
6513f97f BV	43	struct dev_context *devc;
6513f97f BV	44	struct sr_dev_inst *sdi;
6513f97f BV	45	struct sr_config *src;
6513f97f BV	46	GSList usb_devices, devices, *l;
07ffa5b3	47	unsigned int i;
6513f97f	48	const char *conn;
3877dde4	49
41812aca	50	drvc = di->context;
3877dde4 BV	51	drvc->instances = NULL;
3877dde4 BV	52
6513f97f BV	53	conn = NULL;
	54	for (l = options; l; l = l->next) {
	55	src = l->data;
	56	switch (src->key) {
	57	case SR_CONF_CONN:
	58	conn = g_variant_get_string(src->data, NULL);
	59	break;
	60	}
	61	}
	62	if (!conn)
	63	return NULL;
	64
	65	devices = NULL;
e196cb61	66	if ((usb_devices = sr_usb_find(drvc->sr_ctx->libusb_ctx, conn))) {
6513f97f BV	67	/* We have a list of sr_usb_dev_inst matching the connection
	68	* string. Wrap them in sr_dev_inst and we're done. */
	69	for (l = usb_devices; l; l = l->next) {
aac29cc1	70	sdi = g_malloc0(sizeof(struct sr_dev_inst));
0af636be UH	71	sdi->status = SR_ST_INACTIVE;
	72	sdi->vendor = g_strdup(VENDOR);
	73	sdi->model = g_strdup(MODEL);
6513f97f BV	74	sdi->driver = di;
	75	sdi->inst_type = SR_INST_USB;
	76	sdi->conn = l->data;
07ffa5b3	77	for (i = 0; i < ARRAY_SIZE(channel_names); i++)
0f34cb47 UH	78	sr_channel_new(sdi, i, SR_CHANNEL_ANALOG, TRUE,
0f34cb47 UH	79	channel_names[i]);
f57d8ffe	80	devc = g_malloc0(sizeof(struct dev_context));
6513f97f BV	81	sdi->priv = devc;
	82	devc->limit_samples = 0;
	83	devc->data_source = DEFAULT_DATA_SOURCE;
	84	drvc->instances = g_slist_append(drvc->instances, sdi);
	85	devices = g_slist_append(devices, sdi);
	86	}
	87	g_slist_free(usb_devices);
	88	} else
	89	g_slist_free_full(usb_devices, g_free);
3877dde4 BV	90
	91	return devices;
	92	}
	93
3877dde4 BV	94	static int dev_open(struct sr_dev_inst *sdi)
3877dde4 BV	95	{
4f840ce9	96	struct sr_dev_driver *di = sdi->driver;
efa98402	97	struct drv_context *drvc = di->context;
6513f97f BV	98	struct sr_usb_dev_inst *usb;
	99	int ret;
	100
6513f97f BV	101	usb = sdi->conn;
	102
	103	if (sr_usb_open(drvc->sr_ctx->libusb_ctx, usb) != SR_OK)
	104	return SR_ERR;
	105
	106	/*
f3f19d11	107	* The libusb 1.0.9 Darwin backend is broken: it can report a kernel
6513f97f BV	108	* driver being active, but detaching it always returns an error.
	109	*/
	110	#if !defined(__APPLE__)
d6ff054a BV	111	if (libusb_kernel_driver_active(usb->devhdl, USB_INTERFACE) == 1) {
d6ff054a BV	112	if ((ret = libusb_detach_kernel_driver(usb->devhdl, USB_INTERFACE)) < 0) {
6513f97f BV	113	sr_err("failed to detach kernel driver: %s",
	114	libusb_error_name(ret));
	115	return SR_ERR;
	116	}
	117	}
	118	#endif
3877dde4	119
d6ff054a	120	if ((ret = libusb_set_configuration(usb->devhdl, USB_CONFIGURATION))) {
6513f97f BV	121	sr_err("Failed to set configuration: %s.", libusb_error_name(ret));
	122	return SR_ERR;
	123	}
3877dde4	124
6513f97f BV	125	if ((ret = libusb_claim_interface(usb->devhdl, USB_INTERFACE))) {
	126	sr_err("Failed to claim interface: %s.", libusb_error_name(ret));
	127	return SR_ERR;
	128	}
3877dde4 BV	129	sdi->status = SR_ST_ACTIVE;
3877dde4 BV	130
6513f97f	131	return ret;
3877dde4 BV	132	}
	133
	134	static int dev_close(struct sr_dev_inst *sdi)
	135	{
6513f97f	136	struct sr_usb_dev_inst *usb;
3877dde4	137
6513f97f BV	138	usb = sdi->conn;
	139	if (!usb->devhdl)
	140	/* Nothing to do. */
	141	return SR_OK;
3877dde4	142
6513f97f BV	143	libusb_release_interface(usb->devhdl, USB_INTERFACE);
	144	libusb_close(usb->devhdl);
	145	usb->devhdl = NULL;
3877dde4 BV	146	sdi->status = SR_ST_INACTIVE;
	147
	148	return SR_OK;
	149	}
	150
584560f1	151	static int config_get(uint32_t key, GVariant *data, const struct sr_dev_inst sdi,
53b4680f	152	const struct sr_channel_group *cg)
3877dde4	153	{
6513f97f	154	struct dev_context *devc;
3877dde4	155
53b4680f	156	(void)cg;
d3c74a6f	157
6513f97f	158	devc = sdi->priv;
3877dde4	159	switch (key) {
6513f97f BV	160	case SR_CONF_LIMIT_SAMPLES:
	161	*data = g_variant_new_uint64(devc->limit_samples);
	162	break;
	163	case SR_CONF_DATA_SOURCE:
	164	if (devc->data_source == DATA_SOURCE_LIVE)
	165	*data = g_variant_new_string("Live");
	166	else
	167	*data = g_variant_new_string("Memory");
	168	break;
3877dde4 BV	169	default:
	170	return SR_ERR_NA;
	171	}
	172
6513f97f	173	return SR_OK;
3877dde4 BV	174	}
3877dde4 BV	175
584560f1	176	static int config_set(uint32_t key, GVariant data, const struct sr_dev_inst sdi,
53b4680f	177	const struct sr_channel_group *cg)
3877dde4	178	{
6513f97f	179	struct dev_context *devc;
6513f97f	180	const char *tmp_str;
3877dde4	181
53b4680f	182	(void)cg;
d3c74a6f	183
3877dde4 BV	184	if (sdi->status != SR_ST_ACTIVE)
	185	return SR_ERR_DEV_CLOSED;
	186
6513f97f	187	devc = sdi->priv;
dcd438ee	188
3877dde4	189	switch (key) {
6513f97f BV	190	case SR_CONF_LIMIT_SAMPLES:
6513f97f BV	191	devc->limit_samples = g_variant_get_uint64(data);
6513f97f BV	192	break;
	193	case SR_CONF_DATA_SOURCE:
	194	tmp_str = g_variant_get_string(data, NULL);
	195	if (!strcmp(tmp_str, "Live"))
	196	devc->data_source = DATA_SOURCE_LIVE;
	197	else if (!strcmp(tmp_str, "Memory"))
	198	devc->data_source = DATA_SOURCE_MEMORY;
	199	else
	200	return SR_ERR;
	201	break;
3877dde4	202	default:
dcd438ee	203	return SR_ERR_NA;
3877dde4 BV	204	}
3877dde4 BV	205
dcd438ee	206	return SR_OK;
3877dde4 BV	207	}
3877dde4 BV	208
584560f1	209	static int config_list(uint32_t key, GVariant *data, const struct sr_dev_inst sdi,
53b4680f	210	const struct sr_channel_group *cg)
3877dde4	211	{
3877dde4	212	(void)sdi;
53b4680f	213	(void)cg;
3877dde4	214
3877dde4	215	switch (key) {
6513f97f	216	case SR_CONF_DEVICE_OPTIONS:
584560f1	217	*data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
f254bc4b	218	devopts, ARRAY_SIZE(devopts), sizeof(uint32_t));
6513f97f BV	219	break;
	220	case SR_CONF_DATA_SOURCE:
	221	*data = g_variant_new_strv(data_sources, ARRAY_SIZE(data_sources));
	222	break;
3877dde4 BV	223	default:
	224	return SR_ERR_NA;
	225	}
	226
6513f97f	227	return SR_OK;
3877dde4 BV	228	}
3877dde4 BV	229
695dc859	230	static int dev_acquisition_start(const struct sr_dev_inst *sdi)
3877dde4	231	{
4f840ce9	232	struct sr_dev_driver *di = sdi->driver;
6513f97f BV	233	struct drv_context *drvc;
	234	struct dev_context *devc;
	235	struct sr_usb_dev_inst *usb;
6c60facc	236	int len, ret;
6513f97f	237	unsigned char cmd[2];
3877dde4 BV	238
	239	if (sdi->status != SR_ST_ACTIVE)
	240	return SR_ERR_DEV_CLOSED;
	241
41812aca	242	drvc = di->context;
6513f97f BV	243	devc = sdi->priv;
	244	usb = sdi->conn;
	245
6513f97f	246	devc->num_samples = 0;
d6ff054a BV	247	devc->packet_len = 0;
	248
	249	/* Configure serial port parameters on USB-UART interface
	250	* chip inside the device (just baudrate 2400 actually). */
	251	cmd[0] = 0x09;
	252	cmd[1] = 0x60;
	253	ret = libusb_control_transfer(usb->devhdl, 0x21, 0x09, 0x0300, 0x00,
	254	cmd, 2, 5);
	255	if (ret != 2) {
	256	sr_dbg("Failed to configure CH9325: %s", libusb_error_name(ret));
	257	return SR_ERR;
	258	}
6513f97f	259
695dc859	260	std_session_send_df_header(sdi, LOG_PREFIX);
6513f97f BV	261
	262	if (!(devc->xfer = libusb_alloc_transfer(0)))
	263	return SR_ERR;
	264
6513f97f BV	265	/* Length of payload to follow. */
	266	cmd[0] = 0x01;
	267	if (devc->data_source == DATA_SOURCE_LIVE)
	268	cmd[1] = CMD_GET_LIVE;
	269	else
	270	cmd[1] = CMD_GET_STORED;
	271
	272	ret = libusb_bulk_transfer(usb->devhdl, EP_OUT, cmd, 2, &len, 5);
	273	if (ret != 0 \|\| len != 2) {
	274	sr_dbg("Failed to start acquisition: %s", libusb_error_name(ret));
	275	libusb_free_transfer(devc->xfer);
	276	return SR_ERR;
	277	}
	278
	279	libusb_fill_bulk_transfer(devc->xfer, usb->devhdl, EP_IN, devc->buf,
d6ff054a	280	8, uni_t_ut32x_receive_transfer, (void *)sdi, 15);
6513f97f BV	281	if (libusb_submit_transfer(devc->xfer) != 0) {
	282	libusb_free_transfer(devc->xfer);
	283	return SR_ERR;
	284	}
3877dde4	285
102f1239 BV	286	usb_source_add(sdi->session, drvc->sr_ctx, 10,
102f1239 BV	287	uni_t_ut32x_handle_events, (void *)sdi);
d6ff054a	288
3877dde4 BV	289	return SR_OK;
	290	}
	291
695dc859	292	static int dev_acquisition_stop(struct sr_dev_inst *sdi)
3877dde4	293	{
3877dde4 BV	294	if (sdi->status != SR_ST_ACTIVE)
	295	return SR_ERR_DEV_CLOSED;
	296
d6ff054a BV	297	/* Signal USB transfer handler to clean up and stop. */
d6ff054a BV	298	sdi->status = SR_ST_STOPPING;
3877dde4 BV	299
	300	return SR_OK;
	301	}
	302
dd5c48a6	303	static struct sr_dev_driver uni_t_ut32x_driver_info = {
3877dde4 BV	304	.name = "uni-t-ut32x",
	305	.longname = "UNI-T UT32x",
	306	.api_version = 1,
c2fdcc25	307	.init = std_init,
700d6b64	308	.cleanup = std_cleanup,
3877dde4	309	.scan = scan,
c01bf34c	310	.dev_list = std_dev_list,
a6630742	311	.dev_clear = NULL,
3877dde4 BV	312	.config_get = config_get,
	313	.config_set = config_set,
	314	.config_list = config_list,
	315	.dev_open = dev_open,
	316	.dev_close = dev_close,
	317	.dev_acquisition_start = dev_acquisition_start,
	318	.dev_acquisition_stop = dev_acquisition_stop,
41812aca	319	.context = NULL,
3877dde4	320	};
dd5c48a6	321	SR_REGISTER_DEV_DRIVER(uni_t_ut32x_driver_info);