]> sigrok.org Git - libsigrok.git/blame - src/hardware/chronovu-la/api.c
Simplify channel creation.
[libsigrok.git] / src / hardware / chronovu-la / api.c
CommitLineData
b908f067 1/*
50985c20 2 * This file is part of the libsigrok project.
b908f067 3 *
b172c130 4 * Copyright (C) 2011-2014 Uwe Hermann <uwe@hermann-uwe.de>
b908f067
UH
5 *
6 * This program is free software; you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License as published by
8 * the Free Software Foundation; either version 2 of the License, or
9 * (at your option) any later version.
10 *
11 * This program is distributed in the hope that it will be useful,
12 * but WITHOUT ANY WARRANTY; without even the implied warranty of
13 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 * GNU General Public License for more details.
15 *
16 * You should have received a copy of the GNU General Public License
17 * along with this program; if not, write to the Free Software
18 * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
19 */
20
45e080b6 21#include "protocol.h"
b908f067 22
7b356712
UH
23SR_PRIV struct sr_dev_driver chronovu_la_driver_info;
24static struct sr_dev_driver *di = &chronovu_la_driver_info;
b908f067 25
f254bc4b 26static const uint32_t devopts[] = {
1bec72d2 27 SR_CONF_LOGIC_ANALYZER,
5827f61b
BV
28 SR_CONF_LIMIT_MSEC | SR_CONF_SET,
29 SR_CONF_LIMIT_SAMPLES | SR_CONF_SET | SR_CONF_LIST,
30 SR_CONF_SAMPLERATE | SR_CONF_GET | SR_CONF_SET | SR_CONF_LIST,
31 SR_CONF_TRIGGER_MATCH | SR_CONF_LIST,
1bec72d2
BV
32};
33
aeff7fa2
BV
34static const int32_t trigger_matches[] = {
35 SR_TRIGGER_ZERO,
36 SR_TRIGGER_ONE,
37 SR_TRIGGER_RISING,
38 SR_TRIGGER_FALLING,
39};
40
00910580
UH
41/* The ChronoVu LA8/LA16 can have multiple VID/PID pairs. */
42static struct {
43 uint16_t vid;
44 uint16_t pid;
45 int model;
46 const char *iproduct;
47} vid_pid[] = {
48 { 0x0403, 0x6001, CHRONOVU_LA8, "ChronoVu LA8" },
49 { 0x0403, 0x8867, CHRONOVU_LA8, "ChronoVu LA8" },
50 { 0x0403, 0x6001, CHRONOVU_LA16, "ChronoVu LA16" },
51 { 0x0403, 0x8867, CHRONOVU_LA16, "ChronoVu LA16" },
74e5f12d
UH
52};
53
6078d2c9 54static int dev_acquisition_stop(struct sr_dev_inst *sdi, void *cb_data);
b908f067 55
97900799 56static void clear_helper(void *priv)
c4f3ed4b 57{
1644fb24 58 struct dev_context *devc;
b172c130 59
97900799 60 devc = priv;
1644fb24 61
97900799
UH
62 ftdi_free(devc->ftdic);
63 g_free(devc->final_buf);
64}
c4f3ed4b 65
3b412e3a 66static int dev_clear(void)
97900799
UH
67{
68 return std_dev_clear(di, clear_helper);
c4f3ed4b
BV
69}
70
6078d2c9 71static int init(struct sr_context *sr_ctx)
61136ea6 72{
f6beaac5 73 return std_init(sr_ctx, di, LOG_PREFIX);
61136ea6
BV
74}
75
00910580 76static int add_device(int idx, int model, GSList **devices)
b908f067 77{
00910580
UH
78 int ret;
79 unsigned int i;
b908f067 80 struct sr_dev_inst *sdi;
1644fb24
BV
81 struct drv_context *drvc;
82 struct dev_context *devc;
c4f3ed4b 83
00910580 84 ret = SR_OK;
f3a35908
UH
85
86 drvc = di->priv;
4b97c74e 87
1644fb24 88 /* Allocate memory for our private device context. */
f57d8ffe 89 devc = g_malloc0(sizeof(struct dev_context));
b908f067
UH
90
91 /* Set some sane defaults. */
00910580
UH
92 devc->prof = &cv_profiles[model];
93 devc->ftdic = NULL; /* Will be set in the open() API call. */
94 devc->cur_samplerate = 0; /* Set later (different for LA8/LA16). */
1644fb24
BV
95 devc->limit_msec = 0;
96 devc->limit_samples = 0;
3e9b7f9c 97 devc->cb_data = NULL;
1644fb24
BV
98 memset(devc->mangled_buf, 0, BS);
99 devc->final_buf = NULL;
00910580
UH
100 devc->trigger_pattern = 0x0000; /* Irrelevant, see trigger_mask. */
101 devc->trigger_mask = 0x0000; /* All channels: "don't care". */
102 devc->trigger_edgemask = 0x0000; /* All channels: "state triggered". */
1644fb24
BV
103 devc->trigger_found = 0;
104 devc->done = 0;
105 devc->block_counter = 0;
00910580
UH
106 devc->divcount = 0;
107 devc->usb_vid = vid_pid[idx].vid;
108 devc->usb_pid = vid_pid[idx].pid;
109 memset(devc->samplerates, 0, sizeof(uint64_t) * 255);
b908f067
UH
110
111 /* Allocate memory where we'll store the de-mangled data. */
1644fb24 112 if (!(devc->final_buf = g_try_malloc(SDRAM_SIZE))) {
b172c130 113 sr_err("Failed to allocate memory for sample buffer.");
00910580 114 ret = SR_ERR_MALLOC;
1644fb24 115 goto err_free_devc;
b908f067
UH
116 }
117
00910580
UH
118 /* We now know the device, set its max. samplerate as default. */
119 devc->cur_samplerate = devc->prof->max_samplerate;
b908f067
UH
120
121 /* Register the device with libsigrok. */
aac29cc1 122 sdi = g_malloc0(sizeof(struct sr_dev_inst));
0af636be
UH
123 sdi->status = SR_ST_INITIALIZING;
124 sdi->vendor = g_strdup("ChronoVu");
125 sdi->model = g_strdup(devc->prof->modelname);
f3a35908 126 sdi->driver = di;
1644fb24 127 sdi->priv = devc;
b908f067 128
5e23fcab
ML
129 for (i = 0; i < devc->prof->num_channels; i++)
130 sr_channel_new(sdi, i, SR_CHANNEL_LOGIC, TRUE,
c368e6f3 131 cv_channel_names[i]);
87ca93c5 132
00910580 133 *devices = g_slist_append(*devices, sdi);
1644fb24 134 drvc->instances = g_slist_append(drvc->instances, sdi);
b908f067 135
65c8d48f
BV
136 if (ret == SR_OK)
137 return SR_OK;
b908f067 138
1644fb24
BV
139err_free_devc:
140 g_free(devc);
b908f067 141
00910580
UH
142 return ret;
143}
144
145static GSList *scan(GSList *options)
146{
147 int ret;
148 unsigned int i;
149 GSList *devices;
150 struct ftdi_context *ftdic;
151
152 (void)options;
153
154 devices = NULL;
155
156 /* Allocate memory for the FTDI context and initialize it. */
157 if (!(ftdic = ftdi_new())) {
158 sr_err("Failed to initialize libftdi.");
159 return NULL;
160 }
161
162 /* Check for LA8 and/or LA16 devices with various VID/PIDs. */
163 for (i = 0; i < ARRAY_SIZE(vid_pid); i++) {
164 ret = ftdi_usb_open_desc(ftdic, vid_pid[i].vid,
165 vid_pid[i].pid, vid_pid[i].iproduct, NULL);
cfe01d06
UH
166 /* Show errors other than "device not found". */
167 if (ret < 0 && ret != -3)
168 sr_dbg("Error finding/opening device (%d): %s.",
169 ret, ftdi_get_error_string(ftdic));
00910580 170 if (ret < 0)
cfe01d06 171 continue; /* No device found, or not usable. */
00910580
UH
172
173 sr_dbg("Found %s device (%04x:%04x).",
174 vid_pid[i].iproduct, vid_pid[i].vid, vid_pid[i].pid);
175
176 if ((ret = add_device(i, vid_pid[i].model, &devices)) < 0)
177 sr_dbg("Failed to add device: %d.", ret);
178
179 if ((ret = ftdi_usb_close(ftdic)) < 0)
180 sr_dbg("Failed to close FTDI device (%d): %s.",
181 ret, ftdi_get_error_string(ftdic));
182 }
183
184 /* Close USB device, deinitialize and free the FTDI context. */
185 ftdi_free(ftdic);
186 ftdic = NULL;
187
188 return devices;
b908f067
UH
189}
190
6078d2c9 191static GSList *dev_list(void)
811deee4 192{
0e94d524 193 return ((struct drv_context *)(di->priv))->instances;
811deee4
BV
194}
195
6078d2c9 196static int dev_open(struct sr_dev_inst *sdi)
b908f067 197{
1644fb24 198 struct dev_context *devc;
25a0f108 199 int ret;
b908f067 200
b172c130 201 if (!(devc = sdi->priv))
b908f067 202 return SR_ERR_BUG;
b908f067 203
00910580
UH
204 /* Allocate memory for the FTDI context and initialize it. */
205 if (!(devc->ftdic = ftdi_new())) {
206 sr_err("Failed to initialize libftdi.");
207 return SR_ERR;
208 }
209
210 sr_dbg("Opening %s device (%04x:%04x).", devc->prof->modelname,
211 devc->usb_vid, devc->usb_pid);
b908f067
UH
212
213 /* Open the device. */
00910580
UH
214 if ((ret = ftdi_usb_open_desc(devc->ftdic, devc->usb_vid,
215 devc->usb_pid, devc->prof->iproduct, NULL)) < 0) {
b172c130
UH
216 sr_err("Failed to open FTDI device (%d): %s.",
217 ret, ftdi_get_error_string(devc->ftdic));
00910580 218 goto err_ftdi_free;
b908f067 219 }
f3a35908 220 sr_dbg("Device opened successfully.");
b908f067
UH
221
222 /* Purge RX/TX buffers in the FTDI chip. */
1644fb24 223 if ((ret = ftdi_usb_purge_buffers(devc->ftdic)) < 0) {
b172c130
UH
224 sr_err("Failed to purge FTDI buffers (%d): %s.",
225 ret, ftdi_get_error_string(devc->ftdic));
00910580 226 goto err_ftdi_free;
b908f067 227 }
f3a35908 228 sr_dbg("FTDI buffers purged successfully.");
b908f067
UH
229
230 /* Enable flow control in the FTDI chip. */
1644fb24 231 if ((ret = ftdi_setflowctrl(devc->ftdic, SIO_RTS_CTS_HS)) < 0) {
b172c130
UH
232 sr_err("Failed to enable FTDI flow control (%d): %s.",
233 ret, ftdi_get_error_string(devc->ftdic));
00910580 234 goto err_ftdi_free;
b908f067 235 }
f3a35908 236 sr_dbg("FTDI flow control enabled successfully.");
b908f067
UH
237
238 /* Wait 100ms. */
239 g_usleep(100 * 1000);
240
241 sdi->status = SR_ST_ACTIVE;
242
65c8d48f
BV
243 if (ret == SR_OK)
244 return SR_OK;
b908f067 245
00910580
UH
246err_ftdi_free:
247 ftdi_free(devc->ftdic); /* Close device (if open), free FTDI context. */
248 devc->ftdic = NULL;
249 return ret;
b908f067
UH
250}
251
6078d2c9 252static int dev_close(struct sr_dev_inst *sdi)
b908f067 253{
00910580 254 int ret;
1644fb24 255 struct dev_context *devc;
b908f067 256
00910580
UH
257 if (sdi->status != SR_ST_ACTIVE)
258 return SR_OK;
b908f067 259
00910580 260 devc = sdi->priv;
b908f067 261
00910580
UH
262 if (devc->ftdic && (ret = ftdi_usb_close(devc->ftdic)) < 0)
263 sr_err("Failed to close FTDI device (%d): %s.",
264 ret, ftdi_get_error_string(devc->ftdic));
b908f067
UH
265 sdi->status = SR_ST_INACTIVE;
266
b908f067
UH
267 return SR_OK;
268}
269
6078d2c9 270static int cleanup(void)
b908f067 271{
3b412e3a 272 return dev_clear();
b908f067
UH
273}
274
584560f1 275static int config_get(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
53b4680f 276 const struct sr_channel_group *cg)
b908f067 277{
1644fb24 278 struct dev_context *devc;
b908f067 279
53b4680f 280 (void)cg;
8f996b89 281
584560f1 282 switch (key) {
123e1313 283 case SR_CONF_SAMPLERATE:
b172c130
UH
284 if (!sdi || !(devc = sdi->priv))
285 return SR_ERR_BUG;
286 *data = g_variant_new_uint64(devc->cur_samplerate);
b908f067 287 break;
cfe8a84d 288 default:
bd6fbf62 289 return SR_ERR_NA;
b908f067
UH
290 }
291
6a2761fd 292 return SR_OK;
b908f067
UH
293}
294
584560f1 295static int config_set(uint32_t key, GVariant *data, const struct sr_dev_inst *sdi,
53b4680f 296 const struct sr_channel_group *cg)
b908f067 297{
1644fb24 298 struct dev_context *devc;
b908f067 299
53b4680f 300 (void)cg;
8f996b89 301
e73ffd42
BV
302 if (sdi->status != SR_ST_ACTIVE)
303 return SR_ERR_DEV_CLOSED;
304
b172c130 305 if (!(devc = sdi->priv))
b908f067 306 return SR_ERR_BUG;
b908f067 307
584560f1 308 switch (key) {
1953564a 309 case SR_CONF_SAMPLERATE:
00910580 310 if (cv_set_samplerate(sdi, g_variant_get_uint64(data)) < 0)
b908f067 311 return SR_ERR;
b908f067 312 break;
1953564a 313 case SR_CONF_LIMIT_MSEC:
b172c130
UH
314 if (g_variant_get_uint64(data) == 0)
315 return SR_ERR_ARG;
1bec72d2 316 devc->limit_msec = g_variant_get_uint64(data);
b908f067 317 break;
1953564a 318 case SR_CONF_LIMIT_SAMPLES:
b172c130
UH
319 if (g_variant_get_uint64(data) == 0)
320 return SR_ERR_ARG;
1bec72d2 321 devc->limit_samples = g_variant_get_uint64(data);
b908f067
UH
322 break;
323 default:
bd6fbf62 324 return SR_ERR_NA;
b908f067
UH
325 }
326
327 return SR_OK;
328}
329
584560f1 330static int config_list(uint32_t key, GVariant **data, const struct sr_dev_inst *sdi,
53b4680f 331 const struct sr_channel_group *cg)
a1c743fc 332{
f0de2dd0 333 GVariant *gvar, *grange[2];
1bec72d2 334 GVariantBuilder gvb;
00910580 335 struct dev_context *devc;
a1c743fc 336
53b4680f 337 (void)cg;
a1c743fc
BV
338
339 switch (key) {
9a6517d1 340 case SR_CONF_DEVICE_OPTIONS:
584560f1 341 *data = g_variant_new_fixed_array(G_VARIANT_TYPE_UINT32,
f254bc4b 342 devopts, ARRAY_SIZE(devopts), sizeof(uint32_t));
9a6517d1 343 break;
a1c743fc 344 case SR_CONF_SAMPLERATE:
00910580
UH
345 if (!sdi || !sdi->priv || !(devc = sdi->priv))
346 return SR_ERR_BUG;
347 cv_fill_samplerates_if_needed(sdi);
1bec72d2
BV
348 g_variant_builder_init(&gvb, G_VARIANT_TYPE("a{sv}"));
349 gvar = g_variant_new_fixed_array(G_VARIANT_TYPE("t"),
00910580
UH
350 devc->samplerates,
351 ARRAY_SIZE(devc->samplerates),
1bec72d2
BV
352 sizeof(uint64_t));
353 g_variant_builder_add(&gvb, "{sv}", "samplerates", gvar);
354 *data = g_variant_builder_end(&gvb);
a1c743fc 355 break;
f0de2dd0 356 case SR_CONF_LIMIT_SAMPLES:
69bdcd8b
UH
357 if (!sdi || !sdi->priv || !(devc = sdi->priv) || !devc->prof)
358 return SR_ERR_BUG;
f0de2dd0 359 grange[0] = g_variant_new_uint64(0);
69bdcd8b
UH
360 if (devc->prof->model == CHRONOVU_LA8)
361 grange[1] = g_variant_new_uint64(MAX_NUM_SAMPLES);
362 else
363 grange[1] = g_variant_new_uint64(MAX_NUM_SAMPLES / 2);
f0de2dd0
BV
364 *data = g_variant_new_tuple(grange, 2);
365 break;
aeff7fa2 366 case SR_CONF_TRIGGER_MATCH:
00910580 367 if (!sdi || !sdi->priv || !(devc = sdi->priv) || !devc->prof)
13dd25bd 368 return SR_ERR_BUG;
af945a66 369 *data = g_variant_new_fixed_array(G_VARIANT_TYPE_INT32,
aeff7fa2
BV
370 trigger_matches, devc->prof->num_trigger_matches,
371 sizeof(int32_t));
c50277a6 372 break;
a1c743fc 373 default:
bd6fbf62 374 return SR_ERR_NA;
a1c743fc
BV
375 }
376
377 return SR_OK;
378}
379
b908f067
UH
380static int receive_data(int fd, int revents, void *cb_data)
381{
382 int i, ret;
383 struct sr_dev_inst *sdi;
1644fb24 384 struct dev_context *devc;
b908f067 385
b908f067
UH
386 (void)fd;
387 (void)revents;
388
389 if (!(sdi = cb_data)) {
b172c130 390 sr_err("cb_data was NULL.");
b908f067
UH
391 return FALSE;
392 }
393
1644fb24 394 if (!(devc = sdi->priv)) {
b172c130 395 sr_err("sdi->priv was NULL.");
b908f067
UH
396 return FALSE;
397 }
398
1644fb24 399 if (!devc->ftdic) {
b172c130 400 sr_err("devc->ftdic was NULL.");
b908f067
UH
401 return FALSE;
402 }
403
404 /* Get one block of data. */
b172c130
UH
405 if ((ret = cv_read_block(devc)) < 0) {
406 sr_err("Failed to read data block: %d.", ret);
6078d2c9 407 dev_acquisition_stop(sdi, sdi);
b908f067
UH
408 return FALSE;
409 }
410
411 /* We need to get exactly NUM_BLOCKS blocks (i.e. 8MB) of data. */
1644fb24
BV
412 if (devc->block_counter != (NUM_BLOCKS - 1)) {
413 devc->block_counter++;
b908f067
UH
414 return TRUE;
415 }
416
f3a35908 417 sr_dbg("Sampling finished, sending data to session bus now.");
b908f067 418
b0efc84e
UH
419 /*
420 * All data was received and demangled, send it to the session bus.
421 *
422 * Note: Due to the method how data is spread across the 8MByte of
423 * SDRAM, we can _not_ send it to the session bus in a streaming
424 * manner while we receive it. We have to receive and de-mangle the
425 * full 8MByte first, only then the whole buffer contains valid data.
426 */
b908f067 427 for (i = 0; i < NUM_BLOCKS; i++)
b172c130 428 cv_send_block_to_session_bus(devc, i);
b908f067 429
6078d2c9 430 dev_acquisition_stop(sdi, sdi);
b908f067 431
b908f067
UH
432 return TRUE;
433}
434
6078d2c9 435static int dev_acquisition_start(const struct sr_dev_inst *sdi, void *cb_data)
b908f067 436{
1644fb24 437 struct dev_context *devc;
00910580
UH
438 uint8_t buf[8];
439 int bytes_to_write, bytes_written;
b908f067 440
e73ffd42
BV
441 if (sdi->status != SR_ST_ACTIVE)
442 return SR_ERR_DEV_CLOSED;
443
1644fb24 444 if (!(devc = sdi->priv)) {
b172c130 445 sr_err("sdi->priv was NULL.");
b908f067
UH
446 return SR_ERR_BUG;
447 }
448
1644fb24 449 if (!devc->ftdic) {
b172c130 450 sr_err("devc->ftdic was NULL.");
b908f067
UH
451 return SR_ERR_BUG;
452 }
453
00910580 454 devc->divcount = cv_samplerate_to_divcount(sdi, devc->cur_samplerate);
1644fb24 455 if (devc->divcount == 0xff) {
b172c130 456 sr_err("Invalid divcount/samplerate.");
b908f067
UH
457 return SR_ERR;
458 }
459
aeff7fa2
BV
460 if (cv_convert_trigger(sdi) != SR_OK) {
461 sr_err("Failed to configure trigger.");
014359e3
BV
462 return SR_ERR;
463 }
464
b908f067 465 /* Fill acquisition parameters into buf[]. */
00910580
UH
466 if (devc->prof->model == CHRONOVU_LA8) {
467 buf[0] = devc->divcount;
468 buf[1] = 0xff; /* This byte must always be 0xff. */
469 buf[2] = devc->trigger_pattern & 0xff;
470 buf[3] = devc->trigger_mask & 0xff;
471 bytes_to_write = 4;
472 } else {
473 buf[0] = devc->divcount;
474 buf[1] = 0xff; /* This byte must always be 0xff. */
475 buf[2] = (devc->trigger_pattern & 0xff00) >> 8; /* LSB */
476 buf[3] = (devc->trigger_pattern & 0x00ff) >> 0; /* MSB */
477 buf[4] = (devc->trigger_mask & 0xff00) >> 8; /* LSB */
478 buf[5] = (devc->trigger_mask & 0x00ff) >> 0; /* MSB */
479 buf[6] = (devc->trigger_edgemask & 0xff00) >> 8; /* LSB */
480 buf[7] = (devc->trigger_edgemask & 0x00ff) >> 0; /* MSB */
481 bytes_to_write = 8;
482 }
b908f067
UH
483
484 /* Start acquisition. */
00910580 485 bytes_written = cv_write(devc, buf, bytes_to_write);
b908f067 486
00910580
UH
487 if (bytes_written < 0 || bytes_written != bytes_to_write) {
488 sr_err("Acquisition failed to start.");
afc88319 489 return SR_ERR;
b908f067
UH
490 }
491
4afdfd46 492 sr_dbg("Hardware acquisition started successfully.");
b908f067 493
3e9b7f9c 494 devc->cb_data = cb_data;
b908f067
UH
495
496 /* Send header packet to the session bus. */
102f1239 497 std_session_send_df_header(sdi, LOG_PREFIX);
b908f067 498
b908f067 499 /* Time when we should be done (for detecting trigger timeouts). */
00910580
UH
500 devc->done = (devc->divcount + 1) * devc->prof->trigger_constant +
501 g_get_monotonic_time() + (10 * G_TIME_SPAN_SECOND);
1644fb24
BV
502 devc->block_counter = 0;
503 devc->trigger_found = 0;
b908f067 504
b172c130 505 /* Hook up a dummy handler to receive data from the device. */
102f1239 506 sr_session_source_add(sdi->session, -1, G_IO_IN, 0, receive_data, (void *)sdi);
b908f067
UH
507
508 return SR_OK;
509}
510
6078d2c9 511static int dev_acquisition_stop(struct sr_dev_inst *sdi, void *cb_data)
b908f067 512{
b908f067
UH
513 struct sr_datafeed_packet packet;
514
102f1239 515 (void)cb_data;
b908f067 516
f3a35908 517 sr_dbg("Stopping acquisition.");
102f1239 518 sr_session_source_remove(sdi->session, -1);
7021f985 519
b908f067 520 /* Send end packet to the session bus. */
f3a35908 521 sr_dbg("Sending SR_DF_END.");
b908f067 522 packet.type = SR_DF_END;
102f1239 523 sr_session_send(sdi, &packet);
b908f067
UH
524
525 return SR_OK;
526}
527
7b356712
UH
528SR_PRIV struct sr_dev_driver chronovu_la_driver_info = {
529 .name = "chronovu-la",
530 .longname = "ChronoVu LA8/LA16",
b908f067 531 .api_version = 1,
6078d2c9
UH
532 .init = init,
533 .cleanup = cleanup,
534 .scan = scan,
535 .dev_list = dev_list,
3b412e3a 536 .dev_clear = dev_clear,
035a1078
BV
537 .config_get = config_get,
538 .config_set = config_set,
a1c743fc 539 .config_list = config_list,
6078d2c9
UH
540 .dev_open = dev_open,
541 .dev_close = dev_close,
542 .dev_acquisition_start = dev_acquisition_start,
543 .dev_acquisition_stop = dev_acquisition_stop,
1644fb24 544 .priv = NULL,
b908f067 545};