summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
inline | side by side (from parent 1:
76bc28c)
Current code moves the identifier string one byte to the front to
overwrite the bit value, so 'tokens[i]' is a string to compare against
the desired value. This copying is unnecessary, just pass a properly
setup pointer.
Signed-off-by: Wolfram Sang <redacted>
/* Process next token */
continue;
} else if (strchr("01xXzZ", tokens[i][0]) != NULL) {
/* Process next token */
continue;
} else if (strchr("01xXzZ", tokens[i][0]) != NULL) {
/* A new 1-bit sample value */
bit = (tokens[i][0] == '1');
/* A new 1-bit sample value */
bit = (tokens[i][0] == '1');
sr_dbg("Identifier missing!");
break;
}
sr_dbg("Identifier missing!");
break;
}
+ identifier = tokens[i];
- for (j = 1; tokens[i][j]; j++)
- tokens[i][j - 1] = tokens[i][j];
- tokens[i][j - 1] = '\0';
+ identifier = tokens[i] + 1;
}
for (j = 0, l = inc->channels; j < inc->channelcount && l; j++, l = l->next) {
vcd_ch = l->data;
}
for (j = 0, l = inc->channels; j < inc->channelcount && l; j++, l = l->next) {
vcd_ch = l->data;
- if (g_strcmp0(tokens[i], vcd_ch->identifier) == 0) {
+ if (g_strcmp0(identifier, vcd_ch->identifier) == 0) {
/* Found our channel */
size_t byte_idx = (j / 8);
size_t bit_idx = j - 8 * byte_idx;
/* Found our channel */
size_t byte_idx = (j / 8);
size_t bit_idx = j - 8 * byte_idx;
}
}
if (j == inc->channelcount)
}
}
if (j == inc->channelcount)
- sr_dbg("Did not find channel for identifier '%s'.", tokens[i]);
+ sr_dbg("Did not find channel for identifier '%s'.", identifier);
} else {
sr_warn("Skipping unknown token '%s'.", tokens[i]);
}
} else {
sr_warn("Skipping unknown token '%s'.", tokens[i]);
}