]> sigrok.org Git - libsigrok.git/blobdiff - src/output/wav.c
output/wav: Minor code cleanup.
[libsigrok.git] / src / output / wav.c
index 61d184ccb5ce52333ce266605b7588022287f22c..679bee68b661923a44dc586a71e2abca442a2030 100644 (file)
@@ -91,28 +91,10 @@ static int init(struct sr_output *o, GHashTable *options)
        struct out_context *outc;
        struct sr_channel *ch;
        GSList *l;
-       GHashTableIter iter;
-       gpointer key, value;
 
        outc = g_malloc0(sizeof(struct out_context));
        o->priv = outc;
-
-       outc->scale = 0.0;
-       if (options) {
-               g_hash_table_iter_init(&iter, options);
-               while (g_hash_table_iter_next(&iter, &key, &value)) {
-                       if (!strcmp(key, "scale")) {
-                               if (!g_variant_is_of_type(value, G_VARIANT_TYPE_DOUBLE)) {
-                                       sr_err("Invalid type for 'scale' option.");
-                                       return SR_ERR_ARG;
-                               }
-                               outc->scale = g_variant_get_double(value);
-                       } else {
-                               sr_err("Unknown option '%s'.", key);
-                               return SR_ERR_ARG;
-                       }
-               }
-       }
+       outc->scale = g_variant_get_double(g_hash_table_lookup(options, "scale"));
 
        for (l = o->sdi->channels; l; l = l->next) {
                ch = l->data;
@@ -247,6 +229,7 @@ static int check_chanbuf_size(const struct sr_output *o)
 
        return size;
 }
+
 static int receive(const struct sr_output *o, const struct sr_datafeed_packet *packet,
                GString **out)
 {
@@ -356,13 +339,10 @@ static struct sr_option options[] = {
        { 0 }
 };
 
-static struct sr_option *get_options(gboolean cached)
+static struct sr_option *get_options(void)
 {
-       if (cached)
-               return options;
-
-       options[0].def = g_variant_new_double(0);
-       g_variant_ref_sink(options[0].def);
+       if (!options[0].def)
+               options[0].def = g_variant_ref_sink(g_variant_new_double(0.0));
 
        return options;
 }