scpi-pps: Use thread safe SCPI functions, return float not double.

[libsigrok.git] / src / hardware / scpi-pps / protocol.c

diff --git a/src/hardware/scpi-pps/protocol.c b/src/hardware/scpi-pps/protocol.c
index dcb9b7903991ace32c156ff4f73da7fca61f75a1..ecdf40e598aae48cbdd37fe41ae39553d61711c5 100644 (file)
--- a/src/hardware/scpi-pps/protocol.c
+++ b/src/hardware/scpi-pps/protocol.c
@@ -47,7 +47,7 @@ SR_PRIV int select_channel(const struct sr_dev_inst *sdi, struct sr_channel *ch)
                }
        }
 
-       if ((ret = scpi_cmd(sdi, devc->device->commands, SCPI_CMD_SELECT_CHANNEL,
+       if ((ret = sr_scpi_cmd(sdi, devc->device->commands, SCPI_CMD_SELECT_CHANNEL,
                        new_pch->hwname)) >= 0)
                devc->cur_channel = ch;
 
@@ -64,9 +64,12 @@ SR_PRIV int scpi_pps_receive_data(int fd, int revents, void *cb_data)
        struct sr_analog_spec spec;
        const struct sr_dev_inst *sdi;
        struct sr_channel *next_channel;
-       struct sr_scpi_dev_inst *scpi;
        struct pps_channel *pch;
+       const struct channel_spec *ch_spec;
+       int ret;
        float f;
+       GVariant *gvdata;
+       const GVariantType *gvtype;
        int cmd;
 
        (void)fd;
@@ -78,28 +81,55 @@ SR_PRIV int scpi_pps_receive_data(int fd, int revents, void *cb_data)
        if (!(devc = sdi->priv))
                return TRUE;
 
-       scpi = sdi->conn;
-
-       /* Retrieve requested value for this state. */
-       if (sr_scpi_get_float(scpi, NULL, &f) == SR_OK) {
-               pch = devc->cur_channel->priv;
-               packet.type = SR_DF_ANALOG;
-               packet.payload = &analog;
-               sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
-               analog.meaning->channels = g_slist_append(NULL, devc->cur_channel);
-               analog.num_samples = 1;
-               analog.meaning->mq = pch->mq;
-               if (pch->mq == SR_MQ_VOLTAGE)
-                       analog.meaning->unit = SR_UNIT_VOLT;
-               else if (pch->mq == SR_MQ_CURRENT)
-                       analog.meaning->unit = SR_UNIT_AMPERE;
-               else if (pch->mq == SR_MQ_POWER)
-                       analog.meaning->unit = SR_UNIT_WATT;
-               analog.meaning->mqflags = SR_MQFLAG_DC;
-               analog.data = &f;
-               sr_session_send(sdi, &packet);
-               g_slist_free(analog.meaning->channels);
+       pch = devc->cur_channel->priv;
+       if (pch->mq == SR_MQ_VOLTAGE) {
+               gvtype = G_VARIANT_TYPE_DOUBLE;
+               cmd = SCPI_CMD_GET_MEAS_VOLTAGE;
+       } else if (pch->mq == SR_MQ_FREQUENCY) {
+               gvtype = G_VARIANT_TYPE_DOUBLE;
+               cmd = SCPI_CMD_GET_MEAS_FREQUENCY;
+       } else if (pch->mq == SR_MQ_CURRENT) {
+               gvtype = G_VARIANT_TYPE_DOUBLE;
+               cmd = SCPI_CMD_GET_MEAS_CURRENT;
+       } else if (pch->mq == SR_MQ_POWER) {
+               gvtype = G_VARIANT_TYPE_DOUBLE;
+               cmd = SCPI_CMD_GET_MEAS_POWER;
+       } else {
+               return SR_ERR;
+       }
+
+       //sr_scpi_cmd(sdi, devc->device->commands, cmd, pch->hwname); <- api.c 1x called
+       //sr_scpi_cmd(sdi, devc->device->commands, cmd); <- protocol.c xx called
+       ret = sr_scpi_cmd_resp(sdi, devc->device->commands, &gvdata, gvtype, cmd);
+       if (ret != SR_OK)
+               return ret;
+
+       ch_spec = &devc->device->channels[pch->hw_output_idx];
+       packet.type = SR_DF_ANALOG;
+       packet.payload = &analog;
+       /* Note: digits/spec_digits will be overridden later. */
+       sr_analog_init(&analog, &encoding, &meaning, &spec, 0);
+       analog.meaning->channels = g_slist_append(NULL, devc->cur_channel);
+       analog.num_samples = 1;
+       analog.meaning->mq = pch->mq;
+       if (pch->mq == SR_MQ_VOLTAGE) {
+               analog.meaning->unit = SR_UNIT_VOLT;
+               analog.encoding->digits = ch_spec->voltage[4];
+               analog.spec->spec_digits = ch_spec->voltage[3];
+       } else if (pch->mq == SR_MQ_CURRENT) {
+               analog.meaning->unit = SR_UNIT_AMPERE;
+               analog.encoding->digits = ch_spec->current[4];
+               analog.spec->spec_digits = ch_spec->current[3];
+       } else if (pch->mq == SR_MQ_POWER) {
+               analog.meaning->unit = SR_UNIT_WATT;
+               analog.encoding->digits = ch_spec->power[4];
+               analog.spec->spec_digits = ch_spec->power[3];
        }
+       analog.meaning->mqflags = SR_MQFLAG_DC;
+       f = (float)g_variant_get_double(gvdata);
+       analog.data = &f;
+       sr_session_send(sdi, &packet);
+       g_slist_free(analog.meaning->channels);
 
        if (g_slist_length(sdi->channels) > 1) {
                next_channel = sr_next_enabled_channel(sdi, devc->cur_channel);
@@ -109,18 +139,5 @@ SR_PRIV int scpi_pps_receive_data(int fd, int revents, void *cb_data)
                }
        }
 
-       pch = devc->cur_channel->priv;
-       if (pch->mq == SR_MQ_VOLTAGE)
-               cmd = SCPI_CMD_GET_MEAS_VOLTAGE;
-       else if (pch->mq == SR_MQ_FREQUENCY)
-               cmd = SCPI_CMD_GET_MEAS_FREQUENCY;
-       else if (pch->mq == SR_MQ_CURRENT)
-               cmd = SCPI_CMD_GET_MEAS_CURRENT;
-       else if (pch->mq == SR_MQ_POWER)
-               cmd = SCPI_CMD_GET_MEAS_POWER;
-       else
-               return SR_ERR;
-       scpi_cmd(sdi, devc->device->commands, cmd);
-
        return TRUE;
 }