]> sigrok.org Git - libsigrok.git/blobdiff - src/hardware/rigol-ds/protocol.c
rigol-ds: Improve short block handling
[libsigrok.git] / src / hardware / rigol-ds / protocol.c
index 6d8abc1ee3a4f521a917fdfe6ee206c85f482ade..fbbd03209cc1162e56464258707b269ca9ee2202 100644 (file)
@@ -338,12 +338,17 @@ SR_PRIV int rigol_ds_capture_start(const struct sr_dev_inst *sdi)
        if (!(devc = sdi->priv))
                return SR_ERR;
 
-       if (devc->limit_frames == 0)
+       const gboolean first_frame = (devc->num_frames == 0);
+
+       uint64_t limit_frames = devc->limit_frames;
+       if (devc->num_frames_segmented != 0 && devc->num_frames_segmented < limit_frames)
+               limit_frames = devc->num_frames_segmented;
+       if (limit_frames == 0)
                sr_dbg("Starting data capture for frameset %" PRIu64,
                       devc->num_frames + 1);
        else
                sr_dbg("Starting data capture for frameset %" PRIu64 " of %"
-                      PRIu64, devc->num_frames + 1, devc->limit_frames);
+                      PRIu64, devc->num_frames + 1, limit_frames);
 
        switch (devc->model->series->protocol) {
        case PROTOCOL_V1:
@@ -371,17 +376,17 @@ SR_PRIV int rigol_ds_capture_start(const struct sr_dev_inst *sdi)
        case PROTOCOL_V3:
        case PROTOCOL_V4:
        case PROTOCOL_V5:
-               if (rigol_ds_config_set(sdi, ":WAV:FORM BYTE") != SR_OK)
+               if (first_frame && rigol_ds_config_set(sdi, ":WAV:FORM BYTE") != SR_OK)
                        return SR_ERR;
                if (devc->data_source == DATA_SOURCE_LIVE) {
-                       if (rigol_ds_config_set(sdi, ":WAV:MODE NORM") != SR_OK)
+                       if (first_frame && rigol_ds_config_set(sdi, ":WAV:MODE NORM") != SR_OK)
                                return SR_ERR;
                        devc->analog_frame_size = devc->model->series->live_samples;
                        devc->digital_frame_size = devc->model->series->live_samples;
                        rigol_ds_set_wait_event(devc, WAIT_TRIGGER);
                } else {
                        if (devc->model->series->protocol == PROTOCOL_V3) {
-                               if (rigol_ds_config_set(sdi, ":WAV:MODE RAW") != SR_OK)
+                               if (first_frame && rigol_ds_config_set(sdi, ":WAV:MODE RAW") != SR_OK)
                                        return SR_ERR;
                        } else if (devc->model->series->protocol >= PROTOCOL_V4) {
                                num_channels = 0;
@@ -401,7 +406,7 @@ SR_PRIV int rigol_ds_capture_start(const struct sr_dev_inst *sdi)
                                }
 
                                buffer_samples = devc->model->series->buffer_samples;
-                               if (buffer_samples == 0)
+                               if (first_frame && buffer_samples == 0)
                                {
                                        /* The DS4000 series does not have a fixed memory depth, it
                                         * can be chosen from the menu and also varies with number
@@ -411,7 +416,7 @@ SR_PRIV int rigol_ds_capture_start(const struct sr_dev_inst *sdi)
                                        devc->analog_frame_size = devc->digital_frame_size =
                                                        buffer_samples;
                                }
-                               else
+                               else if (first_frame)
                                {
                                        /* The DS1000Z series has a fixed memory depth which we
                                         * need to divide correctly according to the number of
@@ -425,9 +430,13 @@ SR_PRIV int rigol_ds_capture_start(const struct sr_dev_inst *sdi)
                                }
                        }
 
-                       if (rigol_ds_config_set(sdi, ":SING") != SR_OK)
+                       if (devc->data_source == DATA_SOURCE_LIVE && rigol_ds_config_set(sdi, ":SINGL") != SR_OK)
                                return SR_ERR;
                        rigol_ds_set_wait_event(devc, WAIT_STOP);
+                       if (devc->data_source == DATA_SOURCE_SEGMENTED &&
+                                       devc->model->series->protocol <= PROTOCOL_V4)
+                               if (rigol_ds_config_set(sdi, "FUNC:WREP:FCUR %d", devc->num_frames + 1) != SR_OK)
+                                       return SR_ERR;
                }
                break;
        }
@@ -448,6 +457,8 @@ SR_PRIV int rigol_ds_channel_start(const struct sr_dev_inst *sdi)
 
        sr_dbg("Starting reading data from channel %d", ch->index + 1);
 
+       const gboolean first_frame = (devc->num_frames == 0);
+
        switch (devc->model->series->protocol) {
        case PROTOCOL_V1:
        case PROTOCOL_V2:
@@ -489,25 +500,30 @@ SR_PRIV int rigol_ds_channel_start(const struct sr_dev_inst *sdi)
                                return SR_ERR;
                }
 
-               if (rigol_ds_config_set(sdi,
+               if (first_frame && rigol_ds_config_set(sdi,
                                        devc->data_source == DATA_SOURCE_LIVE ?
                                                ":WAV:MODE NORM" :":WAV:MODE RAW") != SR_OK)
                        return SR_ERR;
+
+               if (devc->data_source != DATA_SOURCE_LIVE) {
+                       if (rigol_ds_config_set(sdi, ":WAV:RES") != SR_OK)
+                               return SR_ERR;
+               }
                break;
        }
 
        if (devc->model->series->protocol >= PROTOCOL_V3 &&
                        ch->type == SR_CHANNEL_ANALOG) {
                /* Vertical increment. */
-               if (sr_scpi_get_float(sdi->conn, ":WAV:YINC?",
+               if (first_frame && sr_scpi_get_float(sdi->conn, ":WAV:YINC?",
                                &devc->vert_inc[ch->index]) != SR_OK)
                        return SR_ERR;
                /* Vertical origin. */
-               if (sr_scpi_get_float(sdi->conn, ":WAV:YOR?",
+               if (first_frame && sr_scpi_get_float(sdi->conn, ":WAV:YOR?",
                        &devc->vert_origin[ch->index]) != SR_OK)
                        return SR_ERR;
                /* Vertical reference. */
-               if (sr_scpi_get_int(sdi->conn, ":WAV:YREF?",
+               if (first_frame && sr_scpi_get_int(sdi->conn, ":WAV:YREF?",
                                &devc->vert_reference[ch->index]) != SR_OK)
                        return SR_ERR;
        } else if (ch->type == SR_CHANNEL_ANALOG) {
@@ -609,6 +625,8 @@ SR_PRIV int rigol_ds_receive(int fd, int revents, void *cb_data)
        if (!(revents == G_IO_IN || revents == 0))
                return TRUE;
 
+       const gboolean first_frame = (devc->num_frames == 0);
+
        switch (devc->wait_event) {
        case WAIT_NONE:
                break;
@@ -642,18 +660,21 @@ SR_PRIV int rigol_ds_receive(int fd, int revents, void *cb_data)
 
        if (devc->num_block_bytes == 0) {
                if (devc->model->series->protocol >= PROTOCOL_V4) {
-                       if (rigol_ds_config_set(sdi, ":WAV:START %d",
+                       if (first_frame && rigol_ds_config_set(sdi, ":WAV:START %d",
                                        devc->num_channel_bytes + 1) != SR_OK)
                                return TRUE;
-                       if (rigol_ds_config_set(sdi, ":WAV:STOP %d",
+                       if (first_frame && rigol_ds_config_set(sdi, ":WAV:STOP %d",
                                        MIN(devc->num_channel_bytes + ACQ_BLOCK_SIZE,
                                                devc->analog_frame_size)) != SR_OK)
                                return TRUE;
                }
 
-               if (devc->model->series->protocol >= PROTOCOL_V3)
+               if (devc->model->series->protocol >= PROTOCOL_V3) {
+                       if (rigol_ds_config_set(sdi, ":WAV:BEG") != SR_OK)
+                               return TRUE;
                        if (sr_scpi_send(sdi->conn, ":WAV:DATA?") != SR_OK)
                                return TRUE;
+               }
 
                if (sr_scpi_read_begin(scpi) != SR_OK)
                        return TRUE;
@@ -670,16 +691,17 @@ SR_PRIV int rigol_ds_receive(int fd, int revents, void *cb_data)
                                sr_dev_acquisition_stop(sdi);
                                return TRUE;
                        }
-                       /* At slow timebases in live capture the DS2072
-                        * sometimes returns "short" data blocks, with
+                       /* At slow timebases in live capture the DS2072 and
+                        * DS1054Z sometimes return "short" data blocks, with
                         * apparently no way to get the rest of the data.
-                        * Discard these, the complete data block will
-                        * appear eventually.
+                        * Discard these, the complete data block will appear
+                        * eventually.
                         */
                        if (devc->data_source == DATA_SOURCE_LIVE
                                        && (unsigned)len < expected_data_bytes) {
-                               sr_dbg("Discarding short data block");
+                               sr_dbg("Discarding short data block: got %d/%d bytes\n", len, (int)expected_data_bytes);
                                sr_scpi_read_data(scpi, (char *)devc->buffer, len + 1);
+                               devc->num_header_bytes = 0;
                                return TRUE;
                        }
                        devc->num_block_bytes = len;
@@ -791,7 +813,24 @@ SR_PRIV int rigol_ds_receive(int fd, int revents, void *cb_data)
                /* Done with this frame. */
                std_session_send_df_frame_end(sdi);
 
-               if (++devc->num_frames == devc->limit_frames || devc->data_source == DATA_SOURCE_MEMORY) {
+               devc->num_frames++;
+
+               /* V5 has no way to read the number of recorded frames, so try to set the
+                * next frame and read it back instead.
+                */
+               if (devc->data_source == DATA_SOURCE_SEGMENTED &&
+                               devc->model->series->protocol == PROTOCOL_V5) {
+                       int frames = 0;
+                       if (rigol_ds_config_set(sdi, "REC:CURR %d", devc->num_frames + 1) != SR_OK)
+                               return SR_ERR;
+                       if (sr_scpi_get_int(sdi->conn, "REC:CURR?", &frames) != SR_OK)
+                               return SR_ERR;
+                       devc->num_frames_segmented = frames;
+               }
+
+               if (devc->num_frames == devc->limit_frames ||
+                               devc->num_frames == devc->num_frames_segmented ||
+                               devc->data_source == DATA_SOURCE_MEMORY) {
                        /* Last frame, stop capture. */
                        sr_dev_acquisition_stop(sdi);
                } else {