]> sigrok.org Git - libsigrok.git/blobdiff - src/hardware/ipdbg-la/api.c
ipdbg-la: Fix two compiler warnings on Windows.
[libsigrok.git] / src / hardware / ipdbg-la / api.c
index 6a8f261b6769f2d881a054af1374b1ec1649feb9..59f3f56e955d1313f8538605ee3b8955859c8d24 100644 (file)
@@ -97,11 +97,6 @@ static GSList *scan(struct sr_dev_driver *di, GSList *options)
                return NULL;
 
        struct sr_dev_inst *sdi = g_malloc0(sizeof(struct sr_dev_inst));
-       if (!sdi) {
-               sr_err("no possible to allocate sr_dev_inst");
-               return NULL;
-       }
-
        sdi->status = SR_ST_INACTIVE;
        sdi->vendor = g_strdup("ipdbg.org");
        sdi->model = g_strdup("IPDBG LA");
@@ -113,15 +108,14 @@ static GSList *scan(struct sr_dev_driver *di, GSList *options)
 
        ipdbg_la_get_addrwidth_and_datawidth(tcp, devc);
 
-       sr_dbg("addr_width = %d, data_width = %d\n", devc->ADDR_WIDTH,
-               devc->DATA_WIDTH);
+       sr_dbg("addr_width = %d, data_width = %d\n", devc->addr_width,
+               devc->data_width);
        sr_dbg("limit samples = %" PRIu64 "\n", devc->limit_samples_max);
 
-       for (uint32_t i = 0; i < devc->DATA_WIDTH; i++) {
-               const uint8_t buf_size = 16;
-               char buf[buf_size];
-               snprintf(buf, buf_size, "ch%d", i);
-               sr_channel_new(sdi, i, SR_CHANNEL_LOGIC, TRUE, buf);
+       for (uint32_t i = 0; i < devc->data_width; i++) {
+               char *name = g_strdup_printf("CH%d", i);
+               sr_channel_new(sdi, i, SR_CHANNEL_LOGIC, TRUE, name);
+               g_free(name);
        }
 
        sdi->inst_type = SR_INST_USER;
@@ -241,16 +235,6 @@ static int config_list(uint32_t key, GVariant **data,
        return SR_OK;
 }
 
-static int init(struct sr_dev_driver *di, struct sr_context *sr_ctx)
-{
-       return std_init(di, sr_ctx);
-}
-
-static GSList *dev_list(const struct sr_dev_driver *di)
-{
-       return ((struct drv_context *)(di->context))->instances;
-}
-
 static int dev_acquisition_start(const struct sr_dev_inst *sdi)
 {
        struct ipdbg_la_tcp *tcp = sdi->conn;
@@ -280,7 +264,7 @@ static int dev_acquisition_stop(struct sr_dev_inst *sdi)
 
        if (devc->num_transfers > 0) {
                while (devc->num_transfers <
-                       (devc->limit_samples_max * devc->DATA_WIDTH_BYTES)) {
+                       (devc->limit_samples_max * devc->data_width_bytes)) {
                        ipdbg_la_tcp_receive(tcp, &byte);
                        devc->num_transfers++;
                }
@@ -296,10 +280,10 @@ SR_PRIV struct sr_dev_driver ipdbg_la_driver_info = {
        .name = "ipdbg-la",
        .longname = "IPDBG LA",
        .api_version = 1,
-       .init = init,
+       .init = std_init,
        .cleanup = std_cleanup,
        .scan = scan,
-       .dev_list = dev_list,
+       .dev_list = std_dev_list,
        .dev_clear = dev_clear,
        .config_get = config_get,
        .config_set = config_set,