/*
* Check device by its physical USB bus/port address.
*/
- usb_get_port_path(devlist[i], connection_id, sizeof(connection_id));
+ if (usb_get_port_path(devlist[i], connection_id, sizeof(connection_id)) < 0)
+ continue;
+
if (strcmp(sdi->connection_id, connection_id))
/* This is not the one. */
continue;
libusb_close(usb->devhdl);
usb->devhdl = NULL;
sdi->status = SR_ST_INACTIVE;
-
}
static int get_channel_offsets(const struct sr_dev_inst *sdi)
return SR_OK;
}
-
static void dso2250_set_triggerpos(int value, int long_buffer, uint8_t dest[], int offset)
{
uint32_t min, max;
dest[offset + 2] = (tmp >> 16) & 0x7;
}
-
/* See http://openhantek.sourceforge.net/doc/namespaceHantek.html#ac1cd181814cf3da74771c29800b39028 */
static int dso2250_set_trigger_samplerate(const struct sr_dev_inst *sdi)
{
struct dev_context *devc;
struct sr_usb_dev_inst *usb;
int ret, tmp;
- int base;
+ uint64_t base;
uint8_t cmdstring[12];
int trig;
-
devc = sdi->priv;
usb = sdi->conn;
}
cmdstring[2] = tmp;
-
sr_dbg("Trigger slope: %d.", devc->triggerslope);
cmdstring[2] |= (devc->triggerslope == SLOPE_NEGATIVE ? 1 : 0) << 3;
return SR_ERR;
}
-
/* Frame size */
sr_dbg("Frame size: %d.", devc->framesize);
cmdstring[0] = CMD_2250_SET_RECORD_LENGTH;
- cmdstring[2] = devc->framesize == FRAMESIZE_SMALL ? 0x01 : 0x02;
+ cmdstring[2] = (devc->framesize == FRAMESIZE_SMALL) ? 0x01 : 0x02;
if (send_begin(sdi) != SR_OK)
return SR_ERR;
return SR_ERR;
}
-
memset(cmdstring, 0, sizeof(cmdstring));
cmdstring[0] = CMD_2250_SET_SAMPLERATE;
- sr_dbg("Sample rate: %u", devc->samplerate);
base = 100e6;
if (devc->samplerate > base) {
/* Timebase fast */
}
tmp = base / devc->samplerate;
- sr_dbg("sample rate value: %d.", devc->samplerate);
- if (tmp) {
+ /* Downsample only if really necessary */
+ if (tmp > 1) {
/* Downsampling on */
cmdstring[2] |= 2;
/* Downsampler = 1comp((Base / Samplerate) - 2)
* 1comp(198) => ff39 */
tmp -= 2;
tmp = ~tmp;
- sr_dbg("down sampler value: 0x%x.", tmp & 0xffff);
+ sr_dbg("Down sampler value: 0x%x.", tmp & 0xffff);
cmdstring[4] = (tmp >> 0) & 0xff;
cmdstring[5] = (tmp >> 8) & 0xff;
}
}
sr_dbg("Sent CMD_2250_SET_SAMPLERATE.");
-
- /* Enabled channels: 00=CH1 01=CH2 10=both */
+ /* Enabled channels: 00=CH1, 01=CH2, 10=both. */
memset(cmdstring, 0, sizeof(cmdstring));
cmdstring[0] = CMD_2250_SET_CHANNELS;
- sr_dbg("Channels CH1=%d CH2=%d", devc->ch_enabled[0], devc->ch_enabled[1]);
+ sr_dbg("Channels: CH1=%d, CH2=%d.", devc->ch_enabled[0], devc->ch_enabled[1]);
cmdstring[2] = (devc->ch_enabled[0] ? 0 : 1) + (devc->ch_enabled[1] ? 2 : 0);
if (send_begin(sdi) != SR_OK)
}
sr_dbg("Sent CMD_2250_SET_CHANNELS.");
-
-
- /* Trigger slope: 0=positive 1=negative */
+ /* Trigger slope: 0=positive, 1=negative. */
memset(cmdstring, 0, sizeof(cmdstring));
cmdstring[0] = CMD_2250_SET_TRIGGERPOS_AND_BUFFER;
- sr_dbg("Capture ratio: %d.", devc->capture_ratio);
+ sr_dbg("Capture ratio: %" PRIu64 ".", devc->capture_ratio);
trig = devc->capture_ratio;
dso2250_set_triggerpos(trig,
devc->framesize != FRAMESIZE_SMALL, cmdstring, 2);
return SR_OK;
}
-int dso_set_trigger_samplerate(const struct sr_dev_inst *sdi)
+SR_PRIV int dso_set_trigger_samplerate(const struct sr_dev_inst *sdi)
{
struct dev_context *devc;
struct sr_usb_dev_inst *usb;
cmdstring[5] = (tmp >> 8) & 0xff;
/* Horizontal trigger position */
- sr_dbg("Capture ratio: %d.", devc->capture_ratio);
+ sr_dbg("Capture ratio: %" PRIu64 ".", devc->capture_ratio);
tmp = 0x77fff + 0x8000 * devc->capture_ratio / 100;
cmdstring[6] = tmp & 0xff;
cmdstring[7] = (tmp >> 8) & 0xff;
return SR_OK;
}
-
static int dso_set_filters(const struct sr_dev_inst *sdi)
{
struct dev_context *devc;
cmdstring[0] = CMD_SET_VOLTAGE;
if (devc->profile->fw_pid == 0x2250) {
+ cmdstring[1] = 0x00;
cmdstring[2] = 0x08;
} else {
cmdstring[1] = 0x0f;
cmdstring[2] = 0x30;
}
- /* CH1 volts/div is encoded in bits 0-1 */
+ /* CH1 volts/div is encoded in bits 0-1. */
sr_dbg("CH1 vdiv index: %d.", devc->voltage[0]);
switch (devc->voltage[0]) {
case VDIV_1V:
break;
}
- /* CH2 volts/div is encoded in bits 2-3 */
+ /* CH2 volts/div is encoded in bits 2-3. */
sr_dbg("CH2 vdiv index: %d.", devc->voltage[1]);
switch (devc->voltage[1]) {
case VDIV_1V:
return SR_OK;
}
-static int dso_set_voffsets(const struct sr_dev_inst *sdi)
+SR_PRIV int dso_set_voffsets(const struct sr_dev_inst *sdi)
{
struct dev_context *devc;
struct sr_usb_dev_inst *usb;
SR_PRIV int dso_init(const struct sr_dev_inst *sdi)
{
-
sr_dbg("Initializing DSO.");
if (get_channel_offsets(sdi) != SR_OK)