fix corner cases/memory management (cli->text out)

[libsigrok.git] / output / output_text.c

diff --git a/output/output_text.c b/output/output_text.c
index 05a368f056d4b0a6718fdb8a1e3ed0b290dd898e..f6d9357a7902ce68d84d60076721d50276c06e9c 100644 (file)
--- a/output/output_text.c
+++ b/output/output_text.c
@@ -22,6 +22,7 @@
 #include <string.h>
 #include <glib.h>
 #include <sigrok.h>
+#include "config.h"
 
 #define DEFAULT_BPL_BITS 64
 #define DEFAULT_BPL_HEX  256
@@ -62,7 +63,7 @@ static void flush_linebufs(struct context *ctx, char *outbuf)
                        ctx->probelist[i], ctx->linebuf + i * ctx->linebuf_len);
        }
 
-       /* Mark trigger with ^ */
+       /* Mark trigger with a ^ character. */
        if (ctx->mark_trigger != -1)
                sprintf(outbuf + strlen(outbuf), "T:%*s^\n",
                        ctx->mark_trigger + (ctx->mark_trigger / 8), "");
@@ -79,7 +80,9 @@ static int init(struct output *o, int default_spl)
        int num_probes;
        char *samplerate_s;
 
-       ctx = malloc(sizeof(struct context));
+       if (!(ctx = calloc(1, sizeof(struct context))))
+               return SIGROK_ERR_MALLOC;
+
        o->internal = ctx;
        ctx->num_enabled_probes = 0;
 
@@ -95,36 +98,48 @@ static int init(struct output *o, int default_spl)
        ctx->spl_cnt = 0;
        ctx->mark_trigger = -1;
 
-       if (o->param && o->param[0])
+       if (o->param && o->param[0]) {
                ctx->samples_per_line = strtoul(o->param, NULL, 10);
-       else
+               if (ctx->samples_per_line < 1)
+                       return SIGROK_ERR;
+       } else
                ctx->samples_per_line = default_spl;
 
+       if (!(ctx->header = malloc(512))) {
+               free(ctx);
+               return SIGROK_ERR_MALLOC;
+       }
+
+       snprintf(ctx->header, 511, "%s\n", PACKAGE_STRING);
        if (o->device->plugin) {
-               ctx->header = malloc(512);
                num_probes = g_slist_length(o->device->probes);
                samplerate = *((uint64_t *) o->device->plugin->get_device_info(
                                o->device->plugin_index, DI_CUR_SAMPLERATE));
-               snprintf(ctx->header, 512, "Acquisition with %d/%d probes at ",
-                        ctx->num_enabled_probes, num_probes);
-
-               if ((samplerate_s = sigrok_samplerate_string(samplerate)) == NULL)
-                       return -1; /* FIXME */
-               snprintf(ctx->header + strlen(ctx->header), 512, "%s\n", samplerate_s);
+               if (!(samplerate_s = sigrok_samplerate_string(samplerate))) {
+                       free(ctx->header);
+                       free(ctx);
+                       return SIGROK_ERR;
+               }
+               snprintf(ctx->header + strlen(ctx->header),
+                        511 - strlen(ctx->header),
+                        "Acquisition with %d/%d probes at %s\n",
+                        ctx->num_enabled_probes, num_probes, samplerate_s);
                free(samplerate_s);
-       } else {
-               /*
-                * device has no plugin: this is just a dummy device, the data
-                * comes from a file.
-                */
-               ctx->header = NULL;
        }
 
-       ctx->linebuf_len = ctx->samples_per_line * 2;
-       ctx->linebuf = calloc(1, num_probes * ctx->linebuf_len);
-       ctx->linevalues = calloc(1, num_probes);
+       ctx->linebuf_len = ctx->samples_per_line * 2 + 4;
+       if (!(ctx->linebuf = calloc(1, num_probes * ctx->linebuf_len))) {
+               free(ctx->header);
+               free(ctx);
+               return SIGROK_ERR_MALLOC;
+       }
+       if (!(ctx->linevalues = calloc(1, num_probes))) {
+               free(ctx->header);
+               free(ctx);
+               return SIGROK_ERR_MALLOC;
+       }
 
-       return 0;
+       return SIGROK_OK;
 }
 
 static int event(struct output *o, int event_type, char **data_out,
@@ -142,7 +157,8 @@ static int event(struct output *o, int event_type, char **data_out,
        case DF_END:
                outsize = ctx->num_enabled_probes
                                * (ctx->samples_per_line + 20) + 512;
-               outbuf = calloc(1, outsize);
+               if (!(outbuf = calloc(1, outsize)))
+                       return SIGROK_ERR_MALLOC;
                flush_linebufs(ctx, outbuf);
                *data_out = outbuf;
                *length_out = strlen(outbuf);
@@ -169,15 +185,18 @@ static int data_bits(struct output *o, char *data_in, uint64_t length_in,
 
        ctx = o->internal;
        outsize = length_in / ctx->unitsize * ctx->num_enabled_probes *
-                 ctx->samples_per_line + 512;
-       outbuf = calloc(1, outsize + 1);
+                 ctx->samples_per_line + 4096;
+
+       if (!(outbuf = calloc(1, outsize + 1)))
+               return SIGROK_ERR_MALLOC;
+
+       outbuf[0] = '\0';
        if (ctx->header) {
                /* The header is still here, this must be the first packet. */
                strncpy(outbuf, ctx->header, outsize);
                free(ctx->header);
                ctx->header = NULL;
-       } else
-               outbuf[0] = 0;
+       }
 
        if (length_in >= ctx->unitsize) {
                for (offset = 0; offset <= length_in - ctx->unitsize;
@@ -209,8 +228,9 @@ static int data_bits(struct output *o, char *data_in, uint64_t length_in,
                                ctx->mark_trigger = -1;
                        }
                }
-       } else
+       } else {
                g_message("short buffer (length_in=%" PRIu64 ")", length_in);
+       }
 
        *data_out = outbuf;
        *length_out = strlen(outbuf);
@@ -233,15 +253,18 @@ static int data_hex(struct output *o, char *data_in, uint64_t length_in,
 
        ctx = o->internal;
        outsize = length_in / ctx->unitsize * ctx->num_enabled_probes *
-                 ctx->samples_per_line + 512;
-       outbuf = calloc(1, outsize + 1);
+                 ctx->samples_per_line + 4096;
+
+       if (!(outbuf = calloc(1, outsize + 1)))
+               return SIGROK_ERR_MALLOC;
+
+       outbuf[0] = '\0';
        if (ctx->header) {
                /* The header is still here, this must be the first packet. */
                strncpy(outbuf, ctx->header, outsize);
                free(ctx->header);
                ctx->header = NULL;
-       } else
-               outbuf[0] = 0;
+       }
 
        ctx->line_offset = 0;
        for (offset = 0; offset <= length_in - ctx->unitsize;