probe names: Fix cosmetics, add docs, fix off-by-one.

[libsigrok.git] / input / input_binary.c

diff --git a/input/input_binary.c b/input/input_binary.c
index fd23bfc1b3898cd71d4dc5be2db35afa47b4de2f..b83ea6f5ea58ed46aad482c19031f2b47fe94416 100644 (file)
--- a/input/input_binary.c
+++ b/input/input_binary.c
@@ -40,22 +40,23 @@ static int format_match(const char *filename)
 static int init(struct sr_input *in)
 {
        int num_probes, i;
-       char name[SR_MAX_PROBENAME_LEN];
+       char name[SR_MAX_PROBENAME_LEN + 1];
 
        if (in->param && in->param[0]) {
                num_probes = strtoul(in->param, NULL, 10);
                if (num_probes < 1)
                        return SR_ERR;
-       } else
+       } else {
                num_probes = DEFAULT_NUM_PROBES;
+       }
 
-       /* create a virtual device */
+       /* Create a virtual device. */
        in->vdevice = sr_device_new(NULL, 0);
 
-       for (i = 0; i < num_probes; i++)
-       {
+       for (i = 0; i < num_probes; i++) {
                snprintf(name, SR_MAX_PROBENAME_LEN, "%d", i);
-               sr_device_probe_add(in->vdevice, name); /* TODO: Check return value. */
+               /* TODO: Check return value. */
+               sr_device_probe_add(in->vdevice, name);
        }
 
        return SR_OK;