]> sigrok.org Git - libsigrok.git/blobdiff - hardware/zeroplus-logic-cube/zeroplus.c
sr/drivers: change driver dev_acquisition_start/_stop calls to use sdi
[libsigrok.git] / hardware / zeroplus-logic-cube / zeroplus.c
index 97378d5486c219f8b0476d95109c92f93dd6c421..f889362c49de206104c513007e663ed2d59bb598 100644 (file)
@@ -159,7 +159,9 @@ struct context {
        struct sr_usb_dev_inst *usb;
 };
 
-static int hw_dev_config_set(int dev_index, int hwcap, const void *value);
+static int hw_dev_config_set(const struct sr_dev_inst *sdi, int hwcap,
+               const void *value);
+static int hw_dev_close(struct sr_dev_inst *sdi);
 
 static unsigned int get_memory_size(int type)
 {
@@ -262,29 +264,7 @@ static struct sr_dev_inst *zp_open_dev(int dev_index)
        return sdi;
 }
 
-static void close_dev(struct sr_dev_inst *sdi)
-{
-       struct context *ctx;
-
-       if (!(ctx = sdi->priv)) {
-               sr_err("zp: %s: sdi->priv was NULL", __func__);
-               return; /* FIXME */
-       }
-
-       if (!ctx->usb->devhdl)
-               return;
-
-       sr_info("zp: closing device %d on %d.%d interface %d", sdi->index,
-               ctx->usb->bus, ctx->usb->address, USB_INTERFACE);
-       libusb_release_interface(ctx->usb->devhdl, USB_INTERFACE);
-       libusb_reset_device(ctx->usb->devhdl);
-       libusb_close(ctx->usb->devhdl);
-       ctx->usb->devhdl = NULL;
-       /* TODO: Call libusb_exit() here or only in hw_cleanup()? */
-       sdi->status = SR_ST_INACTIVE;
-}
-
-static int configure_probes(struct sr_dev_inst *sdi, const GSList *probes)
+static int configure_probes(const struct sr_dev_inst *sdi, const GSList *probes)
 {
        struct context *ctx;
        const struct sr_probe *probe;
@@ -333,7 +313,7 @@ static void clear_instances(void)
        for (l = zdi->instances; l; l = l->next) {
                sdi = l->data;
                /* Properly close all devices... */
-               close_dev(sdi);
+               hw_dev_close(sdi);
                /* ...and free all their memory. */
                sr_dev_inst_free(sdi);
        }
@@ -413,7 +393,7 @@ static GSList *hw_scan(GSList *options)
                                       __func__);
                                return 0;
                        }
-
+                       sdi->driver = zdi;
                        sdi->priv = ctx;
 
                        devices = g_slist_append(devices, sdi);
@@ -429,19 +409,11 @@ static GSList *hw_scan(GSList *options)
        return devices;
 }
 
-static int hw_dev_open(int dev_index)
+static int hw_dev_open(struct sr_dev_inst *sdi)
 {
-       struct sr_dev_inst *sdi;
        struct context *ctx;
        int ret;
 
-       if (!(sdi = zp_open_dev(dev_index))) {
-               sr_err("zp: unable to open device");
-               return SR_ERR;
-       }
-
-       /* TODO: Note: sdi is retrieved in zp_open_dev(). */
-
        if (!(ctx = sdi->priv)) {
                sr_err("zp: %s: sdi->priv was NULL", __func__);
                return SR_ERR_ARG;
@@ -482,7 +454,7 @@ static int hw_dev_open(int dev_index)
 
        if (ctx->cur_samplerate == 0) {
                /* Samplerate hasn't been set. Default to the slowest one. */
-               if (hw_dev_config_set(dev_index, SR_HWCAP_SAMPLERATE,
+               if (hw_dev_config_set(sdi, SR_HWCAP_SAMPLERATE,
                     &samplerates.list[0]) == SR_ERR)
                        return SR_ERR;
        }
@@ -490,17 +462,25 @@ static int hw_dev_open(int dev_index)
        return SR_OK;
 }
 
-static int hw_dev_close(int dev_index)
+static int hw_dev_close(struct sr_dev_inst *sdi)
 {
-       struct sr_dev_inst *sdi;
+       struct context *ctx;
 
-       if (!(sdi = sr_dev_inst_get(zdi->instances, dev_index))) {
-               sr_err("zp: %s: sdi was NULL", __func__);
-               return SR_ERR; /* TODO: SR_ERR_ARG? */
+       if (!(ctx = sdi->priv)) {
+               sr_err("zp: %s: sdi->priv was NULL", __func__);
+               return SR_ERR;
        }
 
-       /* TODO */
-       close_dev(sdi);
+       if (!ctx->usb->devhdl)
+               return SR_ERR;
+
+       sr_info("zp: closing device %d on %d.%d interface %d", sdi->index,
+               ctx->usb->bus, ctx->usb->address, USB_INTERFACE);
+       libusb_release_interface(ctx->usb->devhdl, USB_INTERFACE);
+       libusb_reset_device(ctx->usb->devhdl);
+       libusb_close(ctx->usb->devhdl);
+       ctx->usb->devhdl = NULL;
+       sdi->status = SR_ST_INACTIVE;
 
        return SR_OK;
 }
@@ -517,60 +497,54 @@ static int hw_cleanup(void)
        return SR_OK;
 }
 
-static const void *hw_dev_info_get(int dev_index, int dev_info_id)
+static int hw_info_get(int info_id, const void **data,
+       const struct sr_dev_inst *sdi)
 {
-       struct sr_dev_inst *sdi;
        struct context *ctx;
-       const void *info;
-
-       if (!(sdi = sr_dev_inst_get(zdi->instances, dev_index))) {
-               sr_err("zp: %s: sdi was NULL", __func__);
-               return NULL;
-       }
 
-       if (!(ctx = sdi->priv)) {
-               sr_err("zp: %s: sdi->priv was NULL", __func__);
-               return NULL;
-       }
-
-       sr_spew("zp: %s: dev_index %d, dev_info_id %d.", __func__,
-               dev_index, dev_info_id);
-
-       switch (dev_info_id) {
+       switch (info_id) {
        case SR_DI_INST:
-               info = sdi;
+               *data = sdi;
                sr_spew("zp: %s: Returning sdi.", __func__);
                break;
+       case SR_DI_HWCAPS:
+               *data = hwcaps;
+               break;
        case SR_DI_NUM_PROBES:
-               info = GINT_TO_POINTER(ctx->num_channels);
-               sr_spew("zp: %s: Returning number of probes: %d.", __func__,
-                       NUM_PROBES);
+               if (sdi) {
+                       ctx = sdi->priv;
+                       *data = GINT_TO_POINTER(ctx->num_channels);
+                       sr_spew("zp: %s: Returning number of channels: %d.",
+                                       __func__, ctx->num_channels);
+               } else
+                       return SR_ERR;
                break;
        case SR_DI_PROBE_NAMES:
-               info = probe_names;
+               *data = probe_names;
                sr_spew("zp: %s: Returning probenames.", __func__);
                break;
        case SR_DI_SAMPLERATES:
-               info = &samplerates;
+               *data = &samplerates;
                sr_spew("zp: %s: Returning samplerates.", __func__);
                break;
        case SR_DI_TRIGGER_TYPES:
-               info = TRIGGER_TYPES;
-               sr_spew("zp: %s: Returning triggertypes: %s.", __func__, info);
+               *data = TRIGGER_TYPES;
+               sr_spew("zp: %s: Returning triggertypes: %s.", __func__, TRIGGER_TYPES);
                break;
        case SR_DI_CUR_SAMPLERATE:
-               info = &ctx->cur_samplerate;
-               sr_spew("zp: %s: Returning samplerate: %" PRIu64 "Hz.",
-                       __func__, ctx->cur_samplerate);
+               if (sdi) {
+                       ctx = sdi->priv;
+                       *data = &ctx->cur_samplerate;
+                       sr_spew("zp: %s: Returning samplerate: %" PRIu64 "Hz.",
+                               __func__, ctx->cur_samplerate);
+               } else
+                       return SR_ERR;
                break;
        default:
-               /* Unknown device info ID, return NULL. */
-               sr_err("zp: %s: Unknown device info ID", __func__);
-               info = NULL;
-               break;
+               return SR_ERR_ARG;
        }
 
-       return info;
+       return SR_OK;
 }
 
 static int hw_dev_status_get(int dev_index)
@@ -584,12 +558,7 @@ static int hw_dev_status_get(int dev_index)
                return SR_ST_NOT_FOUND;
 }
 
-static const int *hw_hwcap_get_all(void)
-{
-       return hwcaps;
-}
-
-static int set_samplerate(struct sr_dev_inst *sdi, uint64_t samplerate)
+static int set_samplerate(const struct sr_dev_inst *sdi, uint64_t samplerate)
 {
        struct context *ctx;
 
@@ -617,16 +586,11 @@ static int set_samplerate(struct sr_dev_inst *sdi, uint64_t samplerate)
        return SR_OK;
 }
 
-static int hw_dev_config_set(int dev_index, int hwcap, const void *value)
+static int hw_dev_config_set(const struct sr_dev_inst *sdi, int hwcap,
+               const void *value)
 {
-       struct sr_dev_inst *sdi;
        struct context *ctx;
 
-       if (!(sdi = sr_dev_inst_get(zdi->instances, dev_index))) {
-               sr_err("zp: %s: sdi was NULL", __func__);
-               return SR_ERR;
-       }
-
        if (!(ctx = sdi->priv)) {
                sr_err("zp: %s: sdi->priv was NULL", __func__);
                return SR_ERR_ARG;
@@ -645,9 +609,9 @@ static int hw_dev_config_set(int dev_index, int hwcap, const void *value)
        }
 }
 
-static int hw_dev_acquisition_start(int dev_index, void *cb_data)
+static int hw_dev_acquisition_start(const struct sr_dev_inst *sdi,
+               void *cb_data)
 {
-       struct sr_dev_inst *sdi;
        struct sr_datafeed_packet packet;
        struct sr_datafeed_logic logic;
        struct sr_datafeed_header header;
@@ -658,11 +622,6 @@ static int hw_dev_acquisition_start(int dev_index, void *cb_data)
        unsigned char *buf;
        struct context *ctx;
 
-       if (!(sdi = sr_dev_inst_get(zdi->instances, dev_index))) {
-               sr_err("zp: %s: sdi was NULL", __func__);
-               return SR_ERR;
-       }
-
        if (!(ctx = sdi->priv)) {
                sr_err("zp: %s: sdi->priv was NULL", __func__);
                return SR_ERR_ARG;
@@ -727,20 +686,15 @@ static int hw_dev_acquisition_start(int dev_index, void *cb_data)
 }
 
 /* TODO: This stops acquisition on ALL devices, ignoring dev_index. */
-static int hw_dev_acquisition_stop(int dev_index, void *cb_data)
+static int hw_dev_acquisition_stop(const struct sr_dev_inst *sdi,
+               void *cb_data)
 {
        struct sr_datafeed_packet packet;
-       struct sr_dev_inst *sdi;
        struct context *ctx;
 
        packet.type = SR_DF_END;
        sr_session_send(cb_data, &packet);
 
-       if (!(sdi = sr_dev_inst_get(zdi->instances, dev_index))) {
-               sr_err("zp: %s: sdi was NULL", __func__);
-               return SR_ERR_BUG;
-       }
-
        if (!(ctx = sdi->priv)) {
                sr_err("zp: %s: sdi->priv was NULL", __func__);
                return SR_ERR_BUG;
@@ -761,9 +715,8 @@ SR_PRIV struct sr_dev_driver zeroplus_logic_cube_driver_info = {
        .scan = hw_scan,
        .dev_open = hw_dev_open,
        .dev_close = hw_dev_close,
-       .dev_info_get = hw_dev_info_get,
+       .info_get = hw_info_get,
        .dev_status_get = hw_dev_status_get,
-       .hwcap_get_all = hw_hwcap_get_all,
        .dev_config_set = hw_dev_config_set,
        .dev_acquisition_start = hw_dev_acquisition_start,
        .dev_acquisition_stop = hw_dev_acquisition_stop,