]> sigrok.org Git - libsigrok.git/blobdiff - hardware/saleae-logic/saleae-logic.c
Whitespace and consistency fixes.
[libsigrok.git] / hardware / saleae-logic / saleae-logic.c
index 423e1d3441cf114ee21e8f5d04b235ef447a1de8..ba50ee94ea3ea6af15b47360d9cf2588eaf58ec7 100644 (file)
 #include <sigrok.h>
 #include "config.h"
 
-#define USB_VENDOR                     0x0925
+#define USB_VENDOR                 0x0925
 #define USB_PRODUCT                    0x3881
-#define USB_VENDOR_NAME                        "Saleae"
-#define USB_MODEL_NAME                 "Logic"
-#define USB_MODEL_VERSION              ""
+#define USB_VENDOR_NAME        "Saleae"
+#define USB_MODEL_NAME         "Logic"
+#define USB_MODEL_VERSION      ""
 
-#define USB_INTERFACE                  0
-#define USB_CONFIGURATION              1
-#define NUM_PROBES                     8
-#define NUM_TRIGGER_STAGES             4
-#define TRIGGER_TYPES                  "01"
-#define FIRMWARE                       FIRMWARE_DIR "/saleae-logic.fw"
+#define USB_INTERFACE          0
+#define USB_CONFIGURATION      1
+#define NUM_PROBES             8
+#define NUM_TRIGGER_STAGES     4
+#define TRIGGER_TYPES          "01"
+#define FIRMWARE               FIRMWARE_DIR "/saleae-logic.fw"
 
 /* delay in ms */
-#define FIRMWARE_RENUM_DELAY           2000
-#define NUM_SIMUL_TRANSFERS            10
-#define MAX_EMPTY_TRANSFERS            (NUM_SIMUL_TRANSFERS * 2)
+#define FIRMWARE_RENUM_DELAY   2000
+#define NUM_SIMUL_TRANSFERS    10
+#define MAX_EMPTY_TRANSFERS    (NUM_SIMUL_TRANSFERS * 2)
 
 /* Software trigger implementation: positive values indicate trigger stage. */
-#define TRIGGER_FIRED                  -1
+#define TRIGGER_FIRED          -1
 
 /* There is only one model Saleae Logic, and this is what it supports: */
 static int capabilities[] = {
@@ -54,6 +54,7 @@ static int capabilities[] = {
 
        /* These are really implemented in the driver, not the hardware. */
        HWCAP_LIMIT_SAMPLES,
+       HWCAP_CONTINUOUS,
        0,
 };
 
@@ -164,75 +165,6 @@ int check_conf_profile(libusb_device *dev)
        return ret;
 }
 
-static int opendev2(int device_index, struct sigrok_device_instance **sdi,
-                   libusb_device *dev, struct libusb_device_descriptor *des,
-                   int *skip, uint16_t vid, uint16_t pid, int interface)
-{
-       int err;
-
-       if ((err = libusb_get_device_descriptor(dev, des))) {
-               g_warning("failed to get device descriptor: %d", err);
-               return -1;
-       }
-
-       if (des->idVendor != vid || des->idProduct != pid)
-               return 0;
-
-       if (*skip != device_index) {
-               /* Skip devices of this type that aren't the one we want. */
-               *skip += 1;
-               return 0;
-       }
-
-       /*
-        * Should check the bus here, since we know that already. But what are
-        * we going to do if it doesn't match after the right number of skips?
-        */
-       if (!(err = libusb_open(dev, &((*sdi)->usb->devhdl)))) {
-               (*sdi)->usb->address = libusb_get_device_address(dev);
-               (*sdi)->status = ST_ACTIVE;
-               g_message("opened device %d on %d.%d interface %d",
-                         (*sdi)->index, (*sdi)->usb->bus,
-                         (*sdi)->usb->address, interface);
-       } else {
-               g_warning("failed to open device: %d", err);
-               *sdi = NULL;
-       }
-
-       return 0;
-}
-
-static int opendev3(struct sigrok_device_instance **sdi, libusb_device *dev,
-                   struct libusb_device_descriptor *des,
-                   uint16_t vid, uint16_t pid, int interface)
-{
-       int err;
-
-       if ((err = libusb_get_device_descriptor(dev, des))) {
-               g_warning("failed to get device descriptor: %d", err);
-               return -1;
-       }
-
-       if (des->idVendor != vid || des->idProduct != pid)
-               return 0;
-
-       if (libusb_get_bus_number(dev) == (*sdi)->usb->bus
-           && libusb_get_device_address(dev) == (*sdi)->usb->address) {
-               /* Found it. */
-               if (!(err = libusb_open(dev, &((*sdi)->usb->devhdl)))) {
-                       (*sdi)->status = ST_ACTIVE;
-                       g_message("opened device %d on %d.%d interface %d",
-                                 (*sdi)->index, (*sdi)->usb->bus,
-                                 (*sdi)->usb->address, interface);
-               } else {
-                       g_warning("failed to open device: %d", err);
-                       *sdi = NULL;
-               }
-       }
-
-       return 0;
-}
-
 struct sigrok_device_instance *sl_open_device(int device_index)
 {
        struct sigrok_device_instance *sdi;
@@ -300,7 +232,7 @@ static void close_device(struct sigrok_device_instance *sdi)
        if (sdi->usb->devhdl == NULL)
                return;
 
-       g_message("closing device %d on %d.%d interface %d", sdi->index,
+       g_message("saleae: closing device %d on %d.%d interface %d", sdi->index,
                  sdi->usb->bus, sdi->usb->address, USB_INTERFACE);
        libusb_release_interface(sdi->usb->devhdl, USB_INTERFACE);
        libusb_close(sdi->usb->devhdl);
@@ -328,16 +260,17 @@ static int configure_probes(GSList *probes)
                        continue;
                probe_bit = 1 << (probe->index - 1);
                probe_mask |= probe_bit;
-               if (probe->trigger) {
-                       stage = 0;
-                       for (tc = probe->trigger; *tc; tc++) {
-                               trigger_mask[stage] |= probe_bit;
-                               if (*tc == '1')
-                                       trigger_value[stage] |= probe_bit;
-                               stage++;
-                               if (stage > NUM_TRIGGER_STAGES)
-                                       return SIGROK_ERR;
-                       }
+               if (!(probe->trigger))
+                       continue;
+
+               stage = 0;
+               for (tc = probe->trigger; *tc; tc++) {
+                       trigger_mask[stage] |= probe_bit;
+                       if (*tc == '1')
+                               trigger_value[stage] |= probe_bit;
+                       stage++;
+                       if (stage > NUM_TRIGGER_STAGES)
+                               return SIGROK_ERR;
                }
        }
 
@@ -364,14 +297,13 @@ static int hw_init(char *deviceinfo)
        libusb_device **devlist;
        int err, devcnt, i;
 
-       /* QUICK HACK */
+       /* Avoid compiler warnings. */
        deviceinfo = deviceinfo;
 
        if (libusb_init(&usb_context) != 0) {
                g_warning("Failed to initialize USB.");
                return 0;
        }
-       libusb_set_debug(usb_context, 3);
 
        /* Find all Saleae Logic devices and upload firmware to all of them. */
        devcnt = 0;
@@ -433,7 +365,7 @@ static int hw_opendev(int device_index)
                timediff = cur - upd;
                if (timediff < FIRMWARE_RENUM_DELAY) {
                        timediff = FIRMWARE_RENUM_DELAY - timediff;
-                       g_message("waiting %d ms for device to reset",
+                       g_message("saleae: waiting %d ms for device to reset",
                                  timediff);
                        g_usleep(timediff * 1000);
                        firmware_updated.tv_sec = 0;
@@ -549,7 +481,7 @@ static int set_configuration_samplerate(struct sigrok_device_instance *sdi,
 
        divider = (uint8_t) (48 / (samplerate / 1000000.0)) - 1;
 
-       g_message("setting samplerate to %" PRIu64 " Hz (divider %d)",
+       g_message("saleae: setting samplerate to %" PRIu64 " Hz (divider %d)",
                  samplerate, divider);
        buf[0] = 0x01;
        buf[1] = divider;
@@ -579,7 +511,8 @@ static int hw_set_configuration(int device_index, int capability, void *value)
        } else if (capability == HWCAP_PROBECONFIG) {
                ret = configure_probes((GSList *) value);
        } else if (capability == HWCAP_LIMIT_SAMPLES) {
-               limit_samples = strtoull(value, NULL, 10);
+               tmp_u64 = value;
+               limit_samples = *tmp_u64;
                ret = SIGROK_OK;
        } else {
                ret = SIGROK_ERR;
@@ -592,7 +525,7 @@ static int receive_data(int fd, int revents, void *user_data)
 {
        struct timeval tv;
 
-       /* QUICK HACK */
+       /* Avoid compiler warnings. */
        fd = fd;
        revents = revents;
        user_data = user_data;
@@ -603,59 +536,6 @@ static int receive_data(int fd, int revents, void *user_data)
        return TRUE;
 }
 
-static void trigger_helper(int i, unsigned char *cur_buf,
-                          struct datafeed_packet *packet, void *user_data,
-                          int *trigger_offset)
-{
-       if ((cur_buf[i] & trigger_mask[trigger_stage])
-           == trigger_value[trigger_stage]) {
-               /* Match on this trigger stage. */
-               trigger_buffer[trigger_stage] = cur_buf[i];
-               trigger_stage++;
-               if (trigger_stage == NUM_TRIGGER_STAGES
-                   || trigger_mask[trigger_stage] == 0) {
-                       /* Match on all trigger stages, we're done. */
-                       *trigger_offset = i + 1;
-
-                       /*
-                        * TODO: Send pre-trigger buffer to session bus.
-                        * Tell the frontend we hit the trigger here.
-                        */
-                       packet->type = DF_TRIGGER;
-                       packet->length = 0;
-                       session_bus(user_data, packet);
-
-                       /*
-                        * Send the samples that triggered it, since we're
-                        * skipping past them.
-                        */
-                       packet->type = DF_LOGIC8;
-                       packet->length = trigger_stage;
-                       packet->payload = trigger_buffer;
-                       session_bus(user_data, packet);
-                       // break; // FIXME???
-
-                       trigger_stage = TRIGGER_FIRED;
-               }
-               return;
-       }
-
-       /*
-        * We had a match before, but not in the next sample. However, we may
-        * have a match on this stage in the next bit -- trigger on 0001 will
-        * fail on seeing 00001, so we need to go back to stage 0 -- but at
-        * the next sample from the one that matched originally, which the
-        * counter increment at the end of the loop takes care of.
-        */
-       if (trigger_stage > 0) {
-               i -= trigger_stage;
-               if (i < -1)
-                       i = -1; /* Oops, went back past this buffer. */
-               /* Reset trigger stage. */
-               trigger_stage = 0;
-       }
-}
-
 void receive_transfer(struct libusb_transfer *transfer)
 {
        static int num_samples = 0;
@@ -679,7 +559,7 @@ void receive_transfer(struct libusb_transfer *transfer)
                return;
        }
 
-       g_message("receive_transfer(): status %d received %d bytes",
+       g_message("saleae: receive_transfer(): status %d received %d bytes",
                  transfer->status, transfer->actual_length);
 
        /* Save incoming transfer before reusing the transfer struct. */
@@ -713,21 +593,69 @@ void receive_transfer(struct libusb_transfer *transfer)
        trigger_offset = 0;
        if (trigger_stage >= 0) {
                for (i = 0; i < cur_buflen; i++) {
-                       trigger_helper(i, cur_buf, &packet, user_data,
-                                      &trigger_offset);
+
+                       if ((cur_buf[i] & trigger_mask[trigger_stage]) == trigger_value[trigger_stage]) {
+                               /* Match on this trigger stage. */
+                               trigger_buffer[trigger_stage] = cur_buf[i];
+                               trigger_stage++;
+                               if (trigger_stage == NUM_TRIGGER_STAGES || trigger_mask[trigger_stage] == 0) {
+                                       /* Match on all trigger stages, we're done. */
+                                       trigger_offset = i + 1;
+
+                                       /*
+                                        * TODO: Send pre-trigger buffer to session bus.
+                                        * Tell the frontend we hit the trigger here.
+                                        */
+                                       packet.type = DF_TRIGGER;
+                                       packet.length = 0;
+                                       session_bus(user_data, &packet);
+
+                                       /*
+                                        * Send the samples that triggered it, since we're
+                                        * skipping past them.
+                                        */
+                                       packet.type = DF_LOGIC;
+                                       packet.length = trigger_stage;
+                                       packet.unitsize = 1;
+                                       packet.payload = trigger_buffer;
+                                       session_bus(user_data, &packet);
+
+                                       trigger_stage = TRIGGER_FIRED;
+                                       break;
+                               }
+                               return;
+                       }
+
+                       /*
+                        * We had a match before, but not in the next sample. However, we may
+                        * have a match on this stage in the next bit -- trigger on 0001 will
+                        * fail on seeing 00001, so we need to go back to stage 0 -- but at
+                        * the next sample from the one that matched originally, which the
+                        * counter increment at the end of the loop takes care of.
+                        */
+                       if (trigger_stage > 0) {
+                               i -= trigger_stage;
+                               if (i < -1)
+                                       i = -1; /* Oops, went back past this buffer. */
+                               /* Reset trigger stage. */
+                               trigger_stage = 0;
+                       }
+
+
                }
        }
 
        if (trigger_stage == TRIGGER_FIRED) {
                /* Send the incoming transfer to the session bus. */
-               packet.type = DF_LOGIC8;
+               packet.type = DF_LOGIC;
                packet.length = cur_buflen - trigger_offset;
+               packet.unitsize = 1;
                packet.payload = cur_buf + trigger_offset;
                session_bus(user_data, &packet);
                g_free(cur_buf);
 
                num_samples += cur_buflen;
-               if ((unsigned int)num_samples > limit_samples) {
+               if (limit_samples && (unsigned int) num_samples > limit_samples) {
                        hw_stop_acquisition(-1, user_data);
                }
        } else {
@@ -786,7 +714,8 @@ static int hw_start_acquisition(int device_index, gpointer session_device_id)
        gettimeofday(&header->starttime, NULL);
        header->samplerate = cur_samplerate;
        header->protocol_id = PROTO_RAW;
-       header->num_probes = NUM_PROBES;
+       header->num_logic_probes = NUM_PROBES;
+       header->num_analog_probes = 0;
        session_bus(session_device_id, packet);
        g_free(header);
        g_free(packet);
@@ -799,7 +728,7 @@ static void hw_stop_acquisition(int device_index, gpointer session_device_id)
 {
        struct datafeed_packet packet;
 
-       /* QUICK HACK */
+       /* Avoid compiler warnings. */
        device_index = device_index;
 
        packet.type = DF_END;