]> sigrok.org Git - libsigrok.git/blobdiff - hardware/openbench-logic-sniffer/api.c
Consistently use 'cg' for channel group variables.
[libsigrok.git] / hardware / openbench-logic-sniffer / api.c
index c189bed32715800b1ac6b2e947ca38668db42411..76942437d9475d2a53b1df2c7ac05fe157ff8713 100644 (file)
@@ -39,8 +39,9 @@ static const int32_t hwcaps[] = {
        SR_CONF_RLE,
 };
 
-#define STR_PATTERN_EXTERNAL "external"
-#define STR_PATTERN_INTERNAL "internal"
+#define STR_PATTERN_NONE     "None"
+#define STR_PATTERN_EXTERNAL "External"
+#define STR_PATTERN_INTERNAL "Internal"
 
 /* Supported methods of test pattern outputs */
 enum {
@@ -55,6 +56,7 @@ enum {
 };
 
 static const char *patterns[] = {
+       STR_PATTERN_NONE,
        STR_PATTERN_EXTERNAL,
        STR_PATTERN_INTERNAL,
 };
@@ -77,11 +79,6 @@ static const uint64_t samplerates[] = {
 SR_PRIV struct sr_dev_driver ols_driver_info;
 static struct sr_dev_driver *di = &ols_driver_info;
 
-static int dev_clear(void)
-{
-       return std_dev_clear(di, NULL);
-}
-
 static int init(struct sr_context *sr_ctx)
 {
        return std_init(sr_ctx, di, LOG_PREFIX);
@@ -159,7 +156,7 @@ static GSList *scan(GSList *options)
 
        if (probefd.revents != G_IO_IN)
                return NULL;
-       if (serial_read(serial, buf, 4) != 4)
+       if (serial_read_blocking(serial, buf, 4) != 4)
                return NULL;
        if (strncmp(buf, "1SLO", 4) && strncmp(buf, "1ALS", 4))
                return NULL;
@@ -210,30 +207,17 @@ static GSList *dev_list(void)
        return ((struct drv_context *)(di->priv))->instances;
 }
 
-static int dev_open(struct sr_dev_inst *sdi)
-{
-       struct sr_serial_dev_inst *serial;
-
-       serial = sdi->conn;
-       if (serial_open(serial, SERIAL_RDWR | SERIAL_NONBLOCK) != SR_OK)
-               return SR_ERR;
-
-       sdi->status = SR_ST_ACTIVE;
-
-       return SR_OK;
-}
-
 static int cleanup(void)
 {
-       return dev_clear();
+       return std_dev_clear(di, NULL);
 }
 
 static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi,
-               const struct sr_probe_group *probe_group)
+               const struct sr_channel_group *cg)
 {
        struct dev_context *devc;
 
-       (void)probe_group;
+       (void)cg;
 
        if (!sdi)
                return SR_ERR_ARG;
@@ -254,6 +238,8 @@ static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi,
                        *data = g_variant_new_string(STR_PATTERN_EXTERNAL);
                else if (devc->flag_reg & FLAG_INTERNAL_TEST_MODE)
                        *data = g_variant_new_string(STR_PATTERN_INTERNAL);
+               else
+                       *data = g_variant_new_string(STR_PATTERN_NONE);
                break;
        case SR_CONF_RLE:
                *data = g_variant_new_boolean(devc->flag_reg & FLAG_RLE ? TRUE : FALSE);
@@ -266,14 +252,15 @@ static int config_get(int id, GVariant **data, const struct sr_dev_inst *sdi,
 }
 
 static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
-               const struct sr_probe_group *probe_group)
+               const struct sr_channel_group *cg)
 {
        struct dev_context *devc;
-       int ret;
+       uint16_t flag;
        uint64_t tmp_u64;
+       int ret;
        const char *stropt;
 
-       (void)probe_group;
+       (void)cg;
 
        if (sdi->status != SR_ST_ACTIVE)
                return SR_ERR_DEV_CLOSED;
@@ -315,15 +302,23 @@ static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
        case SR_CONF_PATTERN_MODE:
                stropt = g_variant_get_string(data, NULL);
                ret = SR_OK;
-               if (!strcmp(stropt, STR_PATTERN_INTERNAL)) {
+               flag = 0xffff;
+               if (!strcmp(stropt, STR_PATTERN_NONE)) {
+                       sr_info("Disabling test modes.");
+                       flag = 0x0000;
+               }else if (!strcmp(stropt, STR_PATTERN_INTERNAL)) {
                        sr_info("Enabling internal test mode.");
-                       devc->flag_reg |= FLAG_INTERNAL_TEST_MODE;
+                       flag = FLAG_INTERNAL_TEST_MODE;
                } else if (!strcmp(stropt, STR_PATTERN_EXTERNAL)) {
                        sr_info("Enabling external test mode.");
-                       devc->flag_reg |= FLAG_EXTERNAL_TEST_MODE;
+                       flag = FLAG_EXTERNAL_TEST_MODE;
                } else {
                        ret = SR_ERR;
                }
+               if (flag != 0xffff) {
+                       devc->flag_reg &= ~(FLAG_INTERNAL_TEST_MODE | FLAG_EXTERNAL_TEST_MODE);
+                       devc->flag_reg |= flag;
+               }
                break;
        case SR_CONF_SWAP:
                if (g_variant_get_boolean(data)) {
@@ -354,13 +349,14 @@ static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
 }
 
 static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
-               const struct sr_probe_group *probe_group)
+               const struct sr_channel_group *cg)
 {
-       GVariant *gvar;
+       struct dev_context *devc;
+       GVariant *gvar, *grange[2];
        GVariantBuilder gvb;
+       int num_channels, i;
 
-       (void)sdi;
-       (void)probe_group;
+       (void)cg;
 
        switch (key) {
        case SR_CONF_SCAN_OPTIONS:
@@ -384,6 +380,29 @@ static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
        case SR_CONF_PATTERN_MODE:
                *data = g_variant_new_strv(patterns, ARRAY_SIZE(patterns));
                break;
+       case SR_CONF_LIMIT_SAMPLES:
+               if (!sdi)
+                       return SR_ERR_ARG;
+               devc = sdi->priv;
+               if (devc->flag_reg & FLAG_RLE)
+                       return SR_ERR_NA;
+               if (devc->max_samples == 0)
+                       /* Device didn't specify sample memory size in metadata. */
+                       return SR_ERR_NA;
+               /*
+                * Channel groups are turned off if no probes in that group are
+                * enabled, making more room for samples for the enabled group.
+               */
+               ols_configure_probes(sdi);
+               num_channels = 0;
+               for (i = 0; i < 4; i++) {
+                       if (devc->probe_mask & (0xff << (i * 8)))
+                               num_channels++;
+               }
+               grange[0] = g_variant_new_uint64(MIN_NUM_SAMPLES);
+               grange[1] = g_variant_new_uint64(devc->max_samples / num_channels);
+               *data = g_variant_new_tuple(grange, 2);
+               break;
        default:
                return SR_ERR_NA;
        }
@@ -391,17 +410,52 @@ static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
        return SR_OK;
 }
 
+static int set_trigger(const struct sr_dev_inst *sdi, int stage)
+{
+       struct dev_context *devc;
+       struct sr_serial_dev_inst *serial;
+       uint8_t cmd, arg[4];
+
+       devc = sdi->priv;
+       serial = sdi->conn;
+
+       cmd = CMD_SET_TRIGGER_MASK + stage * 4;
+       arg[0] = devc->trigger_mask[stage] & 0xff;
+       arg[1] = (devc->trigger_mask[stage] >> 8) & 0xff;
+       arg[2] = (devc->trigger_mask[stage] >> 16) & 0xff;
+       arg[3] = (devc->trigger_mask[stage] >> 24) & 0xff;
+       if (send_longcommand(serial, cmd, arg) != SR_OK)
+               return SR_ERR;
+
+       cmd = CMD_SET_TRIGGER_VALUE + stage * 4;
+       arg[0] = devc->trigger_value[stage] & 0xff;
+       arg[1] = (devc->trigger_value[stage] >> 8) & 0xff;
+       arg[2] = (devc->trigger_value[stage] >> 16) & 0xff;
+       arg[3] = (devc->trigger_value[stage] >> 24) & 0xff;
+       if (send_longcommand(serial, cmd, arg) != SR_OK)
+               return SR_ERR;
+
+       cmd = CMD_SET_TRIGGER_CONFIG + stage * 4;
+       arg[0] = arg[1] = arg[3] = 0x00;
+       arg[2] = stage;
+       if (stage == devc->num_stages)
+               /* Last stage, fire when this one matches. */
+               arg[3] |= TRIGGER_START;
+       if (send_longcommand(serial, cmd, arg) != SR_OK)
+               return SR_ERR;
+
+       return SR_OK;
+}
+
 static int dev_acquisition_start(const struct sr_dev_inst *sdi,
                void *cb_data)
 {
        struct dev_context *devc;
        struct sr_serial_dev_inst *serial;
-       uint32_t trigger_config[4];
-       uint32_t data;
-       uint16_t readcount, delaycount;
-       uint8_t changrp_mask;
+       uint16_t samplecount, readcount, delaycount;
+       uint8_t changrp_mask, arg[4];
        int num_channels;
-       int i;
+       int ret, i;
 
        if (sdi->status != SR_ST_ACTIVE)
                return SR_ERR_DEV_CLOSED;
@@ -432,86 +486,64 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi,
         * Limit readcount to prevent reading past the end of the hardware
         * buffer.
         */
-       readcount = MIN(devc->max_samples / num_channels, devc->limit_samples) / 4;
+       samplecount = MIN(devc->max_samples / num_channels, devc->limit_samples);
+       readcount = samplecount / 4;
 
-       memset(trigger_config, 0, 16);
-       trigger_config[devc->num_stages] |= 0x08;
-       if (devc->trigger_mask[0]) {
+       /* Rather read too many samples than too few. */
+       if (samplecount % 4 != 0)
+               readcount++;
+
+       /* Basic triggers. */
+       if (devc->trigger_mask[0] != 0x00000000) {
+               /* At least one probe has a trigger on it. */
                delaycount = readcount * (1 - devc->capture_ratio / 100.0);
                devc->trigger_at = (readcount - delaycount) * 4 - devc->num_stages;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_0,
-                       reverse32(devc->trigger_mask[0])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_0,
-                       reverse32(devc->trigger_value[0])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_0,
-                       trigger_config[0]) != SR_OK)
-                       return SR_ERR;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_1,
-                       reverse32(devc->trigger_mask[1])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_1,
-                       reverse32(devc->trigger_value[1])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_1,
-                       trigger_config[1]) != SR_OK)
-                       return SR_ERR;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_2,
-                       reverse32(devc->trigger_mask[2])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_2,
-                       reverse32(devc->trigger_value[2])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_2,
-                       trigger_config[2]) != SR_OK)
-                       return SR_ERR;
-
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_3,
-                       reverse32(devc->trigger_mask[3])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_3,
-                       reverse32(devc->trigger_value[3])) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_3,
-                       trigger_config[3]) != SR_OK)
-                       return SR_ERR;
+               for (i = 0; i <= devc->num_stages; i++) {
+                       sr_dbg("Setting stage %d trigger.", i);
+                       if ((ret = set_trigger(sdi, i)) != SR_OK)
+                               return ret;
+               }
        } else {
-               if (send_longcommand(serial, CMD_SET_TRIGGER_MASK_0,
-                               devc->trigger_mask[0]) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_VALUE_0,
-                               devc->trigger_value[0]) != SR_OK)
-                       return SR_ERR;
-               if (send_longcommand(serial, CMD_SET_TRIGGER_CONFIG_0,
-                    0x00000008) != SR_OK)
-                       return SR_ERR;
+               /* No triggers configured, force trigger on first stage. */
+               sr_dbg("Forcing trigger at stage 0.");
+               if ((ret = set_trigger(sdi, 0)) != SR_OK)
+                       return ret;
                delaycount = readcount;
        }
 
-       sr_info("Setting samplerate to %" PRIu64 "Hz (divider %u, "
-               "demux %s, noise_filter %s)", devc->cur_samplerate,
-               devc->cur_samplerate_divider,
-               devc->flag_reg & FLAG_DEMUX ? "on" : "off",
-               devc->flag_reg & FLAG_FILTER ? "on": "off");
-       if (send_longcommand(serial, CMD_SET_DIVIDER,
-                       reverse32(devc->cur_samplerate_divider)) != SR_OK)
+       /* Samplerate. */
+       sr_dbg("Setting samplerate to %" PRIu64 "Hz (divider %u)",
+                       devc->cur_samplerate, devc->cur_samplerate_divider);
+       arg[0] = devc->cur_samplerate_divider & 0xff;
+       arg[1] = (devc->cur_samplerate_divider & 0xff00) >> 8;
+       arg[2] = (devc->cur_samplerate_divider & 0xff0000) >> 16;
+       arg[3] = 0x00;
+       if (send_longcommand(serial, CMD_SET_DIVIDER, arg) != SR_OK)
                return SR_ERR;
 
        /* Send sample limit and pre/post-trigger capture ratio. */
-       data = ((readcount - 1) & 0xffff) << 16;
-       data |= (delaycount - 1) & 0xffff;
-       if (send_longcommand(serial, CMD_CAPTURE_SIZE, reverse16(data)) != SR_OK)
+       sr_dbg("Setting sample limit %d, trigger point at %d",
+                       (readcount - 1) * 4, (delaycount - 1) * 4);
+       arg[0] = ((readcount - 1) & 0xff);
+       arg[1] = ((readcount - 1) & 0xff00) >> 8;
+       arg[2] = ((delaycount - 1) & 0xff);
+       arg[3] = ((delaycount - 1) & 0xff00) >> 8;
+       if (send_longcommand(serial, CMD_CAPTURE_SIZE, arg) != SR_OK)
                return SR_ERR;
 
-       /* The flag register wants them here, and 1 means "disable channel". */
+       /* Flag register. */
+       sr_dbg("Setting intpat %s, extpat %s, RLE %s, noise_filter %s, demux %s",
+                       devc->flag_reg & FLAG_INTERNAL_TEST_MODE ? "on": "off",
+                       devc->flag_reg & FLAG_EXTERNAL_TEST_MODE ? "on": "off",
+                       devc->flag_reg & FLAG_RLE ? "on" : "off",
+                       devc->flag_reg & FLAG_FILTER ? "on": "off",
+                       devc->flag_reg & FLAG_DEMUX ? "on" : "off");
+       /* 1 means "disable channel". */
        devc->flag_reg |= ~(changrp_mask << 2) & 0x3c;
-       devc->rle_count = 0;
-       data = (devc->flag_reg << 24) | ((devc->flag_reg << 8) & 0xff0000);
-       if (send_longcommand(serial, CMD_SET_FLAGS, data) != SR_OK)
+       arg[0] = devc->flag_reg & 0xff;
+       arg[1] = devc->flag_reg >> 8;
+       arg[2] = arg[3] = 0x00;
+       if (send_longcommand(serial, CMD_SET_FLAGS, arg) != SR_OK)
                return SR_ERR;
 
        /* Start acquisition on the device. */
@@ -519,7 +551,9 @@ static int dev_acquisition_start(const struct sr_dev_inst *sdi,
                return SR_ERR;
 
        /* Reset all operational states. */
-       devc->num_transfers = devc->num_samples = devc->num_bytes = 0;
+       devc->rle_count = devc->num_transfers = 0;
+       devc->num_samples = devc->num_bytes = 0;
+       devc->cnt_bytes = devc->cnt_samples = devc->cnt_samples_rle = 0;
        memset(devc->sample, 0, 4);
 
        /* Send header packet to the session bus. */
@@ -547,11 +581,11 @@ SR_PRIV struct sr_dev_driver ols_driver_info = {
        .cleanup = cleanup,
        .scan = scan,
        .dev_list = dev_list,
-       .dev_clear = dev_clear,
+       .dev_clear = NULL,
        .config_get = config_get,
        .config_set = config_set,
        .config_list = config_list,
-       .dev_open = dev_open,
+       .dev_open = std_serial_dev_open,
        .dev_close = std_serial_dev_close,
        .dev_acquisition_start = dev_acquisition_start,
        .dev_acquisition_stop = dev_acquisition_stop,