]> sigrok.org Git - libsigrok.git/blobdiff - hardware/hantek-dso/api.c
hantek-dso: scan/info_get fixes
[libsigrok.git] / hardware / hantek-dso / api.c
index 40303fee1c2e9d643a82bc465800af5357b6f1d5..f38c80d7b68a6da27abb5363edb567218ed08e84 100644 (file)
@@ -145,7 +145,8 @@ static const char *coupling[] = {
 };
 
 SR_PRIV libusb_context *usb_context = NULL;
-SR_PRIV GSList *dev_insts = NULL;
+SR_PRIV struct sr_dev_driver hantek_dso_driver_info;
+static struct sr_dev_driver *hdi = &hantek_dso_driver_info;
 
 static struct sr_dev_inst *dso_dev_new(int index, const struct dso_profile *prof)
 {
@@ -156,6 +157,7 @@ static struct sr_dev_inst *dso_dev_new(int index, const struct dso_profile *prof
                prof->vendor, prof->model, NULL);
        if (!sdi)
                return NULL;
+       sdi->driver = hdi;
 
        if (!(ctx = g_try_malloc0(sizeof(struct context)))) {
                sr_err("hantek-dso: ctx malloc failed");
@@ -178,7 +180,7 @@ static struct sr_dev_inst *dso_dev_new(int index, const struct dso_profile *prof
        ctx->triggersource = g_strdup(DEFAULT_TRIGGER_SOURCE);
        ctx->triggerposition = DEFAULT_HORIZ_TRIGGERPOS;
        sdi->priv = ctx;
-       dev_insts = g_slist_append(dev_insts, sdi);
+       hdi->instances = g_slist_append(hdi->instances, sdi);
 
        return sdi;
 }
@@ -200,6 +202,36 @@ static int configure_probes(struct context *ctx, const GSList *probes)
        return SR_OK;
 }
 
+/* Properly close and free all devices. */
+static void clear_instances(void)
+{
+       struct sr_dev_inst *sdi;
+       struct context *ctx;
+       GSList *l;
+
+       for (l = hdi->instances; l; l = l->next) {
+               if (!(sdi = l->data)) {
+                       /* Log error, but continue cleaning up the rest. */
+                       sr_err("hantek-dso: %s: sdi was NULL, continuing", __func__);
+                       continue;
+               }
+               if (!(ctx = sdi->priv)) {
+                       /* Log error, but continue cleaning up the rest. */
+                       sr_err("hantek-dso: %s: sdi->priv was NULL, continuing", __func__);
+                       continue;
+               }
+               dso_close(sdi);
+               sr_usb_dev_inst_free(ctx->usb);
+               g_free(ctx->triggersource);
+
+               sr_dev_inst_free(sdi);
+       }
+
+       g_slist_free(hdi->instances);
+       hdi->instances = NULL;
+
+}
+
 static int hw_init(void)
 {
 
@@ -211,17 +243,24 @@ static int hw_init(void)
        return SR_OK;
 }
 
-static int hw_scan(void)
+static GSList *hw_scan(GSList *options)
 {
        struct sr_dev_inst *sdi;
-       struct libusb_device_descriptor des;
        const struct dso_profile *prof;
        struct context *ctx;
+       GSList *devices;
+       struct libusb_device_descriptor des;
        libusb_device **devlist;
        int devcnt, ret, i, j;
 
-       /* Find all Hantek DSO devices and upload firmware to all of them. */
+       (void)options;
        devcnt = 0;
+       devices = 0;
+       hdi->instances = NULL;
+
+       clear_instances();
+
+       /* Find all Hantek DSO devices and upload firmware to all of them. */
        libusb_get_device_list(usb_context, &devlist);
        for (i = 0; devlist[i]; i++) {
                if ((ret = libusb_get_device_descriptor(devlist[i], &des))) {
@@ -237,6 +276,7 @@ static int hw_scan(void)
                                prof = &dev_profiles[j];
                                sr_dbg("hantek-dso: Found a %s %s.", prof->vendor, prof->model);
                                sdi = dso_dev_new(devcnt, prof);
+                               devices = g_slist_append(devices, sdi);
                                ctx = sdi->priv;
                                if (ezusb_upload_firmware(devlist[i], USB_CONFIGURATION,
                                                prof->firmware) == SR_OK)
@@ -257,6 +297,7 @@ static int hw_scan(void)
                                sr_dbg("hantek-dso: Found a %s %s.", prof->vendor, prof->model);
                                sdi = dso_dev_new(devcnt, prof);
                                sdi->status = SR_ST_INACTIVE;
+                               devices = g_slist_append(devices, sdi);
                                ctx = sdi->priv;
                                ctx->usb = sr_usb_dev_inst_new(
                                                libusb_get_bus_number(devlist[i]),
@@ -271,7 +312,7 @@ static int hw_scan(void)
        }
        libusb_free_device_list(devlist, 1);
 
-       return devcnt;
+       return devices;
 }
 
 static int hw_dev_open(int dev_index)
@@ -281,7 +322,7 @@ static int hw_dev_open(int dev_index)
        int64_t timediff_us, timediff_ms;
        int err;
 
-       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
+       if (!(sdi = sr_dev_inst_get(hdi->instances, dev_index)))
                return SR_ERR_ARG;
        ctx = sdi->priv;
 
@@ -326,7 +367,7 @@ static int hw_dev_close(int dev_index)
 {
        struct sr_dev_inst *sdi;
 
-       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
+       if (!(sdi = sr_dev_inst_get(hdi->instances, dev_index)))
                return SR_ERR_ARG;
 
        dso_close(sdi);
@@ -336,31 +377,8 @@ static int hw_dev_close(int dev_index)
 
 static int hw_cleanup(void)
 {
-       GSList *l;
-       struct sr_dev_inst *sdi;
-       struct context *ctx;
-
-       /* Properly close and free all devices. */
-       for (l = dev_insts; l; l = l->next) {
-               if (!(sdi = l->data)) {
-                       /* Log error, but continue cleaning up the rest. */
-                       sr_err("hantek-dso: %s: sdi was NULL, continuing", __func__);
-                       continue;
-               }
-               if (!(ctx = sdi->priv)) {
-                       /* Log error, but continue cleaning up the rest. */
-                       sr_err("hantek-dso: %s: sdi->priv was NULL, continuing", __func__);
-                       continue;
-               }
-               dso_close(sdi);
-               sr_usb_dev_inst_free(ctx->usb);
-               g_free(ctx->triggersource);
-
-               sr_dev_inst_free(sdi);
-       }
 
-       g_slist_free(dev_insts);
-       dev_insts = NULL;
+       clear_instances();
 
        if (usb_context)
                libusb_exit(usb_context);
@@ -369,58 +387,55 @@ static int hw_cleanup(void)
        return SR_OK;
 }
 
-static const void *hw_dev_info_get(int dev_index, int dev_info_id)
+static int hw_info_get(int info_id, const void **data,
+       const struct sr_dev_inst *sdi)
 {
-       struct sr_dev_inst *sdi;
-       const void *info;
        uint64_t tmp;
 
-       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
-               return NULL;
-
-       info = NULL;
-       switch (dev_info_id) {
+       switch (info_id) {
        case SR_DI_INST:
-               info = sdi;
+               *data = sdi;
                break;
        case SR_DI_NUM_PROBES:
-               info = GINT_TO_POINTER(NUM_PROBES);
+               *data = GINT_TO_POINTER(NUM_PROBES);
                break;
        case SR_DI_PROBE_NAMES:
-               info = probe_names;
+               *data = probe_names;
                break;
        case SR_DI_BUFFERSIZES:
-               info = buffersizes;
+               *data = buffersizes;
                break;
        case SR_DI_TIMEBASES:
-               info = timebases;
+               *data = timebases;
                break;
        case SR_DI_TRIGGER_SOURCES:
-               info = trigger_sources;
+               *data = trigger_sources;
                break;
        case SR_DI_FILTERS:
-               info = filter_targets;
+               *data = filter_targets;
                break;
        case SR_DI_VDIVS:
-               info = vdivs;
+               *data = vdivs;
                break;
        case SR_DI_COUPLING:
-               info = coupling;
+               *data = coupling;
                break;
        /* TODO remove this */
        case SR_DI_CUR_SAMPLERATE:
-               info = &tmp;
+               *data = &tmp;
                break;
+       default:
+               return SR_ERR_ARG;
        }
 
-       return info;
+       return SR_OK;
 }
 
 static int hw_dev_status_get(int dev_index)
 {
        struct sr_dev_inst *sdi;
 
-       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
+       if (!(sdi = sr_dev_inst_get(hdi->instances, dev_index)))
                return SR_ST_NOT_FOUND;
 
        return sdi->status;
@@ -441,7 +456,7 @@ static int hw_dev_config_set(int dev_index, int hwcap, const void *value)
        int ret, i;
        char **targets;
 
-       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
+       if (!(sdi = sr_dev_inst_get(hdi->instances, dev_index)))
                return SR_ERR;
 
        if (sdi->status != SR_ST_ACTIVE)
@@ -794,7 +809,7 @@ static int hw_dev_acquisition_start(int dev_index, void *cb_data)
        struct context *ctx;
        int i;
 
-       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
+       if (!(sdi = sr_dev_inst_get(hdi->instances, dev_index)))
                return SR_ERR;
 
        if (sdi->status != SR_ST_ACTIVE)
@@ -841,7 +856,7 @@ static int hw_dev_acquisition_stop(int dev_index, void *cb_data)
        struct sr_dev_inst *sdi;
        struct context *ctx;
 
-       if (!(sdi = sr_dev_inst_get(dev_insts, dev_index)))
+       if (!(sdi = sr_dev_inst_get(hdi->instances, dev_index)))
                return SR_ERR;
 
        if (sdi->status != SR_ST_ACTIVE)
@@ -865,10 +880,11 @@ SR_PRIV struct sr_dev_driver hantek_dso_driver_info = {
        .scan = hw_scan,
        .dev_open = hw_dev_open,
        .dev_close = hw_dev_close,
-       .dev_info_get = hw_dev_info_get,
+       .info_get = hw_info_get,
        .dev_status_get = hw_dev_status_get,
-       .hwcap_get_all = hw_hwcap_get_all,
+//     .hwcap_get_all = hw_hwcap_get_all,
        .dev_config_set = hw_dev_config_set,
        .dev_acquisition_start = hw_dev_acquisition_start,
        .dev_acquisition_stop = hw_dev_acquisition_stop,
+       .instances = NULL,
 };