Windows usb: don't try to resume thread if shut down in callback.

[libsigrok.git] / hardware / common / serial.c

diff --git a/hardware/common/serial.c b/hardware/common/serial.c
index 9727ce8a36271f7a9a5c50efdc6cbaf13449b1a4..891fd02d3729e43b235f8e1b404ed2642ee8482e 100644 (file)
--- a/hardware/common/serial.c
+++ b/hardware/common/serial.c
@@ -77,7 +77,8 @@ SR_PRIV int serial_open(struct sr_serial_dev_inst *serial, int flags)
                return SR_ERR_ARG;
        case SP_ERR_FAIL:
                error = sp_last_error_message();
-               sr_err("Error opening port: %s.", error);
+               sr_err("Error opening port (%d): %s.",
+                       sp_last_error_code(), error);
                sp_free_error_message(error);
                return SR_ERR;
        }
@@ -120,7 +121,8 @@ SR_PRIV int serial_close(struct sr_serial_dev_inst *serial)
                return SR_ERR_ARG;
        case SP_ERR_FAIL:
                error = sp_last_error_message();
-               sr_err("Error closing port: %s.", error);
+               sr_err("Error closing port (%d): %s.",
+                       sp_last_error_code(), error);
                sp_free_error_message(error);
                return SR_ERR;
        }
@@ -163,7 +165,8 @@ SR_PRIV int serial_flush(struct sr_serial_dev_inst *serial)
                return SR_ERR_ARG;
        case SP_ERR_FAIL:
                error = sp_last_error_message();
-               sr_err("Error flushing port: %s.", error);
+               sr_err("Error flushing port (%d): %s.",
+                       sp_last_error_code(), error);
                sp_free_error_message(error);
                return SR_ERR;
        }
@@ -207,7 +210,7 @@ SR_PRIV int serial_write(struct sr_serial_dev_inst *serial,
                return SR_ERR_ARG;
        case SP_ERR_FAIL:
                error = sp_last_error_message();
-               sr_err("Write error: %s.", error);
+               sr_err("Write error (%d): %s.", sp_last_error_code(), error);
                sp_free_error_message(error);
                return SR_ERR;
        }
@@ -253,7 +256,7 @@ SR_PRIV int serial_read(struct sr_serial_dev_inst *serial, void *buf,
                return SR_ERR_ARG;
        case SP_ERR_FAIL:
                error = sp_last_error_message();
-               sr_err("Read error: %s.", error);
+               sr_err("Read error (%d): %s.", sp_last_error_code(), error);
                sp_free_error_message(error);
                return SR_ERR;
        }
@@ -332,7 +335,8 @@ SR_PRIV int serial_set_params(struct sr_serial_dev_inst *serial, int baudrate,
                return SR_ERR_ARG;
        case SP_ERR_FAIL:
                error = sp_last_error_message();
-               sr_err("Error setting serial port parameters: %s.", error);
+               sr_err("Error setting serial port parameters (%d): %s.",
+                       sp_last_error_code(), error);
                sp_free_error_message(error);
                return SR_ERR;
        }
@@ -634,25 +638,69 @@ SR_PRIV int sr_serial_extract_options(GSList *options, const char **serial_devic
        return SR_OK;
 }
 
-SR_PRIV int serial_source_add(struct sr_serial_dev_inst *serial, int events,
-               int timeout, sr_receive_data_callback_t cb, void *cb_data)
-{
 #ifdef _WIN32
-       return SR_ERR;
+typedef HANDLE event_handle;
 #else
-       int fd;
-       sp_get_port_handle(serial->data, &fd);
-       return sr_source_add(fd, events, timeout, cb, cb_data);
+typedef int event_handle;
 #endif
+
+SR_PRIV int serial_source_add(struct sr_serial_dev_inst *serial, int events,
+               int timeout, sr_receive_data_callback_t cb, void *cb_data)
+{
+       enum sp_event mask = 0;
+       unsigned int i;
+
+       if (sp_new_event_set(&serial->event_set) != SP_OK)
+               return SR_ERR;
+
+       if (events & G_IO_IN)
+               mask |= SP_EVENT_RX_READY;
+       if (events & G_IO_OUT)
+               mask |= SP_EVENT_TX_READY;
+       if (events & G_IO_ERR)
+               mask |= SP_EVENT_ERROR;
+
+       if (sp_add_port_events(serial->event_set, serial->data, mask) != SP_OK) {
+               sp_free_event_set(serial->event_set);
+               return SR_ERR;
+       }
+
+       serial->pollfds = (GPollFD *) g_malloc0(sizeof(GPollFD) * serial->event_set->count);
+
+       for (i = 0; i < serial->event_set->count; i++) {
+
+               serial->pollfds[i].fd = ((event_handle *) serial->event_set->handles)[i];
+
+               mask = serial->event_set->masks[i];
+
+               if (mask & SP_EVENT_RX_READY)
+                       serial->pollfds[i].events |= G_IO_IN;
+               if (mask & SP_EVENT_TX_READY)
+                       serial->pollfds[i].events |= G_IO_OUT;
+               if (mask & SP_EVENT_ERROR)
+                       serial->pollfds[i].events |= G_IO_ERR;
+
+               if (sr_session_source_add_pollfd(&serial->pollfds[i],
+                               timeout, cb, cb_data) != SR_OK)
+                       return SR_ERR;
+       }
+
+       return SR_OK;
 }
 
 SR_PRIV int serial_source_remove(struct sr_serial_dev_inst *serial)
 {
-#ifdef _WIN32
-       return SR_ERR;
-#else
-       int fd;
-       sp_get_port_handle(serial->data, &fd);
-       return sr_source_remove(fd);
-#endif
+       unsigned int i;
+
+       for (i = 0; i < serial->event_set->count; i++)
+               if (sr_session_source_remove_pollfd(&serial->pollfds[i]) != SR_OK)
+                       return SR_ERR;
+
+       g_free(serial->pollfds);
+       sp_free_event_set(serial->event_set);
+
+       serial->pollfds = NULL;
+       serial->event_set = NULL;
+
+       return SR_OK;
 }