]> sigrok.org Git - libsigrok.git/blobdiff - hardware/asix-sigma/asix-sigma.c
asix-sigma: Pull out cluster decoding
[libsigrok.git] / hardware / asix-sigma / asix-sigma.c
index 64ebcbb8505778c8dd1904ba5c6c90aa3a6e4c38..d30e1a06bda33d92d416651bf2120cdd1f97a545 100644 (file)
@@ -829,7 +829,7 @@ static int config_set(int id, GVariant *data, const struct sr_dev_inst *sdi,
 {
        struct dev_context *devc;
        uint64_t num_samples;
-       int ret;
+       int ret = 0;
 
        (void)cg;
 
@@ -899,27 +899,29 @@ static int config_list(int key, GVariant **data, const struct sr_dev_inst *sdi,
 }
 
 /* Software trigger to determine exact trigger position. */
-static int get_trigger_offset(uint16_t *samples, uint16_t last_sample,
+static int get_trigger_offset(uint8_t *samples, uint16_t last_sample,
                              struct sigma_trigger *t)
 {
        int i;
+       uint16_t sample = 0;
 
        for (i = 0; i < 8; ++i) {
                if (i > 0)
-                       last_sample = samples[i-1];
+                       last_sample = sample;
+               sample = samples[2 * i] | (samples[2 * i + 1] << 8);
 
                /* Simple triggers. */
-               if ((samples[i] & t->simplemask) != t->simplevalue)
+               if ((sample & t->simplemask) != t->simplevalue)
                        continue;
 
                /* Rising edge. */
-               if ((last_sample & t->risingmask) != 0 || (samples[i] &
-                   t->risingmask) != t->risingmask)
+               if (((last_sample & t->risingmask) != 0) ||
+                   ((sample & t->risingmask) != t->risingmask))
                        continue;
 
                /* Falling edge. */
                if ((last_sample & t->fallingmask) != t->fallingmask ||
-                   (samples[i] & t->fallingmask) != 0)
+                   (sample & t->fallingmask) != 0)
                        continue;
 
                break;
@@ -938,6 +940,104 @@ static uint16_t sigma_dram_cluster_ts(struct sigma_dram_cluster *cluster)
        return (cluster->timestamp_hi << 8) | cluster->timestamp_lo;
 }
 
+static void sigma_decode_dram_cluster(struct sigma_dram_cluster *dram_cluster,
+                                     unsigned int events_in_cluster,
+                                     struct sr_dev_inst *sdi)
+{
+       struct dev_context *devc = sdi->priv;
+       struct sigma_state *ss = &devc->state;
+       struct sr_datafeed_packet packet;
+       struct sr_datafeed_logic logic;
+       uint16_t tsdiff, ts;
+       uint8_t samples[2048];
+       unsigned int i;
+
+       int triggerts = -1;
+
+       ts = sigma_dram_cluster_ts(dram_cluster);
+       tsdiff = ts - ss->lastts;
+       ss->lastts = ts;
+
+       packet.type = SR_DF_LOGIC;
+       packet.payload = &logic;
+       logic.unitsize = 2;
+       logic.data = samples;
+
+       /*
+        * First of all, send Sigrok a copy of the last sample from
+        * previous cluster as many times as needed to make up for
+        * the differential characteristics of data we get from the
+        * Sigma. Sigrok needs one sample of data per period.
+        *
+        * One DRAM cluster contains a timestamp and seven samples,
+        * the units of timestamp are "devc->period_ps" , the first
+        * sample in the cluster happens at the time of the timestamp
+        * and the remaining samples happen at timestamp +1...+6 .
+        */
+       for (ts = 0; ts < tsdiff - (EVENTS_PER_CLUSTER - 1); ts++) {
+               i = ts % 1024;
+               samples[2 * i + 0] = ss->lastsample & 0xff;
+               samples[2 * i + 1] = ss->lastsample >> 8;
+
+               /*
+                * If we have 1024 samples ready or we're at the
+                * end of submitting the padding samples, submit
+                * the packet to Sigrok.
+                */
+               if ((i == 1023) || (ts == (tsdiff - EVENTS_PER_CLUSTER))) {
+                       logic.length = (i + 1) * logic.unitsize;
+                       sr_session_send(devc->cb_data, &packet);
+               }
+       }
+
+       /*
+        * Parse the samples in current cluster and prepare them
+        * to be submitted to Sigrok.
+        */
+       for (i = 0; i < events_in_cluster; i++) {
+               samples[2 * i + 1] = dram_cluster->samples[i].sample_lo;
+               samples[2 * i + 0] = dram_cluster->samples[i].sample_hi;
+       }
+
+       /* Send data up to trigger point (if triggered). */
+       int trigger_offset = 0;
+       if ((int)i == triggerts) {
+               /*
+                * Trigger is not always accurate to sample because of
+                * pipeline delay. However, it always triggers before
+                * the actual event. We therefore look at the next
+                * samples to pinpoint the exact position of the trigger.
+                */
+               trigger_offset = get_trigger_offset(samples,
+                                       ss->lastsample, &devc->trigger);
+
+               if (trigger_offset > 0) {
+                       packet.type = SR_DF_LOGIC;
+                       logic.length = trigger_offset * logic.unitsize;
+                       sr_session_send(devc->cb_data, &packet);
+                       events_in_cluster -= trigger_offset;
+               }
+
+               /* Only send trigger if explicitly enabled. */
+               if (devc->use_triggers) {
+                       packet.type = SR_DF_TRIGGER;
+                       sr_session_send(devc->cb_data, &packet);
+               }
+       }
+
+       if (events_in_cluster > 0) {
+               packet.type = SR_DF_LOGIC;
+               logic.length = events_in_cluster * logic.unitsize;
+               logic.data = samples + (trigger_offset * logic.unitsize);
+               sr_session_send(devc->cb_data, &packet);
+       }
+
+       ss->lastsample =
+               samples[2 * (events_in_cluster - 1) + 0] |
+               (samples[2 * (events_in_cluster - 1) + 1] << 8);
+
+}
+
 /*
  * Decode chunk of 1024 bytes, 64 clusters, 7 events per cluster.
  * Each event is 20ns apart, and can contain multiple samples.
@@ -947,23 +1047,16 @@ static uint16_t sigma_dram_cluster_ts(struct sigma_dram_cluster *cluster)
  * For 50 MHz and below, events contain one sample for each channel,
  * spread 20 ns apart.
  */
-static int decode_chunk_ts(struct sigma_dram_line *dram_line, uint16_t *lastts,
-                          uint16_t *lastsample, int triggerpos,
-                          uint16_t limit_chunk, void *cb_data)
+static int decode_chunk_ts(struct sigma_dram_line *dram_line, int triggerpos,
+                          uint16_t events_in_line, void *cb_data)
 {
-       uint8_t *buf = (uint8_t *)dram_line;
        struct sigma_dram_cluster *dram_cluster;
        struct sr_dev_inst *sdi = cb_data;
        struct dev_context *devc = sdi->priv;
-       uint16_t tsdiff, ts;
-       uint16_t samples[65536 * devc->samples_per_event];
-       struct sr_datafeed_packet packet;
-       struct sr_datafeed_logic logic;
-       int i, j, k, l, numpad, tosend;
-       size_t n = 0, sent = 0;
-       int clustersize = EVENTS_PER_CLUSTER * devc->samples_per_event;
-       uint16_t *event;
-       uint16_t cur_sample;
+       unsigned int clusters_in_line =
+               (events_in_line + (EVENTS_PER_CLUSTER - 1)) / EVENTS_PER_CLUSTER;
+       unsigned int events_in_cluster;
+       unsigned int i;
        int triggerts = -1;
 
        /* Check if trigger is in this chunk. */
@@ -975,107 +1068,22 @@ static int decode_chunk_ts(struct sigma_dram_line *dram_line, uint16_t *lastts,
                        triggerpos = 0;
 
                /* Find in which cluster the trigger occured. */
-               triggerts = triggerpos / 7;
+               triggerts = triggerpos / EVENTS_PER_CLUSTER;
        }
 
-       /* For each ts. */
-       for (i = 0; i < 64; i++) {
+       /* For each full DRAM cluster. */
+       for (i = 0; i < clusters_in_line; i++) {
                dram_cluster = &dram_line->cluster[i];
-               ts = sigma_dram_cluster_ts(dram_cluster);
-               tsdiff = ts - *lastts;
-               *lastts = ts;
-
-               /* Decode partial chunk. */
-               if (limit_chunk && ts > limit_chunk)
-                       return SR_OK;
-
-               /* Pad last sample up to current point. */
-               numpad = tsdiff * devc->samples_per_event - clustersize;
-               if (numpad > 0) {
-                       for (j = 0; j < numpad; ++j)
-                               samples[j] = *lastsample;
-
-                       n = numpad;
-               }
-
-               /* Send samples between previous and this timestamp to sigrok. */
-               sent = 0;
-               while (sent < n) {
-                       tosend = MIN(2048, n - sent);
-
-                       packet.type = SR_DF_LOGIC;
-                       packet.payload = &logic;
-                       logic.length = tosend * sizeof(uint16_t);
-                       logic.unitsize = 2;
-                       logic.data = samples + sent;
-                       sr_session_send(devc->cb_data, &packet);
-
-                       sent += tosend;
-               }
-               n = 0;
 
-               event = (uint16_t *) &buf[i * 16 + 2];
-               cur_sample = 0;
-
-               /* For each event in cluster. */
-               for (j = 0; j < 7; ++j) {
-
-                       /* For each sample in event. */
-                       for (k = 0; k < devc->samples_per_event; ++k) {
-                               cur_sample = 0;
-
-                               /* For each channel. */
-                               for (l = 0; l < devc->num_channels; ++l)
-                                       cur_sample |= (!!(event[j] & (1 << (l *
-                                          devc->samples_per_event + k)))) << l;
-
-                               samples[n++] = cur_sample;
-                       }
-               }
-
-               /* Send data up to trigger point (if triggered). */
-               sent = 0;
-               if (i == triggerts) {
-                       /*
-                        * Trigger is not always accurate to sample because of
-                        * pipeline delay. However, it always triggers before
-                        * the actual event. We therefore look at the next
-                        * samples to pinpoint the exact position of the trigger.
-                        */
-                       tosend = get_trigger_offset(samples, *lastsample,
-                                                   &devc->trigger);
-
-                       if (tosend > 0) {
-                               packet.type = SR_DF_LOGIC;
-                               packet.payload = &logic;
-                               logic.length = tosend * sizeof(uint16_t);
-                               logic.unitsize = 2;
-                               logic.data = samples;
-                               sr_session_send(devc->cb_data, &packet);
-
-                               sent += tosend;
-                       }
-
-                       /* Only send trigger if explicitly enabled. */
-                       if (devc->use_triggers) {
-                               packet.type = SR_DF_TRIGGER;
-                               sr_session_send(devc->cb_data, &packet);
-                       }
-               }
-
-               /* Send rest of the chunk to sigrok. */
-               tosend = n - sent;
-
-               if (tosend > 0) {
-                       packet.type = SR_DF_LOGIC;
-                       packet.payload = &logic;
-                       logic.length = tosend * sizeof(uint16_t);
-                       logic.unitsize = 2;
-                       logic.data = samples + sent;
-                       sr_session_send(devc->cb_data, &packet);
+               /* The last cluster might not be full. */
+               if ((i == clusters_in_line - 1) &&
+                   (events_in_line % EVENTS_PER_CLUSTER)) {
+                       events_in_cluster = events_in_line % EVENTS_PER_CLUSTER;
+               } else {
+                       events_in_cluster = EVENTS_PER_CLUSTER;
                }
 
-               *lastsample = samples[n - 1];
+               sigma_decode_dram_cluster(dram_cluster, events_in_cluster, sdi);
        }
 
        return SR_OK;
@@ -1093,7 +1101,7 @@ static int download_capture(struct sr_dev_inst *sdi)
 
        uint32_t i;
        uint32_t dl_lines_total, dl_lines_curr, dl_lines_done;
-       uint32_t dl_trailing_events;
+       uint32_t dl_events_in_line = 64 * 7;
        uint32_t trg_line = ~0;
 
        dram_line = g_try_malloc0(chunks_per_read * sizeof(*dram_line));
@@ -1122,7 +1130,6 @@ static int download_capture(struct sr_dev_inst *sdi)
         * line can be only partial, containing less than 64 clusters.
         */
        dl_lines_total = (stoppos >> 9) + 1;
-       dl_trailing_events = stoppos & 0x1ff;
 
        dl_lines_done = 0;
 
@@ -1143,20 +1150,17 @@ static int download_capture(struct sr_dev_inst *sdi)
                }
 
                for (i = 0; i < dl_lines_curr; i++) {
-                       uint32_t dl_limit = 0;
                        int trigger_line = -1;
                        /* The last "DRAM line" can be only partially full. */
                        if (dl_lines_done + i == dl_lines_total - 1)
-                               dl_limit = dl_trailing_events;
+                               dl_events_in_line = stoppos & 0x1ff;
 
                        /* Test if the trigger happened on this line. */
                        if (dl_lines_done + i == trg_line)
                                trigger_line = trg_line;
 
-                       decode_chunk_ts(dram_line + i,
-                                       &devc->state.lastts,
-                                       &devc->state.lastsample,
-                                       trigger_line, dl_limit, sdi);
+                       decode_chunk_ts(dram_line + i, trigger_line,
+                                       dl_events_in_line, sdi);
                }
 
                dl_lines_done += dl_lines_curr;