]> sigrok.org Git - libsigrok.git/blobdiff - hardware/asix-sigma/asix-sigma.c
ASIX Sigma: Fix firmware loading bug.
[libsigrok.git] / hardware / asix-sigma / asix-sigma.c
index bcf96422ef99f585a1a6ed8e889b176779a895c5..3cd83d358a7b7a94e6228a1cb5e6ec6dc1ddca21 100644 (file)
@@ -23,6 +23,9 @@
  * ASIX Sigma Logic Analyzer Driver
  */
 
+#include "config.h"
+#include <glib.h>
+#include <glib/gstdio.h>
 #include <ftdi.h>
 #include <string.h>
 #include <zlib.h>
 static GSList *device_instances = NULL;
 
 static uint64_t supported_samplerates[] = {
-       KHZ(200),
-       KHZ(250),
-       KHZ(500),
-       MHZ(1),
-       MHZ(5),
-       MHZ(10),
-       MHZ(25),
-       MHZ(50),
-       MHZ(100),
-       MHZ(200),
+       SR_KHZ(200),
+       SR_KHZ(250),
+       SR_KHZ(500),
+       SR_MHZ(1),
+       SR_MHZ(5),
+       SR_MHZ(10),
+       SR_MHZ(25),
+       SR_MHZ(50),
+       SR_MHZ(100),
+       SR_MHZ(200),
        0,
 };
 
-static struct samplerates samplerates = {
-       KHZ(200),
-       MHZ(200),
-       0,
+static struct sr_samplerates samplerates = {
+       SR_KHZ(200),
+       SR_MHZ(200),
+       SR_HZ(0),
        supported_samplerates,
 };
 
 static int capabilities[] = {
-       HWCAP_LOGIC_ANALYZER,
-       HWCAP_SAMPLERATE,
-       HWCAP_CAPTURE_RATIO,
-       HWCAP_PROBECONFIG,
+       SR_HWCAP_LOGIC_ANALYZER,
+       SR_HWCAP_SAMPLERATE,
+       SR_HWCAP_CAPTURE_RATIO,
+       SR_HWCAP_PROBECONFIG,
 
-       HWCAP_LIMIT_MSEC,
+       SR_HWCAP_LIMIT_MSEC,
        0,
 };
 
@@ -293,7 +296,7 @@ static int sigma_write_trigger_lut(struct triggerlut *lut, struct sigma *sigma)
        sigma_write_register(WRITE_TRIGGER_SELECT0, (uint8_t *) &lut->params,
                             sizeof(lut->params), sigma);
 
-       return SIGROK_OK;
+       return SR_OK;
 }
 
 /* Generate the bitbang stream for programming the FPGA. */
@@ -311,9 +314,9 @@ static int bin2bitbang(const char *filename,
        int c, ret, bit, v;
        uint32_t imm = 0x3f6df2ab;
 
-       f = fopen(filename, "r");
+       f = g_fopen(filename, "rb");
        if (!f) {
-               g_warning("fopen(\"%s\", \"r\")", filename);
+               g_warning("g_fopen(\"%s\", \"rb\")", filename);
                return -1;
        }
 
@@ -384,9 +387,9 @@ static int bin2bitbang(const char *filename,
        return 0;
 }
 
-static int hw_init(char *deviceinfo)
+static int hw_init(const char *deviceinfo)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
        struct sigma *sigma = g_malloc(sizeof(struct sigma));
 
        deviceinfo = deviceinfo;
@@ -407,9 +410,10 @@ static int hw_init(char *deviceinfo)
        sigma->num_probes = 0;
        sigma->samples_per_event = 0;
        sigma->capture_ratio = 50;
+       sigma->use_triggers = 0;
 
        /* Register SIGMA device. */
-       sdi = sigrok_device_instance_new(0, ST_INITIALIZING,
+       sdi = sr_device_instance_new(0, SR_ST_INITIALIZING,
                        USB_VENDOR_NAME, USB_MODEL_NAME, USB_MODEL_VERSION);
        if (!sdi)
                goto free;
@@ -482,7 +486,7 @@ static int upload_firmware(int firmware_idx, struct sigma *sigma)
        if (-1 == bin2bitbang(firmware_path, &buf, &buf_size)) {
                g_warning("An error occured while reading the firmware: %s",
                          firmware_path);
-               return SIGROK_ERR;
+               return SR_ERR;
        }
 
        /* Upload firmare. */
@@ -493,7 +497,7 @@ static int upload_firmware(int firmware_idx, struct sigma *sigma)
        if ((ret = ftdi_set_bitmode(&sigma->ftdic, 0x00, BITMODE_RESET)) < 0) {
                g_warning("ftdi_set_bitmode failed: %s",
                          ftdi_get_error_string(&sigma->ftdic));
-               return SIGROK_ERR;
+               return SR_ERR;
        }
 
        ftdi_usb_purge_buffers(&sigma->ftdic);
@@ -510,22 +514,22 @@ static int upload_firmware(int firmware_idx, struct sigma *sigma)
        if (ret != 3 ||
            result[0] != 0xa6 || result[1] != 0x55 || result[2] != 0xaa) {
                g_warning("Configuration failed. Invalid reply received.");
-               return SIGROK_ERR;
+               return SR_ERR;
        }
 
        sigma->cur_firmware = firmware_idx;
 
-       return SIGROK_OK;
+       return SR_OK;
 }
 
 static int hw_opendev(int device_index)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
        struct sigma *sigma;
        int ret;
 
-       if (!(sdi = get_sigrok_device_instance(device_instances, device_index)))
-               return SIGROK_ERR;
+       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+               return SR_ERR;
 
        sigma = sdi->priv;
 
@@ -539,12 +543,12 @@ static int hw_opendev(int device_index)
                return 0;
        }
 
-       sdi->status = ST_ACTIVE;
+       sdi->status = SR_ST_ACTIVE;
 
-       return SIGROK_OK;
+       return SR_OK;
 }
 
-static int set_samplerate(struct sigrok_device_instance *sdi,
+static int set_samplerate(struct sr_device_instance *sdi,
                          uint64_t samplerate)
 {
        int i, ret;
@@ -555,17 +559,17 @@ static int set_samplerate(struct sigrok_device_instance *sdi,
                        break;
        }
        if (supported_samplerates[i] == 0)
-               return SIGROK_ERR_SAMPLERATE;
+               return SR_ERR_SAMPLERATE;
 
-       if (samplerate <= MHZ(50)) {
+       if (samplerate <= SR_MHZ(50)) {
                ret = upload_firmware(0, sigma);
                sigma->num_probes = 16;
        }
-       if (samplerate == MHZ(100)) {
+       if (samplerate == SR_MHZ(100)) {
                ret = upload_firmware(1, sigma);
                sigma->num_probes = 8;
        }
-       else if (samplerate == MHZ(200)) {
+       else if (samplerate == SR_MHZ(200)) {
                ret = upload_firmware(2, sigma);
                sigma->num_probes = 4;
        }
@@ -587,10 +591,10 @@ static int set_samplerate(struct sigrok_device_instance *sdi,
  * The Sigma supports complex triggers using boolean expressions, but this
  * has not been implemented yet.
  */
-static int configure_probes(struct sigrok_device_instance *sdi, GSList *probes)
+static int configure_probes(struct sr_device_instance *sdi, GSList *probes)
 {
        struct sigma *sigma = sdi->priv;
-       struct probe *probe;
+       struct sr_probe *probe;
        GSList *l;
        int trigger_set = 0;
        int probebit;
@@ -598,19 +602,19 @@ static int configure_probes(struct sigrok_device_instance *sdi, GSList *probes)
        memset(&sigma->trigger, 0, sizeof(struct sigma_trigger));
 
        for (l = probes; l; l = l->next) {
-               probe = (struct probe *)l->data;
+               probe = (struct sr_probe *)l->data;
                probebit = 1 << (probe->index - 1);
 
                if (!probe->enabled || !probe->trigger)
                        continue;
 
-               if (sigma->cur_samplerate >= MHZ(100)) {
+               if (sigma->cur_samplerate >= SR_MHZ(100)) {
                        /* Fast trigger support. */
                        if (trigger_set) {
                                g_warning("Asix Sigma only supports a single "
                                                "pin trigger in 100 and 200 "
                                                "MHz mode.");
-                               return SIGROK_ERR;
+                               return SR_ERR;
                        }
                        if (probe->trigger[0] == 'f')
                                sigma->trigger.fallingmask |= probebit;
@@ -620,7 +624,7 @@ static int configure_probes(struct sigrok_device_instance *sdi, GSList *probes)
                                g_warning("Asix Sigma only supports "
                                          "rising/falling trigger in 100 "
                                          "and 200 MHz mode.");
-                               return SIGROK_ERR;
+                               return SR_ERR;
                        }
 
                        ++trigger_set;
@@ -651,40 +655,43 @@ static int configure_probes(struct sigrok_device_instance *sdi, GSList *probes)
                        if (trigger_set > 1) {
                                g_warning("Asix Sigma only supports 1 rising/"
                                          "falling triggers.");
-                               return SIGROK_ERR;
+                               return SR_ERR;
                        }
                }
+
+               if (trigger_set)
+                       sigma->use_triggers = 1;
        }
 
-       return SIGROK_OK;
+       return SR_OK;
 }
 
 static void hw_closedev(int device_index)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
        struct sigma *sigma;
 
-       if ((sdi = get_sigrok_device_instance(device_instances, device_index)))
+       if ((sdi = sr_get_device_instance(device_instances, device_index)))
        {
                sigma = sdi->priv;
-               if (sdi->status == ST_ACTIVE)
+               if (sdi->status == SR_ST_ACTIVE)
                        ftdi_usb_close(&sigma->ftdic);
 
-               sdi->status = ST_INACTIVE;
+               sdi->status = SR_ST_INACTIVE;
        }
 }
 
 static void hw_cleanup(void)
 {
        GSList *l;
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
 
        /* Properly close all devices. */
        for (l = device_instances; l; l = l->next) {
                sdi = l->data;
                if (sdi->priv != NULL)
                        free(sdi->priv);
-               sigrok_device_instance_free(sdi);
+               sr_device_instance_free(sdi);
        }
        g_slist_free(device_instances);
        device_instances = NULL;
@@ -692,11 +699,11 @@ static void hw_cleanup(void)
 
 static void *hw_get_device_info(int device_index, int device_info_id)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
        struct sigma *sigma;
        void *info = NULL;
 
-       if (!(sdi = get_sigrok_device_instance(device_instances, device_index))) {
+       if (!(sdi = sr_get_device_instance(device_instances, device_index))) {
                fprintf(stderr, "It's NULL.\n");
                return NULL;
        }
@@ -704,19 +711,19 @@ static void *hw_get_device_info(int device_index, int device_info_id)
        sigma = sdi->priv;
 
        switch (device_info_id) {
-       case DI_INSTANCE:
+       case SR_DI_INSTANCE:
                info = sdi;
                break;
-       case DI_NUM_PROBES:
+       case SR_DI_NUM_PROBES:
                info = GINT_TO_POINTER(16);
                break;
-       case DI_SAMPLERATES:
+       case SR_DI_SAMPLERATES:
                info = &samplerates;
                break;
-       case DI_TRIGGER_TYPES:
+       case SR_DI_TRIGGER_TYPES:
                info = (char *)TRIGGER_TYPES;
                break;
-       case DI_CUR_SAMPLERATE:
+       case SR_DI_CUR_SAMPLERATE:
                info = &sigma->cur_samplerate;
                break;
        }
@@ -726,13 +733,13 @@ static void *hw_get_device_info(int device_index, int device_info_id)
 
 static int hw_get_status(int device_index)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
 
-       sdi = get_sigrok_device_instance(device_instances, device_index);
+       sdi = sr_get_device_instance(device_instances, device_index);
        if (sdi)
                return sdi->status;
        else
-               return ST_NOT_FOUND;
+               return SR_ST_NOT_FOUND;
 }
 
 static int *hw_get_capabilities(void)
@@ -742,27 +749,33 @@ static int *hw_get_capabilities(void)
 
 static int hw_set_configuration(int device_index, int capability, void *value)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
        struct sigma *sigma;
        int ret;
 
-       if (!(sdi = get_sigrok_device_instance(device_instances, device_index)))
-               return SIGROK_ERR;
+       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+               return SR_ERR;
 
        sigma = sdi->priv;
 
-       if (capability == HWCAP_SAMPLERATE) {
+       if (capability == SR_HWCAP_SAMPLERATE) {
                ret = set_samplerate(sdi, *(uint64_t*) value);
-       } else if (capability == HWCAP_PROBECONFIG) {
+       } else if (capability == SR_HWCAP_PROBECONFIG) {
                ret = configure_probes(sdi, value);
-       } else if (capability == HWCAP_LIMIT_MSEC) {
-               sigma->limit_msec = strtoull(value, NULL, 10);
-               ret = SIGROK_OK;
-       } else if (capability == HWCAP_CAPTURE_RATIO) {
-               sigma->capture_ratio = strtoull(value, NULL, 10);
-               ret = SIGROK_OK;
+       } else if (capability == SR_HWCAP_LIMIT_MSEC) {
+               sigma->limit_msec = *(uint64_t*) value;
+               if (sigma->limit_msec > 0)
+                       ret = SR_OK;
+               else
+                       ret = SR_ERR;
+       } else if (capability == SR_HWCAP_CAPTURE_RATIO) {
+               sigma->capture_ratio = *(uint64_t*) value;
+               if (sigma->capture_ratio < 0 || sigma->capture_ratio > 100)
+                       ret = SR_ERR;
+               else
+                       ret = SR_OK;
        } else {
-               ret = SIGROK_ERR;
+               ret = SR_ERR;
        }
 
        return ret;
@@ -812,11 +825,11 @@ static int decode_chunk_ts(uint8_t *buf, uint16_t *lastts,
                           uint16_t *lastsample, int triggerpos,
                           uint16_t limit_chunk, void *user_data)
 {
-       struct sigrok_device_instance *sdi = user_data;
+       struct sr_device_instance *sdi = user_data;
        struct sigma *sigma = sdi->priv;
        uint16_t tsdiff, ts;
        uint16_t samples[65536 * sigma->samples_per_event];
-       struct datafeed_packet packet;
+       struct sr_datafeed_packet packet;
        int i, j, k, l, numpad, tosend;
        size_t n = 0, sent = 0;
        int clustersize = EVENTS_PER_CLUSTER * sigma->samples_per_event;
@@ -826,7 +839,7 @@ static int decode_chunk_ts(uint8_t *buf, uint16_t *lastts,
 
        /* Check if trigger is in this chunk. */
        if (triggerpos != -1) {
-               if (sigma->cur_samplerate <= MHZ(50))
+               if (sigma->cur_samplerate <= SR_MHZ(50))
                        triggerpos -= EVENTS_PER_CLUSTER - 1;
 
                if (triggerpos < 0)
@@ -844,7 +857,7 @@ static int decode_chunk_ts(uint8_t *buf, uint16_t *lastts,
 
                /* Decode partial chunk. */
                if (limit_chunk && ts > limit_chunk)
-                       return SIGROK_OK;
+                       return SR_OK;
 
                /* Pad last sample up to current point. */
                numpad = tsdiff * sigma->samples_per_event - clustersize;
@@ -860,11 +873,11 @@ static int decode_chunk_ts(uint8_t *buf, uint16_t *lastts,
                while (sent < n) {
                        tosend = MIN(2048, n - sent);
 
-                       packet.type = DF_LOGIC;
+                       packet.type = SR_DF_LOGIC;
                        packet.length = tosend * sizeof(uint16_t);
                        packet.unitsize = 2;
                        packet.payload = samples + sent;
-                       session_bus(sigma->session_id, &packet);
+                       sr_session_bus(sigma->session_id, &packet);
 
                        sent += tosend;
                }
@@ -904,47 +917,50 @@ static int decode_chunk_ts(uint8_t *buf, uint16_t *lastts,
                                                    &sigma->trigger);
 
                        if (tosend > 0) {
-                               packet.type = DF_LOGIC;
+                               packet.type = SR_DF_LOGIC;
                                packet.length = tosend * sizeof(uint16_t);
                                packet.unitsize = 2;
                                packet.payload = samples;
-                               session_bus(sigma->session_id, &packet);
+                               sr_session_bus(sigma->session_id, &packet);
 
                                sent += tosend;
                        }
 
-                       packet.type = DF_TRIGGER;
-                       packet.length = 0;
-                       packet.payload = 0;
-                       session_bus(sigma->session_id, &packet);
+                       /* Only send trigger if explicitly enabled. */
+                       if (sigma->use_triggers) {
+                               packet.type = SR_DF_TRIGGER;
+                               packet.length = 0;
+                               packet.payload = 0;
+                               sr_session_bus(sigma->session_id, &packet);
+                       }
                }
 
                /* Send rest of the chunk to sigrok. */
                tosend = n - sent;
 
                if (tosend > 0) {
-                       packet.type = DF_LOGIC;
+                       packet.type = SR_DF_LOGIC;
                        packet.length = tosend * sizeof(uint16_t);
                        packet.unitsize = 2;
                        packet.payload = samples + sent;
-                       session_bus(sigma->session_id, &packet);
+                       sr_session_bus(sigma->session_id, &packet);
                }
 
                *lastsample = samples[n - 1];
        }
 
-       return SIGROK_OK;
+       return SR_OK;
 }
 
 static int receive_data(int fd, int revents, void *user_data)
 {
-       struct sigrok_device_instance *sdi = user_data;
+       struct sr_device_instance *sdi = user_data;
        struct sigma *sigma = sdi->priv;
-       struct datafeed_packet packet;
+       struct sr_datafeed_packet packet;
        const int chunks_per_read = 32;
        unsigned char buf[chunks_per_read * CHUNK_SIZE];
        int bufsz, numchunks, i, newchunks;
-       uint32_t running_msec;
+       uint64_t running_msec;
        struct timeval tv;
 
        fd = fd;
@@ -972,9 +988,9 @@ static int receive_data(int fd, int revents, void *user_data)
        } else if (sigma->state.state == SIGMA_DOWNLOAD) {
                if (sigma->state.chunks_downloaded >= numchunks) {
                        /* End of samples. */
-                       packet.type = DF_END;
+                       packet.type = SR_DF_END;
                        packet.length = 0;
-                       session_bus(sigma->session_id, &packet);
+                       sr_session_bus(sigma->session_id, &packet);
 
                        sigma->state.state = SIGMA_IDLE;
 
@@ -1179,38 +1195,39 @@ static int build_basic_trigger(struct triggerlut *lut, struct sigma *sigma)
        /* Triggertype: event. */
        lut->params.selres = 3;
 
-       return SIGROK_OK;
+       return SR_OK;
 }
 
 static int hw_start_acquisition(int device_index, gpointer session_device_id)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
        struct sigma *sigma;
-       struct datafeed_packet packet;
-       struct datafeed_header header;
+       struct sr_datafeed_packet packet;
+       struct sr_datafeed_header header;
        struct clockselect_50 clockselect;
-       int frac;
+       int frac, triggerpin, ret;
        uint8_t triggerselect;
        struct triggerinout triggerinout_conf;
        struct triggerlut lut;
-       int triggerpin;
 
        session_device_id = session_device_id;
 
-       if (!(sdi = get_sigrok_device_instance(device_instances, device_index)))
-               return SIGROK_ERR;
+       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
+               return SR_ERR;
 
        sigma = sdi->priv;
 
-       /* If the samplerate has not been set, default to 50 MHz. */
-       if (sigma->cur_firmware == -1)
-               set_samplerate(sdi, MHZ(50));
+       /* If the samplerate has not been set, default to 200 KHz. */
+       if (sigma->cur_firmware == -1) {
+               if ((ret = set_samplerate(sdi, SR_KHZ(200))) != SR_OK)
+                       return ret;
+       }
 
        /* Enter trigger programming mode. */
        sigma_set_register(WRITE_TRIGGER_SELECT1, 0x20, sigma);
 
        /* 100 and 200 MHz mode. */
-       if (sigma->cur_samplerate >= MHZ(100)) {
+       if (sigma->cur_samplerate >= SR_MHZ(100)) {
                sigma_set_register(WRITE_TRIGGER_SELECT1, 0x81, sigma);
 
                /* Find which pin to trigger on from mask. */
@@ -1227,7 +1244,7 @@ static int hw_start_acquisition(int device_index, gpointer session_device_id)
                        triggerselect |= 1 << 3;
 
        /* All other modes. */
-       } else if (sigma->cur_samplerate <= MHZ(50)) {
+       } else if (sigma->cur_samplerate <= SR_MHZ(50)) {
                build_basic_trigger(&lut, sigma);
 
                sigma_write_trigger_lut(&lut, sigma);
@@ -1248,10 +1265,10 @@ static int hw_start_acquisition(int device_index, gpointer session_device_id)
        sigma_set_register(WRITE_TRIGGER_SELECT1, triggerselect, sigma);
 
        /* Set clock select register. */
-       if (sigma->cur_samplerate == MHZ(200))
+       if (sigma->cur_samplerate == SR_MHZ(200))
                /* Enable 4 probes. */
                sigma_set_register(WRITE_CLOCK_SELECT, 0xf0, sigma);
-       else if (sigma->cur_samplerate == MHZ(100))
+       else if (sigma->cur_samplerate == SR_MHZ(100))
                /* Enable 8 probes. */
                sigma_set_register(WRITE_CLOCK_SELECT, 0x00, sigma);
        else {
@@ -1259,7 +1276,7 @@ static int hw_start_acquisition(int device_index, gpointer session_device_id)
                 * 50 MHz mode (or fraction thereof). Any fraction down to
                 * 50 MHz / 256 can be used, but is not supported by sigrok API.
                 */
-               frac = MHZ(50) / sigma->cur_samplerate - 1;
+               frac = SR_MHZ(50) / sigma->cur_samplerate - 1;
 
                clockselect.async = 0;
                clockselect.fraction = frac;
@@ -1281,32 +1298,32 @@ static int hw_start_acquisition(int device_index, gpointer session_device_id)
        sigma->session_id = session_device_id;
 
        /* Send header packet to the session bus. */
-       packet.type = DF_HEADER;
-       packet.length = sizeof(struct datafeed_header);
+       packet.type = SR_DF_HEADER;
+       packet.length = sizeof(struct sr_datafeed_header);
        packet.payload = &header;
        header.feed_version = 1;
        gettimeofday(&header.starttime, NULL);
        header.samplerate = sigma->cur_samplerate;
-       header.protocol_id = PROTO_RAW;
+       header.protocol_id = SR_PROTO_RAW;
        header.num_logic_probes = sigma->num_probes;
        header.num_analog_probes = 0;
-       session_bus(session_device_id, &packet);
+       sr_session_bus(session_device_id, &packet);
 
        /* Add capture source. */
-       source_add(0, G_IO_IN, 10, receive_data, sdi);
+       sr_source_add(0, G_IO_IN, 10, receive_data, sdi);
 
        sigma->state.state = SIGMA_CAPTURE;
 
-       return SIGROK_OK;
+       return SR_OK;
 }
 
 static void hw_stop_acquisition(int device_index, gpointer session_device_id)
 {
-       struct sigrok_device_instance *sdi;
+       struct sr_device_instance *sdi;
        struct sigma *sigma;
        uint8_t modestatus;
 
-       if (!(sdi = get_sigrok_device_instance(device_instances, device_index)))
+       if (!(sdi = sr_get_device_instance(device_instances, device_index)))
                return;
 
        sigma = sdi->priv;
@@ -1335,8 +1352,9 @@ static void hw_stop_acquisition(int device_index, gpointer session_device_id)
        sigma->state.state = SIGMA_DOWNLOAD;
 }
 
-struct device_plugin asix_sigma_plugin_info = {
+struct sr_device_plugin asix_sigma_plugin_info = {
        "asix-sigma",
+       "ASIX SIGMA",
        1,
        hw_init,
        hw_cleanup,