/**
* Create a new device.
*
- * TODO: num_probes should be uint16_t.
+ * The device is added to the (libsigrok-internal) list of devices, but
+ * additionally a pointer to the newly created device is also returned.
+ *
+ * The device has no probes attached to it yet after this call. You can
+ * use sr_device_probe_add() to add one or more probes.
+ *
* TODO: Should return int, so that we can return SR_OK, SR_ERR_* etc.
*
* It is the caller's responsibility to g_free() the allocated memory when
* @param plugin TODO.
* If 'plugin' is NULL, the created device is a "virtual" one.
* @param plugin_index TODO
- * @param num_probes The number of probes (>= 1) this device has.
- * TODO: 0 allowed?
*
* @return Pointer to the newly allocated device, or NULL upon errors.
*/
/* TODO: Check if plugin_index valid? */
- /* TODO: Check if num_probes valid? */
-
if (!(device = g_try_malloc0(sizeof(struct sr_device)))) {
sr_err("dev: %s: device malloc failed", __func__);
return NULL;
}
/* If the probe has a name, remove it. */
- if (p->name) {
- g_free(p->name);
- p->name = NULL;
- }
+ g_free(p->name);
+ p->name = NULL;
/* If the probe has a trigger, remove it. */
- if (p->trigger) {
- g_free(p->trigger);
- p->trigger = NULL;
- }
+ g_free(p->trigger);
+ p->trigger = NULL;
return SR_OK;
}
p->index = probenum;
p->enabled = TRUE;
- if (name) {
- p->name = g_strdup(name);
- }
+ p->name = g_strdup(name);
p->trigger = NULL;
device->probes = g_slist_append(device->probes, p);
/* TODO: Sanity check on 'name'. */
/* If the probe already has a name, kill it first. */
- if (p->name)
- g_free(p->name);
+ g_free(p->name);
p->name = g_strdup(name);
for (pnum = 1; pnum <= g_slist_length(device->probes); pnum++) {
p = sr_device_probe_find(device, pnum);
/* TODO: Silently ignore probes which cannot be found? */
- if (p && p->trigger) {
+ if (p) {
g_free(p->trigger);
p->trigger = NULL;
}
}
/* If the probe already has a trigger, kill it first. */
- if (p->trigger)
- g_free(p->trigger);
+ g_free(p->trigger);
p->trigger = g_strdup(trigger);