]> sigrok.org Git - libsigrok.git/blobdiff - bindings/cxx/classes.cpp
C++: Fix recursion loop in PacketPayload::get_shared_pointer().
[libsigrok.git] / bindings / cxx / classes.cpp
index 2ae0f29839b9256c19572f8fbece25cdf23a8550..c515a303104d233986f13aebf812ac28acf265db 100644 (file)
@@ -19,6 +19,8 @@
 
 #include "libsigrok/libsigrok.hpp"
 
+#include <sstream>
+
 namespace sigrok
 {
 
@@ -38,16 +40,15 @@ static const char *valid_string(const char *input)
                return "";
 }
 
-/** Helper function to convert between map<string, string> and GHashTable */
-
-static GHashTable *map_to_hash(map<string, string> input)
+/** Helper function to convert between map<string, VariantBase> and GHashTable */
+static GHashTable *map_to_hash_variant(map<string, Glib::VariantBase> input)
 {
        auto output = g_hash_table_new_full(
-               g_str_hash, g_str_equal, g_free, g_free);
+               g_str_hash, g_str_equal, g_free, (GDestroyNotify) g_variant_unref);
        for (auto entry : input)
                g_hash_table_insert(output,
                        g_strdup(entry.first.c_str()),
-                       g_strdup(entry.second.c_str()));
+                       entry.second.gobj_copy());
     return output;
 }
 
@@ -70,23 +71,25 @@ shared_ptr<Context> Context::create()
 }
 
 Context::Context() :
+       UserOwned(structure),
        session(NULL)
 {
        check(sr_init(&structure));
+
        struct sr_dev_driver **driver_list = sr_driver_list();
        if (driver_list)
                for (int i = 0; driver_list[i]; i++)
                        drivers[driver_list[i]->name] =
                                new Driver(driver_list[i]);
-       struct sr_input_format **input_list = sr_input_list();
+       const struct sr_input_module **input_list = sr_input_list();
        if (input_list)
                for (int i = 0; input_list[i]; i++)
-                       input_formats[input_list[i]->id] =
+                       input_formats[sr_input_id_get(input_list[i])] =
                                new InputFormat(input_list[i]);
-       struct sr_output_format **output_list = sr_output_list();
+       const struct sr_output_module **output_list = sr_output_list();
        if (output_list)
                for (int i = 0; output_list[i]; i++)
-                       output_formats[output_list[i]->id] =
+                       output_formats[sr_output_id_get(output_list[i])] =
                                new OutputFormat(output_list[i]);
 }
 
@@ -107,8 +110,7 @@ map<string, shared_ptr<Driver>> Context::get_drivers()
        {
                auto name = entry.first;
                auto driver = entry.second;
-               result[name] = static_pointer_cast<Driver>(
-                       driver->get_shared_pointer(this));
+               result[name] = driver->get_shared_pointer(this);
        }
        return result;
 }
@@ -120,8 +122,7 @@ map<string, shared_ptr<InputFormat>> Context::get_input_formats()
        {
                auto name = entry.first;
                auto input_format = entry.second;
-               result[name] = static_pointer_cast<InputFormat>(
-                       input_format->get_shared_pointer(this));
+               result[name] = input_format->get_shared_pointer(this);
        }
        return result;
 }
@@ -133,8 +134,7 @@ map<string, shared_ptr<OutputFormat>> Context::get_output_formats()
        {
                auto name = entry.first;
                auto output_format = entry.second;
-               result[name] = static_pointer_cast<OutputFormat>(
-                       output_format->get_shared_pointer(this));
+               result[name] = output_format->get_shared_pointer(this);
        }
        return result;
 }
@@ -225,8 +225,29 @@ shared_ptr<Trigger> Context::create_trigger(string name)
                new Trigger(shared_from_this(), name), Trigger::Deleter());
 }
 
+shared_ptr<Input> Context::open_file(string filename)
+{
+       const struct sr_input *input;
+
+       check( sr_input_scan_file(filename.c_str(), &input));
+       return shared_ptr<Input>(
+               new Input(shared_from_this(), input), Input::Deleter());
+}
+
+shared_ptr<Input> Context::open_stream(string header)
+{
+       const struct sr_input *input;
+
+       auto gstr = g_string_new(header.c_str());
+       auto ret = sr_input_scan_buffer(gstr, &input);
+       g_string_free(gstr, true);
+       check(ret);
+       return shared_ptr<Input>(
+               new Input(shared_from_this(), input), Input::Deleter());
+}
+
 Driver::Driver(struct sr_dev_driver *structure) :
-       StructureWrapper<Context, struct sr_dev_driver>(structure),
+       ParentOwned(structure),
        initialized(false)
 {
 }
@@ -293,8 +314,7 @@ vector<shared_ptr<HardwareDevice>> Driver::scan(
        /* Create list of shared pointers to device instances for return. */
        vector<shared_ptr<HardwareDevice>> result;
        for (auto device : devices)
-               result.push_back(static_pointer_cast<HardwareDevice>(
-                       device->get_shared_pointer(parent)));
+               result.push_back(device->get_shared_pointer(parent));
        return result;
 }
 
@@ -328,30 +348,52 @@ void Configurable::config_set(const ConfigKey *key, Glib::VariantBase value)
                key->get_id(), value.gobj()));
 }
 
-Glib::VariantBase Configurable::config_list(const ConfigKey *key)
+Glib::VariantContainerBase Configurable::config_list(const ConfigKey *key)
 {
        GVariant *data;
        check(sr_config_list(
                config_driver, config_sdi, config_channel_group,
                key->get_id(), &data));
-       return Glib::VariantBase(data);
+       return Glib::VariantContainerBase(data);
 }
 
 Device::Device(struct sr_dev_inst *structure) :
        Configurable(structure->driver, structure, NULL),
-       StructureWrapper<Context, struct sr_dev_inst>(structure)
+       structure(structure)
 {
        for (GSList *entry = structure->channels; entry; entry = entry->next)
        {
                auto channel = (struct sr_channel *) entry->data;
                channels[channel] = new Channel(channel);
        }
+
+       for (GSList *entry = structure->channel_groups; entry; entry = entry->next)
+       {
+               auto group = (struct sr_channel_group *) entry->data;
+               channel_groups[group->name] = new ChannelGroup(this, group);
+       }
 }
 
 Device::~Device()
 {
        for (auto entry : channels)
                delete entry.second;
+       for (auto entry : channel_groups)
+               delete entry.second;
+}
+
+string Device::get_description()
+{
+       ostringstream s;
+
+       vector<string> parts =
+               {get_vendor(), get_model(), get_version()};
+
+       for (string part : parts)
+               if (part.length() > 0)
+                       s << part;
+
+       return s.str();
 }
 
 string Device::get_vendor()
@@ -373,15 +415,26 @@ vector<shared_ptr<Channel>> Device::get_channels()
 {
        vector<shared_ptr<Channel>> result;
        for (auto entry : channels)
-               result.push_back(static_pointer_cast<Channel>(
-                       entry.second->get_shared_pointer(this)));
+               result.push_back(entry.second->get_shared_pointer(get_shared_from_this()));
        return result;
 }
 
 shared_ptr<Channel> Device::get_channel(struct sr_channel *ptr)
 {
-       return static_pointer_cast<Channel>(
-               channels[ptr]->get_shared_pointer(this));
+       return channels[ptr]->get_shared_pointer(get_shared_from_this());
+}
+
+map<string, shared_ptr<ChannelGroup>>
+Device::get_channel_groups()
+{
+       map<string, shared_ptr<ChannelGroup>> result;
+       for (auto entry: channel_groups)
+       {
+               auto name = entry.first;
+               auto channel_group = entry.second;
+               result[name] = channel_group->get_shared_pointer(get_shared_from_this());
+       }
+       return result;
 }
 
 void Device::open()
@@ -395,43 +448,28 @@ void Device::close()
 }
 
 HardwareDevice::HardwareDevice(Driver *driver, struct sr_dev_inst *structure) :
+       ParentOwned(structure),
        Device(structure),
        driver(driver)
 {
-       for (GSList *entry = structure->channel_groups; entry; entry = entry->next)
-       {
-               auto group = (struct sr_channel_group *) entry->data;
-               channel_groups[group->name] = new ChannelGroup(this, group);
-       }
 }
 
 HardwareDevice::~HardwareDevice()
 {
-       for (auto entry : channel_groups)
-               delete entry.second;
 }
 
-shared_ptr<Driver> HardwareDevice::get_driver()
+shared_ptr<Device> HardwareDevice::get_shared_from_this()
 {
-       return static_pointer_cast<Driver>(driver->get_shared_pointer(parent));
+       return static_pointer_cast<Device>(shared_from_this());
 }
 
-map<string, shared_ptr<ChannelGroup>>
-HardwareDevice::get_channel_groups()
+shared_ptr<Driver> HardwareDevice::get_driver()
 {
-       map<string, shared_ptr<ChannelGroup>> result;
-       for (auto entry: channel_groups)
-       {
-               auto name = entry.first;
-               auto channel_group = entry.second;
-               result[name] = static_pointer_cast<ChannelGroup>(
-                       channel_group->get_shared_pointer(this));
-       }
-       return result;
+       return driver->get_shared_pointer(parent);
 }
 
 Channel::Channel(struct sr_channel *structure) :
-       StructureWrapper<Device, struct sr_channel>(structure),
+       ParentOwned(structure),
        type(ChannelType::get(structure->type))
 {
 }
@@ -465,9 +503,14 @@ void Channel::set_enabled(bool value)
        check(sr_dev_channel_enable(parent->structure, structure->index, value));
 }
 
-ChannelGroup::ChannelGroup(HardwareDevice *device,
+unsigned int Channel::get_index()
+{
+       return structure->index;
+}
+
+ChannelGroup::ChannelGroup(Device *device,
                struct sr_channel_group *structure) :
-       StructureWrapper<HardwareDevice, struct sr_channel_group>(structure),
+       ParentOwned(structure),
        Configurable(device->structure->driver, device->structure, structure)
 {
        for (GSList *entry = structure->channels; entry; entry = entry->next)
@@ -487,13 +530,13 @@ vector<shared_ptr<Channel>> ChannelGroup::get_channels()
 {
        vector<shared_ptr<Channel>> result;
        for (auto channel : channels)
-               result.push_back(static_pointer_cast<Channel>(
-                       channel->get_shared_pointer(parent)));
+               result.push_back(channel->get_shared_pointer(parent));
        return result;
 }
 
 Trigger::Trigger(shared_ptr<Context> context, string name) : 
-       structure(sr_trigger_new(name.c_str())), context(context)
+       UserOwned(sr_trigger_new(name.c_str())),
+       context(context)
 {
        for (auto stage = structure->stages; stage; stage = stage->next)
                stages.push_back(new TriggerStage((struct sr_trigger_stage *) stage->data));
@@ -516,8 +559,7 @@ vector<shared_ptr<TriggerStage>> Trigger::get_stages()
 {
        vector<shared_ptr<TriggerStage>> result;
        for (auto stage : stages)
-               result.push_back(static_pointer_cast<TriggerStage>(
-                       stage->get_shared_pointer(this)));
+               result.push_back(stage->get_shared_pointer(this));
        return result;
 }
 
@@ -525,12 +567,11 @@ shared_ptr<TriggerStage> Trigger::add_stage()
 {
        auto stage = new TriggerStage(sr_trigger_stage_add(structure));
        stages.push_back(stage);
-       return static_pointer_cast<TriggerStage>(
-               stage->get_shared_pointer(this));
+       return stage->get_shared_pointer(this);
 }
 
 TriggerStage::TriggerStage(struct sr_trigger_stage *structure) : 
-       StructureWrapper<Trigger, struct sr_trigger_stage>(structure)
+       ParentOwned(structure)
 {
 }
 
@@ -549,8 +590,7 @@ vector<shared_ptr<TriggerMatch>> TriggerStage::get_matches()
 {
        vector<shared_ptr<TriggerMatch>> result;
        for (auto match : matches)
-               result.push_back(static_pointer_cast<TriggerMatch>(
-                       match->get_shared_pointer(this)));
+               result.push_back(match->get_shared_pointer(this));
        return result;
 }
 
@@ -567,7 +607,7 @@ void TriggerStage::add_match(shared_ptr<Channel> channel, const TriggerMatchType
 }
 
 TriggerMatch::TriggerMatch(struct sr_trigger_match *structure, shared_ptr<Channel> channel) :
-       StructureWrapper<TriggerStage, struct sr_trigger_match>(structure), channel(channel)
+       ParentOwned(structure), channel(channel)
 {
 }
 
@@ -653,6 +693,7 @@ EventSource::~EventSource()
 }
 
 Session::Session(shared_ptr<Context> context) :
+       UserOwned(structure),
        context(context), saving(false)
 {
        check(sr_session_new(&structure));
@@ -660,6 +701,7 @@ Session::Session(shared_ptr<Context> context) :
 }
 
 Session::Session(shared_ptr<Context> context, string filename) :
+       UserOwned(structure),
        context(context), saving(false)
 {
        check(sr_session_load(filename.c_str(), &structure));
@@ -691,9 +733,6 @@ vector<shared_ptr<Device>> Session::get_devices()
        for (GSList *dev = dev_list; dev; dev = dev->next)
        {
                auto sdi = (struct sr_dev_inst *) dev->data;
-               if (devices.count(sdi) == 0)
-                       devices[sdi] = shared_ptr<Device>(
-                               new Device(sdi), Device::Deleter());
                result.push_back(devices[sdi]);
        }
        return result;
@@ -728,7 +767,7 @@ void Session::begin_save(string filename)
        save_samplerate = 0;
 }
 
-void Session::append(shared_ptr<Device> device, shared_ptr<Packet> packet)
+void Session::append(shared_ptr<Packet> packet)
 {
        if (!saving)
                throw Error(SR_ERR);
@@ -755,8 +794,9 @@ void Session::append(shared_ptr<Device> device, shared_ptr<Packet> packet)
                        {
                                GVariant *samplerate;
 
-                               check(sr_config_get(device->structure->driver,
-                                       device->structure, NULL, SR_CONF_SAMPLERATE, &samplerate));
+                               check(sr_config_get(packet->device->structure->driver,
+                                       packet->device->structure, NULL, SR_CONF_SAMPLERATE,
+                                       &samplerate));
 
                                save_samplerate = g_variant_get_uint64(samplerate);
 
@@ -767,7 +807,7 @@ void Session::append(shared_ptr<Device> device, shared_ptr<Packet> packet)
                        {
                                vector<shared_ptr<Channel>> save_channels;
 
-                               for (auto channel : device->get_channels())
+                               for (auto channel : packet->device->get_channels())
                                        if (channel->structure->enabled &&
                                                        channel->structure->type == SR_CHANNEL_LOGIC)
                                                save_channels.push_back(channel);
@@ -800,6 +840,12 @@ void Session::append(shared_ptr<Device> device, shared_ptr<Packet> packet)
        }
 }
 
+void Session::append(void *data, size_t length, unsigned int unit_size)
+{
+       check(sr_session_append(structure, save_filename.c_str(),
+               (uint8_t *) data, unit_size, length));
+}
+
 static void datafeed_callback(const struct sr_dev_inst *sdi,
        const struct sr_datafeed_packet *pkt, void *cb_data)
 {
@@ -895,7 +941,7 @@ void Session::set_trigger(shared_ptr<Trigger> trigger)
 
 Packet::Packet(shared_ptr<Device> device,
        const struct sr_datafeed_packet *structure) :
-       structure(structure),
+       UserOwned(structure),
        device(device)
 {
        switch (structure->type)
@@ -920,6 +966,9 @@ Packet::Packet(shared_ptr<Device> device,
                                static_cast<const struct sr_datafeed_analog *>(
                                        structure->payload));
                        break;
+               default:
+                       payload = nullptr;
+                       break;
        }
 }
 
@@ -936,7 +985,10 @@ const PacketType *Packet::get_type()
 
 shared_ptr<PacketPayload> Packet::get_payload()
 {
-       return payload->get_shared_pointer(this);
+       if (payload)
+               return payload->get_shared_pointer(this);
+       else
+               throw Error(SR_ERR_NA);
 }
 
 PacketPayload::PacketPayload()
@@ -948,8 +1000,8 @@ PacketPayload::~PacketPayload()
 }
 
 Header::Header(const struct sr_datafeed_header *structure) :
-       PacketPayload(),
-       StructureWrapper<Packet, const struct sr_datafeed_header>(structure)
+       ParentOwned(structure),
+       PacketPayload()
 {
 }
 
@@ -957,6 +1009,12 @@ Header::~Header()
 {
 }
 
+shared_ptr<PacketPayload> Header::get_shared_pointer(Packet *parent)
+{
+       return static_pointer_cast<PacketPayload>(
+               ParentOwned::get_shared_pointer(parent));
+}
+
 int Header::get_feed_version()
 {
        return structure->feed_version;
@@ -970,8 +1028,8 @@ Glib::TimeVal Header::get_start_time()
 }
 
 Meta::Meta(const struct sr_datafeed_meta *structure) :
-       PacketPayload(),
-       StructureWrapper<Packet, const struct sr_datafeed_meta>(structure)
+       ParentOwned(structure),
+       PacketPayload()
 {
 }
 
@@ -979,6 +1037,12 @@ Meta::~Meta()
 {
 }
 
+shared_ptr<PacketPayload> Meta::get_shared_pointer(Packet *parent)
+{
+       return static_pointer_cast<PacketPayload>(
+               ParentOwned::get_shared_pointer(parent));
+}
+
 map<const ConfigKey *, Glib::VariantBase> Meta::get_config()
 {
        map<const ConfigKey *, Glib::VariantBase> result;
@@ -991,8 +1055,8 @@ map<const ConfigKey *, Glib::VariantBase> Meta::get_config()
 }
 
 Logic::Logic(const struct sr_datafeed_logic *structure) :
-       PacketPayload(),
-       StructureWrapper<Packet, const struct sr_datafeed_logic>(structure)
+       ParentOwned(structure),
+       PacketPayload()
 {
 }
 
@@ -1000,6 +1064,12 @@ Logic::~Logic()
 {
 }
 
+shared_ptr<PacketPayload> Logic::get_shared_pointer(Packet *parent)
+{
+       return static_pointer_cast<PacketPayload>(
+               ParentOwned::get_shared_pointer(parent));
+}
+
 void *Logic::get_data_pointer()
 {
        return structure->data;
@@ -1016,8 +1086,8 @@ unsigned int Logic::get_unit_size()
 }
 
 Analog::Analog(const struct sr_datafeed_analog *structure) :
-       PacketPayload(),
-       StructureWrapper<Packet, const struct sr_datafeed_analog>(structure)
+       ParentOwned(structure),
+       PacketPayload()
 {
 }
 
@@ -1025,6 +1095,12 @@ Analog::~Analog()
 {
 }
 
+shared_ptr<PacketPayload> Analog::get_shared_pointer(Packet *parent)
+{
+       return static_pointer_cast<PacketPayload>(
+               ParentOwned::get_shared_pointer(parent));
+}
+
 float *Analog::get_data_pointer()
 {
        return structure->data;
@@ -1059,8 +1135,8 @@ vector<const QuantityFlag *> Analog::get_mq_flags()
        return QuantityFlag::flags_from_mask(structure->mqflags);
 }
 
-InputFormat::InputFormat(struct sr_input_format *structure) :
-       StructureWrapper<Context, struct sr_input_format>(structure)
+InputFormat::InputFormat(const struct sr_input_module *structure) :
+       ParentOwned(structure)
 {
 }
 
@@ -1070,56 +1146,129 @@ InputFormat::~InputFormat()
 
 string InputFormat::get_name()
 {
-       return valid_string(structure->id);
+       return valid_string(sr_input_id_get(structure));
 }
 
 string InputFormat::get_description()
 {
-       return valid_string(structure->description);
+       return valid_string(sr_input_description_get(structure));
 }
 
-bool InputFormat::format_match(string filename)
+map<string, shared_ptr<Option>> InputFormat::get_options()
 {
-       return structure->format_match(filename.c_str());
+       const struct sr_option **options = sr_input_options_get(structure);
+       auto option_array = shared_ptr<const struct sr_option *>(
+               options, sr_input_options_free);
+       map<string, shared_ptr<Option>> result;
+       for (int i = 0; options[i]; i++)
+               result[options[i]->id] = shared_ptr<Option>(
+                       new Option(options[i], option_array), Option::Deleter());
+       return result;
 }
 
-shared_ptr<InputFileDevice> InputFormat::open_file(string filename,
-               map<string, string> options)
+shared_ptr<Input> InputFormat::create_input(
+       map<string, Glib::VariantBase> options)
 {
-       auto input = g_new(struct sr_input, 1);
-       input->param = map_to_hash(options);
+       auto input = sr_input_new(structure, map_to_hash_variant(options));
+       if (!input)
+               throw Error(SR_ERR_ARG);
+       return shared_ptr<Input>(
+               new Input(parent->shared_from_this(), input), Input::Deleter());
+}
+
+Input::Input(shared_ptr<Context> context, const struct sr_input *structure) :
+       UserOwned(structure),
+       context(context),
+       device(nullptr)
+{
+}
 
-       /** Run initialisation. */
-       check(structure->init(input, filename.c_str()));
+shared_ptr<InputDevice> Input::get_device()
+{
+       if (!device)
+       {
+               auto sdi = sr_input_dev_inst_get(structure);
+               if (!sdi)
+                       throw Error(SR_ERR_NA);
+               device = new InputDevice(shared_from_this(), sdi);
+       }
 
-       /** Create virtual device. */
-       return shared_ptr<InputFileDevice>(new InputFileDevice(
-               static_pointer_cast<InputFormat>(shared_from_this()), input, filename),
-               InputFileDevice::Deleter());
+       return device->get_shared_pointer(shared_from_this());
 }
 
-InputFileDevice::InputFileDevice(shared_ptr<InputFormat> format,
-               struct sr_input *input, string filename) :
-       Device(input->sdi),
-       input(input),
-       format(format),
-       filename(filename)
+void Input::send(string data)
 {
+       auto gstr = g_string_new(data.c_str());
+       auto ret = sr_input_send(structure, gstr);
+       g_string_free(gstr, false);
+       check(ret);
 }
 
-InputFileDevice::~InputFileDevice()
+Input::~Input()
 {
-       g_hash_table_unref(input->param);
-       g_free(input);
+       if (device)
+               delete device;
+       check(sr_input_free(structure));
 }
 
-void InputFileDevice::load()
+InputDevice::InputDevice(shared_ptr<Input> input,
+               struct sr_dev_inst *structure) :
+       ParentOwned(structure),
+       Device(structure),
+       input(input)
 {
-       check(format->structure->loadfile(input, filename.c_str()));
 }
 
-OutputFormat::OutputFormat(struct sr_output_format *structure) :
-       StructureWrapper<Context, struct sr_output_format>(structure)
+InputDevice::~InputDevice()
+{
+}
+
+shared_ptr<Device> InputDevice::get_shared_from_this()
+{
+       return static_pointer_cast<Device>(shared_from_this());
+}
+
+Option::Option(const struct sr_option *structure,
+               shared_ptr<const struct sr_option *> structure_array) :
+       UserOwned(structure),
+       structure_array(structure_array)
+{
+}
+
+Option::~Option()
+{
+}
+
+string Option::get_id()
+{
+       return valid_string(structure->id);
+}
+
+string Option::get_name()
+{
+       return valid_string(structure->name);
+}
+
+string Option::get_description()
+{
+       return valid_string(structure->desc);
+}
+
+Glib::VariantBase Option::get_default_value()
+{
+       return Glib::VariantBase(structure->def, true);
+}
+
+vector<Glib::VariantBase> Option::get_values()
+{
+       vector<Glib::VariantBase> result;
+       for (auto l = structure->values; l; l = l->next)
+               result.push_back(Glib::VariantBase((GVariant *) l->data, true));
+       return result;
+}
+
+OutputFormat::OutputFormat(const struct sr_output_module *structure) :
+       ParentOwned(structure)
 {
 }
 
@@ -1129,35 +1278,44 @@ OutputFormat::~OutputFormat()
 
 string OutputFormat::get_name()
 {
-       return valid_string(structure->id);
+       return valid_string(sr_output_id_get(structure));
 }
 
 string OutputFormat::get_description()
 {
-       return valid_string(structure->description);
+       return valid_string(sr_output_description_get(structure));
+}
+
+map<string, shared_ptr<Option>> OutputFormat::get_options()
+{
+       const struct sr_option **options = sr_output_options_get(structure);
+       auto option_array = shared_ptr<const struct sr_option *>(
+               options, sr_output_options_free);
+       map<string, shared_ptr<Option>> result;
+       for (int i = 0; options[i]; i++)
+               result[options[i]->id] = shared_ptr<Option>(
+                       new Option(options[i], option_array), Option::Deleter());
+       return result;
 }
 
 shared_ptr<Output> OutputFormat::create_output(
-       shared_ptr<Device> device, map<string, string> options)
+       shared_ptr<Device> device, map<string, Glib::VariantBase> options)
 {
        return shared_ptr<Output>(
-               new Output(
-                       static_pointer_cast<OutputFormat>(shared_from_this()),
-                               device, options),
+               new Output(shared_from_this(), device, options),
                Output::Deleter());
 }
 
 Output::Output(shared_ptr<OutputFormat> format,
-               shared_ptr<Device> device, map<string, string> options) :
-       structure(sr_output_new(format->structure,
-               map_to_hash(options), device->structure)),
+               shared_ptr<Device> device, map<string, Glib::VariantBase> options) :
+       UserOwned(sr_output_new(format->structure,
+               map_to_hash_variant(options), device->structure)),
        format(format), device(device), options(options)
 {
 }
 
 Output::~Output()
 {
-       g_hash_table_unref(structure->params);
        check(sr_output_free(structure));
 }