*/
#include <string.h>
-#include <stdlib.h> /* strtol() */
+#include <stdlib.h>
#include <errno.h>
-#include <fcntl.h> /* open(), etc... */
+#include <fcntl.h>
#include <glib/gstdio.h>
#include "protocol.h"
#include "gpio.h"
};
static const uint32_t pws_gpios[] = {
- 486, 498, 502, 482, 478, 506, 510, 474
+ 486, 498, 502, 482, 478, 506, 510, 474,
};
static const uint32_t pws_info_gpios[] = {
prb_num, err->message);
g_string_free(path, TRUE);
return ret;
-
}
- if (strncmp(buf, prb_name, strlen(prb_name)) == 0) {
+ if (!strncmp(buf, prb_name, strlen(prb_name))) {
/*
* Correct driver registered on this address - but is
* there an actual probe connected?
probe_hwmon_path(addr, path);
dir = g_dir_open(path->str, 0, &err);
- if (dir == NULL) {
+ if (!dir) {
sr_err("Error opening %s: %s", path->str, err->message);
g_string_free(path, TRUE);
return -1;
return hwmon;
}
-static void append_channel(struct sr_dev_inst *sdi,
- struct sr_channel_group *cg,
+static void append_channel(struct sr_dev_inst *sdi, struct sr_channel_group *cg,
int index, int type)
{
struct channel_priv *cp;
name = g_strdup_printf("P%d_TEMP_OUT", index);
break;
default:
- sr_err("Bug in the code: invalid channel type!");
+ sr_err("Invalid channel type: %d.", type);
return;
}
append_channel(sdi, cg, prb_num, TEMP_IN);
append_channel(sdi, cg, prb_num, TEMP_OUT);
} else {
- sr_err("Bug in the code: invalid probe type!");
+ sr_err("Invalid probe type: %d.", type);
}
sdi->channel_groups = g_slist_append(sdi->channel_groups, cg);
/*
* The shunt_resistor sysfs attribute is available
* in the Linux kernel since version 3.20. We have
- * to notify the user if this attribute is not
- * present.
+ * to notify the user if this attribute is not present.
*/
status = g_file_test(path->str, G_FILE_TEST_EXISTS);
if (!status) {
- sr_err("shunt_resistance attribute not present please update "
+ sr_err("shunt_resistance attribute not present, please update "
"your kernel to version >=3.20");
return SR_ERR_NA;
}
return ret;
}
-SR_PRIV int bl_acme_set_shunt(const struct sr_channel_group *cg,
- uint64_t shunt)
+SR_PRIV int bl_acme_set_shunt(const struct sr_channel_group *cg, uint64_t shunt)
{
GString *path = g_string_sized_new(64);;
int status, ret = SR_OK;
return SR_MQ_CURRENT;
case ENRG_VOL:
return SR_MQ_VOLTAGE;
- case TEMP_IN:
+ case TEMP_IN: /* Fallthrough */
case TEMP_OUT:
return SR_MQ_TEMPERATURE;
default:
return SR_UNIT_AMPERE;
case ENRG_VOL:
return SR_UNIT_VOLT;
- case TEMP_IN:
+ case TEMP_IN: /* Fallthrough */
case TEMP_OUT:
return SR_UNIT_CELSIUS;
default:
switch (type) {
case ENRG_PWR:
return ((float)val) / 1000000.0;
- case ENRG_CURR:
- case ENRG_VOL:
- case TEMP_IN:
+ case ENRG_CURR: /* Fallthrough */
+ case ENRG_VOL: /* Fallthrough */
+ case TEMP_IN: /* Fallthrough */
case TEMP_OUT:
return ((float)val) / 1000.0;
default:
case TEMP_IN: file = "temp1_input"; break;
case TEMP_OUT: file = "temp2_input"; break;
default:
- sr_err("Bug in the code: invalid channel type!");
+ sr_err("Invalid channel type: %d.", chp->ch_type);
return -1.0;
}
- snprintf(path, sizeof(path),
- "/sys/class/hwmon/hwmon%d/%s",
+ snprintf(path, sizeof(path), "/sys/class/hwmon/hwmon%d/%s",
chp->probe->hwmon_num, file);
fd = open(path, O_RDONLY);
if (fd < 0) {
len = read(fd, buf, sizeof(buf));
close(fd);
if (len < 0) {
- sr_err("error reading from %s: %s", path, strerror(errno));
+ sr_err("Error reading from %s: %s", path, strerror(errno));
ch->enabled = FALSE;
return -1.0;
}
analog.data = &valf;
/*
- * Reading from sysfs takes some time - try to
- * keep up with samplerate.
+ * Reading from sysfs takes some time - try to keep up with samplerate.
*/
if (devc->samples_read) {
cur_time = g_get_monotonic_time();