]> sigrok.org Git - pulseview.git/commit
DecodeSignal: Don't set name when creating the signal
authorSoeren Apel <redacted>
Mon, 10 Jul 2017 17:14:35 +0000 (19:14 +0200)
committerSoeren Apel <redacted>
Mon, 10 Jul 2017 17:14:35 +0000 (19:14 +0200)
commit289c1bdc7e113c56f4829550ae894458bfab10a3
tree17af2112de1ff50107fc69238e251adca62bcf1f
parent4ca06ec34ab94ce25b96b16b749b241593858cb1
DecodeSignal: Don't set name when creating the signal

The thought behind this was to have no unnamed signals because
this may make debugging harder. However, giving the signal a
long name and shortening it when decoders are added isn't working
well. The reason is that the width of the header area can be
expanded programmatically but we don't shrink it because we
don't want to hide things the user may want to see.
This behavior in turn leads to the header width expanding when
a signal labeled "Empty decoder signal" is added, only to see
this very signal be renamed to e.g. "SPI" immediately afterwards.
As we don't shrink the header width, the header is now too wide.
pv/data/decodesignal.cpp