]> sigrok.org Git - libsigrokdecode.git/blame - controller.c
Move all decoder instances and callbacks into a session struct
[libsigrokdecode.git] / controller.c
CommitLineData
b2c19614 1/*
50bd5d25 2 * This file is part of the libsigrokdecode project.
b2c19614
BV
3 *
4 * Copyright (C) 2010 Uwe Hermann <uwe@hermann-uwe.de>
bc5f5a43 5 * Copyright (C) 2012 Bert Vermeulen <bert@biot.com>
b2c19614
BV
6 *
7 * This program is free software: you can redistribute it and/or modify
8 * it under the terms of the GNU General Public License as published by
9 * the Free Software Foundation, either version 3 of the License, or
10 * (at your option) any later version.
11 *
12 * This program is distributed in the hope that it will be useful,
13 * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 * GNU General Public License for more details.
16 *
17 * You should have received a copy of the GNU General Public License
18 * along with this program. If not, see <http://www.gnu.org/licenses/>.
19 */
20
c1f86f02
UH
21#include "libsigrokdecode.h" /* First, so we avoid a _POSIX_C_SOURCE warning. */
22#include "libsigrokdecode-internal.h"
7ce7775c 23#include "config.h"
b2c19614 24#include <glib.h>
1aef2f93 25#include <inttypes.h>
0bdadba2 26#include <stdlib.h>
32cfb920 27#include <stdint.h>
b2c19614 28
d7dae84b
UH
29/**
30 * @mainpage libsigrokdecode API
31 *
32 * @section sec_intro Introduction
33 *
34 * The <a href="http://sigrok.org">sigrok</a> project aims at creating a
35 * portable, cross-platform, Free/Libre/Open-Source signal analysis software
36 * suite that supports various device types (such as logic analyzers,
37 * oscilloscopes, multimeters, and more).
38 *
39 * <a href="http://sigrok.org/wiki/Libsigrokdecode">libsigrokdecode</a> is a
40 * shared library written in C which provides the basic API for (streaming)
41 * protocol decoding functionality.
42 *
43 * The <a href="http://sigrok.org/wiki/Protocol_decoders">protocol decoders</a>
44 * are written in Python (>= 3.0).
45 *
46 * @section sec_api API reference
47 *
48 * See the "Modules" page for an introduction to various libsigrokdecode
49 * related topics and the detailed API documentation of the respective
50 * functions.
51 *
52 * You can also browse the API documentation by file, or review all
53 * data structures.
54 *
55 * @section sec_mailinglists Mailing lists
56 *
57 * There are two mailing lists for sigrok/libsigrokdecode: <a href="https://lists.sourceforge.net/lists/listinfo/sigrok-devel">sigrok-devel</a> and <a href="https://lists.sourceforge.net/lists/listinfo/sigrok-commits">sigrok-commits</a>.
58 *
59 * @section sec_irc IRC
60 *
61 * You can find the sigrok developers in the
62 * <a href="irc://chat.freenode.net/sigrok">\#sigrok</a>
63 * IRC channel on Freenode.
64 *
65 * @section sec_website Website
66 *
67 * <a href="http://sigrok.org/wiki/Libsigrokdecode">sigrok.org/wiki/Libsigrokdecode</a>
68 */
69
70/**
71 * @file
72 *
73 * Initializing and shutting down libsigrokdecode.
74 */
75
76/**
77 * @defgroup grp_init Initialization
78 *
79 * Initializing and shutting down libsigrokdecode.
80 *
81 * Before using any of the libsigrokdecode functionality, srd_init() must
82 * be called to initialize the library.
83 *
84 * When libsigrokdecode functionality is no longer needed, srd_exit() should
85 * be called.
86 *
87 * @{
88 */
89
32cfb920 90/** @cond PRIVATE */
d906d3f9 91
32cfb920
BV
92SRD_PRIV GSList *sessions = NULL;
93static int max_session_id = -1;
983cb0f5 94
32cfb920 95static int session_is_valid(struct srd_session *sess);
57790bc8 96
c9bfccc6 97/* decoder.c */
55c3c5f4 98extern SRD_PRIV GSList *pd_list;
b2c19614 99
c9bfccc6 100/* module_sigrokdecode.c */
53a07a6d 101extern PyMODINIT_FUNC PyInit_sigrokdecode(void);
b2c19614 102
c9bfccc6 103/* type_logic.c */
55c3c5f4 104extern SRD_PRIV PyTypeObject srd_logic_type;
b2c19614 105
57790bc8
UH
106/** @endcond */
107
b2c19614
BV
108/**
109 * Initialize libsigrokdecode.
110 *
111 * This initializes the Python interpreter, and creates and initializes
361fdcaa 112 * a "sigrokdecode" Python module.
b2c19614 113 *
4cc0d9fe
UH
114 * Then, it searches for sigrok protocol decoders in the "decoders"
115 * subdirectory of the the libsigrokdecode installation directory.
b2c19614 116 * All decoders that are found are loaded into memory and added to an
4cc0d9fe 117 * internal list of decoders, which can be queried via srd_decoder_list().
b2c19614
BV
118 *
119 * The caller is responsible for calling the clean-up function srd_exit(),
120 * which will properly shut down libsigrokdecode and free its allocated memory.
121 *
7ce7775c 122 * Multiple calls to srd_init(), without calling srd_exit() in between,
b2c19614
BV
123 * are not allowed.
124 *
65e1c7d0 125 * @param path Path to an extra directory containing protocol decoders
4cc0d9fe 126 * which will be added to the Python sys.path. May be NULL.
65e1c7d0 127 *
b2c19614 128 * @return SRD_OK upon success, a (negative) error code otherwise.
4cc0d9fe
UH
129 * Upon Python errors, SRD_ERR_PYTHON is returned. If the decoders
130 * directory cannot be accessed, SRD_ERR_DECODERS_DIR is returned.
131 * If not enough memory could be allocated, SRD_ERR_MALLOC is returned.
8c664ca2
UH
132 *
133 * @since 0.1.0
b2c19614 134 */
abeeed8b 135SRD_API int srd_init(const char *path)
b2c19614
BV
136{
137 int ret;
65e1c7d0 138 char *env_path;
b2c19614 139
32cfb920
BV
140 if (max_session_id != -1) {
141 srd_err("libsigrokdecode is already initialized.");
142 return SRD_ERR;
143 }
144
7a1712c4 145 srd_dbg("Initializing libsigrokdecode.");
d906d3f9
BV
146
147 /* Add our own module to the list of built-in modules. */
bc5f5a43 148 PyImport_AppendInittab("sigrokdecode", PyInit_sigrokdecode);
5f802ec6 149
511e2123 150 /* Initialize the Python interpreter. */
b2c19614
BV
151 Py_Initialize();
152
65e1c7d0 153 /* Installed decoders. */
aafeeaea 154 if ((ret = srd_decoder_searchpath_add(DECODERS_DIR)) != SRD_OK) {
b2c19614
BV
155 Py_Finalize();
156 return ret;
157 }
158
65e1c7d0
BV
159 /* Path specified by the user. */
160 if (path) {
aafeeaea 161 if ((ret = srd_decoder_searchpath_add(path)) != SRD_OK) {
65e1c7d0
BV
162 Py_Finalize();
163 return ret;
164 }
165 }
166
167 /* Environment variable overrides everything, for debugging. */
168 if ((env_path = getenv("SIGROKDECODE_DIR"))) {
aafeeaea 169 if ((ret = srd_decoder_searchpath_add(env_path)) != SRD_OK) {
65e1c7d0
BV
170 Py_Finalize();
171 return ret;
172 }
173 }
174
32cfb920
BV
175 max_session_id = 0;
176
b2c19614
BV
177 return SRD_OK;
178}
179
b2c19614
BV
180/**
181 * Shutdown libsigrokdecode.
182 *
183 * This frees all the memory allocated for protocol decoders and shuts down
184 * the Python interpreter.
185 *
186 * This function should only be called if there was a (successful!) invocation
187 * of srd_init() before. Calling this function multiple times in a row, without
7ce7775c 188 * any successful srd_init() calls in between, is not allowed.
b2c19614
BV
189 *
190 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
191 *
192 * @since 0.1.0
b2c19614 193 */
55c3c5f4 194SRD_API int srd_exit(void)
b2c19614 195{
32cfb920
BV
196 GSList *l;
197
7a1712c4 198 srd_dbg("Exiting libsigrokdecode.");
d906d3f9 199
32cfb920
BV
200 for (l = sessions; l; l = l->next)
201 srd_session_destroy((struct srd_session *)l->data);
202
8ad6e500 203 srd_decoder_unload_all();
e5080882 204 g_slist_free(pd_list);
96c52595 205 pd_list = NULL;
b2c19614
BV
206
207 /* Py_Finalize() returns void, any finalization errors are ignored. */
208 Py_Finalize();
209
32cfb920
BV
210 max_session_id = -1;
211
b2c19614
BV
212 return SRD_OK;
213}
214
b2c19614 215/**
9d9fcb37
UH
216 * Add an additional search directory for the protocol decoders.
217 *
218 * The specified directory is prepended (not appended!) to Python's sys.path,
219 * in order to search for sigrok protocol decoders in the specified
220 * directories first, and in the generic Python module directories (and in
221 * the current working directory) last. This avoids conflicts if there are
222 * Python modules which have the same name as a sigrok protocol decoder in
223 * sys.path or in the current working directory.
b2c19614 224 *
361fdcaa
UH
225 * @param path Path to the directory containing protocol decoders which shall
226 * be added to the Python sys.path, or NULL.
9d9fcb37 227 *
65e1c7d0 228 * @return SRD_OK upon success, a (negative) error code otherwise.
57790bc8
UH
229 *
230 * @private
8c664ca2
UH
231 *
232 * @since 0.1.0
b2c19614 233 */
aafeeaea 234SRD_PRIV int srd_decoder_searchpath_add(const char *path)
b2c19614 235{
65e1c7d0
BV
236 PyObject *py_cur_path, *py_item;
237 GString *new_path;
238 int wc_len, i;
239 wchar_t *wc_new_path;
240 char *item;
241
8ad6e500 242 srd_dbg("Adding '%s' to module path.", path);
65e1c7d0
BV
243
244 new_path = g_string_sized_new(256);
e592ac89 245 g_string_assign(new_path, path);
65e1c7d0
BV
246 py_cur_path = PySys_GetObject("path");
247 for (i = 0; i < PyList_Size(py_cur_path); i++) {
e592ac89 248 g_string_append(new_path, G_SEARCHPATH_SEPARATOR_S);
65e1c7d0
BV
249 py_item = PyList_GetItem(py_cur_path, i);
250 if (!PyUnicode_Check(py_item))
251 /* Shouldn't happen. */
252 continue;
253 if (py_str_as_str(py_item, &item) != SRD_OK)
254 continue;
255 g_string_append(new_path, item);
e592ac89 256 g_free(item);
65e1c7d0 257 }
639c5689 258
65e1c7d0
BV
259 /* Convert to wide chars. */
260 wc_len = sizeof(wchar_t) * (new_path->len + 1);
261 if (!(wc_new_path = g_try_malloc(wc_len))) {
262 srd_dbg("malloc failed");
263 return SRD_ERR_MALLOC;
264 }
265 mbstowcs(wc_new_path, new_path->str, wc_len);
266 PySys_SetPath(wc_new_path);
267 g_string_free(new_path, TRUE);
268 g_free(wc_new_path);
269
65e1c7d0 270 return SRD_OK;
b2c19614
BV
271}
272
4895418c
UH
273/** @} */
274
275/**
276 * @defgroup grp_instances Decoder instances
277 *
278 * Decoder instance handling.
279 *
280 * @{
281 */
282
7ce7775c 283/**
b33b8aa5 284 * Set one or more options in a decoder instance.
0bdadba2 285 *
361fdcaa
UH
286 * Handled options are removed from the hash.
287 *
0bdadba2
BV
288 * @param di Decoder instance.
289 * @param options A GHashTable of options to set.
7ce7775c 290 *
0bdadba2 291 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
292 *
293 * @since 0.1.0
0bdadba2 294 */
b33b8aa5 295SRD_API int srd_inst_option_set(struct srd_decoder_inst *di,
0ff2d191 296 GHashTable *options)
0bdadba2
BV
297{
298 PyObject *py_dec_options, *py_dec_optkeys, *py_di_options, *py_optval;
299 PyObject *py_optlist, *py_classval;
300 Py_UNICODE *py_ustr;
2f395bff 301 GVariant *value;
0bdadba2 302 unsigned long long int val_ull;
2f395bff 303 gint64 val_int;
0bdadba2 304 int num_optkeys, ret, size, i;
2f395bff
BV
305 const char *val_str;
306 char *dbg, *key;
0bdadba2 307
c9bfccc6 308 if (!PyObject_HasAttrString(di->decoder->py_dec, "options")) {
0bdadba2 309 /* Decoder has no options. */
e431d9cc
BV
310 if (g_hash_table_size(options) == 0) {
311 /* No options provided. */
312 return SRD_OK;
313 } else {
314 srd_err("Protocol decoder has no options.");
315 return SRD_ERR_ARG;
316 }
0bdadba2 317 return SRD_OK;
e431d9cc 318 }
0bdadba2
BV
319
320 ret = SRD_ERR_PYTHON;
321 key = NULL;
322 py_dec_options = py_dec_optkeys = py_di_options = py_optval = NULL;
323 py_optlist = py_classval = NULL;
324 py_dec_options = PyObject_GetAttrString(di->decoder->py_dec, "options");
0bdadba2
BV
325
326 /* All of these are synthesized objects, so they're good. */
327 py_dec_optkeys = PyDict_Keys(py_dec_options);
328 num_optkeys = PyList_Size(py_dec_optkeys);
a8b72b05 329 if (!(py_di_options = PyObject_GetAttrString(di->py_inst, "options")))
0bdadba2
BV
330 goto err_out;
331 for (i = 0; i < num_optkeys; i++) {
332 /* Get the default class value for this option. */
333 py_str_as_str(PyList_GetItem(py_dec_optkeys, i), &key);
334 if (!(py_optlist = PyDict_GetItemString(py_dec_options, key)))
335 goto err_out;
336 if (!(py_classval = PyList_GetItem(py_optlist, 1)))
337 goto err_out;
130ef08a 338 if (!PyUnicode_Check(py_classval) && !PyLong_Check(py_classval)) {
c9bfccc6
UH
339 srd_err("Options of type %s are not yet supported.",
340 Py_TYPE(py_classval)->tp_name);
130ef08a
BV
341 goto err_out;
342 }
0bdadba2
BV
343
344 if ((value = g_hash_table_lookup(options, key))) {
2f395bff
BV
345 dbg = g_variant_print(value, TRUE);
346 srd_dbg("got option '%s' = %s", key, dbg);
347 g_free(dbg);
0bdadba2
BV
348 /* An override for this option was provided. */
349 if (PyUnicode_Check(py_classval)) {
2f395bff
BV
350 if (!g_variant_is_of_type(value, G_VARIANT_TYPE_STRING)) {
351 srd_err("Option '%s' requires a string value.", key);
352 goto err_out;
353 }
354 val_str = g_variant_get_string(value, NULL);
355 if (!(py_optval = PyUnicode_FromString(val_str))) {
0bdadba2
BV
356 /* Some UTF-8 encoding error. */
357 PyErr_Clear();
2f395bff 358 srd_err("Option '%s' requires a UTF-8 string value.", key);
0bdadba2
BV
359 goto err_out;
360 }
361 } else if (PyLong_Check(py_classval)) {
2f395bff
BV
362 if (!g_variant_is_of_type(value, G_VARIANT_TYPE_INT64)) {
363 srd_err("Option '%s' requires an integer value.", key);
364 goto err_out;
365 }
366 val_int = g_variant_get_int64(value);
367 if (!(py_optval = PyLong_FromLong(val_int))) {
0bdadba2
BV
368 /* ValueError Exception */
369 PyErr_Clear();
2f395bff 370 srd_err("Option '%s' has invalid integer value.", key);
0bdadba2
BV
371 goto err_out;
372 }
373 }
374 g_hash_table_remove(options, key);
375 } else {
376 /* Use the class default for this option. */
377 if (PyUnicode_Check(py_classval)) {
378 /* Make a brand new copy of the string. */
379 py_ustr = PyUnicode_AS_UNICODE(py_classval);
380 size = PyUnicode_GET_SIZE(py_classval);
381 py_optval = PyUnicode_FromUnicode(py_ustr, size);
382 } else if (PyLong_Check(py_classval)) {
383 /* Make a brand new copy of the integer. */
384 val_ull = PyLong_AsUnsignedLongLong(py_classval);
385 if (val_ull == (unsigned long long)-1) {
386 /* OverFlowError exception */
387 PyErr_Clear();
c9bfccc6
UH
388 srd_err("Invalid integer value for %s: "
389 "expected integer.", key);
0bdadba2
BV
390 goto err_out;
391 }
392 if (!(py_optval = PyLong_FromUnsignedLongLong(val_ull)))
393 goto err_out;
394 }
395 }
396
361fdcaa
UH
397 /*
398 * If we got here, py_optval holds a known good new reference
0bdadba2
BV
399 * to the instance option to set.
400 */
401 if (PyDict_SetItemString(py_di_options, key, py_optval) == -1)
402 goto err_out;
e592ac89 403 g_free(key);
b88e336b 404 key = NULL;
0bdadba2
BV
405 }
406
407 ret = SRD_OK;
408
409err_out:
410 Py_XDECREF(py_optlist);
411 Py_XDECREF(py_di_options);
412 Py_XDECREF(py_dec_optkeys);
413 Py_XDECREF(py_dec_options);
6f858319 414 g_free(key);
2086c684 415 if (PyErr_Occurred())
aafeeaea 416 srd_exception_catch("Stray exception in srd_inst_option_set().");
0bdadba2
BV
417
418 return ret;
419}
420
b33b8aa5 421/* Helper GComparefunc for g_slist_find_custom() in srd_inst_probe_set_all() */
abeeed8b 422static gint compare_probe_id(const struct srd_probe *a, const char *probe_id)
f38ec285 423{
f38ec285
BV
424 return strcmp(a->id, probe_id);
425}
426
0bdadba2 427/**
b33b8aa5
UH
428 * Set all probes in a decoder instance.
429 *
430 * This function sets _all_ probes for the specified decoder instance, i.e.,
431 * it overwrites any probes that were already defined (if any).
0bdadba2
BV
432 *
433 * @param di Decoder instance.
38ff5046
UH
434 * @param new_probes A GHashTable of probes to set. Key is probe name, value is
435 * the probe number. Samples passed to this instance will be
436 * arranged in this order.
12243c22 437 *
0bdadba2 438 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
439 *
440 * @since 0.1.0
0bdadba2 441 */
b33b8aa5 442SRD_API int srd_inst_probe_set_all(struct srd_decoder_inst *di,
0ff2d191 443 GHashTable *new_probes)
0bdadba2 444{
2f395bff 445 GVariant *probe_val;
f38ec285
BV
446 GList *l;
447 GSList *sl;
448 struct srd_probe *p;
449 int *new_probemap, new_probenum;
2f395bff 450 char *probe_id;
38ff5046 451 int i, num_required_probes;
0bdadba2 452
ce46beed 453 srd_dbg("set probes called for instance %s with list of %d probes",
a8b72b05 454 di->inst_id, g_hash_table_size(new_probes));
ce46beed 455
f38ec285 456 if (g_hash_table_size(new_probes) == 0)
0bdadba2
BV
457 /* No probes provided. */
458 return SRD_OK;
459
c9bfccc6 460 if (di->dec_num_probes == 0) {
0bdadba2 461 /* Decoder has no probes. */
f38ec285 462 srd_err("Protocol decoder %s has no probes to define.",
c9bfccc6 463 di->decoder->name);
f38ec285
BV
464 return SRD_ERR_ARG;
465 }
0bdadba2 466
f38ec285 467 new_probemap = NULL;
0bdadba2 468
f38ec285 469 if (!(new_probemap = g_try_malloc(sizeof(int) * di->dec_num_probes))) {
a61ece20 470 srd_err("Failed to g_malloc() new probe map.");
f38ec285 471 return SRD_ERR_MALLOC;
0bdadba2
BV
472 }
473
38ff5046
UH
474 /*
475 * For now, map all indexes to probe -1 (can be overridden later).
476 * This -1 is interpreted as an unspecified probe later.
477 */
478 for (i = 0; i < di->dec_num_probes; i++)
479 new_probemap[i] = -1;
480
f38ec285
BV
481 for (l = g_hash_table_get_keys(new_probes); l; l = l->next) {
482 probe_id = l->data;
2f395bff
BV
483 probe_val= g_hash_table_lookup(new_probes, probe_id);
484 if (!g_variant_is_of_type(probe_val, G_VARIANT_TYPE_INT32)) {
be873260 485 /* Probe name was specified without a value. */
c9bfccc6 486 srd_err("No probe number was specified for %s.",
2f395bff 487 probe_id);
be873260
BV
488 g_free(new_probemap);
489 return SRD_ERR_ARG;
490 }
2f395bff 491 new_probenum = g_variant_get_int32(probe_val);
f38ec285
BV
492 if (!(sl = g_slist_find_custom(di->decoder->probes, probe_id,
493 (GCompareFunc)compare_probe_id))) {
494 /* Fall back on optional probes. */
dcdf4883 495 if (!(sl = g_slist_find_custom(di->decoder->opt_probes,
c9bfccc6
UH
496 probe_id, (GCompareFunc) compare_probe_id))) {
497 srd_err("Protocol decoder %s has no probe "
2f395bff 498 "'%s'.", di->decoder->name, probe_id);
f38ec285
BV
499 g_free(new_probemap);
500 return SRD_ERR_ARG;
501 }
502 }
503 p = sl->data;
504 new_probemap[p->order] = new_probenum;
38ff5046
UH
505 srd_dbg("Setting probe mapping: %s (index %d) = probe %d.",
506 p->id, p->order, new_probenum);
507 }
508
509 srd_dbg("Final probe map:");
510 num_required_probes = g_slist_length(di->decoder->probes);
511 for (i = 0; i < di->dec_num_probes; i++) {
512 srd_dbg(" - index %d = probe %d (%s)", i, new_probemap[i],
513 (i < num_required_probes) ? "required" : "optional");
f38ec285 514 }
38ff5046 515
f38ec285
BV
516 g_free(di->dec_probemap);
517 di->dec_probemap = new_probemap;
0bdadba2 518
f38ec285 519 return SRD_OK;
0bdadba2
BV
520}
521
522/**
523 * Create a new protocol decoder instance.
7ce7775c 524 *
32cfb920 525 * @param sess The session holding the protocol decoder instance.
38ff5046 526 * @param decoder_id Decoder 'id' field.
0bdadba2 527 * @param options GHashtable of options which override the defaults set in
38ff5046 528 * the decoder class. May be NULL.
12243c22 529 *
a8b72b05 530 * @return Pointer to a newly allocated struct srd_decoder_inst, or
c9bfccc6 531 * NULL in case of failure.
8c664ca2
UH
532 *
533 * @since 0.1.0
7ce7775c 534 */
32cfb920
BV
535SRD_API struct srd_decoder_inst *srd_inst_new(struct srd_session *sess,
536 const char *decoder_id, GHashTable *options)
b2c19614 537{
c9bfccc6 538 int i;
b2c19614 539 struct srd_decoder *dec;
a8b72b05
BV
540 struct srd_decoder_inst *di;
541 char *inst_id;
b2c19614 542
7a1712c4 543 srd_dbg("Creating new %s instance.", decoder_id);
7ce7775c 544
32cfb920
BV
545 if (session_is_valid(sess) != SRD_OK) {
546 srd_err("Invalid session.");
547 return NULL;
548 }
549
9d122fd5 550 if (!(dec = srd_decoder_get_by_id(decoder_id))) {
0bdadba2 551 srd_err("Protocol decoder %s not found.", decoder_id);
b2c19614 552 return NULL;
0bdadba2 553 }
b2c19614 554
a8b72b05 555 if (!(di = g_try_malloc0(sizeof(struct srd_decoder_inst)))) {
a61ece20 556 srd_err("Failed to g_malloc() instance.");
7ce7775c
BV
557 return NULL;
558 }
0bdadba2 559
b2c19614 560 di->decoder = dec;
32cfb920 561 di->sess = sess;
38ff5046
UH
562 if (options) {
563 inst_id = g_hash_table_lookup(options, "id");
564 di->inst_id = g_strdup(inst_id ? inst_id : decoder_id);
565 g_hash_table_remove(options, "id");
566 } else
567 di->inst_id = g_strdup(decoder_id);
b2c19614 568
361fdcaa
UH
569 /*
570 * Prepare a default probe map, where samples come in the
f38ec285
BV
571 * order in which the decoder class defined them.
572 */
573 di->dec_num_probes = g_slist_length(di->decoder->probes) +
c9bfccc6 574 g_slist_length(di->decoder->opt_probes);
19a90bab 575 if (di->dec_num_probes) {
c9bfccc6
UH
576 if (!(di->dec_probemap =
577 g_try_malloc(sizeof(int) * di->dec_num_probes))) {
a61ece20 578 srd_err("Failed to g_malloc() probe map.");
19a90bab
BV
579 g_free(di);
580 return NULL;
581 }
582 for (i = 0; i < di->dec_num_probes; i++)
583 di->dec_probemap[i] = i;
f38ec285 584 }
f38ec285 585
0bdadba2 586 /* Create a new instance of this decoder class. */
a8b72b05 587 if (!(di->py_inst = PyObject_CallObject(dec->py_dec, NULL))) {
b2c19614 588 if (PyErr_Occurred())
aafeeaea
UH
589 srd_exception_catch("failed to create %s instance: ",
590 decoder_id);
f38ec285 591 g_free(di->dec_probemap);
0bdadba2 592 g_free(di);
7ce7775c 593 return NULL;
b2c19614 594 }
7ce7775c 595
38ff5046 596 if (options && srd_inst_option_set(di, options) != SRD_OK) {
f38ec285 597 g_free(di->dec_probemap);
0bdadba2
BV
598 g_free(di);
599 return NULL;
600 }
b2c19614 601
f38ec285 602 /* Instance takes input from a frontend by default. */
32cfb920 603 sess->di_list = g_slist_append(sess->di_list, di);
f38ec285 604
b2c19614
BV
605 return di;
606}
607
582c8473
BV
608/**
609 * Stack a decoder instance on top of another.
610 *
32cfb920 611 * @param sess The session holding the protocol decoder instances.
582c8473
BV
612 * @param di_from The instance to move.
613 * @param di_to The instance on top of which di_from will be stacked.
614 *
615 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
616 *
617 * @since 0.1.0
582c8473 618 */
32cfb920
BV
619SRD_API int srd_inst_stack(struct srd_session *sess,
620 struct srd_decoder_inst *di_from, struct srd_decoder_inst *di_to)
7ce7775c 621{
32cfb920
BV
622
623 if (session_is_valid(sess) != SRD_OK) {
624 srd_err("Invalid session.");
625 return SRD_ERR_ARG;
626 }
627
7ce7775c 628 if (!di_from || !di_to) {
d906d3f9 629 srd_err("Invalid from/to instance pair.");
7ce7775c
BV
630 return SRD_ERR_ARG;
631 }
632
32cfb920 633 if (g_slist_find(sess->di_list, di_to)) {
2072ae0c 634 /* Remove from the unstacked list. */
32cfb920 635 sess->di_list = g_slist_remove(sess->di_list, di_to);
7ce7775c
BV
636 }
637
7ce7775c
BV
638 /* Stack on top of source di. */
639 di_from->next_di = g_slist_append(di_from->next_di, di_to);
640
641 return SRD_OK;
642}
643
2072ae0c 644/**
361fdcaa
UH
645 * Find a decoder instance by its instance ID.
646 *
647 * Only the bottom level of instances are searched -- instances already stacked
648 * on top of another one will not be found.
2072ae0c 649 *
32cfb920 650 * @param sess The session holding the protocol decoder instance.
ed2306a6 651 * @param inst_id The instance ID to be found.
2072ae0c 652 *
a8b72b05 653 * @return Pointer to struct srd_decoder_inst, or NULL if not found.
8c664ca2
UH
654 *
655 * @since 0.1.0
2072ae0c 656 */
32cfb920
BV
657SRD_API struct srd_decoder_inst *srd_inst_find_by_id(struct srd_session *sess,
658 const char *inst_id)
7ce7775c
BV
659{
660 GSList *l;
a8b72b05 661 struct srd_decoder_inst *tmp, *di;
b2c19614 662
32cfb920
BV
663 if (session_is_valid(sess) != SRD_OK) {
664 srd_err("Invalid session.");
665 return NULL;
666 }
667
7ce7775c 668 di = NULL;
32cfb920 669 for (l = sess->di_list; l; l = l->next) {
7ce7775c 670 tmp = l->data;
a8b72b05 671 if (!strcmp(tmp->inst_id, inst_id)) {
7ce7775c
BV
672 di = tmp;
673 break;
674 }
675 }
676
677 return di;
678}
679
32cfb920
BV
680static struct srd_decoder_inst *srd_sess_inst_find_by_obj(
681 struct srd_session *sess, const GSList *stack,
682 const PyObject *obj)
683{
684 const GSList *l;
685 struct srd_decoder_inst *tmp, *di;
686
687 if (session_is_valid(sess) != SRD_OK) {
688 srd_err("Invalid session.");
689 return NULL;
690 }
691
692 di = NULL;
693 for (l = stack ? stack : sess->di_list; di == NULL && l != NULL; l = l->next) {
694 tmp = l->data;
695 if (tmp->py_inst == obj)
696 di = tmp;
697 else if (tmp->next_di)
698 di = srd_sess_inst_find_by_obj(sess, tmp->next_di, obj);
699 }
700
701 return di;
702}
703
2072ae0c 704/**
361fdcaa
UH
705 * Find a decoder instance by its Python object.
706 *
707 * I.e. find that instance's instantiation of the sigrokdecode.Decoder class.
32cfb920
BV
708 * This will recurse to find the instance anywhere in the stack tree of all
709 * sessions.
2072ae0c 710 *
361fdcaa
UH
711 * @param stack Pointer to a GSList of struct srd_decoder_inst, indicating the
712 * stack to search. To start searching at the bottom level of
713 * decoder instances, pass NULL.
511e2123 714 * @param obj The Python class instantiation.
2072ae0c 715 *
a8b72b05 716 * @return Pointer to struct srd_decoder_inst, or NULL if not found.
57790bc8
UH
717 *
718 * @private
8c664ca2
UH
719 *
720 * @since 0.1.0
2072ae0c 721 */
abeeed8b 722SRD_PRIV struct srd_decoder_inst *srd_inst_find_by_obj(const GSList *stack,
0ff2d191 723 const PyObject *obj)
2072ae0c 724{
32cfb920
BV
725 struct srd_decoder_inst *di;
726 struct srd_session *sess;
727 GSList *l;
2072ae0c
BV
728
729 di = NULL;
32cfb920
BV
730 for (l = sessions; di == NULL && l != NULL; l = l->next) {
731 sess = l->data;
732 di = srd_sess_inst_find_by_obj(sess, stack, obj);
2072ae0c
BV
733 }
734
735 return di;
736}
737
57790bc8 738/** @private */
ee4ed227 739SRD_PRIV int srd_inst_start(struct srd_decoder_inst *di, PyObject *args)
b2c19614 740{
7ce7775c 741 PyObject *py_name, *py_res;
2072ae0c 742 GSList *l;
a8b72b05 743 struct srd_decoder_inst *next_di;
b2c19614 744
7a1712c4 745 srd_dbg("Calling start() method on protocol decoder instance %s.",
a8b72b05 746 di->inst_id);
b2c19614 747
7ce7775c 748 if (!(py_name = PyUnicode_FromString("start"))) {
511e2123 749 srd_err("Unable to build Python object for 'start'.");
aafeeaea
UH
750 srd_exception_catch("Protocol decoder instance %s: ",
751 di->inst_id);
7ce7775c
BV
752 return SRD_ERR_PYTHON;
753 }
754
a8b72b05 755 if (!(py_res = PyObject_CallMethodObjArgs(di->py_inst,
c9bfccc6 756 py_name, args, NULL))) {
aafeeaea
UH
757 srd_exception_catch("Protocol decoder instance %s: ",
758 di->inst_id);
7ce7775c 759 return SRD_ERR_PYTHON;
b2c19614
BV
760 }
761
f38ec285
BV
762 Py_DecRef(py_res);
763 Py_DecRef(py_name);
7ce7775c 764
361fdcaa
UH
765 /*
766 * Start all the PDs stacked on top of this one. Pass along the
2072ae0c
BV
767 * metadata all the way from the bottom PD, even though it's only
768 * applicable to logic data for now.
769 */
770 for (l = di->next_di; l; l = l->next) {
771 next_di = l->data;
a8b72b05 772 srd_inst_start(next_di, args);
2072ae0c
BV
773 }
774
b2c19614
BV
775 return SRD_OK;
776}
777
b2c19614
BV
778/**
779 * Run the specified decoder function.
780 *
d906d3f9 781 * @param start_samplenum The starting sample number for the buffer's sample
7a1712c4
UH
782 * set, relative to the start of capture.
783 * @param di The decoder instance to call. Must not be NULL.
784 * @param inbuf The buffer to decode. Must not be NULL.
785 * @param inbuflen Length of the buffer. Must be > 0.
b2c19614
BV
786 *
787 * @return SRD_OK upon success, a (negative) error code otherwise.
57790bc8
UH
788 *
789 * @private
8c664ca2
UH
790 *
791 * @since 0.1.0
b2c19614 792 */
12243c22 793SRD_PRIV int srd_inst_decode(uint64_t start_samplenum,
0ff2d191
BV
794 const struct srd_decoder_inst *di, const uint8_t *inbuf,
795 uint64_t inbuflen)
b2c19614 796{
d906d3f9 797 PyObject *py_res;
bc5f5a43 798 srd_logic *logic;
86528298 799 uint64_t end_samplenum;
b2c19614 800
7a1712c4 801 srd_dbg("Calling decode() on instance %s with %d bytes starting "
a8b72b05 802 "at sample %d.", di->inst_id, inbuflen, start_samplenum);
b2c19614 803
d906d3f9 804 /* Return an error upon unusable input. */
7a1712c4
UH
805 if (!di) {
806 srd_dbg("empty decoder instance");
d906d3f9
BV
807 return SRD_ERR_ARG;
808 }
7a1712c4
UH
809 if (!inbuf) {
810 srd_dbg("NULL buffer pointer");
d906d3f9
BV
811 return SRD_ERR_ARG;
812 }
813 if (inbuflen == 0) {
7a1712c4 814 srd_dbg("empty buffer");
d906d3f9
BV
815 return SRD_ERR_ARG;
816 }
b2c19614 817
361fdcaa
UH
818 /*
819 * Create new srd_logic object. Each iteration around the PD's loop
d906d3f9
BV
820 * will fill one sample into this object.
821 */
bc5f5a43
BV
822 logic = PyObject_New(srd_logic, &srd_logic_type);
823 Py_INCREF(logic);
abeeed8b 824 logic->di = (struct srd_decoder_inst *)di;
86528298 825 logic->start_samplenum = start_samplenum;
bc5f5a43 826 logic->itercnt = 0;
abeeed8b 827 logic->inbuf = (uint8_t *)inbuf;
bc5f5a43
BV
828 logic->inbuflen = inbuflen;
829 logic->sample = PyList_New(2);
830 Py_INCREF(logic->sample);
831
a8b72b05 832 Py_IncRef(di->py_inst);
f38ec285 833 end_samplenum = start_samplenum + inbuflen / di->data_unitsize;
a8b72b05 834 if (!(py_res = PyObject_CallMethod(di->py_inst, "decode",
c9bfccc6
UH
835 "KKO", logic->start_samplenum,
836 end_samplenum, logic))) {
aafeeaea
UH
837 srd_exception_catch("Protocol decoder instance %s: ",
838 di->inst_id);
0ff2d191 839 return SRD_ERR_PYTHON;
b2c19614 840 }
d906d3f9 841 Py_DecRef(py_res);
bc5f5a43 842
b2c19614
BV
843 return SRD_OK;
844}
845
57790bc8 846/** @private */
12243c22 847SRD_PRIV void srd_inst_free(struct srd_decoder_inst *di)
fa12a21e
BV
848{
849 GSList *l;
850 struct srd_pd_output *pdo;
851
a8b72b05 852 srd_dbg("Freeing instance %s", di->inst_id);
fa12a21e 853
a8b72b05
BV
854 Py_DecRef(di->py_inst);
855 g_free(di->inst_id);
fa12a21e
BV
856 g_free(di->dec_probemap);
857 g_slist_free(di->next_di);
858 for (l = di->pd_output; l; l = l->next) {
859 pdo = l->data;
860 g_free(pdo->proto_id);
861 g_free(pdo);
862 }
863 g_slist_free(di->pd_output);
e592ac89 864 g_free(di);
fa12a21e
BV
865}
866
57790bc8 867/** @private */
32cfb920 868SRD_PRIV void srd_inst_free_all(struct srd_session *sess, GSList *stack)
fa12a21e
BV
869{
870 GSList *l;
a8b72b05 871 struct srd_decoder_inst *di;
fa12a21e 872
32cfb920
BV
873 if (session_is_valid(sess) != SRD_OK) {
874 srd_err("Invalid session.");
875 return;
876 }
877
fa12a21e 878 di = NULL;
32cfb920 879 for (l = stack ? stack : sess->di_list; di == NULL && l != NULL; l = l->next) {
fa12a21e
BV
880 di = l->data;
881 if (di->next_di)
32cfb920 882 srd_inst_free_all(sess, di->next_di);
a8b72b05 883 srd_inst_free(di);
fa12a21e
BV
884 }
885 if (!stack) {
32cfb920
BV
886 g_slist_free(sess->di_list);
887 sess->di_list = NULL;
fa12a21e 888 }
fa12a21e 889}
b2c19614 890
4895418c
UH
891/** @} */
892
893/**
894 * @defgroup grp_session Session handling
895 *
896 * Starting and handling decoding sessions.
897 *
898 * @{
899 */
900
32cfb920
BV
901static int session_is_valid(struct srd_session *sess)
902{
903
904 if (!sess || sess->session_id < 1)
905 return SRD_ERR;
906
907 return SRD_OK;
908}
909
910/**
911 * Create a decoding session.
912 *
913 * A session holds all decoder instances, their stack relationships and
914 * output callbacks.
915 *
916 * @param sess. A pointer which will hold a pointer to a newly
917 * initialized session on return.
918 *
919 * @return SRD_OK upon success, a (negative) error code otherwise.
920 *
921 * @since 0.3.0
922 */
923SRD_API int srd_session_new(struct srd_session **sess)
924{
925
926 if (!sess) {
927 srd_err("Invalid session pointer.");
928 return SRD_ERR;
929 }
930
931 if (!(*sess = g_try_malloc(sizeof(struct srd_session))))
932 return SRD_ERR_MALLOC;
933 (*sess)->session_id = ++max_session_id;
934 (*sess)->num_probes = (*sess)->unitsize = (*sess)->samplerate = 0;
935 (*sess)->di_list = (*sess)->callbacks = NULL;
936
937 /* Keep a list of all sessions, so we can clean up as needed. */
938 sessions = g_slist_append(sessions, *sess);
939
940 srd_dbg("Created session %d.", (*sess)->session_id);
941
942 return SRD_OK;
943}
944
582c8473
BV
945/**
946 * Start a decoding session.
947 *
32cfb920
BV
948 * Decoders, instances and stack must have been prepared beforehand,
949 * and all SRD_CONF parameters set.
582c8473 950 *
32cfb920 951 * @param sess The session to start.
582c8473
BV
952 *
953 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
954 *
955 * @since 0.1.0
582c8473 956 */
32cfb920 957SRD_API int srd_session_start(struct srd_session *sess)
7ce7775c
BV
958{
959 PyObject *args;
2072ae0c 960 GSList *d;
a8b72b05 961 struct srd_decoder_inst *di;
7ce7775c
BV
962 int ret;
963
32cfb920
BV
964 if (session_is_valid(sess) != SRD_OK) {
965 srd_err("Invalid session pointer.");
966 return SRD_ERR;
967 }
968 if (sess->num_probes == 0) {
969 srd_err("Session has invalid number of probes.");
970 return SRD_ERR;
971 }
972 if (sess->unitsize == 0) {
973 srd_err("Session has invalid unitsize.");
974 return SRD_ERR;
975 }
976 if (sess->samplerate == 0) {
977 srd_err("Session has invalid samplerate.");
978 return SRD_ERR;
979 }
980
38ff5046
UH
981 ret = SRD_OK;
982
32cfb920
BV
983 srd_dbg("Calling start() on all instances in session %d with "
984 "%d probes, unitsize %d samplerate %d.", sess->session_id,
985 sess->num_probes, sess->unitsize, sess->samplerate);
d906d3f9 986
361fdcaa
UH
987 /*
988 * Currently only one item of metadata is passed along to decoders,
d906d3f9
BV
989 * samplerate. This can be extended as needed.
990 */
32cfb920 991 if (!(args = Py_BuildValue("{s:l}", "samplerate", (long)sess->samplerate))) {
511e2123 992 srd_err("Unable to build Python object for metadata.");
7ce7775c
BV
993 return SRD_ERR_PYTHON;
994 }
995
996 /* Run the start() method on all decoders receiving frontend data. */
32cfb920 997 for (d = sess->di_list; d; d = d->next) {
7ce7775c 998 di = d->data;
32cfb920
BV
999 di->data_num_probes = sess->num_probes;
1000 di->data_unitsize = sess->unitsize;
1001 di->data_samplerate = sess->samplerate;
38ff5046 1002 if ((ret = srd_inst_start(di, args)) != SRD_OK)
2072ae0c 1003 break;
7ce7775c
BV
1004 }
1005
d906d3f9 1006 Py_DecRef(args);
7ce7775c 1007
2072ae0c 1008 return ret;
7ce7775c
BV
1009}
1010
32cfb920
BV
1011/**
1012 * Set a configuration key in a session.
1013 *
1014 * @param sess The session to configure.
1015 * @param key The configuration key (SRD_CONF_*).
1016 * @param data The new value for the key, as a GVariant with GVariantType
1017 * appropriate to that key. A floating reference can be passed
1018 * in; its refcount will be sunk and unreferenced after use.
1019 *
1020 * @return SRD_OK upon success, a (negative) error code otherwise.
1021 *
1022 * @since 0.3.0
1023 */
1024SRD_API int srd_session_config_set(struct srd_session *sess, int key,
1025 GVariant *data)
1026{
1027
1028 if (session_is_valid(sess) != SRD_OK) {
1029 srd_err("Invalid session.");
1030 return SRD_ERR_ARG;
1031 }
1032
1033 if (!g_variant_is_of_type(data, G_VARIANT_TYPE_UINT64)) {
1034 srd_err("Value for key %d should be of type uint64.");
1035 return SRD_ERR_ARG;
1036 }
1037
1038 switch (key) {
1039 case SRD_CONF_NUM_PROBES:
1040 sess->num_probes = g_variant_get_uint64(data);
1041 break;
1042 case SRD_CONF_UNITSIZE:
1043 sess->unitsize = g_variant_get_uint64(data);
1044 break;
1045 case SRD_CONF_SAMPLERATE:
1046 sess->samplerate = g_variant_get_uint64(data);
1047 break;
1048 }
1049
1050 g_variant_unref(data);
1051
1052 return SRD_OK;
1053}
1054
582c8473 1055/**
29dad0ac 1056 * Send a chunk of logic sample data to a running decoder session.
582c8473 1057 *
32cfb920 1058 * @param sess The session to use.
582c8473
BV
1059 * @param start_samplenum The sample number of the first sample in this chunk.
1060 * @param inbuf Pointer to sample data.
38ff5046 1061 * @param inbuflen Length in bytes of the buffer.
582c8473
BV
1062 *
1063 * @return SRD_OK upon success, a (negative) error code otherwise.
8c664ca2
UH
1064 *
1065 * @since 0.1.0
582c8473 1066 */
32cfb920
BV
1067SRD_API int srd_session_send(struct srd_session *sess, uint64_t start_samplenum,
1068 const uint8_t *inbuf, uint64_t inbuflen)
b2c19614
BV
1069{
1070 GSList *d;
1071 int ret;
1072
32cfb920
BV
1073 if (session_is_valid(sess) != SRD_OK) {
1074 srd_err("Invalid session.");
1075 return SRD_ERR_ARG;
1076 }
1077
7a1712c4 1078 srd_dbg("Calling decode() on all instances with starting sample "
c9bfccc6
UH
1079 "number %" PRIu64 ", %" PRIu64 " bytes at 0x%p",
1080 start_samplenum, inbuflen, inbuf);
d906d3f9 1081
32cfb920 1082 for (d = sess->di_list; d; d = d->next) {
a8b72b05 1083 if ((ret = srd_inst_decode(start_samplenum, d->data, inbuf,
361fdcaa 1084 inbuflen)) != SRD_OK)
b2c19614
BV
1085 return ret;
1086 }
1087
1088 return SRD_OK;
1089}
1090
32cfb920
BV
1091/**
1092 * Destroy a decoding session.
1093 *
1094 * All decoder instances and output callbacks are properly released.
1095 *
1096 * @param sess. The session to be destroyed.
1097 *
1098 * @return SRD_OK upon success, a (negative) error code otherwise.
1099 *
1100 * @since 0.1.0
1101 */
1102SRD_API int srd_session_destroy(struct srd_session *sess)
1103{
1104 int session_id;
1105
1106 session_id = sess->session_id;
1107 if (sess->di_list)
1108 srd_inst_free_all(sess, NULL);
1109 if (sess->callbacks)
1110 g_slist_free_full(sess->callbacks, g_free);
1111 sessions = g_slist_remove(sessions, sess);
1112 g_free(sess);
1113
1114 srd_dbg("Destroyed session %d.", session_id);
1115
1116 return SRD_OK;
1117}
1118
582c8473 1119/**
b33b8aa5 1120 * Register/add a decoder output callback function.
582c8473
BV
1121 *
1122 * The function will be called when a protocol decoder sends output back
1123 * to the PD controller (except for Python objects, which only go up the
1124 * stack).
1125 *
32cfb920 1126 * @param sess The output session in which to register the callback.
582c8473 1127 * @param output_type The output type this callback will receive. Only one
4c1d0670 1128 * callback per output type can be registered.
361fdcaa
UH
1129 * @param cb The function to call. Must not be NULL.
1130 * @param cb_data Private data for the callback function. Can be NULL.
8c664ca2
UH
1131 *
1132 * @since 0.1.0
582c8473 1133 */
32cfb920
BV
1134SRD_API int srd_pd_output_callback_add(struct srd_session *sess,
1135 int output_type, srd_pd_output_callback_t cb, void *cb_data)
4fadb128
BV
1136{
1137 struct srd_pd_callback *pd_cb;
1138
32cfb920
BV
1139 if (session_is_valid(sess) != SRD_OK) {
1140 srd_err("Invalid session.");
1141 return SRD_ERR_ARG;
1142 }
1143
7a1712c4 1144 srd_dbg("Registering new callback for output type %d.", output_type);
4fadb128 1145
a61ece20
UH
1146 if (!(pd_cb = g_try_malloc(sizeof(struct srd_pd_callback)))) {
1147 srd_err("Failed to g_malloc() struct srd_pd_callback.");
4fadb128 1148 return SRD_ERR_MALLOC;
a61ece20 1149 }
4fadb128
BV
1150
1151 pd_cb->output_type = output_type;
4c1d0670 1152 pd_cb->cb = cb;
41a5d962 1153 pd_cb->cb_data = cb_data;
32cfb920 1154 sess->callbacks = g_slist_append(sess->callbacks, pd_cb);
4fadb128
BV
1155
1156 return SRD_OK;
1157}
1158
57790bc8 1159/** @private */
32cfb920
BV
1160SRD_PRIV struct srd_pd_callback *srd_pd_output_callback_find(
1161 struct srd_session *sess, int output_type)
4fadb128
BV
1162{
1163 GSList *l;
2994587f 1164 struct srd_pd_callback *tmp, *pd_cb;
4fadb128 1165
32cfb920
BV
1166 if (session_is_valid(sess) != SRD_OK) {
1167 srd_err("Invalid session.");
1168 return NULL;
1169 }
1170
2994587f 1171 pd_cb = NULL;
32cfb920 1172 for (l = sess->callbacks; l; l = l->next) {
2994587f
BV
1173 tmp = l->data;
1174 if (tmp->output_type == output_type) {
1175 pd_cb = tmp;
4fadb128
BV
1176 break;
1177 }
1178 }
1179
2994587f 1180 return pd_cb;
4fadb128
BV
1181}
1182
511e2123 1183/* This is the backend function to Python sigrokdecode.add() call. */
57790bc8 1184/** @private */
aafeeaea
UH
1185SRD_PRIV int srd_inst_pd_output_add(struct srd_decoder_inst *di,
1186 int output_type, const char *proto_id)
e5080882 1187{
e5080882 1188 struct srd_pd_output *pdo;
e5080882 1189
7a1712c4 1190 srd_dbg("Instance %s creating new output type %d for %s.",
a8b72b05 1191 di->inst_id, output_type, proto_id);
d906d3f9 1192
a61ece20
UH
1193 if (!(pdo = g_try_malloc(sizeof(struct srd_pd_output)))) {
1194 srd_err("Failed to g_malloc() struct srd_pd_output.");
e5080882 1195 return -1;
a61ece20 1196 }
e5080882 1197
b231546d 1198 /* pdo_id is just a simple index, nothing is deleted from this list anyway. */
15969949 1199 pdo->pdo_id = g_slist_length(di->pd_output);
e5080882 1200 pdo->output_type = output_type;
b3b2cae8 1201 pdo->di = di;
94d43b37 1202 pdo->proto_id = g_strdup(proto_id);
e5080882
BV
1203 di->pd_output = g_slist_append(di->pd_output, pdo);
1204
15969949 1205 return pdo->pdo_id;
e5080882 1206}
d7dae84b
UH
1207
1208/** @} */